* s5p-mfc: sparse warnings
@ 2015-05-22 13:55 Hans Verkuil
2015-05-28 10:50 ` Marek Szyprowski
0 siblings, 1 reply; 2+ messages in thread
From: Hans Verkuil @ 2015-05-22 13:55 UTC (permalink / raw)
To: Linux Media Mailing List, Marek Szyprowski, Kamil Debski
Hi Marek, Kamil,
Can someone look at these sparse warnings?
s5p-mfc/s5p_mfc_opr_v5.c:266:23: warning: incorrect type in argument 2 (different address spaces)
s5p-mfc/s5p_mfc_opr_v5.c:274:23: warning: incorrect type in argument 1 (different address spaces)
s5p-mfc/s5p_mfc_opr_v6.c:1855:23: warning: incorrect type in argument 2 (different address spaces)
s5p-mfc/s5p_mfc_opr_v6.c:1865:22: warning: incorrect type in argument 1 (different address spaces)
It all depends on whether this is supposed to be __iomem memory or not.
If it is supposed to be __iomem, then sparse will fail elsewhere (I saw at
least one memset).
Regards,
Hans
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: s5p-mfc: sparse warnings
2015-05-22 13:55 s5p-mfc: sparse warnings Hans Verkuil
@ 2015-05-28 10:50 ` Marek Szyprowski
0 siblings, 0 replies; 2+ messages in thread
From: Marek Szyprowski @ 2015-05-28 10:50 UTC (permalink / raw)
To: Hans Verkuil, Linux Media Mailing List, Kamil Debski
Hello,
On 2015-05-22 15:55, Hans Verkuil wrote:
> Hi Marek, Kamil,
>
> Can someone look at these sparse warnings?
>
> s5p-mfc/s5p_mfc_opr_v5.c:266:23: warning: incorrect type in argument 2 (different address spaces)
> s5p-mfc/s5p_mfc_opr_v5.c:274:23: warning: incorrect type in argument 1 (different address spaces)
> s5p-mfc/s5p_mfc_opr_v6.c:1855:23: warning: incorrect type in argument 2 (different address spaces)
> s5p-mfc/s5p_mfc_opr_v6.c:1865:22: warning: incorrect type in argument 1 (different address spaces)
>
> It all depends on whether this is supposed to be __iomem memory or not.
>
> If it is supposed to be __iomem, then sparse will fail elsewhere (I saw at
> least one memset).
Well, this really looks messy. I will send a fix for it.
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-05-28 10:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-05-22 13:55 s5p-mfc: sparse warnings Hans Verkuil
2015-05-28 10:50 ` Marek Szyprowski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.