Re: [dpdk-dev] [PATCH v6 1/8] cryptodev: introduce cpu crypto support API

[Thomas Monjalon <thomas@monjalon.net>]

04/02/2020 14:12, Marcin Smoczynski:
> +/**
> + * Converts portion of mbuf data into a vector representation.
> + * Each segment will be represented as a separate entry in *vec* array.
> + * Expects that provided *ofs* + *len* not to exceed mbuf's *pkt_len*.
> + * @param mbuf
> + *   Pointer to the *rte_mbuf* object.
> + * @param ofs
> + *   Offset within mbuf data to start with.
> + * @param len
> + *   Length of data to represent.
> + * @return
> + *   - number of successfully filled entries in *vec* array.
> + *   - negative number of elements in *vec* array required.
> + */
> +__rte_experimental
> +static inline int
> +rte_crypto_mbuf_to_vec(const struct rte_mbuf *mb, uint32_t ofs, uint32_t len,
> +	struct rte_crypto_vec vec[], uint32_t num)

The doxygen comment is incomplete. I workaround the miss with this change:

- * @param mbuf
+ * @param mb
  *   Pointer to the *rte_mbuf* object.
  * @param ofs
  *   Offset within mbuf data to start with.
  * @param len
  *   Length of data to represent.
+ * @param vec
+ * @param num

Please complete vec and num descriptions.