* [Buildroot] [PATCH] gcc/gcc-final: pass TARGET_ABI flags to configure with --enable-cxx-flags
@ 2015-05-26 7:32 Max Filippov
2015-05-27 21:45 ` Arnout Vandecappelle
0 siblings, 1 reply; 5+ messages in thread
From: Max Filippov @ 2015-05-26 7:32 UTC (permalink / raw)
To: buildroot
libstdc++ is in all regards a normal library, it needs to be built with
TARGET_ABI flags, otherwise linking it with other C++ code may fail.
Pass TARGET_ABI flags to gcc-final configure script in the
--enable-cxx-flags parameter.
Fixes:
http://autobuild.buildroot.net/results/81a3bca5cbcf789c7ce1aa221a6a4154dd7c3917/
http://autobuild.buildroot.net/results/4943b214c29951ecc7af0a1f360b6454485c0b9b/
Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
---
package/gcc/gcc-final/gcc-final.mk | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/package/gcc/gcc-final/gcc-final.mk b/package/gcc/gcc-final/gcc-final.mk
index d873aa6..8d7009b 100644
--- a/package/gcc/gcc-final/gcc-final.mk
+++ b/package/gcc/gcc-final/gcc-final.mk
@@ -185,4 +185,8 @@ endef
HOST_GCC_FINAL_POST_INSTALL_HOOKS += HOST_GCC_FINAL_INSTALL_USR_LIBS
endif
+ifeq ($(BR2_xtensa),y)
+HOST_GCC_FINAL_CONF_OPTS += --enable-cxx-flags="$(TARGET_ABI)"
+endif
+
$(eval $(host-autotools-package))
--
1.8.1.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] gcc/gcc-final: pass TARGET_ABI flags to configure with --enable-cxx-flags
2015-05-26 7:32 [Buildroot] [PATCH] gcc/gcc-final: pass TARGET_ABI flags to configure with --enable-cxx-flags Max Filippov
@ 2015-05-27 21:45 ` Arnout Vandecappelle
2015-05-28 3:10 ` Max Filippov
0 siblings, 1 reply; 5+ messages in thread
From: Arnout Vandecappelle @ 2015-05-27 21:45 UTC (permalink / raw)
To: buildroot
On 05/26/15 09:32, Max Filippov wrote:
> libstdc++ is in all regards a normal library, it needs to be built with
> TARGET_ABI flags, otherwise linking it with other C++ code may fail.
Then why only do it for xtensa? And why not pass the full TARGET_CFLAGS?
Regards,
Arnout
>
> Pass TARGET_ABI flags to gcc-final configure script in the
> --enable-cxx-flags parameter.
>
> Fixes:
> http://autobuild.buildroot.net/results/81a3bca5cbcf789c7ce1aa221a6a4154dd7c3917/
> http://autobuild.buildroot.net/results/4943b214c29951ecc7af0a1f360b6454485c0b9b/
>
> Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
> ---
> package/gcc/gcc-final/gcc-final.mk | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/package/gcc/gcc-final/gcc-final.mk b/package/gcc/gcc-final/gcc-final.mk
> index d873aa6..8d7009b 100644
> --- a/package/gcc/gcc-final/gcc-final.mk
> +++ b/package/gcc/gcc-final/gcc-final.mk
> @@ -185,4 +185,8 @@ endef
> HOST_GCC_FINAL_POST_INSTALL_HOOKS += HOST_GCC_FINAL_INSTALL_USR_LIBS
> endif
>
> +ifeq ($(BR2_xtensa),y)
> +HOST_GCC_FINAL_CONF_OPTS += --enable-cxx-flags="$(TARGET_ABI)"
> +endif
> +
> $(eval $(host-autotools-package))
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] gcc/gcc-final: pass TARGET_ABI flags to configure with --enable-cxx-flags
2015-05-27 21:45 ` Arnout Vandecappelle
@ 2015-05-28 3:10 ` Max Filippov
2015-05-28 19:24 ` Arnout Vandecappelle
0 siblings, 1 reply; 5+ messages in thread
From: Max Filippov @ 2015-05-28 3:10 UTC (permalink / raw)
To: buildroot
On Thu, May 28, 2015 at 12:45 AM, Arnout Vandecappelle <arnout@mind.be> wrote:
> On 05/26/15 09:32, Max Filippov wrote:
>> libstdc++ is in all regards a normal library, it needs to be built with
>> TARGET_ABI flags, otherwise linking it with other C++ code may fail.
>
> Then why only do it for xtensa? And why not pass the full TARGET_CFLAGS?
To minimize the impact of the change: currently it's only problem for xtensa
and only TARGET_ABI flags are really missing.
Yes, passing TARGET_CFLAGS works too. And probably it works for other
architectures, but that needs testing. I can send v2 with these changes.
--
Thanks.
-- Max
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] gcc/gcc-final: pass TARGET_ABI flags to configure with --enable-cxx-flags
2015-05-28 3:10 ` Max Filippov
@ 2015-05-28 19:24 ` Arnout Vandecappelle
2015-05-31 20:52 ` Peter Korsgaard
0 siblings, 1 reply; 5+ messages in thread
From: Arnout Vandecappelle @ 2015-05-28 19:24 UTC (permalink / raw)
To: buildroot
On 05/28/15 05:10, Max Filippov wrote:
> On Thu, May 28, 2015 at 12:45 AM, Arnout Vandecappelle <arnout@mind.be> wrote:
>> On 05/26/15 09:32, Max Filippov wrote:
>>> libstdc++ is in all regards a normal library, it needs to be built with
>>> TARGET_ABI flags, otherwise linking it with other C++ code may fail.
>>
>> Then why only do it for xtensa? And why not pass the full TARGET_CFLAGS?
>
> To minimize the impact of the change: currently it's only problem for xtensa
> and only TARGET_ABI flags are really missing.
> Yes, passing TARGET_CFLAGS works too. And probably it works for other
> architectures, but that needs testing. I can send v2 with these changes.
I guess we need this patch for 2015.05 then and TARGET_CFLAGS for -next.
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] gcc/gcc-final: pass TARGET_ABI flags to configure with --enable-cxx-flags
2015-05-28 19:24 ` Arnout Vandecappelle
@ 2015-05-31 20:52 ` Peter Korsgaard
0 siblings, 0 replies; 5+ messages in thread
From: Peter Korsgaard @ 2015-05-31 20:52 UTC (permalink / raw)
To: buildroot
>>>>> "Arnout" == Arnout Vandecappelle <arnout@mind.be> writes:
> On 05/28/15 05:10, Max Filippov wrote:
>> On Thu, May 28, 2015 at 12:45 AM, Arnout Vandecappelle <arnout@mind.be> wrote:
>>> On 05/26/15 09:32, Max Filippov wrote:
>>>> libstdc++ is in all regards a normal library, it needs to be built with
>>>> TARGET_ABI flags, otherwise linking it with other C++ code may fail.
>>>
>>> Then why only do it for xtensa? And why not pass the full TARGET_CFLAGS?
>>
>> To minimize the impact of the change: currently it's only problem for xtensa
>> and only TARGET_ABI flags are really missing.
>> Yes, passing TARGET_CFLAGS works too. And probably it works for other
>> architectures, but that needs testing. I can send v2 with these changes.
> I guess we need this patch for 2015.05 then and TARGET_CFLAGS for -next.
Agreed. I've committed this one for 2015.05 - Thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-05-31 20:52 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-05-26 7:32 [Buildroot] [PATCH] gcc/gcc-final: pass TARGET_ABI flags to configure with --enable-cxx-flags Max Filippov
2015-05-27 21:45 ` Arnout Vandecappelle
2015-05-28 3:10 ` Max Filippov
2015-05-28 19:24 ` Arnout Vandecappelle
2015-05-31 20:52 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.