[PATCH] phy: tusb1210: Use devm_gpiod_get_optional for optional GPIOs

[PATCH] phy: tusb1210: Use devm_gpiod_get_optional for optional GPIOs

[Axel Lin]

Also simplify the code a bit by specify direction and initial value for
output in devm_gpiod_get_optional function.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
 drivers/phy/phy-tusb1210.c | 28 ++++++++++------------------
 1 file changed, 10 insertions(+), 18 deletions(-)

diff --git a/drivers/phy/phy-tusb1210.c b/drivers/phy/phy-tusb1210.c
index 07efdd3..e0174da 100644
--- a/drivers/phy/phy-tusb1210.c
+++ b/drivers/phy/phy-tusb1210.c
@@ -61,32 +61,24 @@ static struct phy_ops phy_ops = {
 
 static int tusb1210_probe(struct ulpi *ulpi)
 {
-	struct gpio_desc *gpio;
 	struct tusb1210 *tusb;
 	u8 val, reg;
-	int ret;
 
 	tusb = devm_kzalloc(&ulpi->dev, sizeof(*tusb), GFP_KERNEL);
 	if (!tusb)
 		return -ENOMEM;
 
-	gpio = devm_gpiod_get(&ulpi->dev, "reset");
-	if (!IS_ERR(gpio)) {
-		ret = gpiod_direction_output(gpio, 0);
-		if (ret)
-			return ret;
-		gpiod_set_value_cansleep(gpio, 1);
-		tusb->gpio_reset = gpio;
-	}
+	tusb->gpio_reset = devm_gpiod_get_optional(&ulpi->dev, "reset",
+						   GPIOD_OUT_LOW);
+	if (IS_ERR(tusb->gpio_reset))
+		return PTR_ERR(tusb->gpio_reset);
+	gpiod_set_value_cansleep(tusb->gpio_reset, 1);
 
-	gpio = devm_gpiod_get(&ulpi->dev, "cs");
-	if (!IS_ERR(gpio)) {
-		ret = gpiod_direction_output(gpio, 0);
-		if (ret)
-			return ret;
-		gpiod_set_value_cansleep(gpio, 1);
-		tusb->gpio_cs = gpio;
-	}
+	tusb->gpio_cs = devm_gpiod_get_optional(&ulpi->dev, "cs",
+						GPIOD_OUT_LOW);
+	if (IS_ERR(tusb->gpio_cs))
+		return PTR_ERR(tusb->gpio_cs);
+	gpiod_set_value_cansleep(tusb->gpio_cs, 1);
 
 	/*
 	 * VENDOR_SPECIFIC2 register in TUSB1210 can be used for configuring eye
-- 
2.1.0

Re: [PATCH] phy: tusb1210: Use devm_gpiod_get_optional for optional GPIOs

[Heikki Krogerus]

On Mon, Jun 01, 2015 at 10:00:31AM +0800, Axel Lin wrote:
> Also simplify the code a bit by specify direction and initial value for
> output in devm_gpiod_get_optional function.
> 
> Signed-off-by: Axel Lin <axel.lin@ingics.com>

Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>


Thanks,

-- 
heikki

Re: [PATCH] phy: tusb1210: Use devm_gpiod_get_optional for optional GPIOs

[Kishon Vijay Abraham I]

On Monday 01 June 2015 01:34 PM, Heikki Krogerus wrote:
> On Mon, Jun 01, 2015 at 10:00:31AM +0800, Axel Lin wrote:
>> Also simplify the code a bit by specify direction and initial value for
>> output in devm_gpiod_get_optional function.
>>
>> Signed-off-by: Axel Lin <axel.lin@ingics.com>
>
> Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Acked-by: Kishon Vijay Abraham I <kishon@ti.com>
>
>
> Thanks,
>