* [Qemu-devel] [PATCH V1] cadence_gem: Fix Rx buffer size field mask
@ 2015-05-29 6:22 Sai Pavan Boddu
2015-06-01 2:51 ` Peter Crosthwaite
0 siblings, 1 reply; 3+ messages in thread
From: Sai Pavan Boddu @ 2015-05-29 6:22 UTC (permalink / raw)
To: qemu-devel; +Cc: Sai Pavan Boddu, edgari, alistai, pcrost
This patch corrects the Rx buffer size field mask to mask bits 23 to 16
Signed-off-by: Sai Pavan Boddu <saipava@xilinx.com>
Reviewed-by: Alistair Francis <alistair.francis@xilinx.com>
---
hw/net/cadence_gem.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/net/cadence_gem.c b/hw/net/cadence_gem.c
index dafe914..494a346 100644
--- a/hw/net/cadence_gem.c
+++ b/hw/net/cadence_gem.c
@@ -155,7 +155,7 @@
#define GEM_NWCFG_BCAST_REJ 0x00000020 /* Reject broadcast packets */
#define GEM_NWCFG_PROMISC 0x00000010 /* Accept all packets */
-#define GEM_DMACFG_RBUFSZ_M 0x007F0000 /* DMA RX Buffer Size mask */
+#define GEM_DMACFG_RBUFSZ_M 0x00FF0000 /* DMA RX Buffer Size mask */
#define GEM_DMACFG_RBUFSZ_S 16 /* DMA RX Buffer Size shift */
#define GEM_DMACFG_RBUFSZ_MUL 64 /* DMA RX Buffer Size multiplier */
#define GEM_DMACFG_TXCSUM_OFFL 0x00000800 /* Transmit checksum offload */
--
1.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH V1] cadence_gem: Fix Rx buffer size field mask
2015-05-29 6:22 [Qemu-devel] [PATCH V1] cadence_gem: Fix Rx buffer size field mask Sai Pavan Boddu
@ 2015-06-01 2:51 ` Peter Crosthwaite
2015-06-02 8:32 ` Michael Tokarev
0 siblings, 1 reply; 3+ messages in thread
From: Peter Crosthwaite @ 2015-06-01 2:51 UTC (permalink / raw)
To: Sai Pavan Boddu, qemu-trivial
Cc: Sai Pavan Boddu, Edgar Iglesias, alistai,
qemu-devel@nongnu.org Developers, Peter Crosthwaite
On Thu, May 28, 2015 at 11:22 PM, Sai Pavan Boddu
<sai.pavan.boddu@xilinx.com> wrote:
> This patch corrects the Rx buffer size field mask to mask bits 23 to 16
>
> Signed-off-by: Sai Pavan Boddu <saipava@xilinx.com>
> Reviewed-by: Alistair Francis <alistair.francis@xilinx.com>
Matches Xilinx UG585 documentation.
Reviewed-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Can this go via the trivial queue?
Regards,
Peter
> ---
> hw/net/cadence_gem.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/hw/net/cadence_gem.c b/hw/net/cadence_gem.c
> index dafe914..494a346 100644
> --- a/hw/net/cadence_gem.c
> +++ b/hw/net/cadence_gem.c
> @@ -155,7 +155,7 @@
> #define GEM_NWCFG_BCAST_REJ 0x00000020 /* Reject broadcast packets */
> #define GEM_NWCFG_PROMISC 0x00000010 /* Accept all packets */
>
> -#define GEM_DMACFG_RBUFSZ_M 0x007F0000 /* DMA RX Buffer Size mask */
> +#define GEM_DMACFG_RBUFSZ_M 0x00FF0000 /* DMA RX Buffer Size mask */
> #define GEM_DMACFG_RBUFSZ_S 16 /* DMA RX Buffer Size shift */
> #define GEM_DMACFG_RBUFSZ_MUL 64 /* DMA RX Buffer Size multiplier */
> #define GEM_DMACFG_TXCSUM_OFFL 0x00000800 /* Transmit checksum offload */
> --
> 1.7.4
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH V1] cadence_gem: Fix Rx buffer size field mask
2015-06-01 2:51 ` Peter Crosthwaite
@ 2015-06-02 8:32 ` Michael Tokarev
0 siblings, 0 replies; 3+ messages in thread
From: Michael Tokarev @ 2015-06-02 8:32 UTC (permalink / raw)
To: Peter Crosthwaite, Sai Pavan Boddu, qemu-trivial
Cc: Sai Pavan Boddu, Edgar Iglesias, alistai,
qemu-devel@nongnu.org Developers, Peter Crosthwaite
01.06.2015 05:51, Peter Crosthwaite wrote:
> On Thu, May 28, 2015 at 11:22 PM, Sai Pavan Boddu
> <sai.pavan.boddu@xilinx.com> wrote:
>> This patch corrects the Rx buffer size field mask to mask bits 23 to 16
>>
>> Signed-off-by: Sai Pavan Boddu <saipava@xilinx.com>
>> Reviewed-by: Alistair Francis <alistair.francis@xilinx.com>
>
> Matches Xilinx UG585 documentation.
>
> Reviewed-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
>
> Can this go via the trivial queue?
Applied to -trivial, with tiny comment change (combining
the two comments, by Sai Pavan Boddy and Peter Crosthwaite,
together).
Thanks,
/mjt
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-06-02 8:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-05-29 6:22 [Qemu-devel] [PATCH V1] cadence_gem: Fix Rx buffer size field mask Sai Pavan Boddu
2015-06-01 2:51 ` Peter Crosthwaite
2015-06-02 8:32 ` Michael Tokarev
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.