Re: [PATCH] nested EPT: fix the handling of nested EPT.

Re: [PATCH] nested EPT: fix the handling of nested EPT.

[Jan Beulich]

>>> On 02.06.15 at 19:41, <liang.z.li@intel.com> wrote:
> @@ -1074,6 +1075,9 @@ void ept_sync_domain(struct p2m_domain *p2m)
>      if ( !paging_mode_hap(d) || !d->vcpu || !d->vcpu[0] )
>          return;
>  
> +    if ( nestedhvm_enabled(d) )
> +        p2m_flush_nestedp2m(d);
> +
>      ASSERT(local_irq_is_enabled());
>  
>      /*

Looks plausible, but I think the addition would better go after the
ASSERT().

Jan

[PATCH] nested EPT: fix the handling of nested EPT.

[Liang Li]

If the host EPT entry is changed, the nested EPT should be updated.
The current code does not do this, and it's wrong.

Reported-by: Tim Deegan <tim@xen.org>
Signed-off-by: Liang Li <liang.z.li@intel.com>
Signed-off-by: Yang Zhang <yang.z.zhang@intel.com>
---
 xen/arch/x86/mm/p2m-ept.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/xen/arch/x86/mm/p2m-ept.c b/xen/arch/x86/mm/p2m-ept.c
index 5133eb6..a8ee949 100644
--- a/xen/arch/x86/mm/p2m-ept.c
+++ b/xen/arch/x86/mm/p2m-ept.c
@@ -26,6 +26,7 @@
 #include <asm/p2m.h>
 #include <asm/hvm/vmx/vmx.h>
 #include <asm/hvm/vmx/vmcs.h>
+#include <asm/hvm/nestedhvm.h>
 #include <xen/iommu.h>
 #include <asm/mtrr.h>
 #include <asm/hvm/cacheattr.h>
@@ -1074,6 +1075,9 @@ void ept_sync_domain(struct p2m_domain *p2m)
     if ( !paging_mode_hap(d) || !d->vcpu || !d->vcpu[0] )
         return;
 
+    if ( nestedhvm_enabled(d) )
+        p2m_flush_nestedp2m(d);
+
     ASSERT(local_irq_is_enabled());
 
     /*
-- 
1.9.1