All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 2/2] staging : wilc1000 : remove UWORD32
@ 2015-06-03  1:17 chaehyun lim
  2015-06-03  7:14 ` walter harms
  0 siblings, 1 reply; 2+ messages in thread
From: chaehyun lim @ 2015-06-03  1:17 UTC (permalink / raw)
  To: kernel-janitors

Use u32 instead of UWORD32

Signed-off-by: chaehyun lim <chaehyun.lim@gmail.com>
---
 drivers/staging/wilc1000/coreconfigurator.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/wilc1000/coreconfigurator.c b/drivers/staging/wilc1000/coreconfigurator.c
index 958cf0b..0dc4413 100644
--- a/drivers/staging/wilc1000/coreconfigurator.c
+++ b/drivers/staging/wilc1000/coreconfigurator.c
@@ -498,10 +498,10 @@ INLINE WILC_Uint32 get_beacon_timestamp_lo(WILC_Uint8 *data)
 	return time_stamp;
 }
 
-INLINE UWORD32 get_beacon_timestamp_hi(u8 *data)
+INLINE u32 get_beacon_timestamp_hi(u8 *data)
 {
-	UWORD32 time_stamp = 0;
-	UWORD32 index    = (MAC_HDR_LEN + 4);
+	u32 time_stamp = 0;
+	u32 index    = (MAC_HDR_LEN + 4);
 
 	time_stamp |= data[index++];
 	time_stamp |= (data[index++] << 8);
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH 2/2] staging : wilc1000 : remove UWORD32
  2015-06-03  1:17 [PATCH 2/2] staging : wilc1000 : remove UWORD32 chaehyun lim
@ 2015-06-03  7:14 ` walter harms
  0 siblings, 0 replies; 2+ messages in thread
From: walter harms @ 2015-06-03  7:14 UTC (permalink / raw)
  To: kernel-janitors


hi,
some remark for you patch:

1. where is the definition of UWORD32 ?
2. can it be removed also ?

hope that helps,
re,
 wh


Am 03.06.2015 03:17, schrieb chaehyun lim:
> Use u32 instead of UWORD32
> 
> Signed-off-by: chaehyun lim <chaehyun.lim@gmail.com>
> ---
>  drivers/staging/wilc1000/coreconfigurator.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/wilc1000/coreconfigurator.c b/drivers/staging/wilc1000/coreconfigurator.c
> index 958cf0b..0dc4413 100644
> --- a/drivers/staging/wilc1000/coreconfigurator.c
> +++ b/drivers/staging/wilc1000/coreconfigurator.c
> @@ -498,10 +498,10 @@ INLINE WILC_Uint32 get_beacon_timestamp_lo(WILC_Uint8 *data)
>  	return time_stamp;
>  }
>  
> -INLINE UWORD32 get_beacon_timestamp_hi(u8 *data)
> +INLINE u32 get_beacon_timestamp_hi(u8 *data)
>  {
> -	UWORD32 time_stamp = 0;
> -	UWORD32 index    = (MAC_HDR_LEN + 4);
> +	u32 time_stamp = 0;
> +	u32 index    = (MAC_HDR_LEN + 4);
>  
>  	time_stamp |= data[index++];
>  	time_stamp |= (data[index++] << 8);

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-06-03  7:14 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-06-03  1:17 [PATCH 2/2] staging : wilc1000 : remove UWORD32 chaehyun lim
2015-06-03  7:14 ` walter harms

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.