* [PATCH v2] Bluetooth: hci_bcm: Correct context of IRQ polarity message
@ 2017-10-07 6:16 Ian W MORRISON
2017-10-09 13:52 ` Hans de Goede
2017-10-09 18:04 ` Marcel Holtmann
0 siblings, 2 replies; 3+ messages in thread
From: Ian W MORRISON @ 2017-10-07 6:16 UTC (permalink / raw)
To: marcel, gustavo, johan.hedberg,
bluez mailin list (linux-bluetooth@vger.kernel.org)
Cc: hdegoede, frederic.danis.oss
As the overwriting of IRQ polarity to active low occurs during the driver probe using 'bt_dev_warn' to display the warning results in '(null)' being displayed for the device. This patch uses 'dev_warn' to correctly display the device in the warning instead.
Signed-off-by: ianwmorrison <ianwmorrison@gmail.com>
---
v2: Uses 'dev_warn' (Suggested-by: Marcel Holtmann <marcel@holtmann.org>)
Testing shows the following improvements using an extract from dmesg of the affected message:
Without patch:
[ 5.512175] Bluetooth: (null): MINIX Z83-4: Overwriting IRQ polarity to active low
v1 (superseded) patch:
[ 5.592238] Bluetooth: MINIX Z83-4: Overwriting IRQ polarity to active low
v2 patch (with a kernel excluding serdev ACPI support patches):
[ 6.112265] hci_bcm BCM2EA4:00: MINIX Z83-4: Overwriting IRQ polarity to active low
v2 patch (with a kernel including serdev ACPI support patches):
[ 6.367829] hci_uart_bcm serial1-0: MINIX Z83-4: Overwriting IRQ polarity to active low
---
drivers/bluetooth/hci_bcm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/bluetooth/hci_bcm.c b/drivers/bluetooth/hci_bcm.c
index 77326eeb6146..16c2eaaaf72b 100644
--- a/drivers/bluetooth/hci_bcm.c
+++ b/drivers/bluetooth/hci_bcm.c
@@ -839,7 +839,7 @@ static int bcm_acpi_probe(struct bcm_device *dev)
dmi_id = dmi_first_match(bcm_active_low_irq_dmi_table);
if (dmi_id) {
- bt_dev_warn(dev, "%s: Overwriting IRQ polarity to active low",
+ dev_warn(dev->dev, "%s: Overwriting IRQ polarity to active low",
dmi_id->ident);
dev->irq_active_low = true;
}
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] Bluetooth: hci_bcm: Correct context of IRQ polarity message
2017-10-07 6:16 [PATCH v2] Bluetooth: hci_bcm: Correct context of IRQ polarity message Ian W MORRISON
@ 2017-10-09 13:52 ` Hans de Goede
2017-10-09 18:04 ` Marcel Holtmann
1 sibling, 0 replies; 3+ messages in thread
From: Hans de Goede @ 2017-10-09 13:52 UTC (permalink / raw)
To: Ian W MORRISON, marcel, gustavo, johan.hedberg,
bluez mailin list (linux-bluetooth@vger.kernel.org)
Cc: frederic.danis.oss
Hi,
On 07-10-17 08:16, Ian W MORRISON wrote:
> As the overwriting of IRQ polarity to active low occurs during the driver probe using 'bt_dev_warn' to display the warning results in '(null)' being displayed for the device. This patch uses 'dev_warn' to correctly display the device in the warning instead.
>
> Signed-off-by: ianwmorrison <ianwmorrison@gmail.com>
> ---
> v2: Uses 'dev_warn' (Suggested-by: Marcel Holtmann <marcel@holtmann.org>)
>
> Testing shows the following improvements using an extract from dmesg of the affected message:
>
> Without patch:
> [ 5.512175] Bluetooth: (null): MINIX Z83-4: Overwriting IRQ polarity to active low
>
> v1 (superseded) patch:
> [ 5.592238] Bluetooth: MINIX Z83-4: Overwriting IRQ polarity to active low
>
> v2 patch (with a kernel excluding serdev ACPI support patches):
> [ 6.112265] hci_bcm BCM2EA4:00: MINIX Z83-4: Overwriting IRQ polarity to active low
>
> v2 patch (with a kernel including serdev ACPI support patches):
> [ 6.367829] hci_uart_bcm serial1-0: MINIX Z83-4: Overwriting IRQ polarity to active low
> ---
Patch looks good to me:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
> drivers/bluetooth/hci_bcm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/bluetooth/hci_bcm.c b/drivers/bluetooth/hci_bcm.c
> index 77326eeb6146..16c2eaaaf72b 100644
> --- a/drivers/bluetooth/hci_bcm.c
> +++ b/drivers/bluetooth/hci_bcm.c
> @@ -839,7 +839,7 @@ static int bcm_acpi_probe(struct bcm_device *dev)
>
> dmi_id = dmi_first_match(bcm_active_low_irq_dmi_table);
> if (dmi_id) {
> - bt_dev_warn(dev, "%s: Overwriting IRQ polarity to active low",
> + dev_warn(dev->dev, "%s: Overwriting IRQ polarity to active low",
> dmi_id->ident);
> dev->irq_active_low = true;
> }
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] Bluetooth: hci_bcm: Correct context of IRQ polarity message
2017-10-07 6:16 [PATCH v2] Bluetooth: hci_bcm: Correct context of IRQ polarity message Ian W MORRISON
2017-10-09 13:52 ` Hans de Goede
@ 2017-10-09 18:04 ` Marcel Holtmann
1 sibling, 0 replies; 3+ messages in thread
From: Marcel Holtmann @ 2017-10-09 18:04 UTC (permalink / raw)
To: Ian W MORRISON
Cc: Gustavo F. Padovan, Johan Hedberg,
bluez mailin list (linux-bluetooth@vger.kernel.org),
hdegoede, frederic.danis.oss
Hi Ian,
> As the overwriting of IRQ polarity to active low occurs during the driver probe using 'bt_dev_warn' to display the warning results in '(null)' being displayed for the device. This patch uses 'dev_warn' to correctly display the device in the warning instead.
>
> Signed-off-by: ianwmorrison <ianwmorrison@gmail.com>
> ---
> v2: Uses 'dev_warn' (Suggested-by: Marcel Holtmann <marcel@holtmann.org>)
>
> Testing shows the following improvements using an extract from dmesg of the affected message:
>
> Without patch:
> [ 5.512175] Bluetooth: (null): MINIX Z83-4: Overwriting IRQ polarity to active low
>
> v1 (superseded) patch:
> [ 5.592238] Bluetooth: MINIX Z83-4: Overwriting IRQ polarity to active low
>
> v2 patch (with a kernel excluding serdev ACPI support patches):
> [ 6.112265] hci_bcm BCM2EA4:00: MINIX Z83-4: Overwriting IRQ polarity to active low
>
> v2 patch (with a kernel including serdev ACPI support patches):
> [ 6.367829] hci_uart_bcm serial1-0: MINIX Z83-4: Overwriting IRQ polarity to active low
> ---
> drivers/bluetooth/hci_bcm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
patch has been applied to bluetooth-next tree.
Regards
Marcel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-10-09 18:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-07 6:16 [PATCH v2] Bluetooth: hci_bcm: Correct context of IRQ polarity message Ian W MORRISON
2017-10-09 13:52 ` Hans de Goede
2017-10-09 18:04 ` Marcel Holtmann
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.