* [Qemu-devel] [PATCH v2] memory_mapping: Rework cpu related includes
@ 2015-06-07 21:59 Peter Crosthwaite
2015-06-08 10:47 ` Paolo Bonzini
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Peter Crosthwaite @ 2015-06-07 21:59 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, pbonzini, Peter Crosthwaite
This makes it more consistent with all other core code files, which
either just rely on qemu-common.h inclusion or precede cpu.h with
qemu-common.h.
cpu-all.h should not be included in addition to cpu.h. Remove it.
Signed-off-by: Peter Crosthwaite <crosthwaite.peter@gmail.com>
---
changed since v1:
Leave in cpu.h include
Picked up by my multi arch WIP where target-multi/cpu.h cant handle
random core code inclusion without preceeded qemu-common.h. I guess
this is the only one in tree?
---
memory_mapping.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/memory_mapping.c b/memory_mapping.c
index 7b69801..36d6b26 100644
--- a/memory_mapping.c
+++ b/memory_mapping.c
@@ -13,8 +13,8 @@
#include <glib.h>
+#include "qemu-common.h"
#include "cpu.h"
-#include "exec/cpu-all.h"
#include "sysemu/memory_mapping.h"
#include "exec/memory.h"
#include "exec/address-spaces.h"
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH v2] memory_mapping: Rework cpu related includes
2015-06-07 21:59 [Qemu-devel] [PATCH v2] memory_mapping: Rework cpu related includes Peter Crosthwaite
@ 2015-06-08 10:47 ` Paolo Bonzini
2015-06-09 7:42 ` Peter Crosthwaite
2015-06-24 4:33 ` Peter Crosthwaite
2015-06-24 8:54 ` Paolo Bonzini
2 siblings, 1 reply; 6+ messages in thread
From: Paolo Bonzini @ 2015-06-08 10:47 UTC (permalink / raw)
To: Peter Crosthwaite, qemu-devel; +Cc: qemu-trivial, Peter Crosthwaite
On 07/06/2015 23:59, Peter Crosthwaite wrote:
> This makes it more consistent with all other core code files, which
> either just rely on qemu-common.h inclusion or precede cpu.h with
> qemu-common.h.
>
> cpu-all.h should not be included in addition to cpu.h. Remove it.
>
> Signed-off-by: Peter Crosthwaite <crosthwaite.peter@gmail.com>
> ---
> changed since v1:
> Leave in cpu.h include
>
> Picked up by my multi arch WIP where target-multi/cpu.h cant handle
> random core code inclusion without preceeded qemu-common.h. I guess
> this is the only one in tree?
> ---
> memory_mapping.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/memory_mapping.c b/memory_mapping.c
> index 7b69801..36d6b26 100644
> --- a/memory_mapping.c
> +++ b/memory_mapping.c
> @@ -13,8 +13,8 @@
>
> #include <glib.h>
>
> +#include "qemu-common.h"
> #include "cpu.h"
> -#include "exec/cpu-all.h"
> #include "sysemu/memory_mapping.h"
> #include "exec/memory.h"
> #include "exec/address-spaces.h"
>
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
About to leave on vacation, so someone else will have to pick it up.
Paolo
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH v2] memory_mapping: Rework cpu related includes
2015-06-08 10:47 ` Paolo Bonzini
@ 2015-06-09 7:42 ` Peter Crosthwaite
2015-06-17 8:57 ` Paolo Bonzini
0 siblings, 1 reply; 6+ messages in thread
From: Peter Crosthwaite @ 2015-06-09 7:42 UTC (permalink / raw)
To: Paolo Bonzini, Peter Maydell, Richard Henderson
Cc: qemu-trivial, Peter Crosthwaite,
qemu-devel@nongnu.org Developers, Peter Crosthwaite
On Mon, Jun 8, 2015 at 3:47 AM, Paolo Bonzini <pbonzini@redhat.com> wrote:
>
>
> On 07/06/2015 23:59, Peter Crosthwaite wrote:
>> This makes it more consistent with all other core code files, which
>> either just rely on qemu-common.h inclusion or precede cpu.h with
>> qemu-common.h.
>>
>> cpu-all.h should not be included in addition to cpu.h. Remove it.
>>
>> Signed-off-by: Peter Crosthwaite <crosthwaite.peter@gmail.com>
>> ---
>> changed since v1:
>> Leave in cpu.h include
>>
>> Picked up by my multi arch WIP where target-multi/cpu.h cant handle
>> random core code inclusion without preceeded qemu-common.h. I guess
>> this is the only one in tree?
>> ---
>> memory_mapping.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/memory_mapping.c b/memory_mapping.c
>> index 7b69801..36d6b26 100644
>> --- a/memory_mapping.c
>> +++ b/memory_mapping.c
>> @@ -13,8 +13,8 @@
>>
>> #include <glib.h>
>>
>> +#include "qemu-common.h"
>> #include "cpu.h"
>> -#include "exec/cpu-all.h"
>> #include "sysemu/memory_mapping.h"
>> #include "exec/memory.h"
>> #include "exec/address-spaces.h"
>>
>
> Acked-by: Paolo Bonzini <pbonzini@redhat.com>
>
> About to leave on vacation, so someone else will have to pick it up.
>
Enjoy. If you are not back before soft freeze would you object to me
sending a [PULL] for some of the multi-arch related mainloop header
patches for which I have RB from Richard from?
Regards,
Peter
> Paolo
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH v2] memory_mapping: Rework cpu related includes
2015-06-09 7:42 ` Peter Crosthwaite
@ 2015-06-17 8:57 ` Paolo Bonzini
0 siblings, 0 replies; 6+ messages in thread
From: Paolo Bonzini @ 2015-06-17 8:57 UTC (permalink / raw)
To: Peter Crosthwaite, Peter Maydell, Richard Henderson
Cc: qemu-trivial, Peter Crosthwaite,
qemu-devel@nongnu.org Developers, Peter Crosthwaite
On 09/06/2015 09:42, Peter Crosthwaite wrote:
> > Acked-by: Paolo Bonzini <pbonzini@redhat.com>
> >
> > About to leave on vacation, so someone else will have to pick it up.
>
> Enjoy. If you are not back before soft freeze would you object to me
> sending a [PULL] for some of the multi-arch related mainloop header
> patches for which I have RB from Richard from?
I don't object to you sending a pull request for any multi-arch related
changes. Anything that makes fewer patches go through my "misc" pull
requests is a good thing for me.
Just consult with Andreas when he's back about what he prefers to go
through his tree.
Paolo
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH v2] memory_mapping: Rework cpu related includes
2015-06-07 21:59 [Qemu-devel] [PATCH v2] memory_mapping: Rework cpu related includes Peter Crosthwaite
2015-06-08 10:47 ` Paolo Bonzini
@ 2015-06-24 4:33 ` Peter Crosthwaite
2015-06-24 8:54 ` Paolo Bonzini
2 siblings, 0 replies; 6+ messages in thread
From: Peter Crosthwaite @ 2015-06-24 4:33 UTC (permalink / raw)
To: Peter Crosthwaite
Cc: qemu-trivial, Paolo Bonzini, qemu-devel@nongnu.org Developers,
Peter Crosthwaite
Ping!
On Sun, Jun 7, 2015 at 2:59 PM, Peter Crosthwaite
<crosthwaitepeter@gmail.com> wrote:
> This makes it more consistent with all other core code files, which
> either just rely on qemu-common.h inclusion or precede cpu.h with
> qemu-common.h.
>
> cpu-all.h should not be included in addition to cpu.h. Remove it.
>
> Signed-off-by: Peter Crosthwaite <crosthwaite.peter@gmail.com>
> ---
> changed since v1:
> Leave in cpu.h include
>
> Picked up by my multi arch WIP where target-multi/cpu.h cant handle
> random core code inclusion without preceeded qemu-common.h. I guess
> this is the only one in tree?
> ---
> memory_mapping.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/memory_mapping.c b/memory_mapping.c
> index 7b69801..36d6b26 100644
> --- a/memory_mapping.c
> +++ b/memory_mapping.c
> @@ -13,8 +13,8 @@
>
> #include <glib.h>
>
> +#include "qemu-common.h"
> #include "cpu.h"
> -#include "exec/cpu-all.h"
> #include "sysemu/memory_mapping.h"
> #include "exec/memory.h"
> #include "exec/address-spaces.h"
> --
> 1.9.1
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH v2] memory_mapping: Rework cpu related includes
2015-06-07 21:59 [Qemu-devel] [PATCH v2] memory_mapping: Rework cpu related includes Peter Crosthwaite
2015-06-08 10:47 ` Paolo Bonzini
2015-06-24 4:33 ` Peter Crosthwaite
@ 2015-06-24 8:54 ` Paolo Bonzini
2 siblings, 0 replies; 6+ messages in thread
From: Paolo Bonzini @ 2015-06-24 8:54 UTC (permalink / raw)
To: Peter Crosthwaite, qemu-devel; +Cc: qemu-trivial, Peter Crosthwaite
On 07/06/2015 23:59, Peter Crosthwaite wrote:
> This makes it more consistent with all other core code files, which
> either just rely on qemu-common.h inclusion or precede cpu.h with
> qemu-common.h.
>
> cpu-all.h should not be included in addition to cpu.h. Remove it.
>
> Signed-off-by: Peter Crosthwaite <crosthwaite.peter@gmail.com>
Applied, will send a pull request today or tomorrow.
Paolo
> ---
> changed since v1:
> Leave in cpu.h include
>
> Picked up by my multi arch WIP where target-multi/cpu.h cant handle
> random core code inclusion without preceeded qemu-common.h. I guess
> this is the only one in tree?
> ---
> memory_mapping.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/memory_mapping.c b/memory_mapping.c
> index 7b69801..36d6b26 100644
> --- a/memory_mapping.c
> +++ b/memory_mapping.c
> @@ -13,8 +13,8 @@
>
> #include <glib.h>
>
> +#include "qemu-common.h"
> #include "cpu.h"
> -#include "exec/cpu-all.h"
> #include "sysemu/memory_mapping.h"
> #include "exec/memory.h"
> #include "exec/address-spaces.h"
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-06-24 8:54 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-06-07 21:59 [Qemu-devel] [PATCH v2] memory_mapping: Rework cpu related includes Peter Crosthwaite
2015-06-08 10:47 ` Paolo Bonzini
2015-06-09 7:42 ` Peter Crosthwaite
2015-06-17 8:57 ` Paolo Bonzini
2015-06-24 4:33 ` Peter Crosthwaite
2015-06-24 8:54 ` Paolo Bonzini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.