All of lore.kernel.org
 help / color / mirror / Atom feed
* [patch] drm/amdgpu: remove an unnecessary condition
@ 2015-06-11  8:19 ` Dan Carpenter
  0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2015-06-11  8:19 UTC (permalink / raw)
  To: David Airlie, Alex Deucher
  Cc: Marek Olšák, kernel-janitors, dri-devel, yanyang1,
	Ken Wang, Christian König

We already checked "if (r)" so there is no need to check again.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c
index 5533434..b7d0425 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c
@@ -111,12 +111,9 @@ int amdgpu_driver_load_kms(struct drm_device *dev, unsigned long flags)
 	/* Call ACPI methods: require modeset init
 	 * but failure is not fatal
 	 */
-	if (!r) {
-		acpi_status = amdgpu_acpi_init(adev);
-		if (acpi_status)
-		dev_dbg(&dev->pdev->dev,
-				"Error during ACPI methods call\n");
-	}
+	acpi_status = amdgpu_acpi_init(adev);
+	if (acpi_status)
+		dev_dbg(&dev->pdev->dev, "Error during ACPI methods call\n");
 
 	if (amdgpu_device_is_px(dev)) {
 		pm_runtime_use_autosuspend(dev->dev);

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [patch] drm/amdgpu: remove an unnecessary condition
@ 2015-06-11  8:19 ` Dan Carpenter
  0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2015-06-11  8:19 UTC (permalink / raw)
  To: David Airlie, Alex Deucher
  Cc: Marek Olšák, kernel-janitors, dri-devel, yanyang1,
	Ken Wang, Christian König

We already checked "if (r)" so there is no need to check again.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c
index 5533434..b7d0425 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c
@@ -111,12 +111,9 @@ int amdgpu_driver_load_kms(struct drm_device *dev, unsigned long flags)
 	/* Call ACPI methods: require modeset init
 	 * but failure is not fatal
 	 */
-	if (!r) {
-		acpi_status = amdgpu_acpi_init(adev);
-		if (acpi_status)
-		dev_dbg(&dev->pdev->dev,
-				"Error during ACPI methods call\n");
-	}
+	acpi_status = amdgpu_acpi_init(adev);
+	if (acpi_status)
+		dev_dbg(&dev->pdev->dev, "Error during ACPI methods call\n");
 
 	if (amdgpu_device_is_px(dev)) {
 		pm_runtime_use_autosuspend(dev->dev);
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [patch] drm/amdgpu: remove an unnecessary condition
  2015-06-11  8:19 ` Dan Carpenter
@ 2015-06-11  9:26   ` Christian König
  -1 siblings, 0 replies; 4+ messages in thread
From: Christian König @ 2015-06-11  9:26 UTC (permalink / raw)
  To: Dan Carpenter, David Airlie, Alex Deucher
  Cc: Marek Olšák, kernel-janitors, dri-devel, yanyang1, Ken Wang

On 11.06.2015 10:19, Dan Carpenter wrote:
> We already checked "if (r)" so there is no need to check again.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Hi Dan,

thanks for taking a look into this. This patch and the other two you 
send today are Reviewed-by: Christian König <christian.koenig@amd.com>

That code was branched of from Radeon it is possible that the same 
changes apply there as well. Since it looks like you created those 
patches at least partially automatically could you run your tool on the 
Radeon code once more as well?

Thanks in advance,
Christian.

>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c
> index 5533434..b7d0425 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c
> @@ -111,12 +111,9 @@ int amdgpu_driver_load_kms(struct drm_device *dev, unsigned long flags)
>   	/* Call ACPI methods: require modeset init
>   	 * but failure is not fatal
>   	 */
> -	if (!r) {
> -		acpi_status = amdgpu_acpi_init(adev);
> -		if (acpi_status)
> -		dev_dbg(&dev->pdev->dev,
> -				"Error during ACPI methods call\n");
> -	}
> +	acpi_status = amdgpu_acpi_init(adev);
> +	if (acpi_status)
> +		dev_dbg(&dev->pdev->dev, "Error during ACPI methods call\n");
>   
>   	if (amdgpu_device_is_px(dev)) {
>   		pm_runtime_use_autosuspend(dev->dev);

--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [patch] drm/amdgpu: remove an unnecessary condition
@ 2015-06-11  9:26   ` Christian König
  0 siblings, 0 replies; 4+ messages in thread
From: Christian König @ 2015-06-11  9:26 UTC (permalink / raw)
  To: Dan Carpenter, David Airlie, Alex Deucher
  Cc: Marek Olšák, kernel-janitors, dri-devel, yanyang1, Ken Wang

On 11.06.2015 10:19, Dan Carpenter wrote:
> We already checked "if (r)" so there is no need to check again.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Hi Dan,

thanks for taking a look into this. This patch and the other two you 
send today are Reviewed-by: Christian König <christian.koenig@amd.com>

That code was branched of from Radeon it is possible that the same 
changes apply there as well. Since it looks like you created those 
patches at least partially automatically could you run your tool on the 
Radeon code once more as well?

Thanks in advance,
Christian.

>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c
> index 5533434..b7d0425 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c
> @@ -111,12 +111,9 @@ int amdgpu_driver_load_kms(struct drm_device *dev, unsigned long flags)
>   	/* Call ACPI methods: require modeset init
>   	 * but failure is not fatal
>   	 */
> -	if (!r) {
> -		acpi_status = amdgpu_acpi_init(adev);
> -		if (acpi_status)
> -		dev_dbg(&dev->pdev->dev,
> -				"Error during ACPI methods call\n");
> -	}
> +	acpi_status = amdgpu_acpi_init(adev);
> +	if (acpi_status)
> +		dev_dbg(&dev->pdev->dev, "Error during ACPI methods call\n");
>   
>   	if (amdgpu_device_is_px(dev)) {
>   		pm_runtime_use_autosuspend(dev->dev);

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-06-11  9:26 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-06-11  8:19 [patch] drm/amdgpu: remove an unnecessary condition Dan Carpenter
2015-06-11  8:19 ` Dan Carpenter
2015-06-11  9:26 ` Christian König
2015-06-11  9:26   ` Christian König

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.