All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Markus Böhme" <markus.boehme@mailbox.org>
To: "Dighe, Niranjan (N.)" <ndighe@visteon.com>
Cc: "sudipm.mukherjee@gmail.com" <sudipm.mukherjee@gmail.com>,
	"teddy.wang@siliconmotion.com" <teddy.wang@siliconmotion.com>,
	"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	"linux-fbdev@vger.kernel.org" <linux-fbdev@vger.kernel.org>,
	"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Staging: sm750fb: fix checkpatch.pl indentation warnings
Date: Sun, 14 Jun 2015 20:45:02 +0200	[thread overview]
Message-ID: <557DCBAE.8070109@mailbox.org> (raw)
In-Reply-To: <20150614174339.GA6105@codebox>

> This patch fixes indentation issues by replacing spaces by tabs at
> the start of line
>
> Signed-off-by: Niranjan Dighe <ndighe@visteon.com>
>
> diff --git a/drivers/staging/sm750fb/ddk750_dvi.c b/drivers/staging/sm750fb/ddk750_dvi.c
> index b2bf7e6..c73b74a 100644
> --- a/drivers/staging/sm750fb/ddk750_dvi.c
> +++ b/drivers/staging/sm750fb/ddk750_dvi.c

> -	if(pCurrentDviCtrl->pfnInit != NULL)
> +	if (pCurrentDviCtrl->pfnInit != NULL)

You are fixing a different type of warning here. Please make only one
kind of change per patch.

Regards,
Markus


WARNING: multiple messages have this Message-ID (diff)
From: "Markus Böhme" <markus.boehme@mailbox.org>
To: "Dighe, Niranjan (N.)" <ndighe@visteon.com>
Cc: "sudipm.mukherjee@gmail.com" <sudipm.mukherjee@gmail.com>,
	"teddy.wang@siliconmotion.com" <teddy.wang@siliconmotion.com>,
	"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	"linux-fbdev@vger.kernel.org" <linux-fbdev@vger.kernel.org>,
	"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Staging: sm750fb: fix checkpatch.pl indentation warnings
Date: Sun, 14 Jun 2015 18:45:02 +0000	[thread overview]
Message-ID: <557DCBAE.8070109@mailbox.org> (raw)
In-Reply-To: <20150614174339.GA6105@codebox>

> This patch fixes indentation issues by replacing spaces by tabs at
> the start of line
>
> Signed-off-by: Niranjan Dighe <ndighe@visteon.com>
>
> diff --git a/drivers/staging/sm750fb/ddk750_dvi.c b/drivers/staging/sm750fb/ddk750_dvi.c
> index b2bf7e6..c73b74a 100644
> --- a/drivers/staging/sm750fb/ddk750_dvi.c
> +++ b/drivers/staging/sm750fb/ddk750_dvi.c

> -	if(pCurrentDviCtrl->pfnInit != NULL)
> +	if (pCurrentDviCtrl->pfnInit != NULL)

You are fixing a different type of warning here. Please make only one
kind of change per patch.

Regards,
Markus


  reply	other threads:[~2015-06-14 18:52 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-14 17:43 [PATCH] Staging: sm750fb: fix checkpatch.pl indentation warnings Dighe, Niranjan (N.)
2015-06-14 17:43 ` Dighe, Niranjan (N.)
2015-06-14 18:45 ` Markus Böhme [this message]
2015-06-14 18:45   ` Markus Böhme
2015-06-15  3:34   ` Dighe, Niranjan (N.)
  -- strict thread matches above, loose matches on Subject: below --
2015-06-14 17:17 [PATCH] Staging: sm750fb: Fix checkpatch.pl warnings Dighe, Niranjan (N.)
2015-06-15  5:27 ` Sudip Mukherjee
2015-06-15  5:39   ` Sudip Mukherjee
2015-06-15 10:23   ` Dighe, Niranjan (N.)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=557DCBAE.8070109@mailbox.org \
    --to=markus.boehme@mailbox.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ndighe@visteon.com \
    --cc=sudipm.mukherjee@gmail.com \
    --cc=teddy.wang@siliconmotion.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.