All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] mx6cuboxi: Fix boot of hummingboard dual-lite
@ 2015-05-29 16:00 Fabio Estevam
  2015-05-29 23:05 ` Andrei Gherzan
  0 siblings, 1 reply; 4+ messages in thread
From: Fabio Estevam @ 2015-05-29 16:00 UTC (permalink / raw)
  To: u-boot

Hummingboard dual-lite is picking the incorrect calibration structure.

Fix it so that it can boot.

While at it, also fix p1_mpdgctrl1 register to match Solid-run's
setting.

Reported-by: Andrei Gherzan <andrei@gherzan.ro>
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
I do not have access to a hummingboard dual-lite.

If anyone could test it, please provide a Tested-by, thanks

 board/solidrun/mx6cuboxi/mx6cuboxi.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/board/solidrun/mx6cuboxi/mx6cuboxi.c b/board/solidrun/mx6cuboxi/mx6cuboxi.c
index d15c726..9b1ecf0 100644
--- a/board/solidrun/mx6cuboxi/mx6cuboxi.c
+++ b/board/solidrun/mx6cuboxi/mx6cuboxi.c
@@ -536,7 +536,7 @@ static const struct mx6_mmdc_calibration mx6dl_1g_mmcd_calib = {
 	.p0_mpdgctrl0 =    0x023C0224,
 	.p0_mpdgctrl1 =    0x02000220,
 	.p1_mpdgctrl0 =    0x02200220,
-	.p1_mpdgctrl1 =    0x02000220,
+	.p1_mpdgctrl1 =    0x02040208,
 	.p0_mprddlctl =    0x44444846,
 	.p1_mprddlctl =    0x4042463C,
 	.p0_mpwrdlctl =    0x32343032,
@@ -627,7 +627,7 @@ static void spl_dram_init(int width)
 	else if (is_cpu_type(MXC_CPU_MX6Q))
 		mx6_dram_cfg(&sysinfo, &mx6q_2g_mmcd_calib, &mem_ddr_4g);
 	else if (is_cpu_type(MXC_CPU_MX6DL))
-		mx6_dram_cfg(&sysinfo, &mx6q_1g_mmcd_calib, &mem_ddr_2g);
+		mx6_dram_cfg(&sysinfo, &mx6dl_1g_mmcd_calib, &mem_ddr_2g);
 	else if (is_cpu_type(MXC_CPU_MX6SOLO))
 		mx6_dram_cfg(&sysinfo, &mx6dl_512m_mmcd_calib, &mem_ddr_2g);
 }
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [U-Boot] [PATCH] mx6cuboxi: Fix boot of hummingboard dual-lite
  2015-05-29 16:00 [U-Boot] [PATCH] mx6cuboxi: Fix boot of hummingboard dual-lite Fabio Estevam
@ 2015-05-29 23:05 ` Andrei Gherzan
  2015-06-11 12:01   ` Fabio Estevam
  0 siblings, 1 reply; 4+ messages in thread
From: Andrei Gherzan @ 2015-05-29 23:05 UTC (permalink / raw)
  To: u-boot

Hi,

On Fri, May 29, 2015 at 6:00 PM, Fabio Estevam
<fabio.estevam@freescale.com> wrote:
> Hummingboard dual-lite is picking the incorrect calibration structure.
>
> Fix it so that it can boot.
>
> While at it, also fix p1_mpdgctrl1 register to match Solid-run's
> setting.
>
> Reported-by: Andrei Gherzan <andrei@gherzan.ro>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>

Tested-by: Andrei Gherzan <andrei@gherzan.ro>
-- 
Andrei Gherzan
e: andrei at gherzan.ro
w: www.gherzan.ro

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [U-Boot] [PATCH] mx6cuboxi: Fix boot of hummingboard dual-lite
  2015-05-29 23:05 ` Andrei Gherzan
@ 2015-06-11 12:01   ` Fabio Estevam
  2015-06-15 10:14     ` Stefano Babic
  0 siblings, 1 reply; 4+ messages in thread
From: Fabio Estevam @ 2015-06-11 12:01 UTC (permalink / raw)
  To: u-boot

Hi Stefano,

On Fri, May 29, 2015 at 8:05 PM, Andrei Gherzan <andrei@gherzan.ro> wrote:
> Hi,
>
> On Fri, May 29, 2015 at 6:00 PM, Fabio Estevam
> <fabio.estevam@freescale.com> wrote:
>> Hummingboard dual-lite is picking the incorrect calibration structure.
>>
>> Fix it so that it can boot.
>>
>> While at it, also fix p1_mpdgctrl1 register to match Solid-run's
>> setting.
>>
>> Reported-by: Andrei Gherzan <andrei@gherzan.ro>
>> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
>
> Tested-by: Andrei Gherzan <andrei@gherzan.ro>

Can this one be applied, please?

It fixes the boot on Hummingboard dual-lite model.

Thanks

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [U-Boot] [PATCH] mx6cuboxi: Fix boot of hummingboard dual-lite
  2015-06-11 12:01   ` Fabio Estevam
@ 2015-06-15 10:14     ` Stefano Babic
  0 siblings, 0 replies; 4+ messages in thread
From: Stefano Babic @ 2015-06-15 10:14 UTC (permalink / raw)
  To: u-boot

Hi Fabio,

On 11/06/2015 14:01, Fabio Estevam wrote:
> Hi Stefano,
> 
> On Fri, May 29, 2015 at 8:05 PM, Andrei Gherzan <andrei@gherzan.ro> wrote:
>> Hi,
>>
>> On Fri, May 29, 2015 at 6:00 PM, Fabio Estevam
>> <fabio.estevam@freescale.com> wrote:
>>> Hummingboard dual-lite is picking the incorrect calibration structure.
>>>
>>> Fix it so that it can boot.
>>>
>>> While at it, also fix p1_mpdgctrl1 register to match Solid-run's
>>> setting.
>>>
>>> Reported-by: Andrei Gherzan <andrei@gherzan.ro>
>>> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
>>
>> Tested-by: Andrei Gherzan <andrei@gherzan.ro>
> 
> Can this one be applied, please?
> 
> It fixes the boot on Hummingboard dual-lite model.
> 

Patch disappeared in patchwork (it was errouneosly set to "Changes
requested") and missed my last PR.

Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic


-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2015-06-15 10:14 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-05-29 16:00 [U-Boot] [PATCH] mx6cuboxi: Fix boot of hummingboard dual-lite Fabio Estevam
2015-05-29 23:05 ` Andrei Gherzan
2015-06-11 12:01   ` Fabio Estevam
2015-06-15 10:14     ` Stefano Babic

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.