[PATCH 00/12] media/subdevices: Remove unused compat control ops

[PATCH 00/12] media/subdevices: Remove unused compat control ops

[Ricardo Ribalda Delgado]

Remove no longer used compat control ops, as they are not used in their
bridge drivers.

Working tree can be found at
https://github.com/ribalda/linux/tree/compat_control_clean

Ricardo Ribalda Delgado (12):
  media/i2c/adv7343: Remove compat control ops
  media/i2c/adv7393: Remove compat control ops
  media/i2c/cs5345: Remove compat control ops
  media/i2c/saa717x: Remove compat control ops
  media/i2c/sr030pc30: Remove compat control ops
  media/i2c/tda7432: Remove compat control ops
  media/i2c/tlv320aic23: Remove compat control ops
  media/i2c/tvp514x: Remove compat control ops
  media/i2c/tvp7002: Remove compat control ops
  i2c/wm8739: Remove compat control ops
  pci/ivtv/ivtv-gpio: Remove compat control ops
  media/radio/saa7706h: Remove compat control ops

 drivers/media/i2c/adv7343.c        |  7 -------
 drivers/media/i2c/adv7393.c        |  7 -------
 drivers/media/i2c/cs5345.c         |  7 -------
 drivers/media/i2c/saa717x.c        |  7 -------
 drivers/media/i2c/sr030pc30.c      |  7 -------
 drivers/media/i2c/tda7432.c        |  7 -------
 drivers/media/i2c/tlv320aic23b.c   |  7 -------
 drivers/media/i2c/tvp514x.c        | 11 -----------
 drivers/media/i2c/tvp7002.c        |  7 -------
 drivers/media/i2c/wm8739.c         |  7 -------
 drivers/media/pci/ivtv/ivtv-gpio.c |  7 -------
 drivers/media/radio/saa7706h.c     | 16 ++--------------
 12 files changed, 2 insertions(+), 95 deletions(-)

-- 
2.1.4

[PATCH 01/12] media/i2c/adv7343: Remove compat control ops

[Ricardo Ribalda Delgado]

They are no longer used in old non-control-framework
bridge drivers.

Reported-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
---
 drivers/media/i2c/adv7343.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/drivers/media/i2c/adv7343.c b/drivers/media/i2c/adv7343.c
index 7c50833e7d17..d27283135490 100644
--- a/drivers/media/i2c/adv7343.c
+++ b/drivers/media/i2c/adv7343.c
@@ -319,13 +319,6 @@ static const struct v4l2_ctrl_ops adv7343_ctrl_ops = {
 
 static const struct v4l2_subdev_core_ops adv7343_core_ops = {
 	.log_status = adv7343_log_status,
-	.g_ext_ctrls = v4l2_subdev_g_ext_ctrls,
-	.try_ext_ctrls = v4l2_subdev_try_ext_ctrls,
-	.s_ext_ctrls = v4l2_subdev_s_ext_ctrls,
-	.g_ctrl = v4l2_subdev_g_ctrl,
-	.s_ctrl = v4l2_subdev_s_ctrl,
-	.queryctrl = v4l2_subdev_queryctrl,
-	.querymenu = v4l2_subdev_querymenu,
 };
 
 static int adv7343_s_std_output(struct v4l2_subdev *sd, v4l2_std_id std)
-- 
2.1.4

[PATCH 02/12] media/i2c/adv7393: Remove compat control ops

[Ricardo Ribalda Delgado]

They are no longer used in old non-control-framework
bridge drivers.

Reported-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
---
 drivers/media/i2c/adv7393.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/drivers/media/i2c/adv7393.c b/drivers/media/i2c/adv7393.c
index 558f19154eb9..0215f95c2245 100644
--- a/drivers/media/i2c/adv7393.c
+++ b/drivers/media/i2c/adv7393.c
@@ -306,13 +306,6 @@ static const struct v4l2_ctrl_ops adv7393_ctrl_ops = {
 
 static const struct v4l2_subdev_core_ops adv7393_core_ops = {
 	.log_status = adv7393_log_status,
-	.g_ext_ctrls = v4l2_subdev_g_ext_ctrls,
-	.try_ext_ctrls = v4l2_subdev_try_ext_ctrls,
-	.s_ext_ctrls = v4l2_subdev_s_ext_ctrls,
-	.g_ctrl = v4l2_subdev_g_ctrl,
-	.s_ctrl = v4l2_subdev_s_ctrl,
-	.queryctrl = v4l2_subdev_queryctrl,
-	.querymenu = v4l2_subdev_querymenu,
 };
 
 static int adv7393_s_std_output(struct v4l2_subdev *sd, v4l2_std_id std)
-- 
2.1.4

[PATCH 03/12] media/i2c/cs5345: Remove compat control ops

[Ricardo Ribalda Delgado]

They are no longer used in old non-control-framework
bridge drivers.

Reported-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
---
 drivers/media/i2c/cs5345.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/drivers/media/i2c/cs5345.c b/drivers/media/i2c/cs5345.c
index 34b76a9e7515..8cebf9cc8007 100644
--- a/drivers/media/i2c/cs5345.c
+++ b/drivers/media/i2c/cs5345.c
@@ -132,13 +132,6 @@ static const struct v4l2_ctrl_ops cs5345_ctrl_ops = {
 
 static const struct v4l2_subdev_core_ops cs5345_core_ops = {
 	.log_status = cs5345_log_status,
-	.g_ext_ctrls = v4l2_subdev_g_ext_ctrls,
-	.try_ext_ctrls = v4l2_subdev_try_ext_ctrls,
-	.s_ext_ctrls = v4l2_subdev_s_ext_ctrls,
-	.g_ctrl = v4l2_subdev_g_ctrl,
-	.s_ctrl = v4l2_subdev_s_ctrl,
-	.queryctrl = v4l2_subdev_queryctrl,
-	.querymenu = v4l2_subdev_querymenu,
 #ifdef CONFIG_VIDEO_ADV_DEBUG
 	.g_register = cs5345_g_register,
 	.s_register = cs5345_s_register,
-- 
2.1.4

[PATCH 04/12] media/i2c/saa717x: Remove compat control ops

[Ricardo Ribalda Delgado]

They are no longer used in old non-control-framework
bridge drivers.

Reported-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
---
 drivers/media/i2c/saa717x.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/drivers/media/i2c/saa717x.c b/drivers/media/i2c/saa717x.c
index 7d517361e419..c6ba19cf1aa5 100644
--- a/drivers/media/i2c/saa717x.c
+++ b/drivers/media/i2c/saa717x.c
@@ -1204,13 +1204,6 @@ static const struct v4l2_subdev_core_ops saa717x_core_ops = {
 	.g_register = saa717x_g_register,
 	.s_register = saa717x_s_register,
 #endif
-	.g_ext_ctrls = v4l2_subdev_g_ext_ctrls,
-	.try_ext_ctrls = v4l2_subdev_try_ext_ctrls,
-	.s_ext_ctrls = v4l2_subdev_s_ext_ctrls,
-	.g_ctrl = v4l2_subdev_g_ctrl,
-	.s_ctrl = v4l2_subdev_s_ctrl,
-	.queryctrl = v4l2_subdev_queryctrl,
-	.querymenu = v4l2_subdev_querymenu,
 	.log_status = saa717x_log_status,
 };
 
-- 
2.1.4

[PATCH 05/12] media/i2c/sr030pc30: Remove compat control ops

[Ricardo Ribalda Delgado]

They are no longer used in old non-control-framework
bridge drivers.

Reported-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
---
 drivers/media/i2c/sr030pc30.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/drivers/media/i2c/sr030pc30.c b/drivers/media/i2c/sr030pc30.c
index b62b6ddc4356..229dc76c44a5 100644
--- a/drivers/media/i2c/sr030pc30.c
+++ b/drivers/media/i2c/sr030pc30.c
@@ -636,13 +636,6 @@ static const struct v4l2_ctrl_ops sr030pc30_ctrl_ops = {
 
 static const struct v4l2_subdev_core_ops sr030pc30_core_ops = {
 	.s_power	= sr030pc30_s_power,
-	.g_ext_ctrls = v4l2_subdev_g_ext_ctrls,
-	.try_ext_ctrls = v4l2_subdev_try_ext_ctrls,
-	.s_ext_ctrls = v4l2_subdev_s_ext_ctrls,
-	.g_ctrl = v4l2_subdev_g_ctrl,
-	.s_ctrl = v4l2_subdev_s_ctrl,
-	.queryctrl = v4l2_subdev_queryctrl,
-	.querymenu = v4l2_subdev_querymenu,
 };
 
 static const struct v4l2_subdev_pad_ops sr030pc30_pad_ops = {
-- 
2.1.4

[PATCH 06/12] media/i2c/tda7432: Remove compat control ops

[Ricardo Ribalda Delgado]

They are no longer used in old non-control-framework
bridge drivers.

Reported-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
---
 drivers/media/i2c/tda7432.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/drivers/media/i2c/tda7432.c b/drivers/media/i2c/tda7432.c
index cf93021a6500..d3834a4c48da 100644
--- a/drivers/media/i2c/tda7432.c
+++ b/drivers/media/i2c/tda7432.c
@@ -331,13 +331,6 @@ static const struct v4l2_ctrl_ops tda7432_ctrl_ops = {
 
 static const struct v4l2_subdev_core_ops tda7432_core_ops = {
 	.log_status = tda7432_log_status,
-	.g_ext_ctrls = v4l2_subdev_g_ext_ctrls,
-	.try_ext_ctrls = v4l2_subdev_try_ext_ctrls,
-	.s_ext_ctrls = v4l2_subdev_s_ext_ctrls,
-	.g_ctrl = v4l2_subdev_g_ctrl,
-	.s_ctrl = v4l2_subdev_s_ctrl,
-	.queryctrl = v4l2_subdev_queryctrl,
-	.querymenu = v4l2_subdev_querymenu,
 };
 
 static const struct v4l2_subdev_ops tda7432_ops = {
-- 
2.1.4

[PATCH 07/12] media/i2c/tlv320aic23: Remove compat control ops

[Ricardo Ribalda Delgado]

They are no longer used in old non-control-framework
bridge drivers.

Reported-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
---
 drivers/media/i2c/tlv320aic23b.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/drivers/media/i2c/tlv320aic23b.c b/drivers/media/i2c/tlv320aic23b.c
index ef87f7b09ea2..0370dd89f1fc 100644
--- a/drivers/media/i2c/tlv320aic23b.c
+++ b/drivers/media/i2c/tlv320aic23b.c
@@ -122,13 +122,6 @@ static const struct v4l2_ctrl_ops tlv320aic23b_ctrl_ops = {
 
 static const struct v4l2_subdev_core_ops tlv320aic23b_core_ops = {
 	.log_status = tlv320aic23b_log_status,
-	.g_ext_ctrls = v4l2_subdev_g_ext_ctrls,
-	.try_ext_ctrls = v4l2_subdev_try_ext_ctrls,
-	.s_ext_ctrls = v4l2_subdev_s_ext_ctrls,
-	.g_ctrl = v4l2_subdev_g_ctrl,
-	.s_ctrl = v4l2_subdev_s_ctrl,
-	.queryctrl = v4l2_subdev_queryctrl,
-	.querymenu = v4l2_subdev_querymenu,
 };
 
 static const struct v4l2_subdev_audio_ops tlv320aic23b_audio_ops = {
-- 
2.1.4

[PATCH 08/12] media/i2c/tvp514x: Remove compat control ops

[Ricardo Ribalda Delgado]

They are no longer used in old non-control-framework
bridge drivers.

Reported-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
---
 drivers/media/i2c/tvp514x.c | 11 -----------
 1 file changed, 11 deletions(-)

diff --git a/drivers/media/i2c/tvp514x.c b/drivers/media/i2c/tvp514x.c
index 24e47279e30c..a93985a9b070 100644
--- a/drivers/media/i2c/tvp514x.c
+++ b/drivers/media/i2c/tvp514x.c
@@ -957,16 +957,6 @@ static int tvp514x_set_pad_format(struct v4l2_subdev *sd,
 	return 0;
 }
 
-static const struct v4l2_subdev_core_ops tvp514x_core_ops = {
-	.g_ext_ctrls = v4l2_subdev_g_ext_ctrls,
-	.try_ext_ctrls = v4l2_subdev_try_ext_ctrls,
-	.s_ext_ctrls = v4l2_subdev_s_ext_ctrls,
-	.g_ctrl = v4l2_subdev_g_ctrl,
-	.s_ctrl = v4l2_subdev_s_ctrl,
-	.queryctrl = v4l2_subdev_queryctrl,
-	.querymenu = v4l2_subdev_querymenu,
-};
-
 static const struct v4l2_subdev_video_ops tvp514x_video_ops = {
 	.s_std = tvp514x_s_std,
 	.s_routing = tvp514x_s_routing,
@@ -983,7 +973,6 @@ static const struct v4l2_subdev_pad_ops tvp514x_pad_ops = {
 };
 
 static const struct v4l2_subdev_ops tvp514x_ops = {
-	.core = &tvp514x_core_ops,
 	.video = &tvp514x_video_ops,
 	.pad = &tvp514x_pad_ops,
 };
-- 
2.1.4

[PATCH 09/12] media/i2c/tvp7002: Remove compat control ops

[Ricardo Ribalda Delgado]

They are no longer used in old non-control-framework
bridge drivers.

Reported-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
---
 drivers/media/i2c/tvp7002.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/drivers/media/i2c/tvp7002.c b/drivers/media/i2c/tvp7002.c
index 05077cffd235..f617d8b745ee 100644
--- a/drivers/media/i2c/tvp7002.c
+++ b/drivers/media/i2c/tvp7002.c
@@ -861,13 +861,6 @@ tvp7002_set_pad_format(struct v4l2_subdev *sd, struct v4l2_subdev_pad_config *cf
 /* V4L2 core operation handlers */
 static const struct v4l2_subdev_core_ops tvp7002_core_ops = {
 	.log_status = tvp7002_log_status,
-	.g_ext_ctrls = v4l2_subdev_g_ext_ctrls,
-	.try_ext_ctrls = v4l2_subdev_try_ext_ctrls,
-	.s_ext_ctrls = v4l2_subdev_s_ext_ctrls,
-	.g_ctrl = v4l2_subdev_g_ctrl,
-	.s_ctrl = v4l2_subdev_s_ctrl,
-	.queryctrl = v4l2_subdev_queryctrl,
-	.querymenu = v4l2_subdev_querymenu,
 #ifdef CONFIG_VIDEO_ADV_DEBUG
 	.g_register = tvp7002_g_register,
 	.s_register = tvp7002_s_register,
-- 
2.1.4

[PATCH 10/12] i2c/wm8739: Remove compat control ops

[Ricardo Ribalda Delgado]

They are no longer used in old non-control-framework
bridge drivers.

Reported-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
---
 drivers/media/i2c/wm8739.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/drivers/media/i2c/wm8739.c b/drivers/media/i2c/wm8739.c
index 3be73f6a40e9..534b0e560317 100644
--- a/drivers/media/i2c/wm8739.c
+++ b/drivers/media/i2c/wm8739.c
@@ -176,13 +176,6 @@ static const struct v4l2_ctrl_ops wm8739_ctrl_ops = {
 
 static const struct v4l2_subdev_core_ops wm8739_core_ops = {
 	.log_status = wm8739_log_status,
-	.g_ext_ctrls = v4l2_subdev_g_ext_ctrls,
-	.try_ext_ctrls = v4l2_subdev_try_ext_ctrls,
-	.s_ext_ctrls = v4l2_subdev_s_ext_ctrls,
-	.g_ctrl = v4l2_subdev_g_ctrl,
-	.s_ctrl = v4l2_subdev_s_ctrl,
-	.queryctrl = v4l2_subdev_queryctrl,
-	.querymenu = v4l2_subdev_querymenu,
 };
 
 static const struct v4l2_subdev_audio_ops wm8739_audio_ops = {
-- 
2.1.4

[PATCH 11/12] pci/ivtv/ivtv-gpio: Remove compat control ops

[Ricardo Ribalda Delgado]

They are no longer used in old non-control-framework
bridge drivers.

Reported-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
---
 drivers/media/pci/ivtv/ivtv-gpio.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/drivers/media/pci/ivtv/ivtv-gpio.c b/drivers/media/pci/ivtv/ivtv-gpio.c
index af52def700cc..f752f3993687 100644
--- a/drivers/media/pci/ivtv/ivtv-gpio.c
+++ b/drivers/media/pci/ivtv/ivtv-gpio.c
@@ -313,13 +313,6 @@ static const struct v4l2_ctrl_ops gpio_ctrl_ops = {
 
 static const struct v4l2_subdev_core_ops subdev_core_ops = {
 	.log_status = subdev_log_status,
-	.g_ext_ctrls = v4l2_subdev_g_ext_ctrls,
-	.try_ext_ctrls = v4l2_subdev_try_ext_ctrls,
-	.s_ext_ctrls = v4l2_subdev_s_ext_ctrls,
-	.g_ctrl = v4l2_subdev_g_ctrl,
-	.s_ctrl = v4l2_subdev_s_ctrl,
-	.queryctrl = v4l2_subdev_queryctrl,
-	.querymenu = v4l2_subdev_querymenu,
 };
 
 static const struct v4l2_subdev_tuner_ops subdev_tuner_ops = {
-- 
2.1.4

[PATCH 12/12] media/radio/saa7706h: Remove compat control ops

[Ricardo Ribalda Delgado]

They are no longer used in old non-control-framework
bridge drivers.

Reported-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
---
 drivers/media/radio/saa7706h.c | 16 ++--------------
 1 file changed, 2 insertions(+), 14 deletions(-)

diff --git a/drivers/media/radio/saa7706h.c b/drivers/media/radio/saa7706h.c
index ec805b09c608..183e92719140 100644
--- a/drivers/media/radio/saa7706h.c
+++ b/drivers/media/radio/saa7706h.c
@@ -336,19 +336,7 @@ static const struct v4l2_ctrl_ops saa7706h_ctrl_ops = {
 	.s_ctrl = saa7706h_s_ctrl,
 };
 
-static const struct v4l2_subdev_core_ops saa7706h_core_ops = {
-	.g_ext_ctrls = v4l2_subdev_g_ext_ctrls,
-	.try_ext_ctrls = v4l2_subdev_try_ext_ctrls,
-	.s_ext_ctrls = v4l2_subdev_s_ext_ctrls,
-	.g_ctrl = v4l2_subdev_g_ctrl,
-	.s_ctrl = v4l2_subdev_s_ctrl,
-	.queryctrl = v4l2_subdev_queryctrl,
-	.querymenu = v4l2_subdev_querymenu,
-};
-
-static const struct v4l2_subdev_ops saa7706h_ops = {
-	.core = &saa7706h_core_ops,
-};
+static const struct v4l2_subdev_ops empty_ops = {};
 
 /*
  * Generic i2c probe
@@ -373,7 +361,7 @@ static int saa7706h_probe(struct i2c_client *client,
 	if (state == NULL)
 		return -ENOMEM;
 	sd = &state->sd;
-	v4l2_i2c_subdev_init(sd, client, &saa7706h_ops);
+	v4l2_i2c_subdev_init(sd, client, &empty_ops);
 
 	v4l2_ctrl_handler_init(&state->hdl, 4);
 	v4l2_ctrl_new_std(&state->hdl, &saa7706h_ctrl_ops,
-- 
2.1.4

Re: [PATCH 05/12] media/i2c/sr030pc30: Remove compat control ops

[Hans Verkuil]

Sylwester,

Can you confirm that this is only used with bridge drivers that use the
control framework? Actually, this driver isn't used by any bridge driver
in the kernel tree, but it is probably in use by out-of-tree code.

I'd like your Ack (or Nack) before I merge this.

Note that eventually these legacy support ops will disappear once all
bridge drivers in the kernel have been converted to the control framework.

Regards,

	Hans


On 06/12/2015 06:31 PM, Ricardo Ribalda Delgado wrote:
> They are no longer used in old non-control-framework
> bridge drivers.
> 
> Reported-by: Hans Verkuil <hans.verkuil@cisco.com>
> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
> ---
>  drivers/media/i2c/sr030pc30.c | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/drivers/media/i2c/sr030pc30.c b/drivers/media/i2c/sr030pc30.c
> index b62b6ddc4356..229dc76c44a5 100644
> --- a/drivers/media/i2c/sr030pc30.c
> +++ b/drivers/media/i2c/sr030pc30.c
> @@ -636,13 +636,6 @@ static const struct v4l2_ctrl_ops sr030pc30_ctrl_ops = {
>  
>  static const struct v4l2_subdev_core_ops sr030pc30_core_ops = {
>  	.s_power	= sr030pc30_s_power,
> -	.g_ext_ctrls = v4l2_subdev_g_ext_ctrls,
> -	.try_ext_ctrls = v4l2_subdev_try_ext_ctrls,
> -	.s_ext_ctrls = v4l2_subdev_s_ext_ctrls,
> -	.g_ctrl = v4l2_subdev_g_ctrl,
> -	.s_ctrl = v4l2_subdev_s_ctrl,
> -	.queryctrl = v4l2_subdev_queryctrl,
> -	.querymenu = v4l2_subdev_querymenu,
>  };
>  
>  static const struct v4l2_subdev_pad_ops sr030pc30_pad_ops = {
> 

Re: [PATCH 05/12] media/i2c/sr030pc30: Remove compat control ops

[Sylwester Nawrocki]

Hi Hans,

On 15/06/15 12:23, Hans Verkuil wrote:
> Sylwester,
> 
> Can you confirm that this is only used with bridge drivers that use the
> control framework? Actually, this driver isn't used by any bridge driver
> in the kernel tree, but it is probably in use by out-of-tree code.
> 
> I'd like your Ack (or Nack) before I merge this.
> 
> Note that eventually these legacy support ops will disappear once all
> bridge drivers in the kernel have been converted to the control framework.

This sensor driver is used on board type which has been scratched long time
ago, feel free to do any changes in this code.

Acked-by: Sylwester Nawrocki <s.nawrocki@samsung.com>


-- 
Regards,
Sylwester

Re: [PATCH 01/12] media/i2c/adv7343: Remove compat control ops

[Lad, Prabhakar]

On Fri, Jun 12, 2015 at 5:31 PM, Ricardo Ribalda Delgado
<ricardo.ribalda@gmail.com> wrote:
> They are no longer used in old non-control-framework
> bridge drivers.
>
> Reported-by: Hans Verkuil <hans.verkuil@cisco.com>
> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>

Acked-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>

Cheers,
--Prabhakar Lad

> ---
>  drivers/media/i2c/adv7343.c | 7 -------
>  1 file changed, 7 deletions(-)
>
> diff --git a/drivers/media/i2c/adv7343.c b/drivers/media/i2c/adv7343.c
> index 7c50833e7d17..d27283135490 100644
> --- a/drivers/media/i2c/adv7343.c
> +++ b/drivers/media/i2c/adv7343.c
> @@ -319,13 +319,6 @@ static const struct v4l2_ctrl_ops adv7343_ctrl_ops = {
>
>  static const struct v4l2_subdev_core_ops adv7343_core_ops = {
>         .log_status = adv7343_log_status,
> -       .g_ext_ctrls = v4l2_subdev_g_ext_ctrls,
> -       .try_ext_ctrls = v4l2_subdev_try_ext_ctrls,
> -       .s_ext_ctrls = v4l2_subdev_s_ext_ctrls,
> -       .g_ctrl = v4l2_subdev_g_ctrl,
> -       .s_ctrl = v4l2_subdev_s_ctrl,
> -       .queryctrl = v4l2_subdev_queryctrl,
> -       .querymenu = v4l2_subdev_querymenu,
>  };
>
>  static int adv7343_s_std_output(struct v4l2_subdev *sd, v4l2_std_id std)
> --
> 2.1.4
>

Re: [PATCH 08/12] media/i2c/tvp514x: Remove compat control ops

[Lad, Prabhakar]

On Fri, Jun 12, 2015 at 5:31 PM, Ricardo Ribalda Delgado
<ricardo.ribalda@gmail.com> wrote:
> They are no longer used in old non-control-framework
> bridge drivers.
>
> Reported-by: Hans Verkuil <hans.verkuil@cisco.com>
> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>

Acked-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>

Cheers,
--Prabhakar Lad

> ---
>  drivers/media/i2c/tvp514x.c | 11 -----------
>  1 file changed, 11 deletions(-)
>
> diff --git a/drivers/media/i2c/tvp514x.c b/drivers/media/i2c/tvp514x.c
> index 24e47279e30c..a93985a9b070 100644
> --- a/drivers/media/i2c/tvp514x.c
> +++ b/drivers/media/i2c/tvp514x.c
> @@ -957,16 +957,6 @@ static int tvp514x_set_pad_format(struct v4l2_subdev *sd,
>         return 0;
>  }
>
> -static const struct v4l2_subdev_core_ops tvp514x_core_ops = {
> -       .g_ext_ctrls = v4l2_subdev_g_ext_ctrls,
> -       .try_ext_ctrls = v4l2_subdev_try_ext_ctrls,
> -       .s_ext_ctrls = v4l2_subdev_s_ext_ctrls,
> -       .g_ctrl = v4l2_subdev_g_ctrl,
> -       .s_ctrl = v4l2_subdev_s_ctrl,
> -       .queryctrl = v4l2_subdev_queryctrl,
> -       .querymenu = v4l2_subdev_querymenu,
> -};
> -
>  static const struct v4l2_subdev_video_ops tvp514x_video_ops = {
>         .s_std = tvp514x_s_std,
>         .s_routing = tvp514x_s_routing,
> @@ -983,7 +973,6 @@ static const struct v4l2_subdev_pad_ops tvp514x_pad_ops = {
>  };
>
>  static const struct v4l2_subdev_ops tvp514x_ops = {
> -       .core = &tvp514x_core_ops,
>         .video = &tvp514x_video_ops,
>         .pad = &tvp514x_pad_ops,
>  };
> --
> 2.1.4
>

Re: [PATCH 09/12] media/i2c/tvp7002: Remove compat control ops

[Lad, Prabhakar]

On Fri, Jun 12, 2015 at 5:31 PM, Ricardo Ribalda Delgado
<ricardo.ribalda@gmail.com> wrote:
> They are no longer used in old non-control-framework
> bridge drivers.
>
> Reported-by: Hans Verkuil <hans.verkuil@cisco.com>
> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>

Acked-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>

Cheers,
--Prabhakar Lad

> ---
>  drivers/media/i2c/tvp7002.c | 7 -------
>  1 file changed, 7 deletions(-)
>
> diff --git a/drivers/media/i2c/tvp7002.c b/drivers/media/i2c/tvp7002.c
> index 05077cffd235..f617d8b745ee 100644
> --- a/drivers/media/i2c/tvp7002.c
> +++ b/drivers/media/i2c/tvp7002.c
> @@ -861,13 +861,6 @@ tvp7002_set_pad_format(struct v4l2_subdev *sd, struct v4l2_subdev_pad_config *cf
>  /* V4L2 core operation handlers */
>  static const struct v4l2_subdev_core_ops tvp7002_core_ops = {
>         .log_status = tvp7002_log_status,
> -       .g_ext_ctrls = v4l2_subdev_g_ext_ctrls,
> -       .try_ext_ctrls = v4l2_subdev_try_ext_ctrls,
> -       .s_ext_ctrls = v4l2_subdev_s_ext_ctrls,
> -       .g_ctrl = v4l2_subdev_g_ctrl,
> -       .s_ctrl = v4l2_subdev_s_ctrl,
> -       .queryctrl = v4l2_subdev_queryctrl,
> -       .querymenu = v4l2_subdev_querymenu,
>  #ifdef CONFIG_VIDEO_ADV_DEBUG
>         .g_register = tvp7002_g_register,
>         .s_register = tvp7002_s_register,
> --
> 2.1.4
>