All of lore.kernel.org
 help / color / mirror / Atom feed
From: Roger Quadros <rogerq@ti.com>
To: Manu Gautam <mgautam@codeaurora.org>, <balbi@kernel.org>
Cc: <linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] usb: dwc3: drd: Fix lock-up on ID change during system suspend/resume
Date: Tue, 23 Jan 2018 14:41:22 +0200	[thread overview]
Message-ID: <557afc49-712d-9e70-7e4a-b7b3e74b7a50@ti.com> (raw)
In-Reply-To: <522f639a-466f-ae72-745e-61cbcc6fbfc7@codeaurora.org>

Hi Manu,

On 23/01/18 05:45, Manu Gautam wrote:
> Hi,
> 
> 
> On 1/22/2018 6:31 PM, Roger Quadros wrote:
>> Adding/removing host/gadget controller before .pm_complete()
>> causes a lock-up. Let's prevent any dual-role state change
>> between .pm_prepare() and .pm_complete() to fix this.
> 
> What kind of lock-up are you seeing? Some hardware lockup or software deadlock?
> IMO using a freezable_wq for drd_work should address that?
> 

I was seeing a software deadlock. freezable_wq is a good idea. I'll try it out.

> 
>>
<snip>

-- 
cheers,
-roger

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

WARNING: multiple messages have this Message-ID (diff)
From: Roger Quadros <rogerq@ti.com>
To: Manu Gautam <mgautam@codeaurora.org>, balbi@kernel.org
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [2/2] usb: dwc3: drd: Fix lock-up on ID change during system suspend/resume
Date: Tue, 23 Jan 2018 14:41:22 +0200	[thread overview]
Message-ID: <557afc49-712d-9e70-7e4a-b7b3e74b7a50@ti.com> (raw)

Hi Manu,

On 23/01/18 05:45, Manu Gautam wrote:
> Hi,
> 
> 
> On 1/22/2018 6:31 PM, Roger Quadros wrote:
>> Adding/removing host/gadget controller before .pm_complete()
>> causes a lock-up. Let's prevent any dual-role state change
>> between .pm_prepare() and .pm_complete() to fix this.
> 
> What kind of lock-up are you seeing? Some hardware lockup or software deadlock?
> IMO using a freezable_wq for drd_work should address that?
> 

I was seeing a software deadlock. freezable_wq is a good idea. I'll try it out.

> 
>>
<snip>

  reply	other threads:[~2018-01-23 12:41 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-22 13:01 [PATCH 0/2] usb: dwc3: Fix dual role during system suspend/resume Roger Quadros
2018-01-22 13:01 ` [PATCH 1/2] usb: dwc3: omap: don't miss events during suspend/resume Roger Quadros
2018-01-22 13:01   ` [1/2] " Roger Quadros
2018-01-22 13:01 ` [PATCH 2/2] usb: dwc3: drd: Fix lock-up on ID change during system suspend/resume Roger Quadros
2018-01-22 13:01   ` [2/2] " Roger Quadros
2018-01-23  3:45   ` [PATCH 2/2] " Manu Gautam
2018-01-23  3:45     ` [2/2] " Manu Gautam
2018-01-23 12:41     ` Roger Quadros [this message]
2018-01-23 12:41       ` Roger Quadros
2018-01-24 12:19       ` [PATCH 2/2] " Roger Quadros
2018-01-24 12:19         ` [2/2] " Roger Quadros
2018-01-25 16:11         ` [PATCH 2/2] " Roger Quadros
2018-01-25 16:11           ` [2/2] " Roger Quadros
2018-02-15  7:45           ` [PATCH 2/2] " Roger Quadros
2018-02-15  7:45             ` [2/2] " Roger Quadros
2018-02-12  8:54   ` [PATCH 2/2] " Felipe Balbi
2018-02-12  8:54     ` [2/2] " Felipe Balbi
2018-02-12 10:48     ` [PATCH 2/2] " Roger Quadros
2018-02-12 10:48       ` [2/2] " Roger Quadros

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=557afc49-712d-9e70-7e4a-b7b3e74b7a50@ti.com \
    --to=rogerq@ti.com \
    --cc=balbi@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mgautam@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.