From: "Jakub Narębski" <jnareb@gmail.com>
To: Philip Oakley <philipoakley@iee.org>,
GitList <git@vger.kernel.org>, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH v5 09/12] doc: revisions - define `reachable`
Date: Mon, 29 Aug 2016 16:43:32 +0200 [thread overview]
Message-ID: <557eb782-ee45-3e33-33bb-aa88817dcd82@gmail.com> (raw)
In-Reply-To: <EDA7BA88AB1D42C7B4228D71CC28145B@PhilipOakley>
W dniu 29.08.2016 o 15:21, Philip Oakley pisze:
> From: "Jakub Narębski" <jnareb@gmail.com>
> Sent: Sunday, August 28, 2016 2:01 PM
>> W dniu 12.08.2016 o 09:07, Philip Oakley pisze:
[...]
>>> +For these commands,
>>> +specifying a single revision, using the notation described in the
>>> +previous section, means the set of commits `reachable` from the given
>>> +commit.
[...]
>>> +
>>> +A commit's reachable set is the commit itself and the commits in
>>> +its ancestry chain.
>>> +
>>
>> It is all right, but perhaps it would be better to just repeat:
>>
>> +Set of commits reachable from given commit is the commit itself
>> +and all the commits in its ancestry chain.
>
> It's very easy to go around in circles here. The original issue was
> the A..B notation for the case where A is a direct descendant of B,
> such that new users, or users more familiar with range notations from
> elsewhere, would expect that the A..B range is *inclusive*, rather
> than an open / closed interval. It was the addressing of that problem
> that lead to the updating of the 'reachability' definition.
All right, I can see that. It is a worthwhile goal.
> The main part of my sentence formation was to make the 'reachable'
> part the defining element, rather than being a feature of the set.
> Maybe it's using the 'set' viewpoint that is distracting?>>
One one hand, the "A commit's reachable set is ..." approach puts
'reachable' upfront. On the other hand it introduces new terminology,
namely 'reachable set' (or 'reachable set of a commit' to be more
exact)... it doesn't read that well to me, but I am not a native
speaker.
But as I wrote, this is quite all right anyway
--
Jakub Narębski
next prev parent reply other threads:[~2016-08-29 14:43 UTC|newest]
Thread overview: 107+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-22 7:25 name for A..B ranges? Philip Oakley
2016-06-24 16:09 ` Jeff King
2016-06-24 16:44 ` Junio C Hamano
2016-06-25 13:50 ` Philip Oakley
2016-06-25 16:46 ` [PATCH 0/2] " Philip Oakley
2016-06-25 16:46 ` [PATCH 1/2] doc: use 'symmetric difference' consistently Philip Oakley
2016-06-25 16:46 ` [PATCH 2/2] doc: give headings for the two and three dot notations Philip Oakley
2016-06-25 18:47 ` [PATCH] doc: show the actual left, right, and boundary marks Philip Oakley
2016-06-30 20:25 ` [PATCH v2 0/4] Name for A..B ranges? Philip Oakley
2016-06-30 20:25 ` [PATCH v2 1/4] doc: use 'symmetric difference' consistently Philip Oakley
2016-06-30 20:25 ` [PATCH v2 2/4] doc: show the actual left, right, and boundary marks Philip Oakley
2016-06-30 20:25 ` [PATCH v2 3/4] doc: give headings for the two and three dot notations Philip Oakley
2016-06-30 20:25 ` [PATCH v2 4/4] doc: clarify that `^r1` will exclude `r1` itself Philip Oakley
2016-07-01 21:16 ` Junio C Hamano
2016-07-01 22:08 ` Philip Oakley
2016-07-01 22:14 ` Junio C Hamano
2016-07-01 23:01 ` Junio C Hamano
2016-07-10 21:17 ` Philip Oakley
2016-07-01 21:27 ` [PATCH v2 0/4] Name for A..B ranges? Junio C Hamano
2016-07-11 20:25 ` [PATCH v3 0/8] " Philip Oakley
2016-07-11 20:25 ` [PATCH v3 1/8] doc: use 'symmetric difference' consistently Philip Oakley
2016-07-11 20:25 ` [PATCH v3 2/8] doc: revisions - name the Left and Right sides Philip Oakley
2016-07-12 16:47 ` Junio C Hamano
2016-07-12 21:47 ` Philip Oakley
2016-07-11 20:25 ` [PATCH v3 3/8] doc: show the actual left, right, and boundary marks Philip Oakley
2016-07-11 20:25 ` [PATCH v3 4/8] doc: give headings for the two and three dot notations Philip Oakley
2016-07-12 13:44 ` Marc Branchaud
2016-07-12 17:04 ` Junio C Hamano
2016-07-12 22:11 ` Philip Oakley
2016-07-19 16:03 ` Jakub Narębski
2016-07-19 19:15 ` Philip Oakley
2016-07-12 21:41 ` Philip Oakley
2016-07-12 22:12 ` Jeff King
2016-07-11 20:25 ` [PATCH v3 5/8] doc: gitrevisions - use 'reachable' in page description Philip Oakley
2016-07-11 20:25 ` [PATCH v3 6/8] doc: gitrevisions - clarify 'latter case' is revision walk Philip Oakley
2016-07-11 20:25 ` [PATCH v3 7/8] doc: revisions - define `reachable` Philip Oakley
2016-07-12 13:48 ` Marc Branchaud
2016-07-12 21:44 ` Philip Oakley
2016-07-11 20:25 ` [PATCH v3 8/8] doc: revisions - clarify reachability examples Philip Oakley
2016-07-12 19:29 ` [PATCH v3 0/8] Name for A..B ranges? Junio C Hamano
2016-07-12 22:29 ` Philip Oakley
2016-07-20 21:09 ` [PATCH v4 " Philip Oakley
2016-07-20 21:10 ` [PATCH v4 1/8] doc: use 'symmetric difference' consistently Philip Oakley
2016-07-20 21:10 ` [PATCH v4 2/8] doc: revisions - name the left and right sides Philip Oakley
2016-07-20 21:10 ` [PATCH v4 3/8] doc: show the actual left, right, and boundary marks Philip Oakley
2016-07-20 21:10 ` [PATCH v4 4/8] doc: give headings for the two and three dot notations Philip Oakley
2016-07-21 14:42 ` Marc Branchaud
2016-07-21 19:54 ` Philip Oakley
2016-07-21 21:20 ` Marc Branchaud
2016-07-22 22:46 ` Junio C Hamano
2016-07-20 21:10 ` [PATCH v4 5/8] doc: gitrevisions - use 'reachable' in page description Philip Oakley
2016-07-20 21:10 ` [PATCH v4 6/8] doc: gitrevisions - clarify 'latter case' is revision walk Philip Oakley
2016-07-20 21:10 ` [PATCH v4 7/8] doc: revisions - define `reachable` Philip Oakley
2016-07-20 21:10 ` [PATCH v4 8/8] doc: revisions - clarify reachability examples Philip Oakley
2016-07-20 22:22 ` [PATCH v4 0/8] Name for A..B ranges? Junio C Hamano
2016-08-11 21:50 ` [PATCH v5 00/12] Update git revisions Philip Oakley
2016-08-11 21:50 ` [PATCH v5 01/12] doc: use 'symmetric difference' consistently Philip Oakley
2016-08-26 11:33 ` Jakub Narębski
2016-08-26 16:09 ` Junio C Hamano
2016-08-11 22:32 ` [PATCH v5 00/12] Update git revisions Philip Oakley
2016-08-12 23:45 ` [PATCH v6 " Philip Oakley
2016-08-12 23:45 ` [PATCH v6 05/12] doc: revisions: extra clarification of <rev>^! notation effects Philip Oakley
2016-08-12 23:45 ` [PATCH v6 06/12] doc: revisions: single vs multi-parent notation comparison Philip Oakley
2016-08-26 15:30 ` Jakub Narębski
2016-08-26 16:19 ` Junio C Hamano
2016-08-12 23:45 ` [PATCH v6 11/12] doc: revisions: show revision expansion in examples Philip Oakley
2016-08-12 23:45 ` [PATCH v6 12/12] doc: revisions: sort examples and fix alignment of the unchanged Philip Oakley
2016-08-15 14:30 ` [PATCH v6 00/12] Update git revisions Marc Branchaud
2016-08-15 15:00 ` Philip Oakley
2016-08-15 16:55 ` BUG: indent-with-non-tab always on (was: Re: [PATCH v6 00/12] Update git revisions) Marc Branchaud
2016-08-15 17:54 ` BUG: indent-with-non-tab always on Marc Branchaud
2016-08-15 17:06 ` [PATCH v6 00/12] Update git revisions Junio C Hamano
2016-08-31 16:22 ` Junio C Hamano
2016-08-11 23:03 ` [PATCH v5 " Philip Oakley
2016-08-11 23:03 ` [PATCH v5 01/12] doc: use 'symmetric difference' consistently Philip Oakley
2016-08-12 7:07 ` [PATCH v5 00/12] Update git revisions Philip Oakley
2016-08-12 7:07 ` [PATCH v5 01/12] doc: use 'symmetric difference' consistently Philip Oakley
2016-08-12 7:07 ` [PATCH v5 02/12] doc: revisions - name the left and right sides Philip Oakley
2016-08-12 7:07 ` [PATCH v5 03/12] doc: show the actual left, right, and boundary marks Philip Oakley
2016-08-12 7:07 ` [PATCH v5 04/12] doc: revisions: give headings for the two and three dot notations Philip Oakley
2016-08-12 7:10 ` Jeff King
2016-08-12 14:37 ` Marc Branchaud
2016-08-12 7:07 ` [PATCH v5 05/12] doc: revisions: extra clarification of <rev>^! notation effects Philip Oakley
2016-08-12 14:39 ` Marc Branchaud
2016-08-12 22:17 ` Philip Oakley
2016-08-12 7:07 ` [PATCH v5 06/12] doc: revisions: single vs multi-parent notation comparison Philip Oakley
2016-08-12 14:40 ` Marc Branchaud
2016-08-12 22:23 ` Philip Oakley
2016-08-12 7:07 ` [PATCH v5 07/12] doc: gitrevisions - use 'reachable' in page description Philip Oakley
2016-08-12 7:07 ` [PATCH v5 08/12] doc: gitrevisions - clarify 'latter case' is revision walk Philip Oakley
2016-08-12 7:07 ` [PATCH v5 09/12] doc: revisions - define `reachable` Philip Oakley
2016-08-28 13:01 ` Jakub Narębski
2016-08-29 13:21 ` Philip Oakley
2016-08-29 14:43 ` Jakub Narębski [this message]
2016-08-29 19:27 ` Philip Oakley
2016-08-12 7:07 ` [PATCH v5 10/12] doc: revisions - clarify reachability examples Philip Oakley
2016-08-12 7:07 ` [PATCH v5 11/12] doc: revisions: show revision expansion in examples Philip Oakley
2016-08-12 15:22 ` Marc Branchaud
2016-08-12 22:45 ` Philip Oakley
2016-08-12 7:07 ` [PATCH v5 12/12] doc: revisions: sort examples and fix alignment of the unchanged Philip Oakley
2016-08-12 15:28 ` [PATCH v5 00/12] Update git revisions Marc Branchaud
2016-08-12 19:20 ` Philip Oakley
2016-08-12 21:27 ` Junio C Hamano
2016-06-25 19:49 ` name for A..B ranges? Junio C Hamano
2016-06-27 13:37 ` Philip Oakley
2016-06-27 15:08 ` Junio C Hamano
2016-06-27 15:39 ` Philip Oakley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=557eb782-ee45-3e33-33bb-aa88817dcd82@gmail.com \
--to=jnareb@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=philipoakley@iee.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.