All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH acm] acme.c: Fix IPv6 address handling in inet_any_pton
@ 2015-06-16 13:37 Hal Rosenstock
       [not found] ` <558026A4.3090907-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
  0 siblings, 1 reply; 3+ messages in thread
From: Hal Rosenstock @ 2015-06-16 13:37 UTC (permalink / raw)
  To: Hefty, Sean
  Cc: linux-rdma (linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org),
	Ilya Nelkenbaum, Ilya Nelkenbaum

From: Ilya Nelkenbaum <ilyan-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>

In inet_any_pton() routine, src_addr was used by mistake
instead of addr argument.

Signed-off-by: Ilya Nelkenbaum <ilyan-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Signed-off-by: Hal Rosenstock <hal-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
---
 acm/src/acme.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/acm/src/acme.c b/acm/src/acme.c
index 9bf7557..d54c8b9 100644
--- a/acm/src/acme.c
+++ b/acm/src/acme.c
@@ -787,7 +787,7 @@ static int inet_any_pton(char *addr, struct sockaddr *sa)
 	if (ret <= 0) {
 		sin6 = (struct sockaddr_in6 *) sa;
 		sa->sa_family = AF_INET6;
-		ret = inet_pton(AF_INET6, src_addr, &sin6->sin6_addr);
+		ret = inet_pton(AF_INET6, addr, &sin6->sin6_addr);
 	}
 
 	return ret;
-- 
1.7.1

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* RE: [PATCH acm] acme.c: Fix IPv6 address handling in inet_any_pton
       [not found] ` <558026A4.3090907-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
@ 2015-06-17  5:50   ` Hefty, Sean
       [not found]     ` <1828884A29C6694DAF28B7E6B8A82373A8FF64BF-P5GAC/sN6hkd3b2yrw5b5LfspsVTdybXVpNB7YpNyf8@public.gmane.org>
  0 siblings, 1 reply; 3+ messages in thread
From: Hefty, Sean @ 2015-06-17  5:50 UTC (permalink / raw)
  To: Hal Rosenstock
  Cc: linux-rdma (linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org),
	Ilya Nelkenbaum, Ilya Nelkenbaum

Thanks - applied manually

>  acm/src/acme.c |    2 +-

Path?

> diff --git a/acm/src/acme.c b/acm/src/acme.c
> index 9bf7557..d54c8b9 100644
> --- a/acm/src/acme.c
> +++ b/acm/src/acme.c
> @@ -787,7 +787,7 @@ static int inet_any_pton(char *addr, struct sockaddr

This was off by a couple hundred lines.  Can you check your branch?

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH acm] acme.c: Fix IPv6 address handling in inet_any_pton
       [not found]     ` <1828884A29C6694DAF28B7E6B8A82373A8FF64BF-P5GAC/sN6hkd3b2yrw5b5LfspsVTdybXVpNB7YpNyf8@public.gmane.org>
@ 2015-06-17 10:09       ` Hal Rosenstock
  0 siblings, 0 replies; 3+ messages in thread
From: Hal Rosenstock @ 2015-06-17 10:09 UTC (permalink / raw)
  To: Hefty, Sean
  Cc: linux-rdma (linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org),
	Ilya Nelkenbaum, Ilya Nelkenbaum

On 6/17/2015 1:50 AM, Hefty, Sean wrote:
> Thanks - applied manually

Thanks.

>>  acm/src/acme.c |    2 +-
> 
> Path?
> 
>> diff --git a/acm/src/acme.c b/acm/src/acme.c
>> index 9bf7557..d54c8b9 100644
>> --- a/acm/src/acme.c
>> +++ b/acm/src/acme.c
>> @@ -787,7 +787,7 @@ static int inet_any_pton(char *addr, struct sockaddr
> 
> This was off by a couple hundred lines.  Can you check your branch?

My bad; patch I sent was against SSA ACM. I only compared code to see it
was needed upstream and forgot to port it against upstream tree.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-06-17 10:09 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-06-16 13:37 [PATCH acm] acme.c: Fix IPv6 address handling in inet_any_pton Hal Rosenstock
     [not found] ` <558026A4.3090907-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2015-06-17  5:50   ` Hefty, Sean
     [not found]     ` <1828884A29C6694DAF28B7E6B8A82373A8FF64BF-P5GAC/sN6hkd3b2yrw5b5LfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-06-17 10:09       ` Hal Rosenstock

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.