* [PATCH v3 2/2] staging: comedi: das16m1: fix lines over 80 characters
@ 2015-06-22 13:03 Luis de Bethencourt
2015-06-22 14:15 ` Ian Abbott
0 siblings, 1 reply; 2+ messages in thread
From: Luis de Bethencourt @ 2015-06-22 13:03 UTC (permalink / raw)
To: linux-kernel
Cc: Ian Abbott, H Hartley Sweeten, Greg Kroah-Hartman, Jaime Arrocha
Warnings found by checkpatch.pl
WARNING: line over 80 characters
/drivers/staging/comedi/drivers/das16m1.c:414
+ if (devpriv->adc_count == 0 && hw_counter == devpriv->initial_hw_count) {
/drivers/staging/comedi/drivers/das16m1.c:417
/drivers/staging/comedi/drivers/das16m1.c:418
/drivers/staging/comedi/drivers/das16m1.c:419
/drivers/staging/comedi/drivers/das16m1.c:420
/drivers/staging/comedi/drivers/das16m1.c:421
Signed-off-by: Luis de Bethencourt <luis@debethencourt.com>
---
drivers/staging/comedi/drivers/das16m1.c | 17 ++++++++++-------
1 file changed, 10 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/comedi/drivers/das16m1.c b/drivers/staging/comedi/drivers/das16m1.c
index a991c97..1f19388 100644
--- a/drivers/staging/comedi/drivers/das16m1.c
+++ b/drivers/staging/comedi/drivers/das16m1.c
@@ -411,15 +411,18 @@ static void das16m1_handler(struct comedi_device *dev, unsigned int status)
hw_counter = comedi_8254_read(devpriv->counter, 1);
/* make sure hardware counter reading is not bogus due to initial value
* not having been loaded yet */
- if (devpriv->adc_count == 0 && hw_counter == devpriv->initial_hw_count) {
+ if (devpriv->adc_count == 0 &&
+ hw_counter == devpriv->initial_hw_count) {
num_samples = 0;
} else {
- /* The calculation of num_samples looks odd, but it uses the following facts.
- * 16 bit hardware counter is initialized with value of zero (which really
- * means 0x1000). The counter decrements by one on each conversion
- * (when the counter decrements from zero it goes to 0xffff). num_samples
- * is a 16 bit variable, so it will roll over in a similar fashion to the
- * hardware counter. Work it out, and this is what you get. */
+ /* The calculation of num_samples looks odd, but it uses the
+ * following facts. 16 bit hardware counter is initialized with
+ * value of zero (which really means 0x1000). The counter
+ * decrements by one on each conversion (when the counter
+ * decrements from zero it goes to 0xffff). num_samples is a
+ * 16 bit variable, so it will roll over in a similar fashion
+ * to the hardware counter. Work it out, and this is what you
+ * get. */
num_samples = -hw_counter - devpriv->adc_count;
}
/* check if we only need some of the points */
--
2.1.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at http://www.tux.org/lkml/
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v3 2/2] staging: comedi: das16m1: fix lines over 80 characters
2015-06-22 13:03 [PATCH v3 2/2] staging: comedi: das16m1: fix lines over 80 characters Luis de Bethencourt
@ 2015-06-22 14:15 ` Ian Abbott
0 siblings, 0 replies; 2+ messages in thread
From: Ian Abbott @ 2015-06-22 14:15 UTC (permalink / raw)
To: Luis de Bethencourt, linux-kernel
Cc: H Hartley Sweeten, Greg Kroah-Hartman, Jaime Arrocha
On 22/06/15 14:03, Luis de Bethencourt wrote:
> Warnings found by checkpatch.pl
> WARNING: line over 80 characters
> /drivers/staging/comedi/drivers/das16m1.c:414
> + if (devpriv->adc_count == 0 && hw_counter == devpriv->initial_hw_count) {
>
> /drivers/staging/comedi/drivers/das16m1.c:417
> /drivers/staging/comedi/drivers/das16m1.c:418
> /drivers/staging/comedi/drivers/das16m1.c:419
> /drivers/staging/comedi/drivers/das16m1.c:420
> /drivers/staging/comedi/drivers/das16m1.c:421
>
> Signed-off-by: Luis de Bethencourt <luis@debethencourt.com>
> ---
> drivers/staging/comedi/drivers/das16m1.c | 17 ++++++++++-------
> 1 file changed, 10 insertions(+), 7 deletions(-)
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at http://www.tux.org/lkml/
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-06-22 14:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-06-22 13:03 [PATCH v3 2/2] staging: comedi: das16m1: fix lines over 80 characters Luis de Bethencourt
2015-06-22 14:15 ` Ian Abbott
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.