From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Hornyack <peterhornyack@google.com>,
"Denis V. Lunev" <den@openvz.org>
Cc: kvm@vger.kernel.org, qemu-devel@nongnu.org,
Andrey Smetanin <asmetanin@virtuozzo.com>,
Gleb Natapov <gleb@kernel.org>
Subject: Re: [PATCH 09/11] kvm/x86: distingiush hyper-v guest crash notification
Date: Tue, 23 Jun 2015 11:52:29 +0200 [thread overview]
Message-ID: <55892C5D.40702@redhat.com> (raw)
In-Reply-To: <CA+0KQ4OAH+6Ua4w998HeiYW9u5grKVZH3QFOT6292vJDZ1v0uA@mail.gmail.com>
On 23/06/2015 01:55, Peter Hornyack wrote:
>> > -static int kvm_hv_msr_set_crash_ctl(struct kvm_vcpu *vcpu, u64 data)
>> > +static int kvm_hv_msr_set_crash_ctl(struct kvm_vcpu *vcpu, u64 data, bool host)
>> > {
>> > struct kvm_arch_hyperv *hv = &vcpu->kvm->arch.hyperv;
>> >
>> > hv->hv_crash_ctl = data;
> Should we allow hv_crash_ctl to be set if !host? It's a small detail,
> but it doesn't seem like the guest should be able to disable crash
> actions that userspace has enabled in hv_crash_ctl.
No, the MSR contents shouldn't be writable.
Paolo
WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Hornyack <peterhornyack@google.com>,
"Denis V. Lunev" <den@openvz.org>
Cc: Andrey Smetanin <asmetanin@virtuozzo.com>,
Gleb Natapov <gleb@kernel.org>,
qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: Re: [Qemu-devel] [PATCH 09/11] kvm/x86: distingiush hyper-v guest crash notification
Date: Tue, 23 Jun 2015 11:52:29 +0200 [thread overview]
Message-ID: <55892C5D.40702@redhat.com> (raw)
In-Reply-To: <CA+0KQ4OAH+6Ua4w998HeiYW9u5grKVZH3QFOT6292vJDZ1v0uA@mail.gmail.com>
On 23/06/2015 01:55, Peter Hornyack wrote:
>> > -static int kvm_hv_msr_set_crash_ctl(struct kvm_vcpu *vcpu, u64 data)
>> > +static int kvm_hv_msr_set_crash_ctl(struct kvm_vcpu *vcpu, u64 data, bool host)
>> > {
>> > struct kvm_arch_hyperv *hv = &vcpu->kvm->arch.hyperv;
>> >
>> > hv->hv_crash_ctl = data;
> Should we allow hv_crash_ctl to be set if !host? It's a small detail,
> but it doesn't seem like the guest should be able to disable crash
> actions that userspace has enabled in hv_crash_ctl.
No, the MSR contents shouldn't be writable.
Paolo
next prev parent reply other threads:[~2015-06-23 9:52 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-22 16:04 [PATCH v2 0/11] HyperV equivalent of pvpanic driver Denis V. Lunev
2015-06-22 16:04 ` [Qemu-devel] " Denis V. Lunev
2015-06-22 16:04 ` [PATCH 01/11] kvm/x86: move Hyper-V MSR's/hypercall code into hyperv.c file Denis V. Lunev
2015-06-22 16:04 ` [Qemu-devel] " Denis V. Lunev
2015-06-25 10:25 ` Denis V. Lunev
2015-06-25 10:25 ` [Qemu-devel] " Denis V. Lunev
2015-06-25 10:26 ` Paolo Bonzini
2015-06-25 10:26 ` [Qemu-devel] " Paolo Bonzini
2015-06-22 16:04 ` [PATCH 02/11] kvm: introduce vcpu_debug = kvm_debug + vcpu context Denis V. Lunev
2015-06-22 16:04 ` [Qemu-devel] " Denis V. Lunev
2015-06-22 16:05 ` [PATCH 03/11] kvm: add hyper-v crash msrs constants Denis V. Lunev
2015-06-22 16:05 ` [Qemu-devel] " Denis V. Lunev
2015-06-22 16:05 ` [PATCH 04/11] kvm/x86: added hyper-v crash msrs into kvm hyperv context Denis V. Lunev
2015-06-22 16:05 ` [Qemu-devel] " Denis V. Lunev
2015-06-22 16:05 ` [PATCH 05/11] kvm: added KVM_REQ_HV_CRASH value to notify qemu about Hyper-V crash Denis V. Lunev
2015-06-22 16:05 ` [Qemu-devel] " Denis V. Lunev
2015-06-22 16:05 ` [PATCH 06/11] kvm/x86: mark hyper-v crash msrs as partition wide Denis V. Lunev
2015-06-22 16:05 ` [Qemu-devel] " Denis V. Lunev
2015-06-22 16:05 ` [PATCH 07/11] kvm/x86: added hyper-v crash data and ctl msr's get/set'ers Denis V. Lunev
2015-06-22 16:05 ` [Qemu-devel] " Denis V. Lunev
2015-06-22 23:52 ` Peter Hornyack
2015-06-22 23:52 ` [Qemu-devel] " Peter Hornyack
2015-06-23 9:47 ` Denis V. Lunev
2015-06-23 9:47 ` [Qemu-devel] " Denis V. Lunev
2015-06-23 9:51 ` Paolo Bonzini
2015-06-23 9:51 ` [Qemu-devel] " Paolo Bonzini
2015-06-23 10:08 ` Denis V. Lunev
2015-06-23 10:08 ` [Qemu-devel] " Denis V. Lunev
2015-06-23 10:30 ` Paolo Bonzini
2015-06-23 10:30 ` [Qemu-devel] " Paolo Bonzini
2015-06-22 16:05 ` [PATCH 08/11] kvm/x86: add sending hyper-v crash notification to user space Denis V. Lunev
2015-06-22 16:05 ` [Qemu-devel] " Denis V. Lunev
2015-06-22 16:05 ` [PATCH 09/11] kvm/x86: distingiush hyper-v guest crash notification Denis V. Lunev
2015-06-22 16:05 ` [Qemu-devel] " Denis V. Lunev
2015-06-22 16:09 ` Paolo Bonzini
2015-06-22 16:09 ` [Qemu-devel] " Paolo Bonzini
2015-06-22 23:55 ` Peter Hornyack
2015-06-22 23:55 ` [Qemu-devel] " Peter Hornyack
2015-06-23 9:52 ` Paolo Bonzini [this message]
2015-06-23 9:52 ` Paolo Bonzini
2015-06-22 16:05 ` [PATCH 10/11] qemu/kvm: kvm hyper-v based guest crash event handling Denis V. Lunev
2015-06-22 16:05 ` [Qemu-devel] " Denis V. Lunev
2015-06-22 16:15 ` Paolo Bonzini
2015-06-22 16:15 ` [Qemu-devel] " Paolo Bonzini
2015-06-22 16:17 ` Paolo Bonzini
2015-06-22 16:17 ` [Qemu-devel] " Paolo Bonzini
2015-06-22 16:05 ` [PATCH 11/11] qemu/kvm: mark in cpu state that hyper-v crash occured Denis V. Lunev
2015-06-22 16:05 ` [Qemu-devel] " Denis V. Lunev
2015-06-22 16:23 ` Andreas Färber
2015-06-22 16:23 ` [Qemu-devel] " Andreas Färber
2015-06-22 16:27 ` Paolo Bonzini
2015-06-22 16:27 ` [Qemu-devel] " Paolo Bonzini
2015-06-22 16:33 ` Andreas Färber
2015-06-22 16:33 ` [Qemu-devel] " Andreas Färber
2015-06-22 16:35 ` Denis V. Lunev
2015-06-22 16:35 ` [Qemu-devel] " Denis V. Lunev
2015-06-22 16:36 ` Paolo Bonzini
2015-06-22 16:36 ` [Qemu-devel] " Paolo Bonzini
2015-06-22 17:46 ` Andreas Färber
2015-06-22 17:46 ` [Qemu-devel] " Andreas Färber
2015-06-23 9:53 ` Paolo Bonzini
2015-06-23 9:53 ` [Qemu-devel] " Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55892C5D.40702@redhat.com \
--to=pbonzini@redhat.com \
--cc=asmetanin@virtuozzo.com \
--cc=den@openvz.org \
--cc=gleb@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=peterhornyack@google.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.