From: Jens Axboe <axboe@kernel.dk>
To: Omar Sandoval <osandov@osandov.com>,
linux-kernel@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>
Cc: kernel-team@fb.com
Subject: Re: [PATCH] sched/wait: fix add_wait_queue() behavior change
Date: Wed, 6 Dec 2017 09:11:03 -0700 [thread overview]
Message-ID: <5589355c-7b6a-91ff-3916-e60e9ac64d9d@kernel.dk> (raw)
In-Reply-To: <a16c8ccffd39bd08fdaa45a5192294c784b803a7.1512544324.git.osandov@fb.com>
On 12/06/2017 12:15 AM, Omar Sandoval wrote:
> From: Omar Sandoval <osandov@fb.com>
>
> Commit 50816c48997a ("sched/wait: Standardize internal naming of
> wait-queue entries") changed the behavior of add_wait_queue() from
> inserting the wait entry at the head of the wait queue to the tail of
> the wait queue. That commit was a cleanup and didn't mention any
> functional changes so it was likely unintentional. This change in
> behavior theoretically breaks wait queues which mix exclusive and
> non-exclusive waiters, as non-exclusive waiters will not be woken up if
> they are queued behind enough exclusive waiters.
Ingo? You've been silent on this issue, which is somewhat odd since
your cosmetic renaming patch introduced this behavioral change.
Omar, should probably turn that into a proper Fixes: line as
well.
> Signed-off-by: Omar Sandoval <osandov@fb.com>
Reviewed-by: Jens Axboe <axboe@kernel.dk>
--
Jens Axboe
next prev parent reply other threads:[~2017-12-06 16:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-30 0:58 add_wait_queue() (unintentional?) behavior change in v4.13 Omar Sandoval
2017-11-30 2:37 ` Linus Torvalds
2017-12-06 7:15 ` [PATCH] sched/wait: fix add_wait_queue() behavior change Omar Sandoval
2017-12-06 16:11 ` Jens Axboe [this message]
2017-12-06 16:46 ` Ingo Molnar
2017-12-06 20:28 ` [tip:sched/core] sched/wait: Fix add_wait_queue() behavioral change tip-bot for Omar Sandoval
2017-12-06 16:43 ` add_wait_queue() (unintentional?) behavior change in v4.13 Ingo Molnar
2017-12-06 2:35 ` Fubo Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5589355c-7b6a-91ff-3916-e60e9ac64d9d@kernel.dk \
--to=axboe@kernel.dk \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=osandov@osandov.com \
--cc=peterz@infradead.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.