All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fubo Chen <fubo.chen@gmail.com>
To: Omar Sandoval <osandov@osandov.com>
Cc: Ingo Molnar <mingo@kernel.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	Jens Axboe <axboe@fb.com>
Subject: Re: add_wait_queue() (unintentional?) behavior change in v4.13
Date: Tue, 5 Dec 2017 18:35:12 -0800	[thread overview]
Message-ID: <CAJAFBLB1n68o_2mXJuWeQfb1fa3rP4XkZKS=v7Fj-1p9j5O7xA@mail.gmail.com> (raw)
In-Reply-To: <20171130005828.GA15628@vader>

On Wed, Nov 29, 2017 at 4:58 PM, Omar Sandoval <osandov@osandov.com> wrote:
> diff --git a/kernel/sched/wait.c b/kernel/sched/wait.c
> index 98feab7933c7..929ecb7d6b78 100644
> --- a/kernel/sched/wait.c
> +++ b/kernel/sched/wait.c
> @@ -27,7 +27,7 @@ void add_wait_queue(struct wait_queue_head *wq_head, struct wait_queue_entry *wq
>
>         wq_entry->flags &= ~WQ_FLAG_EXCLUSIVE;
>         spin_lock_irqsave(&wq_head->lock, flags);
> -       __add_wait_queue_entry_tail(wq_head, wq_entry);
> +       __add_wait_queue(wq_head, wq_entry);
>         spin_unlock_irqrestore(&wq_head->lock, flags);
>  }
>  EXPORT_SYMBOL(add_wait_queue);

Reviewed-by: Fubo Chen <fubo.chen@gmail.com>

      parent reply	other threads:[~2017-12-06  2:35 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-30  0:58 add_wait_queue() (unintentional?) behavior change in v4.13 Omar Sandoval
2017-11-30  2:37 ` Linus Torvalds
2017-12-06  7:15   ` [PATCH] sched/wait: fix add_wait_queue() behavior change Omar Sandoval
2017-12-06 16:11     ` Jens Axboe
2017-12-06 16:46       ` Ingo Molnar
2017-12-06 20:28     ` [tip:sched/core] sched/wait: Fix add_wait_queue() behavioral change tip-bot for Omar Sandoval
2017-12-06 16:43   ` add_wait_queue() (unintentional?) behavior change in v4.13 Ingo Molnar
2017-12-06  2:35 ` Fubo Chen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJAFBLB1n68o_2mXJuWeQfb1fa3rP4XkZKS=v7Fj-1p9j5O7xA@mail.gmail.com' \
    --to=fubo.chen@gmail.com \
    --cc=axboe@fb.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=osandov@osandov.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.