* [PATCH 0/1] KVM: s390: One small fix for post 4.1
@ 2015-06-22 11:20 Christian Borntraeger
2015-06-22 11:20 ` Christian Borntraeger
0 siblings, 1 reply; 4+ messages in thread
From: Christian Borntraeger @ 2015-06-22 11:20 UTC (permalink / raw)
To: Paolo Bonzini
Cc: Alexander Graf, KVM, Cornelia Huck, Jens Freimann, linux-s390,
Christian Borntraeger
Paolo,
here is a small fixup for KVM on s390. It is also necessary for
4.1 which I am a bit late for - so cc stable.
No pull request as it is only one patch.
Jens Freimann (1):
KVM: s390: clear floating interrupt bitmap and parameters
arch/s390/kvm/interrupt.c | 3 +++
1 file changed, 3 insertions(+)
--
2.3.0
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/1] KVM: s390: clear floating interrupt bitmap and parameters
2015-06-22 11:20 [PATCH 0/1] KVM: s390: One small fix for post 4.1 Christian Borntraeger
@ 2015-06-22 11:20 ` Christian Borntraeger
0 siblings, 0 replies; 4+ messages in thread
From: Christian Borntraeger @ 2015-06-22 11:20 UTC (permalink / raw)
To: Paolo Bonzini
Cc: Alexander Graf, KVM, Cornelia Huck, Jens Freimann, linux-s390,
stable, #,
4.1, Christian Borntraeger
From: Jens Freimann <jfrei@linux.vnet.ibm.com>
commit 6d3da24141 ("KVM: s390: deliver floating interrupts in order
of priority") introduced a regression for the reset handling.
We don't clear the bitmap of pending floating interrupts
and interrupt parameters. This could result in stale interrupts
even after a reset. Let's fix this by clearing the pending bitmap
and the parameters for service and machine check interrupts.
Cc: stable@vger.kernel.org # 4.1
Signed-off-by: Jens Freimann <jfrei@linux.vnet.ibm.com>
Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
---
arch/s390/kvm/interrupt.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/s390/kvm/interrupt.c b/arch/s390/kvm/interrupt.c
index 322ef9c..480b975 100644
--- a/arch/s390/kvm/interrupt.c
+++ b/arch/s390/kvm/interrupt.c
@@ -1621,6 +1621,9 @@ void kvm_s390_clear_float_irqs(struct kvm *kvm)
int i;
spin_lock(&fi->lock);
+ fi->pending_irqs = 0;
+ memset(&fi->srv_signal, 0, sizeof(fi->srv_signal));
+ memset(&fi->mchk, 0, sizeof(fi->mchk));
for (i = 0; i < FIRQ_LIST_COUNT; i++)
clear_irq_list(&fi->lists[i]);
for (i = 0; i < FIRQ_MAX_COUNT; i++)
--
2.3.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 1/1] KVM: s390: clear floating interrupt bitmap and parameters
@ 2015-06-22 11:20 ` Christian Borntraeger
0 siblings, 0 replies; 4+ messages in thread
From: Christian Borntraeger @ 2015-06-22 11:20 UTC (permalink / raw)
To: Paolo Bonzini
Cc: Alexander Graf, KVM, Cornelia Huck, Jens Freimann, linux-s390,
stable, #,
4.1, Christian Borntraeger
From: Jens Freimann <jfrei@linux.vnet.ibm.com>
commit 6d3da24141 ("KVM: s390: deliver floating interrupts in order
of priority") introduced a regression for the reset handling.
We don't clear the bitmap of pending floating interrupts
and interrupt parameters. This could result in stale interrupts
even after a reset. Let's fix this by clearing the pending bitmap
and the parameters for service and machine check interrupts.
Cc: stable@vger.kernel.org # 4.1
Signed-off-by: Jens Freimann <jfrei@linux.vnet.ibm.com>
Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
---
arch/s390/kvm/interrupt.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/s390/kvm/interrupt.c b/arch/s390/kvm/interrupt.c
index 322ef9c..480b975 100644
--- a/arch/s390/kvm/interrupt.c
+++ b/arch/s390/kvm/interrupt.c
@@ -1621,6 +1621,9 @@ void kvm_s390_clear_float_irqs(struct kvm *kvm)
int i;
spin_lock(&fi->lock);
+ fi->pending_irqs = 0;
+ memset(&fi->srv_signal, 0, sizeof(fi->srv_signal));
+ memset(&fi->mchk, 0, sizeof(fi->mchk));
for (i = 0; i < FIRQ_LIST_COUNT; i++)
clear_irq_list(&fi->lists[i]);
for (i = 0; i < FIRQ_MAX_COUNT; i++)
--
2.3.0
--
To unsubscribe from this list: send the line "unsubscribe stable" in
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] KVM: s390: clear floating interrupt bitmap and parameters
2015-06-22 11:20 ` Christian Borntraeger
(?)
@ 2015-06-23 14:39 ` Paolo Bonzini
-1 siblings, 0 replies; 4+ messages in thread
From: Paolo Bonzini @ 2015-06-23 14:39 UTC (permalink / raw)
To: Christian Borntraeger
Cc: Alexander Graf, KVM, Cornelia Huck, Jens Freimann, linux-s390,
stable, #,
4.1
On 22/06/2015 13:20, Christian Borntraeger wrote:
> From: Jens Freimann <jfrei@linux.vnet.ibm.com>
>
> commit 6d3da24141 ("KVM: s390: deliver floating interrupts in order
> of priority") introduced a regression for the reset handling.
>
> We don't clear the bitmap of pending floating interrupts
> and interrupt parameters. This could result in stale interrupts
> even after a reset. Let's fix this by clearing the pending bitmap
> and the parameters for service and machine check interrupts.
>
> Cc: stable@vger.kernel.org # 4.1
> Signed-off-by: Jens Freimann <jfrei@linux.vnet.ibm.com>
> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
> ---
> arch/s390/kvm/interrupt.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/s390/kvm/interrupt.c b/arch/s390/kvm/interrupt.c
> index 322ef9c..480b975 100644
> --- a/arch/s390/kvm/interrupt.c
> +++ b/arch/s390/kvm/interrupt.c
> @@ -1621,6 +1621,9 @@ void kvm_s390_clear_float_irqs(struct kvm *kvm)
> int i;
>
> spin_lock(&fi->lock);
> + fi->pending_irqs = 0;
> + memset(&fi->srv_signal, 0, sizeof(fi->srv_signal));
> + memset(&fi->mchk, 0, sizeof(fi->mchk));
> for (i = 0; i < FIRQ_LIST_COUNT; i++)
> clear_irq_list(&fi->lists[i]);
> for (i = 0; i < FIRQ_MAX_COUNT; i++)
>
Applied, thanks.
Paolo
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-06-23 14:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-06-22 11:20 [PATCH 0/1] KVM: s390: One small fix for post 4.1 Christian Borntraeger
2015-06-22 11:20 ` [PATCH 1/1] KVM: s390: clear floating interrupt bitmap and parameters Christian Borntraeger
2015-06-22 11:20 ` Christian Borntraeger
2015-06-23 14:39 ` Paolo Bonzini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.