linux-next: build failure after merge of the drm-exynos tree

linux-next: build failure after merge of the drm-exynos tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1132 bytes --]

Hi Inki,

After merging the drm-exynos tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/media/i2c/adv7604.o: In function `of_graph_get_endpoint_by_regs':
adv7604.c:(.text+0x586c): multiple definition of `of_graph_get_endpoint_by_regs'
drivers/media/i2c/adv7343.o:adv7343.c:(.text+0xa13): first defined here
drivers/media/platform/soc_camera/atmel-isi.o: In function `of_graph_get_endpoint_by_regs':
atmel-isi.c:(.text+0x1ec9): multiple definition of `of_graph_get_endpoint_by_regs'
drivers/media/platform/soc_camera/soc_camera.o:soc_camera.c:(.text+0x2ce3): first defined here
drivers/media/platform/soc_camera/rcar_vin.o: In function `of_graph_get_endpoint_by_regs':
rcar_vin.c:(.text+0x307c): multiple definition of `of_graph_get_endpoint_by_regs'
drivers/media/platform/soc_camera/soc_camera.o:soc_camera.c:(.text+0x2ce3): first defined here

Caused by commit:

  a0f7001c18ca ("of: add helper for getting endpoint node of specific identifiers")

I have used the drm-exynos from next-20150622 for today.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: linux-next: build failure after merge of the drm-exynos tree

[Inki Dae]

Hi Stephen,

On 2015년 06월 23일 10:52, Stephen Rothwell wrote:
> Hi Inki,
> 
> After merging the drm-exynos tree, today's linux-next build (x86_64
> allmodconfig) failed like this:

Thanks for report.

I found out this problem. That is because below patch missed "static"
when defining of_graph_get_endpoint_by_regs function,
	a0f7001c18ca ("of: add helper for getting endpoint node of specific
identifiers")

For this, I will fix and post it soon.

Thanks,
Inki Dae

> 
> drivers/media/i2c/adv7604.o: In function `of_graph_get_endpoint_by_regs':
> adv7604.c:(.text+0x586c): multiple definition of `of_graph_get_endpoint_by_regs'
> drivers/media/i2c/adv7343.o:adv7343.c:(.text+0xa13): first defined here
> drivers/media/platform/soc_camera/atmel-isi.o: In function `of_graph_get_endpoint_by_regs':
> atmel-isi.c:(.text+0x1ec9): multiple definition of `of_graph_get_endpoint_by_regs'
> drivers/media/platform/soc_camera/soc_camera.o:soc_camera.c:(.text+0x2ce3): first defined here
> drivers/media/platform/soc_camera/rcar_vin.o: In function `of_graph_get_endpoint_by_regs':
> rcar_vin.c:(.text+0x307c): multiple definition of `of_graph_get_endpoint_by_regs'
> drivers/media/platform/soc_camera/soc_camera.o:soc_camera.c:(.text+0x2ce3): first defined here
> 
> Caused by commit:
> 
>   a0f7001c18ca ("of: add helper for getting endpoint node of specific identifiers")
> 
> I have used the drm-exynos from next-20150622 for today.
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the drm-exynos tree

[Inki Dae]

Hi Stephen,

On 2015년 06월 23일 10:52, Stephen Rothwell wrote:
> Hi Inki,
> 
> After merging the drm-exynos tree, today's linux-next build (x86_64
> allmodconfig) failed like this:

Thanks for report.

I found out this problem. That is because below patch missed "static"
when defining of_graph_get_endpoint_by_regs function,
	a0f7001c18ca ("of: add helper for getting endpoint node of specific
identifiers")

For this, I will fix and post it soon.

Thanks,
Inki Dae

> 
> drivers/media/i2c/adv7604.o: In function `of_graph_get_endpoint_by_regs':
> adv7604.c:(.text+0x586c): multiple definition of `of_graph_get_endpoint_by_regs'
> drivers/media/i2c/adv7343.o:adv7343.c:(.text+0xa13): first defined here
> drivers/media/platform/soc_camera/atmel-isi.o: In function `of_graph_get_endpoint_by_regs':
> atmel-isi.c:(.text+0x1ec9): multiple definition of `of_graph_get_endpoint_by_regs'
> drivers/media/platform/soc_camera/soc_camera.o:soc_camera.c:(.text+0x2ce3): first defined here
> drivers/media/platform/soc_camera/rcar_vin.o: In function `of_graph_get_endpoint_by_regs':
> rcar_vin.c:(.text+0x307c): multiple definition of `of_graph_get_endpoint_by_regs'
> drivers/media/platform/soc_camera/soc_camera.o:soc_camera.c:(.text+0x2ce3): first defined here
> 
> Caused by commit:
> 
>   a0f7001c18ca ("of: add helper for getting endpoint node of specific identifiers")
> 
> I have used the drm-exynos from next-20150622 for today.
> 

Re: linux-next: build failure after merge of the drm-exynos tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1318 bytes --]

Hi Dave,

On Tue, 23 Jun 2015 11:52:45 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the drm-exynos tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> drivers/media/i2c/adv7604.o: In function `of_graph_get_endpoint_by_regs':
> adv7604.c:(.text+0x586c): multiple definition of `of_graph_get_endpoint_by_regs'
> drivers/media/i2c/adv7343.o:adv7343.c:(.text+0xa13): first defined here
> drivers/media/platform/soc_camera/atmel-isi.o: In function `of_graph_get_endpoint_by_regs':
> atmel-isi.c:(.text+0x1ec9): multiple definition of `of_graph_get_endpoint_by_regs'
> drivers/media/platform/soc_camera/soc_camera.o:soc_camera.c:(.text+0x2ce3): first defined here
> drivers/media/platform/soc_camera/rcar_vin.o: In function `of_graph_get_endpoint_by_regs':
> rcar_vin.c:(.text+0x307c): multiple definition of `of_graph_get_endpoint_by_regs'
> drivers/media/platform/soc_camera/soc_camera.o:soc_camera.c:(.text+0x2ce3): first defined here
> 
> Caused by commit:
> 
>   a0f7001c18ca ("of: add helper for getting endpoint node of specific identifiers")

This failure is now in the drm tree (where above patch is commit
8ccd0d0ca041).  I have used the patch from Inki for today.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: linux-next: build failure after merge of the drm-exynos tree

[Inki Dae]

Hi Dave and Stephen,

On 2015년 06월 24일 10:01, Stephen Rothwell wrote:
> Hi Dave,
> 
> On Tue, 23 Jun 2015 11:52:45 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>>
>> After merging the drm-exynos tree, today's linux-next build (x86_64
>> allmodconfig) failed like this:
>>
>> drivers/media/i2c/adv7604.o: In function `of_graph_get_endpoint_by_regs':
>> adv7604.c:(.text+0x586c): multiple definition of `of_graph_get_endpoint_by_regs'
>> drivers/media/i2c/adv7343.o:adv7343.c:(.text+0xa13): first defined here
>> drivers/media/platform/soc_camera/atmel-isi.o: In function `of_graph_get_endpoint_by_regs':
>> atmel-isi.c:(.text+0x1ec9): multiple definition of `of_graph_get_endpoint_by_regs'
>> drivers/media/platform/soc_camera/soc_camera.o:soc_camera.c:(.text+0x2ce3): first defined here
>> drivers/media/platform/soc_camera/rcar_vin.o: In function `of_graph_get_endpoint_by_regs':
>> rcar_vin.c:(.text+0x307c): multiple definition of `of_graph_get_endpoint_by_regs'
>> drivers/media/platform/soc_camera/soc_camera.o:soc_camera.c:(.text+0x2ce3): first defined here
>>
>> Caused by commit:
>>
>>   a0f7001c18ca ("of: add helper for getting endpoint node of specific identifiers")
> 
> This failure is now in the drm tree (where above patch is commit
> 8ccd0d0ca041).  I have used the patch from Inki for today.

As you know, I posted below patch which fixes the build error,
	[PATCH] of: fix a build error to f_graph_get_endpoint_by_regs function

However, I think we need Acked-by from device tree maintainer to merge
it to drm-next.

Thanks,
Inki Dae

> 

Re: linux-next: build failure after merge of the drm-exynos tree

[Dave Airlie]

> > Hi Dave,
> > 
> > On Tue, 23 Jun 2015 11:52:45 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >>
> >> After merging the drm-exynos tree, today's linux-next build (x86_64
> >> allmodconfig) failed like this:
> >>
> >> drivers/media/i2c/adv7604.o: In function `of_graph_get_endpoint_by_regs':
> >> adv7604.c:(.text+0x586c): multiple definition of `of_graph_get_endpoint_by_regs'
> >> drivers/media/i2c/adv7343.o:adv7343.c:(.text+0xa13): first defined here
> >> drivers/media/platform/soc_camera/atmel-isi.o: In function `of_graph_get_endpoint_by_regs':
> >> atmel-isi.c:(.text+0x1ec9): multiple definition of `of_graph_get_endpoint_by_regs'
> >> drivers/media/platform/soc_camera/soc_camera.o:soc_camera.c:(.text+0x2ce3): first defined here
> >> drivers/media/platform/soc_camera/rcar_vin.o: In function `of_graph_get_endpoint_by_regs':
> >> rcar_vin.c:(.text+0x307c): multiple definition of `of_graph_get_endpoint_by_regs'
> >> drivers/media/platform/soc_camera/soc_camera.o:soc_camera.c:(.text+0x2ce3): first defined here
> >>
> >> Caused by commit:
> >>
> >>   a0f7001c18ca ("of: add helper for getting endpoint node of specific identifiers")
> > 
> > This failure is now in the drm tree (where above patch is commit
> > 8ccd0d0ca041).  I have used the patch from Inki for today.
> 
> As you know, I posted below patch which fixes the build error,
> 	[PATCH] of: fix a build error to f_graph_get_endpoint_by_regs function
> 
> However, I think we need Acked-by from device tree maintainer to merge
> it to drm-next.
> 

In times like this I usually go with forgivness rather than permission,
also previous Ack's are good enough for me to cover build problems.

I've pushed the fix to drm-next.

Dave.

Re: linux-next: build failure after merge of the drm-exynos tree

[Inki Dae]

On 2015년 06월 24일 10:21, Inki Dae wrote:
> Hi Dave and Stephen,
> 
> On 2015년 06월 24일 10:01, Stephen Rothwell wrote:
>> Hi Dave,
>>
>> On Tue, 23 Jun 2015 11:52:45 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>>>
>>> After merging the drm-exynos tree, today's linux-next build (x86_64
>>> allmodconfig) failed like this:
>>>
>>> drivers/media/i2c/adv7604.o: In function `of_graph_get_endpoint_by_regs':
>>> adv7604.c:(.text+0x586c): multiple definition of `of_graph_get_endpoint_by_regs'
>>> drivers/media/i2c/adv7343.o:adv7343.c:(.text+0xa13): first defined here
>>> drivers/media/platform/soc_camera/atmel-isi.o: In function `of_graph_get_endpoint_by_regs':
>>> atmel-isi.c:(.text+0x1ec9): multiple definition of `of_graph_get_endpoint_by_regs'
>>> drivers/media/platform/soc_camera/soc_camera.o:soc_camera.c:(.text+0x2ce3): first defined here
>>> drivers/media/platform/soc_camera/rcar_vin.o: In function `of_graph_get_endpoint_by_regs':
>>> rcar_vin.c:(.text+0x307c): multiple definition of `of_graph_get_endpoint_by_regs'
>>> drivers/media/platform/soc_camera/soc_camera.o:soc_camera.c:(.text+0x2ce3): first defined here
>>>
>>> Caused by commit:
>>>
>>>   a0f7001c18ca ("of: add helper for getting endpoint node of specific identifiers")
>>
>> This failure is now in the drm tree (where above patch is commit
>> 8ccd0d0ca041).  I have used the patch from Inki for today.
> 
> As you know, I posted below patch which fixes the build error,
> 	[PATCH] of: fix a build error to f_graph_get_endpoint_by_regs function
> 
> However, I think we need Acked-by from device tree maintainer to merge
> it to drm-next.

Sorry, Rob did already Acked-by. :)

Thanks,
Inki Dae

> 
> Thanks,
> Inki Dae
> 
>>
> 

Re: linux-next: build failure after merge of the drm-exynos tree

[Stephen Rothwell]

Hi Inki,

On Mon, 17 Aug 2015 16:08:36 +0900 Inki Dae <inki.dae@samsung.com> wrote:
>
> And today, I re-based exynos-drm/for-next on top of mainline. Could you
> update and try to build it again?

It is OK in today's linux-next.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

Re: linux-next: build failure after merge of the drm-exynos tree

[Inki Dae]

Hi Stephen,

On 2015년 08월 17일 14:53, Stephen Rothwell wrote:
> Hi Inki,
> 
> On Mon, 17 Aug 2015 13:53:42 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>>
>> On Mon, 17 Aug 2015 13:51:30 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>>>
>>> After merging the drm-exynos tree, today's linux-next build (arm
>>> multi_v7_defconfig) failed like this:
>>>
>>> drivers/gpu/drm/exynos/exynos_mixer.c: In function 'vp_video_buffer':
>>> drivers/gpu/drm/exynos/exynos_mixer.c:395:15: error: 'struct exynos_drm_plane' has no member named 'pixel_format'
>>>   switch (plane->pixel_format) {
>>>                ^
>>> In file included from drivers/gpu/drm/exynos/exynos_mixer.c:17:0:
>>> drivers/gpu/drm/exynos/exynos_mixer.c:404:10: error: 'struct exynos_drm_plane' has no member named 'pixel_format'
>>>      plane->pixel_format);
>>>           ^
>>> include/drm/drmP.h:164:17: note: in definition of macro 'DRM_ERROR'
>>>   drm_err(fmt, ##__VA_ARGS__)
>>>                  ^
>>> drivers/gpu/drm/exynos/exynos_mixer.c:411:11: error: 'struct exynos_drm_plane' has no member named 'scan_flag'
>>>   if (plane->scan_flag & DRM_MODE_FLAG_INTERLACE) {
>>>            ^
>>> drivers/gpu/drm/exynos/exynos_mixer.c:417:39: error: 'struct exynos_drm_plane' has no member named 'pitch'
>>>     luma_addr[1] = luma_addr[0] + plane->pitch;
>>>                                        ^
>>> drivers/gpu/drm/exynos/exynos_mixer.c:418:43: error: 'struct exynos_drm_plane' has no member named 'pitch'
>>>     chroma_addr[1] = chroma_addr[0] + plane->pitch;
>>>                                            ^
>>> In file included from drivers/gpu/drm/exynos/exynos_mixer.c:20:0:
>>> drivers/gpu/drm/exynos/exynos_mixer.c:439:53: error: 'struct exynos_drm_plane' has no member named 'pitch'
>>>   vp_reg_write(res, VP_IMG_SIZE_Y, VP_IMG_HSIZE(plane->pitch) |
>>>                                                      ^
>>> drivers/gpu/drm/exynos/regs-vp.h:59:5: note: in definition of macro 'VP_MASK_VAL'
>>>   (((val) << (low_bit)) & VP_MASK(high_bit, low_bit))
>>>      ^
>>> drivers/gpu/drm/exynos/exynos_mixer.c:439:35: note: in expansion of macro 'VP_IMG_HSIZE'
>>>   vp_reg_write(res, VP_IMG_SIZE_Y, VP_IMG_HSIZE(plane->pitch) |
>>>                                    ^
>>> drivers/gpu/drm/exynos/exynos_mixer.c:440:21: error: 'struct exynos_drm_plane' has no member named 'fb_height'
>>>    VP_IMG_VSIZE(plane->fb_height));
>>>                      ^
>>> drivers/gpu/drm/exynos/regs-vp.h:59:5: note: in definition of macro 'VP_MASK_VAL'
>>>   (((val) << (low_bit)) & VP_MASK(high_bit, low_bit))
>>>      ^
>>> drivers/gpu/drm/exynos/exynos_mixer.c:440:3: note: in expansion of macro 'VP_IMG_VSIZE'
>>>    VP_IMG_VSIZE(plane->fb_height));
>>>    ^
>>> drivers/gpu/drm/exynos/exynos_mixer.c:442:53: error: 'struct exynos_drm_plane' has no member named 'pitch'
>>>   vp_reg_write(res, VP_IMG_SIZE_C, VP_IMG_HSIZE(plane->pitch) |
>>>                                                      ^
>>> drivers/gpu/drm/exynos/regs-vp.h:59:5: note: in definition of macro 'VP_MASK_VAL'
>>>   (((val) << (low_bit)) & VP_MASK(high_bit, low_bit))
>>>      ^
>>> drivers/gpu/drm/exynos/exynos_mixer.c:442:35: note: in expansion of macro 'VP_IMG_HSIZE'
>>>   vp_reg_write(res, VP_IMG_SIZE_C, VP_IMG_HSIZE(plane->pitch) |
>>>                                    ^
>>> drivers/gpu/drm/exynos/exynos_mixer.c:443:21: error: 'struct exynos_drm_plane' has no member named 'fb_height'
>>>    VP_IMG_VSIZE(plane->fb_height / 2));
>>>                      ^
>>> drivers/gpu/drm/exynos/regs-vp.h:59:5: note: in definition of macro 'VP_MASK_VAL'
>>>   (((val) << (low_bit)) & VP_MASK(high_bit, low_bit))
>>>      ^
>>> drivers/gpu/drm/exynos/exynos_mixer.c:443:3: note: in expansion of macro 'VP_IMG_VSIZE'
>>>    VP_IMG_VSIZE(plane->fb_height / 2));
>>>    ^
>>> drivers/gpu/drm/exynos/exynos_mixer.c:445:39: error: 'struct exynos_drm_plane' has no member named 'src_width'
>>>   vp_reg_write(res, VP_SRC_WIDTH, plane->src_width);
>>>                                        ^
>>> drivers/gpu/drm/exynos/exynos_mixer.c:446:40: error: 'struct exynos_drm_plane' has no member named 'src_height'
>>>   vp_reg_write(res, VP_SRC_HEIGHT, plane->src_height);
>>>                                         ^
>>> drivers/gpu/drm/exynos/exynos_mixer.c:451:39: error: 'struct exynos_drm_plane' has no member named 'crtc_width'
>>>   vp_reg_write(res, VP_DST_WIDTH, plane->crtc_width);
>>>                                        ^
>>> drivers/gpu/drm/exynos/exynos_mixer.c:454:41: error: 'struct exynos_drm_plane' has no member named 'crtc_height'
>>>    vp_reg_write(res, VP_DST_HEIGHT, plane->crtc_height / 2);
>>>                                          ^
>>> drivers/gpu/drm/exynos/exynos_mixer.c:457:41: error: 'struct exynos_drm_plane' has no member named 'crtc_height'
>>>    vp_reg_write(res, VP_DST_HEIGHT, plane->crtc_height);
>>>                                          ^
>>> drivers/gpu/drm/exynos/exynos_mixer.c:472:27: error: 'struct exynos_drm_plane' has no member named 'mode_height'
>>>   mixer_cfg_scan(ctx, plane->mode_height);
>>>                            ^
>>> drivers/gpu/drm/exynos/exynos_mixer.c:473:30: error: 'struct exynos_drm_plane' has no member named 'mode_height'
>>>   mixer_cfg_rgb_fmt(ctx, plane->mode_height);
>>>                               ^
>>> drivers/gpu/drm/exynos/exynos_mixer.c: In function 'mixer_setup_scale':
>>> drivers/gpu/drm/exynos/exynos_mixer.c:494:11: error: 'const struct exynos_drm_plane' has no member named 'crtc_width
>>
>> Hmm, my message was truncated ...
>>
>> I assume that there was a conflicting change in some other tree, and so
>> have dropped this tree for today (hopefully it will be fixed up soon or
>> you can tell me how to fix this).
> 
> Actually it looks like this was caused by commit
> 
>   a97f353797b4 ("drm/exynos: remove unused fields from struct exynos_drm_plane")
> 
> but only exposed today (maybe by some Kconfig dependency changing so
> that drivers/gpu/drm/exynos/exynos_mixer.c is now built).

I tried to build it with multi_v7_defconfig but I couldn't see any build
error.

Below is commit of linux-next tree I tested,
commit b00278812ebaae29769666ef556abc20a4680581
Merge: ad1d24c c098dc8
Author: Stephen Rothwell <sfr@canb.auug.org.au>
Date:   Fri Aug 14 12:06:53 2015 +1000

    Merge remote-tracking branch 'drm-exynos/exynos-drm/for-next


And today, I re-based exynos-drm/for-next on top of mainline. Could you
update and try to build it again?

Thanks,
Inki Dae

> 

Re: linux-next: build failure after merge of the drm-exynos tree

[Stephen Rothwell]

Hi Inki,

On Mon, 17 Aug 2015 13:53:42 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> On Mon, 17 Aug 2015 13:51:30 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > After merging the drm-exynos tree, today's linux-next build (arm
> > multi_v7_defconfig) failed like this:
> > 
> > drivers/gpu/drm/exynos/exynos_mixer.c: In function 'vp_video_buffer':
> > drivers/gpu/drm/exynos/exynos_mixer.c:395:15: error: 'struct exynos_drm_plane' has no member named 'pixel_format'
> >   switch (plane->pixel_format) {
> >                ^
> > In file included from drivers/gpu/drm/exynos/exynos_mixer.c:17:0:
> > drivers/gpu/drm/exynos/exynos_mixer.c:404:10: error: 'struct exynos_drm_plane' has no member named 'pixel_format'
> >      plane->pixel_format);
> >           ^
> > include/drm/drmP.h:164:17: note: in definition of macro 'DRM_ERROR'
> >   drm_err(fmt, ##__VA_ARGS__)
> >                  ^
> > drivers/gpu/drm/exynos/exynos_mixer.c:411:11: error: 'struct exynos_drm_plane' has no member named 'scan_flag'
> >   if (plane->scan_flag & DRM_MODE_FLAG_INTERLACE) {
> >            ^
> > drivers/gpu/drm/exynos/exynos_mixer.c:417:39: error: 'struct exynos_drm_plane' has no member named 'pitch'
> >     luma_addr[1] = luma_addr[0] + plane->pitch;
> >                                        ^
> > drivers/gpu/drm/exynos/exynos_mixer.c:418:43: error: 'struct exynos_drm_plane' has no member named 'pitch'
> >     chroma_addr[1] = chroma_addr[0] + plane->pitch;
> >                                            ^
> > In file included from drivers/gpu/drm/exynos/exynos_mixer.c:20:0:
> > drivers/gpu/drm/exynos/exynos_mixer.c:439:53: error: 'struct exynos_drm_plane' has no member named 'pitch'
> >   vp_reg_write(res, VP_IMG_SIZE_Y, VP_IMG_HSIZE(plane->pitch) |
> >                                                      ^
> > drivers/gpu/drm/exynos/regs-vp.h:59:5: note: in definition of macro 'VP_MASK_VAL'
> >   (((val) << (low_bit)) & VP_MASK(high_bit, low_bit))
> >      ^
> > drivers/gpu/drm/exynos/exynos_mixer.c:439:35: note: in expansion of macro 'VP_IMG_HSIZE'
> >   vp_reg_write(res, VP_IMG_SIZE_Y, VP_IMG_HSIZE(plane->pitch) |
> >                                    ^
> > drivers/gpu/drm/exynos/exynos_mixer.c:440:21: error: 'struct exynos_drm_plane' has no member named 'fb_height'
> >    VP_IMG_VSIZE(plane->fb_height));
> >                      ^
> > drivers/gpu/drm/exynos/regs-vp.h:59:5: note: in definition of macro 'VP_MASK_VAL'
> >   (((val) << (low_bit)) & VP_MASK(high_bit, low_bit))
> >      ^
> > drivers/gpu/drm/exynos/exynos_mixer.c:440:3: note: in expansion of macro 'VP_IMG_VSIZE'
> >    VP_IMG_VSIZE(plane->fb_height));
> >    ^
> > drivers/gpu/drm/exynos/exynos_mixer.c:442:53: error: 'struct exynos_drm_plane' has no member named 'pitch'
> >   vp_reg_write(res, VP_IMG_SIZE_C, VP_IMG_HSIZE(plane->pitch) |
> >                                                      ^
> > drivers/gpu/drm/exynos/regs-vp.h:59:5: note: in definition of macro 'VP_MASK_VAL'
> >   (((val) << (low_bit)) & VP_MASK(high_bit, low_bit))
> >      ^
> > drivers/gpu/drm/exynos/exynos_mixer.c:442:35: note: in expansion of macro 'VP_IMG_HSIZE'
> >   vp_reg_write(res, VP_IMG_SIZE_C, VP_IMG_HSIZE(plane->pitch) |
> >                                    ^
> > drivers/gpu/drm/exynos/exynos_mixer.c:443:21: error: 'struct exynos_drm_plane' has no member named 'fb_height'
> >    VP_IMG_VSIZE(plane->fb_height / 2));
> >                      ^
> > drivers/gpu/drm/exynos/regs-vp.h:59:5: note: in definition of macro 'VP_MASK_VAL'
> >   (((val) << (low_bit)) & VP_MASK(high_bit, low_bit))
> >      ^
> > drivers/gpu/drm/exynos/exynos_mixer.c:443:3: note: in expansion of macro 'VP_IMG_VSIZE'
> >    VP_IMG_VSIZE(plane->fb_height / 2));
> >    ^
> > drivers/gpu/drm/exynos/exynos_mixer.c:445:39: error: 'struct exynos_drm_plane' has no member named 'src_width'
> >   vp_reg_write(res, VP_SRC_WIDTH, plane->src_width);
> >                                        ^
> > drivers/gpu/drm/exynos/exynos_mixer.c:446:40: error: 'struct exynos_drm_plane' has no member named 'src_height'
> >   vp_reg_write(res, VP_SRC_HEIGHT, plane->src_height);
> >                                         ^
> > drivers/gpu/drm/exynos/exynos_mixer.c:451:39: error: 'struct exynos_drm_plane' has no member named 'crtc_width'
> >   vp_reg_write(res, VP_DST_WIDTH, plane->crtc_width);
> >                                        ^
> > drivers/gpu/drm/exynos/exynos_mixer.c:454:41: error: 'struct exynos_drm_plane' has no member named 'crtc_height'
> >    vp_reg_write(res, VP_DST_HEIGHT, plane->crtc_height / 2);
> >                                          ^
> > drivers/gpu/drm/exynos/exynos_mixer.c:457:41: error: 'struct exynos_drm_plane' has no member named 'crtc_height'
> >    vp_reg_write(res, VP_DST_HEIGHT, plane->crtc_height);
> >                                          ^
> > drivers/gpu/drm/exynos/exynos_mixer.c:472:27: error: 'struct exynos_drm_plane' has no member named 'mode_height'
> >   mixer_cfg_scan(ctx, plane->mode_height);
> >                            ^
> > drivers/gpu/drm/exynos/exynos_mixer.c:473:30: error: 'struct exynos_drm_plane' has no member named 'mode_height'
> >   mixer_cfg_rgb_fmt(ctx, plane->mode_height);
> >                               ^
> > drivers/gpu/drm/exynos/exynos_mixer.c: In function 'mixer_setup_scale':
> > drivers/gpu/drm/exynos/exynos_mixer.c:494:11: error: 'const struct exynos_drm_plane' has no member named 'crtc_width
> 
> Hmm, my message was truncated ...
> 
> I assume that there was a conflicting change in some other tree, and so
> have dropped this tree for today (hopefully it will be fixed up soon or
> you can tell me how to fix this).

Actually it looks like this was caused by commit

  a97f353797b4 ("drm/exynos: remove unused fields from struct exynos_drm_plane")

but only exposed today (maybe by some Kconfig dependency changing so
that drivers/gpu/drm/exynos/exynos_mixer.c is now built).

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

Re: linux-next: build failure after merge of the drm-exynos tree

[Stephen Rothwell]

Hi Inki,

On Mon, 17 Aug 2015 13:51:30 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the drm-exynos tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
> 
> drivers/gpu/drm/exynos/exynos_mixer.c: In function 'vp_video_buffer':
> drivers/gpu/drm/exynos/exynos_mixer.c:395:15: error: 'struct exynos_drm_plane' has no member named 'pixel_format'
>   switch (plane->pixel_format) {
>                ^
> In file included from drivers/gpu/drm/exynos/exynos_mixer.c:17:0:
> drivers/gpu/drm/exynos/exynos_mixer.c:404:10: error: 'struct exynos_drm_plane' has no member named 'pixel_format'
>      plane->pixel_format);
>           ^
> include/drm/drmP.h:164:17: note: in definition of macro 'DRM_ERROR'
>   drm_err(fmt, ##__VA_ARGS__)
>                  ^
> drivers/gpu/drm/exynos/exynos_mixer.c:411:11: error: 'struct exynos_drm_plane' has no member named 'scan_flag'
>   if (plane->scan_flag & DRM_MODE_FLAG_INTERLACE) {
>            ^
> drivers/gpu/drm/exynos/exynos_mixer.c:417:39: error: 'struct exynos_drm_plane' has no member named 'pitch'
>     luma_addr[1] = luma_addr[0] + plane->pitch;
>                                        ^
> drivers/gpu/drm/exynos/exynos_mixer.c:418:43: error: 'struct exynos_drm_plane' has no member named 'pitch'
>     chroma_addr[1] = chroma_addr[0] + plane->pitch;
>                                            ^
> In file included from drivers/gpu/drm/exynos/exynos_mixer.c:20:0:
> drivers/gpu/drm/exynos/exynos_mixer.c:439:53: error: 'struct exynos_drm_plane' has no member named 'pitch'
>   vp_reg_write(res, VP_IMG_SIZE_Y, VP_IMG_HSIZE(plane->pitch) |
>                                                      ^
> drivers/gpu/drm/exynos/regs-vp.h:59:5: note: in definition of macro 'VP_MASK_VAL'
>   (((val) << (low_bit)) & VP_MASK(high_bit, low_bit))
>      ^
> drivers/gpu/drm/exynos/exynos_mixer.c:439:35: note: in expansion of macro 'VP_IMG_HSIZE'
>   vp_reg_write(res, VP_IMG_SIZE_Y, VP_IMG_HSIZE(plane->pitch) |
>                                    ^
> drivers/gpu/drm/exynos/exynos_mixer.c:440:21: error: 'struct exynos_drm_plane' has no member named 'fb_height'
>    VP_IMG_VSIZE(plane->fb_height));
>                      ^
> drivers/gpu/drm/exynos/regs-vp.h:59:5: note: in definition of macro 'VP_MASK_VAL'
>   (((val) << (low_bit)) & VP_MASK(high_bit, low_bit))
>      ^
> drivers/gpu/drm/exynos/exynos_mixer.c:440:3: note: in expansion of macro 'VP_IMG_VSIZE'
>    VP_IMG_VSIZE(plane->fb_height));
>    ^
> drivers/gpu/drm/exynos/exynos_mixer.c:442:53: error: 'struct exynos_drm_plane' has no member named 'pitch'
>   vp_reg_write(res, VP_IMG_SIZE_C, VP_IMG_HSIZE(plane->pitch) |
>                                                      ^
> drivers/gpu/drm/exynos/regs-vp.h:59:5: note: in definition of macro 'VP_MASK_VAL'
>   (((val) << (low_bit)) & VP_MASK(high_bit, low_bit))
>      ^
> drivers/gpu/drm/exynos/exynos_mixer.c:442:35: note: in expansion of macro 'VP_IMG_HSIZE'
>   vp_reg_write(res, VP_IMG_SIZE_C, VP_IMG_HSIZE(plane->pitch) |
>                                    ^
> drivers/gpu/drm/exynos/exynos_mixer.c:443:21: error: 'struct exynos_drm_plane' has no member named 'fb_height'
>    VP_IMG_VSIZE(plane->fb_height / 2));
>                      ^
> drivers/gpu/drm/exynos/regs-vp.h:59:5: note: in definition of macro 'VP_MASK_VAL'
>   (((val) << (low_bit)) & VP_MASK(high_bit, low_bit))
>      ^
> drivers/gpu/drm/exynos/exynos_mixer.c:443:3: note: in expansion of macro 'VP_IMG_VSIZE'
>    VP_IMG_VSIZE(plane->fb_height / 2));
>    ^
> drivers/gpu/drm/exynos/exynos_mixer.c:445:39: error: 'struct exynos_drm_plane' has no member named 'src_width'
>   vp_reg_write(res, VP_SRC_WIDTH, plane->src_width);
>                                        ^
> drivers/gpu/drm/exynos/exynos_mixer.c:446:40: error: 'struct exynos_drm_plane' has no member named 'src_height'
>   vp_reg_write(res, VP_SRC_HEIGHT, plane->src_height);
>                                         ^
> drivers/gpu/drm/exynos/exynos_mixer.c:451:39: error: 'struct exynos_drm_plane' has no member named 'crtc_width'
>   vp_reg_write(res, VP_DST_WIDTH, plane->crtc_width);
>                                        ^
> drivers/gpu/drm/exynos/exynos_mixer.c:454:41: error: 'struct exynos_drm_plane' has no member named 'crtc_height'
>    vp_reg_write(res, VP_DST_HEIGHT, plane->crtc_height / 2);
>                                          ^
> drivers/gpu/drm/exynos/exynos_mixer.c:457:41: error: 'struct exynos_drm_plane' has no member named 'crtc_height'
>    vp_reg_write(res, VP_DST_HEIGHT, plane->crtc_height);
>                                          ^
> drivers/gpu/drm/exynos/exynos_mixer.c:472:27: error: 'struct exynos_drm_plane' has no member named 'mode_height'
>   mixer_cfg_scan(ctx, plane->mode_height);
>                            ^
> drivers/gpu/drm/exynos/exynos_mixer.c:473:30: error: 'struct exynos_drm_plane' has no member named 'mode_height'
>   mixer_cfg_rgb_fmt(ctx, plane->mode_height);
>                               ^
> drivers/gpu/drm/exynos/exynos_mixer.c: In function 'mixer_setup_scale':
> drivers/gpu/drm/exynos/exynos_mixer.c:494:11: error: 'const struct exynos_drm_plane' has no member named 'crtc_width

Hmm, my message was truncated ...

I assume that there was a conflicting change in some other tree, and so
have dropped this tree for today (hopefully it will be fixed up soon or
you can tell me how to fix this).

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

linux-next: build failure after merge of the drm-exynos tree

[Stephen Rothwell]

Hi Inki,

After merging the drm-exynos tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

drivers/gpu/drm/exynos/exynos_mixer.c: In function 'vp_video_buffer':
drivers/gpu/drm/exynos/exynos_mixer.c:395:15: error: 'struct exynos_drm_plane' has no member named 'pixel_format'
  switch (plane->pixel_format) {
               ^
In file included from drivers/gpu/drm/exynos/exynos_mixer.c:17:0:
drivers/gpu/drm/exynos/exynos_mixer.c:404:10: error: 'struct exynos_drm_plane' has no member named 'pixel_format'
     plane->pixel_format);
          ^
include/drm/drmP.h:164:17: note: in definition of macro 'DRM_ERROR'
  drm_err(fmt, ##__VA_ARGS__)
                 ^
drivers/gpu/drm/exynos/exynos_mixer.c:411:11: error: 'struct exynos_drm_plane' has no member named 'scan_flag'
  if (plane->scan_flag & DRM_MODE_FLAG_INTERLACE) {
           ^
drivers/gpu/drm/exynos/exynos_mixer.c:417:39: error: 'struct exynos_drm_plane' has no member named 'pitch'
    luma_addr[1] = luma_addr[0] + plane->pitch;
                                       ^
drivers/gpu/drm/exynos/exynos_mixer.c:418:43: error: 'struct exynos_drm_plane' has no member named 'pitch'
    chroma_addr[1] = chroma_addr[0] + plane->pitch;
                                           ^
In file included from drivers/gpu/drm/exynos/exynos_mixer.c:20:0:
drivers/gpu/drm/exynos/exynos_mixer.c:439:53: error: 'struct exynos_drm_plane' has no member named 'pitch'
  vp_reg_write(res, VP_IMG_SIZE_Y, VP_IMG_HSIZE(plane->pitch) |
                                                     ^
drivers/gpu/drm/exynos/regs-vp.h:59:5: note: in definition of macro 'VP_MASK_VAL'
  (((val) << (low_bit)) & VP_MASK(high_bit, low_bit))
     ^
drivers/gpu/drm/exynos/exynos_mixer.c:439:35: note: in expansion of macro 'VP_IMG_HSIZE'
  vp_reg_write(res, VP_IMG_SIZE_Y, VP_IMG_HSIZE(plane->pitch) |
                                   ^
drivers/gpu/drm/exynos/exynos_mixer.c:440:21: error: 'struct exynos_drm_plane' has no member named 'fb_height'
   VP_IMG_VSIZE(plane->fb_height));
                     ^
drivers/gpu/drm/exynos/regs-vp.h:59:5: note: in definition of macro 'VP_MASK_VAL'
  (((val) << (low_bit)) & VP_MASK(high_bit, low_bit))
     ^
drivers/gpu/drm/exynos/exynos_mixer.c:440:3: note: in expansion of macro 'VP_IMG_VSIZE'
   VP_IMG_VSIZE(plane->fb_height));
   ^
drivers/gpu/drm/exynos/exynos_mixer.c:442:53: error: 'struct exynos_drm_plane' has no member named 'pitch'
  vp_reg_write(res, VP_IMG_SIZE_C, VP_IMG_HSIZE(plane->pitch) |
                                                     ^
drivers/gpu/drm/exynos/regs-vp.h:59:5: note: in definition of macro 'VP_MASK_VAL'
  (((val) << (low_bit)) & VP_MASK(high_bit, low_bit))
     ^
drivers/gpu/drm/exynos/exynos_mixer.c:442:35: note: in expansion of macro 'VP_IMG_HSIZE'
  vp_reg_write(res, VP_IMG_SIZE_C, VP_IMG_HSIZE(plane->pitch) |
                                   ^
drivers/gpu/drm/exynos/exynos_mixer.c:443:21: error: 'struct exynos_drm_plane' has no member named 'fb_height'
   VP_IMG_VSIZE(plane->fb_height / 2));
                     ^
drivers/gpu/drm/exynos/regs-vp.h:59:5: note: in definition of macro 'VP_MASK_VAL'
  (((val) << (low_bit)) & VP_MASK(high_bit, low_bit))
     ^
drivers/gpu/drm/exynos/exynos_mixer.c:443:3: note: in expansion of macro 'VP_IMG_VSIZE'
   VP_IMG_VSIZE(plane->fb_height / 2));
   ^
drivers/gpu/drm/exynos/exynos_mixer.c:445:39: error: 'struct exynos_drm_plane' has no member named 'src_width'
  vp_reg_write(res, VP_SRC_WIDTH, plane->src_width);
                                       ^
drivers/gpu/drm/exynos/exynos_mixer.c:446:40: error: 'struct exynos_drm_plane' has no member named 'src_height'
  vp_reg_write(res, VP_SRC_HEIGHT, plane->src_height);
                                        ^
drivers/gpu/drm/exynos/exynos_mixer.c:451:39: error: 'struct exynos_drm_plane' has no member named 'crtc_width'
  vp_reg_write(res, VP_DST_WIDTH, plane->crtc_width);
                                       ^
drivers/gpu/drm/exynos/exynos_mixer.c:454:41: error: 'struct exynos_drm_plane' has no member named 'crtc_height'
   vp_reg_write(res, VP_DST_HEIGHT, plane->crtc_height / 2);
                                         ^
drivers/gpu/drm/exynos/exynos_mixer.c:457:41: error: 'struct exynos_drm_plane' has no member named 'crtc_height'
   vp_reg_write(res, VP_DST_HEIGHT, plane->crtc_height);
                                         ^
drivers/gpu/drm/exynos/exynos_mixer.c:472:27: error: 'struct exynos_drm_plane' has no member named 'mode_height'
  mixer_cfg_scan(ctx, plane->mode_height);
                           ^
drivers/gpu/drm/exynos/exynos_mixer.c:473:30: error: 'struct exynos_drm_plane' has no member named 'mode_height'
  mixer_cfg_rgb_fmt(ctx, plane->mode_height);
                              ^
drivers/gpu/drm/exynos/exynos_mixer.c: In function 'mixer_setup_scale':
drivers/gpu/drm/exynos/exynos_mixer.c:494:11: error: 'const struct exynos_drm_plane' has no member named 'crtc_width

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au