* Re: [Xen-staging] [xen staging] libxl: ao abort: Handle SIGTERM in save/restore helper
[not found] <E1Z8W6A-0004wB-68@xenbits.xen.org>
@ 2015-06-26 16:44 ` Ian Campbell
2015-06-26 16:46 ` Ian Jackson
0 siblings, 1 reply; 5+ messages in thread
From: Ian Campbell @ 2015-06-26 16:44 UTC (permalink / raw)
To: xen-devel, Ian Jackson; +Cc: Roger Pau Monne
On Fri, 2015-06-26 at 16:03 +0000, patchbot@xen.org wrote:
> commit b6ac9b7fc6bb18057a1aa114296b32f59b40e187
> Author: Ian Jackson <ian.jackson@eu.citrix.com>
> AuthorDate: Tue Feb 10 19:05:06 2015 +0000
> Commit: Ian Jackson <Ian.Jackson@eu.citrix.com>
> CommitDate: Fri Jun 26 16:53:51 2015 +0100
>
> libxl: ao abort: Handle SIGTERM in save/restore helper
Trying to do a build test of my libxenctrl split on FreeBSD I came
across this build failure with current staging (without my patches)
which I suspect is down to this change. Missing a header perhaps?
libxl_save_helper.c: In function 'setup_signals':
libxl_save_helper.c:158:22: error: storage size of 'sa' isn't known
struct sigaction sa;
^
libxl_save_helper.c:167:5: error: implicit declaration of function 'sigemptyset' [-Werror=implicit-function-declaration]
sigemptyset(&sa.sa_mask);
^
libxl_save_helper.c:168:5: error: implicit declaration of function 'sigaction' [-Werror=implicit-function-declaration]
r = sigaction(SIGTERM, &sa, 0);
^
libxl_save_helper.c:168:19: error: 'SIGTERM' undeclared (first use in this function)
r = sigaction(SIGTERM, &sa, 0);
^
libxl_save_helper.c:168:19: note: each undeclared identifier is reported only once for each function it appears in
libxl_save_helper.c:172:5: error: implicit declaration of function 'sigaddset' [-Werror=implicit-function-declaration]
sigaddset(&spmask,SIGTERM);
^
libxl_save_helper.c:173:5: error: implicit declaration of function 'sigprocmask' [-Werror=implicit-function-declaration]
r = sigprocmask(SIG_UNBLOCK,&spmask,0);
^
libxl_save_helper.c:173:21: error: 'SIG_UNBLOCK' undeclared (first use in this function)
r = sigprocmask(SIG_UNBLOCK,&spmask,0);
^
libxl_save_helper.c:158:22: error: unused variable 'sa' [-Werror=unused-variable]
struct sigaction sa;
^
libxl_save_helper.c: In function 'main':
libxl_save_helper.c:313:23: error: 'SIG_DFL' undeclared (first use in this function)
setup_signals(SIG_DFL);
^
cc1: all warnings being treated as errors
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Xen-staging] [xen staging] libxl: ao abort: Handle SIGTERM in save/restore helper
2015-06-26 16:44 ` [Xen-staging] [xen staging] libxl: ao abort: Handle SIGTERM in save/restore helper Ian Campbell
@ 2015-06-26 16:46 ` Ian Jackson
2015-06-26 17:26 ` [PATCH] libxl: Add missing #include of <signal.h> Ian Jackson
0 siblings, 1 reply; 5+ messages in thread
From: Ian Jackson @ 2015-06-26 16:46 UTC (permalink / raw)
To: Ian Campbell; +Cc: xen-devel, Roger Pau Monne
Ian Campbell writes ("Re: [Xen-staging] [xen staging] libxl: ao abort: Handle SIGTERM in save/restore helper"):
> On Fri, 2015-06-26 at 16:03 +0000, patchbot@xen.org wrote:
> > commit b6ac9b7fc6bb18057a1aa114296b32f59b40e187
> > Author: Ian Jackson <ian.jackson@eu.citrix.com>
> > AuthorDate: Tue Feb 10 19:05:06 2015 +0000
> > Commit: Ian Jackson <Ian.Jackson@eu.citrix.com>
> > CommitDate: Fri Jun 26 16:53:51 2015 +0100
> >
> > libxl: ao abort: Handle SIGTERM in save/restore helper
>
> Trying to do a build test of my libxenctrl split on FreeBSD I came
> across this build failure with current staging (without my patches)
> which I suspect is down to this change. Missing a header perhaps?
Sorry. Try this ?
Ian.
diff --git a/tools/libxl/libxl_save_helper.c b/tools/libxl/libxl_save_helper.c
index 0be77c9..14675ae 100644
--- a/tools/libxl/libxl_save_helper.c
+++ b/tools/libxl/libxl_save_helper.c
@@ -41,6 +41,7 @@
#include <assert.h>
#include <inttypes.h>
#include <fcntl.h>
+#include <signal.h>
#include "libxl.h"
#include "libxl_utils.h"
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] libxl: Add missing #include of <signal.h>
2015-06-26 16:46 ` Ian Jackson
@ 2015-06-26 17:26 ` Ian Jackson
2015-06-26 17:27 ` Ian Jackson
0 siblings, 1 reply; 5+ messages in thread
From: Ian Jackson @ 2015-06-26 17:26 UTC (permalink / raw)
To: xen-devel; +Cc: Ian Jackson, Ian Campbell, Roger Pau Monne
"libxl: ao abort: Handle SIGTERM in save/restore helper" requires
this; without it we fail to build on BSD.
Reported-by: Ian Campbell <ian.campbell@citrix.com>
CC: Ian Campbell <ian.campbell@citrix.com>
CC: Roger Pau Monne <roger.pau@citrix.com>
Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
---
tools/libxl/libxl_save_helper.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/libxl/libxl_save_helper.c b/tools/libxl/libxl_save_helper.c
index 0be77c9..14675ae 100644
--- a/tools/libxl/libxl_save_helper.c
+++ b/tools/libxl/libxl_save_helper.c
@@ -41,6 +41,7 @@
#include <assert.h>
#include <inttypes.h>
#include <fcntl.h>
+#include <signal.h>
#include "libxl.h"
#include "libxl_utils.h"
--
1.7.10.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] libxl: Add missing #include of <signal.h>
2015-06-26 17:26 ` [PATCH] libxl: Add missing #include of <signal.h> Ian Jackson
@ 2015-06-26 17:27 ` Ian Jackson
2015-06-26 18:23 ` Roger Pau Monné
0 siblings, 1 reply; 5+ messages in thread
From: Ian Jackson @ 2015-06-26 17:27 UTC (permalink / raw)
To: xen-devel, Ian Campbell, Roger Pau Monne
Ian Jackson writes ("[PATCH] libxl: Add missing #include of <signal.h>"):
> "libxl: ao abort: Handle SIGTERM in save/restore helper" requires
> this; without it we fail to build on BSD.
>
> Reported-by: Ian Campbell <ian.campbell@citrix.com>
> CC: Ian Campbell <ian.campbell@citrix.com>
> CC: Roger Pau Monne <roger.pau@citrix.com>
> Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
Given that this is a build fix, I have taken the liberty of pushing it
without waiting for an ack.
Ian.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] libxl: Add missing #include of <signal.h>
2015-06-26 17:27 ` Ian Jackson
@ 2015-06-26 18:23 ` Roger Pau Monné
0 siblings, 0 replies; 5+ messages in thread
From: Roger Pau Monné @ 2015-06-26 18:23 UTC (permalink / raw)
To: Ian Jackson, xen-devel, Ian Campbell
El 26/06/15 a les 19.27, Ian Jackson ha escrit:
> Ian Jackson writes ("[PATCH] libxl: Add missing #include of <signal.h>"):
>> "libxl: ao abort: Handle SIGTERM in save/restore helper" requires
>> this; without it we fail to build on BSD.
>>
>> Reported-by: Ian Campbell <ian.campbell@citrix.com>
>> CC: Ian Campbell <ian.campbell@citrix.com>
>> CC: Roger Pau Monne <roger.pau@citrix.com>
>> Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
>
> Given that this is a build fix, I have taken the liberty of pushing it
> without waiting for an ack.
Thanks. For the record:
Acked-by: Roger Pau Monné <roger.pau@citrix.com>
Roger.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-06-26 18:23 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <E1Z8W6A-0004wB-68@xenbits.xen.org>
2015-06-26 16:44 ` [Xen-staging] [xen staging] libxl: ao abort: Handle SIGTERM in save/restore helper Ian Campbell
2015-06-26 16:46 ` Ian Jackson
2015-06-26 17:26 ` [PATCH] libxl: Add missing #include of <signal.h> Ian Jackson
2015-06-26 17:27 ` Ian Jackson
2015-06-26 18:23 ` Roger Pau Monné
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.