All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@fb.com>
To: Junichi Nomura <j-nomura@ce.jp.nec.com>,
	"torvalds@linuxfoundation.org" <torvalds@linuxfoundation.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Christoph Hellwig <hch@lst.de>, Mike Snitzer <snitzer@redhat.com>,
	device-mapper development <dm-devel@redhat.com>
Subject: Re: [GIT PULL] Core block IO bits for 4.2
Date: Fri, 26 Jun 2015 13:22:33 -0600	[thread overview]
Message-ID: <558DA679.7000304@fb.com> (raw)
In-Reply-To: <20150626061510.GA15036@xzibit.linux.bs1.fc.nec.co.jp>

On 06/26/2015 12:15 AM, Junichi Nomura wrote:
> Hi Jens,
> 
> On 06/25/15 23:37, Jens Axboe wrote:
>>        block, dm: don't copy bios for request clones
> 
> this change should not be pushed to mainline yet.
> 
> Firstly, Christoph has a newer version of the patch that fixes silent
> data corruption problem:
>    https://www.redhat.com/archives/dm-devel/2015-May/msg00229.html
> 
> And the new version still depends on LLDDs to always complete requests
> to the end when error happens, while block API doesn't enforce such a
> requirement. If the assumption is ever broken, the inconsistency between
> request and bio (e.g. rq->__sector and rq->bio) will cause silent data
> corruption:
>    https://www.redhat.com/archives/dm-devel/2015-June/msg00022.html

Why was none of that sent to the block tree?

In any case, Linus, pick up Mike's pull request to fix this up.

-- 
Jens Axboe


  parent reply	other threads:[~2015-06-26 19:22 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-25 14:37 [GIT PULL] Core block IO bits for 4.2 Jens Axboe
2015-06-26  6:15 ` Junichi Nomura
2015-06-26  6:41   ` Linus Torvalds
2015-06-26  8:05     ` Junichi Nomura
2015-06-26 15:20       ` [git pull] device mapper fixes for 4.2-rc1 Mike Snitzer
2015-06-26 19:22   ` Jens Axboe [this message]
2015-06-29 17:00     ` [GIT PULL] Core block IO bits for 4.2 Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=558DA679.7000304@fb.com \
    --to=axboe@fb.com \
    --cc=dm-devel@redhat.com \
    --cc=hch@lst.de \
    --cc=j-nomura@ce.jp.nec.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=snitzer@redhat.com \
    --cc=torvalds@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.