* Re: [tip:irq/urgent] pinctrl/st: Fix race in installing chained IRQ handler
[not found] <tip-1b11b0cb799e5f82ca6391a23eaa8f41c7466cc0@git.kernel.org>
@ 2015-06-27 6:51 ` Maxime Coquelin
2015-06-29 7:08 ` Patrice Chotard
1 sibling, 0 replies; 2+ messages in thread
From: Maxime Coquelin @ 2015-06-27 6:51 UTC (permalink / raw)
To: tglx, hpa, patrice.chotard, Julia.Lawall, rmk+kernel, mingo,
linux-kernel, linus.walleij, srinivas.kandagatla,
linux-tip-commits
Hello Thomas,
On 06/26/2015 09:45 PM, tip-bot for Thomas Gleixner wrote:
> Commit-ID: 1b11b0cb799e5f82ca6391a23eaa8f41c7466cc0
> Gitweb: http://git.kernel.org/tip/1b11b0cb799e5f82ca6391a23eaa8f41c7466cc0
> Author: Thomas Gleixner <tglx@linutronix.de>
> AuthorDate: Sun, 21 Jun 2015 20:16:15 +0200
> Committer: Thomas Gleixner <tglx@linutronix.de>
> CommitDate: Thu, 25 Jun 2015 11:57:09 +0200
>
> pinctrl/st: Fix race in installing chained IRQ handler
>
> Fix a race where a pending interrupt could be received and the handler
> called before the handler's data has been setup, by converting to
> irq_set_chained_handler_and_data().
>
> Search and conversion was done with coccinelle:
>
> @@
> expression E1, E2, E3;
> @@
> (
> -if (irq_set_chained_handler(E1, E3) != 0)
> - BUG();
> |
> -irq_set_chained_handler(E1, E3);
> )
> -irq_set_handler_data(E1, E2);
> +irq_set_chained_handler_and_data(E1, E3, E2);
>
> @@
> expression E1, E2, E3;
> @@
> (
> -if (irq_set_chained_handler(E1, E3) != 0)
> - BUG();
> ...
> |
> -irq_set_chained_handler(E1, E3);
> ...
> )
> -irq_set_handler_data(E1, E2);
> +irq_set_chained_handler_and_data(E1, E3, E2);
>
> Reported-by: Russell King <rmk+kernel@arm.linux.org.uk>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Cc: Julia Lawall <Julia.Lawall@lip6.fr>
> Cc: Srinivas Kandagatla <srinivas.kandagatla@gmail.com>
> Cc: Maxime Coquelin <maxime.coquelin@st.com>
> Cc: Patrice Chotard <patrice.chotard@st.com>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: kernel@stlinux.com
> Cc: linux-gpio@vger.kernel.org
> ---
> drivers/pinctrl/pinctrl-st.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pinctrl/pinctrl-st.c b/drivers/pinctrl/pinctrl-st.c
> index 65bf73b..10e9c4e8 100644
> --- a/drivers/pinctrl/pinctrl-st.c
> +++ b/drivers/pinctrl/pinctrl-st.c
> @@ -1661,8 +1661,8 @@ static int st_pctl_probe_dt(struct platform_device *pdev,
> if (IS_ERR(info->irqmux_base))
> return PTR_ERR(info->irqmux_base);
>
> - irq_set_chained_handler(irq, st_gpio_irqmux_handler);
> - irq_set_handler_data(irq, info);
> + irq_set_chained_handler_and_data(irq, st_gpio_irqmux_handler,
> + info);
>
> }
>
I cannot test the patch before Monday, but it looks good to me:
Acked-by: Maxime Coquelin <maxime.coquelin@st.com>
Thanks!
Maxime
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [tip:irq/urgent] pinctrl/st: Fix race in installing chained IRQ handler
[not found] <tip-1b11b0cb799e5f82ca6391a23eaa8f41c7466cc0@git.kernel.org>
2015-06-27 6:51 ` [tip:irq/urgent] pinctrl/st: Fix race in installing chained IRQ handler Maxime Coquelin
@ 2015-06-29 7:08 ` Patrice Chotard
1 sibling, 0 replies; 2+ messages in thread
From: Patrice Chotard @ 2015-06-29 7:08 UTC (permalink / raw)
To: tglx, hpa, Julia.Lawall, rmk+kernel, mingo, linux-kernel,
linus.walleij, srinivas.kandagatla, maxime.coquelin,
linux-tip-commits
Hi Thomas
On 06/26/2015 09:45 PM, tip-bot for Thomas Gleixner wrote:
> Commit-ID: 1b11b0cb799e5f82ca6391a23eaa8f41c7466cc0
> Gitweb: http://git.kernel.org/tip/1b11b0cb799e5f82ca6391a23eaa8f41c7466cc0
> Author: Thomas Gleixner <tglx@linutronix.de>
> AuthorDate: Sun, 21 Jun 2015 20:16:15 +0200
> Committer: Thomas Gleixner <tglx@linutronix.de>
> CommitDate: Thu, 25 Jun 2015 11:57:09 +0200
>
> pinctrl/st: Fix race in installing chained IRQ handler
>
> Fix a race where a pending interrupt could be received and the handler
> called before the handler's data has been setup, by converting to
> irq_set_chained_handler_and_data().
>
> Search and conversion was done with coccinelle:
>
> @@
> expression E1, E2, E3;
> @@
> (
> -if (irq_set_chained_handler(E1, E3) != 0)
> - BUG();
> |
> -irq_set_chained_handler(E1, E3);
> )
> -irq_set_handler_data(E1, E2);
> +irq_set_chained_handler_and_data(E1, E3, E2);
>
> @@
> expression E1, E2, E3;
> @@
> (
> -if (irq_set_chained_handler(E1, E3) != 0)
> - BUG();
> ...
> |
> -irq_set_chained_handler(E1, E3);
> ...
> )
> -irq_set_handler_data(E1, E2);
> +irq_set_chained_handler_and_data(E1, E3, E2);
>
> Reported-by: Russell King <rmk+kernel@arm.linux.org.uk>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Cc: Julia Lawall <Julia.Lawall@lip6.fr>
> Cc: Srinivas Kandagatla <srinivas.kandagatla@gmail.com>
> Cc: Maxime Coquelin <maxime.coquelin@st.com>
> Cc: Patrice Chotard <patrice.chotard@st.com>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: kernel@stlinux.com
> Cc: linux-gpio@vger.kernel.org
> ---
> drivers/pinctrl/pinctrl-st.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pinctrl/pinctrl-st.c b/drivers/pinctrl/pinctrl-st.c
> index 65bf73b..10e9c4e8 100644
> --- a/drivers/pinctrl/pinctrl-st.c
> +++ b/drivers/pinctrl/pinctrl-st.c
> @@ -1661,8 +1661,8 @@ static int st_pctl_probe_dt(struct platform_device *pdev,
> if (IS_ERR(info->irqmux_base))
> return PTR_ERR(info->irqmux_base);
>
> - irq_set_chained_handler(irq, st_gpio_irqmux_handler);
> - irq_set_handler_data(irq, info);
> + irq_set_chained_handler_and_data(irq, st_gpio_irqmux_handler,
> + info);
>
> }
Acked-by: Patrice Chotard <patrice.chotard@st.com>
Thanks
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-06-29 7:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <tip-1b11b0cb799e5f82ca6391a23eaa8f41c7466cc0@git.kernel.org>
2015-06-27 6:51 ` [tip:irq/urgent] pinctrl/st: Fix race in installing chained IRQ handler Maxime Coquelin
2015-06-29 7:08 ` Patrice Chotard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.