[PATCH 0/3] ARM: mvebu: minor improvements to Armada 388 GP support

[PATCH 0/3] ARM: mvebu: minor improvements to Armada 388 GP support

[Thomas Petazzoni]

Hello,

This small set of three commits makes some minor improvements to the
Armada 388 GP board support.

Thomas

Thomas Petazzoni (3):
  ARM: mvebu: fix description of pwr-sata0 regulator on Armada 388 GP
  ARM: mvebu: update EEPROM description of Armada 388 GP
  ARM: mvebu: update mvebu_v7_defconfig with features needed for Armada
    388 GP

 arch/arm/boot/dts/armada-388-gp.dts | 12 +++++++-----
 arch/arm/configs/mvebu_v7_defconfig |  4 ++++
 2 files changed, 11 insertions(+), 5 deletions(-)

-- 
2.1.0

[PATCH 1/3] ARM: mvebu: fix description of pwr-sata0 regulator on Armada 388 GP

[Thomas Petazzoni]

This regulator was lacking the reference to the GPIO that controls it,
and the regulator-min-microvolt and regulator-max-microvolt
properties. Thanks to this commit, the pwr-sata0 regulator now looks
more like the other pwr-sata{1,2,3} regulators in the same Device
Tree, with of course the exception of a different GPIO reference.

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 arch/arm/boot/dts/armada-388-gp.dts | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/armada-388-gp.dts b/arch/arm/boot/dts/armada-388-gp.dts
index 78514ab..5164b9a 100644
--- a/arch/arm/boot/dts/armada-388-gp.dts
+++ b/arch/arm/boot/dts/armada-388-gp.dts
@@ -301,9 +301,11 @@
 	reg_sata0: pwr-sata0 {
 		compatible = "regulator-fixed";
 		regulator-name = "pwr_en_sata0";
+		regulator-min-microvolt = <12000000>;
+		regulator-max-microvolt = <12000000>;
 		enable-active-high;
 		regulator-always-on;
-
+		gpio = <&expander0 2 GPIO_ACTIVE_HIGH>;
 	};
 
 	reg_5v_sata0: v5-sata0 {
-- 
2.1.0

[PATCH 2/3] ARM: mvebu: update EEPROM description of Armada 388 GP

[Thomas Petazzoni]

Contrary to what the Device Tree indicates, the EEPROM at 0x54 is not
populated, so we get rid of this comment.

However, there is an EEPROM at 0x57, so we add support for this
AT24C64 EEPROM:

$ hexdump -C /sys/bus/i2c/devices/0-0057/eeprom
00000000  0c ff f3 ff ff ff ff ff  ff ff ff ff ff ff ff ff  |................|
00000010  ff ff ff ff ff ff ff ff  ff ff ff ff ff ff ff ff  |................|
*
00002000

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 arch/arm/boot/dts/armada-388-gp.dts | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/arm/boot/dts/armada-388-gp.dts b/arch/arm/boot/dts/armada-388-gp.dts
index 5164b9a..fc1ee3e 100644
--- a/arch/arm/boot/dts/armada-388-gp.dts
+++ b/arch/arm/boot/dts/armada-388-gp.dts
@@ -81,10 +81,6 @@
 				pinctrl-0 = <&i2c0_pins>;
 				status = "okay";
 				clock-frequency = <100000>;
-				/*
-				 * The EEPROM located at adresse 54 is needed
-				 * for the boot - DO NOT ERASE IT -
-				 */
 
 				expander0: pca9555 at 20 {
 					compatible = "nxp,pca9555";
@@ -111,6 +107,10 @@
 					reg = <0x21>;
 				};
 
+				eeprom at 57 {
+					compatible = "atmel,24c64";
+					reg = <0x57>;
+				};
 			};
 
 			serial at 12000 {
-- 
2.1.0

[PATCH 3/3] ARM: mvebu: update mvebu_v7_defconfig with features needed for Armada 388 GP

[Thomas Petazzoni]

The Armada 388 GP board has the following hardware features that were
not enabled in mvebu_v7_defconfig:

 * An AT24 I2C EEPROM (also used by armada-xp-lenovo-ix4-300d)
 * A PCA9555 I2C GPIO expander
 * Several fixed regulators

Therefore, this commit adds the necessary options to mvebu_v7_defconfig.

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 arch/arm/configs/mvebu_v7_defconfig | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm/configs/mvebu_v7_defconfig b/arch/arm/configs/mvebu_v7_defconfig
index cacc9f4..13fcd02 100644
--- a/arch/arm/configs/mvebu_v7_defconfig
+++ b/arch/arm/configs/mvebu_v7_defconfig
@@ -58,6 +58,7 @@ CONFIG_MTD_M25P80=y
 CONFIG_MTD_NAND=y
 CONFIG_MTD_NAND_PXA3xx=y
 CONFIG_MTD_SPI_NOR=y
+CONFIG_EEPROM_AT24=y
 CONFIG_BLK_DEV_SD=y
 CONFIG_ATA=y
 CONFIG_AHCI_MVEBU=y
@@ -83,11 +84,14 @@ CONFIG_I2C_MV64XXX=y
 CONFIG_SPI=y
 CONFIG_SPI_ORION=y
 CONFIG_GPIO_SYSFS=y
+CONFIG_GPIO_PCA953X=y
 CONFIG_SENSORS_GPIO_FAN=y
 CONFIG_THERMAL=y
 CONFIG_ARMADA_THERMAL=y
 CONFIG_WATCHDOG=y
 CONFIG_ORION_WATCHDOG=y
+CONFIG_REGULATOR=y
+CONFIG_REGULATOR_FIXED_VOLTAGE=y
 CONFIG_SOUND=y
 CONFIG_SND=y
 CONFIG_SND_SOC=y
-- 
2.1.0

[PATCH 1/3] ARM: mvebu: fix description of pwr-sata0 regulator on Armada 388 GP

[Gregory CLEMENT]

Hi Thomas,

On 18/06/2015 14:38, Thomas Petazzoni wrote:
> This regulator was lacking the reference to the GPIO that controls it,
> and the regulator-min-microvolt and regulator-max-microvolt
> properties. Thanks to this commit, the pwr-sata0 regulator now looks
> more like the other pwr-sata{1,2,3} regulators in the same Device
> Tree, with of course the exception of a different GPIO reference.
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

Acked-by: Gregory CLEMENT <gregory.clement@free-electrons.com>


Thanks,

Gregory

> ---
>  arch/arm/boot/dts/armada-388-gp.dts | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/armada-388-gp.dts b/arch/arm/boot/dts/armada-388-gp.dts
> index 78514ab..5164b9a 100644
> --- a/arch/arm/boot/dts/armada-388-gp.dts
> +++ b/arch/arm/boot/dts/armada-388-gp.dts
> @@ -301,9 +301,11 @@
>  	reg_sata0: pwr-sata0 {
>  		compatible = "regulator-fixed";
>  		regulator-name = "pwr_en_sata0";
> +		regulator-min-microvolt = <12000000>;
> +		regulator-max-microvolt = <12000000>;
>  		enable-active-high;
>  		regulator-always-on;
> -
> +		gpio = <&expander0 2 GPIO_ACTIVE_HIGH>;
>  	};
>  
>  	reg_5v_sata0: v5-sata0 {
> 


-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

[PATCH 2/3] ARM: mvebu: update EEPROM description of Armada 388 GP

[Gregory CLEMENT]

Hi Thomas,

On 18/06/2015 14:38, Thomas Petazzoni wrote:
> Contrary to what the Device Tree indicates, the EEPROM at 0x54 is not
> populated, so we get rid of this comment.
> 
> However, there is an EEPROM at 0x57, so we add support for this
> AT24C64 EEPROM:
> 
> $ hexdump -C /sys/bus/i2c/devices/0-0057/eeprom
> 00000000  0c ff f3 ff ff ff ff ff  ff ff ff ff ff ff ff ff  |................|
> 00000010  ff ff ff ff ff ff ff ff  ff ff ff ff ff ff ff ff  |................|
> *
> 00002000
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

Acked-by: Gregory CLEMENT <gregory.clement@free-electrons.com>


Thanks,

Gregory

> ---
>  arch/arm/boot/dts/armada-388-gp.dts | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/armada-388-gp.dts b/arch/arm/boot/dts/armada-388-gp.dts
> index 5164b9a..fc1ee3e 100644
> --- a/arch/arm/boot/dts/armada-388-gp.dts
> +++ b/arch/arm/boot/dts/armada-388-gp.dts
> @@ -81,10 +81,6 @@
>  				pinctrl-0 = <&i2c0_pins>;
>  				status = "okay";
>  				clock-frequency = <100000>;
> -				/*
> -				 * The EEPROM located at adresse 54 is needed
> -				 * for the boot - DO NOT ERASE IT -
> -				 */
>  
>  				expander0: pca9555 at 20 {
>  					compatible = "nxp,pca9555";
> @@ -111,6 +107,10 @@
>  					reg = <0x21>;
>  				};
>  
> +				eeprom at 57 {
> +					compatible = "atmel,24c64";
> +					reg = <0x57>;
> +				};
>  			};
>  
>  			serial at 12000 {
> 


-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

[PATCH 3/3] ARM: mvebu: update mvebu_v7_defconfig with features needed for Armada 388 GP

[Gregory CLEMENT]

Hi Thomas,

On 18/06/2015 14:38, Thomas Petazzoni wrote:
> The Armada 388 GP board has the following hardware features that were
> not enabled in mvebu_v7_defconfig:
> 
>  * An AT24 I2C EEPROM (also used by armada-xp-lenovo-ix4-300d)
>  * A PCA9555 I2C GPIO expander
>  * Several fixed regulators
> 
> Therefore, this commit adds the necessary options to mvebu_v7_defconfig.
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>


Acked-by: Gregory CLEMENT <gregory.clement@free-electrons.com>

Thanks,

Gregory

> ---
>  arch/arm/configs/mvebu_v7_defconfig | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/arm/configs/mvebu_v7_defconfig b/arch/arm/configs/mvebu_v7_defconfig
> index cacc9f4..13fcd02 100644
> --- a/arch/arm/configs/mvebu_v7_defconfig
> +++ b/arch/arm/configs/mvebu_v7_defconfig
> @@ -58,6 +58,7 @@ CONFIG_MTD_M25P80=y
>  CONFIG_MTD_NAND=y
>  CONFIG_MTD_NAND_PXA3xx=y
>  CONFIG_MTD_SPI_NOR=y
> +CONFIG_EEPROM_AT24=y
>  CONFIG_BLK_DEV_SD=y
>  CONFIG_ATA=y
>  CONFIG_AHCI_MVEBU=y
> @@ -83,11 +84,14 @@ CONFIG_I2C_MV64XXX=y
>  CONFIG_SPI=y
>  CONFIG_SPI_ORION=y
>  CONFIG_GPIO_SYSFS=y
> +CONFIG_GPIO_PCA953X=y
>  CONFIG_SENSORS_GPIO_FAN=y
>  CONFIG_THERMAL=y
>  CONFIG_ARMADA_THERMAL=y
>  CONFIG_WATCHDOG=y
>  CONFIG_ORION_WATCHDOG=y
> +CONFIG_REGULATOR=y
> +CONFIG_REGULATOR_FIXED_VOLTAGE=y
>  CONFIG_SOUND=y
>  CONFIG_SND=y
>  CONFIG_SND_SOC=y
> 


-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

[PATCH 1/3] ARM: mvebu: fix description of pwr-sata0 regulator on Armada 388 GP

[Gregory CLEMENT]

Hi Thomas,

On 29/06/2015 14:46, Gregory CLEMENT wrote:
> Hi Thomas,
> 
> On 18/06/2015 14:38, Thomas Petazzoni wrote:
>> This regulator was lacking the reference to the GPIO that controls it,
>> and the regulator-min-microvolt and regulator-max-microvolt
>> properties. Thanks to this commit, the pwr-sata0 regulator now looks
>> more like the other pwr-sata{1,2,3} regulators in the same Device
>> Tree, with of course the exception of a different GPIO reference.
>>
>> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> 
> Acked-by: Gregory CLEMENT <gregory.clement@free-electrons.com>

applied on mvebu/dt

Thanks,

Gregory
> 
> 
> Thanks,
> 
> Gregory
> 
>> ---
>>  arch/arm/boot/dts/armada-388-gp.dts | 4 +++-
>>  1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/armada-388-gp.dts b/arch/arm/boot/dts/armada-388-gp.dts
>> index 78514ab..5164b9a 100644
>> --- a/arch/arm/boot/dts/armada-388-gp.dts
>> +++ b/arch/arm/boot/dts/armada-388-gp.dts
>> @@ -301,9 +301,11 @@
>>  	reg_sata0: pwr-sata0 {
>>  		compatible = "regulator-fixed";
>>  		regulator-name = "pwr_en_sata0";
>> +		regulator-min-microvolt = <12000000>;
>> +		regulator-max-microvolt = <12000000>;
>>  		enable-active-high;
>>  		regulator-always-on;
>> -
>> +		gpio = <&expander0 2 GPIO_ACTIVE_HIGH>;
>>  	};
>>  
>>  	reg_5v_sata0: v5-sata0 {
>>
> 
> 


-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

[PATCH 2/3] ARM: mvebu: update EEPROM description of Armada 388 GP

[Gregory CLEMENT]

Hi Thomas,

On 29/06/2015 14:50, Gregory CLEMENT wrote:
> Hi Thomas,
> 
> On 18/06/2015 14:38, Thomas Petazzoni wrote:
>> Contrary to what the Device Tree indicates, the EEPROM at 0x54 is not
>> populated, so we get rid of this comment.
>>
>> However, there is an EEPROM at 0x57, so we add support for this
>> AT24C64 EEPROM:
>>
>> $ hexdump -C /sys/bus/i2c/devices/0-0057/eeprom
>> 00000000  0c ff f3 ff ff ff ff ff  ff ff ff ff ff ff ff ff  |................|
>> 00000010  ff ff ff ff ff ff ff ff  ff ff ff ff ff ff ff ff  |................|
>> *
>> 00002000
>>
>> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> 
> Acked-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
> 

applied on mvebu/dt

Thanks,

Gregory
> 
> Thanks,
> 
> Gregory
> 
>> ---
>>  arch/arm/boot/dts/armada-388-gp.dts | 8 ++++----
>>  1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/armada-388-gp.dts b/arch/arm/boot/dts/armada-388-gp.dts
>> index 5164b9a..fc1ee3e 100644
>> --- a/arch/arm/boot/dts/armada-388-gp.dts
>> +++ b/arch/arm/boot/dts/armada-388-gp.dts
>> @@ -81,10 +81,6 @@
>>  				pinctrl-0 = <&i2c0_pins>;
>>  				status = "okay";
>>  				clock-frequency = <100000>;
>> -				/*
>> -				 * The EEPROM located at adresse 54 is needed
>> -				 * for the boot - DO NOT ERASE IT -
>> -				 */
>>  
>>  				expander0: pca9555 at 20 {
>>  					compatible = "nxp,pca9555";
>> @@ -111,6 +107,10 @@
>>  					reg = <0x21>;
>>  				};
>>  
>> +				eeprom at 57 {
>> +					compatible = "atmel,24c64";
>> +					reg = <0x57>;
>> +				};
>>  			};
>>  
>>  			serial at 12000 {
>>
> 
> 


-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

[PATCH 3/3] ARM: mvebu: update mvebu_v7_defconfig with features needed for Armada 388 GP

[Gregory CLEMENT]

Hi Thomas,

On 29/06/2015 14:51, Gregory CLEMENT wrote:
> Hi Thomas,
> 
> On 18/06/2015 14:38, Thomas Petazzoni wrote:
>> The Armada 388 GP board has the following hardware features that were
>> not enabled in mvebu_v7_defconfig:
>>
>>  * An AT24 I2C EEPROM (also used by armada-xp-lenovo-ix4-300d)
>>  * A PCA9555 I2C GPIO expander
>>  * Several fixed regulators
>>
>> Therefore, this commit adds the necessary options to mvebu_v7_defconfig.
>>
>> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> 
> 
> Acked-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
> 
applied on mvebu/config

Thanks,

Gregory

> Thanks,
> 
> Gregory
> 
>> ---
>>  arch/arm/configs/mvebu_v7_defconfig | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/arch/arm/configs/mvebu_v7_defconfig b/arch/arm/configs/mvebu_v7_defconfig
>> index cacc9f4..13fcd02 100644
>> --- a/arch/arm/configs/mvebu_v7_defconfig
>> +++ b/arch/arm/configs/mvebu_v7_defconfig
>> @@ -58,6 +58,7 @@ CONFIG_MTD_M25P80=y
>>  CONFIG_MTD_NAND=y
>>  CONFIG_MTD_NAND_PXA3xx=y
>>  CONFIG_MTD_SPI_NOR=y
>> +CONFIG_EEPROM_AT24=y
>>  CONFIG_BLK_DEV_SD=y
>>  CONFIG_ATA=y
>>  CONFIG_AHCI_MVEBU=y
>> @@ -83,11 +84,14 @@ CONFIG_I2C_MV64XXX=y
>>  CONFIG_SPI=y
>>  CONFIG_SPI_ORION=y
>>  CONFIG_GPIO_SYSFS=y
>> +CONFIG_GPIO_PCA953X=y
>>  CONFIG_SENSORS_GPIO_FAN=y
>>  CONFIG_THERMAL=y
>>  CONFIG_ARMADA_THERMAL=y
>>  CONFIG_WATCHDOG=y
>>  CONFIG_ORION_WATCHDOG=y
>> +CONFIG_REGULATOR=y
>> +CONFIG_REGULATOR_FIXED_VOLTAGE=y
>>  CONFIG_SOUND=y
>>  CONFIG_SND=y
>>  CONFIG_SND_SOC=y
>>
> 
> 


-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com