From: Hauke Mehrtens <hauke-5/S+JYg5SzeELgA04lAiVw@public.gmane.org> To: "Florian Fainelli" <f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, "Rafał Miłecki" <zajec5-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Cc: "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" <linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>, bcm-kernel-feedback-list <bcm-kernel-feedback-list-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>, "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org> Subject: Re: [PATCH] ARM: BCM5301X: Enable UART0 for SmartRG SR-400AC Date: Wed, 01 Jul 2015 00:04:55 +0200 [thread overview] Message-ID: <55931287.4040609@hauke-m.de> (raw) In-Reply-To: <558F500C.6040004-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> On 06/28/2015 03:38 AM, Florian Fainelli wrote: > Le 06/27/15 15:08, Rafał Miłecki a écrit : >> On 24 June 2015 at 01:51, Florian Fainelli <f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote: >>> Enable the use of UART0 by overriding its default status property. >>> >>> Signed-off-by: Florian Fainelli <f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> >>> --- >>> arch/arm/boot/dts/bcm4708-smartrg-sr400ac.dts | 4 ++++ >>> 1 file changed, 4 insertions(+) >>> >>> diff --git a/arch/arm/boot/dts/bcm4708-smartrg-sr400ac.dts b/arch/arm/boot/dts/bcm4708-smartrg-sr400ac.dts >>> index d6a033b97c70..64a5e8ab65e0 100644 >>> --- a/arch/arm/boot/dts/bcm4708-smartrg-sr400ac.dts >>> +++ b/arch/arm/boot/dts/bcm4708-smartrg-sr400ac.dts >>> @@ -118,3 +118,7 @@ >>> }; >>> }; >>> }; >>> + >>> +&uart0 { >>> + status = "okay"; >>> +}; >> >> We have many more changes like this in OpenWrt, I just didn't upstream >> them because of current chipcommonA state. >> >> It was added before we got "brcm,bus-axi" and I believe Hauke wanted >> move it to the "correct" place at some point. Since UART is part of >> ChipCommon device and ChipCommon is part of "brcm,bus-axi",.I guess we >> should add UARTs as a ChipCommon device subnodes. We already have >> chipcommon: chipcommon@0 { >> reg = <0x00000000 0x1000>; >> >> gpio-controller; >> #gpio-cells = <2>; >> }; >> , is it possible to move UARTs there? I added it at the beginning of the port so I have serial, even without adding support for bcma. I haven't look at that part later, but it should go into the chipcommon part. Thats for the patches. >> >> I'm not sure if this UART cleanup should block your change. I guess it >> depends on the way it'll finally look like. > > I do not think it will, see below: > >> >> I'm also wondering: is there any preference between overwriting status >> with something like >> &uart0 { }; >> and >> chipcommonA { >> uart0: serial@0300 { }; >> }; >> ? I don't know DT that well, just asking. > > An alias can be located pretty much anywhere in the DTS as long as the > name is unique, which is why I took this approach, because I do not have > to do something like this and need to know the full depth of the tree: > > foo0 { > bar0 { > baz0 { > status = "okay"; > }; > }; > }; > > This is both more compact, and more robust to re-parenting the UART0 > node in case you ever wanted to do it in the future. > > I will happily fix the other DTSes to use that convention if we agree > this is the route to take. I haven't used that earlier because I did not know of this feature. I think Rafał already did or is currently doing this steps. Hauke -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: hauke@hauke-m.de (Hauke Mehrtens) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH] ARM: BCM5301X: Enable UART0 for SmartRG SR-400AC Date: Wed, 01 Jul 2015 00:04:55 +0200 [thread overview] Message-ID: <55931287.4040609@hauke-m.de> (raw) In-Reply-To: <558F500C.6040004@gmail.com> On 06/28/2015 03:38 AM, Florian Fainelli wrote: > Le 06/27/15 15:08, Rafa? Mi?ecki a ?crit : >> On 24 June 2015 at 01:51, Florian Fainelli <f.fainelli@gmail.com> wrote: >>> Enable the use of UART0 by overriding its default status property. >>> >>> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> >>> --- >>> arch/arm/boot/dts/bcm4708-smartrg-sr400ac.dts | 4 ++++ >>> 1 file changed, 4 insertions(+) >>> >>> diff --git a/arch/arm/boot/dts/bcm4708-smartrg-sr400ac.dts b/arch/arm/boot/dts/bcm4708-smartrg-sr400ac.dts >>> index d6a033b97c70..64a5e8ab65e0 100644 >>> --- a/arch/arm/boot/dts/bcm4708-smartrg-sr400ac.dts >>> +++ b/arch/arm/boot/dts/bcm4708-smartrg-sr400ac.dts >>> @@ -118,3 +118,7 @@ >>> }; >>> }; >>> }; >>> + >>> +&uart0 { >>> + status = "okay"; >>> +}; >> >> We have many more changes like this in OpenWrt, I just didn't upstream >> them because of current chipcommonA state. >> >> It was added before we got "brcm,bus-axi" and I believe Hauke wanted >> move it to the "correct" place at some point. Since UART is part of >> ChipCommon device and ChipCommon is part of "brcm,bus-axi",.I guess we >> should add UARTs as a ChipCommon device subnodes. We already have >> chipcommon: chipcommon at 0 { >> reg = <0x00000000 0x1000>; >> >> gpio-controller; >> #gpio-cells = <2>; >> }; >> , is it possible to move UARTs there? I added it at the beginning of the port so I have serial, even without adding support for bcma. I haven't look at that part later, but it should go into the chipcommon part. Thats for the patches. >> >> I'm not sure if this UART cleanup should block your change. I guess it >> depends on the way it'll finally look like. > > I do not think it will, see below: > >> >> I'm also wondering: is there any preference between overwriting status >> with something like >> &uart0 { }; >> and >> chipcommonA { >> uart0: serial at 0300 { }; >> }; >> ? I don't know DT that well, just asking. > > An alias can be located pretty much anywhere in the DTS as long as the > name is unique, which is why I took this approach, because I do not have > to do something like this and need to know the full depth of the tree: > > foo0 { > bar0 { > baz0 { > status = "okay"; > }; > }; > }; > > This is both more compact, and more robust to re-parenting the UART0 > node in case you ever wanted to do it in the future. > > I will happily fix the other DTSes to use that convention if we agree > this is the route to take. I haven't used that earlier because I did not know of this feature. I think Rafa? already did or is currently doing this steps. Hauke
next prev parent reply other threads:[~2015-06-30 22:04 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-06-23 23:51 [PATCH] ARM: BCM5301X: Enable UART0 for SmartRG SR-400AC Florian Fainelli 2015-06-23 23:51 ` Florian Fainelli [not found] ` <1435103504-28592-1-git-send-email-f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2015-06-24 21:48 ` Tyler Baker 2015-06-24 21:48 ` Tyler Baker 2015-06-24 21:56 ` Rafał Miłecki 2015-06-24 21:56 ` Rafał Miłecki 2015-06-27 22:08 ` Rafał Miłecki 2015-06-27 22:08 ` Rafał Miłecki [not found] ` <CACna6rzJE8Gzrwvj+nCw=qCRho=6nZ+k1h_tFQLhNZvf5zWTDg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2015-06-28 1:38 ` Florian Fainelli 2015-06-28 1:38 ` Florian Fainelli [not found] ` <558F500C.6040004-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2015-06-28 7:17 ` Rafał Miłecki 2015-06-28 7:17 ` Rafał Miłecki 2015-06-30 22:04 ` Hauke Mehrtens [this message] 2015-06-30 22:04 ` Hauke Mehrtens 2015-06-28 17:46 ` [PATCH] ARM: BCM5301X: Enable UART0 on tested devices Rafał Miłecki 2015-06-28 17:48 ` Hauke Mehrtens 2015-06-29 5:22 ` [PATCH V2] " Rafał Miłecki 2015-07-08 1:09 ` Florian Fainelli
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=55931287.4040609@hauke-m.de \ --to=hauke-5/s+jyg5szeelga04laivw@public.gmane.org \ --cc=bcm-kernel-feedback-list-dY08KVG/lbpWk0Htik3J/w@public.gmane.org \ --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \ --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \ --cc=zajec5-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.