* [PATCH] tcp: fix __tcp_transmit_skb's comment text
@ 2019-02-26 8:41 Geliang Tang
2019-02-26 15:11 ` Eric Dumazet
0 siblings, 1 reply; 2+ messages in thread
From: Geliang Tang @ 2019-02-26 8:41 UTC (permalink / raw)
To: Eric Dumazet, David S. Miller, Alexey Kuznetsov, Hideaki YOSHIFUJI
Cc: Geliang Tang, netdev, linux-kernel
The function name tcp_do_sendmsg has been renamed. But it still
appears in __tcp_transmit_skb's comment text. This patch changes
it to tcp_sendmsg_locked.
Signed-off-by: Geliang Tang <geliangtang@gmail.com>
---
net/ipv4/tcp_output.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv4/tcp_output.c b/net/ipv4/tcp_output.c
index e72aa0ff5785..67a43b966b8a 100644
--- a/net/ipv4/tcp_output.c
+++ b/net/ipv4/tcp_output.c
@@ -1003,7 +1003,7 @@ static void tcp_update_skb_after_send(struct sock *sk, struct sk_buff *skb,
}
/* This routine actually transmits TCP packets queued in by
- * tcp_do_sendmsg(). This is used by both the initial
+ * tcp_sendmsg_locked(). This is used by both the initial
* transmission and possible later retransmissions.
* All SKB's seen here are completely headerless. It is our
* job to build the TCP header, and pass the packet down to
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] tcp: fix __tcp_transmit_skb's comment text
2019-02-26 8:41 [PATCH] tcp: fix __tcp_transmit_skb's comment text Geliang Tang
@ 2019-02-26 15:11 ` Eric Dumazet
0 siblings, 0 replies; 2+ messages in thread
From: Eric Dumazet @ 2019-02-26 15:11 UTC (permalink / raw)
To: Geliang Tang, Eric Dumazet, David S. Miller, Alexey Kuznetsov,
Hideaki YOSHIFUJI
Cc: netdev, linux-kernel
On 02/26/2019 12:41 AM, Geliang Tang wrote:
> The function name tcp_do_sendmsg has been renamed. But it still
> appears in __tcp_transmit_skb's comment text. This patch changes
> it to tcp_sendmsg_locked.
>
> Signed-off-by: Geliang Tang <geliangtang@gmail.com>
> ---
> net/ipv4/tcp_output.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/ipv4/tcp_output.c b/net/ipv4/tcp_output.c
> index e72aa0ff5785..67a43b966b8a 100644
> --- a/net/ipv4/tcp_output.c
> +++ b/net/ipv4/tcp_output.c
> @@ -1003,7 +1003,7 @@ static void tcp_update_skb_after_send(struct sock *sk, struct sk_buff *skb,
> }
>
> /* This routine actually transmits TCP packets queued in by
> - * tcp_do_sendmsg(). This is used by both the initial
> + * tcp_sendmsg_locked(). This is used by both the initial
> * transmission and possible later retransmissions.
> * All SKB's seen here are completely headerless. It is our
> * job to build the TCP header, and pass the packet down to
>
Not sure your patch helps, packets can also be put in write queue
by many different functions, including tcp_sendmsg_locked().
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-02-26 15:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-26 8:41 [PATCH] tcp: fix __tcp_transmit_skb's comment text Geliang Tang
2019-02-26 15:11 ` Eric Dumazet
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.