From: Anna Schumaker <schumaker.anna-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> To: Chuck Lever <chuck.lever-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>, linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Subject: Re: [PATCH v1 10/12] xprtrdma: Fix large NFS SYMLINK calls Date: Tue, 14 Jul 2015 12:01:29 -0400 [thread overview] Message-ID: <55A53259.8090606@gmail.com> (raw) In-Reply-To: <20150709204315.26247.47851.stgit-FYjufvaPoItvLzlybtyyYzGyq/o6K9yX@public.gmane.org> Hey Chuck, On 07/09/2015 04:43 PM, Chuck Lever wrote: > Repair how rpcrdma_marshal_req() chooses which RDMA message type > to use for large non-WRITE operations so that it picks RDMA_NOMSG > in the correct situations, and sets up the marshaling logic to > SEND only the RPC/RDMA header. > > Large NFSv2 SYMLINK requests now use RDMA_NOMSG calls. The Linux NFS > server XDR decoder for NFSv2 SYMLINK does not handle having the > pathname argument arrive in a separate buffer. The decoder could be > fixed, but this is simpler and RDMA_NOMSG can be used in a variety > of other situations. > > Ensure that the Linux client continues to use "RDMA_MSG + read > list" when sending large NFSv3 SYMLINK requests, which is more > efficient than using RDMA_NOMSG. > > Large NFSv4 CREATE(NF4LNK) requests are changed to use "RDMA_MSG + > read list" just like NFSv3 (see Section 5 of RFC 5667). Before, > these did not work at all. > > Signed-off-by: Chuck Lever <chuck.lever-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> > --- > fs/nfs/nfs3xdr.c | 1 + > fs/nfs/nfs4xdr.c | 1 + > net/sunrpc/xprtrdma/rpc_rdma.c | 21 ++++++++++++--------- > 3 files changed, 14 insertions(+), 9 deletions(-) It might be better to split this into separate patches for nfs and sunrpc, since Trond might want to accept the nfs changes separately. Anna > > diff --git a/fs/nfs/nfs3xdr.c b/fs/nfs/nfs3xdr.c > index 9b04c2e..267126d 100644 > --- a/fs/nfs/nfs3xdr.c > +++ b/fs/nfs/nfs3xdr.c > @@ -1103,6 +1103,7 @@ static void nfs3_xdr_enc_symlink3args(struct rpc_rqst *req, > { > encode_diropargs3(xdr, args->fromfh, args->fromname, args->fromlen); > encode_symlinkdata3(xdr, args); > + xdr->buf->flags |= XDRBUF_WRITE; > } > > /* > diff --git a/fs/nfs/nfs4xdr.c b/fs/nfs/nfs4xdr.c > index 558cd65d..03a20ec 100644 > --- a/fs/nfs/nfs4xdr.c > +++ b/fs/nfs/nfs4xdr.c > @@ -1155,6 +1155,7 @@ static void encode_create(struct xdr_stream *xdr, const struct nfs4_create_arg * > p = reserve_space(xdr, 4); > *p = cpu_to_be32(create->u.symlink.len); > xdr_write_pages(xdr, create->u.symlink.pages, 0, create->u.symlink.len); > + xdr->buf->flags |= XDRBUF_WRITE; > break; > > case NF4BLK: case NF4CHR: > diff --git a/net/sunrpc/xprtrdma/rpc_rdma.c b/net/sunrpc/xprtrdma/rpc_rdma.c > index 2e721f2..64fc4b4 100644 > --- a/net/sunrpc/xprtrdma/rpc_rdma.c > +++ b/net/sunrpc/xprtrdma/rpc_rdma.c > @@ -484,21 +484,24 @@ rpcrdma_marshal_req(struct rpc_rqst *rqst) > * > * o If the total request is under the inline threshold, all ops > * are sent as inline. > - * o Large non-write ops are sent with the entire message as a > - * single read chunk (protocol 0-position special case). > * o Large write ops transmit data as read chunk(s), header as > * inline. > + * o Large non-write ops are sent with the entire message as a > + * single read chunk (protocol 0-position special case). > * > - * Note: the NFS code sending down multiple argument segments > - * implies the op is a write. > - * TBD check NFSv4 setacl > + * This assumes that the upper layer does not present a request > + * that both has a data payload, and whose non-data arguments > + * by themselves are larger than the inline threshold. > */ > - if (rpcrdma_args_inline(rqst)) > + if (rpcrdma_args_inline(rqst)) { > rtype = rpcrdma_noch; > - else if (rqst->rq_snd_buf.page_len == 0) > - rtype = rpcrdma_areadch; > - else > + } else if (rqst->rq_snd_buf.flags & XDRBUF_WRITE) { > rtype = rpcrdma_readch; > + } else { > + headerp->rm_type = htonl(RDMA_NOMSG); > + rtype = rpcrdma_areadch; > + rpclen = 0; > + } > > /* The following simplification is not true forever */ > if (rtype != rpcrdma_noch && wtype == rpcrdma_replych) > > -- > To unsubscribe from this list: send the line "unsubscribe linux-nfs" in > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Anna Schumaker <schumaker.anna@gmail.com> To: Chuck Lever <chuck.lever@oracle.com>, <linux-rdma@vger.kernel.org>, <linux-nfs@vger.kernel.org> Subject: Re: [PATCH v1 10/12] xprtrdma: Fix large NFS SYMLINK calls Date: Tue, 14 Jul 2015 12:01:29 -0400 [thread overview] Message-ID: <55A53259.8090606@gmail.com> (raw) In-Reply-To: <20150709204315.26247.47851.stgit@manet.1015granger.net> Hey Chuck, On 07/09/2015 04:43 PM, Chuck Lever wrote: > Repair how rpcrdma_marshal_req() chooses which RDMA message type > to use for large non-WRITE operations so that it picks RDMA_NOMSG > in the correct situations, and sets up the marshaling logic to > SEND only the RPC/RDMA header. > > Large NFSv2 SYMLINK requests now use RDMA_NOMSG calls. The Linux NFS > server XDR decoder for NFSv2 SYMLINK does not handle having the > pathname argument arrive in a separate buffer. The decoder could be > fixed, but this is simpler and RDMA_NOMSG can be used in a variety > of other situations. > > Ensure that the Linux client continues to use "RDMA_MSG + read > list" when sending large NFSv3 SYMLINK requests, which is more > efficient than using RDMA_NOMSG. > > Large NFSv4 CREATE(NF4LNK) requests are changed to use "RDMA_MSG + > read list" just like NFSv3 (see Section 5 of RFC 5667). Before, > these did not work at all. > > Signed-off-by: Chuck Lever <chuck.lever@oracle.com> > --- > fs/nfs/nfs3xdr.c | 1 + > fs/nfs/nfs4xdr.c | 1 + > net/sunrpc/xprtrdma/rpc_rdma.c | 21 ++++++++++++--------- > 3 files changed, 14 insertions(+), 9 deletions(-) It might be better to split this into separate patches for nfs and sunrpc, since Trond might want to accept the nfs changes separately. Anna > > diff --git a/fs/nfs/nfs3xdr.c b/fs/nfs/nfs3xdr.c > index 9b04c2e..267126d 100644 > --- a/fs/nfs/nfs3xdr.c > +++ b/fs/nfs/nfs3xdr.c > @@ -1103,6 +1103,7 @@ static void nfs3_xdr_enc_symlink3args(struct rpc_rqst *req, > { > encode_diropargs3(xdr, args->fromfh, args->fromname, args->fromlen); > encode_symlinkdata3(xdr, args); > + xdr->buf->flags |= XDRBUF_WRITE; > } > > /* > diff --git a/fs/nfs/nfs4xdr.c b/fs/nfs/nfs4xdr.c > index 558cd65d..03a20ec 100644 > --- a/fs/nfs/nfs4xdr.c > +++ b/fs/nfs/nfs4xdr.c > @@ -1155,6 +1155,7 @@ static void encode_create(struct xdr_stream *xdr, const struct nfs4_create_arg * > p = reserve_space(xdr, 4); > *p = cpu_to_be32(create->u.symlink.len); > xdr_write_pages(xdr, create->u.symlink.pages, 0, create->u.symlink.len); > + xdr->buf->flags |= XDRBUF_WRITE; > break; > > case NF4BLK: case NF4CHR: > diff --git a/net/sunrpc/xprtrdma/rpc_rdma.c b/net/sunrpc/xprtrdma/rpc_rdma.c > index 2e721f2..64fc4b4 100644 > --- a/net/sunrpc/xprtrdma/rpc_rdma.c > +++ b/net/sunrpc/xprtrdma/rpc_rdma.c > @@ -484,21 +484,24 @@ rpcrdma_marshal_req(struct rpc_rqst *rqst) > * > * o If the total request is under the inline threshold, all ops > * are sent as inline. > - * o Large non-write ops are sent with the entire message as a > - * single read chunk (protocol 0-position special case). > * o Large write ops transmit data as read chunk(s), header as > * inline. > + * o Large non-write ops are sent with the entire message as a > + * single read chunk (protocol 0-position special case). > * > - * Note: the NFS code sending down multiple argument segments > - * implies the op is a write. > - * TBD check NFSv4 setacl > + * This assumes that the upper layer does not present a request > + * that both has a data payload, and whose non-data arguments > + * by themselves are larger than the inline threshold. > */ > - if (rpcrdma_args_inline(rqst)) > + if (rpcrdma_args_inline(rqst)) { > rtype = rpcrdma_noch; > - else if (rqst->rq_snd_buf.page_len == 0) > - rtype = rpcrdma_areadch; > - else > + } else if (rqst->rq_snd_buf.flags & XDRBUF_WRITE) { > rtype = rpcrdma_readch; > + } else { > + headerp->rm_type = htonl(RDMA_NOMSG); > + rtype = rpcrdma_areadch; > + rpclen = 0; > + } > > /* The following simplification is not true forever */ > if (rtype != rpcrdma_noch && wtype == rpcrdma_replych) > > -- > To unsubscribe from this list: send the line "unsubscribe linux-nfs" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >
next prev parent reply other threads:[~2015-07-14 16:01 UTC|newest] Thread overview: 92+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-07-09 20:41 [PATCH v1 00/12] NFS/RDMA client side for Linux 4.3 Chuck Lever 2015-07-09 20:41 ` Chuck Lever [not found] ` <20150709203242.26247.4848.stgit-FYjufvaPoItvLzlybtyyYzGyq/o6K9yX@public.gmane.org> 2015-07-09 20:41 ` [PATCH v1 01/12] xprtrdma: Make xprt_setup_rdma() agnostic to family of server address Chuck Lever 2015-07-09 20:41 ` Chuck Lever 2015-07-09 20:41 ` [PATCH v1 02/12] xprtrdma: Raise maximum payload size to one megabyte Chuck Lever 2015-07-09 20:41 ` Chuck Lever [not found] ` <20150709204159.26247.44592.stgit-FYjufvaPoItvLzlybtyyYzGyq/o6K9yX@public.gmane.org> 2015-07-10 10:25 ` Devesh Sharma 2015-07-10 10:25 ` Devesh Sharma 2015-07-10 19:21 ` Anna Schumaker 2015-07-10 19:21 ` Anna Schumaker [not found] ` <55A01B56.2020107-ZwjVKphTwtPQT0dZR+AlfA@public.gmane.org> 2015-07-10 19:33 ` Chuck Lever 2015-07-10 19:33 ` Chuck Lever [not found] ` <F9717330-F362-477B-915D-D6AAE7B5DDDB-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> 2015-07-10 19:41 ` Anna Schumaker 2015-07-10 19:41 ` Anna Schumaker 2015-07-12 14:31 ` Sagi Grimberg 2015-07-12 14:31 ` Sagi Grimberg 2015-07-09 20:42 ` [PATCH v1 03/12] xprtrdma: Increase default credit limit Chuck Lever 2015-07-09 20:42 ` Chuck Lever [not found] ` <20150709204208.26247.52073.stgit-FYjufvaPoItvLzlybtyyYzGyq/o6K9yX@public.gmane.org> 2015-07-10 10:45 ` Devesh Sharma 2015-07-10 10:45 ` Devesh Sharma [not found] ` <CANjDDBiMDM5VP5ev3LFfapX-5amqukH=dJdaEZVcZc9SSP2CCg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2015-07-10 14:33 ` Chuck Lever 2015-07-10 14:33 ` Chuck Lever [not found] ` <B6E6A65D-DE61-4A95-91D7-1E8A5132F7EE-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> 2015-07-10 14:47 ` Devesh Sharma 2015-07-10 14:47 ` Devesh Sharma 2015-07-12 14:31 ` Sagi Grimberg 2015-07-12 14:31 ` Sagi Grimberg 2015-07-09 20:42 ` [PATCH v1 04/12] xprtrdma: Remove last ib_reg_phys_mr() call site Chuck Lever 2015-07-09 20:42 ` Chuck Lever [not found] ` <20150709204218.26247.67243.stgit-FYjufvaPoItvLzlybtyyYzGyq/o6K9yX@public.gmane.org> 2015-07-10 10:52 ` Devesh Sharma 2015-07-10 10:52 ` Devesh Sharma 2015-07-11 10:34 ` Christoph Hellwig 2015-07-11 10:34 ` Christoph Hellwig [not found] ` <20150711103428.GD14741-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org> 2015-07-11 18:50 ` Chuck Lever 2015-07-11 18:50 ` Chuck Lever [not found] ` <682604AF-955A-44F8-86F9-EB7D403CABFF-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2015-07-12 7:58 ` Christoph Hellwig 2015-07-12 7:58 ` Christoph Hellwig 2015-07-12 14:31 ` Sagi Grimberg 2015-07-12 14:31 ` Sagi Grimberg 2015-07-09 20:42 ` [PATCH v1 05/12] xprtrdma: Account for RPC/RDMA header size when deciding to inline Chuck Lever 2015-07-09 20:42 ` Chuck Lever [not found] ` <20150709204227.26247.51111.stgit-FYjufvaPoItvLzlybtyyYzGyq/o6K9yX@public.gmane.org> 2015-07-10 10:55 ` Devesh Sharma 2015-07-10 10:55 ` Devesh Sharma 2015-07-10 20:08 ` Anna Schumaker 2015-07-10 20:08 ` Anna Schumaker [not found] ` <55A02650.1050809-ZwjVKphTwtPQT0dZR+AlfA@public.gmane.org> 2015-07-10 20:28 ` Chuck Lever 2015-07-10 20:28 ` Chuck Lever 2015-07-12 14:37 ` Sagi Grimberg 2015-07-12 14:37 ` Sagi Grimberg [not found] ` <55A27B9D.5010002-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org> 2015-07-12 17:52 ` Chuck Lever 2015-07-12 17:52 ` Chuck Lever 2015-07-09 20:42 ` [PATCH v1 06/12] xprtrdma: Always provide a write list when sending NFS READ Chuck Lever 2015-07-09 20:42 ` Chuck Lever [not found] ` <20150709204237.26247.297.stgit-FYjufvaPoItvLzlybtyyYzGyq/o6K9yX@public.gmane.org> 2015-07-10 11:08 ` Devesh Sharma 2015-07-10 11:08 ` Devesh Sharma 2015-07-12 14:42 ` Sagi Grimberg 2015-07-12 14:42 ` Sagi Grimberg 2015-07-09 20:42 ` [PATCH v1 07/12] xprtrdma: Don't provide a reply chunk when expecting a short reply Chuck Lever 2015-07-09 20:42 ` Chuck Lever [not found] ` <20150709204246.26247.10367.stgit-FYjufvaPoItvLzlybtyyYzGyq/o6K9yX@public.gmane.org> 2015-07-12 14:58 ` Sagi Grimberg 2015-07-12 14:58 ` Sagi Grimberg [not found] ` <55A2809C.7020106-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org> 2015-07-12 18:38 ` Chuck Lever 2015-07-12 18:38 ` Chuck Lever [not found] ` <2EB8EA33-9345-4D18-8BE1-39C4EB2658E2-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> 2015-07-14 9:54 ` Sagi Grimberg 2015-07-14 9:54 ` Sagi Grimberg 2015-07-09 20:42 ` [PATCH v1 08/12] xprtrdma: Fix XDR tail buffer marshalling Chuck Lever 2015-07-09 20:42 ` Chuck Lever 2015-07-09 20:43 ` [PATCH v1 09/12] xprtrdma: Prepare rpcrdma_ep_post() for RDMA_NOMSG calls Chuck Lever 2015-07-09 20:43 ` Chuck Lever [not found] ` <20150709204305.26247.39173.stgit-FYjufvaPoItvLzlybtyyYzGyq/o6K9yX@public.gmane.org> 2015-07-10 11:29 ` Devesh Sharma 2015-07-10 11:29 ` Devesh Sharma [not found] ` <CANjDDBh38PrxGgWGuKYCYcbjqY9ELrpkGqaRZ_ueKfD7FEQP8g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2015-07-10 12:58 ` Tom Talpey 2015-07-10 12:58 ` Tom Talpey [not found] ` <559FC17A.7060502-CLs1Zie5N5HQT0dZR+AlfA@public.gmane.org> 2015-07-10 14:11 ` Devesh Sharma 2015-07-10 14:11 ` Devesh Sharma [not found] ` <CANjDDBipaXMO7Z5wirG127E9kQ0aHdWJ1s6ZM21th5RWLNh-4Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2015-07-10 14:53 ` Chuck Lever 2015-07-10 14:53 ` Chuck Lever [not found] ` <F5F5CAC4-866E-4BCA-8094-908CE9ED3B4B-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> 2015-07-10 22:44 ` Jason Gunthorpe 2015-07-10 22:44 ` Jason Gunthorpe 2015-07-10 20:43 ` Anna Schumaker 2015-07-10 20:43 ` Anna Schumaker [not found] ` <55A02E73.7000902-ZwjVKphTwtPQT0dZR+AlfA@public.gmane.org> 2015-07-10 20:52 ` Chuck Lever 2015-07-10 20:52 ` Chuck Lever 2015-07-09 20:43 ` [PATCH v1 10/12] xprtrdma: Fix large NFS SYMLINK calls Chuck Lever 2015-07-09 20:43 ` Chuck Lever [not found] ` <20150709204315.26247.47851.stgit-FYjufvaPoItvLzlybtyyYzGyq/o6K9yX@public.gmane.org> 2015-07-14 16:01 ` Anna Schumaker [this message] 2015-07-14 16:01 ` Anna Schumaker [not found] ` <55A53259.8090606-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2015-07-14 19:09 ` Chuck Lever 2015-07-14 19:09 ` Chuck Lever 2015-07-09 20:43 ` [PATCH v1 11/12] xprtrdma: Clean up xprt_rdma_print_stats() Chuck Lever 2015-07-09 20:43 ` Chuck Lever 2015-07-09 20:43 ` [PATCH v1 12/12] xprtrdma: Count RDMA_NOMSG type calls Chuck Lever 2015-07-09 20:43 ` Chuck Lever
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=55A53259.8090606@gmail.com \ --to=schumaker.anna-re5jqeeqqe8avxtiumwx3w@public.gmane.org \ --cc=chuck.lever-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \ --cc=linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.