From: Paolo Bonzini <pbonzini@redhat.com>
To: Jason Wang <jasowang@redhat.com>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, cornelia.huck@de.ibm.com,
qemu-block@nongnu.org, stefanha@redhat.com, mst@redhat.com
Subject: Re: [Qemu-devel] [PATCH V2 2/5] virtio-blk: advertise scsi only when scsi is set
Date: Wed, 15 Jul 2015 10:33:10 +0200 [thread overview]
Message-ID: <55A61AC6.2050805@redhat.com> (raw)
In-Reply-To: <55A61A70.4090109@redhat.com>
On 15/07/2015 10:31, Jason Wang wrote:
> > This must only be done for newer machine types only, or you change guest
> > ABI for scsi=off. Effectively you have to split it in two properties,
> > "scsi" and "always_set_f_scsi".
>
> And always_set_f_scsi is true only for legacy machine types?
s/legacy/older/ :)
It's also ignored for modern devices. So perhaps you could name it to
transitional_force_f_scsi or something like that.
Paolo
next prev parent reply other threads:[~2015-07-15 8:33 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-15 5:29 [Qemu-devel] [PATCH V2 0/5] Set correct blk feature for virtio 1.0 Jason Wang
2015-07-15 5:29 ` [Qemu-devel] [PATCH V2 1/5] virtio: get_features() can fail Jason Wang
2015-07-15 9:01 ` Cornelia Huck
2015-07-15 9:11 ` Jason Wang
2015-07-15 11:36 ` Paolo Bonzini
2015-07-22 15:13 ` Markus Armbruster
2015-07-15 5:29 ` [Qemu-devel] [PATCH V2 2/5] virtio-blk: advertise scsi only when scsi is set Jason Wang
2015-07-15 7:57 ` Paolo Bonzini
2015-07-15 8:31 ` Jason Wang
2015-07-15 8:33 ` Paolo Bonzini [this message]
2015-07-15 5:29 ` [Qemu-devel] [PATCH V2 3/5] virtio-blk: disable scsi passthrough by default Jason Wang
2015-07-15 12:21 ` Michael S. Tsirkin
2015-07-15 12:47 ` Paolo Bonzini
2015-07-15 14:14 ` Michael S. Tsirkin
2015-07-15 14:18 ` Paolo Bonzini
2015-07-15 14:28 ` Michael S. Tsirkin
2015-07-15 14:45 ` Paolo Bonzini
2015-10-14 10:29 ` Cornelia Huck
2015-10-14 15:58 ` Paolo Bonzini
2015-07-15 5:30 ` [Qemu-devel] [PATCH V2 4/5] virtio-blk: fail the init when both 1.0 and scsi is set Jason Wang
2015-07-15 5:30 ` [Qemu-devel] [PATCH V2 5/5] virtio-blk: set VIRTIO_F_ANY_LAYOUT when 1.0 is supported Jason Wang
2015-07-15 9:11 ` [Qemu-devel] [PATCH V2 0/5] Set correct blk feature for virtio 1.0 Cornelia Huck
2015-07-15 9:39 ` Jason Wang
2015-07-15 11:38 ` Cornelia Huck
2015-07-15 11:52 ` Michael S. Tsirkin
2015-07-15 12:46 ` Cornelia Huck
2015-07-15 14:08 ` Michael S. Tsirkin
2015-07-15 14:20 ` Cornelia Huck
2015-07-15 11:49 ` Michael S. Tsirkin
2015-07-15 12:49 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55A61AC6.2050805@redhat.com \
--to=pbonzini@redhat.com \
--cc=cornelia.huck@de.ibm.com \
--cc=jasowang@redhat.com \
--cc=kwolf@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.