[U-Boot] [PATCH] mx6sabresd: Use 'int' for return values

[U-Boot] [PATCH] mx6sabresd: Use 'int' for return values

[Fabio Estevam]

From: Fabio Estevam <fabio.estevam@freescale.com>

The variable 'ret' is used to store the value returned by pfuze_mode_init(),
so it should of type 'int' instead of 'unsigned int' in order to correctly
handle negative numbers.

Fix the variable type.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 board/freescale/mx6sabresd/mx6sabresd.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/board/freescale/mx6sabresd/mx6sabresd.c b/board/freescale/mx6sabresd/mx6sabresd.c
index 23f8f6b..fa800f4 100644
--- a/board/freescale/mx6sabresd/mx6sabresd.c
+++ b/board/freescale/mx6sabresd/mx6sabresd.c
@@ -631,7 +631,8 @@ int board_init(void)
 int power_init_board(void)
 {
 	struct pmic *p;
-	unsigned int reg, ret;
+	unsigned int reg;
+	int ret;
 
 	p = pfuze_common_init(I2C_PMIC);
 	if (!p)
-- 
1.9.1

[U-Boot] [PATCH] mx6sabresd: Use 'int' for return values

[Stefano Babic]

Hi Fabio,

On 22/07/2015 01:02, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> The variable 'ret' is used to store the value returned by pfuze_mode_init(),
> so it should of type 'int' instead of 'unsigned int' in order to correctly
> handle negative numbers.
> 
> Fix the variable type.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
>  board/freescale/mx6sabresd/mx6sabresd.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/board/freescale/mx6sabresd/mx6sabresd.c b/board/freescale/mx6sabresd/mx6sabresd.c
> index 23f8f6b..fa800f4 100644
> --- a/board/freescale/mx6sabresd/mx6sabresd.c
> +++ b/board/freescale/mx6sabresd/mx6sabresd.c
> @@ -631,7 +631,8 @@ int board_init(void)
>  int power_init_board(void)
>  {
>  	struct pmic *p;
> -	unsigned int reg, ret;
> +	unsigned int reg;
> +	int ret;
>  
>  	p = pfuze_common_init(I2C_PMIC);
>  	if (!p)
> 

Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================