All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Hansen <dave.hansen@intel.com>
To: Tim Chen <tim.c.chen@linux.intel.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
	Chandramouli Narayanan <mouli@linux.intel.com>,
	x86@kernel.org, linux-kernel@vger.kernel.org,
	Borislav Petkov <bp@suse.de>
Subject: Re: [PATCH] sha: Enable cpuid check for Intel SHA extensions implementations
Date: Mon, 17 Aug 2015 14:19:38 -0700	[thread overview]
Message-ID: <55D24FEA.1000803@intel.com> (raw)
In-Reply-To: <1439844283.21627.5.camel@schen9-desk2.jf.intel.com>

On 08/17/2015 01:44 PM, Tim Chen wrote:
> @@ -401,6 +402,7 @@ extern const char * const x86_bug_flags[NBUGINTS*32];
>  #define cpu_has_eager_fpu	boot_cpu_has(X86_FEATURE_EAGER_FPU)
>  #define cpu_has_topoext		boot_cpu_has(X86_FEATURE_TOPOEXT)
>  #define cpu_has_bpext		boot_cpu_has(X86_FEATURE_BPEXT)
> +#define cpu_has_sha_ni		boot_cpu_has(X86_FEATURE_SHA_NI)

I think we're trying not to add these cpu_has_* macros any more.  For
MPX at least we were encouraged to call cpu_has(X86_FEATURE_*) directly.

In the patch description, it might also be nice to remind folks that
this will feature will also show up as "sha_ni" in /proc/cpuinfo.

  reply	other threads:[~2015-08-17 21:19 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-17 20:44 [PATCH] sha: Enable cpuid check for Intel SHA extensions implementations Tim Chen
2015-08-17 21:19 ` Dave Hansen [this message]
2015-08-17 22:33   ` Tim Chen
2015-08-18 16:46     ` Thomas Gleixner
2015-08-19 16:49       ` Tim Chen
2015-08-20  4:08         ` Borislav Petkov
2015-08-20 15:03           ` Tim Chen
2015-08-20 20:02             ` Thomas Gleixner
2015-08-21 21:56               ` Tim Chen
2015-08-22  9:21                 ` [tip:x86/cpufeature] x86/cpufeatures: Enable cpuid for Intel SHA extensions tip-bot for Tim Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55D24FEA.1000803@intel.com \
    --to=dave.hansen@intel.com \
    --cc=bp@suse.de \
    --cc=herbert@gondor.apana.org.au \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=mouli@linux.intel.com \
    --cc=tglx@linutronix.de \
    --cc=tim.c.chen@linux.intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.