All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: yalin wang <yalin.wang2010@gmail.com>
Cc: <adaplas@gmail.com>, <plagnioj@jcrosoft.com>,
	<linux-fbdev@vger.kernel.org>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [RFC] fbdev/riva:change to use generice function to implement reverse_order()
Date: Fri, 21 Aug 2015 09:41:22 +0300	[thread overview]
Message-ID: <55D6C812.6080400@ti.com> (raw)
In-Reply-To: <867D66CD-9A3B-4536-B537-8C065C85E497@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 745 bytes --]



On 20/08/15 14:30, yalin wang wrote:
> 
>> On Aug 20, 2015, at 19:02, Tomi Valkeinen <tomi.valkeinen@ti.com> wrote:
>>
>>
>> On 10/08/15 13:12, yalin wang wrote:
>>> This change to use swab32(bitrev32()) to implement reverse_order()
>>> function, have better performance on some platforms.
>>
>> Which platforms? Presuming you tested this, roughly how much better
>> performance? If you didn't, how do you know it's faster?
> 
> i investigate on arm64 platforms:

Ok. So is any arm64 platform actually using these devices? If these
devices are mostly used by 32bit x86 platforms, optimizing them for
arm64 doesn't make any sense.

Possibly the patches are still good for x86 also, but that needs to be
proven.

 Tomi


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: yalin wang <yalin.wang2010@gmail.com>
Cc: adaplas@gmail.com, plagnioj@jcrosoft.com,
	linux-fbdev@vger.kernel.org,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [RFC] fbdev/riva:change to use generice function to implement reverse_order()
Date: Fri, 21 Aug 2015 06:41:22 +0000	[thread overview]
Message-ID: <55D6C812.6080400@ti.com> (raw)
In-Reply-To: <867D66CD-9A3B-4536-B537-8C065C85E497@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 745 bytes --]



On 20/08/15 14:30, yalin wang wrote:
> 
>> On Aug 20, 2015, at 19:02, Tomi Valkeinen <tomi.valkeinen@ti.com> wrote:
>>
>>
>> On 10/08/15 13:12, yalin wang wrote:
>>> This change to use swab32(bitrev32()) to implement reverse_order()
>>> function, have better performance on some platforms.
>>
>> Which platforms? Presuming you tested this, roughly how much better
>> performance? If you didn't, how do you know it's faster?
> 
> i investigate on arm64 platforms:

Ok. So is any arm64 platform actually using these devices? If these
devices are mostly used by 32bit x86 platforms, optimizing them for
arm64 doesn't make any sense.

Possibly the patches are still good for x86 also, but that needs to be
proven.

 Tomi


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  reply	other threads:[~2015-08-21  6:41 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-10 10:12 [RFC] fbdev/riva:change to use generice function to implement reverse_order() yalin wang
2015-08-10 10:12 ` yalin wang
2015-08-20 11:02 ` Tomi Valkeinen
2015-08-20 11:02   ` Tomi Valkeinen
2015-08-20 11:30   ` yalin wang
2015-08-20 11:30     ` yalin wang
2015-08-21  6:41     ` Tomi Valkeinen [this message]
2015-08-21  6:41       ` Tomi Valkeinen
2015-08-21  7:46       ` yalin wang
2015-08-21  7:46         ` yalin wang
2015-08-21  8:01         ` Tomi Valkeinen
2015-08-21  8:01           ` Tomi Valkeinen
2015-08-22  7:53           ` Afzal Mohammed
2015-08-22  7:53             ` Afzal Mohammed
2015-08-24  8:31             ` yalin wang
2015-08-24  8:31               ` yalin wang
2015-08-24 13:41               ` Afzal Mohammed
2015-08-24 13:53                 ` Afzal Mohammed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55D6C812.6080400@ti.com \
    --to=tomi.valkeinen@ti.com \
    --cc=adaplas@gmail.com \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=plagnioj@jcrosoft.com \
    --cc=yalin.wang2010@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.