From: Yakir Yang <ykk@rock-chips.com> To: Thierry Reding <treding@nvidia.com> Cc: Rob Herring <robherring2@gmail.com>, Russell King - ARM Linux <linux@arm.linux.org.uk>, Heiko Stuebner <heiko@sntech.de>, Jingoo Han <jingoohan1@gmail.com>, Fabio Estevam <fabio.estevam@freescale.com>, Inki Dae <inki.dae@samsung.com>, Joe Perches <joe@perches.com>, Sean Paul <seanpaul@google.com>, Takashi Iwai <tiwai@suse.de>, dri-devel <dri-devel@lists.freedesktop.org>, Andrzej Hajda <a.hajda@samsung.com>, Gustavo Padovan <gustavo.padovan@collabora.co.uk>, "linux-samsung-soc@vger.kernel.org" <linux-samsung-soc@vger.kernel.org>, Vincent Palatin <vpalatin@chromium.org>, linux-rockchip@lists.infradead.org, Kishon Vijay Abraham I <kishon@ti.com>, David Airlie <airlied@linux.ie>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, Pawel Moll <pawel.moll@arm.com>, Ian Campbell <ijc+devicetree@hellion.org.uk>, Doug Anderson <dianders@google.com>, Rob Herring <robh+dt@kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, Mark Yao <mark.yao@rock-chips.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Kyungmin Park <kyungmin.park@samsung.com>, Daniel Kurtz <djkurtz@google.com>, Philipp Zabel <p.zabel@pengutronix.de>, Kumar Gala <galak@codeaurora.org>, Ajay kumar <ajaynumb@gmail.com>, Andy Yan <andy.yan@rock-chips.com> Subject: Re: [PATCH v3 06/14] Documentation: drm/bridge: add document for analogix_dp Date: Tue, 25 Aug 2015 22:02:25 +0800 [thread overview] Message-ID: <55DC7571.6000204@rock-chips.com> (raw) In-Reply-To: <20150825100628.GD14034@ulmo.nvidia.com> Hi Thierry, 在 2015/8/25 18:06, Thierry Reding 写道: > On Tue, Aug 25, 2015 at 05:41:19PM +0800, Yakir Yang wrote: >> Hi Thierry, >> >> 在 2015/8/25 17:12, Thierry Reding 写道: >>> On Mon, Aug 24, 2015 at 09:48:27AM -0500, Rob Herring wrote: >>>> On Mon, Aug 24, 2015 at 7:57 AM, Russell King - ARM Linux >>>> <linux@arm.linux.org.uk> wrote: >>>>> On Sun, Aug 23, 2015 at 06:23:14PM -0500, Rob Herring wrote: >>>>>> On Wed, Aug 19, 2015 at 9:50 AM, Yakir Yang <ykk@rock-chips.com> wrote: >>>>>>> + -analogix,color-depth: >>>>>>> + number of bits per colour component. >>>>>>> + COLOR_6 = 0, COLOR_8 = 1, COLOR_10 = 2, COLOR_12 = 3 >>>>>> This seems pretty generic. Just use 6, 8, 10, or 12 for values. And >>>>>> drop the vendor prefix. >>>>> Please think about this some more. What does "color-depth" mean? Does it >>>>> mean the number of bits per colour _component_, or does it mean the total >>>>> number of bits to represent a particular colour. It's confusing as it >>>>> stands. >>>> Then "component-color-bpp" perhaps? >>> There should be no need to have this in DT at all. The BPC is a property >>> of the attached panel and it should come from the panel (either the >>> panel driver or parsed from EDID if available). >> Actually I have send an email about this one to you in version 2, just past >> from that email: >> >> "samsung,color_space" and "samsung,color-depth" >> >> The drm_display_info's color_formats and bpc indicate the monitor display >> ability, but >> the edp driver could not take it as input video format directly. >> >> For example, with my DP TV I would found "RGB444 & YCRCB422 & & YCRCB444" >> support in drm_display_info.color_formats and 16bit bpc support, but RK3288 >> crtc >> driver could only output RGB & ITU formats, so finally analogix_dp-rockchip >> driver >> config crtc to RGBaaa 10bpc mode. >> >> In this sutiation, the analogix_dp core driver would pazzled by the >> drm_display_info, >> can't chose the right color_space and bpc. >> >> And this is the place that confused me, wish you could give some ideas about >> this one :-) > Your display driver should choose whatever it is capable of outputting. > If the display reports that it can do 16 bits-per-color, but your > display driver can't do it, then it should choose a configuration that > it supports. Similarily for the color encodings. If you can't generate > YCrCb444 with your hardware, then it's the driver's job to know about > that and select the next appropriate configuration. > > But hard-coding this is not the right solution because the value in DT > may end up conflicting with what the display reports. Yeah, thanks for your explain, you are right. It's the best way to get "color-depth" and "color-space" from display driver, not to hard-code in DT prop. But if the common analogix-dp driver want to get those values, then those values should come from the common drm struct data. Personally I think "struct drm_crtc" is the best place that should indicate the output ability of SoC vop/lcdc. But I haven't find out there are some place to store those message for now (I don't think it's good to modify the original color-space and color-bpc which parsed from monitor edid). So could you share sme ideas about this, and I would rather to talk with Mark (Author of rockchip drm driver) to find out the better way to fix this one. Besides, I would appreciate very much if you can share some ideas about how Exynos handler with this problem ;) Thanks, - Yakir > Thierry
WARNING: multiple messages have this Message-ID (diff)
From: Yakir Yang <ykk@rock-chips.com> To: Thierry Reding <treding@nvidia.com> Cc: Rob Herring <robherring2@gmail.com>, Russell King - ARM Linux <linux@arm.linux.org.uk>, Heiko Stuebner <heiko@sntech.de>, Jingoo Han <jingoohan1@gmail.com>, Fabio Estevam <fabio.estevam@freescale.com>, Inki Dae <inki.dae@samsung.com>, Joe Perches <joe@perches.com>, Sean Paul <seanpaul@google.com>, Takashi Iwai <tiwai@suse.de>, dri-devel <dri-devel@lists.freedesktop.org>, Andrzej Hajda <a.hajda@samsung.com>, Gustavo Padovan <gustavo.padovan@collabora.co.uk>, "linux-samsung-soc@vger.kernel.org" <linux-samsung-soc@vger.kernel.org>, Vincent Palatin <vpalatin@chromium.org>, linux-rockchip@lists.infradead.org, Kishon Vijay Abraham I <kishon@ti.com>, David Airlie <airlied@linux.ie>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, Pawel Moll <pawel.moll@arm.com>, Ian Campbell <ijc+devicetree@hellion.org.uk>, Doug Anderson <dianders@google.com>Rob Herring <ro> Subject: Re: [PATCH v3 06/14] Documentation: drm/bridge: add document for analogix_dp Date: Tue, 25 Aug 2015 22:02:25 +0800 [thread overview] Message-ID: <55DC7571.6000204@rock-chips.com> (raw) In-Reply-To: <20150825100628.GD14034@ulmo.nvidia.com> Hi Thierry, 在 2015/8/25 18:06, Thierry Reding 写道: > On Tue, Aug 25, 2015 at 05:41:19PM +0800, Yakir Yang wrote: >> Hi Thierry, >> >> 在 2015/8/25 17:12, Thierry Reding 写道: >>> On Mon, Aug 24, 2015 at 09:48:27AM -0500, Rob Herring wrote: >>>> On Mon, Aug 24, 2015 at 7:57 AM, Russell King - ARM Linux >>>> <linux@arm.linux.org.uk> wrote: >>>>> On Sun, Aug 23, 2015 at 06:23:14PM -0500, Rob Herring wrote: >>>>>> On Wed, Aug 19, 2015 at 9:50 AM, Yakir Yang <ykk@rock-chips.com> wrote: >>>>>>> + -analogix,color-depth: >>>>>>> + number of bits per colour component. >>>>>>> + COLOR_6 = 0, COLOR_8 = 1, COLOR_10 = 2, COLOR_12 = 3 >>>>>> This seems pretty generic. Just use 6, 8, 10, or 12 for values. And >>>>>> drop the vendor prefix. >>>>> Please think about this some more. What does "color-depth" mean? Does it >>>>> mean the number of bits per colour _component_, or does it mean the total >>>>> number of bits to represent a particular colour. It's confusing as it >>>>> stands. >>>> Then "component-color-bpp" perhaps? >>> There should be no need to have this in DT at all. The BPC is a property >>> of the attached panel and it should come from the panel (either the >>> panel driver or parsed from EDID if available). >> Actually I have send an email about this one to you in version 2, just past >> from that email: >> >> "samsung,color_space" and "samsung,color-depth" >> >> The drm_display_info's color_formats and bpc indicate the monitor display >> ability, but >> the edp driver could not take it as input video format directly. >> >> For example, with my DP TV I would found "RGB444 & YCRCB422 & & YCRCB444" >> support in drm_display_info.color_formats and 16bit bpc support, but RK3288 >> crtc >> driver could only output RGB & ITU formats, so finally analogix_dp-rockchip >> driver >> config crtc to RGBaaa 10bpc mode. >> >> In this sutiation, the analogix_dp core driver would pazzled by the >> drm_display_info, >> can't chose the right color_space and bpc. >> >> And this is the place that confused me, wish you could give some ideas about >> this one :-) > Your display driver should choose whatever it is capable of outputting. > If the display reports that it can do 16 bits-per-color, but your > display driver can't do it, then it should choose a configuration that > it supports. Similarily for the color encodings. If you can't generate > YCrCb444 with your hardware, then it's the driver's job to know about > that and select the next appropriate configuration. > > But hard-coding this is not the right solution because the value in DT > may end up conflicting with what the display reports. Yeah, thanks for your explain, you are right. It's the best way to get "color-depth" and "color-space" from display driver, not to hard-code in DT prop. But if the common analogix-dp driver want to get those values, then those values should come from the common drm struct data. Personally I think "struct drm_crtc" is the best place that should indicate the output ability of SoC vop/lcdc. But I haven't find out there are some place to store those message for now (I don't think it's good to modify the original color-space and color-bpc which parsed from monitor edid). So could you share sme ideas about this, and I would rather to talk with Mark (Author of rockchip drm driver) to find out the better way to fix this one. Besides, I would appreciate very much if you can share some ideas about how Exynos handler with this problem ;) Thanks, - Yakir > Thierry
next prev parent reply other threads:[~2015-08-25 14:02 UTC|newest] Thread overview: 187+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-08-19 14:48 [PATCH v3 0/14] Add Analogix Core Display Port Driver Yakir Yang 2015-08-19 14:48 ` Yakir Yang 2015-08-19 14:49 ` [PATCH v3 01/14] drm: exynos/dp: fix code style Yakir Yang 2015-08-19 14:49 ` Yakir Yang 2015-08-19 14:49 ` [PATCH v3 02/14] drm: exynos/dp: convert to drm bridge mode Yakir Yang 2015-08-19 14:49 ` Yakir Yang 2015-08-19 14:50 ` [PATCH v3 03/14] drm: bridge: analogix_dp: split exynos dp driver to bridge dir Yakir Yang 2015-08-19 14:50 ` Yakir Yang 2015-08-19 14:50 ` [PATCH v3 04/14] drm: bridge/analogix_dp: dynamic parse sync_pol & interlace & colorimetry Yakir Yang 2015-08-19 14:50 ` Yakir Yang 2015-08-19 14:50 ` [PATCH v3 05/14] drm: bridge/analogix_dp: fix link_rate & lane_count bug Yakir Yang 2015-08-19 14:50 ` Yakir Yang 2015-08-20 7:22 ` Jingoo Han 2015-08-20 7:22 ` Jingoo Han 2015-08-20 7:22 ` Jingoo Han 2015-08-20 8:04 ` Yakir Yang 2015-08-20 8:04 ` Yakir Yang 2015-08-20 8:04 ` Yakir Yang 2015-08-19 14:50 ` [PATCH v3 06/14] Documentation: drm/bridge: add document for analogix_dp Yakir Yang 2015-08-19 14:50 ` Yakir Yang 2015-08-23 23:23 ` Rob Herring 2015-08-23 23:23 ` Rob Herring 2015-08-23 23:23 ` Rob Herring 2015-08-24 0:43 ` Krzysztof Kozlowski 2015-08-24 0:43 ` Krzysztof Kozlowski 2015-08-24 0:43 ` Krzysztof Kozlowski 2015-08-24 2:42 ` Yakir Yang 2015-08-24 2:42 ` Yakir Yang 2015-08-24 4:20 ` Krzysztof Kozlowski 2015-08-24 4:20 ` Krzysztof Kozlowski 2015-08-24 4:20 ` Krzysztof Kozlowski 2015-08-24 12:48 ` Yakir Yang 2015-08-24 12:48 ` Yakir Yang 2015-08-24 12:48 ` Yakir Yang 2015-08-24 13:03 ` Heiko Stuebner 2015-08-24 13:03 ` Heiko Stuebner 2015-08-24 13:03 ` Heiko Stuebner 2015-08-25 1:37 ` Yakir Yang 2015-08-25 1:37 ` Yakir Yang 2015-08-25 1:37 ` Yakir Yang 2015-08-24 23:49 ` Krzysztof Kozlowski 2015-08-24 23:49 ` Krzysztof Kozlowski 2015-08-24 23:49 ` Krzysztof Kozlowski [not found] ` <55DBAD90.3040901-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> 2015-08-25 1:32 ` Yakir Yang 2015-08-25 1:33 ` Yakir Yang 2015-08-25 1:33 ` Yakir Yang 2015-08-25 1:33 ` Yakir Yang 2015-08-25 1:35 ` Krzysztof Kozlowski 2015-08-25 1:35 ` Krzysztof Kozlowski 2015-08-25 1:35 ` Krzysztof Kozlowski 2015-08-24 7:40 ` Jingoo Han 2015-08-24 7:40 ` Jingoo Han 2015-08-24 7:40 ` Jingoo Han 2015-08-24 12:55 ` Yakir Yang 2015-08-24 12:55 ` Yakir Yang 2015-08-24 12:55 ` Yakir Yang 2015-08-24 2:19 ` Yakir Yang 2015-08-24 2:19 ` Yakir Yang 2015-08-24 12:57 ` Russell King - ARM Linux 2015-08-24 12:57 ` Russell King - ARM Linux 2015-08-24 12:57 ` Russell King - ARM Linux 2015-08-24 14:48 ` Rob Herring 2015-08-24 14:48 ` Rob Herring 2015-08-24 14:48 ` Rob Herring 2015-08-24 16:16 ` Heiko Stuebner 2015-08-24 16:16 ` Heiko Stuebner 2015-08-24 16:16 ` Heiko Stuebner 2015-08-25 1:21 ` Yakir Yang 2015-08-25 1:21 ` Yakir Yang 2015-08-25 1:21 ` Yakir Yang 2015-08-25 9:12 ` Thierry Reding 2015-08-25 9:12 ` Thierry Reding 2015-08-25 9:12 ` Thierry Reding 2015-08-25 9:29 ` Russell King - ARM Linux 2015-08-25 9:29 ` Russell King - ARM Linux 2015-08-25 9:29 ` Russell King - ARM Linux 2015-08-25 10:40 ` Thierry Reding 2015-08-25 10:40 ` Thierry Reding 2015-08-25 10:40 ` Thierry Reding 2015-08-25 10:52 ` Russell King - ARM Linux 2015-08-25 10:52 ` Russell King - ARM Linux 2015-08-25 10:52 ` Russell King - ARM Linux 2015-08-25 9:41 ` Yakir Yang 2015-08-25 9:41 ` Yakir Yang 2015-08-25 10:06 ` Thierry Reding 2015-08-25 10:06 ` Thierry Reding 2015-08-25 10:06 ` Thierry Reding 2015-08-25 14:02 ` Yakir Yang [this message] 2015-08-25 14:02 ` Yakir Yang 2015-08-25 9:15 ` Thierry Reding 2015-08-25 9:15 ` Thierry Reding 2015-08-25 9:15 ` Thierry Reding 2015-08-25 9:37 ` Yakir Yang 2015-08-25 9:37 ` Yakir Yang 2015-08-25 13:27 ` Rob Herring 2015-08-25 13:27 ` Rob Herring 2015-08-25 13:27 ` Rob Herring 2015-08-25 13:48 ` Yakir Yang 2015-08-25 14:16 ` Thierry Reding 2015-08-25 14:16 ` Thierry Reding 2015-08-25 14:16 ` Thierry Reding 2015-08-25 14:23 ` Yakir Yang 2015-08-25 14:23 ` Yakir Yang 2015-08-25 9:58 ` Thierry Reding 2015-08-25 9:58 ` Thierry Reding 2015-08-25 9:58 ` Thierry Reding 2015-08-25 14:03 ` Yakir Yang 2015-08-25 14:03 ` Yakir Yang 2015-08-25 14:21 ` Thierry Reding 2015-08-25 14:21 ` Thierry Reding 2015-08-25 14:21 ` Thierry Reding 2015-08-25 15:57 ` Russell King - ARM Linux 2015-08-25 15:57 ` Russell King - ARM Linux 2015-08-25 15:57 ` Russell King - ARM Linux 2015-08-19 14:50 ` [PATCH v3 07/14] drm: rockchip/dp: add rockchip platform dp driver Yakir Yang 2015-08-19 14:50 ` Yakir Yang 2015-08-19 14:50 ` Yakir Yang 2015-08-19 14:51 ` [PATCH v3 08/14] phy: Add driver for rockchip Display Port PHY Yakir Yang 2015-08-19 14:51 ` Yakir Yang 2015-08-20 4:40 ` Kishon Vijay Abraham I 2015-08-20 4:40 ` Kishon Vijay Abraham I 2015-08-20 4:40 ` Kishon Vijay Abraham I 2015-08-20 6:56 ` Yakir Yang 2015-08-20 7:01 ` Yakir Yang 2015-08-19 14:51 ` [PATCH v3 09/14] drm: bridge/analogix_dp: add platform device type support Yakir Yang 2015-08-19 14:51 ` Yakir Yang 2015-08-19 14:51 ` Yakir Yang 2015-08-19 14:51 ` [PATCH v3 10/14] drm: bridge: analogix_dp: add some rk3288 special registers setting Yakir Yang 2015-08-19 14:51 ` Yakir Yang 2015-08-19 14:51 ` [PATCH v3 11/14] drm: bridge: analogix_dp: try force hpd after plug in lookup failed Yakir Yang 2015-08-19 14:51 ` Yakir Yang 2015-08-19 14:52 ` [PATCH v3 12/14] drm: bridge/analogix_dp: expand the delay time for hpd detect Yakir Yang 2015-08-19 14:52 ` Yakir Yang 2015-08-19 14:52 ` Yakir Yang 2015-08-20 6:11 ` Jingoo Han 2015-08-20 6:11 ` Jingoo Han 2015-08-20 6:11 ` Jingoo Han 2015-08-20 8:02 ` Yakir Yang 2015-08-20 8:02 ` Yakir Yang 2015-08-20 8:02 ` Yakir Yang 2015-08-19 14:52 ` [PATCH v3 13/14] drm: bridge/analogix_dp: move hpd detect to connector detect function Yakir Yang 2015-08-19 14:52 ` Yakir Yang 2015-08-20 7:49 ` Jingoo Han 2015-08-20 7:49 ` Jingoo Han 2015-08-20 7:49 ` Jingoo Han 2015-08-20 8:18 ` Yakir Yang 2015-08-20 8:18 ` Yakir Yang 2015-08-20 8:18 ` Yakir Yang 2015-08-19 14:52 ` [PATCH v3 14/14] drm: bridge/analogix_dp: add edid modes parse in get_modes method Yakir Yang 2015-08-19 14:52 ` Yakir Yang 2015-08-19 23:54 ` [PATCH v3 0/14] Add Analogix Core Display Port Driver Dave Airlie 2015-08-19 23:54 ` Dave Airlie 2015-08-19 23:54 ` Dave Airlie 2015-08-20 1:02 ` Yakir Yang 2015-08-20 1:02 ` Yakir Yang 2015-08-20 1:02 ` Yakir Yang 2015-08-20 4:29 ` Archit Taneja 2015-08-20 4:29 ` Archit Taneja 2015-08-20 4:29 ` Archit Taneja 2015-08-20 5:54 ` Jingoo Han 2015-08-20 5:54 ` Jingoo Han 2015-08-20 5:54 ` Jingoo Han 2015-08-20 6:23 ` Yakir Yang 2015-08-20 6:23 ` Yakir Yang 2015-08-20 6:23 ` Yakir Yang 2015-08-20 6:55 ` Jingoo Han 2015-08-20 6:55 ` Jingoo Han 2015-08-20 6:55 ` Jingoo Han 2015-08-20 8:03 ` Yakir Yang 2015-08-20 8:03 ` Yakir Yang 2015-08-20 8:03 ` Yakir Yang 2015-08-21 8:20 ` Jingoo Han 2015-08-21 8:20 ` Jingoo Han 2015-08-21 8:20 ` Jingoo Han 2015-08-21 10:01 ` Yakir Yang 2015-08-21 11:24 ` Jingoo Han 2015-08-21 13:16 ` Thierry Reding 2015-08-21 13:16 ` Thierry Reding 2015-08-21 13:16 ` Thierry Reding 2015-08-22 10:13 ` Yakir Yang 2015-08-30 12:16 ` Romain Perier 2015-08-30 12:16 ` Romain Perier 2015-08-30 12:16 ` Romain Perier 2015-08-31 2:40 ` Yakir Yang 2015-08-31 2:40 ` Yakir Yang 2015-08-31 2:40 ` Yakir Yang 2015-08-22 9:42 ` Yakir Yang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=55DC7571.6000204@rock-chips.com \ --to=ykk@rock-chips.com \ --cc=a.hajda@samsung.com \ --cc=airlied@linux.ie \ --cc=ajaynumb@gmail.com \ --cc=andy.yan@rock-chips.com \ --cc=devicetree@vger.kernel.org \ --cc=dianders@google.com \ --cc=djkurtz@google.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=fabio.estevam@freescale.com \ --cc=galak@codeaurora.org \ --cc=gustavo.padovan@collabora.co.uk \ --cc=heiko@sntech.de \ --cc=ijc+devicetree@hellion.org.uk \ --cc=inki.dae@samsung.com \ --cc=jingoohan1@gmail.com \ --cc=joe@perches.com \ --cc=kishon@ti.com \ --cc=kyungmin.park@samsung.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-rockchip@lists.infradead.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=linux@arm.linux.org.uk \ --cc=mark.yao@rock-chips.com \ --cc=p.zabel@pengutronix.de \ --cc=pawel.moll@arm.com \ --cc=robh+dt@kernel.org \ --cc=robherring2@gmail.com \ --cc=seanpaul@google.com \ --cc=tiwai@suse.de \ --cc=treding@nvidia.com \ --cc=vpalatin@chromium.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.