* [U-Boot] [RFC PATCH] arm: cache_v7: fix dcache invalidation
@ 2015-08-28 13:12 Markus Niebel
2015-08-28 13:37 ` Hannes Schmelzer
0 siblings, 1 reply; 3+ messages in thread
From: Markus Niebel @ 2015-08-28 13:12 UTC (permalink / raw)
To: u-boot
From: Markus Niebel <Markus.Niebel@tq-group.com>
according to
http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.faqs/ka14802.html
and the clarification given by Marc Rutland of ARM
data cache invalidation should go from outer to inner cache.
This patch corrects the order in
flush_dcache_range
flush_dcache_all
Signed-off-by: Markus Niebel <Markus.Niebel@tq-group.com>
---
arch/arm/cpu/armv7/cache_v7.c | 8 ++++----
include/configs/tqma6.h | 3 ++-
2 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/arch/arm/cpu/armv7/cache_v7.c b/arch/arm/cpu/armv7/cache_v7.c
index a5aa4fa..81eb286 100644
--- a/arch/arm/cpu/armv7/cache_v7.c
+++ b/arch/arm/cpu/armv7/cache_v7.c
@@ -235,9 +235,9 @@ static void v7_inval_tlb(void)
void invalidate_dcache_all(void)
{
- v7_maint_dcache_all(ARMV7_DCACHE_INVAL_ALL);
-
v7_outer_cache_inval_all();
+
+ v7_maint_dcache_all(ARMV7_DCACHE_INVAL_ALL);
}
/*
@@ -257,9 +257,9 @@ void flush_dcache_all(void)
*/
void invalidate_dcache_range(unsigned long start, unsigned long stop)
{
- v7_dcache_maint_range(start, stop, ARMV7_DCACHE_INVAL_RANGE);
-
v7_outer_cache_inval_range(start, stop);
+
+ v7_dcache_maint_range(start, stop, ARMV7_DCACHE_INVAL_RANGE);
}
/*
diff --git a/include/configs/tqma6.h b/include/configs/tqma6.h
index f7fade1..0a0cbbe 100644
--- a/include/configs/tqma6.h
+++ b/include/configs/tqma6.h
@@ -111,10 +111,11 @@
#define CONFIG_ARP_TIMEOUT 200UL
/* Network config - Allow larger/faster download for TFTP/NFS */
+/*
#define CONFIG_IP_DEFRAG
#define CONFIG_TFTP_BLOCKSIZE 4096
#define CONFIG_NFS_READ_SIZE 4096
-
+*/
/* Command definition */
#define CONFIG_CMD_BMODE
--
2.3.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [U-Boot] [RFC PATCH] arm: cache_v7: fix dcache invalidation
2015-08-28 13:12 [U-Boot] [RFC PATCH] arm: cache_v7: fix dcache invalidation Markus Niebel
@ 2015-08-28 13:37 ` Hannes Schmelzer
2015-08-28 14:36 ` Markus Niebel
0 siblings, 1 reply; 3+ messages in thread
From: Hannes Schmelzer @ 2015-08-28 13:37 UTC (permalink / raw)
To: u-boot
Hi Markus,
On 2015-08-28 15:12, Markus Niebel wrote:
>
> /*
> diff --git a/include/configs/tqma6.h b/include/configs/tqma6.h
> index f7fade1..0a0cbbe 100644
> --- a/include/configs/tqma6.h
> +++ b/include/configs/tqma6.h
> @@ -111,10 +111,11 @@
>
> #define CONFIG_ARP_TIMEOUT 200UL
> /* Network config - Allow larger/faster download for TFTP/NFS */
> +/*
> #define CONFIG_IP_DEFRAG
> #define CONFIG_TFTP_BLOCKSIZE 4096
> #define CONFIG_NFS_READ_SIZE 4096
> -
> +*/
> /* Command definition */
> #define CONFIG_CMD_BMODE
Is this change some mistake ?
If not, please separate it from your first patch.
best regards,
Hannes
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] [RFC PATCH] arm: cache_v7: fix dcache invalidation
2015-08-28 13:37 ` Hannes Schmelzer
@ 2015-08-28 14:36 ` Markus Niebel
0 siblings, 0 replies; 3+ messages in thread
From: Markus Niebel @ 2015-08-28 14:36 UTC (permalink / raw)
To: u-boot
Am 28.08.2015 um 15:37 schrieb Hannes Schmelzer:
> Hi Markus,
>
> On 2015-08-28 15:12, Markus Niebel wrote:
>> /*
>> diff --git a/include/configs/tqma6.h b/include/configs/tqma6.h
>> index f7fade1..0a0cbbe 100644
>> --- a/include/configs/tqma6.h
>> +++ b/include/configs/tqma6.h
>> @@ -111,10 +111,11 @@
>> #define CONFIG_ARP_TIMEOUT 200UL
>> /* Network config - Allow larger/faster download for TFTP/NFS */
>> +/*
>> #define CONFIG_IP_DEFRAG
>> #define CONFIG_TFTP_BLOCKSIZE 4096
>> #define CONFIG_NFS_READ_SIZE 4096
>> -
>> +*/
>> /* Command definition */
>> #define CONFIG_CMD_BMODE
> Is this change some mistake ?
You are right. Should not be here - sorry.
> If not, please separate it from your first patch.
>
> best regards,
> Hannes
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-08-28 14:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-08-28 13:12 [U-Boot] [RFC PATCH] arm: cache_v7: fix dcache invalidation Markus Niebel
2015-08-28 13:37 ` Hannes Schmelzer
2015-08-28 14:36 ` Markus Niebel
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.