* [Buildroot] [PATCH] system: use a menuconfig for the getty options
@ 2015-09-01 23:10 Yann E. MORIN
2015-09-02 22:13 ` Arnout Vandecappelle
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Yann E. MORIN @ 2015-09-01 23:10 UTC (permalink / raw)
To: buildroot
Making the getty option a menuconfig instead of a simple config
automatically moves its dependees into a menu without the need to
manually declare such a menu.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
system/Config.in | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/system/Config.in b/system/Config.in
index fad829d..ea45cf3 100644
--- a/system/Config.in
+++ b/system/Config.in
@@ -260,12 +260,11 @@ config BR2_SYSTEM_BIN_SH
default "dash" if BR2_SYSTEM_BIN_SH_DASH
default "zsh" if BR2_SYSTEM_BIN_SH_ZSH
-config BR2_TARGET_GENERIC_GETTY
+menuconfig BR2_TARGET_GENERIC_GETTY
bool "Run a getty (login prompt) after boot"
default y
if BR2_TARGET_GENERIC_GETTY
-menu "getty options"
config BR2_TARGET_GENERIC_GETTY_PORT
string "TTY port"
default "console"
@@ -313,7 +312,6 @@ config BR2_TARGET_GENERIC_GETTY_OPTIONS
help
Any other flags you want to pass to getty,
Refer to getty --help for details.
-endmenu
endif
config BR2_TARGET_GENERIC_REMOUNT_ROOTFS_RW
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] system: use a menuconfig for the getty options
2015-09-01 23:10 [Buildroot] [PATCH] system: use a menuconfig for the getty options Yann E. MORIN
@ 2015-09-02 22:13 ` Arnout Vandecappelle
2015-09-03 14:54 ` Vicente Olivert Riera
2015-10-03 12:26 ` Peter Korsgaard
2 siblings, 0 replies; 4+ messages in thread
From: Arnout Vandecappelle @ 2015-09-02 22:13 UTC (permalink / raw)
To: buildroot
On 02-09-15 01:10, Yann E. MORIN wrote:
> Making the getty option a menuconfig instead of a simple config
> automatically moves its dependees into a menu without the need to
> manually declare such a menu.
>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
I don't quite like the new title of the menu, but I do think that this is
better than the original.
Regards,
Arnout
> ---
> system/Config.in | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/system/Config.in b/system/Config.in
> index fad829d..ea45cf3 100644
> --- a/system/Config.in
> +++ b/system/Config.in
> @@ -260,12 +260,11 @@ config BR2_SYSTEM_BIN_SH
> default "dash" if BR2_SYSTEM_BIN_SH_DASH
> default "zsh" if BR2_SYSTEM_BIN_SH_ZSH
>
> -config BR2_TARGET_GENERIC_GETTY
> +menuconfig BR2_TARGET_GENERIC_GETTY
> bool "Run a getty (login prompt) after boot"
> default y
>
> if BR2_TARGET_GENERIC_GETTY
> -menu "getty options"
> config BR2_TARGET_GENERIC_GETTY_PORT
> string "TTY port"
> default "console"
> @@ -313,7 +312,6 @@ config BR2_TARGET_GENERIC_GETTY_OPTIONS
> help
> Any other flags you want to pass to getty,
> Refer to getty --help for details.
> -endmenu
> endif
>
> config BR2_TARGET_GENERIC_REMOUNT_ROOTFS_RW
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] system: use a menuconfig for the getty options
2015-09-01 23:10 [Buildroot] [PATCH] system: use a menuconfig for the getty options Yann E. MORIN
2015-09-02 22:13 ` Arnout Vandecappelle
@ 2015-09-03 14:54 ` Vicente Olivert Riera
2015-10-03 12:26 ` Peter Korsgaard
2 siblings, 0 replies; 4+ messages in thread
From: Vicente Olivert Riera @ 2015-09-03 14:54 UTC (permalink / raw)
To: buildroot
Dear Yann E. MORIN,
On 09/02/2015 12:10 AM, Yann E. MORIN wrote:
> Making the getty option a menuconfig instead of a simple config
> automatically moves its dependees into a menu without the need to
> manually declare such a menu.
>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> ---
> system/Config.in | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/system/Config.in b/system/Config.in
> index fad829d..ea45cf3 100644
> --- a/system/Config.in
> +++ b/system/Config.in
> @@ -260,12 +260,11 @@ config BR2_SYSTEM_BIN_SH
> default "dash" if BR2_SYSTEM_BIN_SH_DASH
> default "zsh" if BR2_SYSTEM_BIN_SH_ZSH
>
> -config BR2_TARGET_GENERIC_GETTY
> +menuconfig BR2_TARGET_GENERIC_GETTY
> bool "Run a getty (login prompt) after boot"
> default y
>
> if BR2_TARGET_GENERIC_GETTY
> -menu "getty options"
> config BR2_TARGET_GENERIC_GETTY_PORT
> string "TTY port"
> default "console"
> @@ -313,7 +312,6 @@ config BR2_TARGET_GENERIC_GETTY_OPTIONS
> help
> Any other flags you want to pass to getty,
> Refer to getty --help for details.
> -endmenu
> endif
>
> config BR2_TARGET_GENERIC_REMOUNT_ROOTFS_RW
>
Reviewed-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
Tested-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
Regards,
Vincent.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] system: use a menuconfig for the getty options
2015-09-01 23:10 [Buildroot] [PATCH] system: use a menuconfig for the getty options Yann E. MORIN
2015-09-02 22:13 ` Arnout Vandecappelle
2015-09-03 14:54 ` Vicente Olivert Riera
@ 2015-10-03 12:26 ` Peter Korsgaard
2 siblings, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2015-10-03 12:26 UTC (permalink / raw)
To: buildroot
>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:
> Making the getty option a menuconfig instead of a simple config
> automatically moves its dependees into a menu without the need to
> manually declare such a menu.
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Committed, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-10-03 12:26 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-09-01 23:10 [Buildroot] [PATCH] system: use a menuconfig for the getty options Yann E. MORIN
2015-09-02 22:13 ` Arnout Vandecappelle
2015-09-03 14:54 ` Vicente Olivert Riera
2015-10-03 12:26 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.