* [PATCH linux-next v9 0/3] mfd: flexcom: add a driver for Flexcom
@ 2015-09-01 14:46 ` Cyrille Pitchen
0 siblings, 0 replies; 45+ messages in thread
From: Cyrille Pitchen @ 2015-09-01 14:46 UTC (permalink / raw)
To: linux-arm-kernel
ChangeLog
v9:
- go back to v5 (use the new "atmel,flexcom-mode" DT property).
- fix the name of the spi node in the DT example: from spi at f8034400 to
spi at 400
- align the fields of the struct platform_driver atmel_flexcom_driver as
suggested by Lee Jones.
v8:
- fix the name of the spi node in the DT example: from spi at f8034400 to
spi at 2,0
- use the return code of op_property_read_u32_index() instead of -EINVAL
to report error.
- add Acked-by from Nicolas Ferre
v7:
- read the operating mode from the very first u32 of the reg property from
the first available child node (should be unique).
- update the DT bindings documentation accordingly.
v6:
- select the operating mode according to the "compatible" DT property of
the first available child node (should be unique).
- remove the "atmel,flexcom-mode" DT property so the need of a header file
defining macros for the possible values of this deprecated property.
v5:
- create a header file containing macros used by DT bindings
- use numeric constants instead of strings to select the Flexcom mode
- change the license to "GPL v2"
- update the DT binding documentation to make it more readable and add
references to USART, SPI and I2C DT binding documentations. remove the
useless label in the Example section.
- change the register prefix from FX_ to FLEX_ to match the Flexcom
programmer datasheet.
- rename some variables to make them more understandable.
v4:
- check clk_prepare_enable() return code in atmel_flexcom_probe()
- add a commit message to the DT binding patch
v3:
- remove MODULE_ALIAS()
- add Acked-by from Boris Brezillon and Alexandre Belloni
v2:
- enhance the documentation of DT bindings and change the way the "ranges"
property is used.
- replace __raw_readl() and __raw_writel() by readl() and writel().
- change the module license to "GPL" for v2 or later
- print the selected flexcom mode after the hardware version
v1:
This series of patches a support to the Atmel Flexcom, a wrapper which
integrates an USART, a SPI controller and a TWI controller. Only one
peripheral can be used at a time. The active function is selected though
the Flexcom Mode Register.
Cyrille Pitchen (3):
mfd: atmel-flexcom: create include file with macros used by DT
bindings
mfd: devicetree: add bindings for Atmel Flexcom
mfd: atmel-flexcom: add a driver for Atmel Flexible Serial
Communication Unit
.../devicetree/bindings/mfd/atmel-flexcom.txt | 67 +++++++++++++
drivers/mfd/Kconfig | 11 +++
drivers/mfd/Makefile | 1 +
drivers/mfd/atmel-flexcom.c | 104 +++++++++++++++++++++
include/dt-bindings/mfd/atmel-flexcom.h | 16 ++++
5 files changed, 199 insertions(+)
create mode 100644 Documentation/devicetree/bindings/mfd/atmel-flexcom.txt
create mode 100644 drivers/mfd/atmel-flexcom.c
create mode 100644 include/dt-bindings/mfd/atmel-flexcom.h
--
1.8.2.2
^ permalink raw reply [flat|nested] 45+ messages in thread* [PATCH linux-next v9 0/3] mfd: flexcom: add a driver for Flexcom
@ 2015-09-01 14:46 ` Cyrille Pitchen
0 siblings, 0 replies; 45+ messages in thread
From: Cyrille Pitchen @ 2015-09-01 14:46 UTC (permalink / raw)
To: nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w,
boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8,
alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8,
sameo-VuQAYsv1563Yd54FQh9/CA, lee.jones-QSEj5FYQhm4dnm+yROfE0A
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A, pawel.moll-5wv7dgnIgG8,
mark.rutland-5wv7dgnIgG8, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg,
galak-sgV2jX0FEOL9JmXXK+q4OQ, devicetree-u79uwXL29TY76Z2rM5mHXA,
Cyrille Pitchen
ChangeLog
v9:
- go back to v5 (use the new "atmel,flexcom-mode" DT property).
- fix the name of the spi node in the DT example: from spi@f8034400 to
spi@400
- align the fields of the struct platform_driver atmel_flexcom_driver as
suggested by Lee Jones.
v8:
- fix the name of the spi node in the DT example: from spi@f8034400 to
spi@2,0
- use the return code of op_property_read_u32_index() instead of -EINVAL
to report error.
- add Acked-by from Nicolas Ferre
v7:
- read the operating mode from the very first u32 of the reg property from
the first available child node (should be unique).
- update the DT bindings documentation accordingly.
v6:
- select the operating mode according to the "compatible" DT property of
the first available child node (should be unique).
- remove the "atmel,flexcom-mode" DT property so the need of a header file
defining macros for the possible values of this deprecated property.
v5:
- create a header file containing macros used by DT bindings
- use numeric constants instead of strings to select the Flexcom mode
- change the license to "GPL v2"
- update the DT binding documentation to make it more readable and add
references to USART, SPI and I2C DT binding documentations. remove the
useless label in the Example section.
- change the register prefix from FX_ to FLEX_ to match the Flexcom
programmer datasheet.
- rename some variables to make them more understandable.
v4:
- check clk_prepare_enable() return code in atmel_flexcom_probe()
- add a commit message to the DT binding patch
v3:
- remove MODULE_ALIAS()
- add Acked-by from Boris Brezillon and Alexandre Belloni
v2:
- enhance the documentation of DT bindings and change the way the "ranges"
property is used.
- replace __raw_readl() and __raw_writel() by readl() and writel().
- change the module license to "GPL" for v2 or later
- print the selected flexcom mode after the hardware version
v1:
This series of patches a support to the Atmel Flexcom, a wrapper which
integrates an USART, a SPI controller and a TWI controller. Only one
peripheral can be used at a time. The active function is selected though
the Flexcom Mode Register.
Cyrille Pitchen (3):
mfd: atmel-flexcom: create include file with macros used by DT
bindings
mfd: devicetree: add bindings for Atmel Flexcom
mfd: atmel-flexcom: add a driver for Atmel Flexible Serial
Communication Unit
.../devicetree/bindings/mfd/atmel-flexcom.txt | 67 +++++++++++++
drivers/mfd/Kconfig | 11 +++
drivers/mfd/Makefile | 1 +
drivers/mfd/atmel-flexcom.c | 104 +++++++++++++++++++++
include/dt-bindings/mfd/atmel-flexcom.h | 16 ++++
5 files changed, 199 insertions(+)
create mode 100644 Documentation/devicetree/bindings/mfd/atmel-flexcom.txt
create mode 100644 drivers/mfd/atmel-flexcom.c
create mode 100644 include/dt-bindings/mfd/atmel-flexcom.h
--
1.8.2.2
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 45+ messages in thread* [PATCH linux-next v9 1/3] mfd: atmel-flexcom: create include file with macros used by DT bindings
@ 2015-09-01 14:46 ` Cyrille Pitchen
0 siblings, 0 replies; 45+ messages in thread
From: Cyrille Pitchen @ 2015-09-01 14:46 UTC (permalink / raw)
To: nicolas.ferre, boris.brezillon, alexandre.belloni, sameo, lee.jones
Cc: linux-arm-kernel, linux-kernel, robh+dt, pawel.moll,
mark.rutland, ijc+devicetree, galak, devicetree, Cyrille Pitchen
This patch defines some macros to be used as value for the
"atmel,flexcom-mode" DT property. This value is then written into
the Operating Mode (OPMODE) bit field of the Flexcom Mode Register.
Signed-off-by: Cyrille Pitchen <cyrille.pitchen@atmel.com>
---
include/dt-bindings/mfd/atmel-flexcom.h | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
create mode 100644 include/dt-bindings/mfd/atmel-flexcom.h
diff --git a/include/dt-bindings/mfd/atmel-flexcom.h b/include/dt-bindings/mfd/atmel-flexcom.h
new file mode 100644
index 000000000000..6728f2851b4d
--- /dev/null
+++ b/include/dt-bindings/mfd/atmel-flexcom.h
@@ -0,0 +1,16 @@
+/*
+ * This header provides macros for Atmel Flexcom DT bindings.
+ *
+ * Copyright (C) 2015 Cyrille Pitchen <cyrille.pitchen@atmel.com>
+ *
+ * GPLv2 only
+ */
+
+#ifndef __DT_BINDINGS_ATMEL_FLEXCOM_H__
+#define __DT_BINDINGS_ATMEL_FLEXCOM_H__
+
+#define ATMEL_FLEXCOM_MODE_USART 1
+#define ATMEL_FLEXCOM_MODE_SPI 2
+#define ATMEL_FLEXCOM_MODE_TWI 3
+
+#endif /* __DT_BINDINGS_ATMEL_FLEXCOM_H__ */
--
1.8.2.2
^ permalink raw reply related [flat|nested] 45+ messages in thread
* [PATCH linux-next v9 1/3] mfd: atmel-flexcom: create include file with macros used by DT bindings
@ 2015-09-01 14:46 ` Cyrille Pitchen
0 siblings, 0 replies; 45+ messages in thread
From: Cyrille Pitchen @ 2015-09-01 14:46 UTC (permalink / raw)
To: linux-arm-kernel
This patch defines some macros to be used as value for the
"atmel,flexcom-mode" DT property. This value is then written into
the Operating Mode (OPMODE) bit field of the Flexcom Mode Register.
Signed-off-by: Cyrille Pitchen <cyrille.pitchen@atmel.com>
---
include/dt-bindings/mfd/atmel-flexcom.h | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
create mode 100644 include/dt-bindings/mfd/atmel-flexcom.h
diff --git a/include/dt-bindings/mfd/atmel-flexcom.h b/include/dt-bindings/mfd/atmel-flexcom.h
new file mode 100644
index 000000000000..6728f2851b4d
--- /dev/null
+++ b/include/dt-bindings/mfd/atmel-flexcom.h
@@ -0,0 +1,16 @@
+/*
+ * This header provides macros for Atmel Flexcom DT bindings.
+ *
+ * Copyright (C) 2015 Cyrille Pitchen <cyrille.pitchen@atmel.com>
+ *
+ * GPLv2 only
+ */
+
+#ifndef __DT_BINDINGS_ATMEL_FLEXCOM_H__
+#define __DT_BINDINGS_ATMEL_FLEXCOM_H__
+
+#define ATMEL_FLEXCOM_MODE_USART 1
+#define ATMEL_FLEXCOM_MODE_SPI 2
+#define ATMEL_FLEXCOM_MODE_TWI 3
+
+#endif /* __DT_BINDINGS_ATMEL_FLEXCOM_H__ */
--
1.8.2.2
^ permalink raw reply related [flat|nested] 45+ messages in thread
* [PATCH linux-next v9 1/3] mfd: atmel-flexcom: create include file with macros used by DT bindings
@ 2015-09-01 14:46 ` Cyrille Pitchen
0 siblings, 0 replies; 45+ messages in thread
From: Cyrille Pitchen @ 2015-09-01 14:46 UTC (permalink / raw)
To: nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w,
boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8,
alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8,
sameo-VuQAYsv1563Yd54FQh9/CA, lee.jones-QSEj5FYQhm4dnm+yROfE0A
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A, pawel.moll-5wv7dgnIgG8,
mark.rutland-5wv7dgnIgG8, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg,
galak-sgV2jX0FEOL9JmXXK+q4OQ, devicetree-u79uwXL29TY76Z2rM5mHXA,
Cyrille Pitchen
This patch defines some macros to be used as value for the
"atmel,flexcom-mode" DT property. This value is then written into
the Operating Mode (OPMODE) bit field of the Flexcom Mode Register.
Signed-off-by: Cyrille Pitchen <cyrille.pitchen-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
---
include/dt-bindings/mfd/atmel-flexcom.h | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
create mode 100644 include/dt-bindings/mfd/atmel-flexcom.h
diff --git a/include/dt-bindings/mfd/atmel-flexcom.h b/include/dt-bindings/mfd/atmel-flexcom.h
new file mode 100644
index 000000000000..6728f2851b4d
--- /dev/null
+++ b/include/dt-bindings/mfd/atmel-flexcom.h
@@ -0,0 +1,16 @@
+/*
+ * This header provides macros for Atmel Flexcom DT bindings.
+ *
+ * Copyright (C) 2015 Cyrille Pitchen <cyrille.pitchen-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
+ *
+ * GPLv2 only
+ */
+
+#ifndef __DT_BINDINGS_ATMEL_FLEXCOM_H__
+#define __DT_BINDINGS_ATMEL_FLEXCOM_H__
+
+#define ATMEL_FLEXCOM_MODE_USART 1
+#define ATMEL_FLEXCOM_MODE_SPI 2
+#define ATMEL_FLEXCOM_MODE_TWI 3
+
+#endif /* __DT_BINDINGS_ATMEL_FLEXCOM_H__ */
--
1.8.2.2
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 45+ messages in thread
* Re: [PATCH linux-next v9 1/3] mfd: atmel-flexcom: create include file with macros used by DT bindings
@ 2015-09-03 15:42 ` Nicolas Ferre
0 siblings, 0 replies; 45+ messages in thread
From: Nicolas Ferre @ 2015-09-03 15:42 UTC (permalink / raw)
To: Cyrille Pitchen, boris.brezillon, alexandre.belloni, sameo, lee.jones
Cc: linux-arm-kernel, linux-kernel, robh+dt, pawel.moll,
mark.rutland, ijc+devicetree, galak, devicetree
Le 01/09/2015 16:46, Cyrille Pitchen a écrit :
> This patch defines some macros to be used as value for the
> "atmel,flexcom-mode" DT property. This value is then written into
> the Operating Mode (OPMODE) bit field of the Flexcom Mode Register.
>
> Signed-off-by: Cyrille Pitchen <cyrille.pitchen@atmel.com>
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> ---
> include/dt-bindings/mfd/atmel-flexcom.h | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
> create mode 100644 include/dt-bindings/mfd/atmel-flexcom.h
>
> diff --git a/include/dt-bindings/mfd/atmel-flexcom.h b/include/dt-bindings/mfd/atmel-flexcom.h
> new file mode 100644
> index 000000000000..6728f2851b4d
> --- /dev/null
> +++ b/include/dt-bindings/mfd/atmel-flexcom.h
> @@ -0,0 +1,16 @@
> +/*
> + * This header provides macros for Atmel Flexcom DT bindings.
> + *
> + * Copyright (C) 2015 Cyrille Pitchen <cyrille.pitchen@atmel.com>
> + *
> + * GPLv2 only
> + */
> +
> +#ifndef __DT_BINDINGS_ATMEL_FLEXCOM_H__
> +#define __DT_BINDINGS_ATMEL_FLEXCOM_H__
> +
> +#define ATMEL_FLEXCOM_MODE_USART 1
> +#define ATMEL_FLEXCOM_MODE_SPI 2
> +#define ATMEL_FLEXCOM_MODE_TWI 3
> +
> +#endif /* __DT_BINDINGS_ATMEL_FLEXCOM_H__ */
>
--
Nicolas Ferre
^ permalink raw reply [flat|nested] 45+ messages in thread
* [PATCH linux-next v9 1/3] mfd: atmel-flexcom: create include file with macros used by DT bindings
@ 2015-09-03 15:42 ` Nicolas Ferre
0 siblings, 0 replies; 45+ messages in thread
From: Nicolas Ferre @ 2015-09-03 15:42 UTC (permalink / raw)
To: linux-arm-kernel
Le 01/09/2015 16:46, Cyrille Pitchen a ?crit :
> This patch defines some macros to be used as value for the
> "atmel,flexcom-mode" DT property. This value is then written into
> the Operating Mode (OPMODE) bit field of the Flexcom Mode Register.
>
> Signed-off-by: Cyrille Pitchen <cyrille.pitchen@atmel.com>
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> ---
> include/dt-bindings/mfd/atmel-flexcom.h | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
> create mode 100644 include/dt-bindings/mfd/atmel-flexcom.h
>
> diff --git a/include/dt-bindings/mfd/atmel-flexcom.h b/include/dt-bindings/mfd/atmel-flexcom.h
> new file mode 100644
> index 000000000000..6728f2851b4d
> --- /dev/null
> +++ b/include/dt-bindings/mfd/atmel-flexcom.h
> @@ -0,0 +1,16 @@
> +/*
> + * This header provides macros for Atmel Flexcom DT bindings.
> + *
> + * Copyright (C) 2015 Cyrille Pitchen <cyrille.pitchen@atmel.com>
> + *
> + * GPLv2 only
> + */
> +
> +#ifndef __DT_BINDINGS_ATMEL_FLEXCOM_H__
> +#define __DT_BINDINGS_ATMEL_FLEXCOM_H__
> +
> +#define ATMEL_FLEXCOM_MODE_USART 1
> +#define ATMEL_FLEXCOM_MODE_SPI 2
> +#define ATMEL_FLEXCOM_MODE_TWI 3
> +
> +#endif /* __DT_BINDINGS_ATMEL_FLEXCOM_H__ */
>
--
Nicolas Ferre
^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH linux-next v9 1/3] mfd: atmel-flexcom: create include file with macros used by DT bindings
@ 2015-09-03 15:42 ` Nicolas Ferre
0 siblings, 0 replies; 45+ messages in thread
From: Nicolas Ferre @ 2015-09-03 15:42 UTC (permalink / raw)
To: Cyrille Pitchen,
boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8,
alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8,
sameo-VuQAYsv1563Yd54FQh9/CA, lee.jones-QSEj5FYQhm4dnm+yROfE0A
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A, pawel.moll-5wv7dgnIgG8,
mark.rutland-5wv7dgnIgG8, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg,
galak-sgV2jX0FEOL9JmXXK+q4OQ, devicetree-u79uwXL29TY76Z2rM5mHXA
Le 01/09/2015 16:46, Cyrille Pitchen a écrit :
> This patch defines some macros to be used as value for the
> "atmel,flexcom-mode" DT property. This value is then written into
> the Operating Mode (OPMODE) bit field of the Flexcom Mode Register.
>
> Signed-off-by: Cyrille Pitchen <cyrille.pitchen-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
Acked-by: Nicolas Ferre <nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
> ---
> include/dt-bindings/mfd/atmel-flexcom.h | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
> create mode 100644 include/dt-bindings/mfd/atmel-flexcom.h
>
> diff --git a/include/dt-bindings/mfd/atmel-flexcom.h b/include/dt-bindings/mfd/atmel-flexcom.h
> new file mode 100644
> index 000000000000..6728f2851b4d
> --- /dev/null
> +++ b/include/dt-bindings/mfd/atmel-flexcom.h
> @@ -0,0 +1,16 @@
> +/*
> + * This header provides macros for Atmel Flexcom DT bindings.
> + *
> + * Copyright (C) 2015 Cyrille Pitchen <cyrille.pitchen-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
> + *
> + * GPLv2 only
> + */
> +
> +#ifndef __DT_BINDINGS_ATMEL_FLEXCOM_H__
> +#define __DT_BINDINGS_ATMEL_FLEXCOM_H__
> +
> +#define ATMEL_FLEXCOM_MODE_USART 1
> +#define ATMEL_FLEXCOM_MODE_SPI 2
> +#define ATMEL_FLEXCOM_MODE_TWI 3
> +
> +#endif /* __DT_BINDINGS_ATMEL_FLEXCOM_H__ */
>
--
Nicolas Ferre
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH linux-next v9 1/3] mfd: atmel-flexcom: create include file with macros used by DT bindings
@ 2015-09-08 23:33 ` Rob Herring
0 siblings, 0 replies; 45+ messages in thread
From: Rob Herring @ 2015-09-08 23:33 UTC (permalink / raw)
To: Cyrille Pitchen, nicolas.ferre, boris.brezillon,
alexandre.belloni, sameo, lee.jones
Cc: linux-arm-kernel, linux-kernel, robh+dt, pawel.moll,
mark.rutland, ijc+devicetree, galak, devicetree
On 09/01/2015 09:46 AM, Cyrille Pitchen wrote:
> This patch defines some macros to be used as value for the
> "atmel,flexcom-mode" DT property. This value is then written into
> the Operating Mode (OPMODE) bit field of the Flexcom Mode Register.
>
> Signed-off-by: Cyrille Pitchen <cyrille.pitchen@atmel.com>
Acked-by: Rob Herring <robh@kernel.org>
In the future, you can combine headers with the binding doc as they are
part of the binding.
Rob
> ---
> include/dt-bindings/mfd/atmel-flexcom.h | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
> create mode 100644 include/dt-bindings/mfd/atmel-flexcom.h
>
> diff --git a/include/dt-bindings/mfd/atmel-flexcom.h b/include/dt-bindings/mfd/atmel-flexcom.h
> new file mode 100644
> index 000000000000..6728f2851b4d
> --- /dev/null
> +++ b/include/dt-bindings/mfd/atmel-flexcom.h
> @@ -0,0 +1,16 @@
> +/*
> + * This header provides macros for Atmel Flexcom DT bindings.
> + *
> + * Copyright (C) 2015 Cyrille Pitchen <cyrille.pitchen@atmel.com>
> + *
> + * GPLv2 only
> + */
> +
> +#ifndef __DT_BINDINGS_ATMEL_FLEXCOM_H__
> +#define __DT_BINDINGS_ATMEL_FLEXCOM_H__
> +
> +#define ATMEL_FLEXCOM_MODE_USART 1
> +#define ATMEL_FLEXCOM_MODE_SPI 2
> +#define ATMEL_FLEXCOM_MODE_TWI 3
> +
> +#endif /* __DT_BINDINGS_ATMEL_FLEXCOM_H__ */
>
^ permalink raw reply [flat|nested] 45+ messages in thread
* [PATCH linux-next v9 1/3] mfd: atmel-flexcom: create include file with macros used by DT bindings
@ 2015-09-08 23:33 ` Rob Herring
0 siblings, 0 replies; 45+ messages in thread
From: Rob Herring @ 2015-09-08 23:33 UTC (permalink / raw)
To: linux-arm-kernel
On 09/01/2015 09:46 AM, Cyrille Pitchen wrote:
> This patch defines some macros to be used as value for the
> "atmel,flexcom-mode" DT property. This value is then written into
> the Operating Mode (OPMODE) bit field of the Flexcom Mode Register.
>
> Signed-off-by: Cyrille Pitchen <cyrille.pitchen@atmel.com>
Acked-by: Rob Herring <robh@kernel.org>
In the future, you can combine headers with the binding doc as they are
part of the binding.
Rob
> ---
> include/dt-bindings/mfd/atmel-flexcom.h | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
> create mode 100644 include/dt-bindings/mfd/atmel-flexcom.h
>
> diff --git a/include/dt-bindings/mfd/atmel-flexcom.h b/include/dt-bindings/mfd/atmel-flexcom.h
> new file mode 100644
> index 000000000000..6728f2851b4d
> --- /dev/null
> +++ b/include/dt-bindings/mfd/atmel-flexcom.h
> @@ -0,0 +1,16 @@
> +/*
> + * This header provides macros for Atmel Flexcom DT bindings.
> + *
> + * Copyright (C) 2015 Cyrille Pitchen <cyrille.pitchen@atmel.com>
> + *
> + * GPLv2 only
> + */
> +
> +#ifndef __DT_BINDINGS_ATMEL_FLEXCOM_H__
> +#define __DT_BINDINGS_ATMEL_FLEXCOM_H__
> +
> +#define ATMEL_FLEXCOM_MODE_USART 1
> +#define ATMEL_FLEXCOM_MODE_SPI 2
> +#define ATMEL_FLEXCOM_MODE_TWI 3
> +
> +#endif /* __DT_BINDINGS_ATMEL_FLEXCOM_H__ */
>
^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH linux-next v9 1/3] mfd: atmel-flexcom: create include file with macros used by DT bindings
@ 2015-09-08 23:33 ` Rob Herring
0 siblings, 0 replies; 45+ messages in thread
From: Rob Herring @ 2015-09-08 23:33 UTC (permalink / raw)
To: Cyrille Pitchen, nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w,
boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8,
alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8,
sameo-VuQAYsv1563Yd54FQh9/CA, lee.jones-QSEj5FYQhm4dnm+yROfE0A
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A, pawel.moll-5wv7dgnIgG8,
mark.rutland-5wv7dgnIgG8, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg,
galak-sgV2jX0FEOL9JmXXK+q4OQ, devicetree-u79uwXL29TY76Z2rM5mHXA
On 09/01/2015 09:46 AM, Cyrille Pitchen wrote:
> This patch defines some macros to be used as value for the
> "atmel,flexcom-mode" DT property. This value is then written into
> the Operating Mode (OPMODE) bit field of the Flexcom Mode Register.
>
> Signed-off-by: Cyrille Pitchen <cyrille.pitchen-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
Acked-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
In the future, you can combine headers with the binding doc as they are
part of the binding.
Rob
> ---
> include/dt-bindings/mfd/atmel-flexcom.h | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
> create mode 100644 include/dt-bindings/mfd/atmel-flexcom.h
>
> diff --git a/include/dt-bindings/mfd/atmel-flexcom.h b/include/dt-bindings/mfd/atmel-flexcom.h
> new file mode 100644
> index 000000000000..6728f2851b4d
> --- /dev/null
> +++ b/include/dt-bindings/mfd/atmel-flexcom.h
> @@ -0,0 +1,16 @@
> +/*
> + * This header provides macros for Atmel Flexcom DT bindings.
> + *
> + * Copyright (C) 2015 Cyrille Pitchen <cyrille.pitchen-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
> + *
> + * GPLv2 only
> + */
> +
> +#ifndef __DT_BINDINGS_ATMEL_FLEXCOM_H__
> +#define __DT_BINDINGS_ATMEL_FLEXCOM_H__
> +
> +#define ATMEL_FLEXCOM_MODE_USART 1
> +#define ATMEL_FLEXCOM_MODE_SPI 2
> +#define ATMEL_FLEXCOM_MODE_TWI 3
> +
> +#endif /* __DT_BINDINGS_ATMEL_FLEXCOM_H__ */
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 45+ messages in thread
* [PATCH linux-next v9 2/3] mfd: devicetree: add bindings for Atmel Flexcom
@ 2015-09-01 14:46 ` Cyrille Pitchen
0 siblings, 0 replies; 45+ messages in thread
From: Cyrille Pitchen @ 2015-09-01 14:46 UTC (permalink / raw)
To: nicolas.ferre, boris.brezillon, alexandre.belloni, sameo, lee.jones
Cc: linux-arm-kernel, linux-kernel, robh+dt, pawel.moll,
mark.rutland, ijc+devicetree, galak, devicetree, Cyrille Pitchen
This patch documents the DT bindings for the Atmel Flexcom which will be
introduced by sama5d2x SoCs. These bindings will be used by the actual
Flexcom driver to be sent in another patch.
Signed-off-by: Cyrille Pitchen <cyrille.pitchen@atmel.com>
Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>
Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
---
.../devicetree/bindings/mfd/atmel-flexcom.txt | 67 ++++++++++++++++++++++
1 file changed, 67 insertions(+)
create mode 100644 Documentation/devicetree/bindings/mfd/atmel-flexcom.txt
diff --git a/Documentation/devicetree/bindings/mfd/atmel-flexcom.txt b/Documentation/devicetree/bindings/mfd/atmel-flexcom.txt
new file mode 100644
index 000000000000..fc3511e41542
--- /dev/null
+++ b/Documentation/devicetree/bindings/mfd/atmel-flexcom.txt
@@ -0,0 +1,67 @@
+* Device tree bindings for Atmel Flexcom (Flexible Serial Communication Unit)
+
+The Atmel Flexcom is just a wrapper which embeds a SPI controller, an I2C
+controller and an USART. Only one function can be used at a time and is chosen
+at boot time according to the device tree.
+
+Required properties:
+- compatible: Should be "atmel,sama5d2-flexcom"
+- reg: Should be the offset/length value for Flexcom dedicated
+ I/O registers (without USART, TWI or SPI registers).
+- clocks: Should be the Flexcom peripheral clock from PMC.
+- #address-cells: Should be <1>
+- #size-cells: Should be <1>
+- ranges: Should be one range for the full I/O register region
+ (including USART, TWI and SPI registers).
+- atmel,flexcom-mode: Should be one of the 3 following macros as defined in
+ include/dt-bindings/mfd/atmel-flexcom.h:
+ - ATMEL_FLEXCOM_MODE_USART for USART
+ - ATMEL_FLEXCOM_MODE_SPI for SPI
+ - ATMEL_FLEXCOM_MODE_TWI for I2C
+
+Required child:
+a single child device of type matching the "atmel,flexcom-mode" property.
+
+The reg property of this child should be:
+- <0x200 0x200> for USART
+- <0x400 0x200> for SPI
+- <0x600 0x200> for I2C
+
+The phandle provided by the clocks property of the child is the same as one for
+the Flexcom parent.
+
+Other properties remain unchanged. See documentation of the respective device:
+- ../serial/atmel-usart.txt
+- ../spi/spi_atmel.txt
+- ../i2c/i2c-at91.txt
+
+Example:
+
+flexcom@f8034000 {
+ compatible = "atmel,sama5d2-flexcom";
+ reg = <0xf8034000 0x200>;
+ clocks = <&flx0_clk>;
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges = <0x0 0xf8034000 0x800>;
+ atmel,flexcom-mode = <ATMEL_FLEXCOM_MODE_SPI>;
+
+ spi@400 {
+ compatible = "atmel,at91rm9200-spi";
+ reg = <0x400 0x200>;
+ interrupts = <19 IRQ_TYPE_LEVEL_HIGH 7>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_flx0_default>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ clocks = <&flx0_clk>;
+ clock-names = "spi_clk";
+ atmel,fifo-size = <32>;
+
+ mtd_dataflash@0 {
+ compatible = "atmel,at25f512b";
+ reg = <0>;
+ spi-max-frequency = <20000000>;
+ };
+ };
+};
--
1.8.2.2
^ permalink raw reply related [flat|nested] 45+ messages in thread* [PATCH linux-next v9 2/3] mfd: devicetree: add bindings for Atmel Flexcom
@ 2015-09-01 14:46 ` Cyrille Pitchen
0 siblings, 0 replies; 45+ messages in thread
From: Cyrille Pitchen @ 2015-09-01 14:46 UTC (permalink / raw)
To: linux-arm-kernel
This patch documents the DT bindings for the Atmel Flexcom which will be
introduced by sama5d2x SoCs. These bindings will be used by the actual
Flexcom driver to be sent in another patch.
Signed-off-by: Cyrille Pitchen <cyrille.pitchen@atmel.com>
Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>
Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
---
.../devicetree/bindings/mfd/atmel-flexcom.txt | 67 ++++++++++++++++++++++
1 file changed, 67 insertions(+)
create mode 100644 Documentation/devicetree/bindings/mfd/atmel-flexcom.txt
diff --git a/Documentation/devicetree/bindings/mfd/atmel-flexcom.txt b/Documentation/devicetree/bindings/mfd/atmel-flexcom.txt
new file mode 100644
index 000000000000..fc3511e41542
--- /dev/null
+++ b/Documentation/devicetree/bindings/mfd/atmel-flexcom.txt
@@ -0,0 +1,67 @@
+* Device tree bindings for Atmel Flexcom (Flexible Serial Communication Unit)
+
+The Atmel Flexcom is just a wrapper which embeds a SPI controller, an I2C
+controller and an USART. Only one function can be used at a time and is chosen
+at boot time according to the device tree.
+
+Required properties:
+- compatible: Should be "atmel,sama5d2-flexcom"
+- reg: Should be the offset/length value for Flexcom dedicated
+ I/O registers (without USART, TWI or SPI registers).
+- clocks: Should be the Flexcom peripheral clock from PMC.
+- #address-cells: Should be <1>
+- #size-cells: Should be <1>
+- ranges: Should be one range for the full I/O register region
+ (including USART, TWI and SPI registers).
+- atmel,flexcom-mode: Should be one of the 3 following macros as defined in
+ include/dt-bindings/mfd/atmel-flexcom.h:
+ - ATMEL_FLEXCOM_MODE_USART for USART
+ - ATMEL_FLEXCOM_MODE_SPI for SPI
+ - ATMEL_FLEXCOM_MODE_TWI for I2C
+
+Required child:
+a single child device of type matching the "atmel,flexcom-mode" property.
+
+The reg property of this child should be:
+- <0x200 0x200> for USART
+- <0x400 0x200> for SPI
+- <0x600 0x200> for I2C
+
+The phandle provided by the clocks property of the child is the same as one for
+the Flexcom parent.
+
+Other properties remain unchanged. See documentation of the respective device:
+- ../serial/atmel-usart.txt
+- ../spi/spi_atmel.txt
+- ../i2c/i2c-at91.txt
+
+Example:
+
+flexcom at f8034000 {
+ compatible = "atmel,sama5d2-flexcom";
+ reg = <0xf8034000 0x200>;
+ clocks = <&flx0_clk>;
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges = <0x0 0xf8034000 0x800>;
+ atmel,flexcom-mode = <ATMEL_FLEXCOM_MODE_SPI>;
+
+ spi at 400 {
+ compatible = "atmel,at91rm9200-spi";
+ reg = <0x400 0x200>;
+ interrupts = <19 IRQ_TYPE_LEVEL_HIGH 7>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_flx0_default>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ clocks = <&flx0_clk>;
+ clock-names = "spi_clk";
+ atmel,fifo-size = <32>;
+
+ mtd_dataflash at 0 {
+ compatible = "atmel,at25f512b";
+ reg = <0>;
+ spi-max-frequency = <20000000>;
+ };
+ };
+};
--
1.8.2.2
^ permalink raw reply related [flat|nested] 45+ messages in thread* [PATCH linux-next v9 2/3] mfd: devicetree: add bindings for Atmel Flexcom
@ 2015-09-01 14:46 ` Cyrille Pitchen
0 siblings, 0 replies; 45+ messages in thread
From: Cyrille Pitchen @ 2015-09-01 14:46 UTC (permalink / raw)
To: nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w,
boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8,
alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8,
sameo-VuQAYsv1563Yd54FQh9/CA, lee.jones-QSEj5FYQhm4dnm+yROfE0A
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A, pawel.moll-5wv7dgnIgG8,
mark.rutland-5wv7dgnIgG8, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg,
galak-sgV2jX0FEOL9JmXXK+q4OQ, devicetree-u79uwXL29TY76Z2rM5mHXA,
Cyrille Pitchen
This patch documents the DT bindings for the Atmel Flexcom which will be
introduced by sama5d2x SoCs. These bindings will be used by the actual
Flexcom driver to be sent in another patch.
Signed-off-by: Cyrille Pitchen <cyrille.pitchen-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
Acked-by: Boris Brezillon <boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
Acked-by: Alexandre Belloni <alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
---
.../devicetree/bindings/mfd/atmel-flexcom.txt | 67 ++++++++++++++++++++++
1 file changed, 67 insertions(+)
create mode 100644 Documentation/devicetree/bindings/mfd/atmel-flexcom.txt
diff --git a/Documentation/devicetree/bindings/mfd/atmel-flexcom.txt b/Documentation/devicetree/bindings/mfd/atmel-flexcom.txt
new file mode 100644
index 000000000000..fc3511e41542
--- /dev/null
+++ b/Documentation/devicetree/bindings/mfd/atmel-flexcom.txt
@@ -0,0 +1,67 @@
+* Device tree bindings for Atmel Flexcom (Flexible Serial Communication Unit)
+
+The Atmel Flexcom is just a wrapper which embeds a SPI controller, an I2C
+controller and an USART. Only one function can be used at a time and is chosen
+at boot time according to the device tree.
+
+Required properties:
+- compatible: Should be "atmel,sama5d2-flexcom"
+- reg: Should be the offset/length value for Flexcom dedicated
+ I/O registers (without USART, TWI or SPI registers).
+- clocks: Should be the Flexcom peripheral clock from PMC.
+- #address-cells: Should be <1>
+- #size-cells: Should be <1>
+- ranges: Should be one range for the full I/O register region
+ (including USART, TWI and SPI registers).
+- atmel,flexcom-mode: Should be one of the 3 following macros as defined in
+ include/dt-bindings/mfd/atmel-flexcom.h:
+ - ATMEL_FLEXCOM_MODE_USART for USART
+ - ATMEL_FLEXCOM_MODE_SPI for SPI
+ - ATMEL_FLEXCOM_MODE_TWI for I2C
+
+Required child:
+a single child device of type matching the "atmel,flexcom-mode" property.
+
+The reg property of this child should be:
+- <0x200 0x200> for USART
+- <0x400 0x200> for SPI
+- <0x600 0x200> for I2C
+
+The phandle provided by the clocks property of the child is the same as one for
+the Flexcom parent.
+
+Other properties remain unchanged. See documentation of the respective device:
+- ../serial/atmel-usart.txt
+- ../spi/spi_atmel.txt
+- ../i2c/i2c-at91.txt
+
+Example:
+
+flexcom@f8034000 {
+ compatible = "atmel,sama5d2-flexcom";
+ reg = <0xf8034000 0x200>;
+ clocks = <&flx0_clk>;
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges = <0x0 0xf8034000 0x800>;
+ atmel,flexcom-mode = <ATMEL_FLEXCOM_MODE_SPI>;
+
+ spi@400 {
+ compatible = "atmel,at91rm9200-spi";
+ reg = <0x400 0x200>;
+ interrupts = <19 IRQ_TYPE_LEVEL_HIGH 7>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_flx0_default>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ clocks = <&flx0_clk>;
+ clock-names = "spi_clk";
+ atmel,fifo-size = <32>;
+
+ mtd_dataflash@0 {
+ compatible = "atmel,at25f512b";
+ reg = <0>;
+ spi-max-frequency = <20000000>;
+ };
+ };
+};
--
1.8.2.2
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 45+ messages in thread* Re: [PATCH linux-next v9 2/3] mfd: devicetree: add bindings for Atmel Flexcom
@ 2015-09-03 15:56 ` Nicolas Ferre
0 siblings, 0 replies; 45+ messages in thread
From: Nicolas Ferre @ 2015-09-03 15:56 UTC (permalink / raw)
To: Cyrille Pitchen, boris.brezillon, alexandre.belloni, sameo, lee.jones
Cc: linux-arm-kernel, linux-kernel, robh+dt, pawel.moll,
mark.rutland, ijc+devicetree, galak, devicetree
Le 01/09/2015 16:46, Cyrille Pitchen a écrit :
> This patch documents the DT bindings for the Atmel Flexcom which will be
> introduced by sama5d2x SoCs. These bindings will be used by the actual
> Flexcom driver to be sent in another patch.
>
> Signed-off-by: Cyrille Pitchen <cyrille.pitchen@atmel.com>
> Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
After all, this approach is far more simple and obvious than the use of
the "reg" property, so coming back to this "atmel,flexcom-mode" option
make a lot of sense.
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Bye,
> ---
> .../devicetree/bindings/mfd/atmel-flexcom.txt | 67 ++++++++++++++++++++++
> 1 file changed, 67 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mfd/atmel-flexcom.txt
>
> diff --git a/Documentation/devicetree/bindings/mfd/atmel-flexcom.txt b/Documentation/devicetree/bindings/mfd/atmel-flexcom.txt
> new file mode 100644
> index 000000000000..fc3511e41542
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/atmel-flexcom.txt
> @@ -0,0 +1,67 @@
> +* Device tree bindings for Atmel Flexcom (Flexible Serial Communication Unit)
> +
> +The Atmel Flexcom is just a wrapper which embeds a SPI controller, an I2C
> +controller and an USART. Only one function can be used at a time and is chosen
> +at boot time according to the device tree.
> +
> +Required properties:
> +- compatible: Should be "atmel,sama5d2-flexcom"
> +- reg: Should be the offset/length value for Flexcom dedicated
> + I/O registers (without USART, TWI or SPI registers).
> +- clocks: Should be the Flexcom peripheral clock from PMC.
> +- #address-cells: Should be <1>
> +- #size-cells: Should be <1>
> +- ranges: Should be one range for the full I/O register region
> + (including USART, TWI and SPI registers).
> +- atmel,flexcom-mode: Should be one of the 3 following macros as defined in
> + include/dt-bindings/mfd/atmel-flexcom.h:
> + - ATMEL_FLEXCOM_MODE_USART for USART
> + - ATMEL_FLEXCOM_MODE_SPI for SPI
> + - ATMEL_FLEXCOM_MODE_TWI for I2C
> +
> +Required child:
> +a single child device of type matching the "atmel,flexcom-mode" property.
> +
> +The reg property of this child should be:
> +- <0x200 0x200> for USART
> +- <0x400 0x200> for SPI
> +- <0x600 0x200> for I2C
> +
> +The phandle provided by the clocks property of the child is the same as one for
> +the Flexcom parent.
> +
> +Other properties remain unchanged. See documentation of the respective device:
> +- ../serial/atmel-usart.txt
> +- ../spi/spi_atmel.txt
> +- ../i2c/i2c-at91.txt
> +
> +Example:
> +
> +flexcom@f8034000 {
> + compatible = "atmel,sama5d2-flexcom";
> + reg = <0xf8034000 0x200>;
> + clocks = <&flx0_clk>;
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges = <0x0 0xf8034000 0x800>;
> + atmel,flexcom-mode = <ATMEL_FLEXCOM_MODE_SPI>;
> +
> + spi@400 {
> + compatible = "atmel,at91rm9200-spi";
> + reg = <0x400 0x200>;
> + interrupts = <19 IRQ_TYPE_LEVEL_HIGH 7>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_flx0_default>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + clocks = <&flx0_clk>;
> + clock-names = "spi_clk";
> + atmel,fifo-size = <32>;
> +
> + mtd_dataflash@0 {
> + compatible = "atmel,at25f512b";
> + reg = <0>;
> + spi-max-frequency = <20000000>;
> + };
> + };
> +};
>
--
Nicolas Ferre
^ permalink raw reply [flat|nested] 45+ messages in thread* [PATCH linux-next v9 2/3] mfd: devicetree: add bindings for Atmel Flexcom
@ 2015-09-03 15:56 ` Nicolas Ferre
0 siblings, 0 replies; 45+ messages in thread
From: Nicolas Ferre @ 2015-09-03 15:56 UTC (permalink / raw)
To: linux-arm-kernel
Le 01/09/2015 16:46, Cyrille Pitchen a ?crit :
> This patch documents the DT bindings for the Atmel Flexcom which will be
> introduced by sama5d2x SoCs. These bindings will be used by the actual
> Flexcom driver to be sent in another patch.
>
> Signed-off-by: Cyrille Pitchen <cyrille.pitchen@atmel.com>
> Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
After all, this approach is far more simple and obvious than the use of
the "reg" property, so coming back to this "atmel,flexcom-mode" option
make a lot of sense.
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Bye,
> ---
> .../devicetree/bindings/mfd/atmel-flexcom.txt | 67 ++++++++++++++++++++++
> 1 file changed, 67 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mfd/atmel-flexcom.txt
>
> diff --git a/Documentation/devicetree/bindings/mfd/atmel-flexcom.txt b/Documentation/devicetree/bindings/mfd/atmel-flexcom.txt
> new file mode 100644
> index 000000000000..fc3511e41542
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/atmel-flexcom.txt
> @@ -0,0 +1,67 @@
> +* Device tree bindings for Atmel Flexcom (Flexible Serial Communication Unit)
> +
> +The Atmel Flexcom is just a wrapper which embeds a SPI controller, an I2C
> +controller and an USART. Only one function can be used at a time and is chosen
> +at boot time according to the device tree.
> +
> +Required properties:
> +- compatible: Should be "atmel,sama5d2-flexcom"
> +- reg: Should be the offset/length value for Flexcom dedicated
> + I/O registers (without USART, TWI or SPI registers).
> +- clocks: Should be the Flexcom peripheral clock from PMC.
> +- #address-cells: Should be <1>
> +- #size-cells: Should be <1>
> +- ranges: Should be one range for the full I/O register region
> + (including USART, TWI and SPI registers).
> +- atmel,flexcom-mode: Should be one of the 3 following macros as defined in
> + include/dt-bindings/mfd/atmel-flexcom.h:
> + - ATMEL_FLEXCOM_MODE_USART for USART
> + - ATMEL_FLEXCOM_MODE_SPI for SPI
> + - ATMEL_FLEXCOM_MODE_TWI for I2C
> +
> +Required child:
> +a single child device of type matching the "atmel,flexcom-mode" property.
> +
> +The reg property of this child should be:
> +- <0x200 0x200> for USART
> +- <0x400 0x200> for SPI
> +- <0x600 0x200> for I2C
> +
> +The phandle provided by the clocks property of the child is the same as one for
> +the Flexcom parent.
> +
> +Other properties remain unchanged. See documentation of the respective device:
> +- ../serial/atmel-usart.txt
> +- ../spi/spi_atmel.txt
> +- ../i2c/i2c-at91.txt
> +
> +Example:
> +
> +flexcom at f8034000 {
> + compatible = "atmel,sama5d2-flexcom";
> + reg = <0xf8034000 0x200>;
> + clocks = <&flx0_clk>;
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges = <0x0 0xf8034000 0x800>;
> + atmel,flexcom-mode = <ATMEL_FLEXCOM_MODE_SPI>;
> +
> + spi at 400 {
> + compatible = "atmel,at91rm9200-spi";
> + reg = <0x400 0x200>;
> + interrupts = <19 IRQ_TYPE_LEVEL_HIGH 7>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_flx0_default>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + clocks = <&flx0_clk>;
> + clock-names = "spi_clk";
> + atmel,fifo-size = <32>;
> +
> + mtd_dataflash at 0 {
> + compatible = "atmel,at25f512b";
> + reg = <0>;
> + spi-max-frequency = <20000000>;
> + };
> + };
> +};
>
--
Nicolas Ferre
^ permalink raw reply [flat|nested] 45+ messages in thread* Re: [PATCH linux-next v9 2/3] mfd: devicetree: add bindings for Atmel Flexcom
@ 2015-09-03 15:56 ` Nicolas Ferre
0 siblings, 0 replies; 45+ messages in thread
From: Nicolas Ferre @ 2015-09-03 15:56 UTC (permalink / raw)
To: Cyrille Pitchen,
boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8,
alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8,
sameo-VuQAYsv1563Yd54FQh9/CA, lee.jones-QSEj5FYQhm4dnm+yROfE0A
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A, pawel.moll-5wv7dgnIgG8,
mark.rutland-5wv7dgnIgG8, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg,
galak-sgV2jX0FEOL9JmXXK+q4OQ, devicetree-u79uwXL29TY76Z2rM5mHXA
Le 01/09/2015 16:46, Cyrille Pitchen a écrit :
> This patch documents the DT bindings for the Atmel Flexcom which will be
> introduced by sama5d2x SoCs. These bindings will be used by the actual
> Flexcom driver to be sent in another patch.
>
> Signed-off-by: Cyrille Pitchen <cyrille.pitchen-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
> Acked-by: Boris Brezillon <boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
> Acked-by: Alexandre Belloni <alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
After all, this approach is far more simple and obvious than the use of
the "reg" property, so coming back to this "atmel,flexcom-mode" option
make a lot of sense.
Acked-by: Nicolas Ferre <nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
Bye,
> ---
> .../devicetree/bindings/mfd/atmel-flexcom.txt | 67 ++++++++++++++++++++++
> 1 file changed, 67 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mfd/atmel-flexcom.txt
>
> diff --git a/Documentation/devicetree/bindings/mfd/atmel-flexcom.txt b/Documentation/devicetree/bindings/mfd/atmel-flexcom.txt
> new file mode 100644
> index 000000000000..fc3511e41542
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/atmel-flexcom.txt
> @@ -0,0 +1,67 @@
> +* Device tree bindings for Atmel Flexcom (Flexible Serial Communication Unit)
> +
> +The Atmel Flexcom is just a wrapper which embeds a SPI controller, an I2C
> +controller and an USART. Only one function can be used at a time and is chosen
> +at boot time according to the device tree.
> +
> +Required properties:
> +- compatible: Should be "atmel,sama5d2-flexcom"
> +- reg: Should be the offset/length value for Flexcom dedicated
> + I/O registers (without USART, TWI or SPI registers).
> +- clocks: Should be the Flexcom peripheral clock from PMC.
> +- #address-cells: Should be <1>
> +- #size-cells: Should be <1>
> +- ranges: Should be one range for the full I/O register region
> + (including USART, TWI and SPI registers).
> +- atmel,flexcom-mode: Should be one of the 3 following macros as defined in
> + include/dt-bindings/mfd/atmel-flexcom.h:
> + - ATMEL_FLEXCOM_MODE_USART for USART
> + - ATMEL_FLEXCOM_MODE_SPI for SPI
> + - ATMEL_FLEXCOM_MODE_TWI for I2C
> +
> +Required child:
> +a single child device of type matching the "atmel,flexcom-mode" property.
> +
> +The reg property of this child should be:
> +- <0x200 0x200> for USART
> +- <0x400 0x200> for SPI
> +- <0x600 0x200> for I2C
> +
> +The phandle provided by the clocks property of the child is the same as one for
> +the Flexcom parent.
> +
> +Other properties remain unchanged. See documentation of the respective device:
> +- ../serial/atmel-usart.txt
> +- ../spi/spi_atmel.txt
> +- ../i2c/i2c-at91.txt
> +
> +Example:
> +
> +flexcom@f8034000 {
> + compatible = "atmel,sama5d2-flexcom";
> + reg = <0xf8034000 0x200>;
> + clocks = <&flx0_clk>;
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges = <0x0 0xf8034000 0x800>;
> + atmel,flexcom-mode = <ATMEL_FLEXCOM_MODE_SPI>;
> +
> + spi@400 {
> + compatible = "atmel,at91rm9200-spi";
> + reg = <0x400 0x200>;
> + interrupts = <19 IRQ_TYPE_LEVEL_HIGH 7>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_flx0_default>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + clocks = <&flx0_clk>;
> + clock-names = "spi_clk";
> + atmel,fifo-size = <32>;
> +
> + mtd_dataflash@0 {
> + compatible = "atmel,at25f512b";
> + reg = <0>;
> + spi-max-frequency = <20000000>;
> + };
> + };
> +};
>
--
Nicolas Ferre
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH linux-next v9 2/3] mfd: devicetree: add bindings for Atmel Flexcom
2015-09-01 14:46 ` Cyrille Pitchen
(?)
@ 2015-09-08 23:40 ` Rob Herring
-1 siblings, 0 replies; 45+ messages in thread
From: Rob Herring @ 2015-09-08 23:40 UTC (permalink / raw)
To: Cyrille Pitchen, nicolas.ferre, boris.brezillon,
alexandre.belloni, sameo, lee.jones
Cc: linux-arm-kernel, linux-kernel, robh+dt, pawel.moll,
mark.rutland, ijc+devicetree, galak, devicetree
On 09/01/2015 09:46 AM, Cyrille Pitchen wrote:
> This patch documents the DT bindings for the Atmel Flexcom which will be
> introduced by sama5d2x SoCs. These bindings will be used by the actual
> Flexcom driver to be sent in another patch.
>
> Signed-off-by: Cyrille Pitchen <cyrille.pitchen@atmel.com>
> Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
A few comments, but in general looks fine.
> ---
> .../devicetree/bindings/mfd/atmel-flexcom.txt | 67 ++++++++++++++++++++++
> 1 file changed, 67 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mfd/atmel-flexcom.txt
>
> diff --git a/Documentation/devicetree/bindings/mfd/atmel-flexcom.txt b/Documentation/devicetree/bindings/mfd/atmel-flexcom.txt
> new file mode 100644
> index 000000000000..fc3511e41542
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/atmel-flexcom.txt
> @@ -0,0 +1,67 @@
> +* Device tree bindings for Atmel Flexcom (Flexible Serial Communication Unit)
> +
> +The Atmel Flexcom is just a wrapper which embeds a SPI controller, an I2C
> +controller and an USART. Only one function can be used at a time and is chosen
> +at boot time according to the device tree.
Doesn't the board design choose (unless pins go to a header)?
> +
> +Required properties:
> +- compatible: Should be "atmel,sama5d2-flexcom"
> +- reg: Should be the offset/length value for Flexcom dedicated
> + I/O registers (without USART, TWI or SPI registers).
> +- clocks: Should be the Flexcom peripheral clock from PMC.
> +- #address-cells: Should be <1>
> +- #size-cells: Should be <1>
> +- ranges: Should be one range for the full I/O register region
> + (including USART, TWI and SPI registers).
> +- atmel,flexcom-mode: Should be one of the 3 following macros as defined in
> + include/dt-bindings/mfd/atmel-flexcom.h:
> + - ATMEL_FLEXCOM_MODE_USART for USART
> + - ATMEL_FLEXCOM_MODE_SPI for SPI
> + - ATMEL_FLEXCOM_MODE_TWI for I2C
> +
> +Required child:
> +a single child device of type matching the "atmel,flexcom-mode" property.
Okay, but why not allow all children and use "status"?
> +
> +The reg property of this child should be:
> +- <0x200 0x200> for USART
> +- <0x400 0x200> for SPI
> +- <0x600 0x200> for I2C
> +
> +The phandle provided by the clocks property of the child is the same as one for
> +the Flexcom parent.
> +
> +Other properties remain unchanged. See documentation of the respective device:
> +- ../serial/atmel-usart.txt
> +- ../spi/spi_atmel.txt
> +- ../i2c/i2c-at91.txt
> +
> +Example:
> +
> +flexcom@f8034000 {
> + compatible = "atmel,sama5d2-flexcom";
> + reg = <0xf8034000 0x200>;
> + clocks = <&flx0_clk>;
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges = <0x0 0xf8034000 0x800>;
> + atmel,flexcom-mode = <ATMEL_FLEXCOM_MODE_SPI>;
> +
> + spi@400 {
> + compatible = "atmel,at91rm9200-spi";
> + reg = <0x400 0x200>;
> + interrupts = <19 IRQ_TYPE_LEVEL_HIGH 7>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_flx0_default>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + clocks = <&flx0_clk>;
> + clock-names = "spi_clk";
> + atmel,fifo-size = <32>;
> +
> + mtd_dataflash@0 {
> + compatible = "atmel,at25f512b";
> + reg = <0>;
> + spi-max-frequency = <20000000>;
> + };
> + };
> +};
>
^ permalink raw reply [flat|nested] 45+ messages in thread* [PATCH linux-next v9 2/3] mfd: devicetree: add bindings for Atmel Flexcom
@ 2015-09-08 23:40 ` Rob Herring
0 siblings, 0 replies; 45+ messages in thread
From: Rob Herring @ 2015-09-08 23:40 UTC (permalink / raw)
To: linux-arm-kernel
On 09/01/2015 09:46 AM, Cyrille Pitchen wrote:
> This patch documents the DT bindings for the Atmel Flexcom which will be
> introduced by sama5d2x SoCs. These bindings will be used by the actual
> Flexcom driver to be sent in another patch.
>
> Signed-off-by: Cyrille Pitchen <cyrille.pitchen@atmel.com>
> Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
A few comments, but in general looks fine.
> ---
> .../devicetree/bindings/mfd/atmel-flexcom.txt | 67 ++++++++++++++++++++++
> 1 file changed, 67 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mfd/atmel-flexcom.txt
>
> diff --git a/Documentation/devicetree/bindings/mfd/atmel-flexcom.txt b/Documentation/devicetree/bindings/mfd/atmel-flexcom.txt
> new file mode 100644
> index 000000000000..fc3511e41542
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/atmel-flexcom.txt
> @@ -0,0 +1,67 @@
> +* Device tree bindings for Atmel Flexcom (Flexible Serial Communication Unit)
> +
> +The Atmel Flexcom is just a wrapper which embeds a SPI controller, an I2C
> +controller and an USART. Only one function can be used at a time and is chosen
> +at boot time according to the device tree.
Doesn't the board design choose (unless pins go to a header)?
> +
> +Required properties:
> +- compatible: Should be "atmel,sama5d2-flexcom"
> +- reg: Should be the offset/length value for Flexcom dedicated
> + I/O registers (without USART, TWI or SPI registers).
> +- clocks: Should be the Flexcom peripheral clock from PMC.
> +- #address-cells: Should be <1>
> +- #size-cells: Should be <1>
> +- ranges: Should be one range for the full I/O register region
> + (including USART, TWI and SPI registers).
> +- atmel,flexcom-mode: Should be one of the 3 following macros as defined in
> + include/dt-bindings/mfd/atmel-flexcom.h:
> + - ATMEL_FLEXCOM_MODE_USART for USART
> + - ATMEL_FLEXCOM_MODE_SPI for SPI
> + - ATMEL_FLEXCOM_MODE_TWI for I2C
> +
> +Required child:
> +a single child device of type matching the "atmel,flexcom-mode" property.
Okay, but why not allow all children and use "status"?
> +
> +The reg property of this child should be:
> +- <0x200 0x200> for USART
> +- <0x400 0x200> for SPI
> +- <0x600 0x200> for I2C
> +
> +The phandle provided by the clocks property of the child is the same as one for
> +the Flexcom parent.
> +
> +Other properties remain unchanged. See documentation of the respective device:
> +- ../serial/atmel-usart.txt
> +- ../spi/spi_atmel.txt
> +- ../i2c/i2c-at91.txt
> +
> +Example:
> +
> +flexcom at f8034000 {
> + compatible = "atmel,sama5d2-flexcom";
> + reg = <0xf8034000 0x200>;
> + clocks = <&flx0_clk>;
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges = <0x0 0xf8034000 0x800>;
> + atmel,flexcom-mode = <ATMEL_FLEXCOM_MODE_SPI>;
> +
> + spi at 400 {
> + compatible = "atmel,at91rm9200-spi";
> + reg = <0x400 0x200>;
> + interrupts = <19 IRQ_TYPE_LEVEL_HIGH 7>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_flx0_default>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + clocks = <&flx0_clk>;
> + clock-names = "spi_clk";
> + atmel,fifo-size = <32>;
> +
> + mtd_dataflash at 0 {
> + compatible = "atmel,at25f512b";
> + reg = <0>;
> + spi-max-frequency = <20000000>;
> + };
> + };
> +};
>
^ permalink raw reply [flat|nested] 45+ messages in thread* Re: [PATCH linux-next v9 2/3] mfd: devicetree: add bindings for Atmel Flexcom
@ 2015-09-08 23:40 ` Rob Herring
0 siblings, 0 replies; 45+ messages in thread
From: Rob Herring @ 2015-09-08 23:40 UTC (permalink / raw)
To: Cyrille Pitchen, nicolas.ferre, boris.brezillon,
alexandre.belloni, sameo, lee.jones
Cc: mark.rutland, devicetree, pawel.moll, ijc+devicetree,
linux-kernel, robh+dt, galak, linux-arm-kernel
On 09/01/2015 09:46 AM, Cyrille Pitchen wrote:
> This patch documents the DT bindings for the Atmel Flexcom which will be
> introduced by sama5d2x SoCs. These bindings will be used by the actual
> Flexcom driver to be sent in another patch.
>
> Signed-off-by: Cyrille Pitchen <cyrille.pitchen@atmel.com>
> Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
A few comments, but in general looks fine.
> ---
> .../devicetree/bindings/mfd/atmel-flexcom.txt | 67 ++++++++++++++++++++++
> 1 file changed, 67 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mfd/atmel-flexcom.txt
>
> diff --git a/Documentation/devicetree/bindings/mfd/atmel-flexcom.txt b/Documentation/devicetree/bindings/mfd/atmel-flexcom.txt
> new file mode 100644
> index 000000000000..fc3511e41542
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/atmel-flexcom.txt
> @@ -0,0 +1,67 @@
> +* Device tree bindings for Atmel Flexcom (Flexible Serial Communication Unit)
> +
> +The Atmel Flexcom is just a wrapper which embeds a SPI controller, an I2C
> +controller and an USART. Only one function can be used at a time and is chosen
> +at boot time according to the device tree.
Doesn't the board design choose (unless pins go to a header)?
> +
> +Required properties:
> +- compatible: Should be "atmel,sama5d2-flexcom"
> +- reg: Should be the offset/length value for Flexcom dedicated
> + I/O registers (without USART, TWI or SPI registers).
> +- clocks: Should be the Flexcom peripheral clock from PMC.
> +- #address-cells: Should be <1>
> +- #size-cells: Should be <1>
> +- ranges: Should be one range for the full I/O register region
> + (including USART, TWI and SPI registers).
> +- atmel,flexcom-mode: Should be one of the 3 following macros as defined in
> + include/dt-bindings/mfd/atmel-flexcom.h:
> + - ATMEL_FLEXCOM_MODE_USART for USART
> + - ATMEL_FLEXCOM_MODE_SPI for SPI
> + - ATMEL_FLEXCOM_MODE_TWI for I2C
> +
> +Required child:
> +a single child device of type matching the "atmel,flexcom-mode" property.
Okay, but why not allow all children and use "status"?
> +
> +The reg property of this child should be:
> +- <0x200 0x200> for USART
> +- <0x400 0x200> for SPI
> +- <0x600 0x200> for I2C
> +
> +The phandle provided by the clocks property of the child is the same as one for
> +the Flexcom parent.
> +
> +Other properties remain unchanged. See documentation of the respective device:
> +- ../serial/atmel-usart.txt
> +- ../spi/spi_atmel.txt
> +- ../i2c/i2c-at91.txt
> +
> +Example:
> +
> +flexcom@f8034000 {
> + compatible = "atmel,sama5d2-flexcom";
> + reg = <0xf8034000 0x200>;
> + clocks = <&flx0_clk>;
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges = <0x0 0xf8034000 0x800>;
> + atmel,flexcom-mode = <ATMEL_FLEXCOM_MODE_SPI>;
> +
> + spi@400 {
> + compatible = "atmel,at91rm9200-spi";
> + reg = <0x400 0x200>;
> + interrupts = <19 IRQ_TYPE_LEVEL_HIGH 7>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_flx0_default>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + clocks = <&flx0_clk>;
> + clock-names = "spi_clk";
> + atmel,fifo-size = <32>;
> +
> + mtd_dataflash@0 {
> + compatible = "atmel,at25f512b";
> + reg = <0>;
> + spi-max-frequency = <20000000>;
> + };
> + };
> +};
>
^ permalink raw reply [flat|nested] 45+ messages in thread* Re: [PATCH linux-next v9 2/3] mfd: devicetree: add bindings for Atmel Flexcom
2015-09-08 23:40 ` Rob Herring
(?)
@ 2015-09-09 15:45 ` Cyrille Pitchen
-1 siblings, 0 replies; 45+ messages in thread
From: Cyrille Pitchen @ 2015-09-09 15:45 UTC (permalink / raw)
To: Rob Herring, nicolas.ferre, boris.brezillon, alexandre.belloni,
sameo, lee.jones
Cc: linux-arm-kernel, linux-kernel, robh+dt, pawel.moll,
mark.rutland, ijc+devicetree, galak, devicetree
Hi Rob,
Le 09/09/2015 01:40, Rob Herring a écrit :
> On 09/01/2015 09:46 AM, Cyrille Pitchen wrote:
>> This patch documents the DT bindings for the Atmel Flexcom which will be
>> introduced by sama5d2x SoCs. These bindings will be used by the actual
>> Flexcom driver to be sent in another patch.
>>
>> Signed-off-by: Cyrille Pitchen <cyrille.pitchen@atmel.com>
>> Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>
>> Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
>
> A few comments, but in general looks fine.
>
>> ---
>> .../devicetree/bindings/mfd/atmel-flexcom.txt | 67 ++++++++++++++++++++++
>> 1 file changed, 67 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/mfd/atmel-flexcom.txt
>>
>> diff --git a/Documentation/devicetree/bindings/mfd/atmel-flexcom.txt b/Documentation/devicetree/bindings/mfd/atmel-flexcom.txt
>> new file mode 100644
>> index 000000000000..fc3511e41542
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/mfd/atmel-flexcom.txt
>> @@ -0,0 +1,67 @@
>> +* Device tree bindings for Atmel Flexcom (Flexible Serial Communication Unit)
>> +
>> +The Atmel Flexcom is just a wrapper which embeds a SPI controller, an I2C
>> +controller and an USART. Only one function can be used at a time and is chosen
>> +at boot time according to the device tree.
>
> Doesn't the board design choose (unless pins go to a header)?
>
The function may be chosen once for all by the board design but if we take the
sama5d2 xplained board as an example, most Flexcoms output their pins to
headers.
>> +
>> +Required properties:
>> +- compatible: Should be "atmel,sama5d2-flexcom"
>> +- reg: Should be the offset/length value for Flexcom dedicated
>> + I/O registers (without USART, TWI or SPI registers).
>> +- clocks: Should be the Flexcom peripheral clock from PMC.
>> +- #address-cells: Should be <1>
>> +- #size-cells: Should be <1>
>> +- ranges: Should be one range for the full I/O register region
>> + (including USART, TWI and SPI registers).
>> +- atmel,flexcom-mode: Should be one of the 3 following macros as defined in
>> + include/dt-bindings/mfd/atmel-flexcom.h:
>> + - ATMEL_FLEXCOM_MODE_USART for USART
>> + - ATMEL_FLEXCOM_MODE_SPI for SPI
>> + - ATMEL_FLEXCOM_MODE_TWI for I2C
>> +
>> +Required child:
>> +a single child device of type matching the "atmel,flexcom-mode" property.
>
> Okay, but why not allow all children and use "status"?
>
That is exactly what was proposed in v6 of this series: allow more than one
child so possibly all children but only one "available" child (status =
"okay").
The Flexocm driver still needs to find out the type of device of this
available child to know which function is to be enabled (USART, I2C or SPI).
So the "compatible" attribute was parsed using strstr() to search on of the
patterns "usart", "spi" or "i2c".
However the use of strstr() was discussed to know whether the driver should
looks for a partial or an exact match of the "compatible" string.
An exact match would require to keep the Flexcom driver synchonized with the
3 other drivers every time one of them introduces a new compatibility string,
which whould have made every driver more difficult to maintain by creating a
useless dependency.
So this implementation relying on the "compatible" attribute was abandoned.
To sum up, no other reliable (and simple) means to guess/extact the device
type from its DT node was found so we got back to the "atmel,flexcom-mode"
property.
>> +
>> +The reg property of this child should be:
>> +- <0x200 0x200> for USART
>> +- <0x400 0x200> for SPI
>> +- <0x600 0x200> for I2C
>> +
>> +The phandle provided by the clocks property of the child is the same as one for
>> +the Flexcom parent.
>> +
>> +Other properties remain unchanged. See documentation of the respective device:
>> +- ../serial/atmel-usart.txt
>> +- ../spi/spi_atmel.txt
>> +- ../i2c/i2c-at91.txt
>> +
>> +Example:
>> +
>> +flexcom@f8034000 {
>> + compatible = "atmel,sama5d2-flexcom";
>> + reg = <0xf8034000 0x200>;
>> + clocks = <&flx0_clk>;
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> + ranges = <0x0 0xf8034000 0x800>;
>> + atmel,flexcom-mode = <ATMEL_FLEXCOM_MODE_SPI>;
>> +
>> + spi@400 {
>> + compatible = "atmel,at91rm9200-spi";
>> + reg = <0x400 0x200>;
>> + interrupts = <19 IRQ_TYPE_LEVEL_HIGH 7>;
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&pinctrl_flx0_default>;
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + clocks = <&flx0_clk>;
>> + clock-names = "spi_clk";
>> + atmel,fifo-size = <32>;
>> +
>> + mtd_dataflash@0 {
>> + compatible = "atmel,at25f512b";
>> + reg = <0>;
>> + spi-max-frequency = <20000000>;
>> + };
>> + };
>> +};
>>
>
Best Regards,
Cyrille
^ permalink raw reply [flat|nested] 45+ messages in thread* [PATCH linux-next v9 2/3] mfd: devicetree: add bindings for Atmel Flexcom
@ 2015-09-09 15:45 ` Cyrille Pitchen
0 siblings, 0 replies; 45+ messages in thread
From: Cyrille Pitchen @ 2015-09-09 15:45 UTC (permalink / raw)
To: linux-arm-kernel
Hi Rob,
Le 09/09/2015 01:40, Rob Herring a ?crit :
> On 09/01/2015 09:46 AM, Cyrille Pitchen wrote:
>> This patch documents the DT bindings for the Atmel Flexcom which will be
>> introduced by sama5d2x SoCs. These bindings will be used by the actual
>> Flexcom driver to be sent in another patch.
>>
>> Signed-off-by: Cyrille Pitchen <cyrille.pitchen@atmel.com>
>> Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>
>> Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
>
> A few comments, but in general looks fine.
>
>> ---
>> .../devicetree/bindings/mfd/atmel-flexcom.txt | 67 ++++++++++++++++++++++
>> 1 file changed, 67 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/mfd/atmel-flexcom.txt
>>
>> diff --git a/Documentation/devicetree/bindings/mfd/atmel-flexcom.txt b/Documentation/devicetree/bindings/mfd/atmel-flexcom.txt
>> new file mode 100644
>> index 000000000000..fc3511e41542
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/mfd/atmel-flexcom.txt
>> @@ -0,0 +1,67 @@
>> +* Device tree bindings for Atmel Flexcom (Flexible Serial Communication Unit)
>> +
>> +The Atmel Flexcom is just a wrapper which embeds a SPI controller, an I2C
>> +controller and an USART. Only one function can be used at a time and is chosen
>> +at boot time according to the device tree.
>
> Doesn't the board design choose (unless pins go to a header)?
>
The function may be chosen once for all by the board design but if we take the
sama5d2 xplained board as an example, most Flexcoms output their pins to
headers.
>> +
>> +Required properties:
>> +- compatible: Should be "atmel,sama5d2-flexcom"
>> +- reg: Should be the offset/length value for Flexcom dedicated
>> + I/O registers (without USART, TWI or SPI registers).
>> +- clocks: Should be the Flexcom peripheral clock from PMC.
>> +- #address-cells: Should be <1>
>> +- #size-cells: Should be <1>
>> +- ranges: Should be one range for the full I/O register region
>> + (including USART, TWI and SPI registers).
>> +- atmel,flexcom-mode: Should be one of the 3 following macros as defined in
>> + include/dt-bindings/mfd/atmel-flexcom.h:
>> + - ATMEL_FLEXCOM_MODE_USART for USART
>> + - ATMEL_FLEXCOM_MODE_SPI for SPI
>> + - ATMEL_FLEXCOM_MODE_TWI for I2C
>> +
>> +Required child:
>> +a single child device of type matching the "atmel,flexcom-mode" property.
>
> Okay, but why not allow all children and use "status"?
>
That is exactly what was proposed in v6 of this series: allow more than one
child so possibly all children but only one "available" child (status =
"okay").
The Flexocm driver still needs to find out the type of device of this
available child to know which function is to be enabled (USART, I2C or SPI).
So the "compatible" attribute was parsed using strstr() to search on of the
patterns "usart", "spi" or "i2c".
However the use of strstr() was discussed to know whether the driver should
looks for a partial or an exact match of the "compatible" string.
An exact match would require to keep the Flexcom driver synchonized with the
3 other drivers every time one of them introduces a new compatibility string,
which whould have made every driver more difficult to maintain by creating a
useless dependency.
So this implementation relying on the "compatible" attribute was abandoned.
To sum up, no other reliable (and simple) means to guess/extact the device
type from its DT node was found so we got back to the "atmel,flexcom-mode"
property.
>> +
>> +The reg property of this child should be:
>> +- <0x200 0x200> for USART
>> +- <0x400 0x200> for SPI
>> +- <0x600 0x200> for I2C
>> +
>> +The phandle provided by the clocks property of the child is the same as one for
>> +the Flexcom parent.
>> +
>> +Other properties remain unchanged. See documentation of the respective device:
>> +- ../serial/atmel-usart.txt
>> +- ../spi/spi_atmel.txt
>> +- ../i2c/i2c-at91.txt
>> +
>> +Example:
>> +
>> +flexcom at f8034000 {
>> + compatible = "atmel,sama5d2-flexcom";
>> + reg = <0xf8034000 0x200>;
>> + clocks = <&flx0_clk>;
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> + ranges = <0x0 0xf8034000 0x800>;
>> + atmel,flexcom-mode = <ATMEL_FLEXCOM_MODE_SPI>;
>> +
>> + spi at 400 {
>> + compatible = "atmel,at91rm9200-spi";
>> + reg = <0x400 0x200>;
>> + interrupts = <19 IRQ_TYPE_LEVEL_HIGH 7>;
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&pinctrl_flx0_default>;
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + clocks = <&flx0_clk>;
>> + clock-names = "spi_clk";
>> + atmel,fifo-size = <32>;
>> +
>> + mtd_dataflash at 0 {
>> + compatible = "atmel,at25f512b";
>> + reg = <0>;
>> + spi-max-frequency = <20000000>;
>> + };
>> + };
>> +};
>>
>
Best Regards,
Cyrille
^ permalink raw reply [flat|nested] 45+ messages in thread* Re: [PATCH linux-next v9 2/3] mfd: devicetree: add bindings for Atmel Flexcom
@ 2015-09-09 15:45 ` Cyrille Pitchen
0 siblings, 0 replies; 45+ messages in thread
From: Cyrille Pitchen @ 2015-09-09 15:45 UTC (permalink / raw)
To: Rob Herring, nicolas.ferre, boris.brezillon, alexandre.belloni,
sameo, lee.jones
Cc: linux-arm-kernel, linux-kernel, robh+dt, pawel.moll,
mark.rutland, ijc+devicetree, galak, devicetree
Hi Rob,
Le 09/09/2015 01:40, Rob Herring a écrit :
> On 09/01/2015 09:46 AM, Cyrille Pitchen wrote:
>> This patch documents the DT bindings for the Atmel Flexcom which will be
>> introduced by sama5d2x SoCs. These bindings will be used by the actual
>> Flexcom driver to be sent in another patch.
>>
>> Signed-off-by: Cyrille Pitchen <cyrille.pitchen@atmel.com>
>> Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>
>> Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
>
> A few comments, but in general looks fine.
>
>> ---
>> .../devicetree/bindings/mfd/atmel-flexcom.txt | 67 ++++++++++++++++++++++
>> 1 file changed, 67 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/mfd/atmel-flexcom.txt
>>
>> diff --git a/Documentation/devicetree/bindings/mfd/atmel-flexcom.txt b/Documentation/devicetree/bindings/mfd/atmel-flexcom.txt
>> new file mode 100644
>> index 000000000000..fc3511e41542
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/mfd/atmel-flexcom.txt
>> @@ -0,0 +1,67 @@
>> +* Device tree bindings for Atmel Flexcom (Flexible Serial Communication Unit)
>> +
>> +The Atmel Flexcom is just a wrapper which embeds a SPI controller, an I2C
>> +controller and an USART. Only one function can be used at a time and is chosen
>> +at boot time according to the device tree.
>
> Doesn't the board design choose (unless pins go to a header)?
>
The function may be chosen once for all by the board design but if we take the
sama5d2 xplained board as an example, most Flexcoms output their pins to
headers.
>> +
>> +Required properties:
>> +- compatible: Should be "atmel,sama5d2-flexcom"
>> +- reg: Should be the offset/length value for Flexcom dedicated
>> + I/O registers (without USART, TWI or SPI registers).
>> +- clocks: Should be the Flexcom peripheral clock from PMC.
>> +- #address-cells: Should be <1>
>> +- #size-cells: Should be <1>
>> +- ranges: Should be one range for the full I/O register region
>> + (including USART, TWI and SPI registers).
>> +- atmel,flexcom-mode: Should be one of the 3 following macros as defined in
>> + include/dt-bindings/mfd/atmel-flexcom.h:
>> + - ATMEL_FLEXCOM_MODE_USART for USART
>> + - ATMEL_FLEXCOM_MODE_SPI for SPI
>> + - ATMEL_FLEXCOM_MODE_TWI for I2C
>> +
>> +Required child:
>> +a single child device of type matching the "atmel,flexcom-mode" property.
>
> Okay, but why not allow all children and use "status"?
>
That is exactly what was proposed in v6 of this series: allow more than one
child so possibly all children but only one "available" child (status =
"okay").
The Flexocm driver still needs to find out the type of device of this
available child to know which function is to be enabled (USART, I2C or SPI).
So the "compatible" attribute was parsed using strstr() to search on of the
patterns "usart", "spi" or "i2c".
However the use of strstr() was discussed to know whether the driver should
looks for a partial or an exact match of the "compatible" string.
An exact match would require to keep the Flexcom driver synchonized with the
3 other drivers every time one of them introduces a new compatibility string,
which whould have made every driver more difficult to maintain by creating a
useless dependency.
So this implementation relying on the "compatible" attribute was abandoned.
To sum up, no other reliable (and simple) means to guess/extact the device
type from its DT node was found so we got back to the "atmel,flexcom-mode"
property.
>> +
>> +The reg property of this child should be:
>> +- <0x200 0x200> for USART
>> +- <0x400 0x200> for SPI
>> +- <0x600 0x200> for I2C
>> +
>> +The phandle provided by the clocks property of the child is the same as one for
>> +the Flexcom parent.
>> +
>> +Other properties remain unchanged. See documentation of the respective device:
>> +- ../serial/atmel-usart.txt
>> +- ../spi/spi_atmel.txt
>> +- ../i2c/i2c-at91.txt
>> +
>> +Example:
>> +
>> +flexcom@f8034000 {
>> + compatible = "atmel,sama5d2-flexcom";
>> + reg = <0xf8034000 0x200>;
>> + clocks = <&flx0_clk>;
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> + ranges = <0x0 0xf8034000 0x800>;
>> + atmel,flexcom-mode = <ATMEL_FLEXCOM_MODE_SPI>;
>> +
>> + spi@400 {
>> + compatible = "atmel,at91rm9200-spi";
>> + reg = <0x400 0x200>;
>> + interrupts = <19 IRQ_TYPE_LEVEL_HIGH 7>;
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&pinctrl_flx0_default>;
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + clocks = <&flx0_clk>;
>> + clock-names = "spi_clk";
>> + atmel,fifo-size = <32>;
>> +
>> + mtd_dataflash@0 {
>> + compatible = "atmel,at25f512b";
>> + reg = <0>;
>> + spi-max-frequency = <20000000>;
>> + };
>> + };
>> +};
>>
>
Best Regards,
Cyrille
^ permalink raw reply [flat|nested] 45+ messages in thread* Re: [PATCH linux-next v9 2/3] mfd: devicetree: add bindings for Atmel Flexcom
2015-09-09 15:45 ` Cyrille Pitchen
@ 2015-09-10 0:06 ` Rob Herring
-1 siblings, 0 replies; 45+ messages in thread
From: Rob Herring @ 2015-09-10 0:06 UTC (permalink / raw)
To: Cyrille Pitchen, nicolas.ferre, boris.brezillon,
alexandre.belloni, sameo, lee.jones
Cc: linux-arm-kernel, linux-kernel, robh+dt, pawel.moll,
mark.rutland, ijc+devicetree, galak, devicetree
On 09/09/2015 10:45 AM, Cyrille Pitchen wrote:
> Hi Rob,
>
> Le 09/09/2015 01:40, Rob Herring a écrit :
>> On 09/01/2015 09:46 AM, Cyrille Pitchen wrote:
>>> This patch documents the DT bindings for the Atmel Flexcom which will be
>>> introduced by sama5d2x SoCs. These bindings will be used by the actual
>>> Flexcom driver to be sent in another patch.
>>>
>>> Signed-off-by: Cyrille Pitchen <cyrille.pitchen@atmel.com>
>>> Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>
>>> Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
>>
>> A few comments, but in general looks fine.
>>
>>> ---
>>> .../devicetree/bindings/mfd/atmel-flexcom.txt | 67 ++++++++++++++++++++++
>>> 1 file changed, 67 insertions(+)
>>> create mode 100644 Documentation/devicetree/bindings/mfd/atmel-flexcom.txt
>>>
>>> diff --git a/Documentation/devicetree/bindings/mfd/atmel-flexcom.txt b/Documentation/devicetree/bindings/mfd/atmel-flexcom.txt
>>> new file mode 100644
>>> index 000000000000..fc3511e41542
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/mfd/atmel-flexcom.txt
>>> @@ -0,0 +1,67 @@
>>> +* Device tree bindings for Atmel Flexcom (Flexible Serial Communication Unit)
>>> +
>>> +The Atmel Flexcom is just a wrapper which embeds a SPI controller, an I2C
>>> +controller and an USART. Only one function can be used at a time and is chosen
>>> +at boot time according to the device tree.
>>
>> Doesn't the board design choose (unless pins go to a header)?
>>
>
> The function may be chosen once for all by the board design but if we take the
> sama5d2 xplained board as an example, most Flexcoms output their pins to
> headers.
>
>>> +
>>> +Required properties:
>>> +- compatible: Should be "atmel,sama5d2-flexcom"
>>> +- reg: Should be the offset/length value for Flexcom dedicated
>>> + I/O registers (without USART, TWI or SPI registers).
>>> +- clocks: Should be the Flexcom peripheral clock from PMC.
>>> +- #address-cells: Should be <1>
>>> +- #size-cells: Should be <1>
>>> +- ranges: Should be one range for the full I/O register region
>>> + (including USART, TWI and SPI registers).
>>> +- atmel,flexcom-mode: Should be one of the 3 following macros as defined in
>>> + include/dt-bindings/mfd/atmel-flexcom.h:
>>> + - ATMEL_FLEXCOM_MODE_USART for USART
>>> + - ATMEL_FLEXCOM_MODE_SPI for SPI
>>> + - ATMEL_FLEXCOM_MODE_TWI for I2C
>>> +
>>> +Required child:
>>> +a single child device of type matching the "atmel,flexcom-mode" property.
>>
>> Okay, but why not allow all children and use "status"?
>>
>
> That is exactly what was proposed in v6 of this series: allow more than one
> child so possibly all children but only one "available" child (status =
> "okay").
>
> The Flexocm driver still needs to find out the type of device of this
> available child to know which function is to be enabled (USART, I2C or SPI).
> So the "compatible" attribute was parsed using strstr() to search on of the
> patterns "usart", "spi" or "i2c".
>
> However the use of strstr() was discussed to know whether the driver should
> looks for a partial or an exact match of the "compatible" string.
> An exact match would require to keep the Flexcom driver synchonized with the
> 3 other drivers every time one of them introduces a new compatibility string,
> which whould have made every driver more difficult to maintain by creating a
> useless dependency.
> So this implementation relying on the "compatible" attribute was abandoned.
>
> To sum up, no other reliable (and simple) means to guess/extact the device
> type from its DT node was found so we got back to the "atmel,flexcom-mode"
> property.
I wasn't thinking removing this property. If the mode is configured by
the bootloader, then you want to make updates to the configuration as
simple as possible. Updating atmel,flexcom-mode and status for the
children would be much more simple than creating the whole child node.
If that's not a valid usecase, then never mind.
Rob
^ permalink raw reply [flat|nested] 45+ messages in thread
* [PATCH linux-next v9 2/3] mfd: devicetree: add bindings for Atmel Flexcom
@ 2015-09-10 0:06 ` Rob Herring
0 siblings, 0 replies; 45+ messages in thread
From: Rob Herring @ 2015-09-10 0:06 UTC (permalink / raw)
To: linux-arm-kernel
On 09/09/2015 10:45 AM, Cyrille Pitchen wrote:
> Hi Rob,
>
> Le 09/09/2015 01:40, Rob Herring a ?crit :
>> On 09/01/2015 09:46 AM, Cyrille Pitchen wrote:
>>> This patch documents the DT bindings for the Atmel Flexcom which will be
>>> introduced by sama5d2x SoCs. These bindings will be used by the actual
>>> Flexcom driver to be sent in another patch.
>>>
>>> Signed-off-by: Cyrille Pitchen <cyrille.pitchen@atmel.com>
>>> Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>
>>> Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
>>
>> A few comments, but in general looks fine.
>>
>>> ---
>>> .../devicetree/bindings/mfd/atmel-flexcom.txt | 67 ++++++++++++++++++++++
>>> 1 file changed, 67 insertions(+)
>>> create mode 100644 Documentation/devicetree/bindings/mfd/atmel-flexcom.txt
>>>
>>> diff --git a/Documentation/devicetree/bindings/mfd/atmel-flexcom.txt b/Documentation/devicetree/bindings/mfd/atmel-flexcom.txt
>>> new file mode 100644
>>> index 000000000000..fc3511e41542
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/mfd/atmel-flexcom.txt
>>> @@ -0,0 +1,67 @@
>>> +* Device tree bindings for Atmel Flexcom (Flexible Serial Communication Unit)
>>> +
>>> +The Atmel Flexcom is just a wrapper which embeds a SPI controller, an I2C
>>> +controller and an USART. Only one function can be used at a time and is chosen
>>> +at boot time according to the device tree.
>>
>> Doesn't the board design choose (unless pins go to a header)?
>>
>
> The function may be chosen once for all by the board design but if we take the
> sama5d2 xplained board as an example, most Flexcoms output their pins to
> headers.
>
>>> +
>>> +Required properties:
>>> +- compatible: Should be "atmel,sama5d2-flexcom"
>>> +- reg: Should be the offset/length value for Flexcom dedicated
>>> + I/O registers (without USART, TWI or SPI registers).
>>> +- clocks: Should be the Flexcom peripheral clock from PMC.
>>> +- #address-cells: Should be <1>
>>> +- #size-cells: Should be <1>
>>> +- ranges: Should be one range for the full I/O register region
>>> + (including USART, TWI and SPI registers).
>>> +- atmel,flexcom-mode: Should be one of the 3 following macros as defined in
>>> + include/dt-bindings/mfd/atmel-flexcom.h:
>>> + - ATMEL_FLEXCOM_MODE_USART for USART
>>> + - ATMEL_FLEXCOM_MODE_SPI for SPI
>>> + - ATMEL_FLEXCOM_MODE_TWI for I2C
>>> +
>>> +Required child:
>>> +a single child device of type matching the "atmel,flexcom-mode" property.
>>
>> Okay, but why not allow all children and use "status"?
>>
>
> That is exactly what was proposed in v6 of this series: allow more than one
> child so possibly all children but only one "available" child (status =
> "okay").
>
> The Flexocm driver still needs to find out the type of device of this
> available child to know which function is to be enabled (USART, I2C or SPI).
> So the "compatible" attribute was parsed using strstr() to search on of the
> patterns "usart", "spi" or "i2c".
>
> However the use of strstr() was discussed to know whether the driver should
> looks for a partial or an exact match of the "compatible" string.
> An exact match would require to keep the Flexcom driver synchonized with the
> 3 other drivers every time one of them introduces a new compatibility string,
> which whould have made every driver more difficult to maintain by creating a
> useless dependency.
> So this implementation relying on the "compatible" attribute was abandoned.
>
> To sum up, no other reliable (and simple) means to guess/extact the device
> type from its DT node was found so we got back to the "atmel,flexcom-mode"
> property.
I wasn't thinking removing this property. If the mode is configured by
the bootloader, then you want to make updates to the configuration as
simple as possible. Updating atmel,flexcom-mode and status for the
children would be much more simple than creating the whole child node.
If that's not a valid usecase, then never mind.
Rob
^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH linux-next v9 2/3] mfd: devicetree: add bindings for Atmel Flexcom
@ 2015-09-21 12:15 ` Cyrille Pitchen
0 siblings, 0 replies; 45+ messages in thread
From: Cyrille Pitchen @ 2015-09-21 12:15 UTC (permalink / raw)
To: Rob Herring, nicolas.ferre, boris.brezillon, alexandre.belloni,
sameo, lee.jones
Cc: linux-arm-kernel, linux-kernel, robh+dt, pawel.moll,
mark.rutland, ijc+devicetree, galak, devicetree
Hi Rob,
Le 10/09/2015 02:06, Rob Herring a écrit :
> On 09/09/2015 10:45 AM, Cyrille Pitchen wrote:
>> Hi Rob,
>>
>> Le 09/09/2015 01:40, Rob Herring a écrit :
>>> On 09/01/2015 09:46 AM, Cyrille Pitchen wrote:
>>>> This patch documents the DT bindings for the Atmel Flexcom which will be
>>>> introduced by sama5d2x SoCs. These bindings will be used by the actual
>>>> Flexcom driver to be sent in another patch.
>>>>
>>>> Signed-off-by: Cyrille Pitchen <cyrille.pitchen@atmel.com>
>>>> Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>
>>>> Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
>>>
>>> A few comments, but in general looks fine.
>>>
>>>> ---
>>>> .../devicetree/bindings/mfd/atmel-flexcom.txt | 67 ++++++++++++++++++++++
>>>> 1 file changed, 67 insertions(+)
>>>> create mode 100644 Documentation/devicetree/bindings/mfd/atmel-flexcom.txt
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/mfd/atmel-flexcom.txt b/Documentation/devicetree/bindings/mfd/atmel-flexcom.txt
>>>> new file mode 100644
>>>> index 000000000000..fc3511e41542
>>>> --- /dev/null
>>>> +++ b/Documentation/devicetree/bindings/mfd/atmel-flexcom.txt
>>>> @@ -0,0 +1,67 @@
>>>> +* Device tree bindings for Atmel Flexcom (Flexible Serial Communication Unit)
>>>> +
>>>> +The Atmel Flexcom is just a wrapper which embeds a SPI controller, an I2C
>>>> +controller and an USART. Only one function can be used at a time and is chosen
>>>> +at boot time according to the device tree.
>>>
>>> Doesn't the board design choose (unless pins go to a header)?
>>>
>>
>> The function may be chosen once for all by the board design but if we take the
>> sama5d2 xplained board as an example, most Flexcoms output their pins to
>> headers.
>>
>>>> +
>>>> +Required properties:
>>>> +- compatible: Should be "atmel,sama5d2-flexcom"
>>>> +- reg: Should be the offset/length value for Flexcom dedicated
>>>> + I/O registers (without USART, TWI or SPI registers).
>>>> +- clocks: Should be the Flexcom peripheral clock from PMC.
>>>> +- #address-cells: Should be <1>
>>>> +- #size-cells: Should be <1>
>>>> +- ranges: Should be one range for the full I/O register region
>>>> + (including USART, TWI and SPI registers).
>>>> +- atmel,flexcom-mode: Should be one of the 3 following macros as defined in
>>>> + include/dt-bindings/mfd/atmel-flexcom.h:
>>>> + - ATMEL_FLEXCOM_MODE_USART for USART
>>>> + - ATMEL_FLEXCOM_MODE_SPI for SPI
>>>> + - ATMEL_FLEXCOM_MODE_TWI for I2C
>>>> +
>>>> +Required child:
>>>> +a single child device of type matching the "atmel,flexcom-mode" property.
>>>
>>> Okay, but why not allow all children and use "status"?
>>>
>>
>> That is exactly what was proposed in v6 of this series: allow more than one
>> child so possibly all children but only one "available" child (status =
>> "okay").
>>
>> The Flexocm driver still needs to find out the type of device of this
>> available child to know which function is to be enabled (USART, I2C or SPI).
>> So the "compatible" attribute was parsed using strstr() to search on of the
>> patterns "usart", "spi" or "i2c".
>>
>> However the use of strstr() was discussed to know whether the driver should
>> looks for a partial or an exact match of the "compatible" string.
>> An exact match would require to keep the Flexcom driver synchonized with the
>> 3 other drivers every time one of them introduces a new compatibility string,
>> which whould have made every driver more difficult to maintain by creating a
>> useless dependency.
>> So this implementation relying on the "compatible" attribute was abandoned.
>>
>> To sum up, no other reliable (and simple) means to guess/extact the device
>> type from its DT node was found so we got back to the "atmel,flexcom-mode"
>> property.
>
> I wasn't thinking removing this property. If the mode is configured by
> the bootloader, then you want to make updates to the configuration as
> simple as possible. Updating atmel,flexcom-mode and status for the
> children would be much more simple than creating the whole child node.
> If that's not a valid usecase, then never mind.
>
> Rob
>
The Flexcom driver calls of_platform_populate(), so yes it's allowed and
supported to put the 3 children in the DT as long as only one is available.
Should I update the documentation to deal with optional children or leave it
as it is?
Best Regards,
Cyrille
^ permalink raw reply [flat|nested] 45+ messages in thread
* [PATCH linux-next v9 2/3] mfd: devicetree: add bindings for Atmel Flexcom
@ 2015-09-21 12:15 ` Cyrille Pitchen
0 siblings, 0 replies; 45+ messages in thread
From: Cyrille Pitchen @ 2015-09-21 12:15 UTC (permalink / raw)
To: linux-arm-kernel
Hi Rob,
Le 10/09/2015 02:06, Rob Herring a ?crit :
> On 09/09/2015 10:45 AM, Cyrille Pitchen wrote:
>> Hi Rob,
>>
>> Le 09/09/2015 01:40, Rob Herring a ?crit :
>>> On 09/01/2015 09:46 AM, Cyrille Pitchen wrote:
>>>> This patch documents the DT bindings for the Atmel Flexcom which will be
>>>> introduced by sama5d2x SoCs. These bindings will be used by the actual
>>>> Flexcom driver to be sent in another patch.
>>>>
>>>> Signed-off-by: Cyrille Pitchen <cyrille.pitchen@atmel.com>
>>>> Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>
>>>> Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
>>>
>>> A few comments, but in general looks fine.
>>>
>>>> ---
>>>> .../devicetree/bindings/mfd/atmel-flexcom.txt | 67 ++++++++++++++++++++++
>>>> 1 file changed, 67 insertions(+)
>>>> create mode 100644 Documentation/devicetree/bindings/mfd/atmel-flexcom.txt
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/mfd/atmel-flexcom.txt b/Documentation/devicetree/bindings/mfd/atmel-flexcom.txt
>>>> new file mode 100644
>>>> index 000000000000..fc3511e41542
>>>> --- /dev/null
>>>> +++ b/Documentation/devicetree/bindings/mfd/atmel-flexcom.txt
>>>> @@ -0,0 +1,67 @@
>>>> +* Device tree bindings for Atmel Flexcom (Flexible Serial Communication Unit)
>>>> +
>>>> +The Atmel Flexcom is just a wrapper which embeds a SPI controller, an I2C
>>>> +controller and an USART. Only one function can be used at a time and is chosen
>>>> +at boot time according to the device tree.
>>>
>>> Doesn't the board design choose (unless pins go to a header)?
>>>
>>
>> The function may be chosen once for all by the board design but if we take the
>> sama5d2 xplained board as an example, most Flexcoms output their pins to
>> headers.
>>
>>>> +
>>>> +Required properties:
>>>> +- compatible: Should be "atmel,sama5d2-flexcom"
>>>> +- reg: Should be the offset/length value for Flexcom dedicated
>>>> + I/O registers (without USART, TWI or SPI registers).
>>>> +- clocks: Should be the Flexcom peripheral clock from PMC.
>>>> +- #address-cells: Should be <1>
>>>> +- #size-cells: Should be <1>
>>>> +- ranges: Should be one range for the full I/O register region
>>>> + (including USART, TWI and SPI registers).
>>>> +- atmel,flexcom-mode: Should be one of the 3 following macros as defined in
>>>> + include/dt-bindings/mfd/atmel-flexcom.h:
>>>> + - ATMEL_FLEXCOM_MODE_USART for USART
>>>> + - ATMEL_FLEXCOM_MODE_SPI for SPI
>>>> + - ATMEL_FLEXCOM_MODE_TWI for I2C
>>>> +
>>>> +Required child:
>>>> +a single child device of type matching the "atmel,flexcom-mode" property.
>>>
>>> Okay, but why not allow all children and use "status"?
>>>
>>
>> That is exactly what was proposed in v6 of this series: allow more than one
>> child so possibly all children but only one "available" child (status =
>> "okay").
>>
>> The Flexocm driver still needs to find out the type of device of this
>> available child to know which function is to be enabled (USART, I2C or SPI).
>> So the "compatible" attribute was parsed using strstr() to search on of the
>> patterns "usart", "spi" or "i2c".
>>
>> However the use of strstr() was discussed to know whether the driver should
>> looks for a partial or an exact match of the "compatible" string.
>> An exact match would require to keep the Flexcom driver synchonized with the
>> 3 other drivers every time one of them introduces a new compatibility string,
>> which whould have made every driver more difficult to maintain by creating a
>> useless dependency.
>> So this implementation relying on the "compatible" attribute was abandoned.
>>
>> To sum up, no other reliable (and simple) means to guess/extact the device
>> type from its DT node was found so we got back to the "atmel,flexcom-mode"
>> property.
>
> I wasn't thinking removing this property. If the mode is configured by
> the bootloader, then you want to make updates to the configuration as
> simple as possible. Updating atmel,flexcom-mode and status for the
> children would be much more simple than creating the whole child node.
> If that's not a valid usecase, then never mind.
>
> Rob
>
The Flexcom driver calls of_platform_populate(), so yes it's allowed and
supported to put the 3 children in the DT as long as only one is available.
Should I update the documentation to deal with optional children or leave it
as it is?
Best Regards,
Cyrille
^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH linux-next v9 2/3] mfd: devicetree: add bindings for Atmel Flexcom
@ 2015-09-21 12:15 ` Cyrille Pitchen
0 siblings, 0 replies; 45+ messages in thread
From: Cyrille Pitchen @ 2015-09-21 12:15 UTC (permalink / raw)
To: Rob Herring, nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w,
boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8,
alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8,
sameo-VuQAYsv1563Yd54FQh9/CA, lee.jones-QSEj5FYQhm4dnm+yROfE0A
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A, pawel.moll-5wv7dgnIgG8,
mark.rutland-5wv7dgnIgG8, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg,
galak-sgV2jX0FEOL9JmXXK+q4OQ, devicetree-u79uwXL29TY76Z2rM5mHXA
Hi Rob,
Le 10/09/2015 02:06, Rob Herring a écrit :
> On 09/09/2015 10:45 AM, Cyrille Pitchen wrote:
>> Hi Rob,
>>
>> Le 09/09/2015 01:40, Rob Herring a écrit :
>>> On 09/01/2015 09:46 AM, Cyrille Pitchen wrote:
>>>> This patch documents the DT bindings for the Atmel Flexcom which will be
>>>> introduced by sama5d2x SoCs. These bindings will be used by the actual
>>>> Flexcom driver to be sent in another patch.
>>>>
>>>> Signed-off-by: Cyrille Pitchen <cyrille.pitchen-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
>>>> Acked-by: Boris Brezillon <boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
>>>> Acked-by: Alexandre Belloni <alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
>>>
>>> A few comments, but in general looks fine.
>>>
>>>> ---
>>>> .../devicetree/bindings/mfd/atmel-flexcom.txt | 67 ++++++++++++++++++++++
>>>> 1 file changed, 67 insertions(+)
>>>> create mode 100644 Documentation/devicetree/bindings/mfd/atmel-flexcom.txt
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/mfd/atmel-flexcom.txt b/Documentation/devicetree/bindings/mfd/atmel-flexcom.txt
>>>> new file mode 100644
>>>> index 000000000000..fc3511e41542
>>>> --- /dev/null
>>>> +++ b/Documentation/devicetree/bindings/mfd/atmel-flexcom.txt
>>>> @@ -0,0 +1,67 @@
>>>> +* Device tree bindings for Atmel Flexcom (Flexible Serial Communication Unit)
>>>> +
>>>> +The Atmel Flexcom is just a wrapper which embeds a SPI controller, an I2C
>>>> +controller and an USART. Only one function can be used at a time and is chosen
>>>> +at boot time according to the device tree.
>>>
>>> Doesn't the board design choose (unless pins go to a header)?
>>>
>>
>> The function may be chosen once for all by the board design but if we take the
>> sama5d2 xplained board as an example, most Flexcoms output their pins to
>> headers.
>>
>>>> +
>>>> +Required properties:
>>>> +- compatible: Should be "atmel,sama5d2-flexcom"
>>>> +- reg: Should be the offset/length value for Flexcom dedicated
>>>> + I/O registers (without USART, TWI or SPI registers).
>>>> +- clocks: Should be the Flexcom peripheral clock from PMC.
>>>> +- #address-cells: Should be <1>
>>>> +- #size-cells: Should be <1>
>>>> +- ranges: Should be one range for the full I/O register region
>>>> + (including USART, TWI and SPI registers).
>>>> +- atmel,flexcom-mode: Should be one of the 3 following macros as defined in
>>>> + include/dt-bindings/mfd/atmel-flexcom.h:
>>>> + - ATMEL_FLEXCOM_MODE_USART for USART
>>>> + - ATMEL_FLEXCOM_MODE_SPI for SPI
>>>> + - ATMEL_FLEXCOM_MODE_TWI for I2C
>>>> +
>>>> +Required child:
>>>> +a single child device of type matching the "atmel,flexcom-mode" property.
>>>
>>> Okay, but why not allow all children and use "status"?
>>>
>>
>> That is exactly what was proposed in v6 of this series: allow more than one
>> child so possibly all children but only one "available" child (status =
>> "okay").
>>
>> The Flexocm driver still needs to find out the type of device of this
>> available child to know which function is to be enabled (USART, I2C or SPI).
>> So the "compatible" attribute was parsed using strstr() to search on of the
>> patterns "usart", "spi" or "i2c".
>>
>> However the use of strstr() was discussed to know whether the driver should
>> looks for a partial or an exact match of the "compatible" string.
>> An exact match would require to keep the Flexcom driver synchonized with the
>> 3 other drivers every time one of them introduces a new compatibility string,
>> which whould have made every driver more difficult to maintain by creating a
>> useless dependency.
>> So this implementation relying on the "compatible" attribute was abandoned.
>>
>> To sum up, no other reliable (and simple) means to guess/extact the device
>> type from its DT node was found so we got back to the "atmel,flexcom-mode"
>> property.
>
> I wasn't thinking removing this property. If the mode is configured by
> the bootloader, then you want to make updates to the configuration as
> simple as possible. Updating atmel,flexcom-mode and status for the
> children would be much more simple than creating the whole child node.
> If that's not a valid usecase, then never mind.
>
> Rob
>
The Flexcom driver calls of_platform_populate(), so yes it's allowed and
supported to put the 3 children in the DT as long as only one is available.
Should I update the documentation to deal with optional children or leave it
as it is?
Best Regards,
Cyrille
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 45+ messages in thread
* [PATCH linux-next v9 3/3] mfd: atmel-flexcom: add a driver for Atmel Flexible Serial Communication Unit
2015-09-01 14:46 ` Cyrille Pitchen
(?)
@ 2015-09-01 14:46 ` Cyrille Pitchen
-1 siblings, 0 replies; 45+ messages in thread
From: Cyrille Pitchen @ 2015-09-01 14:46 UTC (permalink / raw)
To: nicolas.ferre, boris.brezillon, alexandre.belloni, sameo, lee.jones
Cc: linux-arm-kernel, linux-kernel, robh+dt, pawel.moll,
mark.rutland, ijc+devicetree, galak, devicetree, Cyrille Pitchen
This driver supports the new Atmel Flexcom. The Flexcom is a wrapper which
integrates one SPI controller, one I2C controller and one USART. Only one
function can be enabled at a time. This driver selects the function once
for all, when the Flexcom is probed, according to the value of the new
"atmel,flexcom-mode" device tree property.
This driver has chosen to present the Flexcom to the system as a MFD so
the implementation is seamless for the existing Atmel SPI, I2C and USART
drivers.
Also the Flexcom embeds FIFOs: the latest patches of the SPI, I2C and
USART drivers take advantage of this new feature.
Signed-off-by: Cyrille Pitchen <cyrille.pitchen@atmel.com>
Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>
Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
---
drivers/mfd/Kconfig | 11 +++++
drivers/mfd/Makefile | 1 +
drivers/mfd/atmel-flexcom.c | 104 ++++++++++++++++++++++++++++++++++++++++++++
3 files changed, 116 insertions(+)
create mode 100644 drivers/mfd/atmel-flexcom.c
diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index 99d63675f073..87e84e7c71da 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -60,6 +60,17 @@ config MFD_AAT2870_CORE
additional drivers must be enabled in order to use the
functionality of the device.
+config MFD_ATMEL_FLEXCOM
+ tristate "Atmel Flexcom (Flexible Serial Communication Unit)"
+ select MFD_CORE
+ depends on OF
+ help
+ Select this to get support for Atmel Flexcom. This is a wrapper
+ which embeds a SPI controller, a I2C controller and a USART. Only
+ one function can be used at a time. The choice is done at boot time
+ by the probe function of this MFD driver according to a device tree
+ property.
+
config MFD_ATMEL_HLCDC
tristate "Atmel HLCDC (High-end LCD Controller)"
select MFD_CORE
diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile
index a59e3fcc8626..f2383e0d1760 100644
--- a/drivers/mfd/Makefile
+++ b/drivers/mfd/Makefile
@@ -164,6 +164,7 @@ obj-$(CONFIG_MFD_SPMI_PMIC) += qcom-spmi-pmic.o
obj-$(CONFIG_TPS65911_COMPARATOR) += tps65911-comparator.o
obj-$(CONFIG_MFD_TPS65090) += tps65090.o
obj-$(CONFIG_MFD_AAT2870_CORE) += aat2870-core.o
+obj-$(CONFIG_MFD_ATMEL_FLEXCOM) += atmel-flexcom.o
obj-$(CONFIG_MFD_ATMEL_HLCDC) += atmel-hlcdc.o
obj-$(CONFIG_MFD_INTEL_LPSS) += intel-lpss.o
obj-$(CONFIG_MFD_INTEL_LPSS_PCI) += intel-lpss-pci.o
diff --git a/drivers/mfd/atmel-flexcom.c b/drivers/mfd/atmel-flexcom.c
new file mode 100644
index 000000000000..e8e67be6b493
--- /dev/null
+++ b/drivers/mfd/atmel-flexcom.c
@@ -0,0 +1,104 @@
+/*
+ * Driver for Atmel Flexcom
+ *
+ * Copyright (C) 2015 Atmel Corporation
+ *
+ * Author: Cyrille Pitchen <cyrille.pitchen@atmel.com>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
+ * more details.
+ *
+ * You should have received a copy of the GNU General Public License along with
+ * this program. If not, see <http://www.gnu.org/licenses/>.
+ */
+
+#include <linux/module.h>
+#include <linux/types.h>
+#include <linux/kernel.h>
+#include <linux/platform_device.h>
+#include <linux/of.h>
+#include <linux/of_platform.h>
+#include <linux/err.h>
+#include <linux/io.h>
+#include <linux/clk.h>
+#include <dt-bindings/mfd/atmel-flexcom.h>
+
+/* I/O register offsets */
+#define FLEX_MR 0x0 /* Mode Register */
+#define FLEX_VERSION 0xfc /* Version Register */
+
+/* Mode Register bit fields */
+#define FLEX_MR_OPMODE_OFFSET (0) /* Operating Mode */
+#define FLEX_MR_OPMODE_MASK (0x3 << FLEX_MR_OPMODE_OFFSET)
+#define FLEX_MR_OPMODE(opmode) (((opmode) << FLEX_MR_OPMODE_OFFSET) & \
+ FLEX_MR_OPMODE_MASK)
+
+
+static int atmel_flexcom_probe(struct platform_device *pdev)
+{
+ struct device_node *np = pdev->dev.of_node;
+ struct clk *clk;
+ struct resource *res;
+ void __iomem *base;
+ u32 opmode;
+ int err;
+
+ err = of_property_read_u32(np, "atmel,flexcom-mode", &opmode);
+ if (err)
+ return err;
+
+ if (opmode < ATMEL_FLEXCOM_MODE_USART ||
+ opmode > ATMEL_FLEXCOM_MODE_TWI)
+ return -EINVAL;
+
+ res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
+ base = devm_ioremap_resource(&pdev->dev, res);
+ if (IS_ERR(base))
+ return PTR_ERR(base);
+
+ clk = devm_clk_get(&pdev->dev, NULL);
+ if (IS_ERR(clk))
+ return PTR_ERR(clk);
+
+ err = clk_prepare_enable(clk);
+ if (err)
+ return err;
+
+ /*
+ * Set the Operating Mode in the Mode Register: only the selected device
+ * is clocked. Hence, registers of the other serial devices remain
+ * inaccessible and are read as zero. Also the external I/O lines of the
+ * Flexcom are muxed to reach the selected device.
+ */
+ writel(FLEX_MR_OPMODE(opmode), base + FLEX_MR);
+
+ clk_disable_unprepare(clk);
+
+ return of_platform_populate(np, NULL, NULL, &pdev->dev);
+}
+
+static const struct of_device_id atmel_flexcom_of_match[] = {
+ { .compatible = "atmel,sama5d2-flexcom" },
+ { /* sentinel */ }
+};
+MODULE_DEVICE_TABLE(of, atmel_flexcom_of_match);
+
+static struct platform_driver atmel_flexcom_driver = {
+ .probe = atmel_flexcom_probe,
+ .driver = {
+ .name = "atmel_flexcom",
+ .of_match_table = atmel_flexcom_of_match,
+ },
+};
+
+module_platform_driver(atmel_flexcom_driver);
+
+MODULE_AUTHOR("Cyrille Pitchen <cyrille.pitchen@atmel.com>");
+MODULE_DESCRIPTION("Atmel Flexcom MFD driver");
+MODULE_LICENSE("GPL v2");
--
1.8.2.2
^ permalink raw reply related [flat|nested] 45+ messages in thread* [PATCH linux-next v9 3/3] mfd: atmel-flexcom: add a driver for Atmel Flexible Serial Communication Unit
@ 2015-09-01 14:46 ` Cyrille Pitchen
0 siblings, 0 replies; 45+ messages in thread
From: Cyrille Pitchen @ 2015-09-01 14:46 UTC (permalink / raw)
To: linux-arm-kernel
This driver supports the new Atmel Flexcom. The Flexcom is a wrapper which
integrates one SPI controller, one I2C controller and one USART. Only one
function can be enabled at a time. This driver selects the function once
for all, when the Flexcom is probed, according to the value of the new
"atmel,flexcom-mode" device tree property.
This driver has chosen to present the Flexcom to the system as a MFD so
the implementation is seamless for the existing Atmel SPI, I2C and USART
drivers.
Also the Flexcom embeds FIFOs: the latest patches of the SPI, I2C and
USART drivers take advantage of this new feature.
Signed-off-by: Cyrille Pitchen <cyrille.pitchen@atmel.com>
Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>
Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
---
drivers/mfd/Kconfig | 11 +++++
drivers/mfd/Makefile | 1 +
drivers/mfd/atmel-flexcom.c | 104 ++++++++++++++++++++++++++++++++++++++++++++
3 files changed, 116 insertions(+)
create mode 100644 drivers/mfd/atmel-flexcom.c
diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index 99d63675f073..87e84e7c71da 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -60,6 +60,17 @@ config MFD_AAT2870_CORE
additional drivers must be enabled in order to use the
functionality of the device.
+config MFD_ATMEL_FLEXCOM
+ tristate "Atmel Flexcom (Flexible Serial Communication Unit)"
+ select MFD_CORE
+ depends on OF
+ help
+ Select this to get support for Atmel Flexcom. This is a wrapper
+ which embeds a SPI controller, a I2C controller and a USART. Only
+ one function can be used at a time. The choice is done at boot time
+ by the probe function of this MFD driver according to a device tree
+ property.
+
config MFD_ATMEL_HLCDC
tristate "Atmel HLCDC (High-end LCD Controller)"
select MFD_CORE
diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile
index a59e3fcc8626..f2383e0d1760 100644
--- a/drivers/mfd/Makefile
+++ b/drivers/mfd/Makefile
@@ -164,6 +164,7 @@ obj-$(CONFIG_MFD_SPMI_PMIC) += qcom-spmi-pmic.o
obj-$(CONFIG_TPS65911_COMPARATOR) += tps65911-comparator.o
obj-$(CONFIG_MFD_TPS65090) += tps65090.o
obj-$(CONFIG_MFD_AAT2870_CORE) += aat2870-core.o
+obj-$(CONFIG_MFD_ATMEL_FLEXCOM) += atmel-flexcom.o
obj-$(CONFIG_MFD_ATMEL_HLCDC) += atmel-hlcdc.o
obj-$(CONFIG_MFD_INTEL_LPSS) += intel-lpss.o
obj-$(CONFIG_MFD_INTEL_LPSS_PCI) += intel-lpss-pci.o
diff --git a/drivers/mfd/atmel-flexcom.c b/drivers/mfd/atmel-flexcom.c
new file mode 100644
index 000000000000..e8e67be6b493
--- /dev/null
+++ b/drivers/mfd/atmel-flexcom.c
@@ -0,0 +1,104 @@
+/*
+ * Driver for Atmel Flexcom
+ *
+ * Copyright (C) 2015 Atmel Corporation
+ *
+ * Author: Cyrille Pitchen <cyrille.pitchen@atmel.com>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
+ * more details.
+ *
+ * You should have received a copy of the GNU General Public License along with
+ * this program. If not, see <http://www.gnu.org/licenses/>.
+ */
+
+#include <linux/module.h>
+#include <linux/types.h>
+#include <linux/kernel.h>
+#include <linux/platform_device.h>
+#include <linux/of.h>
+#include <linux/of_platform.h>
+#include <linux/err.h>
+#include <linux/io.h>
+#include <linux/clk.h>
+#include <dt-bindings/mfd/atmel-flexcom.h>
+
+/* I/O register offsets */
+#define FLEX_MR 0x0 /* Mode Register */
+#define FLEX_VERSION 0xfc /* Version Register */
+
+/* Mode Register bit fields */
+#define FLEX_MR_OPMODE_OFFSET (0) /* Operating Mode */
+#define FLEX_MR_OPMODE_MASK (0x3 << FLEX_MR_OPMODE_OFFSET)
+#define FLEX_MR_OPMODE(opmode) (((opmode) << FLEX_MR_OPMODE_OFFSET) & \
+ FLEX_MR_OPMODE_MASK)
+
+
+static int atmel_flexcom_probe(struct platform_device *pdev)
+{
+ struct device_node *np = pdev->dev.of_node;
+ struct clk *clk;
+ struct resource *res;
+ void __iomem *base;
+ u32 opmode;
+ int err;
+
+ err = of_property_read_u32(np, "atmel,flexcom-mode", &opmode);
+ if (err)
+ return err;
+
+ if (opmode < ATMEL_FLEXCOM_MODE_USART ||
+ opmode > ATMEL_FLEXCOM_MODE_TWI)
+ return -EINVAL;
+
+ res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
+ base = devm_ioremap_resource(&pdev->dev, res);
+ if (IS_ERR(base))
+ return PTR_ERR(base);
+
+ clk = devm_clk_get(&pdev->dev, NULL);
+ if (IS_ERR(clk))
+ return PTR_ERR(clk);
+
+ err = clk_prepare_enable(clk);
+ if (err)
+ return err;
+
+ /*
+ * Set the Operating Mode in the Mode Register: only the selected device
+ * is clocked. Hence, registers of the other serial devices remain
+ * inaccessible and are read as zero. Also the external I/O lines of the
+ * Flexcom are muxed to reach the selected device.
+ */
+ writel(FLEX_MR_OPMODE(opmode), base + FLEX_MR);
+
+ clk_disable_unprepare(clk);
+
+ return of_platform_populate(np, NULL, NULL, &pdev->dev);
+}
+
+static const struct of_device_id atmel_flexcom_of_match[] = {
+ { .compatible = "atmel,sama5d2-flexcom" },
+ { /* sentinel */ }
+};
+MODULE_DEVICE_TABLE(of, atmel_flexcom_of_match);
+
+static struct platform_driver atmel_flexcom_driver = {
+ .probe = atmel_flexcom_probe,
+ .driver = {
+ .name = "atmel_flexcom",
+ .of_match_table = atmel_flexcom_of_match,
+ },
+};
+
+module_platform_driver(atmel_flexcom_driver);
+
+MODULE_AUTHOR("Cyrille Pitchen <cyrille.pitchen@atmel.com>");
+MODULE_DESCRIPTION("Atmel Flexcom MFD driver");
+MODULE_LICENSE("GPL v2");
--
1.8.2.2
^ permalink raw reply related [flat|nested] 45+ messages in thread* [PATCH linux-next v9 3/3] mfd: atmel-flexcom: add a driver for Atmel Flexible Serial Communication Unit
@ 2015-09-01 14:46 ` Cyrille Pitchen
0 siblings, 0 replies; 45+ messages in thread
From: Cyrille Pitchen @ 2015-09-01 14:46 UTC (permalink / raw)
To: nicolas.ferre, boris.brezillon, alexandre.belloni, sameo, lee.jones
Cc: linux-arm-kernel, linux-kernel, robh+dt, pawel.moll,
mark.rutland, ijc+devicetree, galak, devicetree, Cyrille Pitchen
This driver supports the new Atmel Flexcom. The Flexcom is a wrapper which
integrates one SPI controller, one I2C controller and one USART. Only one
function can be enabled at a time. This driver selects the function once
for all, when the Flexcom is probed, according to the value of the new
"atmel,flexcom-mode" device tree property.
This driver has chosen to present the Flexcom to the system as a MFD so
the implementation is seamless for the existing Atmel SPI, I2C and USART
drivers.
Also the Flexcom embeds FIFOs: the latest patches of the SPI, I2C and
USART drivers take advantage of this new feature.
Signed-off-by: Cyrille Pitchen <cyrille.pitchen@atmel.com>
Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>
Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
---
drivers/mfd/Kconfig | 11 +++++
drivers/mfd/Makefile | 1 +
drivers/mfd/atmel-flexcom.c | 104 ++++++++++++++++++++++++++++++++++++++++++++
3 files changed, 116 insertions(+)
create mode 100644 drivers/mfd/atmel-flexcom.c
diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index 99d63675f073..87e84e7c71da 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -60,6 +60,17 @@ config MFD_AAT2870_CORE
additional drivers must be enabled in order to use the
functionality of the device.
+config MFD_ATMEL_FLEXCOM
+ tristate "Atmel Flexcom (Flexible Serial Communication Unit)"
+ select MFD_CORE
+ depends on OF
+ help
+ Select this to get support for Atmel Flexcom. This is a wrapper
+ which embeds a SPI controller, a I2C controller and a USART. Only
+ one function can be used at a time. The choice is done at boot time
+ by the probe function of this MFD driver according to a device tree
+ property.
+
config MFD_ATMEL_HLCDC
tristate "Atmel HLCDC (High-end LCD Controller)"
select MFD_CORE
diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile
index a59e3fcc8626..f2383e0d1760 100644
--- a/drivers/mfd/Makefile
+++ b/drivers/mfd/Makefile
@@ -164,6 +164,7 @@ obj-$(CONFIG_MFD_SPMI_PMIC) += qcom-spmi-pmic.o
obj-$(CONFIG_TPS65911_COMPARATOR) += tps65911-comparator.o
obj-$(CONFIG_MFD_TPS65090) += tps65090.o
obj-$(CONFIG_MFD_AAT2870_CORE) += aat2870-core.o
+obj-$(CONFIG_MFD_ATMEL_FLEXCOM) += atmel-flexcom.o
obj-$(CONFIG_MFD_ATMEL_HLCDC) += atmel-hlcdc.o
obj-$(CONFIG_MFD_INTEL_LPSS) += intel-lpss.o
obj-$(CONFIG_MFD_INTEL_LPSS_PCI) += intel-lpss-pci.o
diff --git a/drivers/mfd/atmel-flexcom.c b/drivers/mfd/atmel-flexcom.c
new file mode 100644
index 000000000000..e8e67be6b493
--- /dev/null
+++ b/drivers/mfd/atmel-flexcom.c
@@ -0,0 +1,104 @@
+/*
+ * Driver for Atmel Flexcom
+ *
+ * Copyright (C) 2015 Atmel Corporation
+ *
+ * Author: Cyrille Pitchen <cyrille.pitchen@atmel.com>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
+ * more details.
+ *
+ * You should have received a copy of the GNU General Public License along with
+ * this program. If not, see <http://www.gnu.org/licenses/>.
+ */
+
+#include <linux/module.h>
+#include <linux/types.h>
+#include <linux/kernel.h>
+#include <linux/platform_device.h>
+#include <linux/of.h>
+#include <linux/of_platform.h>
+#include <linux/err.h>
+#include <linux/io.h>
+#include <linux/clk.h>
+#include <dt-bindings/mfd/atmel-flexcom.h>
+
+/* I/O register offsets */
+#define FLEX_MR 0x0 /* Mode Register */
+#define FLEX_VERSION 0xfc /* Version Register */
+
+/* Mode Register bit fields */
+#define FLEX_MR_OPMODE_OFFSET (0) /* Operating Mode */
+#define FLEX_MR_OPMODE_MASK (0x3 << FLEX_MR_OPMODE_OFFSET)
+#define FLEX_MR_OPMODE(opmode) (((opmode) << FLEX_MR_OPMODE_OFFSET) & \
+ FLEX_MR_OPMODE_MASK)
+
+
+static int atmel_flexcom_probe(struct platform_device *pdev)
+{
+ struct device_node *np = pdev->dev.of_node;
+ struct clk *clk;
+ struct resource *res;
+ void __iomem *base;
+ u32 opmode;
+ int err;
+
+ err = of_property_read_u32(np, "atmel,flexcom-mode", &opmode);
+ if (err)
+ return err;
+
+ if (opmode < ATMEL_FLEXCOM_MODE_USART ||
+ opmode > ATMEL_FLEXCOM_MODE_TWI)
+ return -EINVAL;
+
+ res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
+ base = devm_ioremap_resource(&pdev->dev, res);
+ if (IS_ERR(base))
+ return PTR_ERR(base);
+
+ clk = devm_clk_get(&pdev->dev, NULL);
+ if (IS_ERR(clk))
+ return PTR_ERR(clk);
+
+ err = clk_prepare_enable(clk);
+ if (err)
+ return err;
+
+ /*
+ * Set the Operating Mode in the Mode Register: only the selected device
+ * is clocked. Hence, registers of the other serial devices remain
+ * inaccessible and are read as zero. Also the external I/O lines of the
+ * Flexcom are muxed to reach the selected device.
+ */
+ writel(FLEX_MR_OPMODE(opmode), base + FLEX_MR);
+
+ clk_disable_unprepare(clk);
+
+ return of_platform_populate(np, NULL, NULL, &pdev->dev);
+}
+
+static const struct of_device_id atmel_flexcom_of_match[] = {
+ { .compatible = "atmel,sama5d2-flexcom" },
+ { /* sentinel */ }
+};
+MODULE_DEVICE_TABLE(of, atmel_flexcom_of_match);
+
+static struct platform_driver atmel_flexcom_driver = {
+ .probe = atmel_flexcom_probe,
+ .driver = {
+ .name = "atmel_flexcom",
+ .of_match_table = atmel_flexcom_of_match,
+ },
+};
+
+module_platform_driver(atmel_flexcom_driver);
+
+MODULE_AUTHOR("Cyrille Pitchen <cyrille.pitchen@atmel.com>");
+MODULE_DESCRIPTION("Atmel Flexcom MFD driver");
+MODULE_LICENSE("GPL v2");
--
1.8.2.2
^ permalink raw reply related [flat|nested] 45+ messages in thread
* Re: [PATCH linux-next v9 0/3] mfd: flexcom: add a driver for Flexcom
@ 2015-09-08 16:04 ` Cyrille Pitchen
0 siblings, 0 replies; 45+ messages in thread
From: Cyrille Pitchen @ 2015-09-08 16:04 UTC (permalink / raw)
To: nicolas.ferre, boris.brezillon, alexandre.belloni, sameo, lee.jones
Cc: linux-arm-kernel, linux-kernel, robh+dt, pawel.moll,
mark.rutland, ijc+devicetree, galak, devicetree
Hi all,
Le 01/09/2015 16:46, Cyrille Pitchen a écrit :
> ChangeLog
>
> v9:
> - go back to v5 (use the new "atmel,flexcom-mode" DT property).
> - fix the name of the spi node in the DT example: from spi@f8034400 to
> spi@400
> - align the fields of the struct platform_driver atmel_flexcom_driver as
> suggested by Lee Jones.
>
[...]
Are there any remaining blocking points for this series ?
Best Regards,
Cyrille
^ permalink raw reply [flat|nested] 45+ messages in thread
* [PATCH linux-next v9 0/3] mfd: flexcom: add a driver for Flexcom
@ 2015-09-08 16:04 ` Cyrille Pitchen
0 siblings, 0 replies; 45+ messages in thread
From: Cyrille Pitchen @ 2015-09-08 16:04 UTC (permalink / raw)
To: linux-arm-kernel
Hi all,
Le 01/09/2015 16:46, Cyrille Pitchen a ?crit :
> ChangeLog
>
> v9:
> - go back to v5 (use the new "atmel,flexcom-mode" DT property).
> - fix the name of the spi node in the DT example: from spi at f8034400 to
> spi at 400
> - align the fields of the struct platform_driver atmel_flexcom_driver as
> suggested by Lee Jones.
>
[...]
Are there any remaining blocking points for this series ?
Best Regards,
Cyrille
^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH linux-next v9 0/3] mfd: flexcom: add a driver for Flexcom
@ 2015-09-08 16:04 ` Cyrille Pitchen
0 siblings, 0 replies; 45+ messages in thread
From: Cyrille Pitchen @ 2015-09-08 16:04 UTC (permalink / raw)
To: nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w,
boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8,
alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8,
sameo-VuQAYsv1563Yd54FQh9/CA, lee.jones-QSEj5FYQhm4dnm+yROfE0A
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A, pawel.moll-5wv7dgnIgG8,
mark.rutland-5wv7dgnIgG8, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg,
galak-sgV2jX0FEOL9JmXXK+q4OQ, devicetree-u79uwXL29TY76Z2rM5mHXA
Hi all,
Le 01/09/2015 16:46, Cyrille Pitchen a écrit :
> ChangeLog
>
> v9:
> - go back to v5 (use the new "atmel,flexcom-mode" DT property).
> - fix the name of the spi node in the DT example: from spi@f8034400 to
> spi@400
> - align the fields of the struct platform_driver atmel_flexcom_driver as
> suggested by Lee Jones.
>
[...]
Are there any remaining blocking points for this series ?
Best Regards,
Cyrille
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH linux-next v9 0/3] mfd: flexcom: add a driver for Flexcom
2015-09-08 16:04 ` Cyrille Pitchen
@ 2015-09-08 16:26 ` Lee Jones
-1 siblings, 0 replies; 45+ messages in thread
From: Lee Jones @ 2015-09-08 16:26 UTC (permalink / raw)
To: Cyrille Pitchen
Cc: nicolas.ferre, boris.brezillon, alexandre.belloni, sameo,
linux-arm-kernel, linux-kernel, robh+dt, pawel.moll,
mark.rutland, ijc+devicetree, galak, devicetree
On Tue, 08 Sep 2015, Cyrille Pitchen wrote:
> Hi all,
>
> Le 01/09/2015 16:46, Cyrille Pitchen a écrit :
> > ChangeLog
> >
> > v9:
> > - go back to v5 (use the new "atmel,flexcom-mode" DT property).
> > - fix the name of the spi node in the DT example: from spi@f8034400 to
> > spi@400
> > - align the fields of the struct platform_driver atmel_flexcom_driver as
> > suggested by Lee Jones.
> >
> [...]
>
> Are there any remaining blocking points for this series ?
Yes. The merge window is open, so it's Maintainer sleepy time [0].
Will get back to reviewing next week probably.
[0] AKA: Breath out and catch up with real-work for a bit.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 45+ messages in thread
* [PATCH linux-next v9 0/3] mfd: flexcom: add a driver for Flexcom
@ 2015-09-08 16:26 ` Lee Jones
0 siblings, 0 replies; 45+ messages in thread
From: Lee Jones @ 2015-09-08 16:26 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, 08 Sep 2015, Cyrille Pitchen wrote:
> Hi all,
>
> Le 01/09/2015 16:46, Cyrille Pitchen a ?crit :
> > ChangeLog
> >
> > v9:
> > - go back to v5 (use the new "atmel,flexcom-mode" DT property).
> > - fix the name of the spi node in the DT example: from spi at f8034400 to
> > spi at 400
> > - align the fields of the struct platform_driver atmel_flexcom_driver as
> > suggested by Lee Jones.
> >
> [...]
>
> Are there any remaining blocking points for this series ?
Yes. The merge window is open, so it's Maintainer sleepy time [0].
Will get back to reviewing next week probably.
[0] AKA: Breath out and catch up with real-work for a bit.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH linux-next v9 0/3] mfd: flexcom: add a driver for Flexcom
2015-09-01 14:46 ` Cyrille Pitchen
@ 2015-09-20 4:19 ` Lee Jones
-1 siblings, 0 replies; 45+ messages in thread
From: Lee Jones @ 2015-09-20 4:19 UTC (permalink / raw)
To: Cyrille Pitchen
Cc: nicolas.ferre, boris.brezillon, alexandre.belloni, sameo,
linux-arm-kernel, linux-kernel, robh+dt, pawel.moll,
mark.rutland, ijc+devicetree, galak, devicetree
Patch set description?
Once Rob is satisfied, please re-submit this set with Nicolas' Acks
and I will re-review.
> ChangeLog
>
> v9:
> - go back to v5 (use the new "atmel,flexcom-mode" DT property).
> - fix the name of the spi node in the DT example: from spi@f8034400 to
> spi@400
> - align the fields of the struct platform_driver atmel_flexcom_driver as
> suggested by Lee Jones.
>
> v8:
> - fix the name of the spi node in the DT example: from spi@f8034400 to
> spi@2,0
> - use the return code of op_property_read_u32_index() instead of -EINVAL
> to report error.
> - add Acked-by from Nicolas Ferre
>
> v7:
> - read the operating mode from the very first u32 of the reg property from
> the first available child node (should be unique).
> - update the DT bindings documentation accordingly.
>
> v6:
> - select the operating mode according to the "compatible" DT property of
> the first available child node (should be unique).
> - remove the "atmel,flexcom-mode" DT property so the need of a header file
> defining macros for the possible values of this deprecated property.
>
> v5:
> - create a header file containing macros used by DT bindings
> - use numeric constants instead of strings to select the Flexcom mode
> - change the license to "GPL v2"
> - update the DT binding documentation to make it more readable and add
> references to USART, SPI and I2C DT binding documentations. remove the
> useless label in the Example section.
> - change the register prefix from FX_ to FLEX_ to match the Flexcom
> programmer datasheet.
> - rename some variables to make them more understandable.
>
> v4:
> - check clk_prepare_enable() return code in atmel_flexcom_probe()
> - add a commit message to the DT binding patch
>
> v3:
> - remove MODULE_ALIAS()
> - add Acked-by from Boris Brezillon and Alexandre Belloni
>
> v2:
> - enhance the documentation of DT bindings and change the way the "ranges"
> property is used.
> - replace __raw_readl() and __raw_writel() by readl() and writel().
> - change the module license to "GPL" for v2 or later
> - print the selected flexcom mode after the hardware version
>
> v1:
> This series of patches a support to the Atmel Flexcom, a wrapper which
> integrates an USART, a SPI controller and a TWI controller. Only one
> peripheral can be used at a time. The active function is selected though
> the Flexcom Mode Register.
>
> Cyrille Pitchen (3):
> mfd: atmel-flexcom: create include file with macros used by DT
> bindings
> mfd: devicetree: add bindings for Atmel Flexcom
> mfd: atmel-flexcom: add a driver for Atmel Flexible Serial
> Communication Unit
>
> .../devicetree/bindings/mfd/atmel-flexcom.txt | 67 +++++++++++++
> drivers/mfd/Kconfig | 11 +++
> drivers/mfd/Makefile | 1 +
> drivers/mfd/atmel-flexcom.c | 104 +++++++++++++++++++++
> include/dt-bindings/mfd/atmel-flexcom.h | 16 ++++
> 5 files changed, 199 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mfd/atmel-flexcom.txt
> create mode 100644 drivers/mfd/atmel-flexcom.c
> create mode 100644 include/dt-bindings/mfd/atmel-flexcom.h
>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 45+ messages in thread
* [PATCH linux-next v9 0/3] mfd: flexcom: add a driver for Flexcom
@ 2015-09-20 4:19 ` Lee Jones
0 siblings, 0 replies; 45+ messages in thread
From: Lee Jones @ 2015-09-20 4:19 UTC (permalink / raw)
To: linux-arm-kernel
Patch set description?
Once Rob is satisfied, please re-submit this set with Nicolas' Acks
and I will re-review.
> ChangeLog
>
> v9:
> - go back to v5 (use the new "atmel,flexcom-mode" DT property).
> - fix the name of the spi node in the DT example: from spi at f8034400 to
> spi at 400
> - align the fields of the struct platform_driver atmel_flexcom_driver as
> suggested by Lee Jones.
>
> v8:
> - fix the name of the spi node in the DT example: from spi at f8034400 to
> spi at 2,0
> - use the return code of op_property_read_u32_index() instead of -EINVAL
> to report error.
> - add Acked-by from Nicolas Ferre
>
> v7:
> - read the operating mode from the very first u32 of the reg property from
> the first available child node (should be unique).
> - update the DT bindings documentation accordingly.
>
> v6:
> - select the operating mode according to the "compatible" DT property of
> the first available child node (should be unique).
> - remove the "atmel,flexcom-mode" DT property so the need of a header file
> defining macros for the possible values of this deprecated property.
>
> v5:
> - create a header file containing macros used by DT bindings
> - use numeric constants instead of strings to select the Flexcom mode
> - change the license to "GPL v2"
> - update the DT binding documentation to make it more readable and add
> references to USART, SPI and I2C DT binding documentations. remove the
> useless label in the Example section.
> - change the register prefix from FX_ to FLEX_ to match the Flexcom
> programmer datasheet.
> - rename some variables to make them more understandable.
>
> v4:
> - check clk_prepare_enable() return code in atmel_flexcom_probe()
> - add a commit message to the DT binding patch
>
> v3:
> - remove MODULE_ALIAS()
> - add Acked-by from Boris Brezillon and Alexandre Belloni
>
> v2:
> - enhance the documentation of DT bindings and change the way the "ranges"
> property is used.
> - replace __raw_readl() and __raw_writel() by readl() and writel().
> - change the module license to "GPL" for v2 or later
> - print the selected flexcom mode after the hardware version
>
> v1:
> This series of patches a support to the Atmel Flexcom, a wrapper which
> integrates an USART, a SPI controller and a TWI controller. Only one
> peripheral can be used at a time. The active function is selected though
> the Flexcom Mode Register.
>
> Cyrille Pitchen (3):
> mfd: atmel-flexcom: create include file with macros used by DT
> bindings
> mfd: devicetree: add bindings for Atmel Flexcom
> mfd: atmel-flexcom: add a driver for Atmel Flexible Serial
> Communication Unit
>
> .../devicetree/bindings/mfd/atmel-flexcom.txt | 67 +++++++++++++
> drivers/mfd/Kconfig | 11 +++
> drivers/mfd/Makefile | 1 +
> drivers/mfd/atmel-flexcom.c | 104 +++++++++++++++++++++
> include/dt-bindings/mfd/atmel-flexcom.h | 16 ++++
> 5 files changed, 199 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mfd/atmel-flexcom.txt
> create mode 100644 drivers/mfd/atmel-flexcom.c
> create mode 100644 include/dt-bindings/mfd/atmel-flexcom.h
>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH linux-next v9 0/3] mfd: flexcom: add a driver for Flexcom
2015-09-20 4:19 ` Lee Jones
(?)
@ 2015-09-23 10:29 ` Nicolas Ferre
-1 siblings, 0 replies; 45+ messages in thread
From: Nicolas Ferre @ 2015-09-23 10:29 UTC (permalink / raw)
To: Lee Jones, Cyrille Pitchen, robh+dt, Samuel Ortiz
Cc: boris.brezillon, alexandre.belloni, sameo, linux-arm-kernel,
linux-kernel, pawel.moll, mark.rutland, ijc+devicetree, galak,
devicetree
Le 20/09/2015 06:19, Lee Jones a écrit :
> Patch set description?
Cyrille actually placed it as the v1 changelog below...
> Once Rob is satisfied, please re-submit this set with Nicolas' Acks
I think that Rob was okay with the DT binding: "A few comments, but in
general looks fine." and it may not be important to tack Rob for
addition of his formal tag...
Or maybe this message can act as a "ping" for Rob...
> and I will re-review.
We wait one or two days before Cyrille re-send the series. We are
looking forward to using this driver in Linux-next soon.
Bye,
>> ChangeLog
>>
>> v9:
>> - go back to v5 (use the new "atmel,flexcom-mode" DT property).
>> - fix the name of the spi node in the DT example: from spi@f8034400 to
>> spi@400
>> - align the fields of the struct platform_driver atmel_flexcom_driver as
>> suggested by Lee Jones.
>>
>> v8:
>> - fix the name of the spi node in the DT example: from spi@f8034400 to
>> spi@2,0
>> - use the return code of op_property_read_u32_index() instead of -EINVAL
>> to report error.
>> - add Acked-by from Nicolas Ferre
>>
>> v7:
>> - read the operating mode from the very first u32 of the reg property from
>> the first available child node (should be unique).
>> - update the DT bindings documentation accordingly.
>>
>> v6:
>> - select the operating mode according to the "compatible" DT property of
>> the first available child node (should be unique).
>> - remove the "atmel,flexcom-mode" DT property so the need of a header file
>> defining macros for the possible values of this deprecated property.
>>
>> v5:
>> - create a header file containing macros used by DT bindings
>> - use numeric constants instead of strings to select the Flexcom mode
>> - change the license to "GPL v2"
>> - update the DT binding documentation to make it more readable and add
>> references to USART, SPI and I2C DT binding documentations. remove the
>> useless label in the Example section.
>> - change the register prefix from FX_ to FLEX_ to match the Flexcom
>> programmer datasheet.
>> - rename some variables to make them more understandable.
>>
>> v4:
>> - check clk_prepare_enable() return code in atmel_flexcom_probe()
>> - add a commit message to the DT binding patch
>>
>> v3:
>> - remove MODULE_ALIAS()
>> - add Acked-by from Boris Brezillon and Alexandre Belloni
>>
>> v2:
>> - enhance the documentation of DT bindings and change the way the "ranges"
>> property is used.
>> - replace __raw_readl() and __raw_writel() by readl() and writel().
>> - change the module license to "GPL" for v2 or later
>> - print the selected flexcom mode after the hardware version
>>
>> v1:
>> This series of patches a support to the Atmel Flexcom, a wrapper which
>> integrates an USART, a SPI controller and a TWI controller. Only one
>> peripheral can be used at a time. The active function is selected though
>> the Flexcom Mode Register.
>>
>> Cyrille Pitchen (3):
>> mfd: atmel-flexcom: create include file with macros used by DT
>> bindings
>> mfd: devicetree: add bindings for Atmel Flexcom
>> mfd: atmel-flexcom: add a driver for Atmel Flexible Serial
>> Communication Unit
>>
>> .../devicetree/bindings/mfd/atmel-flexcom.txt | 67 +++++++++++++
>> drivers/mfd/Kconfig | 11 +++
>> drivers/mfd/Makefile | 1 +
>> drivers/mfd/atmel-flexcom.c | 104 +++++++++++++++++++++
>> include/dt-bindings/mfd/atmel-flexcom.h | 16 ++++
>> 5 files changed, 199 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/mfd/atmel-flexcom.txt
>> create mode 100644 drivers/mfd/atmel-flexcom.c
>> create mode 100644 include/dt-bindings/mfd/atmel-flexcom.h
>>
>
--
Nicolas Ferre
^ permalink raw reply [flat|nested] 45+ messages in thread
* [PATCH linux-next v9 0/3] mfd: flexcom: add a driver for Flexcom
@ 2015-09-23 10:29 ` Nicolas Ferre
0 siblings, 0 replies; 45+ messages in thread
From: Nicolas Ferre @ 2015-09-23 10:29 UTC (permalink / raw)
To: linux-arm-kernel
Le 20/09/2015 06:19, Lee Jones a ?crit :
> Patch set description?
Cyrille actually placed it as the v1 changelog below...
> Once Rob is satisfied, please re-submit this set with Nicolas' Acks
I think that Rob was okay with the DT binding: "A few comments, but in
general looks fine." and it may not be important to tack Rob for
addition of his formal tag...
Or maybe this message can act as a "ping" for Rob...
> and I will re-review.
We wait one or two days before Cyrille re-send the series. We are
looking forward to using this driver in Linux-next soon.
Bye,
>> ChangeLog
>>
>> v9:
>> - go back to v5 (use the new "atmel,flexcom-mode" DT property).
>> - fix the name of the spi node in the DT example: from spi at f8034400 to
>> spi at 400
>> - align the fields of the struct platform_driver atmel_flexcom_driver as
>> suggested by Lee Jones.
>>
>> v8:
>> - fix the name of the spi node in the DT example: from spi at f8034400 to
>> spi at 2,0
>> - use the return code of op_property_read_u32_index() instead of -EINVAL
>> to report error.
>> - add Acked-by from Nicolas Ferre
>>
>> v7:
>> - read the operating mode from the very first u32 of the reg property from
>> the first available child node (should be unique).
>> - update the DT bindings documentation accordingly.
>>
>> v6:
>> - select the operating mode according to the "compatible" DT property of
>> the first available child node (should be unique).
>> - remove the "atmel,flexcom-mode" DT property so the need of a header file
>> defining macros for the possible values of this deprecated property.
>>
>> v5:
>> - create a header file containing macros used by DT bindings
>> - use numeric constants instead of strings to select the Flexcom mode
>> - change the license to "GPL v2"
>> - update the DT binding documentation to make it more readable and add
>> references to USART, SPI and I2C DT binding documentations. remove the
>> useless label in the Example section.
>> - change the register prefix from FX_ to FLEX_ to match the Flexcom
>> programmer datasheet.
>> - rename some variables to make them more understandable.
>>
>> v4:
>> - check clk_prepare_enable() return code in atmel_flexcom_probe()
>> - add a commit message to the DT binding patch
>>
>> v3:
>> - remove MODULE_ALIAS()
>> - add Acked-by from Boris Brezillon and Alexandre Belloni
>>
>> v2:
>> - enhance the documentation of DT bindings and change the way the "ranges"
>> property is used.
>> - replace __raw_readl() and __raw_writel() by readl() and writel().
>> - change the module license to "GPL" for v2 or later
>> - print the selected flexcom mode after the hardware version
>>
>> v1:
>> This series of patches a support to the Atmel Flexcom, a wrapper which
>> integrates an USART, a SPI controller and a TWI controller. Only one
>> peripheral can be used at a time. The active function is selected though
>> the Flexcom Mode Register.
>>
>> Cyrille Pitchen (3):
>> mfd: atmel-flexcom: create include file with macros used by DT
>> bindings
>> mfd: devicetree: add bindings for Atmel Flexcom
>> mfd: atmel-flexcom: add a driver for Atmel Flexible Serial
>> Communication Unit
>>
>> .../devicetree/bindings/mfd/atmel-flexcom.txt | 67 +++++++++++++
>> drivers/mfd/Kconfig | 11 +++
>> drivers/mfd/Makefile | 1 +
>> drivers/mfd/atmel-flexcom.c | 104 +++++++++++++++++++++
>> include/dt-bindings/mfd/atmel-flexcom.h | 16 ++++
>> 5 files changed, 199 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/mfd/atmel-flexcom.txt
>> create mode 100644 drivers/mfd/atmel-flexcom.c
>> create mode 100644 include/dt-bindings/mfd/atmel-flexcom.h
>>
>
--
Nicolas Ferre
^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH linux-next v9 0/3] mfd: flexcom: add a driver for Flexcom
@ 2015-09-23 10:29 ` Nicolas Ferre
0 siblings, 0 replies; 45+ messages in thread
From: Nicolas Ferre @ 2015-09-23 10:29 UTC (permalink / raw)
To: Lee Jones, Cyrille Pitchen, robh+dt
Cc: boris.brezillon, alexandre.belloni, sameo, linux-arm-kernel,
linux-kernel, pawel.moll, mark.rutland, ijc+devicetree, galak,
devicetree
Le 20/09/2015 06:19, Lee Jones a écrit :
> Patch set description?
Cyrille actually placed it as the v1 changelog below...
> Once Rob is satisfied, please re-submit this set with Nicolas' Acks
I think that Rob was okay with the DT binding: "A few comments, but in
general looks fine." and it may not be important to tack Rob for
addition of his formal tag...
Or maybe this message can act as a "ping" for Rob...
> and I will re-review.
We wait one or two days before Cyrille re-send the series. We are
looking forward to using this driver in Linux-next soon.
Bye,
>> ChangeLog
>>
>> v9:
>> - go back to v5 (use the new "atmel,flexcom-mode" DT property).
>> - fix the name of the spi node in the DT example: from spi@f8034400 to
>> spi@400
>> - align the fields of the struct platform_driver atmel_flexcom_driver as
>> suggested by Lee Jones.
>>
>> v8:
>> - fix the name of the spi node in the DT example: from spi@f8034400 to
>> spi@2,0
>> - use the return code of op_property_read_u32_index() instead of -EINVAL
>> to report error.
>> - add Acked-by from Nicolas Ferre
>>
>> v7:
>> - read the operating mode from the very first u32 of the reg property from
>> the first available child node (should be unique).
>> - update the DT bindings documentation accordingly.
>>
>> v6:
>> - select the operating mode according to the "compatible" DT property of
>> the first available child node (should be unique).
>> - remove the "atmel,flexcom-mode" DT property so the need of a header file
>> defining macros for the possible values of this deprecated property.
>>
>> v5:
>> - create a header file containing macros used by DT bindings
>> - use numeric constants instead of strings to select the Flexcom mode
>> - change the license to "GPL v2"
>> - update the DT binding documentation to make it more readable and add
>> references to USART, SPI and I2C DT binding documentations. remove the
>> useless label in the Example section.
>> - change the register prefix from FX_ to FLEX_ to match the Flexcom
>> programmer datasheet.
>> - rename some variables to make them more understandable.
>>
>> v4:
>> - check clk_prepare_enable() return code in atmel_flexcom_probe()
>> - add a commit message to the DT binding patch
>>
>> v3:
>> - remove MODULE_ALIAS()
>> - add Acked-by from Boris Brezillon and Alexandre Belloni
>>
>> v2:
>> - enhance the documentation of DT bindings and change the way the "ranges"
>> property is used.
>> - replace __raw_readl() and __raw_writel() by readl() and writel().
>> - change the module license to "GPL" for v2 or later
>> - print the selected flexcom mode after the hardware version
>>
>> v1:
>> This series of patches a support to the Atmel Flexcom, a wrapper which
>> integrates an USART, a SPI controller and a TWI controller. Only one
>> peripheral can be used at a time. The active function is selected though
>> the Flexcom Mode Register.
>>
>> Cyrille Pitchen (3):
>> mfd: atmel-flexcom: create include file with macros used by DT
>> bindings
>> mfd: devicetree: add bindings for Atmel Flexcom
>> mfd: atmel-flexcom: add a driver for Atmel Flexible Serial
>> Communication Unit
>>
>> .../devicetree/bindings/mfd/atmel-flexcom.txt | 67 +++++++++++++
>> drivers/mfd/Kconfig | 11 +++
>> drivers/mfd/Makefile | 1 +
>> drivers/mfd/atmel-flexcom.c | 104 +++++++++++++++++++++
>> include/dt-bindings/mfd/atmel-flexcom.h | 16 ++++
>> 5 files changed, 199 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/mfd/atmel-flexcom.txt
>> create mode 100644 drivers/mfd/atmel-flexcom.c
>> create mode 100644 include/dt-bindings/mfd/atmel-flexcom.h
>>
>
--
Nicolas Ferre
^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH linux-next v9 0/3] mfd: flexcom: add a driver for Flexcom
@ 2015-09-24 17:37 ` Lee Jones
0 siblings, 0 replies; 45+ messages in thread
From: Lee Jones @ 2015-09-24 17:37 UTC (permalink / raw)
To: Nicolas Ferre
Cc: Cyrille Pitchen, robh+dt, Samuel Ortiz, boris.brezillon,
alexandre.belloni, linux-arm-kernel, linux-kernel, pawel.moll,
mark.rutland, ijc+devicetree, galak, devicetree
On Wed, 23 Sep 2015, Nicolas Ferre wrote:
> Le 20/09/2015 06:19, Lee Jones a écrit :
> > Patch set description?
>
> Cyrille actually placed it as the v1 changelog below...
I see it now, but that's not a very intuitive way of representing the
set description. Please use the normal format with the description at
the top. Normally all I care about is the description and the latest
changes (although please keep in the previous changelogs, as they can
also prove useful).
> > Once Rob is satisfied, please re-submit this set with Nicolas' Acks
>
> I think that Rob was okay with the DT binding: "A few comments, but in
> general looks fine." and it may not be important to tack Rob for
> addition of his formal tag...
>
> Or maybe this message can act as a "ping" for Rob...
I'm not asking for that, although it's never UNwanted. I'm asking for
the discussion between the submitter and other interested parties to
play out, then adapt and re-submit accordingly. I receive far too
many submissions to keep track of all of the discussions.
> > and I will re-review.
>
> We wait one or two days before Cyrille re-send the series. We are
> looking forward to using this driver in Linux-next soon.
>
> >> ChangeLog
> >>
> >> v9:
> >> - go back to v5 (use the new "atmel,flexcom-mode" DT property).
> >> - fix the name of the spi node in the DT example: from spi@f8034400 to
> >> spi@400
> >> - align the fields of the struct platform_driver atmel_flexcom_driver as
> >> suggested by Lee Jones.
> >>
> >> v8:
> >> - fix the name of the spi node in the DT example: from spi@f8034400 to
> >> spi@2,0
> >> - use the return code of op_property_read_u32_index() instead of -EINVAL
> >> to report error.
> >> - add Acked-by from Nicolas Ferre
> >>
> >> v7:
> >> - read the operating mode from the very first u32 of the reg property from
> >> the first available child node (should be unique).
> >> - update the DT bindings documentation accordingly.
> >>
> >> v6:
> >> - select the operating mode according to the "compatible" DT property of
> >> the first available child node (should be unique).
> >> - remove the "atmel,flexcom-mode" DT property so the need of a header file
> >> defining macros for the possible values of this deprecated property.
> >>
> >> v5:
> >> - create a header file containing macros used by DT bindings
> >> - use numeric constants instead of strings to select the Flexcom mode
> >> - change the license to "GPL v2"
> >> - update the DT binding documentation to make it more readable and add
> >> references to USART, SPI and I2C DT binding documentations. remove the
> >> useless label in the Example section.
> >> - change the register prefix from FX_ to FLEX_ to match the Flexcom
> >> programmer datasheet.
> >> - rename some variables to make them more understandable.
> >>
> >> v4:
> >> - check clk_prepare_enable() return code in atmel_flexcom_probe()
> >> - add a commit message to the DT binding patch
> >>
> >> v3:
> >> - remove MODULE_ALIAS()
> >> - add Acked-by from Boris Brezillon and Alexandre Belloni
> >>
> >> v2:
> >> - enhance the documentation of DT bindings and change the way the "ranges"
> >> property is used.
> >> - replace __raw_readl() and __raw_writel() by readl() and writel().
> >> - change the module license to "GPL" for v2 or later
> >> - print the selected flexcom mode after the hardware version
> >>
> >> v1:
> >> This series of patches a support to the Atmel Flexcom, a wrapper which
> >> integrates an USART, a SPI controller and a TWI controller. Only one
> >> peripheral can be used at a time. The active function is selected though
> >> the Flexcom Mode Register.
> >>
> >> Cyrille Pitchen (3):
> >> mfd: atmel-flexcom: create include file with macros used by DT
> >> bindings
> >> mfd: devicetree: add bindings for Atmel Flexcom
> >> mfd: atmel-flexcom: add a driver for Atmel Flexible Serial
> >> Communication Unit
> >>
> >> .../devicetree/bindings/mfd/atmel-flexcom.txt | 67 +++++++++++++
> >> drivers/mfd/Kconfig | 11 +++
> >> drivers/mfd/Makefile | 1 +
> >> drivers/mfd/atmel-flexcom.c | 104 +++++++++++++++++++++
> >> include/dt-bindings/mfd/atmel-flexcom.h | 16 ++++
> >> 5 files changed, 199 insertions(+)
> >> create mode 100644 Documentation/devicetree/bindings/mfd/atmel-flexcom.txt
> >> create mode 100644 drivers/mfd/atmel-flexcom.c
> >> create mode 100644 include/dt-bindings/mfd/atmel-flexcom.h
> >>
> >
>
>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 45+ messages in thread
* [PATCH linux-next v9 0/3] mfd: flexcom: add a driver for Flexcom
@ 2015-09-24 17:37 ` Lee Jones
0 siblings, 0 replies; 45+ messages in thread
From: Lee Jones @ 2015-09-24 17:37 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, 23 Sep 2015, Nicolas Ferre wrote:
> Le 20/09/2015 06:19, Lee Jones a ?crit :
> > Patch set description?
>
> Cyrille actually placed it as the v1 changelog below...
I see it now, but that's not a very intuitive way of representing the
set description. Please use the normal format with the description at
the top. Normally all I care about is the description and the latest
changes (although please keep in the previous changelogs, as they can
also prove useful).
> > Once Rob is satisfied, please re-submit this set with Nicolas' Acks
>
> I think that Rob was okay with the DT binding: "A few comments, but in
> general looks fine." and it may not be important to tack Rob for
> addition of his formal tag...
>
> Or maybe this message can act as a "ping" for Rob...
I'm not asking for that, although it's never UNwanted. I'm asking for
the discussion between the submitter and other interested parties to
play out, then adapt and re-submit accordingly. I receive far too
many submissions to keep track of all of the discussions.
> > and I will re-review.
>
> We wait one or two days before Cyrille re-send the series. We are
> looking forward to using this driver in Linux-next soon.
>
> >> ChangeLog
> >>
> >> v9:
> >> - go back to v5 (use the new "atmel,flexcom-mode" DT property).
> >> - fix the name of the spi node in the DT example: from spi at f8034400 to
> >> spi at 400
> >> - align the fields of the struct platform_driver atmel_flexcom_driver as
> >> suggested by Lee Jones.
> >>
> >> v8:
> >> - fix the name of the spi node in the DT example: from spi at f8034400 to
> >> spi at 2,0
> >> - use the return code of op_property_read_u32_index() instead of -EINVAL
> >> to report error.
> >> - add Acked-by from Nicolas Ferre
> >>
> >> v7:
> >> - read the operating mode from the very first u32 of the reg property from
> >> the first available child node (should be unique).
> >> - update the DT bindings documentation accordingly.
> >>
> >> v6:
> >> - select the operating mode according to the "compatible" DT property of
> >> the first available child node (should be unique).
> >> - remove the "atmel,flexcom-mode" DT property so the need of a header file
> >> defining macros for the possible values of this deprecated property.
> >>
> >> v5:
> >> - create a header file containing macros used by DT bindings
> >> - use numeric constants instead of strings to select the Flexcom mode
> >> - change the license to "GPL v2"
> >> - update the DT binding documentation to make it more readable and add
> >> references to USART, SPI and I2C DT binding documentations. remove the
> >> useless label in the Example section.
> >> - change the register prefix from FX_ to FLEX_ to match the Flexcom
> >> programmer datasheet.
> >> - rename some variables to make them more understandable.
> >>
> >> v4:
> >> - check clk_prepare_enable() return code in atmel_flexcom_probe()
> >> - add a commit message to the DT binding patch
> >>
> >> v3:
> >> - remove MODULE_ALIAS()
> >> - add Acked-by from Boris Brezillon and Alexandre Belloni
> >>
> >> v2:
> >> - enhance the documentation of DT bindings and change the way the "ranges"
> >> property is used.
> >> - replace __raw_readl() and __raw_writel() by readl() and writel().
> >> - change the module license to "GPL" for v2 or later
> >> - print the selected flexcom mode after the hardware version
> >>
> >> v1:
> >> This series of patches a support to the Atmel Flexcom, a wrapper which
> >> integrates an USART, a SPI controller and a TWI controller. Only one
> >> peripheral can be used at a time. The active function is selected though
> >> the Flexcom Mode Register.
> >>
> >> Cyrille Pitchen (3):
> >> mfd: atmel-flexcom: create include file with macros used by DT
> >> bindings
> >> mfd: devicetree: add bindings for Atmel Flexcom
> >> mfd: atmel-flexcom: add a driver for Atmel Flexible Serial
> >> Communication Unit
> >>
> >> .../devicetree/bindings/mfd/atmel-flexcom.txt | 67 +++++++++++++
> >> drivers/mfd/Kconfig | 11 +++
> >> drivers/mfd/Makefile | 1 +
> >> drivers/mfd/atmel-flexcom.c | 104 +++++++++++++++++++++
> >> include/dt-bindings/mfd/atmel-flexcom.h | 16 ++++
> >> 5 files changed, 199 insertions(+)
> >> create mode 100644 Documentation/devicetree/bindings/mfd/atmel-flexcom.txt
> >> create mode 100644 drivers/mfd/atmel-flexcom.c
> >> create mode 100644 include/dt-bindings/mfd/atmel-flexcom.h
> >>
> >
>
>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH linux-next v9 0/3] mfd: flexcom: add a driver for Flexcom
@ 2015-09-24 17:37 ` Lee Jones
0 siblings, 0 replies; 45+ messages in thread
From: Lee Jones @ 2015-09-24 17:37 UTC (permalink / raw)
To: Nicolas Ferre
Cc: Cyrille Pitchen, robh+dt-DgEjT+Ai2ygdnm+yROfE0A, Samuel Ortiz,
boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8,
alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, pawel.moll-5wv7dgnIgG8,
mark.rutland-5wv7dgnIgG8, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg,
galak-sgV2jX0FEOL9JmXXK+q4OQ, devicetree-u79uwXL29TY76Z2rM5mHXA
On Wed, 23 Sep 2015, Nicolas Ferre wrote:
> Le 20/09/2015 06:19, Lee Jones a écrit :
> > Patch set description?
>
> Cyrille actually placed it as the v1 changelog below...
I see it now, but that's not a very intuitive way of representing the
set description. Please use the normal format with the description at
the top. Normally all I care about is the description and the latest
changes (although please keep in the previous changelogs, as they can
also prove useful).
> > Once Rob is satisfied, please re-submit this set with Nicolas' Acks
>
> I think that Rob was okay with the DT binding: "A few comments, but in
> general looks fine." and it may not be important to tack Rob for
> addition of his formal tag...
>
> Or maybe this message can act as a "ping" for Rob...
I'm not asking for that, although it's never UNwanted. I'm asking for
the discussion between the submitter and other interested parties to
play out, then adapt and re-submit accordingly. I receive far too
many submissions to keep track of all of the discussions.
> > and I will re-review.
>
> We wait one or two days before Cyrille re-send the series. We are
> looking forward to using this driver in Linux-next soon.
>
> >> ChangeLog
> >>
> >> v9:
> >> - go back to v5 (use the new "atmel,flexcom-mode" DT property).
> >> - fix the name of the spi node in the DT example: from spi@f8034400 to
> >> spi@400
> >> - align the fields of the struct platform_driver atmel_flexcom_driver as
> >> suggested by Lee Jones.
> >>
> >> v8:
> >> - fix the name of the spi node in the DT example: from spi@f8034400 to
> >> spi@2,0
> >> - use the return code of op_property_read_u32_index() instead of -EINVAL
> >> to report error.
> >> - add Acked-by from Nicolas Ferre
> >>
> >> v7:
> >> - read the operating mode from the very first u32 of the reg property from
> >> the first available child node (should be unique).
> >> - update the DT bindings documentation accordingly.
> >>
> >> v6:
> >> - select the operating mode according to the "compatible" DT property of
> >> the first available child node (should be unique).
> >> - remove the "atmel,flexcom-mode" DT property so the need of a header file
> >> defining macros for the possible values of this deprecated property.
> >>
> >> v5:
> >> - create a header file containing macros used by DT bindings
> >> - use numeric constants instead of strings to select the Flexcom mode
> >> - change the license to "GPL v2"
> >> - update the DT binding documentation to make it more readable and add
> >> references to USART, SPI and I2C DT binding documentations. remove the
> >> useless label in the Example section.
> >> - change the register prefix from FX_ to FLEX_ to match the Flexcom
> >> programmer datasheet.
> >> - rename some variables to make them more understandable.
> >>
> >> v4:
> >> - check clk_prepare_enable() return code in atmel_flexcom_probe()
> >> - add a commit message to the DT binding patch
> >>
> >> v3:
> >> - remove MODULE_ALIAS()
> >> - add Acked-by from Boris Brezillon and Alexandre Belloni
> >>
> >> v2:
> >> - enhance the documentation of DT bindings and change the way the "ranges"
> >> property is used.
> >> - replace __raw_readl() and __raw_writel() by readl() and writel().
> >> - change the module license to "GPL" for v2 or later
> >> - print the selected flexcom mode after the hardware version
> >>
> >> v1:
> >> This series of patches a support to the Atmel Flexcom, a wrapper which
> >> integrates an USART, a SPI controller and a TWI controller. Only one
> >> peripheral can be used at a time. The active function is selected though
> >> the Flexcom Mode Register.
> >>
> >> Cyrille Pitchen (3):
> >> mfd: atmel-flexcom: create include file with macros used by DT
> >> bindings
> >> mfd: devicetree: add bindings for Atmel Flexcom
> >> mfd: atmel-flexcom: add a driver for Atmel Flexible Serial
> >> Communication Unit
> >>
> >> .../devicetree/bindings/mfd/atmel-flexcom.txt | 67 +++++++++++++
> >> drivers/mfd/Kconfig | 11 +++
> >> drivers/mfd/Makefile | 1 +
> >> drivers/mfd/atmel-flexcom.c | 104 +++++++++++++++++++++
> >> include/dt-bindings/mfd/atmel-flexcom.h | 16 ++++
> >> 5 files changed, 199 insertions(+)
> >> create mode 100644 Documentation/devicetree/bindings/mfd/atmel-flexcom.txt
> >> create mode 100644 drivers/mfd/atmel-flexcom.c
> >> create mode 100644 include/dt-bindings/mfd/atmel-flexcom.h
> >>
> >
>
>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 45+ messages in thread