All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ARM: OMAP: Remove duplicated operand in OR operation
@ 2015-09-17 13:22 Javier Martinez Canillas
  2015-09-21  7:28   ` Roger Quadros
  0 siblings, 1 reply; 4+ messages in thread
From: Javier Martinez Canillas @ 2015-09-17 13:22 UTC (permalink / raw)
  To: linux-kernel
  Cc: Paul Walmsley, linux-omap, Tony Lindgren, Roger Quadros,
	Javier Martinez Canillas

Commit b483a4a5a711 ("ARM: OMAP4+: hwmod data: Don't prevent RESET of
USB Host module") added the SYSC_HAS_RESET_STATUS flag to both OMAP4
and OMAP5 USB host module hwmon sysconfig but that flag was already
set for OMAP5. So now the flag appears twice in the expression.

make coccicheck complains with the following message:

omap_hwmod_54xx_data.c:1846:37-58: duplicated argument to & or |

Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>

---

 arch/arm/mach-omap2/omap_hwmod_54xx_data.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/arm/mach-omap2/omap_hwmod_54xx_data.c b/arch/arm/mach-omap2/omap_hwmod_54xx_data.c
index 7c3fac035e93..8cdfd9b7ab4f 100644
--- a/arch/arm/mach-omap2/omap_hwmod_54xx_data.c
+++ b/arch/arm/mach-omap2/omap_hwmod_54xx_data.c
@@ -1844,8 +1844,7 @@ static struct omap_hwmod_class_sysconfig omap54xx_usb_host_hs_sysc = {
 	.rev_offs	= 0x0000,
 	.sysc_offs	= 0x0010,
 	.sysc_flags	= (SYSC_HAS_MIDLEMODE | SYSC_HAS_RESET_STATUS |
-			   SYSC_HAS_SIDLEMODE | SYSC_HAS_SOFTRESET |
-			   SYSC_HAS_RESET_STATUS),
+			   SYSC_HAS_SIDLEMODE | SYSC_HAS_SOFTRESET),
 	.idlemodes	= (SIDLE_FORCE | SIDLE_NO | SIDLE_SMART |
 			   SIDLE_SMART_WKUP | MSTANDBY_FORCE | MSTANDBY_NO |
 			   MSTANDBY_SMART | MSTANDBY_SMART_WKUP),
-- 
2.4.3


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: OMAP: Remove duplicated operand in OR operation
  2015-09-17 13:22 [PATCH] ARM: OMAP: Remove duplicated operand in OR operation Javier Martinez Canillas
@ 2015-09-21  7:28   ` Roger Quadros
  0 siblings, 0 replies; 4+ messages in thread
From: Roger Quadros @ 2015-09-21  7:28 UTC (permalink / raw)
  To: Javier Martinez Canillas, linux-kernel
  Cc: Paul Walmsley, linux-omap, Tony Lindgren

On 17/09/15 16:22, Javier Martinez Canillas wrote:
> Commit b483a4a5a711 ("ARM: OMAP4+: hwmod data: Don't prevent RESET of
> USB Host module") added the SYSC_HAS_RESET_STATUS flag to both OMAP4
> and OMAP5 USB host module hwmon sysconfig but that flag was already
> set for OMAP5. So now the flag appears twice in the expression.
> 
> make coccicheck complains with the following message:
> 
> omap_hwmod_54xx_data.c:1846:37-58: duplicated argument to & or |
> 
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>

Acked-by: Roger Quadros <rogerq@ti.com>

> 
> ---
> 
>  arch/arm/mach-omap2/omap_hwmod_54xx_data.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/arch/arm/mach-omap2/omap_hwmod_54xx_data.c b/arch/arm/mach-omap2/omap_hwmod_54xx_data.c
> index 7c3fac035e93..8cdfd9b7ab4f 100644
> --- a/arch/arm/mach-omap2/omap_hwmod_54xx_data.c
> +++ b/arch/arm/mach-omap2/omap_hwmod_54xx_data.c
> @@ -1844,8 +1844,7 @@ static struct omap_hwmod_class_sysconfig omap54xx_usb_host_hs_sysc = {
>  	.rev_offs	= 0x0000,
>  	.sysc_offs	= 0x0010,
>  	.sysc_flags	= (SYSC_HAS_MIDLEMODE | SYSC_HAS_RESET_STATUS |
> -			   SYSC_HAS_SIDLEMODE | SYSC_HAS_SOFTRESET |
> -			   SYSC_HAS_RESET_STATUS),
> +			   SYSC_HAS_SIDLEMODE | SYSC_HAS_SOFTRESET),
>  	.idlemodes	= (SIDLE_FORCE | SIDLE_NO | SIDLE_SMART |
>  			   SIDLE_SMART_WKUP | MSTANDBY_FORCE | MSTANDBY_NO |
>  			   MSTANDBY_SMART | MSTANDBY_SMART_WKUP),
> 

--
cheers,
-roger

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: OMAP: Remove duplicated operand in OR operation
@ 2015-09-21  7:28   ` Roger Quadros
  0 siblings, 0 replies; 4+ messages in thread
From: Roger Quadros @ 2015-09-21  7:28 UTC (permalink / raw)
  To: Javier Martinez Canillas, linux-kernel
  Cc: Paul Walmsley, linux-omap, Tony Lindgren

On 17/09/15 16:22, Javier Martinez Canillas wrote:
> Commit b483a4a5a711 ("ARM: OMAP4+: hwmod data: Don't prevent RESET of
> USB Host module") added the SYSC_HAS_RESET_STATUS flag to both OMAP4
> and OMAP5 USB host module hwmon sysconfig but that flag was already
> set for OMAP5. So now the flag appears twice in the expression.
> 
> make coccicheck complains with the following message:
> 
> omap_hwmod_54xx_data.c:1846:37-58: duplicated argument to & or |
> 
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>

Acked-by: Roger Quadros <rogerq@ti.com>

> 
> ---
> 
>  arch/arm/mach-omap2/omap_hwmod_54xx_data.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/arch/arm/mach-omap2/omap_hwmod_54xx_data.c b/arch/arm/mach-omap2/omap_hwmod_54xx_data.c
> index 7c3fac035e93..8cdfd9b7ab4f 100644
> --- a/arch/arm/mach-omap2/omap_hwmod_54xx_data.c
> +++ b/arch/arm/mach-omap2/omap_hwmod_54xx_data.c
> @@ -1844,8 +1844,7 @@ static struct omap_hwmod_class_sysconfig omap54xx_usb_host_hs_sysc = {
>  	.rev_offs	= 0x0000,
>  	.sysc_offs	= 0x0010,
>  	.sysc_flags	= (SYSC_HAS_MIDLEMODE | SYSC_HAS_RESET_STATUS |
> -			   SYSC_HAS_SIDLEMODE | SYSC_HAS_SOFTRESET |
> -			   SYSC_HAS_RESET_STATUS),
> +			   SYSC_HAS_SIDLEMODE | SYSC_HAS_SOFTRESET),
>  	.idlemodes	= (SIDLE_FORCE | SIDLE_NO | SIDLE_SMART |
>  			   SIDLE_SMART_WKUP | MSTANDBY_FORCE | MSTANDBY_NO |
>  			   MSTANDBY_SMART | MSTANDBY_SMART_WKUP),
> 

--
cheers,
-roger

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: OMAP: Remove duplicated operand in OR operation
  2015-09-21  7:28   ` Roger Quadros
  (?)
@ 2015-09-23 20:08   ` Paul Walmsley
  -1 siblings, 0 replies; 4+ messages in thread
From: Paul Walmsley @ 2015-09-23 20:08 UTC (permalink / raw)
  To: Javier Martinez Canillas, Roger Quadros
  Cc: linux-kernel, linux-omap, Tony Lindgren

On Mon, 21 Sep 2015, Roger Quadros wrote:

> On 17/09/15 16:22, Javier Martinez Canillas wrote:
> > Commit b483a4a5a711 ("ARM: OMAP4+: hwmod data: Don't prevent RESET of
> > USB Host module") added the SYSC_HAS_RESET_STATUS flag to both OMAP4
> > and OMAP5 USB host module hwmon sysconfig but that flag was already
> > set for OMAP5. So now the flag appears twice in the expression.
> > 
> > make coccicheck complains with the following message:
> > 
> > omap_hwmod_54xx_data.c:1846:37-58: duplicated argument to & or |
> > 
> > Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> 
> Acked-by: Roger Quadros <rogerq@ti.com>

Thanks, queued for v4.4.

- Paul

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-09-23 20:08 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-09-17 13:22 [PATCH] ARM: OMAP: Remove duplicated operand in OR operation Javier Martinez Canillas
2015-09-21  7:28 ` Roger Quadros
2015-09-21  7:28   ` Roger Quadros
2015-09-23 20:08   ` Paul Walmsley

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.