All of lore.kernel.org
 help / color / mirror / Atom feed
From: Evan Chime <chime.evan.dri.devel@gmail.com>
To: gregkh@linuxfoundation.org
Cc: outreachy-kernel@googlegroups.com,
	laurent.pinchart@ideasonboard.com, mchehab@kernel.org
Subject: [PATCH v2 2/3] Staging: media: omap4iss: Add comment to memory barrier
Date: Sun, 3 Nov 2019 16:14:50 +0000	[thread overview]
Message-ID: <55eb1841b82cb2b5506a219ce217ebf1501e60ef.1572797322.git.chime.evan.dri.devel@gmail.com> (raw)
In-Reply-To: <cover.1572797322.git.chime.evan.dri.devel@gmail.com>

Fix "WARNING: memory barrier without comment" from checkpath. Add comment
to memory barrier smp_wmb() on line 653

Signed-off-by: Evan Chime <chime.evan.dri.devel@gmail.com>
---
 drivers/staging/media/omap4iss/iss.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/media/omap4iss/iss.c b/drivers/staging/media/omap4iss/iss.c
index 5156ad8e4b96..ce34c19874c7 100644
--- a/drivers/staging/media/omap4iss/iss.c
+++ b/drivers/staging/media/omap4iss/iss.c
@@ -650,7 +650,7 @@ int omap4iss_module_sync_idle(struct media_entity *me, wait_queue_head_t *wait,
 	if (video->dmaqueue_flags & ISS_VIDEO_DMAQUEUE_UNDERRUN) {
 		spin_unlock_irqrestore(&video->qlock, flags);
 		atomic_set(stopping, 0);
-		smp_wmb();
+		smp_wmb(); /* Prevent stores reordering across the barrier */
 		return 0;
 	}
 	spin_unlock_irqrestore(&video->qlock, flags);
-- 
2.17.1



  parent reply	other threads:[~2019-11-03 16:14 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-03 16:13 [PATCH v2 0/3] Add comment to memory barrier Evan Chime
2019-11-03 16:14 ` [PATCH v2 1/3] Staging: media: omap4iss: " Evan Chime
2019-11-03 17:07   ` Greg KH
2019-11-03 17:26     ` evan chime
2019-11-03 16:14 ` Evan Chime [this message]
2019-11-03 16:15 ` [PATCH v2 3/3] " Evan Chime
2019-11-03 16:16   ` [Outreachy kernel] " Julia Lawall
2019-11-03 16:23     ` evan chime
2019-11-03 16:18 ` [Outreachy kernel] [PATCH v2 0/3] " Julia Lawall
2019-11-03 16:27   ` evan chime
2019-11-04 13:26     ` evan chime
2019-11-04 18:54       ` evan chime
2019-11-05 16:40 ` ledepiele

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55eb1841b82cb2b5506a219ce217ebf1501e60ef.1572797322.git.chime.evan.dri.devel@gmail.com \
    --to=chime.evan.dri.devel@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=mchehab@kernel.org \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.