From: allen-kh.cheng <allen-kh.cheng@mediatek.com> To: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>, Matthias Brugger <matthias.bgg@gmail.com>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>, Chun-Kuang Hu <chunkuang.hu@kernel.org>, Philipp Zabel <p.zabel@pengutronix.de> Cc: <Project_Global_Chrome_Upstream_Group@mediatek.com>, <devicetree@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org>, <linux-mediatek@lists.infradead.org>, Xiandong Wang <xiandong.wang@mediatek.com> Subject: Re: [PATCH 1/2] dt-bindings: soc: mediatek: add mdp3 mutex support for mt8186 Date: Fri, 8 Jul 2022 16:14:44 +0800 [thread overview] Message-ID: <55fafa62684e077f75c3b8b192a59df62ad01692.camel@mediatek.com> (raw) In-Reply-To: <243b30ca-a552-3cb7-8a4e-6e54a56ff60a@collabora.com> Hi Angelo, On Thu, 2022-07-07 at 12:59 +0200, AngeloGioacchino Del Regno wrote: > Il 07/07/22 12:41, Matthias Brugger ha scritto: > > > > > > On 07/07/2022 10:52, AngeloGioacchino Del Regno wrote: > > > Il 05/07/22 14:26, Allen-KH Cheng ha scritto: > > > > Add mdp3 mutex compatible for mt8186 SoC. > > > > > > > > Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com> > > > > Signed-off-by: Xiandong Wang <xiandong.wang@mediatek.com> > > > > > > > > > Please drop this commit. Adding a mdp3-mutex compatible is not > > > needed here. > > > > > > > Thanks for checking. We probably would need a fallback compatible. > > We can only know > > from the HW engineers that can confirm if the IP block is the same > > as the disp > > mutex or a different one. > > > > I'll drop both patches for now until things got clear. > > > > They're located in a different iospace from each other, but either > the platform > data needs to *not be* joined together, or if they're together, I > would not like > having two different compatible strings for essentially the same > thing. > > I would at this point prefer dropping '-disp' from 'mediatek,mt8186- > disp-mutex' > so that we would be able to declare two 'mediatek,mt8186-mutex' in > devicetree... > ...or simply have two mediatek,mt8186-disp-mutex (although logically > incorrect?). > > Cheers, > Angelo > Thanks for your opinion. They are two different hardwares for different address spaces. I think we drop '-disp' from 'mediatek,mt8186-disp-mutex' will be excessive because we also need to modify mutex node in all exited dts files. I prefer havingg two mediatek,mt8186-disp-mutex. ex: mutex: mutex@14001000 { compatible = "mediatek,mt8186-disp-mutex"; .. } mdp3_mutex0: mutex@1b001000 { compatible = "mediatek,mt8186-disp-mutex"; ... } What do you think? Best regards, Allen > > Regards, > > Matthias > > > > > > --- > > > > > > > > .../devicetree/bindings/soc/mediatek/mediatek,mutex.yaml > > > > | 1 + > > > > 1 file changed, 1 insertion(+) > > > > > > > > diff --git > > > > a/Documentation/devicetree/bindings/soc/mediatek/mediatek,mutex > > > > .yaml > > > > b/Documentation/devicetree/bindings/soc/mediatek/mediatek,mutex > > > > .yaml > > > > index 627dcc3e8b32..234fa5dc07c2 100644 > > > > --- > > > > a/Documentation/devicetree/bindings/soc/mediatek/mediatek,mutex > > > > .yaml > > > > +++ > > > > b/Documentation/devicetree/bindings/soc/mediatek/mediatek,mutex > > > > .yaml > > > > @@ -30,6 +30,7 @@ properties: > > > > - mediatek,mt8173-disp-mutex > > > > - mediatek,mt8183-disp-mutex > > > > - mediatek,mt8186-disp-mutex > > > > + - mediatek,mt8186-mdp3-mutex > > > > - mediatek,mt8192-disp-mutex > > > > - mediatek,mt8195-disp-mutex > > > > > > > > > > >
WARNING: multiple messages have this Message-ID (diff)
From: allen-kh.cheng <allen-kh.cheng@mediatek.com> To: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>, Matthias Brugger <matthias.bgg@gmail.com>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>, Chun-Kuang Hu <chunkuang.hu@kernel.org>, Philipp Zabel <p.zabel@pengutronix.de> Cc: <Project_Global_Chrome_Upstream_Group@mediatek.com>, <devicetree@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org>, <linux-mediatek@lists.infradead.org>, Xiandong Wang <xiandong.wang@mediatek.com> Subject: Re: [PATCH 1/2] dt-bindings: soc: mediatek: add mdp3 mutex support for mt8186 Date: Fri, 8 Jul 2022 16:14:44 +0800 [thread overview] Message-ID: <55fafa62684e077f75c3b8b192a59df62ad01692.camel@mediatek.com> (raw) In-Reply-To: <243b30ca-a552-3cb7-8a4e-6e54a56ff60a@collabora.com> Hi Angelo, On Thu, 2022-07-07 at 12:59 +0200, AngeloGioacchino Del Regno wrote: > Il 07/07/22 12:41, Matthias Brugger ha scritto: > > > > > > On 07/07/2022 10:52, AngeloGioacchino Del Regno wrote: > > > Il 05/07/22 14:26, Allen-KH Cheng ha scritto: > > > > Add mdp3 mutex compatible for mt8186 SoC. > > > > > > > > Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com> > > > > Signed-off-by: Xiandong Wang <xiandong.wang@mediatek.com> > > > > > > > > > Please drop this commit. Adding a mdp3-mutex compatible is not > > > needed here. > > > > > > > Thanks for checking. We probably would need a fallback compatible. > > We can only know > > from the HW engineers that can confirm if the IP block is the same > > as the disp > > mutex or a different one. > > > > I'll drop both patches for now until things got clear. > > > > They're located in a different iospace from each other, but either > the platform > data needs to *not be* joined together, or if they're together, I > would not like > having two different compatible strings for essentially the same > thing. > > I would at this point prefer dropping '-disp' from 'mediatek,mt8186- > disp-mutex' > so that we would be able to declare two 'mediatek,mt8186-mutex' in > devicetree... > ...or simply have two mediatek,mt8186-disp-mutex (although logically > incorrect?). > > Cheers, > Angelo > Thanks for your opinion. They are two different hardwares for different address spaces. I think we drop '-disp' from 'mediatek,mt8186-disp-mutex' will be excessive because we also need to modify mutex node in all exited dts files. I prefer havingg two mediatek,mt8186-disp-mutex. ex: mutex: mutex@14001000 { compatible = "mediatek,mt8186-disp-mutex"; .. } mdp3_mutex0: mutex@1b001000 { compatible = "mediatek,mt8186-disp-mutex"; ... } What do you think? Best regards, Allen > > Regards, > > Matthias > > > > > > --- > > > > > > > > .../devicetree/bindings/soc/mediatek/mediatek,mutex.yaml > > > > | 1 + > > > > 1 file changed, 1 insertion(+) > > > > > > > > diff --git > > > > a/Documentation/devicetree/bindings/soc/mediatek/mediatek,mutex > > > > .yaml > > > > b/Documentation/devicetree/bindings/soc/mediatek/mediatek,mutex > > > > .yaml > > > > index 627dcc3e8b32..234fa5dc07c2 100644 > > > > --- > > > > a/Documentation/devicetree/bindings/soc/mediatek/mediatek,mutex > > > > .yaml > > > > +++ > > > > b/Documentation/devicetree/bindings/soc/mediatek/mediatek,mutex > > > > .yaml > > > > @@ -30,6 +30,7 @@ properties: > > > > - mediatek,mt8173-disp-mutex > > > > - mediatek,mt8183-disp-mutex > > > > - mediatek,mt8186-disp-mutex > > > > + - mediatek,mt8186-mdp3-mutex > > > > - mediatek,mt8192-disp-mutex > > > > - mediatek,mt8195-disp-mutex > > > > > > > > > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-07-08 8:45 UTC|newest] Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-07-05 12:26 [PATCH 0/2] Add mt8186 mutex support for mdp3 Allen-KH Cheng 2022-07-05 12:26 ` Allen-KH Cheng 2022-07-05 12:26 ` [PATCH 1/2] dt-bindings: soc: mediatek: add mdp3 mutex support for mt8186 Allen-KH Cheng 2022-07-05 12:26 ` Allen-KH Cheng 2022-07-07 8:52 ` AngeloGioacchino Del Regno 2022-07-07 8:52 ` AngeloGioacchino Del Regno 2022-07-07 10:41 ` Matthias Brugger 2022-07-07 10:41 ` Matthias Brugger 2022-07-07 10:59 ` AngeloGioacchino Del Regno 2022-07-07 10:59 ` AngeloGioacchino Del Regno 2022-07-08 8:14 ` allen-kh.cheng [this message] 2022-07-08 8:14 ` allen-kh.cheng 2022-07-08 8:19 ` Matthias Brugger 2022-07-08 8:19 ` Matthias Brugger 2022-07-08 8:28 ` AngeloGioacchino Del Regno 2022-07-08 8:28 ` AngeloGioacchino Del Regno 2022-07-08 11:58 ` allen-kh.cheng 2022-07-08 11:58 ` allen-kh.cheng 2022-07-08 15:37 ` AngeloGioacchino Del Regno 2022-07-08 15:37 ` AngeloGioacchino Del Regno 2022-07-11 11:28 ` allen-kh.cheng 2022-07-11 11:28 ` allen-kh.cheng 2022-07-05 12:26 ` [PATCH 2/2] soc: mediatek: mutex: add mt8186 mutex mod settings for mdp3 Allen-KH Cheng 2022-07-05 12:26 ` Allen-KH Cheng 2022-07-07 8:51 ` AngeloGioacchino Del Regno 2022-07-07 8:51 ` AngeloGioacchino Del Regno 2022-07-06 14:17 ` [PATCH 0/2] Add mt8186 mutex support " Matthias Brugger 2022-07-06 14:17 ` Matthias Brugger 2022-07-07 10:08 ` Matthias Brugger 2022-07-07 10:08 ` Matthias Brugger
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=55fafa62684e077f75c3b8b192a59df62ad01692.camel@mediatek.com \ --to=allen-kh.cheng@mediatek.com \ --cc=Project_Global_Chrome_Upstream_Group@mediatek.com \ --cc=angelogioacchino.delregno@collabora.com \ --cc=chunkuang.hu@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=krzysztof.kozlowski@canonical.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mediatek@lists.infradead.org \ --cc=matthias.bgg@gmail.com \ --cc=p.zabel@pengutronix.de \ --cc=robh+dt@kernel.org \ --cc=xiandong.wang@mediatek.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.