From: Andrzej Hajda <a.hajda@samsung.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
Jianwei Wang <jianwei.wang.chn@gmail.com>
Cc: kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org,
Alison Wang <alison.wang@freescale.com>
Subject: Re: [patch] drm/layerscape: fix a signedness bug
Date: Tue, 22 Sep 2015 12:55:09 +0000 [thread overview]
Message-ID: <56014FAD.7010805@samsung.com> (raw)
In-Reply-To: <20150922123104.GB27407@mwanda>
Hi,
I have posted the same patch yesterday [1].
http://permalink.gmane.org/gmane.comp.video.dri.devel/136945
Regards
Andrzej
On 09/22/2015 02:31 PM, Dan Carpenter wrote:
> "index" needs to be signed for the error handling to work. Really "ret"
> should be an int as well.
>
> Fixes: 109eee2f2a18 ('drm/layerscape: Add Freescale DCU DRM driver')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_plane.c b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_plane.c
> index 82be6b8..d1e300d 100644
> --- a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_plane.c
> +++ b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_plane.c
> @@ -58,7 +58,8 @@ static void fsl_dcu_drm_plane_atomic_disable(struct drm_plane *plane,
> struct drm_plane_state *old_state)
> {
> struct fsl_dcu_drm_device *fsl_dev = plane->dev->dev_private;
> - unsigned int index, value, ret;
> + unsigned int value;
> + int index, ret;
>
> index = fsl_dcu_drm_plane_index(plane);
> if (index < 0)
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
>
WARNING: multiple messages have this Message-ID (diff)
From: Andrzej Hajda <a.hajda@samsung.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
Jianwei Wang <jianwei.wang.chn@gmail.com>
Cc: kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org,
Alison Wang <alison.wang@freescale.com>
Subject: Re: [patch] drm/layerscape: fix a signedness bug
Date: Tue, 22 Sep 2015 14:55:09 +0200 [thread overview]
Message-ID: <56014FAD.7010805@samsung.com> (raw)
In-Reply-To: <20150922123104.GB27407@mwanda>
Hi,
I have posted the same patch yesterday [1].
http://permalink.gmane.org/gmane.comp.video.dri.devel/136945
Regards
Andrzej
On 09/22/2015 02:31 PM, Dan Carpenter wrote:
> "index" needs to be signed for the error handling to work. Really "ret"
> should be an int as well.
>
> Fixes: 109eee2f2a18 ('drm/layerscape: Add Freescale DCU DRM driver')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_plane.c b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_plane.c
> index 82be6b8..d1e300d 100644
> --- a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_plane.c
> +++ b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_plane.c
> @@ -58,7 +58,8 @@ static void fsl_dcu_drm_plane_atomic_disable(struct drm_plane *plane,
> struct drm_plane_state *old_state)
> {
> struct fsl_dcu_drm_device *fsl_dev = plane->dev->dev_private;
> - unsigned int index, value, ret;
> + unsigned int value;
> + int index, ret;
>
> index = fsl_dcu_drm_plane_index(plane);
> if (index < 0)
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2015-09-22 12:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-22 12:31 [patch] drm/layerscape: fix a signedness bug Dan Carpenter
2015-09-22 12:31 ` Dan Carpenter
2015-09-22 12:55 ` Andrzej Hajda [this message]
2015-09-22 12:55 ` Andrzej Hajda
2015-09-28 21:38 ` Dan Carpenter
2015-09-28 21:38 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56014FAD.7010805@samsung.com \
--to=a.hajda@samsung.com \
--cc=alison.wang@freescale.com \
--cc=dan.carpenter@oracle.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jianwei.wang.chn@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.