* [Qemu-devel] MAINTAINERS leaves too many files uncovered
@ 2014-10-20 9:19 Markus Armbruster
2014-10-20 18:36 ` Paolo Bonzini
` (2 more replies)
0 siblings, 3 replies; 55+ messages in thread
From: Markus Armbruster @ 2014-10-20 9:19 UTC (permalink / raw)
To: qemu-devel
In my experience, too many files are not covered by MAINTAINERS.
scripts/get_maintainer.pl falls back to git then, unless you say
--no-git-fallback. Copies sent there tends to annoy their recipients
without accomplishing all that much.
Two obvious improvements:
* Easy: Flip scripts/get_maintainer.pl's default to --no-git-fallback.
I'll post the obvious patch, please raise your objections there.
* Harder: improve MAINTAINERS coverage.
Let me back up subjective experience with hard data. The tree has quite
a few files:
$ git-ls-files | wc -l
3746
Counting them by extension:
$ git-ls-files | sed -n 's#.*/##;s#.*\.##p' | sort | uniq -c | sort -nr
1836 c
818 h
133 out
105 S
97 objs
69 s
64 mak
48 json
47 py
41 txt
33 exit
33 err
16 xml
16 bin
13 rom
12 sh
12 dsl
[Long tail that doesn't add up to anything interesting omitted]
Let's look for .c not in MAINTAINERS:
$ for i in `git-ls-files`; do [ "`scripts/get_maintainer.pl -f --no-git-fallback $i`" ] || echo $i; done >unmaintained-files
$ grep -c '\.c$' unmaintained-files
1066
That's almost 60%. Not good.
Apparently, nobody cares for tests:
$ grep '^tests/' unmaintained-files | grep -c '\.c$'
654
$ git-ls-files | grep '^tests/' | grep -c '\.c$'
664
Filtering those out leaves us with 412 unmaintained out of of 1172, or
35% unmaintained. Not good even if we (foolishly!) considered tests not
worthy of maintenance.
Maybe unmaintained files are much smaller. David A. Wheeler's
SLOCCount counts 570kSLOC in 1212 maintained files (+140 files sloccount
doesn't know how to count) vs. 300kSLOC in 1798 unmaintained files (+596
uncounted), or 35% unmaintained SLOC. With tests/ ignored, it's 30%.
So, unmaintained files are indeed smaller, but 30-something percent is
still not good.
Where are the unmaintained files? Top-scoring directories outside
tests/ and include/, files in subdirs not counted:
#files directory
84 68% .
63 100% default-configs
48 100% pc-bios
43 97% stubs
39 100% util
37 100% pc-bios/keymaps
35 81% hw/display
32 94% scripts
26 92% docs
26 100% libcacard
23 69% hw/misc
22 57% hw/net
21 63% hw/intc
19 100% roms
18 100% disas
18 56% hw/timer
16 100% hw/core
15 53% hw/char
15 100% qga
14 100% docs/specs
12 92% hw/input
12 100% qobject
12 100% target-m68k
11 100% backends
11 100% pc-bios/s390-ccw
10 71% hw/dma
Ideas? Takers?
^ permalink raw reply [flat|nested] 55+ messages in thread
* Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered
2014-10-20 9:19 [Qemu-devel] MAINTAINERS leaves too many files uncovered Markus Armbruster
@ 2014-10-20 18:36 ` Paolo Bonzini
2014-10-22 8:23 ` Markus Armbruster
2014-10-22 14:02 ` Alex Bennée
2 siblings, 0 replies; 55+ messages in thread
From: Paolo Bonzini @ 2014-10-20 18:36 UTC (permalink / raw)
To: Markus Armbruster, qemu-devel
On 10/20/2014 11:19 AM, Markus Armbruster wrote:
> In my experience, too many files are not covered by MAINTAINERS.
> scripts/get_maintainer.pl falls back to git then, unless you say
> --no-git-fallback. Copies sent there tends to annoy their recipients
> without accomplishing all that much.
>
> Two obvious improvements:
>
> * Easy: Flip scripts/get_maintainer.pl's default to --no-git-fallback.
> I'll post the obvious patch, please raise your objections there.
In many cases it annoys recipients. In other cases, the top 1-2 results
are actually a good match for a prospective maintainer. I suspect this
is the case for most tests, in fact.
Paolo
^ permalink raw reply [flat|nested] 55+ messages in thread
* Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered
2014-10-20 9:19 [Qemu-devel] MAINTAINERS leaves too many files uncovered Markus Armbruster
2014-10-20 18:36 ` Paolo Bonzini
@ 2014-10-22 8:23 ` Markus Armbruster
2014-10-22 9:00 ` Paolo Bonzini
2015-09-22 9:13 ` Markus Armbruster
2014-10-22 14:02 ` Alex Bennée
2 siblings, 2 replies; 55+ messages in thread
From: Markus Armbruster @ 2014-10-22 8:23 UTC (permalink / raw)
To: qemu-devel
Markus Armbruster <armbru@redhat.com> writes:
> In my experience, too many files are not covered by MAINTAINERS.
> scripts/get_maintainer.pl falls back to git then, unless you say
> --no-git-fallback. Copies sent there tends to annoy their recipients
> without accomplishing all that much.
>
> Two obvious improvements:
>
> * Easy: Flip scripts/get_maintainer.pl's default to --no-git-fallback.
> I'll post the obvious patch, please raise your objections there.
>
> * Harder: improve MAINTAINERS coverage.
A few folks have started doing that. Much appreciated!
I collected recent patches to MAINTAINERS, and reran my analysis.
> Let me back up subjective experience with hard data. The tree has quite
> a few files:
>
> $ git-ls-files | wc -l
> 3746
Now 3752.
> Counting them by extension:
>
> $ git-ls-files | sed -n 's#.*/##;s#.*\.##p' | sort | uniq -c | sort -nr
> 1836 c
> 818 h
> 133 out
> 105 S
> 97 objs
> 69 s
> 64 mak
> 48 json
> 47 py
> 41 txt
> 33 exit
> 33 err
> 16 xml
> 16 bin
> 13 rom
> 12 sh
> 12 dsl
> [Long tail that doesn't add up to anything interesting omitted]
>
> Let's look for .c not in MAINTAINERS:
>
> $ for i in `git-ls-files`; do [ "`scripts/get_maintainer.pl -f --no-git-fallback $i`" ] || echo $i; done >unmaintained-files
> $ grep -c '\.c$' unmaintained-files
> 1066
>
> That's almost 60%. Not good.
Down to 491 our of 1841 (27%). Progress, but not quite enough.
> Apparently, nobody cares for tests:
>
> $ grep '^tests/' unmaintained-files | grep -c '\.c$'
> 654
> $ git-ls-files | grep '^tests/' | grep -c '\.c$'
> 664
Now 91 out of 665.
> Filtering those out leaves us with 412 unmaintained out of of 1172, or
> 35% unmaintained. Not good even if we (foolishly!) considered tests not
> worthy of maintenance.
>
> Maybe unmaintained files are much smaller. David A. Wheeler's
> SLOCCount counts 570kSLOC in 1212 maintained files (+140 files sloccount
> doesn't know how to count) vs. 300kSLOC in 1798 unmaintained files (+596
> uncounted), or 35% unmaintained SLOC. With tests/ ignored, it's 30%.
> So, unmaintained files are indeed smaller, but 30-something percent is
> still not good.
>
> Where are the unmaintained files? Top-scoring directories outside
> tests/ and include/, files in subdirs not counted:
>
> #files directory
> 84 68% .
> 63 100% default-configs
> 48 100% pc-bios
> 43 97% stubs
> 39 100% util
> 37 100% pc-bios/keymaps
> 35 81% hw/display
> 32 94% scripts
> 26 92% docs
> 26 100% libcacard
> 23 69% hw/misc
> 22 57% hw/net
> 21 63% hw/intc
> 19 100% roms
> 18 100% disas
> 18 56% hw/timer
> 16 100% hw/core
> 15 53% hw/char
> 15 100% qga
> 14 100% docs/specs
> 12 92% hw/input
> 12 100% qobject
> 12 100% target-m68k
> 11 100% backends
> 11 100% pc-bios/s390-ccw
> 10 71% hw/dma
>
> Ideas? Takers?
Full list of unmaintained files now:
.exrc
.gitignore
.gitmodules
.mailmap
.travis.yml
CODING_STYLE
COPYING
COPYING.LIB
Changelog
HACKING
LICENSE
MAINTAINERS
Makefile
Makefile.objs
Makefile.target
README
VERSION
accel.c
arch_init.c
backends/Makefile.objs
backends/baum.c
backends/hostmem-file.c
backends/hostmem-ram.c
backends/hostmem.c
backends/msmouse.c
backends/rng-egd.c
backends/rng-random.c
backends/rng.c
backends/testdev.c
backends/tpm.c
balloon.c
bt-host.c
bt-vhci.c
configure
coroutine-gthread.c
coroutine-sigaltstack.c
coroutine-ucontext.c
cpus.c
default-configs/aarch64-linux-user.mak
default-configs/aarch64-softmmu.mak
default-configs/alpha-linux-user.mak
default-configs/alpha-softmmu.mak
default-configs/arm-linux-user.mak
default-configs/arm-softmmu.mak
default-configs/armeb-linux-user.mak
default-configs/cris-linux-user.mak
default-configs/cris-softmmu.mak
default-configs/i386-bsd-user.mak
default-configs/i386-linux-user.mak
default-configs/i386-softmmu.mak
default-configs/lm32-softmmu.mak
default-configs/m68k-linux-user.mak
default-configs/m68k-softmmu.mak
default-configs/microblaze-linux-user.mak
default-configs/microblaze-softmmu.mak
default-configs/microblazeel-linux-user.mak
default-configs/microblazeel-softmmu.mak
default-configs/mips-linux-user.mak
default-configs/mips-softmmu.mak
default-configs/mips64-linux-user.mak
default-configs/mips64-softmmu.mak
default-configs/mips64el-linux-user.mak
default-configs/mips64el-softmmu.mak
default-configs/mipsel-linux-user.mak
default-configs/mipsel-softmmu.mak
default-configs/mipsn32-linux-user.mak
default-configs/mipsn32el-linux-user.mak
default-configs/moxie-softmmu.mak
default-configs/or32-linux-user.mak
default-configs/or32-softmmu.mak
default-configs/pci.mak
default-configs/ppc-linux-user.mak
default-configs/ppc-softmmu.mak
default-configs/ppc64-linux-user.mak
default-configs/ppc64-softmmu.mak
default-configs/ppc64abi32-linux-user.mak
default-configs/ppc64le-linux-user.mak
default-configs/ppcemb-softmmu.mak
default-configs/s390x-linux-user.mak
default-configs/s390x-softmmu.mak
default-configs/sh4-linux-user.mak
default-configs/sh4-softmmu.mak
default-configs/sh4eb-linux-user.mak
default-configs/sh4eb-softmmu.mak
default-configs/sound.mak
default-configs/sparc-bsd-user.mak
default-configs/sparc-linux-user.mak
default-configs/sparc-softmmu.mak
default-configs/sparc32plus-linux-user.mak
default-configs/sparc64-bsd-user.mak
default-configs/sparc64-linux-user.mak
default-configs/sparc64-softmmu.mak
default-configs/tricore-softmmu.mak
default-configs/unicore32-linux-user.mak
default-configs/unicore32-softmmu.mak
default-configs/usb.mak
default-configs/x86_64-bsd-user.mak
default-configs/x86_64-linux-user.mak
default-configs/x86_64-softmmu.mak
default-configs/xtensa-softmmu.mak
default-configs/xtensaeb-softmmu.mak
device-hotplug.c
disas.c
disas/Makefile.objs
disas/alpha.c
disas/arm-a64.cc
disas/arm.c
disas/cris.c
disas/hppa.c
disas/i386.c
disas/ia64.c
disas/libvixl/LICENCE
disas/libvixl/Makefile.objs
disas/libvixl/README
disas/libvixl/a64/assembler-a64.h
disas/libvixl/a64/constants-a64.h
disas/libvixl/a64/cpu-a64.h
disas/libvixl/a64/decoder-a64.cc
disas/libvixl/a64/decoder-a64.h
disas/libvixl/a64/disasm-a64.cc
disas/libvixl/a64/disasm-a64.h
disas/libvixl/a64/instructions-a64.cc
disas/libvixl/a64/instructions-a64.h
disas/libvixl/globals.h
disas/libvixl/platform.h
disas/libvixl/utils.cc
disas/libvixl/utils.h
disas/lm32.c
disas/m68k.c
disas/microblaze.c
disas/mips.c
disas/moxie.c
disas/ppc.c
disas/s390.c
disas/sh4.c
disas/sparc.c
disas/tci.c
dma-helpers.c
docs/aio_notify.promela
docs/atomics.txt
docs/blkdebug.txt
docs/blkverify.txt
docs/bootindex.txt
docs/ccid.txt
docs/ich9-ehci-uhci.cfg
docs/image-fuzzer.txt
docs/libcacard.txt
docs/live-block-ops.txt
docs/memory.txt
docs/migration.txt
docs/multiple-iothreads.txt
docs/multiseat.txt
docs/q35-chipset.cfg
docs/qapi-code-gen.txt
docs/qdev-device-use.txt
docs/qemupciserial.inf
docs/qmp/README
docs/qmp/qmp-events.txt
docs/qmp/qmp-spec.txt
docs/rdma.txt
docs/specs/acpi_cpu_hotplug.txt
docs/specs/acpi_mem_hotplug.txt
docs/specs/acpi_pci_hotplug.txt
docs/specs/ivshmem_device_spec.txt
docs/specs/pci-ids.txt
docs/specs/pci-serial.txt
docs/specs/pci-testdev.txt
docs/specs/ppc-spapr-hcalls.txt
docs/specs/pvpanic.txt
docs/specs/qcow2.txt
docs/specs/qed_spec.txt
docs/specs/standard-vga.txt
docs/specs/vhost-user.txt
docs/specs/vmw_pvscsi-spec.txt
docs/spice-port-fqdn.txt
docs/usb-storage.txt
docs/usb2.txt
docs/virtio-balloon-stats.txt
docs/vnc-ledstate-Pseudo-encoding.txt
docs/writing-qmp-commands.txt
docs/xbzrle.txt
dtc
dump.c
fpu/softfloat-macros.h
fpu/softfloat-specialize.h
fpu/softfloat.c
hmp.h
hw/Makefile.objs
hw/bt/Makefile.objs
hw/bt/core.c
hw/bt/hci-csr.c
hw/bt/hci.c
hw/bt/hid.c
hw/bt/l2cap.c
hw/bt/sdp.c
hw/char/Makefile.objs
hw/char/debugcon.c
hw/char/escc.c
hw/char/ipoctal232.c
hw/char/mcf_uart.c
hw/char/milkymist-uart.c
hw/char/parallel.c
hw/char/pl011.c
hw/char/sclpconsole-lm.c
hw/char/sclpconsole.c
hw/char/serial-isa.c
hw/char/serial-pci.c
hw/char/serial.c
hw/char/sh_serial.c
hw/char/xen_console.c
hw/core/Makefile.objs
hw/core/empty_slot.c
hw/core/fw-path-provider.c
hw/core/hotplug.c
hw/core/irq.c
hw/core/loader.c
hw/core/machine.c
hw/core/nmi.c
hw/core/null-machine.c
hw/core/ptimer.c
hw/core/qdev-properties-system.c
hw/core/qdev-properties.c
hw/core/qdev.c
hw/core/stream.c
hw/core/sysbus.c
hw/core/uboot_image.h
hw/cpu/Makefile.objs
hw/cpu/realview_mpcore.c
hw/display/Makefile.objs
hw/display/ads7846.c
hw/display/blizzard.c
hw/display/blizzard_template.h
hw/display/cg3.c
hw/display/cirrus_vga.c
hw/display/cirrus_vga_rop.h
hw/display/cirrus_vga_rop2.h
hw/display/framebuffer.c
hw/display/framebuffer.h
hw/display/g364fb.c
hw/display/jazz_led.c
hw/display/milkymist-tmu2.c
hw/display/milkymist-vgafb.c
hw/display/milkymist-vgafb_template.h
hw/display/pl110.c
hw/display/pl110_template.h
hw/display/pxa2xx_lcd.c
hw/display/pxa2xx_template.h
hw/display/sm501.c
hw/display/sm501_template.h
hw/display/ssd0303.c
hw/display/ssd0323.c
hw/display/tc6393xb.c
hw/display/tc6393xb_template.h
hw/display/tcx.c
hw/display/vga-helpers.h
hw/display/vga-isa-mm.c
hw/display/vga-isa.c
hw/display/vga-pci.c
hw/display/vga.c
hw/display/vga.h
hw/display/vga_int.h
hw/display/vmware_vga.c
hw/display/xenfb.c
hw/dma/Makefile.objs
hw/dma/i82374.c
hw/dma/i8257.c
hw/dma/pl080.c
hw/dma/pl330.c
hw/dma/pxa2xx_dma.c
hw/dma/rc4030.c
hw/dma/soc_dma.c
hw/dma/sparc32_dma.c
hw/dma/sun4m_iommu.c
hw/gpio/Makefile.objs
hw/gpio/max7310.c
hw/gpio/pl061.c
hw/gpio/zaurus.c
hw/i2c/Makefile.objs
hw/i2c/bitbang_i2c.c
hw/i2c/bitbang_i2c.h
hw/i2c/core.c
hw/i2c/pm_smbus.c
hw/i2c/smbus.c
hw/i2c/smbus_eeprom.c
hw/input/Makefile.objs
hw/input/adb.c
hw/input/hid.c
hw/input/lm832x.c
hw/input/milkymist-softusb.c
hw/input/pckbd.c
hw/input/pl050.c
hw/input/ps2.c
hw/input/pxa2xx_keypad.c
hw/input/tsc2005.c
hw/input/tsc210x.c
hw/input/vmmouse.c
hw/intc/Makefile.objs
hw/intc/apic.c
hw/intc/apic_common.c
hw/intc/arm_gic.c
hw/intc/arm_gic_common.c
hw/intc/arm_gic_kvm.c
hw/intc/armv7m_nvic.c
hw/intc/gic_internal.h
hw/intc/heathrow_pic.c
hw/intc/i8259.c
hw/intc/i8259_common.c
hw/intc/ioapic.c
hw/intc/ioapic_common.c
hw/intc/lm32_pic.c
hw/intc/openpic.c
hw/intc/openpic_kvm.c
hw/intc/pl190.c
hw/intc/realview_gic.c
hw/intc/sh_intc.c
hw/intc/slavio_intctl.c
hw/ipack/Makefile.objs
hw/ipack/ipack.c
hw/ipack/tpci200.c
hw/isa/Makefile.objs
hw/isa/apm.c
hw/isa/i82378.c
hw/isa/isa-bus.c
hw/isa/vt82c686.c
hw/m68k/Makefile.objs
hw/m68k/an5206.c
hw/m68k/dummy_m68k.c
hw/m68k/mcf5206.c
hw/m68k/mcf5208.c
hw/m68k/mcf_intc.c
hw/mem/Makefile.objs
hw/mem/pc-dimm.c
hw/misc/Makefile.objs
hw/misc/a9scu.c
hw/misc/applesmc.c
hw/misc/arm11scu.c
hw/misc/arm_integrator_debug.c
hw/misc/arm_l2x0.c
hw/misc/arm_sysctl.c
hw/misc/cbus.c
hw/misc/debugexit.c
hw/misc/eccmemctl.c
hw/misc/ivshmem.c
hw/misc/max111x.c
hw/misc/milkymist-hpdmc.c
hw/misc/milkymist-pfpu.c
hw/misc/mst_fpga.c
hw/misc/pc-testdev.c
hw/misc/pci-testdev.c
hw/misc/pvpanic.c
hw/misc/sga.c
hw/misc/slavio_misc.c
hw/misc/tmp105.c
hw/misc/tmp105.h
hw/misc/vmport.c
hw/moxie/Makefile.objs
hw/moxie/moxiesim.c
hw/net/Makefile.objs
hw/net/allwinner_emac.c
hw/net/dp8393x.c
hw/net/e1000.c
hw/net/e1000_regs.h
hw/net/eepro100.c
hw/net/fsl_etsec/etsec.c
hw/net/fsl_etsec/etsec.h
hw/net/fsl_etsec/miim.c
hw/net/fsl_etsec/registers.c
hw/net/fsl_etsec/registers.h
hw/net/fsl_etsec/rings.c
hw/net/lan9118.c
hw/net/lance.c
hw/net/mcf_fec.c
hw/net/milkymist-minimac2.c
hw/net/mipsnet.c
hw/net/ne2000-isa.c
hw/net/ne2000.c
hw/net/ne2000.h
hw/net/pcnet-pci.c
hw/net/pcnet.c
hw/net/pcnet.h
hw/net/rtl8139.c
hw/net/smc91c111.c
hw/net/vmware_utils.h
hw/net/xen_nic.c
hw/nvram/Makefile.objs
hw/nvram/ds1225y.c
hw/nvram/eeprom93xx.c
hw/nvram/fw_cfg.c
hw/nvram/mac_nvram.c
hw/pci-bridge/Makefile.objs
hw/pci-bridge/i82801b11.c
hw/pci-bridge/ioh3420.c
hw/pci-bridge/ioh3420.h
hw/pci-bridge/pci_bridge_dev.c
hw/pci-bridge/xio3130_downstream.c
hw/pci-bridge/xio3130_downstream.h
hw/pci-bridge/xio3130_upstream.c
hw/pci-bridge/xio3130_upstream.h
hw/pci-host/Makefile.objs
hw/pci-host/apb.c
hw/pci-host/bonito.c
hw/pci-host/ppce500.c
hw/pcmcia/Makefile.objs
hw/pcmcia/pcmcia.c
hw/pcmcia/pxa2xx.c
hw/sd/Makefile.objs
hw/sd/milkymist-memcard.c
hw/sd/pl181.c
hw/sd/pxa2xx_mmci.c
hw/sd/sd.c
hw/sd/sdhci.c
hw/sd/sdhci.h
hw/sd/ssi-sd.c
hw/timer/Makefile.objs
hw/timer/a9gtimer.c
hw/timer/arm_mptimer.c
hw/timer/arm_timer.c
hw/timer/ds1338.c
hw/timer/hpet.c
hw/timer/i8254.c
hw/timer/i8254_common.c
hw/timer/lm32_timer.c
hw/timer/m48t59.c
hw/timer/mc146818rtc.c
hw/timer/milkymist-sysctl.c
hw/timer/pl031.c
hw/timer/pxa2xx_timer.c
hw/timer/sh_timer.c
hw/timer/slavio_timer.c
hw/timer/tusb6010.c
hw/timer/twl92230.c
hw/tpm/Makefile.objs
hw/tpm/tpm_int.h
hw/tpm/tpm_passthrough.c
hw/tpm/tpm_tis.c
hw/tpm/tpm_tis.h
hw/virtio/Makefile.objs
hw/virtio/dataplane/Makefile.objs
hw/virtio/dataplane/vring.c
hw/watchdog/Makefile.objs
hw/watchdog/watchdog.c
hw/watchdog/wdt_i6300esb.c
hw/watchdog/wdt_ib700.c
hw/xen/Makefile.objs
hw/xen/xen-host-pci-device.c
hw/xen/xen-host-pci-device.h
hw/xen/xen_backend.c
hw/xen/xen_devconfig.c
hw/xen/xen_pt.c
hw/xen/xen_pt.h
hw/xen/xen_pt_config_init.c
hw/xen/xen_pt_msi.c
hw/xenpv/Makefile.objs
hw/xenpv/xen_domainbuild.c
hw/xenpv/xen_domainbuild.h
hw/xenpv/xen_machine_pv.c
include/block/accounting.h
include/block/aio.h
include/block/block.h
include/block/block_int.h
include/block/blockjob.h
include/block/coroutine.h
include/block/coroutine_int.h
include/block/nbd.h
include/block/qapi.h
include/block/scsi.h
include/block/snapshot.h
include/block/thread-pool.h
include/config.h
include/disas/bfd.h
include/disas/disas.h
include/elf.h
include/exec/address-spaces.h
include/exec/cpu-all.h
include/exec/cpu-common.h
include/exec/cpu-defs.h
include/exec/cpu_ldst.h
include/exec/cputlb.h
include/exec/exec-all.h
include/exec/gdbstub.h
include/exec/gen-icount.h
include/exec/hwaddr.h
include/exec/poison.h
include/exec/ram_addr.h
include/exec/softmmu-semi.h
include/exec/spinlock.h
include/exec/user/abitypes.h
include/exec/user/thunk.h
include/fpu/softfloat.h
include/glib-compat.h
include/hw/acpi/acpi.h
include/hw/acpi/acpi_dev_interface.h
include/hw/acpi/cpu_hotplug.h
include/hw/acpi/memory_hotplug.h
include/hw/acpi/pc-hotplug.h
include/hw/acpi/pcihp.h
include/hw/acpi/piix4.h
include/hw/acpi/tpm.h
include/hw/arm/arm.h
include/hw/arm/exynos4210.h
include/hw/arm/imx.h
include/hw/arm/omap.h
include/hw/arm/primecell.h
include/hw/arm/pxa.h
include/hw/arm/sharpsl.h
include/hw/arm/soc_dma.h
include/hw/audio/audio.h
include/hw/audio/pcspk.h
include/hw/block/block.h
include/hw/block/fdc.h
include/hw/block/flash.h
include/hw/boards.h
include/hw/bt.h
include/hw/char/digic-uart.h
include/hw/char/escc.h
include/hw/char/lm32_juart.h
include/hw/char/serial.h
include/hw/cpu/a15mpcore.h
include/hw/cpu/a9mpcore.h
include/hw/cpu/arm11mpcore.h
include/hw/cris/etraxfs.h
include/hw/cris/etraxfs_dma.h
include/hw/devices.h
include/hw/elf_ops.h
include/hw/empty_slot.h
include/hw/fw-path-provider.h
include/hw/hotplug.h
include/hw/hw.h
include/hw/i2c/i2c.h
include/hw/i2c/pm_smbus.h
include/hw/i2c/smbus.h
include/hw/input/adb.h
include/hw/input/hid.h
include/hw/input/ps2.h
include/hw/intc/arm_gic.h
include/hw/intc/arm_gic_common.h
include/hw/intc/realview_gic.h
include/hw/ipack/ipack.h
include/hw/irq.h
include/hw/isa/apm.h
include/hw/isa/i8259_internal.h
include/hw/isa/isa.h
include/hw/isa/pc87312.h
include/hw/isa/vt82c686.h
include/hw/kvm/clock.h
include/hw/lm32/lm32_pic.h
include/hw/loader.h
include/hw/m68k/mcf.h
include/hw/mem/pc-dimm.h
include/hw/mips/bios.h
include/hw/mips/cpudevs.h
include/hw/mips/mips.h
include/hw/misc/a9scu.h
include/hw/misc/arm11scu.h
include/hw/misc/arm_integrator_debug.h
include/hw/misc/tmp105_regs.h
include/hw/misc/vfio.h
include/hw/net/allwinner_emac.h
include/hw/nmi.h
include/hw/nvram/eeprom93xx.h
include/hw/nvram/fw_cfg.h
include/hw/nvram/openbios_firmware_abi.h
include/hw/pci-host/apb.h
include/hw/pci-host/ppce500.h
include/hw/pcmcia.h
include/hw/ppc/mac_dbdma.h
include/hw/ppc/openpic.h
include/hw/ppc/ppc.h
include/hw/ppc/ppc4xx.h
include/hw/ppc/ppc_e500.h
include/hw/ptimer.h
include/hw/qdev-core.h
include/hw/qdev-dma.h
include/hw/qdev-properties.h
include/hw/qdev.h
include/hw/scsi/esp.h
include/hw/scsi/scsi.h
include/hw/sd.h
include/hw/sh4/sh.h
include/hw/sh4/sh_intc.h
include/hw/sparc/grlib.h
include/hw/sparc/sparc32_dma.h
include/hw/sparc/sun4m.h
include/hw/ssi.h
include/hw/stream.h
include/hw/sysbus.h
include/hw/timer/a9gtimer.h
include/hw/timer/arm_mptimer.h
include/hw/timer/digic-timer.h
include/hw/timer/hpet.h
include/hw/timer/i8254.h
include/hw/timer/i8254_internal.h
include/hw/timer/m48t59.h
include/hw/timer/mc146818rtc.h
include/hw/timer/mc146818rtc_regs.h
include/hw/tricore/tricore.h
include/hw/unicore32/puv3.h
include/hw/usb.h
include/hw/usb/ehci-regs.h
include/hw/usb/uhci-regs.h
include/hw/virtio/dataplane/vring.h
include/hw/virtio/vhost-backend.h
include/hw/virtio/vhost-scsi.h
include/hw/virtio/vhost.h
include/hw/virtio/virtio-9p.h
include/hw/virtio/virtio-access.h
include/hw/virtio/virtio-balloon.h
include/hw/virtio/virtio-blk.h
include/hw/virtio/virtio-bus.h
include/hw/virtio/virtio-net.h
include/hw/virtio/virtio-rng.h
include/hw/virtio/virtio-scsi.h
include/hw/virtio/virtio-serial.h
include/hw/virtio/virtio.h
include/hw/virtio/virtio_ring.h
include/hw/xen/xen.h
include/hw/xen/xen_backend.h
include/hw/xen/xen_common.h
include/libdecnumber/dconfig.h
include/libdecnumber/decContext.h
include/libdecnumber/decDPD.h
include/libdecnumber/decNumber.h
include/libdecnumber/decNumberLocal.h
include/libdecnumber/dpd/decimal128.h
include/libdecnumber/dpd/decimal128Local.h
include/libdecnumber/dpd/decimal32.h
include/libdecnumber/dpd/decimal64.h
include/migration/block.h
include/migration/migration.h
include/migration/page_cache.h
include/migration/qemu-file.h
include/migration/vmstate.h
include/monitor/monitor.h
include/monitor/qdev.h
include/net/checksum.h
include/net/eth.h
include/net/net.h
include/net/queue.h
include/net/slirp.h
include/net/tap.h
include/net/vhost-user.h
include/net/vhost_net.h
include/qapi/dealloc-visitor.h
include/qapi/error.h
include/qapi/opts-visitor.h
include/qapi/qmp-event.h
include/qapi/qmp-input-visitor.h
include/qapi/qmp-output-visitor.h
include/qapi/qmp/dispatch.h
include/qapi/qmp/json-lexer.h
include/qapi/qmp/json-parser.h
include/qapi/qmp/json-streamer.h
include/qapi/qmp/qbool.h
include/qapi/qmp/qdict.h
include/qapi/qmp/qerror.h
include/qapi/qmp/qfloat.h
include/qapi/qmp/qint.h
include/qapi/qmp/qjson.h
include/qapi/qmp/qlist.h
include/qapi/qmp/qobject.h
include/qapi/qmp/qstring.h
include/qapi/qmp/types.h
include/qapi/string-input-visitor.h
include/qapi/string-output-visitor.h
include/qapi/util.h
include/qapi/visitor-impl.h
include/qapi/visitor.h
include/qemu-common.h
include/qemu-io.h
include/qemu/acl.h
include/qemu/aes.h
include/qemu/atomic.h
include/qemu/bitmap.h
include/qemu/bitops.h
include/qemu/bswap.h
include/qemu/compatfd.h
include/qemu/compiler.h
include/qemu/config-file.h
include/qemu/crc32c.h
include/qemu/envlist.h
include/qemu/error-report.h
include/qemu/event_notifier.h
include/qemu/fifo8.h
include/qemu/hbitmap.h
include/qemu/host-utils.h
include/qemu/int128.h
include/qemu/iov.h
include/qemu/log.h
include/qemu/main-loop.h
include/qemu/module.h
include/qemu/notify.h
include/qemu/option.h
include/qemu/option_int.h
include/qemu/osdep.h
include/qemu/queue.h
include/qemu/range.h
include/qemu/ratelimit.h
include/qemu/readline.h
include/qemu/rfifolock.h
include/qemu/seqlock.h
include/qemu/sockets.h
include/qemu/thread-posix.h
include/qemu/thread-win32.h
include/qemu/thread.h
include/qemu/throttle.h
include/qemu/timer.h
include/qemu/tls.h
include/qemu/typedefs.h
include/qemu/uri.h
include/qemu/xattr.h
include/sysemu/accel.h
include/sysemu/arch_init.h
include/sysemu/balloon.h
include/sysemu/blockdev.h
include/sysemu/bt.h
include/sysemu/char.h
include/sysemu/cpus.h
include/sysemu/device_tree.h
include/sysemu/dma.h
include/sysemu/dump-arch.h
include/sysemu/dump.h
include/sysemu/hostmem.h
include/sysemu/iothread.h
include/sysemu/kvm.h
include/sysemu/memory_mapping.h
include/sysemu/os-posix.h
include/sysemu/os-win32.h
include/sysemu/qtest.h
include/sysemu/rng-random.h
include/sysemu/rng.h
include/sysemu/sysemu.h
include/sysemu/tpm.h
include/sysemu/tpm_backend.h
include/sysemu/tpm_backend_int.h
include/sysemu/watchdog.h
include/sysemu/xen-mapcache.h
include/trace-tcg.h
include/trace.h
include/ui/console.h
include/ui/input.h
include/ui/pixel_ops.h
include/ui/qemu-pixman.h
include/ui/spice-display.h
iohandler.c
iothread.c
libcacard/Makefile
libcacard/cac.c
libcacard/cac.h
libcacard/card_7816.c
libcacard/card_7816.h
libcacard/card_7816t.h
libcacard/event.c
libcacard/eventt.h
libcacard/libcacard.pc.in
libcacard/libcacard.syms
libcacard/link_test.c
libcacard/vcard.c
libcacard/vcard.h
libcacard/vcard_emul.h
libcacard/vcard_emul_nss.c
libcacard/vcard_emul_type.c
libcacard/vcard_emul_type.h
libcacard/vcardt.c
libcacard/vcardt.h
libcacard/vcardt_internal.h
libcacard/vevent.h
libcacard/vreader.c
libcacard/vreader.h
libcacard/vreadert.h
libcacard/vscard_common.h
libcacard/vscclient.c
libdecnumber/decContext.c
libdecnumber/decNumber.c
libdecnumber/dpd/decimal128.c
libdecnumber/dpd/decimal128Local.h
libdecnumber/dpd/decimal32.c
libdecnumber/dpd/decimal64.c
memory_mapping.c
migration-exec.c
migration-fd.c
migration-rdma.c
migration-tcp.c
migration-unix.c
migration.c
module-common.c
numa.c
page_cache.c
pc-bios/Makefile
pc-bios/QEMU,cgthree.bin
pc-bios/QEMU,tcx.bin
pc-bios/README
pc-bios/acpi-dsdt.aml
pc-bios/bamboo.dtb
pc-bios/bamboo.dts
pc-bios/bios-256k.bin
pc-bios/bios.bin
pc-bios/efi-e1000.rom
pc-bios/efi-eepro100.rom
pc-bios/efi-ne2k_pci.rom
pc-bios/efi-pcnet.rom
pc-bios/efi-rtl8139.rom
pc-bios/efi-virtio.rom
pc-bios/keymaps/ar
pc-bios/keymaps/bepo
pc-bios/keymaps/common
pc-bios/keymaps/cz
pc-bios/keymaps/da
pc-bios/keymaps/de
pc-bios/keymaps/de-ch
pc-bios/keymaps/en-gb
pc-bios/keymaps/en-us
pc-bios/keymaps/es
pc-bios/keymaps/et
pc-bios/keymaps/fi
pc-bios/keymaps/fo
pc-bios/keymaps/fr
pc-bios/keymaps/fr-be
pc-bios/keymaps/fr-ca
pc-bios/keymaps/fr-ch
pc-bios/keymaps/hr
pc-bios/keymaps/hu
pc-bios/keymaps/is
pc-bios/keymaps/it
pc-bios/keymaps/ja
pc-bios/keymaps/lt
pc-bios/keymaps/lv
pc-bios/keymaps/mk
pc-bios/keymaps/modifiers
pc-bios/keymaps/nl
pc-bios/keymaps/nl-be
pc-bios/keymaps/no
pc-bios/keymaps/pl
pc-bios/keymaps/pt
pc-bios/keymaps/pt-br
pc-bios/keymaps/ru
pc-bios/keymaps/sl
pc-bios/keymaps/sv
pc-bios/keymaps/th
pc-bios/keymaps/tr
pc-bios/kvmvapic.bin
pc-bios/linuxboot.bin
pc-bios/multiboot.bin
pc-bios/openbios-ppc
pc-bios/openbios-sparc32
pc-bios/openbios-sparc64
pc-bios/optionrom/Makefile
pc-bios/optionrom/kvmvapic.S
pc-bios/optionrom/linuxboot.S
pc-bios/optionrom/multiboot.S
pc-bios/optionrom/optionrom.h
pc-bios/palcode-clipper
pc-bios/petalogix-ml605.dtb
pc-bios/petalogix-s3adsp1800.dtb
pc-bios/ppc_rom.bin
pc-bios/pxe-e1000.rom
pc-bios/pxe-eepro100.rom
pc-bios/pxe-ne2k_pci.rom
pc-bios/pxe-pcnet.rom
pc-bios/pxe-rtl8139.rom
pc-bios/pxe-virtio.rom
pc-bios/q35-acpi-dsdt.aml
pc-bios/qemu-icon.bmp
pc-bios/qemu-nsis.bmp
pc-bios/qemu-nsis.ico
pc-bios/qemu_logo.svg
pc-bios/qemu_logo_no_text.svg
pc-bios/s390-ccw.img
pc-bios/s390-zipl.rom
pc-bios/sgabios.bin
pc-bios/slof.bin
pc-bios/spapr-rtas.bin
pc-bios/u-boot.e500
pc-bios/vgabios-cirrus.bin
pc-bios/vgabios-qxl.bin
pc-bios/vgabios-stdvga.bin
pc-bios/vgabios-vmware.bin
pc-bios/vgabios.bin
pixman
po/Makefile
po/de_DE.po
po/fr_FR.po
po/hu.po
po/it.po
po/messages.po
po/tr.po
po/zh_CN.po
qdev-monitor.c
qdict-test-data.txt
qemu-bridge-helper.c
qemu-coroutine-io.c
qemu-coroutine-lock.c
qemu-coroutine-sleep.c
qemu-coroutine.c
qemu-doc.texi
qemu-file-stdio.c
qemu-file-unix.c
qemu-file.c
qemu-log.c
qemu-nbd.texi
qemu-options-wrapper.h
qemu-options.h
qemu-options.hx
qemu-tech.texi
qemu.nsi
qemu.sasl
qga/Makefile.objs
qga/channel-posix.c
qga/channel-win32.c
qga/channel.h
qga/commands-posix.c
qga/commands-win32.c
qga/commands.c
qga/guest-agent-command-state.c
qga/guest-agent-core.h
qga/main.c
qga/qapi-schema.json
qga/service-win32.c
qga/service-win32.h
qga/vss-win32.c
qga/vss-win32.h
qga/vss-win32/Makefile.objs
qga/vss-win32/install.cpp
qga/vss-win32/provider.cpp
qga/vss-win32/qga-vss.def
qga/vss-win32/qga-vss.idl
qga/vss-win32/qga-vss.tlb
qga/vss-win32/requester.cpp
qga/vss-win32/requester.h
qga/vss-win32/vss-common.h
qobject/Makefile.objs
qobject/json-lexer.c
qobject/json-parser.c
qobject/json-streamer.c
qobject/qbool.c
qobject/qdict.c
qobject/qerror.c
qobject/qfloat.c
qobject/qint.c
qobject/qjson.c
qobject/qlist.c
qobject/qstring.c
qtest.c
roms/Makefile
roms/SLOF
roms/config.ipxe.general.h
roms/config.seabios-128k
roms/config.seabios-256k
roms/config.vga-cirrus
roms/config.vga-isavga
roms/config.vga-qxl
roms/config.vga-stdvga
roms/config.vga-vmware
roms/configure-seabios.sh
roms/ipxe
roms/openbios
roms/openhackware
roms/qemu-palcode
roms/seabios
roms/sgabios
roms/u-boot
roms/vgabios
rules.mak
savevm.c
scripts/acpi_extract.py
scripts/acpi_extract_preprocess.py
scripts/analyse-9p-simpletrace.py
scripts/check-qerror.sh
scripts/cleanup-trace-events.pl
scripts/coverity-model.c
scripts/create_config
scripts/disas-objdump.pl
scripts/dump-guest-memory.py
scripts/extract-vsssdk-headers
scripts/feature_to_c.sh
scripts/get_maintainer.pl
scripts/gtester-cat
scripts/hxtool
scripts/kvm/kvm_flightrecorder
scripts/kvm/kvm_stat
scripts/kvm/vmxcap
scripts/make-release
scripts/make_device_config.sh
scripts/ordereddict.py
scripts/qapi-commands.py
scripts/qapi-event.py
scripts/qapi-types.py
scripts/qapi-visit.py
scripts/qapi.py
scripts/qemu-binfmt-conf.sh
scripts/qemu-gdb.py
scripts/qemu-guest-agent/fsfreeze-hook
scripts/qemu-guest-agent/fsfreeze-hook.d/mysql-flush.sh.sample
scripts/qmp/qemu-ga-client
scripts/qmp/qmp
scripts/qmp/qmp-shell
scripts/qmp/qmp.py
scripts/qmp/qom-fuse
scripts/qmp/qom-get
scripts/qmp/qom-list
scripts/qmp/qom-set
scripts/refresh-pxe-roms.sh
scripts/signrom.py
scripts/simpletrace.py
scripts/switch-timer-api
scripts/texi2pod.pl
scripts/update-acpi.sh
scripts/update-linux-headers.sh
scripts/vmstate-static-checker.py
spice-qemu-char.c
stubs/Makefile.objs
stubs/arch-query-cpu-def.c
stubs/bdrv-commit-all.c
stubs/blockdev.c
stubs/chr-baum-init.c
stubs/chr-msmouse.c
stubs/chr-testdev.c
stubs/clock-warp.c
stubs/cpu-get-clock.c
stubs/cpu-get-icount.c
stubs/cpus.c
stubs/dump.c
stubs/fd-register.c
stubs/fdset-add-fd.c
stubs/fdset-find-fd.c
stubs/fdset-get-fd.c
stubs/fdset-remove-fd.c
stubs/gdbstub.c
stubs/get-fd.c
stubs/get-next-serial.c
stubs/get-vm-name.c
stubs/iothread-lock.c
stubs/is-daemonized.c
stubs/machine-init-done.c
stubs/migr-blocker.c
stubs/mon-is-qmp.c
stubs/mon-printf.c
stubs/mon-set-error.c
stubs/monitor-init.c
stubs/notify-event.c
stubs/pci-drive-hot-add.c
stubs/qemu-chr-open-spice.c
stubs/qmp_pc_dimm_device_list.c
stubs/qtest.c
stubs/reset.c
stubs/runstate-check.c
stubs/set-fd-handler.c
stubs/slirp.c
stubs/sysbus.c
stubs/uuid.c
stubs/vc-init.c
stubs/vm-stop.c
stubs/vmstate.c
sysconfigs/target/target-x86_64.conf
target-m68k/Makefile.objs
target-m68k/cpu-qom.h
target-m68k/cpu.c
target-m68k/cpu.h
target-m68k/gdbstub.c
target-m68k/helper.c
target-m68k/helper.h
target-m68k/m68k-qreg.h
target-m68k/m68k-semi.c
target-m68k/op_helper.c
target-m68k/qregs.def
target-m68k/translate.c
tcg-runtime.c
tests/.gitignore
tests/Makefile
tests/acpi-test-data/pc/APIC
tests/acpi-test-data/pc/DSDT
tests/acpi-test-data/pc/FACP
tests/acpi-test-data/pc/FACS
tests/acpi-test-data/pc/HPET
tests/acpi-test-data/pc/SSDT
tests/acpi-test-data/q35/APIC
tests/acpi-test-data/q35/DSDT
tests/acpi-test-data/q35/FACP
tests/acpi-test-data/q35/FACS
tests/acpi-test-data/q35/HPET
tests/acpi-test-data/q35/MCFG
tests/acpi-test-data/q35/SSDT
tests/acpi-test-data/rebuild-expected-aml.sh
tests/ahci-test.c
tests/bios-tables-test.c
tests/boot-order-test.c
tests/check-block.sh
tests/check-qdict.c
tests/check-qfloat.c
tests/check-qint.c
tests/check-qjson.c
tests/check-qlist.c
tests/check-qom-interface.c
tests/check-qstring.c
tests/display-vga-test.c
tests/drive_del-test.c
tests/e1000-test.c
tests/eepro100-test.c
tests/endianness-test.c
tests/fdc-test.c
tests/fw_cfg-test.c
tests/hd-geo-test.c
tests/i440fx-test.c
tests/i82801b11-test.c
tests/ide-test.c
tests/ioh3420-test.c
tests/ipoctal232-test.c
tests/libqos/fw_cfg.c
tests/libqos/fw_cfg.h
tests/libqos/i2c-omap.c
tests/libqos/i2c.c
tests/libqos/i2c.h
tests/libqos/malloc-pc.c
tests/libqos/malloc-pc.h
tests/libqos/malloc.h
tests/libqos/pci-pc.c
tests/libqos/pci-pc.h
tests/libqos/pci.c
tests/libqos/pci.h
tests/libqos/usb.c
tests/libqos/usb.h
tests/libqos/virtio-pci.c
tests/libqos/virtio-pci.h
tests/libqos/virtio.c
tests/libqos/virtio.h
tests/libqtest.c
tests/libqtest.h
tests/m48t59-test.c
tests/multiboot/Makefile
tests/multiboot/libc.c
tests/multiboot/libc.h
tests/multiboot/link.ld
tests/multiboot/mmap.c
tests/multiboot/mmap.out
tests/multiboot/multiboot.h
tests/multiboot/run_test.sh
tests/multiboot/start.S
tests/ne2000-test.c
tests/pcnet-test.c
tests/pvpanic-test.c
tests/qemu-iotests-quick.sh
tests/rtc-test.c
tests/rtl8139-test.c
tests/spapr-phb-test.c
tests/tcg/Makefile
tests/tcg/hello-arm.c
tests/tcg/hello-i386.c
tests/tcg/hello-mips.c
tests/tcg/linux-test.c
tests/tcg/pi_10.com
tests/tcg/runcom.c
tests/tcg/sha1.c
tests/tcg/test-arm-iwmmxt.s
tests/tcg/test-i386-code16.S
tests/tcg/test-i386-fprem.c
tests/tcg/test-i386-muldiv.h
tests/tcg/test-i386-shift.h
tests/tcg/test-i386-ssse3.c
tests/tcg/test-i386-vm86.S
tests/tcg/test-i386.c
tests/tcg/test-i386.h
tests/tcg/test-mmap.c
tests/tcg/test_path.c
tests/tcg/testthread.c
tests/test-aio.c
tests/test-bitops.c
tests/test-coroutine.c
tests/test-cutils.c
tests/test-hbitmap.c
tests/test-int128.c
tests/test-iov.c
tests/test-mul64.c
tests/test-opts-visitor.c
tests/test-qdev-global-props.c
tests/test-qemu-opts.c
tests/test-qmp-commands.c
tests/test-qmp-event.c
tests/test-qmp-input-strict.c
tests/test-qmp-input-visitor.c
tests/test-qmp-output-visitor.c
tests/test-rfifolock.c
tests/test-string-input-visitor.c
tests/test-string-output-visitor.c
tests/test-thread-pool.c
tests/test-throttle.c
tests/test-visitor-serialization.c
tests/test-vmstate.c
tests/test-x86-cpuid.c
tests/test-xbzrle.c
tests/tmp105-test.c
tests/tpci200-test.c
tests/vhost-user-test.c
tests/virtio-balloon-test.c
tests/virtio-blk-test.c
tests/virtio-console-test.c
tests/virtio-net-test.c
tests/virtio-rng-test.c
tests/virtio-scsi-test.c
tests/virtio-serial-test.c
tests/vmstate-static-checker-data/dump1.json
tests/vmstate-static-checker-data/dump2.json
tests/vmxnet3-test.c
tests/wdt_ib700-test.c
thread-pool.c
tpm.c
trace-events
translate-all.h
util/Makefile.objs
util/acl.c
util/aes.c
util/bitmap.c
util/bitops.c
util/compatfd.c
util/crc32c.c
util/cutils.c
util/envlist.c
util/error.c
util/event_notifier-posix.c
util/event_notifier-win32.c
util/fifo8.c
util/getauxval.c
util/hbitmap.c
util/hexdump.c
util/host-utils.c
util/id.c
util/iov.c
util/module.c
util/notify.c
util/osdep.c
util/oslib-posix.c
util/oslib-win32.c
util/path.c
util/qemu-config.c
util/qemu-error.c
util/qemu-openpty.c
util/qemu-option.c
util/qemu-progress.c
util/qemu-sockets.c
util/qemu-thread-posix.c
util/qemu-thread-win32.c
util/qemu-timer-common.c
util/readline.c
util/rfifolock.c
util/throttle.c
util/unicode.c
util/uri.c
version.rc
vmstate.c
xbzrle.c
^ permalink raw reply [flat|nested] 55+ messages in thread
* Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered
2014-10-22 8:23 ` Markus Armbruster
@ 2014-10-22 9:00 ` Paolo Bonzini
2014-10-22 11:45 ` Markus Armbruster
2015-09-22 9:13 ` Markus Armbruster
1 sibling, 1 reply; 55+ messages in thread
From: Paolo Bonzini @ 2014-10-22 9:00 UTC (permalink / raw)
To: Markus Armbruster, qemu-devel
> Down to 491 our of 1841 (27%). Progress, but not quite enough.
I think a better analysis would be on patches, not files. Which is
really hard to do, of course.
But as a rule of thumb, tests/ and include/ patches should also touch
files outside those directories. Not many people, unfortunately, write
tests out of a whim. So I wouldn't care much about those.
Some low-hanging fruit:
> libcacard/Makefile
> libcacard/cac.c
> libcacard/cac.h
> libcacard/card_7816.c
> libcacard/card_7816.h
> libcacard/card_7816t.h
> libcacard/event.c
> libcacard/eventt.h
> libcacard/libcacard.pc.in
> libcacard/libcacard.syms
> libcacard/link_test.c
> libcacard/vcard.c
> libcacard/vcard.h
> libcacard/vcard_emul.h
> libcacard/vcard_emul_nss.c
> libcacard/vcard_emul_type.c
> libcacard/vcard_emul_type.h
> libcacard/vcardt.c
> libcacard/vcardt.h
> libcacard/vcardt_internal.h
> libcacard/vevent.h
> libcacard/vreader.c
> libcacard/vreader.h
> libcacard/vreadert.h
> libcacard/vscard_common.h
> libcacard/vscclient.c
Alon?
> libdecnumber/decContext.c
> libdecnumber/decNumber.c
> libdecnumber/dpd/decimal128.c
> libdecnumber/dpd/decimal128Local.h
> libdecnumber/dpd/decimal32.c
> libdecnumber/dpd/decimal64.c
Part of TCG PPC.
> qga/Makefile.objs
> qga/channel-posix.c
> qga/channel-win32.c
> qga/channel.h
> qga/commands-posix.c
> qga/commands-win32.c
> qga/commands.c
> qga/guest-agent-command-state.c
> qga/guest-agent-core.h
> qga/main.c
> qga/qapi-schema.json
> qga/service-win32.c
> qga/service-win32.h
> qga/vss-win32.c
> qga/vss-win32.h
> qga/vss-win32/Makefile.objs
> qga/vss-win32/install.cpp
> qga/vss-win32/provider.cpp
> qga/vss-win32/qga-vss.def
> qga/vss-win32/qga-vss.idl
> qga/vss-win32/qga-vss.tlb
> qga/vss-win32/requester.cpp
> qga/vss-win32/requester.h
> qga/vss-win32/vss-common.h
Mike Roth?
> qobject/Makefile.objs
> qobject/json-lexer.c
> qobject/json-parser.c
> qobject/json-streamer.c
> qobject/qbool.c
> qobject/qdict.c
> qobject/qerror.c
> qobject/qfloat.c
> qobject/qint.c
> qobject/qjson.c
> qobject/qlist.c
> qobject/qstring.c
Part of QMP.
Paolo
^ permalink raw reply [flat|nested] 55+ messages in thread
* Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered
2014-10-22 9:00 ` Paolo Bonzini
@ 2014-10-22 11:45 ` Markus Armbruster
2014-10-22 11:50 ` Paolo Bonzini
` (3 more replies)
0 siblings, 4 replies; 55+ messages in thread
From: Markus Armbruster @ 2014-10-22 11:45 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: Luiz Capitulino, qemu-devel, Michael Roth
Paolo Bonzini <pbonzini@redhat.com> writes:
>> Down to 491 our of 1841 (27%). Progress, but not quite enough.
>
> I think a better analysis would be on patches, not files. Which is
> really hard to do, of course.
>
> But as a rule of thumb, tests/ and include/ patches should also touch
> files outside those directories. Not many people, unfortunately, write
> tests out of a whim. So I wouldn't care much about those.
Focusing on non-test, non-header source code for now seems sensible.
> Some low-hanging fruit:
>
>> libcacard/Makefile
>> libcacard/cac.c
>> libcacard/cac.h
>> libcacard/card_7816.c
>> libcacard/card_7816.h
>> libcacard/card_7816t.h
>> libcacard/event.c
>> libcacard/eventt.h
>> libcacard/libcacard.pc.in
>> libcacard/libcacard.syms
>> libcacard/link_test.c
>> libcacard/vcard.c
>> libcacard/vcard.h
>> libcacard/vcard_emul.h
>> libcacard/vcard_emul_nss.c
>> libcacard/vcard_emul_type.c
>> libcacard/vcard_emul_type.h
>> libcacard/vcardt.c
>> libcacard/vcardt.h
>> libcacard/vcardt_internal.h
>> libcacard/vevent.h
>> libcacard/vreader.c
>> libcacard/vreader.h
>> libcacard/vreadert.h
>> libcacard/vscard_common.h
>> libcacard/vscclient.c
>
> Alon?
>
>> libdecnumber/decContext.c
>> libdecnumber/decNumber.c
>> libdecnumber/dpd/decimal128.c
>> libdecnumber/dpd/decimal128Local.h
>> libdecnumber/dpd/decimal32.c
>> libdecnumber/dpd/decimal64.c
>
> Part of TCG PPC.
Give me a name :)
>> qga/Makefile.objs
>> qga/channel-posix.c
>> qga/channel-win32.c
>> qga/channel.h
>> qga/commands-posix.c
>> qga/commands-win32.c
>> qga/commands.c
>> qga/guest-agent-command-state.c
>> qga/guest-agent-core.h
>> qga/main.c
>> qga/qapi-schema.json
>> qga/service-win32.c
>> qga/service-win32.h
>> qga/vss-win32.c
>> qga/vss-win32.h
>> qga/vss-win32/Makefile.objs
>> qga/vss-win32/install.cpp
>> qga/vss-win32/provider.cpp
>> qga/vss-win32/qga-vss.def
>> qga/vss-win32/qga-vss.idl
>> qga/vss-win32/qga-vss.tlb
>> qga/vss-win32/requester.cpp
>> qga/vss-win32/requester.h
>> qga/vss-win32/vss-common.h
>
> Mike Roth?
Cc'ed.
>> qobject/Makefile.objs
>> qobject/json-lexer.c
>> qobject/json-parser.c
>> qobject/json-streamer.c
>> qobject/qbool.c
>> qobject/qdict.c
>> qobject/qerror.c
>> qobject/qfloat.c
>> qobject/qint.c
>> qobject/qjson.c
>> qobject/qlist.c
>> qobject/qstring.c
>
> Part of QMP.
Cc'ing Luiz.
^ permalink raw reply [flat|nested] 55+ messages in thread
* Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered
2014-10-22 11:45 ` Markus Armbruster
@ 2014-10-22 11:50 ` Paolo Bonzini
2014-10-22 13:06 ` Markus Armbruster
2014-10-22 11:58 ` [Qemu-devel] MAINTAINERS: please add myself as usb-serial.c and baum.c maintainer Samuel Thibault
` (2 subsequent siblings)
3 siblings, 1 reply; 55+ messages in thread
From: Paolo Bonzini @ 2014-10-22 11:50 UTC (permalink / raw)
To: Markus Armbruster; +Cc: qemu-devel
On 10/22/2014 01:45 PM, Markus Armbruster wrote:
>> > Part of TCG PPC.
> Give me a name :)
>
This:
PowerPC
M: Alexander Graf <agraf@suse.de>
L: qemu-ppc@nongnu.org
S: Maintained
F: target-ppc/
F: hw/ppc/
Paolo
^ permalink raw reply [flat|nested] 55+ messages in thread
* [Qemu-devel] MAINTAINERS: please add myself as usb-serial.c and baum.c maintainer
2014-10-22 11:45 ` Markus Armbruster
2014-10-22 11:50 ` Paolo Bonzini
@ 2014-10-22 11:58 ` Samuel Thibault
2014-10-22 12:51 ` Paolo Bonzini
2014-10-22 13:00 ` Markus Armbruster
2014-10-22 12:06 ` [Qemu-devel] MAINTAINERS leaves too many files uncovered Michael Roth
2014-10-22 12:54 ` Luiz Capitulino
3 siblings, 2 replies; 55+ messages in thread
From: Samuel Thibault @ 2014-10-22 11:58 UTC (permalink / raw)
To: qemu-devel
Hello,
I've written mostly all of usb-serial.c and baum.c, and keep maintaining
them, since I use them regularly.
Samuel
^ permalink raw reply [flat|nested] 55+ messages in thread
* Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered
2014-10-22 11:45 ` Markus Armbruster
2014-10-22 11:50 ` Paolo Bonzini
2014-10-22 11:58 ` [Qemu-devel] MAINTAINERS: please add myself as usb-serial.c and baum.c maintainer Samuel Thibault
@ 2014-10-22 12:06 ` Michael Roth
2014-10-22 12:54 ` Luiz Capitulino
3 siblings, 0 replies; 55+ messages in thread
From: Michael Roth @ 2014-10-22 12:06 UTC (permalink / raw)
To: Markus Armbruster, Paolo Bonzini; +Cc: qemu-devel, Luiz Capitulino
Quoting Markus Armbruster (2014-10-22 06:45:44)
> Paolo Bonzini <pbonzini@redhat.com> writes:
>
> >> Down to 491 our of 1841 (27%). Progress, but not quite enough.
> >
> > I think a better analysis would be on patches, not files. Which is
> > really hard to do, of course.
> >
> > But as a rule of thumb, tests/ and include/ patches should also touch
> > files outside those directories. Not many people, unfortunately, write
> > tests out of a whim. So I wouldn't care much about those.
>
> Focusing on non-test, non-header source code for now seems sensible.
>
> > Some low-hanging fruit:
> >
> >> libcacard/Makefile
> >> libcacard/cac.c
> >> libcacard/cac.h
> >> libcacard/card_7816.c
> >> libcacard/card_7816.h
> >> libcacard/card_7816t.h
> >> libcacard/event.c
> >> libcacard/eventt.h
> >> libcacard/libcacard.pc.in
> >> libcacard/libcacard.syms
> >> libcacard/link_test.c
> >> libcacard/vcard.c
> >> libcacard/vcard.h
> >> libcacard/vcard_emul.h
> >> libcacard/vcard_emul_nss.c
> >> libcacard/vcard_emul_type.c
> >> libcacard/vcard_emul_type.h
> >> libcacard/vcardt.c
> >> libcacard/vcardt.h
> >> libcacard/vcardt_internal.h
> >> libcacard/vevent.h
> >> libcacard/vreader.c
> >> libcacard/vreader.h
> >> libcacard/vreadert.h
> >> libcacard/vscard_common.h
> >> libcacard/vscclient.c
> >
> > Alon?
> >
> >> libdecnumber/decContext.c
> >> libdecnumber/decNumber.c
> >> libdecnumber/dpd/decimal128.c
> >> libdecnumber/dpd/decimal128Local.h
> >> libdecnumber/dpd/decimal32.c
> >> libdecnumber/dpd/decimal64.c
> >
> > Part of TCG PPC.
>
> Give me a name :)
>
> >> qga/Makefile.objs
> >> qga/channel-posix.c
> >> qga/channel-win32.c
> >> qga/channel.h
> >> qga/commands-posix.c
> >> qga/commands-win32.c
> >> qga/commands.c
> >> qga/guest-agent-command-state.c
> >> qga/guest-agent-core.h
> >> qga/main.c
> >> qga/qapi-schema.json
> >> qga/service-win32.c
> >> qga/service-win32.h
> >> qga/vss-win32.c
> >> qga/vss-win32.h
> >> qga/vss-win32/Makefile.objs
> >> qga/vss-win32/install.cpp
> >> qga/vss-win32/provider.cpp
> >> qga/vss-win32/qga-vss.def
> >> qga/vss-win32/qga-vss.idl
> >> qga/vss-win32/qga-vss.tlb
> >> qga/vss-win32/requester.cpp
> >> qga/vss-win32/requester.h
> >> qga/vss-win32/vss-common.h
> >
> > Mike Roth?
>
> Cc'ed.
Of course, just never thought to add it. Just sent a patch for MAINTAINERS.
>
> >> qobject/Makefile.objs
> >> qobject/json-lexer.c
> >> qobject/json-parser.c
> >> qobject/json-streamer.c
> >> qobject/qbool.c
> >> qobject/qdict.c
> >> qobject/qerror.c
> >> qobject/qfloat.c
> >> qobject/qint.c
> >> qobject/qjson.c
> >> qobject/qlist.c
> >> qobject/qstring.c
> >
> > Part of QMP.
>
> Cc'ing Luiz.
^ permalink raw reply [flat|nested] 55+ messages in thread
* Re: [Qemu-devel] MAINTAINERS: please add myself as usb-serial.c and baum.c maintainer
2014-10-22 11:58 ` [Qemu-devel] MAINTAINERS: please add myself as usb-serial.c and baum.c maintainer Samuel Thibault
@ 2014-10-22 12:51 ` Paolo Bonzini
2014-10-22 13:00 ` Markus Armbruster
1 sibling, 0 replies; 55+ messages in thread
From: Paolo Bonzini @ 2014-10-22 12:51 UTC (permalink / raw)
To: Samuel Thibault, qemu-devel
Will do, thanks!
Paolo
On 10/22/2014 01:58 PM, Samuel Thibault wrote:
> Hello,
>
> I've written mostly all of usb-serial.c and baum.c, and keep maintaining
> them, since I use them regularly.
>
> Samuel
>
>
^ permalink raw reply [flat|nested] 55+ messages in thread
* Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered
2014-10-22 11:45 ` Markus Armbruster
` (2 preceding siblings ...)
2014-10-22 12:06 ` [Qemu-devel] MAINTAINERS leaves too many files uncovered Michael Roth
@ 2014-10-22 12:54 ` Luiz Capitulino
3 siblings, 0 replies; 55+ messages in thread
From: Luiz Capitulino @ 2014-10-22 12:54 UTC (permalink / raw)
To: Markus Armbruster; +Cc: Paolo Bonzini, qemu-devel, Michael Roth
On Wed, 22 Oct 2014 13:45:44 +0200
Markus Armbruster <armbru@redhat.com> wrote:
> >> qobject/Makefile.objs
> >> qobject/json-lexer.c
> >> qobject/json-parser.c
> >> qobject/json-streamer.c
> >> qobject/qbool.c
> >> qobject/qdict.c
> >> qobject/qerror.c
> >> qobject/qfloat.c
> >> qobject/qint.c
> >> qobject/qjson.c
> >> qobject/qlist.c
> >> qobject/qstring.c
> >
> > Part of QMP.
>
> Cc'ing Luiz.
Will send a patch.
^ permalink raw reply [flat|nested] 55+ messages in thread
* Re: [Qemu-devel] MAINTAINERS: please add myself as usb-serial.c and baum.c maintainer
2014-10-22 11:58 ` [Qemu-devel] MAINTAINERS: please add myself as usb-serial.c and baum.c maintainer Samuel Thibault
2014-10-22 12:51 ` Paolo Bonzini
@ 2014-10-22 13:00 ` Markus Armbruster
2014-10-22 13:53 ` Samuel Thibault
1 sibling, 1 reply; 55+ messages in thread
From: Markus Armbruster @ 2014-10-22 13:00 UTC (permalink / raw)
To: Samuel Thibault; +Cc: qemu-devel
Samuel Thibault <samuel.thibault@ens-lyon.org> writes:
> Hello,
>
> I've written mostly all of usb-serial.c and baum.c, and keep maintaining
> them, since I use them regularly.
Please post the obvious patch to MAINTAINERS then :)
^ permalink raw reply [flat|nested] 55+ messages in thread
* Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered
2014-10-22 11:50 ` Paolo Bonzini
@ 2014-10-22 13:06 ` Markus Armbruster
2014-10-22 13:22 ` Alexander Graf
2014-10-22 13:36 ` Paolo Bonzini
0 siblings, 2 replies; 55+ messages in thread
From: Markus Armbruster @ 2014-10-22 13:06 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: qemu-devel, Alexander Graf
Paolo Bonzini <pbonzini@redhat.com> writes:
> On 10/22/2014 01:45 PM, Markus Armbruster wrote:
>>> > Part of TCG PPC.
>> Give me a name :)
>>
>
> This:
>
> PowerPC
> M: Alexander Graf <agraf@suse.de>
> L: qemu-ppc@nongnu.org
> S: Maintained
> F: target-ppc/
> F: hw/ppc/
>
> Paolo
Something like this, I presume:
diff --git a/MAINTAINERS b/MAINTAINERS
index e52e75c..52ac491 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -138,6 +138,7 @@ L: qemu-ppc@nongnu.org
S: Maintained
F: target-ppc/
F: hw/ppc/
+F: libdecnumber
S390
M: Richard Henderson <rth@twiddle.net>
^ permalink raw reply [flat|nested] 55+ messages in thread
* Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered
2014-10-22 13:06 ` Markus Armbruster
@ 2014-10-22 13:22 ` Alexander Graf
2014-10-22 13:36 ` Paolo Bonzini
1 sibling, 0 replies; 55+ messages in thread
From: Alexander Graf @ 2014-10-22 13:22 UTC (permalink / raw)
To: Markus Armbruster, Paolo Bonzini; +Cc: qemu-devel
On 22.10.14 15:06, Markus Armbruster wrote:
> Paolo Bonzini <pbonzini@redhat.com> writes:
>
>> On 10/22/2014 01:45 PM, Markus Armbruster wrote:
>>>>> Part of TCG PPC.
>>> Give me a name :)
>>>
>>
>> This:
>>
>> PowerPC
>> M: Alexander Graf <agraf@suse.de>
>> L: qemu-ppc@nongnu.org
>> S: Maintained
>> F: target-ppc/
>> F: hw/ppc/
>>
>> Paolo
>
> Something like this, I presume:
I think the best way to figure these out would be to have checkpatch.pl
check whether an unmaintained file gets introduced. If that happens,
warn the user.
I always run checkpatch.pl on every patch I apply.
Alex
^ permalink raw reply [flat|nested] 55+ messages in thread
* Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered
2014-10-22 13:06 ` Markus Armbruster
2014-10-22 13:22 ` Alexander Graf
@ 2014-10-22 13:36 ` Paolo Bonzini
1 sibling, 0 replies; 55+ messages in thread
From: Paolo Bonzini @ 2014-10-22 13:36 UTC (permalink / raw)
To: Markus Armbruster; +Cc: qemu-devel, Alexander Graf
On 10/22/2014 03:06 PM, Markus Armbruster wrote:
> Paolo Bonzini <pbonzini@redhat.com> writes:
>
>> On 10/22/2014 01:45 PM, Markus Armbruster wrote:
>>>>> Part of TCG PPC.
>>> Give me a name :)
>>>
>>
>> This:
>>
>> PowerPC
>> M: Alexander Graf <agraf@suse.de>
>> L: qemu-ppc@nongnu.org
>> S: Maintained
>> F: target-ppc/
>> F: hw/ppc/
>>
>> Paolo
>
> Something like this, I presume:
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index e52e75c..52ac491 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -138,6 +138,7 @@ L: qemu-ppc@nongnu.org
> S: Maintained
> F: target-ppc/
> F: hw/ppc/
> +F: libdecnumber
with a slash at the end :)
Paolo
^ permalink raw reply [flat|nested] 55+ messages in thread
* Re: [Qemu-devel] MAINTAINERS: please add myself as usb-serial.c and baum.c maintainer
2014-10-22 13:00 ` Markus Armbruster
@ 2014-10-22 13:53 ` Samuel Thibault
2014-10-22 15:21 ` Markus Armbruster
0 siblings, 1 reply; 55+ messages in thread
From: Samuel Thibault @ 2014-10-22 13:53 UTC (permalink / raw)
To: Markus Armbruster; +Cc: qemu-devel
Markus Armbruster, le Wed 22 Oct 2014 15:00:20 +0200, a écrit :
> Samuel Thibault <samuel.thibault@ens-lyon.org> writes:
>
> > I've written mostly all of usb-serial.c and baum.c, and keep maintaining
> > them, since I use them regularly.
>
> Please post the obvious patch to MAINTAINERS then :)
Well, it wasn't obvious to me where in MAINTAINERS these would have to
go. I guess what Paolo suggested will be fine.
Samuel
^ permalink raw reply [flat|nested] 55+ messages in thread
* Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered
2014-10-20 9:19 [Qemu-devel] MAINTAINERS leaves too many files uncovered Markus Armbruster
2014-10-20 18:36 ` Paolo Bonzini
2014-10-22 8:23 ` Markus Armbruster
@ 2014-10-22 14:02 ` Alex Bennée
2014-10-22 15:26 ` Markus Armbruster
2 siblings, 1 reply; 55+ messages in thread
From: Alex Bennée @ 2014-10-22 14:02 UTC (permalink / raw)
To: Markus Armbruster; +Cc: qemu-devel
Markus Armbruster <armbru@redhat.com> writes:
> In my experience, too many files are not covered by MAINTAINERS.
> scripts/get_maintainer.pl falls back to git then, unless you say
> --no-git-fallback. Copies sent there tends to annoy their recipients
> without accomplishing all that much.
>
> Two obvious improvements:
>
> * Easy: Flip scripts/get_maintainer.pl's default to --no-git-fallback.
> I'll post the obvious patch, please raise your objections there.
As it happens I do that in my .git/config, but...
> * Harder: improve MAINTAINERS coverage.
Well one problem is no MAINTAINER == no obvious tree to take you
patches. This is my main bugbear. I have a few patch series that touch a
smattering of files (e.g. logging improvements) that don't fall under
one particular sub-system but are probably a little too broad for the
trivial tree.
> Where are the unmaintained files? Top-scoring directories outside
> tests/ and include/, files in subdirs not counted:
>
> #files directory
> 84 68% .
I suspect there is a bunch of general infrastructure bits that has this
sort of property. Maybe some effort be made to move related bits into
sub-directories (with MAINTAINERS) where they are less likely to fall
in-between the cracks?
<snip>
> Ideas? Takers?
My 0.2c ;-)
--
Alex Bennée
^ permalink raw reply [flat|nested] 55+ messages in thread
* Re: [Qemu-devel] MAINTAINERS: please add myself as usb-serial.c and baum.c maintainer
2014-10-22 13:53 ` Samuel Thibault
@ 2014-10-22 15:21 ` Markus Armbruster
0 siblings, 0 replies; 55+ messages in thread
From: Markus Armbruster @ 2014-10-22 15:21 UTC (permalink / raw)
To: Samuel Thibault; +Cc: qemu-devel
Samuel Thibault <samuel.thibault@gnu.org> writes:
> Markus Armbruster, le Wed 22 Oct 2014 15:00:20 +0200, a écrit :
>> Samuel Thibault <samuel.thibault@ens-lyon.org> writes:
>>
>> > I've written mostly all of usb-serial.c and baum.c, and keep maintaining
>> > them, since I use them regularly.
>>
>> Please post the obvious patch to MAINTAINERS then :)
>
> Well, it wasn't obvious to me where in MAINTAINERS these would have to
> go. I guess what Paolo suggested will be fine.
Yes. Please reply to it with your S-o-b.
^ permalink raw reply [flat|nested] 55+ messages in thread
* Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered
2014-10-22 14:02 ` Alex Bennée
@ 2014-10-22 15:26 ` Markus Armbruster
0 siblings, 0 replies; 55+ messages in thread
From: Markus Armbruster @ 2014-10-22 15:26 UTC (permalink / raw)
To: Alex Bennée; +Cc: qemu-devel
Alex Bennée <alex.bennee@linaro.org> writes:
> Markus Armbruster <armbru@redhat.com> writes:
>
>> In my experience, too many files are not covered by MAINTAINERS.
>> scripts/get_maintainer.pl falls back to git then, unless you say
>> --no-git-fallback. Copies sent there tends to annoy their recipients
>> without accomplishing all that much.
>>
>> Two obvious improvements:
>>
>> * Easy: Flip scripts/get_maintainer.pl's default to --no-git-fallback.
>> I'll post the obvious patch, please raise your objections there.
>
> As it happens I do that in my .git/config, but...
>
>> * Harder: improve MAINTAINERS coverage.
>
> Well one problem is no MAINTAINER == no obvious tree to take you
> patches. This is my main bugbear. I have a few patch series that touch a
> smattering of files (e.g. logging improvements) that don't fall under
> one particular sub-system but are probably a little too broad for the
> trivial tree.
I've been there quite a few times. No easy answers.
>> Where are the unmaintained files? Top-scoring directories outside
>> tests/ and include/, files in subdirs not counted:
>>
>> #files directory
>> 84 68% .
>
> I suspect there is a bunch of general infrastructure bits that has this
> sort of property. Maybe some effort be made to move related bits into
> sub-directories (with MAINTAINERS) where they are less likely to fall
> in-between the cracks?
No objection to moving stuff to more appropriate homes. But it's not
necessary for MAINTAINERS coverage. Just add the necessary F: lines.
> <snip>
>
>> Ideas? Takers?
>
> My 0.2c ;-)
Thanks!
^ permalink raw reply [flat|nested] 55+ messages in thread
* Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered
2014-10-22 8:23 ` Markus Armbruster
2014-10-22 9:00 ` Paolo Bonzini
@ 2015-09-22 9:13 ` Markus Armbruster
2015-09-22 10:06 ` Daniel P. Berrange
` (5 more replies)
1 sibling, 6 replies; 55+ messages in thread
From: Markus Armbruster @ 2015-09-22 9:13 UTC (permalink / raw)
To: qemu-devel
Paolo asked for an update.
Markus Armbruster <armbru@redhat.com> writes:
> Markus Armbruster <armbru@redhat.com> writes:
>
>> In my experience, too many files are not covered by MAINTAINERS.
>> scripts/get_maintainer.pl falls back to git then, unless you say
>> --no-git-fallback. Copies sent there tends to annoy their recipients
>> without accomplishing all that much.
>>
>> Two obvious improvements:
>>
>> * Easy: Flip scripts/get_maintainer.pl's default to --no-git-fallback.
>> I'll post the obvious patch, please raise your objections there.
>>
>> * Harder: improve MAINTAINERS coverage.
>
> A few folks have started doing that. Much appreciated!
>
> I collected recent patches to MAINTAINERS, and reran my analysis.
>
>> Let me back up subjective experience with hard data. The tree has quite
>> a few files:
>>
>> $ git-ls-files | wc -l
>> 3746
>
> Now 3752.
Eleven months later, this is 4387.
>> Counting them by extension:
>>
>> $ git-ls-files | sed -n 's#.*/##;s#.*\.##p' | sort | uniq -c | sort -nr
>> 1836 c
>> 818 h
>> 133 out
>> 105 S
>> 97 objs
>> 69 s
>> 64 mak
>> 48 json
>> 47 py
>> 41 txt
>> 33 exit
>> 33 err
>> 16 xml
>> 16 bin
>> 13 rom
>> 12 sh
>> 12 dsl
>> [Long tail that doesn't add up to anything interesting omitted]
>>
>> Let's look for .c not in MAINTAINERS:
>>
>> $ for i in `git-ls-files`; do [ "`scripts/get_maintainer.pl -f
> --no-git-fallback $i`" ] || echo $i; done >unmaintained-files
>> $ grep -c '\.c$' unmaintained-files
>> 1066
>>
>> That's almost 60%. Not good.
>
> Down to 491 our of 1841 (27%). Progress, but not quite enough.
461 out of 1945 (24%). At this linear rate, we'll reach 10%
unmaintained in five years.
We're still adding unmaintained .c files:
$ git-diff --diff-filter=A --name-only e668d1b | grep -c '\.c$'
116
$ git-diff --diff-filter=A --name-only e668d1b | grep '\.c$' | join unmaintained-files - | wc -l
37
37 out of 116 new files (32%) are not covered. That's worse than we do
for old files. Inexcusable.
>> Apparently, nobody cares for tests:
>>
>> $ grep '^tests/' unmaintained-files | grep -c '\.c$'
>> 654
>> $ git-ls-files | grep '^tests/' | grep -c '\.c$'
>> 664
>
> Now 91 out of 665.
105 out of 687.
>> Filtering those out leaves us with 412 unmaintained out of of 1172, or
>> 35% unmaintained. Not good even if we (foolishly!) considered tests not
>> worthy of maintenance.
>>
>> Maybe unmaintained files are much smaller. David A. Wheeler's
>> SLOCCount counts 570kSLOC in 1212 maintained files (+140 files sloccount
>> doesn't know how to count) vs. 300kSLOC in 1798 unmaintained files (+596
>> uncounted), or 35% unmaintained SLOC. With tests/ ignored, it's 30%.
>> So, unmaintained files are indeed smaller, but 30-something percent is
>> still not good.
>>
>> Where are the unmaintained files? Top-scoring directories outside
>> tests/ and include/, files in subdirs not counted:
>>
>> #files directory
>> 84 68% .
>> 63 100% default-configs
>> 48 100% pc-bios
>> 43 97% stubs
>> 39 100% util
>> 37 100% pc-bios/keymaps
>> 35 81% hw/display
>> 32 94% scripts
>> 26 92% docs
>> 26 100% libcacard
>> 23 69% hw/misc
>> 22 57% hw/net
>> 21 63% hw/intc
>> 19 100% roms
>> 18 100% disas
>> 18 56% hw/timer
>> 16 100% hw/core
>> 15 53% hw/char
>> 15 100% qga
>> 14 100% docs/specs
>> 12 92% hw/input
>> 12 100% qobject
>> 12 100% target-m68k
>> 11 100% backends
>> 11 100% pc-bios/s390-ccw
>> 10 71% hw/dma
Different tack: what are the unmaintained files we actually change?
Unmaintained files sorted by number of commits in the past year (commit
1733681):
$ for i in `cat unmaintained-files`; do echo -n "$i "; git-rev-list 1733681.. $i | wc -l; done | awk '{ printf "%7d %s\n", $2, $1 }' | sort -rn | head -n 100
79 trace-events
77 MAINTAINERS
74 tests/Makefile
37 hw/core/qdev.c
35 arch_init.c
33 tests/libqos/ahci.c
30 tests/libqos/ahci.h
27 qdev-monitor.c
27 include/hw/boards.h
27 Makefile
26 include/exec/exec-all.h
25 include/hw/virtio/virtio.h
24 hw/xen/xen_pt_config_init.c
23 include/hw/virtio/virtio-scsi.h
22 util/qemu-option.c
22 hw/net/rtl8139.c
22 hw/intc/arm_gic.c
22 VERSION
21 target-tilegx/translate.c
21 include/ui/console.h
21 include/hw/qdev-core.h
19 include/qemu-common.h
19 hw/xen/xen_pt.c
19 hw/display/vga.c
18 include/exec/cpu-all.h
18 disas/mips.c
17 hw/nvram/fw_cfg.c
15 include/sysemu/blockdev.h
15 include/sysemu/block-backend.h
15 hw/core/machine.c
15 default-configs/arm-softmmu.mak
15 accel.c
14 hw/net/dp8393x.c
13 include/qemu/timer.h
13 include/qemu/option.h
13 include/qapi/qmp/qerror.h
13 include/exec/ram_addr.h
13 hw/xen/xen_pt.h
13 hw/core/qdev-properties.c
13 hw/core/loader.c
12 qemu-doc.texi
12 include/sysemu/kvm.h
12 hw/tpm/tpm_tis.c
12 hw/sd/sdhci.c
12 hmp.h
11 util/qemu-sockets.c
11 util/qemu-config.c
11 util/cutils.c
11 scripts/kvm/kvm_stat
11 include/qemu/typedefs.h
11 include/hw/scsi/scsi.h
11 hw/intc/arm_gic_kvm.c
11 hw/char/serial.c
10 util/rcu.c
10 tests/test-qmp-output-visitor.c
10 target-m68k/translate.c
10 scripts/update-linux-headers.sh
10 qtest.c
10 include/ui/sdl2.h
10 include/monitor/monitor.h
10 include/hw/virtio/virtio-blk.h
10 include/hw/intc/arm_gic_common.h
10 hw/core/qdev-properties-system.c
10 Makefile.objs
9 tpm.c
9 tests/virtio-blk-test.c
9 tests/test-qmp-input-visitor.c
9 tests/bios-tables-test.c
9 hw/net/e1000.c
9 hw/intc/arm_gic_common.c
9 hw/display/vga-pci.c
9 hw/display/cirrus_vga.c
9 hw/core/sysbus.c
9 dma-helpers.c
8 tests/.gitignore
8 include/hw/sysbus.h
8 include/hw/qdev-properties.h
8 include/hw/loader.h
8 hw/tpm/tpm_passthrough.c
8 hw/net/pcnet.c
8 hw/misc/ivshmem.c
8 hw/intc/armv7m_nvic.c
8 hw/display/vmware_vga.c
8 default-configs/x86_64-softmmu.mak
8 default-configs/i386-softmmu.mak
8 balloon.c
7 util/uri.c
7 tests/libqtest.c
7 tests/libqos/malloc.c
7 tests/libqos/libqos.h
7 tests/libqos/libqos.c
7 tests/drive_del-test.c
7 tests/acpi-test-data/q35/SSDT
7 include/qemu/osdep.h
7 include/fpu/softfloat.h
7 include/exec/cpu-defs.h
7 hw/timer/mc146818rtc.c
7 hw/pci-bridge/pci_bridge_dev.c
7 hw/net/ne2000.c
7 hw/isa/vt82c686.c
Sorted by maximum(added lines, deleted lines), top scorers:
$ git-diff --numstat 1733681 `cat unmaintained-files ` | awk '{ print ($1 > $2 ? $1 : $2), $0 }' | sort -nr | sed 's/^[0-9]* //' | head -n 100
2161 0 target-tilegx/translate.c
1504 0 pc-bios/qemu.rsrc
1406 0 target-tilegx/opcode_tilegx.h
1255 0 tests/test-cutils.c
1203 0 include/standard-headers/linux/input.h
1 1112 arch_init.c
1104 0 tests/pkix_asn1_tab.c
1039 767 fpu/softfloat.c
1014 0 docs/specs/rocker.txt
962 0 tests/libqos/ahci.c
924 4 disas/mips.c
908 0 include/standard-headers/linux/pci_regs.h
609 150 hw/intc/arm_gic.c
597 0 scripts/analyze-migration.py
586 0 tests/libqos/ahci.h
565 119 hw/display/tcx.c
485 0 tests/crypto-tls-x509-helpers.c
465 0 tests/tco-test.c
463 0 tests/rcutorture.c
439 0 hw/display/vga-helpers.h
423 56 trace-events
414 237 disas/libvixl/a64/assembler-a64.h
404 50 MAINTAINERS
390 0 docs/rcu.txt
385 172 hw/xen/xen_pt_config_init.c
374 0 tests/libqos/malloc.c
352 0 util/rcu.c
352 0 docs/bitmaps.md
264 334 hw/net/rtl8139.c
328 0 hw/timer/stm32f2xx_timer.c
141 322 hw/display/vga.c
316 0 tests/test-rcu-list.c
305 0 docs/specs/ppc-spapr-hotplug.txt
302 0 tests/check-qom-proplist.c
295 4 tests/test-hbitmap.c
7 289 tests/libqos/malloc-pc.c
282 77 hw/core/qdev.c
280 105 disas/libvixl/a64/disasm-a64.cc
275 0 include/hw/xen/xen_common.h
274 143 tests/virtio-blk-test.c
272 0 hw/xen/xen_pt_graphics.c
254 0 include/standard-headers/asm-x86/hyperv.h
252 101 hw/timer/m48t59.c
252 0 hw/core/platform-bus.c
249 0 include/hw/arm/fsl-imx25.h
247 5 tests/virtio-scsi-test.c
246 201 include/fpu/softfloat.h
245 0 include/standard-headers/linux/virtio_net.h
240 0 tests/libqos/libqos.c
239 6 tests/virtio-net-test.c
239 223 hw/dma/rc4030.c
237 105 hw/nvram/fw_cfg.c
235 140 qdev-monitor.c
232 0 hw/char/stm32f2xx_usart.c
225 49 hw/tpm/tpm_tis.c
188 219 dump.c
217 0 hw/gpio/mpc8xxx.c
216 0 target-tilegx/spr_def_64.h
213 91 hw/xen/xen_pt.c
209 0 tests/libqos/i2c-imx.c
206 0 include/standard-headers/linux/virtio_gpu.h
202 203 hw/net/dp8393x.c
199 0 include/standard-headers/linux/virtio_pci.h
198 0 tests/libqos/virtio-mmio.c
2 193 include/hw/virtio/virtio-net.h
192 0 hw/intc/arm_gicv2m.c
189 9 hw/core/machine.c
181 0 tests/rtl8139-test.c
179 0 target-tilegx/cpu.h
173 82 tests/Makefile
173 0 target-tilegx/cpu.c
173 0 include/sysemu/block-backend.h
172 0 include/standard-headers/linux/virtio_scsi.h
172 0 include/standard-headers/linux/virtio_ring.h
171 96 fpu/softfloat-specialize.h
166 53 scripts/kvm/kvm_stat
164 34 qtest.c
164 0 docs/qcow2-cache.txt
163 53 hw/display/vga-pci.c
161 0 docs/blkdebug.txt
160 23 util/cutils.c
160 0 hw/misc/stm32f2xx_syscfg.c
158 31 include/exec/ram_addr.h
7 157 disas/microblaze.c
157 0 accel.c
156 0 include/qemu/rcu.h
154 0 hw/pci-host/gpex.c
152 0 docs/aio_notify_accept.promela
149 0 include/hw/vfio/vfio-common.h
149 0 docs/multi-thread-compression.txt
138 148 hw/intc/openpic.c
147 103 util/qemu-option.c
147 0 include/standard-headers/linux/virtio_blk.h
146 0 tests/pc-cpu-test.c
144 44 tests/test-throttle.c
142 0 include/hw/virtio/virtio-gpu.h
140 0 docs/aio_notify_bug.promela
139 0 include/qemu/host-utils.h
137 0 tests/drive_del-test.c
137 0 qemu-ga.texi
>>
>> Ideas? Takers?
>
> Full list of unmaintained files now:
[...]
.exrc
.gitignore
.gitmodules
.mailmap
.travis.yml
CODING_STYLE
COPYING
COPYING.LIB
Changelog
HACKING
LICENSE
MAINTAINERS
Makefile
Makefile.objs
README
VERSION
accel.c
arch_init.c
backends/Makefile.objs
backends/hostmem-file.c
backends/hostmem-ram.c
backends/tpm.c
balloon.c
bt-host.c
bt-vhci.c
coroutine-gthread.c
coroutine-sigaltstack.c
coroutine-ucontext.c
cpu-exec-common.c
default-configs/aarch64-linux-user.mak
default-configs/aarch64-softmmu.mak
default-configs/alpha-linux-user.mak
default-configs/alpha-softmmu.mak
default-configs/arm-linux-user.mak
default-configs/arm-softmmu.mak
default-configs/armeb-linux-user.mak
default-configs/cris-linux-user.mak
default-configs/cris-softmmu.mak
default-configs/i386-bsd-user.mak
default-configs/i386-linux-user.mak
default-configs/i386-softmmu.mak
default-configs/lm32-softmmu.mak
default-configs/m68k-linux-user.mak
default-configs/m68k-softmmu.mak
default-configs/microblaze-linux-user.mak
default-configs/microblaze-softmmu.mak
default-configs/microblazeel-linux-user.mak
default-configs/microblazeel-softmmu.mak
default-configs/mips-linux-user.mak
default-configs/mips-softmmu.mak
default-configs/mips64-linux-user.mak
default-configs/mips64-softmmu.mak
default-configs/mips64el-linux-user.mak
default-configs/mips64el-softmmu.mak
default-configs/mipsel-linux-user.mak
default-configs/mipsel-softmmu.mak
default-configs/mipsn32-linux-user.mak
default-configs/mipsn32el-linux-user.mak
default-configs/moxie-softmmu.mak
default-configs/or32-linux-user.mak
default-configs/or32-softmmu.mak
default-configs/pci.mak
default-configs/ppc-linux-user.mak
default-configs/ppc-softmmu.mak
default-configs/ppc64-linux-user.mak
default-configs/ppc64-softmmu.mak
default-configs/ppc64abi32-linux-user.mak
default-configs/ppc64le-linux-user.mak
default-configs/ppcemb-softmmu.mak
default-configs/s390x-linux-user.mak
default-configs/s390x-softmmu.mak
default-configs/sh4-linux-user.mak
default-configs/sh4-softmmu.mak
default-configs/sh4eb-linux-user.mak
default-configs/sh4eb-softmmu.mak
default-configs/sound.mak
default-configs/sparc-bsd-user.mak
default-configs/sparc-linux-user.mak
default-configs/sparc-softmmu.mak
default-configs/sparc32plus-linux-user.mak
default-configs/sparc64-bsd-user.mak
default-configs/sparc64-linux-user.mak
default-configs/sparc64-softmmu.mak
default-configs/tilegx-linux-user.mak
default-configs/tricore-softmmu.mak
default-configs/unicore32-linux-user.mak
default-configs/unicore32-softmmu.mak
default-configs/usb.mak
default-configs/x86_64-bsd-user.mak
default-configs/x86_64-linux-user.mak
default-configs/x86_64-softmmu.mak
default-configs/xtensa-softmmu.mak
default-configs/xtensaeb-softmmu.mak
device-hotplug.c
disas.c
disas/Makefile.objs
disas/alpha.c
disas/arm-a64.cc
disas/arm.c
disas/cris.c
disas/hppa.c
disas/i386.c
disas/ia64.c
disas/libvixl/LICENCE
disas/libvixl/Makefile.objs
disas/libvixl/README
disas/libvixl/a64/assembler-a64.h
disas/libvixl/a64/constants-a64.h
disas/libvixl/a64/cpu-a64.h
disas/libvixl/a64/decoder-a64.cc
disas/libvixl/a64/decoder-a64.h
disas/libvixl/a64/disasm-a64.cc
disas/libvixl/a64/disasm-a64.h
disas/libvixl/a64/instructions-a64.cc
disas/libvixl/a64/instructions-a64.h
disas/libvixl/code-buffer.h
disas/libvixl/globals.h
disas/libvixl/platform.h
disas/libvixl/utils.cc
disas/libvixl/utils.h
disas/microblaze.c
disas/mips.c
disas/moxie.c
disas/ppc.c
disas/s390.c
disas/sh4.c
disas/sparc.c
disas/tci.c
dma-helpers.c
docs/aio_notify.promela
docs/aio_notify_accept.promela
docs/aio_notify_bug.promela
docs/atomics.txt
docs/bitmaps.md
docs/blkdebug.txt
docs/blkverify.txt
docs/bootindex.txt
docs/ccid.txt
docs/ich9-ehci-uhci.cfg
docs/image-fuzzer.txt
docs/libcacard.txt
docs/live-block-ops.txt
docs/memory-hotplug.txt
docs/memory.txt
docs/migration.txt
docs/multi-thread-compression.txt
docs/multiple-iothreads.txt
docs/multiseat.txt
docs/q35-chipset.cfg
docs/qcow2-cache.txt
docs/qdev-device-use.txt
docs/qemupciserial.inf
docs/rcu.txt
docs/rdma.txt
docs/specs/acpi_cpu_hotplug.txt
docs/specs/acpi_mem_hotplug.txt
docs/specs/acpi_pci_hotplug.txt
docs/specs/edu.txt
docs/specs/ivshmem_device_spec.txt
docs/specs/pci-ids.txt
docs/specs/pci-serial.txt
docs/specs/pci-testdev.txt
docs/specs/ppc-spapr-hcalls.txt
docs/specs/ppc-spapr-hotplug.txt
docs/specs/pvpanic.txt
docs/specs/qcow2.txt
docs/specs/qed_spec.txt
docs/specs/rocker.txt
docs/specs/standard-vga.txt
docs/specs/vhost-user.txt
docs/specs/vmw_pvscsi-spec.txt
docs/spice-port-fqdn.txt
docs/usb-storage.txt
docs/usb2.txt
docs/virtio-balloon-stats.txt
docs/vnc-ledstate-Pseudo-encoding.txt
docs/writing-qmp-commands.txt
docs/xbzrle.txt
dtc
dump.c
fpu/softfloat-macros.h
fpu/softfloat-specialize.h
fpu/softfloat.c
hmp.h
hw/Makefile.objs
hw/bt/Makefile.objs
hw/bt/core.c
hw/bt/hci-csr.c
hw/bt/hci.c
hw/bt/hid.c
hw/bt/l2cap.c
hw/bt/sdp.c
hw/char/Makefile.objs
hw/char/debugcon.c
hw/char/escc.c
hw/char/ipoctal232.c
hw/char/mcf_uart.c
hw/char/parallel.c
hw/char/pl011.c
hw/char/sclpconsole-lm.c
hw/char/sclpconsole.c
hw/char/serial-isa.c
hw/char/serial-pci.c
hw/char/serial.c
hw/char/sh_serial.c
hw/char/stm32f2xx_usart.c
hw/char/xen_console.c
hw/core/Makefile.objs
hw/core/empty_slot.c
hw/core/fw-path-provider.c
hw/core/hotplug.c
hw/core/irq.c
hw/core/loader.c
hw/core/machine.c
hw/core/nmi.c
hw/core/null-machine.c
hw/core/platform-bus.c
hw/core/ptimer.c
hw/core/qdev-properties-system.c
hw/core/qdev-properties.c
hw/core/qdev.c
hw/core/stream.c
hw/core/sysbus.c
hw/core/uboot_image.h
hw/cpu/Makefile.objs
hw/cpu/realview_mpcore.c
hw/display/Makefile.objs
hw/display/ads7846.c
hw/display/blizzard.c
hw/display/blizzard_template.h
hw/display/cg3.c
hw/display/cirrus_vga.c
hw/display/cirrus_vga_rop.h
hw/display/cirrus_vga_rop2.h
hw/display/framebuffer.c
hw/display/framebuffer.h
hw/display/g364fb.c
hw/display/jazz_led.c
hw/display/pl110.c
hw/display/pl110_template.h
hw/display/pxa2xx_lcd.c
hw/display/pxa2xx_template.h
hw/display/sm501.c
hw/display/sm501_template.h
hw/display/ssd0303.c
hw/display/ssd0323.c
hw/display/tc6393xb.c
hw/display/tc6393xb_template.h
hw/display/tcx.c
hw/display/vga-helpers.h
hw/display/vga-isa-mm.c
hw/display/vga-isa.c
hw/display/vga-pci.c
hw/display/vga.c
hw/display/vga.h
hw/display/vga_int.h
hw/display/vmware_vga.c
hw/display/xenfb.c
hw/dma/Makefile.objs
hw/dma/i82374.c
hw/dma/i8257.c
hw/dma/pl080.c
hw/dma/pl330.c
hw/dma/pxa2xx_dma.c
hw/dma/rc4030.c
hw/dma/soc_dma.c
hw/dma/sparc32_dma.c
hw/dma/sun4m_iommu.c
hw/gpio/Makefile.objs
hw/gpio/max7310.c
hw/gpio/mpc8xxx.c
hw/gpio/pl061.c
hw/gpio/zaurus.c
hw/i2c/Makefile.objs
hw/i2c/bitbang_i2c.c
hw/i2c/bitbang_i2c.h
hw/i2c/core.c
hw/i2c/pm_smbus.c
hw/i2c/smbus.c
hw/i2c/smbus_eeprom.c
hw/input/Makefile.objs
hw/input/adb.c
hw/input/hid.c
hw/input/lm832x.c
hw/input/pckbd.c
hw/input/pl050.c
hw/input/ps2.c
hw/input/pxa2xx_keypad.c
hw/input/tsc2005.c
hw/input/tsc210x.c
hw/input/vmmouse.c
hw/intc/Makefile.objs
hw/intc/apic.c
hw/intc/apic_common.c
hw/intc/arm_gic.c
hw/intc/arm_gic_common.c
hw/intc/arm_gic_kvm.c
hw/intc/arm_gicv2m.c
hw/intc/armv7m_nvic.c
hw/intc/gic_internal.h
hw/intc/heathrow_pic.c
hw/intc/i8259.c
hw/intc/i8259_common.c
hw/intc/ioapic.c
hw/intc/ioapic_common.c
hw/intc/openpic.c
hw/intc/openpic_kvm.c
hw/intc/pl190.c
hw/intc/realview_gic.c
hw/intc/sh_intc.c
hw/intc/slavio_intctl.c
hw/ipack/Makefile.objs
hw/ipack/ipack.c
hw/ipack/tpci200.c
hw/isa/Makefile.objs
hw/isa/apm.c
hw/isa/i82378.c
hw/isa/isa-bus.c
hw/isa/vt82c686.c
hw/m68k/Makefile.objs
hw/m68k/an5206.c
hw/m68k/dummy_m68k.c
hw/m68k/mcf5206.c
hw/m68k/mcf5208.c
hw/m68k/mcf_intc.c
hw/misc/Makefile.objs
hw/misc/a9scu.c
hw/misc/applesmc.c
hw/misc/arm11scu.c
hw/misc/arm_integrator_debug.c
hw/misc/arm_l2x0.c
hw/misc/arm_sysctl.c
hw/misc/cbus.c
hw/misc/debugexit.c
hw/misc/eccmemctl.c
hw/misc/ivshmem.c
hw/misc/max111x.c
hw/misc/mst_fpga.c
hw/misc/pc-testdev.c
hw/misc/pci-testdev.c
hw/misc/pvpanic.c
hw/misc/sga.c
hw/misc/slavio_misc.c
hw/misc/stm32f2xx_syscfg.c
hw/misc/tmp105.c
hw/misc/tmp105.h
hw/misc/vmport.c
hw/moxie/Makefile.objs
hw/moxie/moxiesim.c
hw/net/Makefile.objs
hw/net/allwinner_emac.c
hw/net/dp8393x.c
hw/net/e1000.c
hw/net/e1000_regs.h
hw/net/eepro100.c
hw/net/fsl_etsec/etsec.c
hw/net/fsl_etsec/etsec.h
hw/net/fsl_etsec/miim.c
hw/net/fsl_etsec/registers.c
hw/net/fsl_etsec/registers.h
hw/net/fsl_etsec/rings.c
hw/net/lan9118.c
hw/net/lance.c
hw/net/mcf_fec.c
hw/net/mipsnet.c
hw/net/ne2000-isa.c
hw/net/ne2000.c
hw/net/ne2000.h
hw/net/pcnet-pci.c
hw/net/pcnet.c
hw/net/pcnet.h
hw/net/rtl8139.c
hw/net/smc91c111.c
hw/net/vmware_utils.h
hw/net/xen_nic.c
hw/nvram/Makefile.objs
hw/nvram/ds1225y.c
hw/nvram/eeprom93xx.c
hw/nvram/fw_cfg.c
hw/nvram/mac_nvram.c
hw/pci-bridge/Makefile.objs
hw/pci-bridge/i82801b11.c
hw/pci-bridge/ioh3420.c
hw/pci-bridge/ioh3420.h
hw/pci-bridge/pci_bridge_dev.c
hw/pci-bridge/xio3130_downstream.c
hw/pci-bridge/xio3130_downstream.h
hw/pci-bridge/xio3130_upstream.c
hw/pci-bridge/xio3130_upstream.h
hw/pci-host/Makefile.objs
hw/pci-host/apb.c
hw/pci-host/bonito.c
hw/pci-host/gpex.c
hw/pci-host/ppce500.c
hw/pcmcia/Makefile.objs
hw/pcmcia/pcmcia.c
hw/pcmcia/pxa2xx.c
hw/sd/Makefile.objs
hw/sd/pl181.c
hw/sd/pxa2xx_mmci.c
hw/sd/sd.c
hw/sd/sdhci.c
hw/sd/sdhci.h
hw/sd/ssi-sd.c
hw/timer/Makefile.objs
hw/timer/a9gtimer.c
hw/timer/arm_mptimer.c
hw/timer/arm_timer.c
hw/timer/ds1338.c
hw/timer/hpet.c
hw/timer/i8254.c
hw/timer/i8254_common.c
hw/timer/m48t59.c
hw/timer/mc146818rtc.c
hw/timer/pl031.c
hw/timer/pxa2xx_timer.c
hw/timer/sh_timer.c
hw/timer/slavio_timer.c
hw/timer/stm32f2xx_timer.c
hw/timer/tusb6010.c
hw/timer/twl92230.c
hw/tpm/Makefile.objs
hw/tpm/tpm_int.h
hw/tpm/tpm_passthrough.c
hw/tpm/tpm_tis.c
hw/tpm/tpm_tis.h
hw/tpm/tpm_util.c
hw/tpm/tpm_util.h
hw/virtio/Makefile.objs
hw/watchdog/Makefile.objs
hw/watchdog/watchdog.c
hw/watchdog/wdt_diag288.c
hw/watchdog/wdt_i6300esb.c
hw/watchdog/wdt_ib700.c
hw/xen/Makefile.objs
hw/xen/xen-host-pci-device.c
hw/xen/xen-host-pci-device.h
hw/xen/xen_backend.c
hw/xen/xen_devconfig.c
hw/xen/xen_pt.c
hw/xen/xen_pt.h
hw/xen/xen_pt_config_init.c
hw/xen/xen_pt_graphics.c
hw/xen/xen_pt_msi.c
hw/xenpv/Makefile.objs
hw/xenpv/xen_domainbuild.c
hw/xenpv/xen_domainbuild.h
hw/xenpv/xen_machine_pv.c
include/config.h
include/disas/bfd.h
include/disas/disas.h
include/elf.h
include/exec/address-spaces.h
include/exec/cpu-all.h
include/exec/cpu-common.h
include/exec/cpu-defs.h
include/exec/cpu_ldst_useronly_template.h
include/exec/cputlb.h
include/exec/exec-all.h
include/exec/gdbstub.h
include/exec/gen-icount.h
include/exec/hwaddr.h
include/exec/memattrs.h
include/exec/poison.h
include/exec/ram_addr.h
include/exec/semihost.h
include/exec/softmmu-semi.h
include/exec/tb-hash.h
include/exec/user/abitypes.h
include/exec/user/thunk.h
include/fpu/softfloat.h
include/glib-compat.h
include/hw/arm/arm.h
include/hw/arm/exynos4210.h
include/hw/arm/fdt.h
include/hw/arm/fsl-imx25.h
include/hw/arm/fsl-imx31.h
include/hw/arm/linux-boot-if.h
include/hw/arm/omap.h
include/hw/arm/primecell.h
include/hw/arm/pxa.h
include/hw/arm/sharpsl.h
include/hw/arm/soc_dma.h
include/hw/arm/stm32f205_soc.h
include/hw/arm/sysbus-fdt.h
include/hw/arm/virt.h
include/hw/audio/audio.h
include/hw/audio/pcspk.h
include/hw/block/block.h
include/hw/block/flash.h
include/hw/boards.h
include/hw/char/cadence_uart.h
include/hw/char/digic-uart.h
include/hw/char/escc.h
include/hw/char/imx_serial.h
include/hw/char/serial.h
include/hw/char/stm32f2xx_usart.h
include/hw/compat.h
include/hw/cpu/a15mpcore.h
include/hw/cpu/a9mpcore.h
include/hw/cpu/arm11mpcore.h
include/hw/cris/etraxfs.h
include/hw/cris/etraxfs_dma.h
include/hw/devices.h
include/hw/elf_ops.h
include/hw/empty_slot.h
include/hw/fw-path-provider.h
include/hw/gpio/imx_gpio.h
include/hw/hotplug.h
include/hw/hw.h
include/hw/i2c/i2c.h
include/hw/i2c/imx_i2c.h
include/hw/i2c/pm_smbus.h
include/hw/i2c/smbus.h
include/hw/input/adb.h
include/hw/input/hid.h
include/hw/input/ps2.h
include/hw/intc/arm_gic.h
include/hw/intc/arm_gic_common.h
include/hw/intc/imx_avic.h
include/hw/intc/realview_gic.h
include/hw/ipack/ipack.h
include/hw/irq.h
include/hw/isa/apm.h
include/hw/isa/i8259_internal.h
include/hw/isa/isa.h
include/hw/isa/pc87312.h
include/hw/isa/vt82c686.h
include/hw/kvm/clock.h
include/hw/loader.h
include/hw/m68k/mcf.h
include/hw/mips/bios.h
include/hw/mips/cpudevs.h
include/hw/mips/mips.h
include/hw/misc/a9scu.h
include/hw/misc/arm11scu.h
include/hw/misc/arm_integrator_debug.h
include/hw/misc/imx_ccm.h
include/hw/misc/stm32f2xx_syscfg.h
include/hw/misc/tmp105_regs.h
include/hw/net/allwinner_emac.h
include/hw/net/cadence_gem.h
include/hw/net/imx_fec.h
include/hw/net/mii.h
include/hw/nmi.h
include/hw/nvram/eeprom93xx.h
include/hw/nvram/openbios_firmware_abi.h
include/hw/pci-host/apb.h
include/hw/pci-host/gpex.h
include/hw/pci-host/ppce500.h
include/hw/pcmcia.h
include/hw/platform-bus.h
include/hw/ppc/mac_dbdma.h
include/hw/ppc/openpic.h
include/hw/ppc/ppc.h
include/hw/ppc/ppc4xx.h
include/hw/ppc/ppc_e500.h
include/hw/ptimer.h
include/hw/qdev-core.h
include/hw/qdev-dma.h
include/hw/qdev-properties.h
include/hw/qdev.h
include/hw/scsi/esp.h
include/hw/scsi/scsi.h
include/hw/sd.h
include/hw/sh4/sh.h
include/hw/sh4/sh_intc.h
include/hw/sparc/grlib.h
include/hw/sparc/sparc32_dma.h
include/hw/sparc/sun4m.h
include/hw/ssi.h
include/hw/stream.h
include/hw/sysbus.h
include/hw/timer/a9gtimer.h
include/hw/timer/arm_mptimer.h
include/hw/timer/digic-timer.h
include/hw/timer/hpet.h
include/hw/timer/i8254.h
include/hw/timer/i8254_internal.h
include/hw/timer/imx_epit.h
include/hw/timer/imx_gpt.h
include/hw/timer/m48t59.h
include/hw/timer/mc146818rtc.h
include/hw/timer/mc146818rtc_regs.h
include/hw/timer/stm32f2xx_timer.h
include/hw/tricore/tricore.h
include/hw/unicore32/puv3.h
include/hw/usb.h
include/hw/usb/ehci-regs.h
include/hw/usb/uhci-regs.h
include/hw/vfio/vfio-calxeda-xgmac.h
include/hw/vfio/vfio-common.h
include/hw/vfio/vfio-platform.h
include/hw/vfio/vfio.h
include/hw/virtio/dataplane/vring-accessors.h
include/hw/virtio/dataplane/vring.h
include/hw/virtio/vhost-backend.h
include/hw/virtio/vhost-scsi.h
include/hw/virtio/vhost.h
include/hw/virtio/virtio-9p.h
include/hw/virtio/virtio-access.h
include/hw/virtio/virtio-balloon.h
include/hw/virtio/virtio-blk.h
include/hw/virtio/virtio-bus.h
include/hw/virtio/virtio-gpu.h
include/hw/virtio/virtio-net.h
include/hw/virtio/virtio-scsi.h
include/hw/virtio/virtio.h
include/hw/watchdog/wdt_diag288.h
include/hw/xen/xen.h
include/hw/xen/xen_backend.h
include/hw/xen/xen_common.h
include/libdecnumber/dconfig.h
include/libdecnumber/decContext.h
include/libdecnumber/decDPD.h
include/libdecnumber/decNumber.h
include/libdecnumber/decNumberLocal.h
include/libdecnumber/dpd/decimal128.h
include/libdecnumber/dpd/decimal128Local.h
include/libdecnumber/dpd/decimal32.h
include/libdecnumber/dpd/decimal64.h
include/monitor/hmp-target.h
include/monitor/monitor.h
include/monitor/qdev.h
include/net/checksum.h
include/net/eth.h
include/net/net.h
include/net/queue.h
include/net/slirp.h
include/net/tap.h
include/net/vhost-user.h
include/net/vhost_net.h
include/qapi/dealloc-visitor.h
include/qapi/opts-visitor.h
include/qapi/qmp-event.h
include/qapi/qmp-input-visitor.h
include/qapi/qmp-output-visitor.h
include/qapi/qmp/dispatch.h
include/qapi/qmp/json-lexer.h
include/qapi/qmp/json-parser.h
include/qapi/qmp/json-streamer.h
include/qapi/qmp/qbool.h
include/qapi/qmp/qdict.h
include/qapi/qmp/qerror.h
include/qapi/qmp/qfloat.h
include/qapi/qmp/qint.h
include/qapi/qmp/qjson.h
include/qapi/qmp/qlist.h
include/qapi/qmp/qobject.h
include/qapi/qmp/qstring.h
include/qapi/qmp/types.h
include/qapi/string-input-visitor.h
include/qapi/string-output-visitor.h
include/qapi/util.h
include/qapi/visitor-impl.h
include/qapi/visitor.h
include/qemu-common.h
include/qemu-io.h
include/qemu/acl.h
include/qemu/atomic.h
include/qemu/bitmap.h
include/qemu/bitops.h
include/qemu/bswap.h
include/qemu/compatfd.h
include/qemu/compiler.h
include/qemu/config-file.h
include/qemu/crc32c.h
include/qemu/envlist.h
include/qemu/event_notifier.h
include/qemu/fifo8.h
include/qemu/fprintf-fn.h
include/qemu/hbitmap.h
include/qemu/host-utils.h
include/qemu/int128.h
include/qemu/iov.h
include/qemu/log.h
include/qemu/main-loop.h
include/qemu/module.h
include/qemu/notify.h
include/qemu/option.h
include/qemu/option_int.h
include/qemu/osdep.h
include/qemu/queue.h
include/qemu/range.h
include/qemu/ratelimit.h
include/qemu/rcu.h
include/qemu/rcu_queue.h
include/qemu/readline.h
include/qemu/rfifolock.h
include/qemu/seqlock.h
include/qemu/sockets.h
include/qemu/thread-posix.h
include/qemu/thread-win32.h
include/qemu/thread.h
include/qemu/throttle.h
include/qemu/timer.h
include/qemu/typedefs.h
include/qemu/uri.h
include/qemu/xattr.h
include/qjson.h
include/standard-headers/asm-s390/kvm_virtio.h
include/standard-headers/asm-s390/virtio-ccw.h
include/standard-headers/asm-x86/hyperv.h
include/standard-headers/linux/if_ether.h
include/standard-headers/linux/input.h
include/standard-headers/linux/pci_regs.h
include/standard-headers/linux/types.h
include/standard-headers/linux/virtio_9p.h
include/standard-headers/linux/virtio_balloon.h
include/standard-headers/linux/virtio_blk.h
include/standard-headers/linux/virtio_config.h
include/standard-headers/linux/virtio_console.h
include/standard-headers/linux/virtio_gpu.h
include/standard-headers/linux/virtio_ids.h
include/standard-headers/linux/virtio_input.h
include/standard-headers/linux/virtio_net.h
include/standard-headers/linux/virtio_pci.h
include/standard-headers/linux/virtio_ring.h
include/standard-headers/linux/virtio_rng.h
include/standard-headers/linux/virtio_scsi.h
include/standard-headers/linux/virtio_types.h
include/sysemu/accel.h
include/sysemu/arch_init.h
include/sysemu/balloon.h
include/sysemu/block-backend.h
include/sysemu/blockdev.h
include/sysemu/bt.h
include/sysemu/char.h
include/sysemu/cpus.h
include/sysemu/device_tree.h
include/sysemu/dma.h
include/sysemu/dump-arch.h
include/sysemu/dump.h
include/sysemu/hostmem.h
include/sysemu/iothread.h
include/sysemu/kvm.h
include/sysemu/kvm_int.h
include/sysemu/memory_mapping.h
include/sysemu/os-posix.h
include/sysemu/os-win32.h
include/sysemu/qtest.h
include/sysemu/rng-random.h
include/sysemu/rng.h
include/sysemu/tpm.h
include/sysemu/tpm_backend.h
include/sysemu/tpm_backend_int.h
include/sysemu/watchdog.h
include/sysemu/xen-mapcache.h
include/trace-tcg.h
include/trace.h
include/ui/console.h
include/ui/egl-helpers.h
include/ui/gtk.h
include/ui/input.h
include/ui/pixel_ops.h
include/ui/qemu-pixman.h
include/ui/sdl2.h
include/ui/shader.h
include/ui/spice-display.h
iohandler.c
iothread.c
libcacard/Makefile
libcacard/cac.c
libcacard/cac.h
libcacard/card_7816.c
libcacard/card_7816.h
libcacard/card_7816t.h
libcacard/event.c
libcacard/eventt.h
libcacard/libcacard.pc.in
libcacard/libcacard.syms
libcacard/link_test.c
libcacard/vcard.c
libcacard/vcard.h
libcacard/vcard_emul.h
libcacard/vcard_emul_nss.c
libcacard/vcard_emul_type.c
libcacard/vcard_emul_type.h
libcacard/vcardt.c
libcacard/vcardt.h
libcacard/vcardt_internal.h
libcacard/vevent.h
libcacard/vreader.c
libcacard/vreader.h
libcacard/vreadert.h
libcacard/vscard_common.h
libcacard/vscclient.c
libdecnumber/decContext.c
libdecnumber/decNumber.c
libdecnumber/dpd/decimal128.c
libdecnumber/dpd/decimal32.c
libdecnumber/dpd/decimal64.c
memory_mapping.c
module-common.c
page_cache.c
pc-bios/Makefile
pc-bios/QEMU,cgthree.bin
pc-bios/QEMU,tcx.bin
pc-bios/README
pc-bios/acpi-dsdt.aml
pc-bios/bamboo.dtb
pc-bios/bamboo.dts
pc-bios/efi-e1000.rom
pc-bios/efi-eepro100.rom
pc-bios/efi-ne2k_pci.rom
pc-bios/efi-pcnet.rom
pc-bios/efi-rtl8139.rom
pc-bios/efi-virtio.rom
pc-bios/keymaps/bepo
pc-bios/keymaps/common
pc-bios/keymaps/cz
pc-bios/keymaps/da
pc-bios/keymaps/de
pc-bios/keymaps/de-ch
pc-bios/keymaps/en-gb
pc-bios/keymaps/en-us
pc-bios/keymaps/es
pc-bios/keymaps/et
pc-bios/keymaps/fi
pc-bios/keymaps/fo
pc-bios/keymaps/fr
pc-bios/keymaps/fr-be
pc-bios/keymaps/fr-ca
pc-bios/keymaps/fr-ch
pc-bios/keymaps/hr
pc-bios/keymaps/hu
pc-bios/keymaps/is
pc-bios/keymaps/it
pc-bios/keymaps/ja
pc-bios/keymaps/lt
pc-bios/keymaps/lv
pc-bios/keymaps/mk
pc-bios/keymaps/modifiers
pc-bios/keymaps/nl
pc-bios/keymaps/nl-be
pc-bios/keymaps/no
pc-bios/keymaps/pl
pc-bios/keymaps/pt
pc-bios/keymaps/pt-br
pc-bios/keymaps/ru
pc-bios/keymaps/sl
pc-bios/keymaps/sv
pc-bios/keymaps/th
pc-bios/keymaps/tr
pc-bios/kvmvapic.bin
pc-bios/linuxboot.bin
pc-bios/multiboot.bin
pc-bios/openbios-ppc
pc-bios/openbios-sparc32
pc-bios/openbios-sparc64
pc-bios/optionrom/Makefile
pc-bios/optionrom/kvmvapic.S
pc-bios/optionrom/linuxboot.S
pc-bios/optionrom/multiboot.S
pc-bios/optionrom/optionrom.h
pc-bios/palcode-clipper
pc-bios/petalogix-ml605.dtb
pc-bios/petalogix-s3adsp1800.dtb
pc-bios/ppc_rom.bin
pc-bios/pxe-e1000.rom
pc-bios/pxe-eepro100.rom
pc-bios/pxe-ne2k_pci.rom
pc-bios/pxe-pcnet.rom
pc-bios/pxe-rtl8139.rom
pc-bios/pxe-virtio.rom
pc-bios/q35-acpi-dsdt.aml
pc-bios/qemu-icon.bmp
pc-bios/qemu-nsis.bmp
pc-bios/qemu-nsis.ico
pc-bios/qemu.rsrc
pc-bios/qemu_logo.svg
pc-bios/qemu_logo_no_text.svg
pc-bios/s390-ccw.img
pc-bios/s390-zipl.rom
pc-bios/sgabios.bin
pc-bios/slof.bin
pc-bios/spapr-rtas.bin
pc-bios/u-boot.e500
pc-bios/vgabios-cirrus.bin
pc-bios/vgabios-qxl.bin
pc-bios/vgabios-stdvga.bin
pc-bios/vgabios-virtio.bin
pc-bios/vgabios-vmware.bin
pc-bios/vgabios.bin
pixman
po/Makefile
po/de_DE.po
po/fr_FR.po
po/hu.po
po/it.po
po/messages.po
po/tr.po
po/zh_CN.po
qdev-monitor.c
qemu-bridge-helper.c
qemu-coroutine-io.c
qemu-coroutine-lock.c
qemu-coroutine-sleep.c
qemu-coroutine.c
qemu-doc.texi
qemu-ga.texi
qemu-log.c
qemu-nbd.texi
qemu-options-wrapper.h
qemu-options.h
qemu-tech.texi
qemu.nsi
qemu.sasl
qjson.c
qtest.c
roms/Makefile
roms/SLOF
roms/config.ipxe.general.h
roms/config.seabios-128k
roms/config.seabios-256k
roms/config.vga-cirrus
roms/config.vga-isavga
roms/config.vga-qxl
roms/config.vga-stdvga
roms/config.vga-virtio
roms/config.vga-vmware
roms/configure-seabios.sh
roms/ipxe
roms/openbios
roms/openhackware
roms/qemu-palcode
roms/seabios
roms/sgabios
roms/u-boot
roms/vgabios
rules.mak
scripts/analyse-9p-simpletrace.py
scripts/analyze-migration.py
scripts/check-qerror.sh
scripts/cleanup-trace-events.pl
scripts/cocci-macro-file.h
scripts/create_config
scripts/disas-objdump.pl
scripts/dump-guest-memory.py
scripts/extract-vsssdk-headers
scripts/feature_to_c.sh
scripts/get_maintainer.pl
scripts/gtester-cat
scripts/hxtool
scripts/kvm/kvm_flightrecorder
scripts/kvm/kvm_stat
scripts/kvm/kvm_stat.texi
scripts/kvm/vmxcap
scripts/make-release
scripts/make_device_config.sh
scripts/ordereddict.py
scripts/qemu-binfmt-conf.sh
scripts/qemu-gdb.py
scripts/qemu-guest-agent/fsfreeze-hook
scripts/qemu-guest-agent/fsfreeze-hook.d/mysql-flush.sh.sample
scripts/qemugdb/__init__.py
scripts/qemugdb/coroutine.py
scripts/qemugdb/mtree.py
scripts/qtest.py
scripts/refresh-pxe-roms.sh
scripts/shaderinclude.pl
scripts/signrom.py
scripts/simpletrace.py
scripts/switch-timer-api
scripts/texi2pod.pl
scripts/update-acpi.sh
scripts/update-linux-headers.sh
spice-qemu-char.c
stubs/Makefile.objs
stubs/arch-query-cpu-def.c
stubs/bdrv-commit-all.c
stubs/chr-baum-init.c
stubs/chr-msmouse.c
stubs/chr-testdev.c
stubs/clock-warp.c
stubs/cpu-get-clock.c
stubs/cpu-get-icount.c
stubs/cpus.c
stubs/dump.c
stubs/fd-register.c
stubs/fdset-add-fd.c
stubs/fdset-find-fd.c
stubs/fdset-get-fd.c
stubs/fdset-remove-fd.c
stubs/gdbstub.c
stubs/get-fd.c
stubs/get-next-serial.c
stubs/get-vm-name.c
stubs/iothread-lock.c
stubs/is-daemonized.c
stubs/machine-init-done.c
stubs/migr-blocker.c
stubs/mon-is-qmp.c
stubs/mon-printf.c
stubs/monitor-init.c
stubs/notify-event.c
stubs/qemu-chr-open-spice.c
stubs/qmp_pc_dimm_device_list.c
stubs/qtest.c
stubs/reset.c
stubs/runstate-check.c
stubs/set-fd-handler.c
stubs/slirp.c
stubs/sysbus.c
stubs/target-monitor-defs.c
stubs/uuid.c
stubs/vc-init.c
stubs/vm-stop.c
stubs/vmstate.c
target-m68k/Makefile.objs
target-m68k/cpu-qom.h
target-m68k/cpu.c
target-m68k/cpu.h
target-m68k/gdbstub.c
target-m68k/helper.c
target-m68k/helper.h
target-m68k/m68k-semi.c
target-m68k/op_helper.c
target-m68k/qregs.def
target-m68k/translate.c
target-tilegx/Makefile.objs
target-tilegx/cpu.c
target-tilegx/cpu.h
target-tilegx/helper.c
target-tilegx/helper.h
target-tilegx/opcode_tilegx.h
target-tilegx/simd_helper.c
target-tilegx/spr_def_64.h
target-tilegx/translate.c
tcg-runtime.c
tests/.gitignore
tests/Makefile
tests/acpi-test-data/pc/APIC
tests/acpi-test-data/pc/DSDT
tests/acpi-test-data/pc/FACP
tests/acpi-test-data/pc/FACS
tests/acpi-test-data/pc/HPET
tests/acpi-test-data/pc/SSDT
tests/acpi-test-data/pc/SSDT.bridge
tests/acpi-test-data/q35/APIC
tests/acpi-test-data/q35/DSDT
tests/acpi-test-data/q35/FACP
tests/acpi-test-data/q35/FACS
tests/acpi-test-data/q35/HPET
tests/acpi-test-data/q35/MCFG
tests/acpi-test-data/q35/SSDT
tests/acpi-test-data/q35/SSDT.bridge
tests/acpi-test-data/rebuild-expected-aml.sh
tests/bios-tables-test.c
tests/boot-order-test.c
tests/check-block.sh
tests/check-qdict.c
tests/check-qfloat.c
tests/check-qint.c
tests/check-qjson.c
tests/check-qlist.c
tests/check-qom-interface.c
tests/check-qom-proplist.c
tests/check-qstring.c
tests/crypto-tls-x509-helpers.c
tests/crypto-tls-x509-helpers.h
tests/display-vga-test.c
tests/drive_del-test.c
tests/ds1338-test.c
tests/e1000-test.c
tests/eepro100-test.c
tests/endianness-test.c
tests/fdc-test.c
tests/hd-geo-test.c
tests/i440fx-test.c
tests/i82801b11-test.c
tests/ioh3420-test.c
tests/ipoctal232-test.c
tests/libqos/ahci.c
tests/libqos/ahci.h
tests/libqos/fw_cfg.c
tests/libqos/fw_cfg.h
tests/libqos/i2c-imx.c
tests/libqos/i2c-omap.c
tests/libqos/i2c.c
tests/libqos/i2c.h
tests/libqos/libqos-pc.c
tests/libqos/libqos-pc.h
tests/libqos/libqos.c
tests/libqos/libqos.h
tests/libqos/malloc-generic.c
tests/libqos/malloc-generic.h
tests/libqos/malloc-pc.c
tests/libqos/malloc-pc.h
tests/libqos/malloc.c
tests/libqos/malloc.h
tests/libqos/pci-pc.c
tests/libqos/pci-pc.h
tests/libqos/pci.c
tests/libqos/pci.h
tests/libqos/usb.c
tests/libqos/usb.h
tests/libqos/virtio-mmio.c
tests/libqos/virtio-mmio.h
tests/libqos/virtio-pci.c
tests/libqos/virtio-pci.h
tests/libqos/virtio.c
tests/libqos/virtio.h
tests/libqtest.c
tests/libqtest.h
tests/m48t59-test.c
tests/multiboot/Makefile
tests/multiboot/libc.c
tests/multiboot/libc.h
tests/multiboot/link.ld
tests/multiboot/mmap.c
tests/multiboot/mmap.out
tests/multiboot/module.txt
tests/multiboot/modules.c
tests/multiboot/modules.out
tests/multiboot/multiboot.h
tests/multiboot/run_test.sh
tests/multiboot/start.S
tests/ne2000-test.c
tests/pc-cpu-test.c
tests/pcnet-test.c
tests/pkix_asn1_tab.c
tests/pvpanic-test.c
tests/q35-test.c
tests/qemu-iotests-quick.sh
tests/rcutorture.c
tests/rocker/README
tests/rocker/all
tests/rocker/bridge
tests/rocker/bridge-stp
tests/rocker/bridge-vlan
tests/rocker/bridge-vlan-stp
tests/rocker/port
tests/rocker/tut.dot
tests/rtc-test.c
tests/rtl8139-test.c
tests/spapr-phb-test.c
tests/tcg/Makefile
tests/tcg/hello-arm.c
tests/tcg/hello-i386.c
tests/tcg/hello-mips.c
tests/tcg/linux-test.c
tests/tcg/pi_10.com
tests/tcg/runcom.c
tests/tcg/sha1.c
tests/tcg/test-arm-iwmmxt.s
tests/tcg/test-i386-code16.S
tests/tcg/test-i386-fprem.c
tests/tcg/test-i386-muldiv.h
tests/tcg/test-i386-shift.h
tests/tcg/test-i386-ssse3.c
tests/tcg/test-i386-vm86.S
tests/tcg/test-i386.c
tests/tcg/test-i386.h
tests/tcg/test-mmap.c
tests/tcg/test_path.c
tests/tcg/testthread.c
tests/tco-test.c
tests/test-aio.c
tests/test-bitops.c
tests/test-coroutine.c
tests/test-cutils.c
tests/test-hbitmap.c
tests/test-int128.c
tests/test-iov.c
tests/test-mul64.c
tests/test-opts-visitor.c
tests/test-qdev-global-props.c
tests/test-qemu-opts.c
tests/test-qmp-commands.c
tests/test-qmp-event.c
tests/test-qmp-input-strict.c
tests/test-qmp-input-visitor.c
tests/test-qmp-output-visitor.c
tests/test-rcu-list.c
tests/test-rfifolock.c
tests/test-string-input-visitor.c
tests/test-string-output-visitor.c
tests/test-thread-pool.c
tests/test-throttle.c
tests/test-visitor-serialization.c
tests/test-vmstate.c
tests/test-write-threshold.c
tests/test-x86-cpuid.c
tests/test-xbzrle.c
tests/tmp105-test.c
tests/tpci200-test.c
tests/virtio-balloon-test.c
tests/virtio-blk-test.c
tests/virtio-console-test.c
tests/virtio-net-test.c
tests/virtio-rng-test.c
tests/virtio-scsi-test.c
tests/virtio-serial-test.c
tests/vmxnet3-test.c
tests/wdt_ib700-test.c
thread-pool.c
tpm.c
trace-events
translate-all.h
translate-common.c
util/Makefile.objs
util/acl.c
util/bitmap.c
util/bitops.c
util/compatfd.c
util/crc32c.c
util/cutils.c
util/envlist.c
util/event_notifier-posix.c
util/event_notifier-win32.c
util/fifo8.c
util/getauxval.c
util/hbitmap.c
util/hexdump.c
util/host-utils.c
util/id.c
util/iov.c
util/module.c
util/notify.c
util/osdep.c
util/oslib-posix.c
util/oslib-win32.c
util/path.c
util/qemu-config.c
util/qemu-openpty.c
util/qemu-option.c
util/qemu-progress.c
util/qemu-sockets.c
util/qemu-thread-posix.c
util/qemu-thread-win32.c
util/qemu-timer-common.c
util/rcu.c
util/readline.c
util/rfifolock.c
util/throttle.c
util/unicode.c
util/uri.c
version.rc
^ permalink raw reply [flat|nested] 55+ messages in thread
* Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered
2015-09-22 9:13 ` Markus Armbruster
@ 2015-09-22 10:06 ` Daniel P. Berrange
2015-09-22 10:18 ` Paolo Bonzini
2015-09-22 13:42 ` Thomas Huth
` (4 subsequent siblings)
5 siblings, 1 reply; 55+ messages in thread
From: Daniel P. Berrange @ 2015-09-22 10:06 UTC (permalink / raw)
To: Markus Armbruster; +Cc: qemu-devel
On Tue, Sep 22, 2015 at 11:13:57AM +0200, Markus Armbruster wrote:
> Paolo asked for an update.
>
> Markus Armbruster <armbru@redhat.com> writes:
>
> > Markus Armbruster <armbru@redhat.com> writes:
> >
> >> In my experience, too many files are not covered by MAINTAINERS.
> >> scripts/get_maintainer.pl falls back to git then, unless you say
> >> --no-git-fallback. Copies sent there tends to annoy their recipients
> >> without accomplishing all that much.
> >>
> >> Two obvious improvements:
> >>
> >> * Easy: Flip scripts/get_maintainer.pl's default to --no-git-fallback.
> >> I'll post the obvious patch, please raise your objections there.
> >>
> >> * Harder: improve MAINTAINERS coverage.
> >
> > A few folks have started doing that. Much appreciated!
> >
> > I collected recent patches to MAINTAINERS, and reran my analysis.
> >
> >> Let me back up subjective experience with hard data. The tree has quite
> >> a few files:
> >>
> >> $ git-ls-files | wc -l
> >> 3746
> >
> > Now 3752.
>
> Eleven months later, this is 4387.
>
> >> Counting them by extension:
> >>
> >> $ git-ls-files | sed -n 's#.*/##;s#.*\.##p' | sort | uniq -c | sort -nr
> >> 1836 c
> >> 818 h
> >> 133 out
> >> 105 S
> >> 97 objs
> >> 69 s
> >> 64 mak
> >> 48 json
> >> 47 py
> >> 41 txt
> >> 33 exit
> >> 33 err
> >> 16 xml
> >> 16 bin
> >> 13 rom
> >> 12 sh
> >> 12 dsl
> >> [Long tail that doesn't add up to anything interesting omitted]
> >>
> >> Let's look for .c not in MAINTAINERS:
> >>
> >> $ for i in `git-ls-files`; do [ "`scripts/get_maintainer.pl -f
> > --no-git-fallback $i`" ] || echo $i; done >unmaintained-files
> >> $ grep -c '\.c$' unmaintained-files
> >> 1066
> >>
> >> That's almost 60%. Not good.
> >
> > Down to 491 our of 1841 (27%). Progress, but not quite enough.
>
> 461 out of 1945 (24%). At this linear rate, we'll reach 10%
> unmaintained in five years.
>
> We're still adding unmaintained .c files:
>
> $ git-diff --diff-filter=A --name-only e668d1b | grep -c '\.c$'
> 116
> $ git-diff --diff-filter=A --name-only e668d1b | grep '\.c$' | join unmaintained-files - | wc -l
> 37
>
> 37 out of 116 new files (32%) are not covered. That's worse than we do
> for old files. Inexcusable.
We could extend the checkpatch.pl script so that it reports an error
if the patch contains a new file which is not covered by MAINTAINERS.
That would immediately prevent the situation getting any worse.
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
^ permalink raw reply [flat|nested] 55+ messages in thread
* Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered
2015-09-22 10:06 ` Daniel P. Berrange
@ 2015-09-22 10:18 ` Paolo Bonzini
0 siblings, 0 replies; 55+ messages in thread
From: Paolo Bonzini @ 2015-09-22 10:18 UTC (permalink / raw)
To: Daniel P. Berrange, Markus Armbruster; +Cc: qemu-devel
On 22/09/2015 12:06, Daniel P. Berrange wrote:
> We could extend the checkpatch.pl script so that it reports an error
> if the patch contains a new file which is not covered by MAINTAINERS.
> That would immediately prevent the situation getting any worse.
Actually Linux has such a check. Any volunteer to backport it? :)
Paolo
^ permalink raw reply [flat|nested] 55+ messages in thread
* Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered
2015-09-22 9:13 ` Markus Armbruster
2015-09-22 10:06 ` Daniel P. Berrange
@ 2015-09-22 13:42 ` Thomas Huth
2015-09-22 14:58 ` Gerd Hoffmann
2015-09-22 15:13 ` Juan Quintela
2015-09-22 14:58 ` Daniel P. Berrange
` (3 subsequent siblings)
5 siblings, 2 replies; 55+ messages in thread
From: Thomas Huth @ 2015-09-22 13:42 UTC (permalink / raw)
To: Markus Armbruster, qemu-devel
Cc: Michael S. Tsirkin, Juan Quintela, Alexander Graf, Gerd Hoffmann,
Leon Alrae, Aurelien Jarno
On 22/09/15 11:13, Markus Armbruster wrote:
...
>> Full list of unmaintained files now:
[...]
> default-configs/aarch64-linux-user.mak
> default-configs/aarch64-softmmu.mak
> default-configs/alpha-linux-user.mak
> default-configs/alpha-softmmu.mak
> default-configs/arm-linux-user.mak
> default-configs/arm-softmmu.mak
> default-configs/armeb-linux-user.mak
> default-configs/cris-linux-user.mak
> default-configs/cris-softmmu.mak
> default-configs/i386-bsd-user.mak
> default-configs/i386-linux-user.mak
> default-configs/i386-softmmu.mak
> default-configs/lm32-softmmu.mak
> default-configs/m68k-linux-user.mak
> default-configs/m68k-softmmu.mak
> default-configs/microblaze-linux-user.mak
> default-configs/microblaze-softmmu.mak
> default-configs/microblazeel-linux-user.mak
> default-configs/microblazeel-softmmu.mak
> default-configs/mips-linux-user.mak
> default-configs/mips-softmmu.mak
> default-configs/mips64-linux-user.mak
> default-configs/mips64-softmmu.mak
> default-configs/mips64el-linux-user.mak
> default-configs/mips64el-softmmu.mak
> default-configs/mipsel-linux-user.mak
> default-configs/mipsel-softmmu.mak
> default-configs/mipsn32-linux-user.mak
> default-configs/mipsn32el-linux-user.mak
> default-configs/moxie-softmmu.mak
> default-configs/or32-linux-user.mak
> default-configs/or32-softmmu.mak
> default-configs/pci.mak
> default-configs/ppc-linux-user.mak
> default-configs/ppc-softmmu.mak
> default-configs/ppc64-linux-user.mak
> default-configs/ppc64-softmmu.mak
> default-configs/ppc64abi32-linux-user.mak
> default-configs/ppc64le-linux-user.mak
> default-configs/ppcemb-softmmu.mak
> default-configs/s390x-linux-user.mak
> default-configs/s390x-softmmu.mak
> default-configs/sh4-linux-user.mak
> default-configs/sh4-softmmu.mak
> default-configs/sh4eb-linux-user.mak
> default-configs/sh4eb-softmmu.mak
> default-configs/sound.mak
> default-configs/sparc-bsd-user.mak
> default-configs/sparc-linux-user.mak
> default-configs/sparc-softmmu.mak
> default-configs/sparc32plus-linux-user.mak
> default-configs/sparc64-bsd-user.mak
> default-configs/sparc64-linux-user.mak
> default-configs/sparc64-softmmu.mak
> default-configs/tilegx-linux-user.mak
> default-configs/tricore-softmmu.mak
> default-configs/unicore32-linux-user.mak
> default-configs/unicore32-softmmu.mak
> default-configs/usb.mak
> default-configs/x86_64-bsd-user.mak
> default-configs/x86_64-linux-user.mak
> default-configs/x86_64-softmmu.mak
Can't we give the default softmmu config files to the corresponding
machine maintainers? E.g. the x86_64-softmmu to the X86 machine
maintainer etc.?
> docs/migration.txt
Juan?
> docs/usb-storage.txt
> docs/usb2.txt
> include/hw/usb.h
> include/hw/usb/ehci-regs.h
> include/hw/usb/uhci-regs.h
> include/ui/console.h
> include/ui/egl-helpers.h
> include/ui/gtk.h
> include/ui/input.h
> include/ui/pixel_ops.h
> include/ui/qemu-pixman.h
> include/ui/sdl2.h
> include/ui/shader.h
> include/ui/spice-display.h
Gerd?
> include/hw/mips/bios.h
> include/hw/mips/cpudevs.h
> include/hw/mips/mips.h
-> MIPS CPU maintainers?
> include/hw/ppc/mac_dbdma.h
> include/hw/ppc/openpic.h
> include/hw/ppc/ppc.h
> include/hw/ppc/ppc4xx.h
> include/hw/ppc/ppc_e500.h
-> PPC CPU maintainer?
> include/hw/virtio/dataplane/vring-accessors.h
> include/hw/virtio/dataplane/vring.h
> include/hw/virtio/vhost-backend.h
> include/hw/virtio/vhost-scsi.h
> include/hw/virtio/vhost.h
> include/hw/virtio/virtio-9p.h
> include/hw/virtio/virtio-access.h
> include/hw/virtio/virtio-balloon.h
> include/hw/virtio/virtio-blk.h
> include/hw/virtio/virtio-bus.h
> include/hw/virtio/virtio-gpu.h
> include/hw/virtio/virtio-net.h
> include/hw/virtio/virtio-scsi.h
> include/hw/virtio/virtio.h
> tests/virtio-balloon-test.c
> tests/virtio-blk-test.c
> tests/virtio-console-test.c
> tests/virtio-net-test.c
> tests/virtio-rng-test.c
> tests/virtio-scsi-test.c
> tests/virtio-serial-test.c
Michael?
> target-m68k/Makefile.objs
> target-m68k/cpu-qom.h
> target-m68k/cpu.c
> target-m68k/cpu.h
> target-m68k/gdbstub.c
> target-m68k/helper.c
> target-m68k/helper.h
> target-m68k/m68k-semi.c
> target-m68k/op_helper.c
> target-m68k/qregs.def
> target-m68k/translate.c
There are some 68k people on the list ... maybe one of them could be
motivated? ;-)
Thomas
^ permalink raw reply [flat|nested] 55+ messages in thread
* Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered
2015-09-22 13:42 ` Thomas Huth
@ 2015-09-22 14:58 ` Gerd Hoffmann
2015-09-22 15:13 ` Juan Quintela
1 sibling, 0 replies; 55+ messages in thread
From: Gerd Hoffmann @ 2015-09-22 14:58 UTC (permalink / raw)
To: Thomas Huth
Cc: Juan Quintela, qemu-devel, Michael S. Tsirkin, Alexander Graf,
Markus Armbruster, Leon Alrae, Aurelien Jarno
Hi,
> > docs/usb-storage.txt
> > docs/usb2.txt
> > include/hw/usb.h
> > include/hw/usb/ehci-regs.h
> > include/hw/usb/uhci-regs.h
> > include/ui/console.h
> > include/ui/egl-helpers.h
> > include/ui/gtk.h
> > include/ui/input.h
> > include/ui/pixel_ops.h
> > include/ui/qemu-pixman.h
> > include/ui/sdl2.h
> > include/ui/shader.h
> > include/ui/spice-display.h
> Gerd?
Yes.
usb obviously to the usb section. The include/ui/ includes to the
corresponding ui/ sections (vnc, spice, ...).
There are possibly some uncovered files in ui/ too, maybe we need new ui
section(s), all the new opengl bits are not yet covered I think.
thanks for looking at this,
Gerd
^ permalink raw reply [flat|nested] 55+ messages in thread
* Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered
2015-09-22 9:13 ` Markus Armbruster
2015-09-22 10:06 ` Daniel P. Berrange
2015-09-22 13:42 ` Thomas Huth
@ 2015-09-22 14:58 ` Daniel P. Berrange
2015-09-22 15:40 ` Peter Maydell
2015-09-22 18:07 ` Eric Blake
` (2 subsequent siblings)
5 siblings, 1 reply; 55+ messages in thread
From: Daniel P. Berrange @ 2015-09-22 14:58 UTC (permalink / raw)
To: Markus Armbruster; +Cc: qemu-devel
On Tue, Sep 22, 2015 at 11:13:57AM +0200, Markus Armbruster wrote:
> Paolo asked for an update.
>
> Markus Armbruster <armbru@redhat.com> writes:
>
> > Markus Armbruster <armbru@redhat.com> writes:
> Different tack: what are the unmaintained files we actually change?
>
> Unmaintained files sorted by number of commits in the past year (commit
> 1733681):
>
> $ for i in `cat unmaintained-files`; do echo -n "$i "; git-rev-list 1733681.. $i | wc -l; done | awk '{ printf "%7d %s\n", $2, $1 }' | sort -rn | head -n 100
> 79 trace-events
We should probably just kill the trace-events file from git entirely.
Everyone more or less appends to it, which guarantees each patch
series conflicts on it, and no one person is suitable as maintainer
of it really.
My personal suggestion would be to have a .t file alongside each
source file which has trace events in it. eg if ui/vnc.c includes
trace events, then put all VNC trace events in a ui/vnc.t file.
The Makefile can trivially concatenate all .t files back into a
single trace-events file.
This way, we can trivially align maintainers for the .t files
with the corresponding maintainer of the .c file.
There might be some cases where trace events are used from multiple
source files, in which case you could allow a common.t file in each
subdirectory too. This gets slightly harder to assign a unique maintainer
against though particularly for a dumping ground like util/ or block/
etc, so I'd suggest focusing on .t files matching the .c filename.
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
^ permalink raw reply [flat|nested] 55+ messages in thread
* Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered
2015-09-22 13:42 ` Thomas Huth
2015-09-22 14:58 ` Gerd Hoffmann
@ 2015-09-22 15:13 ` Juan Quintela
1 sibling, 0 replies; 55+ messages in thread
From: Juan Quintela @ 2015-09-22 15:13 UTC (permalink / raw)
To: Thomas Huth
Cc: Michael S. Tsirkin, qemu-devel, Alexander Graf,
Markus Armbruster, Gerd Hoffmann, Leon Alrae, Aurelien Jarno
Thomas Huth <thuth@redhat.com> wrote:
> On 22/09/15 11:13, Markus Armbruster wrote:
>
>> docs/migration.txt
>
> Juan?
Reviewed-by: Juan Quintela <quintela@redhat.com>
O;-)
^ permalink raw reply [flat|nested] 55+ messages in thread
* Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered
2015-09-22 14:58 ` Daniel P. Berrange
@ 2015-09-22 15:40 ` Peter Maydell
0 siblings, 0 replies; 55+ messages in thread
From: Peter Maydell @ 2015-09-22 15:40 UTC (permalink / raw)
To: Daniel P. Berrange; +Cc: Markus Armbruster, qemu-devel
On 22 September 2015 at 07:58, Daniel P. Berrange <berrange@redhat.com> wrote:
> On Tue, Sep 22, 2015 at 11:13:57AM +0200, Markus Armbruster wrote:
>> Paolo asked for an update.
>>
>> Markus Armbruster <armbru@redhat.com> writes:
>>
>> > Markus Armbruster <armbru@redhat.com> writes:
>> Different tack: what are the unmaintained files we actually change?
>>
>> Unmaintained files sorted by number of commits in the past year (commit
>> 1733681):
>>
>> $ for i in `cat unmaintained-files`; do echo -n "$i "; git-rev-list 1733681.. $i | wc -l; done | awk '{ printf "%7d %s\n", $2, $1 }' | sort -rn | head -n 100
>> 79 trace-events
>
> We should probably just kill the trace-events file from git entirely.
> Everyone more or less appends to it, which guarantees each patch
> series conflicts on it, and no one person is suitable as maintainer
> of it really.
Strong agreement; a single trace-events file is just nasty.
-- PMM
^ permalink raw reply [flat|nested] 55+ messages in thread
* Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered
2015-09-22 9:13 ` Markus Armbruster
` (2 preceding siblings ...)
2015-09-22 14:58 ` Daniel P. Berrange
@ 2015-09-22 18:07 ` Eric Blake
2015-09-22 19:50 ` Paolo Bonzini
` (2 more replies)
2015-09-22 18:37 ` John Snow
2016-08-30 11:31 ` Markus Armbruster
5 siblings, 3 replies; 55+ messages in thread
From: Eric Blake @ 2015-09-22 18:07 UTC (permalink / raw)
To: Markus Armbruster, qemu-devel, Kevin Wolf, Stefan Hajnoczi
[-- Attachment #1: Type: text/plain, Size: 2091 bytes --]
On 09/22/2015 03:13 AM, Markus Armbruster wrote:
>> Full list of unmaintained files now:
> [...]
>
> docs/bitmaps.md
> docs/blkdebug.txt
> docs/blkverify.txt
> docs/live-block-ops.txt
> docs/qcow2-cache.txt
> docs/qdev-device-use.txt
> docs/specs/qcow2.txt
> docs/specs/qed_spec.txt
Kevin, Stefan - should these be added to Block maintainers?
> docs/writing-qmp-commands.txt
Markus: Probably belongs to qapi.
> include/qapi/dealloc-visitor.h
> include/qapi/opts-visitor.h
> include/qapi/qmp-event.h
> include/qapi/qmp-input-visitor.h
> include/qapi/qmp-output-visitor.h
> include/qapi/qmp/dispatch.h
> include/qapi/qmp/json-lexer.h
> include/qapi/qmp/json-parser.h
> include/qapi/qmp/json-streamer.h
> include/qapi/qmp/qbool.h
> include/qapi/qmp/qdict.h
> include/qapi/qmp/qerror.h
> include/qapi/qmp/qfloat.h
> include/qapi/qmp/qint.h
> include/qapi/qmp/qjson.h
> include/qapi/qmp/qlist.h
> include/qapi/qmp/qobject.h
> include/qapi/qmp/qstring.h
> include/qapi/qmp/types.h
> include/qapi/string-input-visitor.h
> include/qapi/string-output-visitor.h
> include/qapi/util.h
> include/qapi/visitor-impl.h
> include/qapi/visitor.h
Definitely belongs to qapi.
> include/qemu/throttle.h
Block?
> include/qjson.h
qapi?
> tests/check-qdict.c
> tests/check-qfloat.c
> tests/check-qint.c
> tests/check-qjson.c
> tests/check-qlist.c
> tests/check-qstring.c
qapi?
> tests/test-opts-visitor.c
> tests/test-qmp-commands.c
> tests/test-qmp-event.c
> tests/test-qmp-input-strict.c
> tests/test-qmp-input-visitor.c
> tests/test-qmp-output-visitor.c
> tests/test-string-input-visitor.c
> tests/test-string-output-visitor.c
qapi
Also, should we have some new group for maintainer files, for things like:
.exrc
.gitignore
.gitmodules
.mailmap
.travis.yml
CODING_STYLE
COPYING
COPYING.LIB
Changelog
HACKING
LICENSE
MAINTAINERS
README
VERSION
scripts/get_maintainer.pl
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
^ permalink raw reply [flat|nested] 55+ messages in thread
* Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered
2015-09-22 9:13 ` Markus Armbruster
` (3 preceding siblings ...)
2015-09-22 18:07 ` Eric Blake
@ 2015-09-22 18:37 ` John Snow
2016-08-30 11:31 ` Markus Armbruster
5 siblings, 0 replies; 55+ messages in thread
From: John Snow @ 2015-09-22 18:37 UTC (permalink / raw)
To: Markus Armbruster, qemu-devel
On 09/22/2015 05:13 AM, Markus Armbruster wrote:
> Paolo asked for an update.
>
> Markus Armbruster <armbru@redhat.com> writes:
>>
>> Full list of unmaintained files now:
> [...]
>
Full list edited down to 'sections' with replies in-line...
[ top level confetti/detritus ]
[ backends/* ]
[ coroutine-* ]
[ default-configs/* ]
[ disas* ]
> dma-helpers.c
Block?
[ docs/* ]
> docs/bitmaps.md
Mine, or otherwise at least 'block.'
> docs/blkdebug.txt
> docs/blkverify.txt
> docs/live-block-ops.txt
> docs/qcow2-cache.txt
> docs/specs/qcow2.txt
> docs/specs/qed_spec.txt
block?
[ fpu/* ]
[ hw/bt ]
[ hw/char ]
[ hw/core ]
[ hw/cpu ]
[ hw/display ]
[ hw/dma ]
[ hw/gpio ]
[ hw/i2c ]
[ hw/input ]
[ hw/intc ]
[ hw/ipack ]
[ hw/isa ]
[ hw/m68k ]
[ hw/misc ]
[ hw/moxie ]
[ hw/net ]
[ hw/nvram ]
[ hw/pci-bridge ]
[ hw/pci-host ]
[ hw/pcmcia ]
[ hw/sd ]
[ hw/timer ]
[ hw/tpm ]
[ hw/virtio ]
[ hw/watchdog ]
[ hw/xen ]
[ hw/xenpv ]
[ include/* ]
[ include/disas/* ]
[ include/exec/* ]
[ include/fpu/* ]
[ include/hw/{...see hw list above...} ]
[ libcacard/* ] forward to libcacard project?
[ pc-bios/* ]
[ po/* ]
> qemu-coroutine-io.c
> qemu-coroutine-lock.c
> qemu-coroutine-sleep.c
> qemu-coroutine.c
Stefan ... ?
[ roms/* ]
[ scripts/* ] -- pretty much a grab-bag of random stuff.
[ stubs/* ] -- I think we need a designated "build system" maintainer to
take this and other build-system related infrastructure pieces.
[ target-m68k/* ]
[ target-tilegx/* ]
[ tests/acpi-test-data/* ]
[ tests/* ]
> tests/fdc-test.c
Mine, as part of the FDC stanza.
> tests/libqos/ahci.c
> tests/libqos/ahci.h
Mine again, as part of the IDE stanza.
> tests/libqos/fw_cfg.c
> tests/libqos/fw_cfg.h
> tests/libqos/i2c-imx.c
> tests/libqos/i2c-omap.c
> tests/libqos/i2c.c
> tests/libqos/i2c.h
> tests/libqos/libqos-pc.c
> tests/libqos/libqos-pc.h
> tests/libqos/libqos.c
> tests/libqos/libqos.h
> tests/libqos/malloc-generic.c
> tests/libqos/malloc-generic.h
> tests/libqos/malloc-pc.c
> tests/libqos/malloc-pc.h
> tests/libqos/malloc.c
> tests/libqos/malloc.h
> tests/libqos/pci-pc.c
> tests/libqos/pci-pc.h
> tests/libqos/pci.c
> tests/libqos/pci.h
> tests/libqos/usb.c
> tests/libqos/usb.h
> tests/libqos/virtio-mmio.c
> tests/libqos/virtio-mmio.h
> tests/libqos/virtio-pci.c
> tests/libqos/virtio-pci.h
> tests/libqos/virtio.c
> tests/libqos/virtio.h
> tests/libqtest.c
> tests/libqtest.h
I wouldn't mind taking these, if that helped instead of being a burden.
I expect most of the time that changes to these files will go through
other trees.
Perhaps as a 'weak' assignment, but allowing e.g. virtio, i2c, etc to be
more strongly associated with those subsystems and their maintainers
instead; like I will group tests/libqos/ahci.[ch] with my IDE stanza.
[ tests/multiboot/* ]
[ tests/rocker/* ]
[ tests/tcg/* ]
> tests/test-hbitmap.c
Either me or Paolo, I guess, though I'm not sure if it's worth creating
stanzas for each single test file here. We have bigger fish to fry,
probably.
[ tests/test-qmp-* ]
Our good friend Markus.
[ util/* ] Another giant grab-bag.
--js
^ permalink raw reply [flat|nested] 55+ messages in thread
* Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered
2015-09-22 18:07 ` Eric Blake
@ 2015-09-22 19:50 ` Paolo Bonzini
2015-09-23 8:24 ` Kevin Wolf
2015-09-24 12:47 ` Markus Armbruster
2 siblings, 0 replies; 55+ messages in thread
From: Paolo Bonzini @ 2015-09-22 19:50 UTC (permalink / raw)
To: Eric Blake, Markus Armbruster, qemu-devel, Kevin Wolf, Stefan Hajnoczi
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
On 22/09/2015 20:07, Eric Blake wrote:
> On 09/22/2015 03:13 AM, Markus Armbruster wrote:
>
>>> Full list of unmaintained files now:
>> [...]
>>
>
>> docs/bitmaps.md docs/blkdebug.txt docs/blkverify.txt
>
>> docs/live-block-ops.txt
>
>> docs/qcow2-cache.txt docs/qdev-device-use.txt
>
>> docs/specs/qcow2.txt docs/specs/qed_spec.txt
>
> Kevin, Stefan - should these be added to Block maintainers?
Possibly moved to docs/block while at it?
Paolo
^ permalink raw reply [flat|nested] 55+ messages in thread
* Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered
2015-09-22 18:07 ` Eric Blake
2015-09-22 19:50 ` Paolo Bonzini
@ 2015-09-23 8:24 ` Kevin Wolf
2015-09-23 8:30 ` Alberto Garcia
2015-09-24 12:47 ` Markus Armbruster
2 siblings, 1 reply; 55+ messages in thread
From: Kevin Wolf @ 2015-09-23 8:24 UTC (permalink / raw)
To: Eric Blake; +Cc: berto, Markus Armbruster, Stefan Hajnoczi, qemu-devel
[-- Attachment #1: Type: text/plain, Size: 970 bytes --]
Am 22.09.2015 um 20:07 hat Eric Blake geschrieben:
> On 09/22/2015 03:13 AM, Markus Armbruster wrote:
>
> >> Full list of unmaintained files now:
> > [...]
> >
>
> > docs/bitmaps.md
> > docs/blkdebug.txt
> > docs/blkverify.txt
>
> > docs/live-block-ops.txt
>
> > docs/qcow2-cache.txt
> > docs/qdev-device-use.txt
>
> > docs/specs/qcow2.txt
> > docs/specs/qed_spec.txt
>
> Kevin, Stefan - should these be added to Block maintainers?
Except for docs/qdev-device-use.txt, I guess.
Also, they shouldn't be added to block in general, but to the specific
block drivers/subsystems like qcow2, qed, block jobs etc.
> > include/qemu/throttle.h
>
> Block?
Would be covered if it were in the correct place (include/block/).
Should we add a separate section for I/O throttling, maintained by
Berto, as well? So far it's part of the block layer core - that is,
officially maintained by me and I know next to nothing about it.
Kevin
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 55+ messages in thread
* Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered
2015-09-23 8:24 ` Kevin Wolf
@ 2015-09-23 8:30 ` Alberto Garcia
2015-09-24 12:49 ` Markus Armbruster
0 siblings, 1 reply; 55+ messages in thread
From: Alberto Garcia @ 2015-09-23 8:30 UTC (permalink / raw)
To: Kevin Wolf, Eric Blake; +Cc: Markus Armbruster, Stefan Hajnoczi, qemu-devel
On Wed 23 Sep 2015 10:24:55 AM CEST, Kevin Wolf <kwolf@redhat.com> wrote:
>> > include/qemu/throttle.h
>>
>> Block?
>
> Would be covered if it were in the correct place (include/block/).
>
> Should we add a separate section for I/O throttling, maintained by
> Berto, as well? So far it's part of the block layer core - that is,
> officially maintained by me and I know next to nothing about it.
Yes, you can list me as maintainer of the throttling code.
Thanks for telling,
Berto
^ permalink raw reply [flat|nested] 55+ messages in thread
* Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered
2015-09-22 18:07 ` Eric Blake
2015-09-22 19:50 ` Paolo Bonzini
2015-09-23 8:24 ` Kevin Wolf
@ 2015-09-24 12:47 ` Markus Armbruster
2 siblings, 0 replies; 55+ messages in thread
From: Markus Armbruster @ 2015-09-24 12:47 UTC (permalink / raw)
To: Eric Blake; +Cc: Kevin Wolf, qemu-devel, Stefan Hajnoczi
Eric Blake <eblake@redhat.com> writes:
> On 09/22/2015 03:13 AM, Markus Armbruster wrote:
>
>>> Full list of unmaintained files now:
>> [...]
>>
>
>> docs/bitmaps.md
>> docs/blkdebug.txt
>> docs/blkverify.txt
>
>> docs/live-block-ops.txt
>
>> docs/qcow2-cache.txt
>> docs/qdev-device-use.txt
>
>> docs/specs/qcow2.txt
>> docs/specs/qed_spec.txt
>
> Kevin, Stefan - should these be added to Block maintainers?
>
>> docs/writing-qmp-commands.txt
>
> Markus: Probably belongs to qapi.
QMP, actually.
>> include/qapi/dealloc-visitor.h
>> include/qapi/opts-visitor.h
>> include/qapi/qmp-event.h
>> include/qapi/qmp-input-visitor.h
>> include/qapi/qmp-output-visitor.h
>> include/qapi/qmp/dispatch.h
>> include/qapi/qmp/json-lexer.h
>> include/qapi/qmp/json-parser.h
>> include/qapi/qmp/json-streamer.h
>> include/qapi/qmp/qbool.h
>> include/qapi/qmp/qdict.h
>> include/qapi/qmp/qerror.h
>> include/qapi/qmp/qfloat.h
>> include/qapi/qmp/qint.h
>> include/qapi/qmp/qjson.h
>> include/qapi/qmp/qlist.h
>> include/qapi/qmp/qobject.h
>> include/qapi/qmp/qstring.h
>> include/qapi/qmp/types.h
>> include/qapi/string-input-visitor.h
>> include/qapi/string-output-visitor.h
>> include/qapi/util.h
>> include/qapi/visitor-impl.h
>> include/qapi/visitor.h
>
> Definitely belongs to qapi.
The core visitor stuff is clearly QAPI. The QMP visitor stuff is where
QAPI and QMP overlap. As long as they share a maintainer (currently
me), it doesn't matter much on which side of the fence we file them.
>> include/qemu/throttle.h
>
> Block?
>
>> include/qjson.h
>
> qapi?
Nope. Belongs to qjson.c, which has nothing to do with QAPI. It's a
(yet another) JSON writer that is currently used by migration.
Unfortunate choice of filename, because not only do qjson.[ch] exist
elsewhere already, but that qjson.c used to be right here until it got
moved elsewhere! Results in a really confusing git-log.
Details: commit a372823 moved qjson.c to qobject/qjson.c, and commit
190c882 created it again. Blerch.
>> tests/check-qdict.c
>> tests/check-qfloat.c
>> tests/check-qint.c
>> tests/check-qjson.c
>> tests/check-qlist.c
>
>> tests/check-qstring.c
>
> qapi?
Close: QObject.
>> tests/test-opts-visitor.c
>
>> tests/test-qmp-commands.c
>> tests/test-qmp-event.c
>> tests/test-qmp-input-strict.c
>> tests/test-qmp-input-visitor.c
>> tests/test-qmp-output-visitor.c
>
>> tests/test-string-input-visitor.c
>> tests/test-string-output-visitor.c
>
> qapi
Again, some QAPI, some QAPI/QMP.
I'll prepare patches to update MAINTAINERS for QAPI, QMP and QObject.
> Also, should we have some new group for maintainer files, for things like:
>
> .exrc
> .gitignore
> .gitmodules
> .mailmap
> .travis.yml
> CODING_STYLE
> COPYING
> COPYING.LIB
> Changelog
> HACKING
> LICENSE
> MAINTAINERS
>
> README
> VERSION
>
> scripts/get_maintainer.pl
If a maintainer steps forward.
^ permalink raw reply [flat|nested] 55+ messages in thread
* Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered
2015-09-23 8:30 ` Alberto Garcia
@ 2015-09-24 12:49 ` Markus Armbruster
0 siblings, 0 replies; 55+ messages in thread
From: Markus Armbruster @ 2015-09-24 12:49 UTC (permalink / raw)
To: Alberto Garcia; +Cc: Kevin Wolf, qemu-devel, Stefan Hajnoczi
Alberto Garcia <berto@igalia.com> writes:
> On Wed 23 Sep 2015 10:24:55 AM CEST, Kevin Wolf <kwolf@redhat.com> wrote:
>
>>> > include/qemu/throttle.h
>>>
>>> Block?
>>
>> Would be covered if it were in the correct place (include/block/).
Let's move it to the correct place then.
>> Should we add a separate section for I/O throttling, maintained by
>> Berto, as well? So far it's part of the block layer core - that is,
>> officially maintained by me and I know next to nothing about it.
>
> Yes, you can list me as maintainer of the throttling code.
Cool, thanks!
^ permalink raw reply [flat|nested] 55+ messages in thread
* Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered
2015-09-22 9:13 ` Markus Armbruster
` (4 preceding siblings ...)
2015-09-22 18:37 ` John Snow
@ 2016-08-30 11:31 ` Markus Armbruster
2016-08-30 12:26 ` Cornelia Huck
` (5 more replies)
5 siblings, 6 replies; 55+ messages in thread
From: Markus Armbruster @ 2016-08-30 11:31 UTC (permalink / raw)
To: qemu-devel
Markus Armbruster <armbru@redhat.com> writes:
> Paolo asked for an update.
Another update; HEAD is commit e00da55.
> Markus Armbruster <armbru@redhat.com> writes:
>
>> Markus Armbruster <armbru@redhat.com> writes:
>>
>>> In my experience, too many files are not covered by MAINTAINERS.
>>> scripts/get_maintainer.pl falls back to git then, unless you say
>>> --no-git-fallback. Copies sent there tends to annoy their recipients
>>> without accomplishing all that much.
>>>
>>> Two obvious improvements:
>>>
>>> * Easy: Flip scripts/get_maintainer.pl's default to --no-git-fallback.
>>> I'll post the obvious patch, please raise your objections there.
>>>
>>> * Harder: improve MAINTAINERS coverage.
>>
>> A few folks have started doing that. Much appreciated!
>>
>> I collected recent patches to MAINTAINERS, and reran my analysis.
>>
>>> Let me back up subjective experience with hard data. The tree has quite
>>> a few files:
>>>
>>> $ git-ls-files | wc -l
>>> 3746
>>
>> Now 3752.
>
> Eleven months later, this is 4387.
Another eleven months later, it's 4921.
>>> Counting them by extension:
>>>
>>> $ git-ls-files | sed -n 's#.*/##;s#.*\.##p' | sort | uniq -c | sort -nr
>>> 1836 c
>>> 818 h
>>> 133 out
>>> 105 S
>>> 97 objs
>>> 69 s
>>> 64 mak
>>> 48 json
>>> 47 py
>>> 41 txt
>>> 33 exit
>>> 33 err
>>> 16 xml
>>> 16 bin
>>> 13 rom
>>> 12 sh
>>> 12 dsl
>>> [Long tail that doesn't add up to anything interesting omitted]
>>>
>>> Let's look for .c not in MAINTAINERS:
>>>
>>> $ for i in `git-ls-files`; do [ "`scripts/get_maintainer.pl -f --no-git-fallback $i`" ] || echo $i; done >unmaintained-files
>>> $ grep -c '\.c$' unmaintained-files
>>> 1066
>>>
>>> That's almost 60%. Not good.
>>
>> Down to 491 our of 1841 (27%). Progress, but not quite enough.
>
> 461 out of 1945 (24%). At this linear rate, we'll reach 10%
> unmaintained in five years.
This is now
$ for i in `git-ls-files`; do [ "`scripts/get_maintainer.pl -f --no-git-fallback $i | grep -v '^qemu-devel@nongnu\.org'`" ] || echo $i; done >unmaintained-files
$ grep -c '\.c$' unmaintained-files
402
402 out of 2132 (19%). More progress, but not yet there.
> We're still adding unmaintained .c files:
>
> $ git-diff --diff-filter=A --name-only e668d1b | grep -c '\.c$'
> 116
> $ git-diff --diff-filter=A --name-only e668d1b | grep '\.c$' | join unmaintained-files - | wc -l
> 37
>
> 37 out of 116 new files (32%) are not covered. That's worse than we do
> for old files. Inexcusable.
$ git-diff --diff-filter=A --name-only 6138fbd | grep -c '\.c$'
215
$ git-diff --diff-filter=A --name-only 6138fbd | grep '\.c$' | join unmaintained-files - | wc -l
86
This time, it's 86 out of 215 (40%). Getting worse. I'll cook up a
patch to make checkpatch.pl catch such additions.
>>> Apparently, nobody cares for tests:
>>>
>>> $ grep '^tests/' unmaintained-files | grep -c '\.c$'
>>> 654
>>> $ git-ls-files | grep '^tests/' | grep -c '\.c$'
>>> 664
>>
>> Now 91 out of 665.
>
> 105 out of 687.
114 out of 726.
>>> Filtering those out leaves us with 412 unmaintained out of of 1172, or
>>> 35% unmaintained. Not good even if we (foolishly!) considered tests not
>>> worthy of maintenance.
>>>
>>> Maybe unmaintained files are much smaller. David A. Wheeler's
>>> SLOCCount counts 570kSLOC in 1212 maintained files (+140 files sloccount
>>> doesn't know how to count) vs. 300kSLOC in 1798 unmaintained files (+596
>>> uncounted), or 35% unmaintained SLOC. With tests/ ignored, it's 30%.
>>> So, unmaintained files are indeed smaller, but 30-something percent is
>>> still not good.
>>>
>>> Where are the unmaintained files? Top-scoring directories outside
>>> tests/ and include/, files in subdirs not counted:
>>>
>>> #files directory
>>> 84 68% .
>>> 63 100% default-configs
>>> 48 100% pc-bios
>>> 43 97% stubs
>>> 39 100% util
>>> 37 100% pc-bios/keymaps
>>> 35 81% hw/display
>>> 32 94% scripts
>>> 26 92% docs
>>> 26 100% libcacard
>>> 23 69% hw/misc
>>> 22 57% hw/net
>>> 21 63% hw/intc
>>> 19 100% roms
>>> 18 100% disas
>>> 18 56% hw/timer
>>> 16 100% hw/core
>>> 15 53% hw/char
>>> 15 100% qga
>>> 14 100% docs/specs
>>> 12 92% hw/input
>>> 12 100% qobject
>>> 12 100% target-m68k
>>> 11 100% backends
>>> 11 100% pc-bios/s390-ccw
>>> 10 71% hw/dma
>
> Different tack: what are the unmaintained files we actually change?
>
> Unmaintained files sorted by number of commits in the past year (commit
> 1733681):
>
> $ for i in `cat unmaintained-files`; do echo -n "$i "; git-rev-list 1733681.. $i | wc -l; done | awk '{ printf "%7d %s\n", $2, $1 }' | sort -rn | head -n 100
> 79 trace-events
> 77 MAINTAINERS
> 74 tests/Makefile
> 37 hw/core/qdev.c
> 35 arch_init.c
> 33 tests/libqos/ahci.c
> 30 tests/libqos/ahci.h
> 27 qdev-monitor.c
> 27 include/hw/boards.h
> 27 Makefile
> 26 include/exec/exec-all.h
> 25 include/hw/virtio/virtio.h
> 24 hw/xen/xen_pt_config_init.c
> 23 include/hw/virtio/virtio-scsi.h
> 22 util/qemu-option.c
> 22 hw/net/rtl8139.c
> 22 hw/intc/arm_gic.c
> 22 VERSION
> 21 target-tilegx/translate.c
> 21 include/ui/console.h
[...]
Unmaintained files sorted by number of commits in the past year (commit
351053e):
$ for i in `cat unmaintained-files`; do echo -n "$i "; git-rev-list 351053e.. $i | wc -l; done | awk '{ printf "%7d %s\n", $2, $1 }' | sort -rn | head -n 100
181 trace-events
104 configure
98 MAINTAINERS
82 hw/misc/ivshmem.c
54 qemu-options.hx
53 Makefile.objs
50 target-tilegx/translate.c
49 Makefile
42 include/sysemu/block-backend.h
31 include/qemu-common.h
30 tests/vhost-user-test.c
28 tests/.gitignore
28 include/qom/cpu.h
27 include/qemu/osdep.h
23 include/sysemu/sysemu.h
22 tests/test-throttle.c
22 scripts/checkpatch.pl
22 hw/ipmi/ipmi_bmc_sim.c
21 qemu-doc.texi
20 util/log.c
20 tests/Makefile.include
20 VERSION
19 include/hw/compat.h
18 util/oslib-posix.c
18 tests/ivshmem-test.c
18 stubs/Makefile.objs
18 include/qemu/typedefs.h
18 include/qemu/log.h
18 hw/sd/sdhci.c
18 hw/nvram/fw_cfg.c
17 target-m68k/translate.c
17 include/sysemu/replay.h
17 hw/sd/sd.c
17 hw/core/qdev-properties.c
16 replay/replay.c
16 include/sysemu/char.h
16 hw/core/qdev.c
16 gdbstub.c
15 tests/vhost-user-bridge.c
15 tests/test-visitor-serialization.c
15 dump.c
15 docs/specs/vhost-user.txt
15 bsd-user/main.c
14 util/cutils.c
14 replay/replay-internal.h
14 qom/cpu.c
14 hw/misc/Makefile.objs
13 target-tilegx/cpu.h
13 replay/replay-input.c
13 Makefile.target
12 util/Makefile.objs
12 qdev-monitor.c
12 hw/display/vga.c
12 contrib/ivshmem-server/main.c
11 util/oslib-win32.c
11 tests/bios-tables-test.c
11 scripts/clean-includes
11 hw/intc/gicv3_internal.h
11 hw/intc/Makefile.objs
11 hw/core/qdev-properties-system.c
11 hw/core/loader.c
10 tests/virtio-blk-test.c
10 target-tilegx/helper.h
10 scripts/dump-guest-memory.py
10 include/hw/nvram/fw_cfg.h
10 hw/input/hid.c
10 disas.c
10 default-configs/i386-softmmu.mak
10 default-configs/arm-softmmu.mak
10 contrib/ivshmem-server/ivshmem-server.c
9 tests/test-qga.c
9 tests/test-cutils.c
9 tests/test-aio.c
9 tests/libqtest.c
9 target-m68k/cpu.h
9 scripts/update-linux-headers.sh
9 rules.mak
9 include/hw/qdev-core.h
9 include/hw/isa/isa.h
9 hw/misc/mips_itu.c
9 hmp-commands-info.hx
9 default-configs/x86_64-softmmu.mak
9 contrib/ivshmem-server/ivshmem-server.h
8 util/qemu-option.c
8 tests/virtio-scsi-test.c
8 tests/virtio-net-test.c
8 tests/test-logging.c
8 replay/replay-events.c
8 qemu-nbd.texi
8 pc-bios/optionrom/Makefile
8 include/hw/arm/xlnx-zynqmp.h
8 hw/moxie/moxiesim.c
8 hw/misc/bcm2835_property.c
8 hw/m68k/an5206.c
8 hw/input/ps2.c
8 hw/display/vmware_vga.c
8 hw/core/ptimer.c
8 .gitignore
7 util/osdep.c
7 util/mmap-alloc.c
Active subsystems lacking a maintainer include tilegx, qdev, replay.
Headers that should probably be covered by existing MAINTAINERS stanzas
include include/sysemu/block-backend.h include/qom/cpu.h
include/hw/arm/xlnx-zynqmp.h.
> Sorted by maximum(added lines, deleted lines), top scorers:
>
> $ git-diff --numstat 1733681 `cat unmaintained-files ` | awk '{ print ($1 > $2 ? $1 : $2), $0 }' | sort -nr | sed 's/^[0-9]* //' | head -n 100
> 2161 0 target-tilegx/translate.c
> 1504 0 pc-bios/qemu.rsrc
> 1406 0 target-tilegx/opcode_tilegx.h
> 1255 0 tests/test-cutils.c
> 1203 0 include/standard-headers/linux/input.h
> 1 1112 arch_init.c
> 1104 0 tests/pkix_asn1_tab.c
> 1039 767 fpu/softfloat.c
> 1014 0 docs/specs/rocker.txt
> 962 0 tests/libqos/ahci.c
> 924 4 disas/mips.c
> 908 0 include/standard-headers/linux/pci_regs.h
> 609 150 hw/intc/arm_gic.c
> 597 0 scripts/analyze-migration.py
> 586 0 tests/libqos/ahci.h
> 565 119 hw/display/tcx.c
> 485 0 tests/crypto-tls-x509-helpers.c
> 465 0 tests/tco-test.c
> 463 0 tests/rcutorture.c
> 439 0 hw/display/vga-helpers.h
[...]
$ git-diff --numstat 351053e `cat unmaintained-files ` | awk '{ print ($1 > $2 ? $1 : $2), $0 }' | sort -nr | sed 's/^[0-9]* //' | head -n 100
2453 0 target-tilegx/translate.c
1810 0 hw/ipmi/ipmi_bmc_sim.c
63 1542 trace-events
1438 0 tests/vhost-user-bridge.c
1406 0 target-tilegx/opcode_tilegx.h
1348 5 tests/test-cutils.c
1105 0 tests/pkix_asn1_tab.c
1063 0 linux-headers/asm-mips/unistd.h
950 515 hw/misc/ivshmem.c
930 0 tests/test-qga.c
907 559 configure
844 0 util/qht.c
825 0 hmp-commands-info.hx
805 0 include/standard-headers/linux/input-event-codes.h
71 788 include/standard-headers/linux/input.h
778 0 tests/Makefile.include
635 0 include/hw/ide/internal.h
623 0 tests/migration/guestperf/plot.py
177 539 scripts/checkpatch.pl
537 0 hw/ipmi/isa_ipmi_bt.c
530 0 tests/postcopy-test.c
524 0 hw/misc/mips_itu.c
519 175 tests/vhost-user-test.c
519 0 hw/ipmi/ipmi_bmc_extern.c
516 0 tests/ivshmem-test.c
514 0 hw/timer/aspeed_timer.c
501 0 hw/ipmi/isa_ipmi_kcs.c
487 0 tests/qht-bench.c
485 0 tests/crypto-tls-x509-helpers.c
478 0 tests/e1000e-test.c
468 72 qemu-options.hx
460 0 hw/intc/mips_gic.c
459 282 scripts/dump-guest-memory.py
457 0 contrib/ivshmem-server/ivshmem-server.c
453 0 include/hw/arm/fsl-imx6.h
452 0 linux-headers/asm-arm/unistd.h
446 0 contrib/ivshmem-client/ivshmem-client.c
440 0 hw/misc/bcm2835_property.c
440 0 hw/i2c/aspeed_i2c.c
439 0 tests/migration/guestperf/engine.py
432 0 tests/ipmi-bt-test.c
426 0 hw/display/bcm2835_fb.c
412 58 hw/nvram/fw_cfg.c
410 0 hw/dma/bcm2835_dma.c
408 0 linux-headers/asm-s390/unistd.h
405 0 include/hw/ide/ahci.h
397 0 util/qdist.c
396 0 linux-headers/asm-powerpc/unistd.h
389 0 tests/test-qdist.c
381 0 linux-headers/asm-x86/unistd_32.h
8 368 include/qemu-common.h
367 0 tests/migration/stress.c
366 0 include/standard-headers/asm-x86/hyperv.h
355 74 MAINTAINERS
354 0 replay/replay.c
343 95 include/standard-headers/linux/pci_regs.h
339 0 hw/intc/aspeed_vic.c
338 0 util/log.c
336 0 hw/misc/bcm2835_mbox.c
334 0 linux-headers/asm-x86/unistd_64.h
331 0 hw/intc/gicv3_internal.h
323 0 linux-headers/asm-x86/unistd_x32.h
320 69 scripts/qemu-binfmt-conf.sh
318 46 util/cutils.c
311 0 replay/replay-events.c
308 0 hw/i2c/i2c-ddc.c
305 0 hw/intc/bcm2836_control.c
304 0 hw/misc/zynq-xadc.c
298 0 pc-bios/optionrom/linuxboot_dma.c
295 6 util/oslib-win32.c
292 0 tests/ipmi-kcs-test.c
292 0 hw/misc/auxbus.c
282 0 hw/misc/aspeed_scu.c
273 0 contrib/ivshmem-server/main.c
262 0 include/hw/ipmi/ipmi.h
261 89 hw/sd/sd.c
257 0 include/hw/net/imx_fec.h
255 0 tests/migration/guestperf/shell.py
254 0 tests/test-blockjob-txn.c
254 0 docs/specs/ivshmem-spec.txt
252 0 docs/throttle.txt
80 251 hw/core/qdev.c
251 0 hw/core/bus.c
1 250 linux-headers/asm-x86/hyperv.h
249 0 include/hw/arm/fsl-imx25.h
248 0 tests/io-channel-helpers.c
246 0 hw/misc/mips_cmgcr.c
243 111 dump.c
241 0 contrib/ivshmem-client/main.c
238 0 hw/intc/bcm2835_ic.c
232 0 hw/sd/sdhci-internal.h
231 5 docs/specs/vhost-user.txt
231 0 util/timed-average.c
222 0 scripts/qemu.py
221 2 docs/specs/qcow2.txt
216 0 tests/test-filter-redirector.c
216 0 target-tilegx/spr_def_64.h
216 0 include/hw/intc/mips_gic.h
213 0 scripts/clean-header-guards.pl
212 0 contrib/ivshmem-client/ivshmem-client.h
>>>
>>> Ideas? Takers?
>>
>> Full list of unmaintained files now:
[...]
.dir-locals.el
.exrc
.gitignore
.gitmodules
.mailmap
CODING_STYLE
COPYING
COPYING.LIB
Changelog
HACKING
LICENSE
MAINTAINERS
Makefile
Makefile.objs
Makefile.target
README
VERSION
accel.c
arch_init.c
backends/Makefile.objs
backends/tpm.c
balloon.c
bsd-user/Makefile.objs
bsd-user/bsd-mman.h
bsd-user/bsdload.c
bsd-user/elfload.c
bsd-user/errno_defs.h
bsd-user/freebsd/strace.list
bsd-user/freebsd/syscall_nr.h
bsd-user/i386/target_signal.h
bsd-user/i386/target_syscall.h
bsd-user/main.c
bsd-user/mmap.c
bsd-user/netbsd/strace.list
bsd-user/netbsd/syscall_nr.h
bsd-user/openbsd/strace.list
bsd-user/openbsd/syscall_nr.h
bsd-user/qemu.h
bsd-user/signal.c
bsd-user/sparc/target_signal.h
bsd-user/sparc/target_syscall.h
bsd-user/sparc64/target_signal.h
bsd-user/sparc64/target_syscall.h
bsd-user/strace.c
bsd-user/syscall.c
bsd-user/syscall_defs.h
bsd-user/uaccess.c
bsd-user/x86_64/target_signal.h
bsd-user/x86_64/target_syscall.h
bt-host.c
bt-vhci.c
configure
contrib/ivshmem-client/Makefile.objs
contrib/ivshmem-client/ivshmem-client.c
contrib/ivshmem-client/ivshmem-client.h
contrib/ivshmem-client/main.c
contrib/ivshmem-server/Makefile.objs
contrib/ivshmem-server/ivshmem-server.c
contrib/ivshmem-server/ivshmem-server.h
contrib/ivshmem-server/main.c
default-configs/aarch64-linux-user.mak
default-configs/aarch64-softmmu.mak
default-configs/alpha-linux-user.mak
default-configs/alpha-softmmu.mak
default-configs/arm-linux-user.mak
default-configs/arm-softmmu.mak
default-configs/armeb-linux-user.mak
default-configs/cris-linux-user.mak
default-configs/cris-softmmu.mak
default-configs/i386-bsd-user.mak
default-configs/i386-linux-user.mak
default-configs/i386-softmmu.mak
default-configs/lm32-softmmu.mak
default-configs/m68k-linux-user.mak
default-configs/m68k-softmmu.mak
default-configs/microblaze-linux-user.mak
default-configs/microblaze-softmmu.mak
default-configs/microblazeel-linux-user.mak
default-configs/microblazeel-softmmu.mak
default-configs/mips-linux-user.mak
default-configs/mips-softmmu-common.mak
default-configs/mips-softmmu.mak
default-configs/mips64-linux-user.mak
default-configs/mips64-softmmu.mak
default-configs/mips64el-linux-user.mak
default-configs/mips64el-softmmu.mak
default-configs/mipsel-linux-user.mak
default-configs/mipsel-softmmu.mak
default-configs/mipsn32-linux-user.mak
default-configs/mipsn32el-linux-user.mak
default-configs/moxie-softmmu.mak
default-configs/or32-linux-user.mak
default-configs/or32-softmmu.mak
default-configs/pci.mak
default-configs/ppc-linux-user.mak
default-configs/ppc-softmmu.mak
default-configs/ppc64-linux-user.mak
default-configs/ppc64-softmmu.mak
default-configs/ppc64abi32-linux-user.mak
default-configs/ppc64le-linux-user.mak
default-configs/ppcemb-softmmu.mak
default-configs/s390x-linux-user.mak
default-configs/s390x-softmmu.mak
default-configs/sh4-linux-user.mak
default-configs/sh4-softmmu.mak
default-configs/sh4eb-linux-user.mak
default-configs/sh4eb-softmmu.mak
default-configs/sound.mak
default-configs/sparc-bsd-user.mak
default-configs/sparc-linux-user.mak
default-configs/sparc-softmmu.mak
default-configs/sparc32plus-linux-user.mak
default-configs/sparc64-bsd-user.mak
default-configs/sparc64-linux-user.mak
default-configs/sparc64-softmmu.mak
default-configs/tilegx-linux-user.mak
default-configs/tricore-softmmu.mak
default-configs/unicore32-linux-user.mak
default-configs/unicore32-softmmu.mak
default-configs/usb.mak
default-configs/x86_64-bsd-user.mak
default-configs/x86_64-linux-user.mak
default-configs/x86_64-softmmu.mak
default-configs/xtensa-softmmu.mak
default-configs/xtensaeb-softmmu.mak
device-hotplug.c
disas.c
disas/Makefile.objs
disas/hppa.c
disas/m68k.c
dma-helpers.c
docs/aio_notify.promela
docs/aio_notify_accept.promela
docs/aio_notify_bug.promela
docs/atomics.txt
docs/bitmaps.md
docs/blkdebug.txt
docs/blkverify.txt
docs/bootindex.txt
docs/ccid.txt
docs/ich9-ehci-uhci.cfg
docs/igd-assign.txt
docs/image-fuzzer.txt
docs/live-block-ops.txt
docs/memory-hotplug.txt
docs/memory.txt
docs/multi-thread-compression.txt
docs/multiple-iothreads.txt
docs/multiseat.txt
docs/pci_expander_bridge.txt
docs/q35-chipset.cfg
docs/qcow2-cache.txt
docs/qdev-device-use.txt
docs/qemupciserial.inf
docs/rcu.txt
docs/rdma.txt
docs/replay.txt
docs/specs/acpi_cpu_hotplug.txt
docs/specs/acpi_mem_hotplug.txt
docs/specs/acpi_nvdimm.txt
docs/specs/acpi_pci_hotplug.txt
docs/specs/edu.txt
docs/specs/fw_cfg.txt
docs/specs/ivshmem-spec.txt
docs/specs/pci-ids.txt
docs/specs/pci-serial.txt
docs/specs/pci-testdev.txt
docs/specs/ppc-spapr-hcalls.txt
docs/specs/ppc-spapr-hotplug.txt
docs/specs/pvpanic.txt
docs/specs/qcow2.txt
docs/specs/qed_spec.txt
docs/specs/rocker.txt
docs/specs/standard-vga.txt
docs/specs/vhost-user.txt
docs/specs/vmw_pvscsi-spec.txt
docs/spice-port-fqdn.txt
docs/throttle.txt
docs/virtio-balloon-stats.txt
docs/virtio-migration.txt
docs/vnc-ledstate-Pseudo-encoding.txt
docs/win32-qemu-event.promela
docs/xbzrle.txt
dtc
dump.c
gdb-xml/aarch64-core.xml
gdb-xml/aarch64-fpu.xml
gdb-xml/arm-core.xml
gdb-xml/arm-neon.xml
gdb-xml/arm-vfp.xml
gdb-xml/arm-vfp3.xml
gdb-xml/cf-core.xml
gdb-xml/cf-fp.xml
gdb-xml/power-altivec.xml
gdb-xml/power-core.xml
gdb-xml/power-fpu.xml
gdb-xml/power-spe.xml
gdb-xml/power-vsx.xml
gdb-xml/power64-core.xml
gdbstub.c
hmp-commands-info.hx
hmp.h
hw/Makefile.objs
hw/bt/Makefile.objs
hw/bt/core.c
hw/bt/hci-csr.c
hw/bt/hci.c
hw/bt/hid.c
hw/bt/l2cap.c
hw/bt/sdp.c
hw/core/Makefile.objs
hw/core/bus.c
hw/core/empty_slot.c
hw/core/fw-path-provider.c
hw/core/hotplug.c
hw/core/irq.c
hw/core/loader.c
hw/core/nmi.c
hw/core/null-machine.c
hw/core/platform-bus.c
hw/core/ptimer.c
hw/core/qdev-properties-system.c
hw/core/qdev-properties.c
hw/core/qdev.c
hw/core/stream.c
hw/core/sysbus.c
hw/core/uboot_image.h
hw/cpu/Makefile.objs
hw/cpu/core.c
hw/cpu/realview_mpcore.c
hw/display/Makefile.objs
hw/display/ads7846.c
hw/display/bcm2835_fb.c
hw/display/blizzard.c
hw/display/cg3.c
hw/display/cirrus_vga.c
hw/display/cirrus_vga_rop.h
hw/display/cirrus_vga_rop2.h
hw/display/dpcd.c
hw/display/framebuffer.c
hw/display/framebuffer.h
hw/display/g364fb.c
hw/display/jazz_led.c
hw/display/sm501.c
hw/display/sm501_template.h
hw/display/ssd0303.c
hw/display/ssd0323.c
hw/display/tc6393xb.c
hw/display/tc6393xb_template.h
hw/display/tcx.c
hw/display/trace-events
hw/display/vga-helpers.h
hw/display/vga-isa-mm.c
hw/display/vga-isa.c
hw/display/vga-pci.c
hw/display/vga.c
hw/display/vga.h
hw/display/vga_int.h
hw/display/vmware_vga.c
hw/dma/Makefile.objs
hw/dma/bcm2835_dma.c
hw/dma/i82374.c
hw/dma/rc4030.c
hw/dma/soc_dma.c
hw/dma/sparc32_dma.c
hw/dma/sun4m_iommu.c
hw/dma/trace-events
hw/gpio/Makefile.objs
hw/gpio/gpio_key.c
hw/gpio/max7310.c
hw/gpio/mpc8xxx.c
hw/gpio/zaurus.c
hw/i2c/Makefile.objs
hw/i2c/aspeed_i2c.c
hw/i2c/bitbang_i2c.c
hw/i2c/bitbang_i2c.h
hw/i2c/core.c
hw/i2c/i2c-ddc.c
hw/i2c/smbus.c
hw/i2c/smbus_eeprom.c
hw/input/Makefile.objs
hw/input/adb.c
hw/input/hid.c
hw/input/lm832x.c
hw/input/pckbd.c
hw/input/ps2.c
hw/input/trace-events
hw/input/tsc2005.c
hw/input/tsc210x.c
hw/input/vmmouse.c
hw/intc/Makefile.objs
hw/intc/aspeed_vic.c
hw/intc/bcm2835_ic.c
hw/intc/bcm2836_control.c
hw/intc/gicv3_internal.h
hw/intc/heathrow_pic.c
hw/intc/mips_gic.c
hw/intc/openpic.c
hw/intc/openpic_kvm.c
hw/intc/sh_intc.c
hw/intc/slavio_intctl.c
hw/intc/trace-events
hw/intc/vgic_common.h
hw/ipmi/Makefile.objs
hw/ipmi/ipmi.c
hw/ipmi/ipmi_bmc_extern.c
hw/ipmi/ipmi_bmc_sim.c
hw/ipmi/isa_ipmi_bt.c
hw/ipmi/isa_ipmi_kcs.c
hw/isa/Makefile.objs
hw/isa/apm.c
hw/isa/i82378.c
hw/isa/isa-bus.c
hw/isa/trace-events
hw/isa/vt82c686.c
hw/m68k/Makefile.objs
hw/m68k/an5206.c
hw/m68k/dummy_m68k.c
hw/m68k/mcf5206.c
hw/m68k/mcf5208.c
hw/m68k/mcf_intc.c
hw/misc/Makefile.objs
hw/misc/applesmc.c
hw/misc/arm_integrator_debug.c
hw/misc/arm_l2x0.c
hw/misc/arm_sysctl.c
hw/misc/aspeed_scu.c
hw/misc/auxbus.c
hw/misc/bcm2835_mbox.c
hw/misc/bcm2835_property.c
hw/misc/cbus.c
hw/misc/eccmemctl.c
hw/misc/hyperv_testdev.c
hw/misc/ivshmem.c
hw/misc/max111x.c
hw/misc/mips_cmgcr.c
hw/misc/mips_cpc.c
hw/misc/mips_itu.c
hw/misc/mst_fpga.c
hw/misc/pvpanic.c
hw/misc/slavio_misc.c
hw/misc/stm32f2xx_syscfg.c
hw/misc/tmp105.c
hw/misc/tmp105.h
hw/misc/trace-events
hw/misc/vmport.c
hw/misc/zynq-xadc.c
hw/moxie/Makefile.objs
hw/moxie/moxiesim.c
hw/nvram/Makefile.objs
hw/nvram/ds1225y.c
hw/nvram/eeprom93xx.c
hw/nvram/fw_cfg.c
hw/nvram/mac_nvram.c
hw/nvram/trace-events
hw/pci-host/Makefile.objs
hw/pci-host/apb.c
hw/pci-host/bonito.c
hw/pci-host/gpex.c
hw/pcmcia/Makefile.objs
hw/pcmcia/pcmcia.c
hw/sd/Makefile.objs
hw/sd/core.c
hw/sd/sd.c
hw/sd/sdhci-internal.h
hw/sd/sdhci.c
hw/sd/ssi-sd.c
hw/sd/trace-events
hw/timer/Makefile.objs
hw/timer/aspeed_timer.c
hw/timer/ds1338.c
hw/timer/m48t59.c
hw/timer/mips_gictimer.c
hw/timer/sh_timer.c
hw/timer/slavio_timer.c
hw/timer/stm32f2xx_timer.c
hw/timer/trace-events
hw/timer/twl92230.c
hw/tpm/Makefile.objs
hw/tpm/tpm_int.h
hw/tpm/tpm_passthrough.c
hw/tpm/tpm_tis.c
hw/tpm/tpm_tis.h
hw/tpm/tpm_util.c
hw/tpm/tpm_util.h
hw/virtio/Makefile.objs
hw/virtio/trace-events
hw/watchdog/Makefile.objs
hw/watchdog/watchdog.c
hw/watchdog/wdt_i6300esb.c
hw/watchdog/wdt_ib700.c
include/disas/bfd.h
include/disas/disas.h
include/elf.h
include/exec/address-spaces.h
include/exec/gdbstub.h
include/exec/gen-icount.h
include/exec/hwaddr.h
include/exec/log.h
include/exec/memattrs.h
include/exec/poison.h
include/exec/semihost.h
include/exec/softmmu-semi.h
include/exec/tb-context.h
include/exec/tb-hash-xx.h
include/exec/user/abitypes.h
include/exec/user/thunk.h
include/glib-compat.h
include/hw/arm/ast2400.h
include/hw/arm/bcm2835_peripherals.h
include/hw/arm/bcm2836.h
include/hw/arm/fdt.h
include/hw/arm/fsl-imx25.h
include/hw/arm/fsl-imx6.h
include/hw/arm/linux-boot-if.h
include/hw/arm/raspi_platform.h
include/hw/arm/sharpsl.h
include/hw/arm/soc_dma.h
include/hw/arm/stm32f205_soc.h
include/hw/arm/sysbus-fdt.h
include/hw/arm/virt.h
include/hw/arm/xlnx-zynqmp.h
include/hw/audio/audio.h
include/hw/audio/pcspk.h
include/hw/block/block.h
include/hw/block/flash.h
include/hw/bt.h
include/hw/char/bcm2835_aux.h
include/hw/char/cadence_uart.h
include/hw/char/digic-uart.h
include/hw/char/escc.h
include/hw/char/imx_serial.h
include/hw/char/pl011.h
include/hw/char/serial.h
include/hw/char/stm32f2xx_usart.h
include/hw/char/xilinx_uartlite.h
include/hw/compat.h
include/hw/cpu/a15mpcore.h
include/hw/cpu/a9mpcore.h
include/hw/cpu/arm11mpcore.h
include/hw/cpu/core.h
include/hw/cris/etraxfs.h
include/hw/cris/etraxfs_dma.h
include/hw/devices.h
include/hw/display/bcm2835_fb.h
include/hw/display/dpcd.h
include/hw/display/xlnx_dp.h
include/hw/dma/bcm2835_dma.h
include/hw/dma/xlnx-zynq-devcfg.h
include/hw/dma/xlnx_dpdma.h
include/hw/elf_ops.h
include/hw/empty_slot.h
include/hw/fw-path-provider.h
include/hw/gpio/imx_gpio.h
include/hw/hotplug.h
include/hw/hw.h
include/hw/i2c/aspeed_i2c.h
include/hw/i2c/i2c-ddc.h
include/hw/i2c/i2c.h
include/hw/i2c/imx_i2c.h
include/hw/i2c/pm_smbus.h
include/hw/i2c/smbus.h
include/hw/ide/ahci.h
include/hw/ide/internal.h
include/hw/ide/pci.h
include/hw/input/adb.h
include/hw/input/hid.h
include/hw/input/ps2.h
include/hw/intc/aspeed_vic.h
include/hw/intc/bcm2835_ic.h
include/hw/intc/bcm2836_control.h
include/hw/intc/imx_avic.h
include/hw/intc/mips_gic.h
include/hw/ipack/ipack.h
include/hw/ipmi/ipmi.h
include/hw/irq.h
include/hw/isa/apm.h
include/hw/isa/i8257.h
include/hw/isa/i8259_internal.h
include/hw/isa/isa.h
include/hw/isa/pc87312.h
include/hw/isa/vt82c686.h
include/hw/kvm/clock.h
include/hw/loader.h
include/hw/m68k/mcf.h
include/hw/mem/pc-dimm.h
include/hw/mips/bios.h
include/hw/mips/cps.h
include/hw/mips/cpudevs.h
include/hw/mips/mips.h
include/hw/misc/arm_integrator_debug.h
include/hw/misc/aspeed_scu.h
include/hw/misc/auxbus.h
include/hw/misc/bcm2835_mbox.h
include/hw/misc/bcm2835_mbox_defs.h
include/hw/misc/bcm2835_property.h
include/hw/misc/imx25_ccm.h
include/hw/misc/imx31_ccm.h
include/hw/misc/imx6_ccm.h
include/hw/misc/imx6_src.h
include/hw/misc/imx_ccm.h
include/hw/misc/ivshmem.h
include/hw/misc/mips_cmgcr.h
include/hw/misc/mips_cpc.h
include/hw/misc/mips_itu.h
include/hw/misc/stm32f2xx_syscfg.h
include/hw/misc/tmp105_regs.h
include/hw/misc/zynq-xadc.h
include/hw/net/cadence_gem.h
include/hw/net/imx_fec.h
include/hw/net/mii.h
include/hw/nmi.h
include/hw/nvram/eeprom93xx.h
include/hw/nvram/fw_cfg.h
include/hw/nvram/fw_cfg_keys.h
include/hw/nvram/openbios_firmware_abi.h
include/hw/pci-host/apb.h
include/hw/pci-host/gpex.h
include/hw/pci-host/ppce500.h
include/hw/pcmcia.h
include/hw/platform-bus.h
include/hw/ppc/mac_dbdma.h
include/hw/ppc/openpic.h
include/hw/ppc/ppc.h
include/hw/ppc/ppc4xx.h
include/hw/ppc/ppc_e500.h
include/hw/ptimer.h
include/hw/qdev-core.h
include/hw/qdev-dma.h
include/hw/qdev-properties.h
include/hw/qdev.h
include/hw/scsi/esp.h
include/hw/scsi/scsi.h
include/hw/sd/sd.h
include/hw/sd/sdhci.h
include/hw/sh4/sh.h
include/hw/sh4/sh_intc.h
include/hw/sparc/grlib.h
include/hw/sparc/sparc32_dma.h
include/hw/sparc/sun4m.h
include/hw/ssi/aspeed_smc.h
include/hw/ssi/imx_spi.h
include/hw/ssi/ssi.h
include/hw/ssi/xilinx_spips.h
include/hw/stream.h
include/hw/sysbus.h
include/hw/timer/aspeed_timer.h
include/hw/timer/digic-timer.h
include/hw/timer/hpet.h
include/hw/timer/i8254.h
include/hw/timer/i8254_internal.h
include/hw/timer/imx_epit.h
include/hw/timer/imx_gpt.h
include/hw/timer/m48t59.h
include/hw/timer/mc146818rtc.h
include/hw/timer/mc146818rtc_regs.h
include/hw/timer/mips_gictimer.h
include/hw/timer/stm32f2xx_timer.h
include/hw/tricore/tricore.h
include/hw/unicore32/puv3.h
include/hw/watchdog/wdt_diag288.h
include/libdecnumber/dconfig.h
include/libdecnumber/decContext.h
include/libdecnumber/decDPD.h
include/libdecnumber/decNumber.h
include/libdecnumber/decNumberLocal.h
include/libdecnumber/dpd/decimal128.h
include/libdecnumber/dpd/decimal128Local.h
include/libdecnumber/dpd/decimal32.h
include/libdecnumber/dpd/decimal64.h
include/monitor/hmp-target.h
include/monitor/monitor.h
include/monitor/qdev.h
include/qapi/qmp/dispatch.h
include/qemu-common.h
include/qemu-io.h
include/qemu/acl.h
include/qemu/atomic.h
include/qemu/base64.h
include/qemu/bcd.h
include/qemu/bitmap.h
include/qemu/bitops.h
include/qemu/bswap.h
include/qemu/compatfd.h
include/qemu/compiler.h
include/qemu/config-file.h
include/qemu/crc32c.h
include/qemu/cutils.h
include/qemu/envlist.h
include/qemu/event_notifier.h
include/qemu/fifo32.h
include/qemu/fifo8.h
include/qemu/fprintf-fn.h
include/qemu/hbitmap.h
include/qemu/help_option.h
include/qemu/host-utils.h
include/qemu/id.h
include/qemu/int128.h
include/qemu/iov.h
include/qemu/log.h
include/qemu/main-loop.h
include/qemu/memfd.h
include/qemu/mmap-alloc.h
include/qemu/module.h
include/qemu/notify.h
include/qemu/option.h
include/qemu/option_int.h
include/qemu/osdep.h
include/qemu/path.h
include/qemu/processor.h
include/qemu/qdist.h
include/qemu/qht.h
include/qemu/queue.h
include/qemu/range.h
include/qemu/ratelimit.h
include/qemu/rcu.h
include/qemu/rcu_queue.h
include/qemu/readline.h
include/qemu/rfifolock.h
include/qemu/seqlock.h
include/qemu/thread-posix.h
include/qemu/thread-win32.h
include/qemu/thread.h
include/qemu/timed-average.h
include/qemu/timer.h
include/qemu/typedefs.h
include/qemu/unicode.h
include/qemu/uri.h
include/qemu/xattr.h
include/qom/cpu.h
include/standard-headers/asm-s390/kvm_virtio.h
include/standard-headers/asm-s390/virtio-ccw.h
include/standard-headers/asm-x86/hyperv.h
include/standard-headers/linux/if_ether.h
include/standard-headers/linux/input-event-codes.h
include/standard-headers/linux/input.h
include/standard-headers/linux/pci_regs.h
include/standard-headers/linux/types.h
include/standard-headers/linux/virtio_9p.h
include/standard-headers/linux/virtio_balloon.h
include/standard-headers/linux/virtio_blk.h
include/standard-headers/linux/virtio_config.h
include/standard-headers/linux/virtio_console.h
include/standard-headers/linux/virtio_gpu.h
include/standard-headers/linux/virtio_ids.h
include/standard-headers/linux/virtio_input.h
include/standard-headers/linux/virtio_net.h
include/standard-headers/linux/virtio_pci.h
include/standard-headers/linux/virtio_ring.h
include/standard-headers/linux/virtio_rng.h
include/standard-headers/linux/virtio_scsi.h
include/standard-headers/linux/virtio_types.h
include/sysemu/accel.h
include/sysemu/arch_init.h
include/sysemu/balloon.h
include/sysemu/block-backend.h
include/sysemu/blockdev.h
include/sysemu/bt.h
include/sysemu/char.h
include/sysemu/cpus.h
include/sysemu/dma.h
include/sysemu/dump-arch.h
include/sysemu/dump.h
include/sysemu/iothread.h
include/sysemu/memory_mapping.h
include/sysemu/os-posix.h
include/sysemu/os-win32.h
include/sysemu/qtest.h
include/sysemu/replay.h
include/sysemu/sysemu.h
include/sysemu/tpm.h
include/sysemu/tpm_backend.h
include/sysemu/tpm_backend_int.h
include/sysemu/watchdog.h
include/trace-tcg.h
include/trace.h
iohandler.c
iothread.c
libdecnumber/decContext.c
libdecnumber/decNumber.c
libdecnumber/dpd/decimal128.c
libdecnumber/dpd/decimal32.c
libdecnumber/dpd/decimal64.c
linux-headers/COPYING
linux-headers/README
linux-headers/asm-arm/kvm.h
linux-headers/asm-arm/kvm_para.h
linux-headers/asm-arm/unistd.h
linux-headers/asm-arm64/kvm.h
linux-headers/asm-arm64/kvm_para.h
linux-headers/asm-arm64/unistd.h
linux-headers/asm-generic/kvm_para.h
linux-headers/asm-mips/kvm.h
linux-headers/asm-mips/kvm_para.h
linux-headers/asm-mips/unistd.h
linux-headers/asm-powerpc/epapr_hcalls.h
linux-headers/asm-powerpc/kvm.h
linux-headers/asm-powerpc/kvm_para.h
linux-headers/asm-powerpc/unistd.h
linux-headers/asm-s390/kvm.h
linux-headers/asm-s390/kvm_para.h
linux-headers/asm-s390/unistd.h
linux-headers/asm-x86/hyperv.h
linux-headers/asm-x86/kvm.h
linux-headers/asm-x86/kvm_para.h
linux-headers/asm-x86/unistd.h
linux-headers/asm-x86/unistd_32.h
linux-headers/asm-x86/unistd_64.h
linux-headers/asm-x86/unistd_x32.h
linux-headers/linux/kvm.h
linux-headers/linux/kvm_para.h
linux-headers/linux/psci.h
linux-headers/linux/userfaultfd.h
linux-headers/linux/vfio.h
linux-headers/linux/vhost.h
linux-headers/linux/virtio_config.h
linux-headers/linux/virtio_ring.h
memory_mapping.c
module-common.c
os-posix.c
page_cache.c
pc-bios/Makefile
pc-bios/QEMU,cgthree.bin
pc-bios/QEMU,tcx.bin
pc-bios/README
pc-bios/acpi-dsdt.aml
pc-bios/bamboo.dtb
pc-bios/bamboo.dts
pc-bios/bios-256k.bin
pc-bios/bios.bin
pc-bios/efi-e1000.rom
pc-bios/efi-e1000e.rom
pc-bios/efi-eepro100.rom
pc-bios/efi-ne2k_pci.rom
pc-bios/efi-pcnet.rom
pc-bios/efi-rtl8139.rom
pc-bios/efi-virtio.rom
pc-bios/efi-vmxnet3.rom
pc-bios/keymaps/ar
pc-bios/keymaps/bepo
pc-bios/keymaps/common
pc-bios/keymaps/cz
pc-bios/keymaps/da
pc-bios/keymaps/de
pc-bios/keymaps/de-ch
pc-bios/keymaps/en-gb
pc-bios/keymaps/en-us
pc-bios/keymaps/es
pc-bios/keymaps/et
pc-bios/keymaps/fi
pc-bios/keymaps/fo
pc-bios/keymaps/fr
pc-bios/keymaps/fr-be
pc-bios/keymaps/fr-ca
pc-bios/keymaps/fr-ch
pc-bios/keymaps/hr
pc-bios/keymaps/hu
pc-bios/keymaps/is
pc-bios/keymaps/it
pc-bios/keymaps/ja
pc-bios/keymaps/lt
pc-bios/keymaps/lv
pc-bios/keymaps/mk
pc-bios/keymaps/modifiers
pc-bios/keymaps/nl
pc-bios/keymaps/nl-be
pc-bios/keymaps/no
pc-bios/keymaps/pl
pc-bios/keymaps/pt
pc-bios/keymaps/pt-br
pc-bios/keymaps/ru
pc-bios/keymaps/sl
pc-bios/keymaps/sv
pc-bios/keymaps/th
pc-bios/keymaps/tr
pc-bios/kvmvapic.bin
pc-bios/linuxboot.bin
pc-bios/linuxboot_dma.bin
pc-bios/multiboot.bin
pc-bios/openbios-ppc
pc-bios/openbios-sparc32
pc-bios/openbios-sparc64
pc-bios/optionrom/Makefile
pc-bios/optionrom/code16gcc.h
pc-bios/optionrom/flat.lds
pc-bios/optionrom/kvmvapic.S
pc-bios/optionrom/linuxboot.S
pc-bios/optionrom/linuxboot_dma.c
pc-bios/optionrom/multiboot.S
pc-bios/optionrom/optionrom.h
pc-bios/palcode-clipper
pc-bios/petalogix-ml605.dtb
pc-bios/petalogix-s3adsp1800.dtb
pc-bios/ppc_rom.bin
pc-bios/pxe-e1000.rom
pc-bios/pxe-eepro100.rom
pc-bios/pxe-ne2k_pci.rom
pc-bios/pxe-pcnet.rom
pc-bios/pxe-rtl8139.rom
pc-bios/pxe-virtio.rom
pc-bios/qemu-icon.bmp
pc-bios/qemu-nsis.bmp
pc-bios/qemu-nsis.ico
pc-bios/qemu.rsrc
pc-bios/qemu_logo.svg
pc-bios/qemu_logo_no_text.svg
pc-bios/s390-ccw.img
pc-bios/sgabios.bin
pc-bios/slof.bin
pc-bios/spapr-rtas.bin
pc-bios/u-boot.e500
pc-bios/vgabios-cirrus.bin
pc-bios/vgabios-qxl.bin
pc-bios/vgabios-stdvga.bin
pc-bios/vgabios-virtio.bin
pc-bios/vgabios-vmware.bin
pc-bios/vgabios.bin
pixman
po/Makefile
po/bg.po
po/de_DE.po
po/fr_FR.po
po/hu.po
po/it.po
po/messages.po
po/tr.po
po/zh_CN.po
qdev-monitor.c
qdict-test-data.txt
qemu-bridge-helper.c
qemu-doc.texi
qemu-ga.texi
qemu-nbd.texi
qemu-option-trace.texi
qemu-options-wrapper.h
qemu-options.h
qemu-options.hx
qemu-tech.texi
qemu.sasl
qom/cpu.c
qtest.c
replay/Makefile.objs
replay/replay-char.c
replay/replay-events.c
replay/replay-input.c
replay/replay-internal.c
replay/replay-internal.h
replay/replay-time.c
replay/replay.c
roms/Makefile
roms/SLOF
roms/config.seabios-128k
roms/config.seabios-256k
roms/config.vga-cirrus
roms/config.vga-isavga
roms/config.vga-qxl
roms/config.vga-stdvga
roms/config.vga-virtio
roms/config.vga-vmware
roms/configure-seabios.sh
roms/ipxe
roms/openbios
roms/openhackware
roms/qemu-palcode
roms/seabios
roms/sgabios
roms/u-boot
roms/vgabios
rules.mak
scripts/analyse-9p-simpletrace.py
scripts/analyze-inclusions
scripts/analyze-migration.py
scripts/check-qerror.sh
scripts/checkpatch.pl
scripts/clean-header-guards.pl
scripts/clean-includes
scripts/cleanup-trace-events.pl
scripts/cocci-macro-file.h
scripts/coccinelle/err-bad-newline.cocci
scripts/coccinelle/error_propagate_null.cocci
scripts/coccinelle/overflow_muldiv64.cocci
scripts/coccinelle/remove_local_err.cocci
scripts/coccinelle/remove_muldiv64.cocci
scripts/coccinelle/return_directly.cocci
scripts/coccinelle/round.cocci
scripts/coccinelle/simplify_muldiv64.cocci
scripts/coccinelle/swap_muldiv64.cocci
scripts/create_config
scripts/disas-objdump.pl
scripts/dump-guest-memory.py
scripts/extract-vsssdk-headers
scripts/feature_to_c.sh
scripts/get_maintainer.pl
scripts/gtester-cat
scripts/hxtool
scripts/kvm/kvm_flightrecorder
scripts/kvm/vmxcap
scripts/make-release
scripts/make_device_config.sh
scripts/ordereddict.py
scripts/qemu-binfmt-conf.sh
scripts/qemu-gdb.py
scripts/qemu-guest-agent/fsfreeze-hook
scripts/qemu-guest-agent/fsfreeze-hook.d/mysql-flush.sh.sample
scripts/qemu.py
scripts/qemugdb/__init__.py
scripts/qemugdb/aio.py
scripts/qemugdb/coroutine.py
scripts/qemugdb/mtree.py
scripts/qtest.py
scripts/refresh-pxe-roms.sh
scripts/shaderinclude.pl
scripts/signrom.py
scripts/simpletrace.py
scripts/switch-timer-api
scripts/texi2pod.pl
scripts/update-linux-headers.sh
spice-qemu-char.c
stubs/Makefile.objs
stubs/arch-query-cpu-def.c
stubs/bdrv-next-monitor-owned.c
stubs/blk-commit-all.c
stubs/blockdev-close-all-bdrv-states.c
stubs/clock-warp.c
stubs/cpu-get-clock.c
stubs/cpu-get-icount.c
stubs/cpus.c
stubs/dump.c
stubs/fd-register.c
stubs/fdset-add-fd.c
stubs/fdset-find-fd.c
stubs/fdset-get-fd.c
stubs/fdset-remove-fd.c
stubs/gdbstub.c
stubs/get-fd.c
stubs/get-next-serial.c
stubs/get-vm-name.c
stubs/iohandler.c
stubs/iothread-lock.c
stubs/ipmi.c
stubs/is-daemonized.c
stubs/machine-init-done.c
stubs/migr-blocker.c
stubs/mon-is-qmp.c
stubs/mon-printf.c
stubs/monitor-init.c
stubs/notify-event.c
stubs/pc_madt_cpu_entry.c
stubs/qmp_pc_dimm_device_list.c
stubs/qtest.c
stubs/replay-user.c
stubs/replay.c
stubs/reset.c
stubs/runstate-check.c
stubs/set-fd-handler.c
stubs/slirp.c
stubs/smbios_type_38.c
stubs/sysbus.c
stubs/target-get-monitor-def.c
stubs/target-monitor-defs.c
stubs/trace-control.c
stubs/uuid.c
stubs/vhost.c
stubs/vm-stop.c
stubs/vmstate.c
target-m68k/Makefile.objs
target-m68k/cpu-qom.h
target-m68k/cpu.c
target-m68k/cpu.h
target-m68k/gdbstub.c
target-m68k/helper.c
target-m68k/helper.h
target-m68k/m68k-semi.c
target-m68k/op_helper.c
target-m68k/qregs.def
target-m68k/translate.c
target-tilegx/Makefile.objs
target-tilegx/cpu.c
target-tilegx/cpu.h
target-tilegx/helper.c
target-tilegx/helper.h
target-tilegx/opcode_tilegx.h
target-tilegx/simd_helper.c
target-tilegx/spr_def_64.h
target-tilegx/translate.c
tcg-runtime.c
tests/.gitignore
tests/Makefile.include
tests/acpi-test-data/pc/APIC
tests/acpi-test-data/pc/APIC.cphp
tests/acpi-test-data/pc/DSDT
tests/acpi-test-data/pc/DSDT.bridge
tests/acpi-test-data/pc/DSDT.cphp
tests/acpi-test-data/pc/DSDT.ipmikcs
tests/acpi-test-data/pc/FACP
tests/acpi-test-data/pc/FACS
tests/acpi-test-data/pc/HPET
tests/acpi-test-data/q35/APIC
tests/acpi-test-data/q35/APIC.cphp
tests/acpi-test-data/q35/DSDT
tests/acpi-test-data/q35/DSDT.bridge
tests/acpi-test-data/q35/DSDT.cphp
tests/acpi-test-data/q35/DSDT.ipmibt
tests/acpi-test-data/q35/FACP
tests/acpi-test-data/q35/FACS
tests/acpi-test-data/q35/HPET
tests/acpi-test-data/q35/MCFG
tests/acpi-test-data/rebuild-expected-aml.sh
tests/bios-tables-test.c
tests/boot-order-test.c
tests/boot-sector.c
tests/boot-sector.h
tests/check-block.sh
tests/check-qnull.c
tests/crypto-tls-x509-helpers.c
tests/crypto-tls-x509-helpers.h
tests/data/test-qga-config
tests/device-introspect-test.c
tests/display-vga-test.c
tests/drive_del-test.c
tests/ds1338-test.c
tests/e1000-test.c
tests/e1000e-test.c
tests/eepro100-test.c
tests/endianness-test.c
tests/fw_cfg-test.c
tests/guest-debug/test-gdbstub.py
tests/hd-geo-test.c
tests/i440fx-test.c
tests/i82801b11-test.c
tests/io-channel-helpers.c
tests/io-channel-helpers.h
tests/ioh3420-test.c
tests/ipmi-bt-test.c
tests/ipmi-kcs-test.c
tests/ipoctal232-test.c
tests/ivshmem-test.c
tests/libqos/fw_cfg.c
tests/libqos/fw_cfg.h
tests/libqos/i2c-imx.c
tests/libqos/i2c-omap.c
tests/libqos/i2c.c
tests/libqos/i2c.h
tests/libqos/libqos-pc.c
tests/libqos/libqos-pc.h
tests/libqos/libqos.c
tests/libqos/libqos.h
tests/libqos/malloc-generic.c
tests/libqos/malloc-generic.h
tests/libqos/malloc-pc.c
tests/libqos/malloc-pc.h
tests/libqos/malloc.c
tests/libqos/malloc.h
tests/libqos/pci-pc.c
tests/libqos/pci-pc.h
tests/libqos/pci.c
tests/libqos/pci.h
tests/libqos/usb.c
tests/libqos/usb.h
tests/libqos/virtio-mmio.c
tests/libqos/virtio-mmio.h
tests/libqos/virtio-pci.c
tests/libqos/virtio-pci.h
tests/libqos/virtio.c
tests/libqos/virtio.h
tests/libqtest.c
tests/libqtest.h
tests/m48t59-test.c
tests/migration/.gitignore
tests/migration/guestperf-batch.py
tests/migration/guestperf-plot.py
tests/migration/guestperf.py
tests/migration/guestperf/__init__.py
tests/migration/guestperf/comparison.py
tests/migration/guestperf/engine.py
tests/migration/guestperf/hardware.py
tests/migration/guestperf/plot.py
tests/migration/guestperf/progress.py
tests/migration/guestperf/report.py
tests/migration/guestperf/scenario.py
tests/migration/guestperf/shell.py
tests/migration/guestperf/timings.py
tests/migration/stress.c
tests/multiboot/Makefile
tests/multiboot/libc.c
tests/multiboot/libc.h
tests/multiboot/link.ld
tests/multiboot/mmap.c
tests/multiboot/mmap.out
tests/multiboot/module.txt
tests/multiboot/modules.c
tests/multiboot/modules.out
tests/multiboot/multiboot.h
tests/multiboot/run_test.sh
tests/multiboot/start.S
tests/ne2000-test.c
tests/pc-cpu-test.c
tests/pcnet-test.c
tests/pkix_asn1_tab.c
tests/postcopy-test.c
tests/prom-env-test.c
tests/pvpanic-test.c
tests/pxe-test.c
tests/q35-test.c
tests/qemu-iotests-quick.sh
tests/qht-bench.c
tests/rcutorture.c
tests/rocker/README
tests/rocker/all
tests/rocker/bridge
tests/rocker/bridge-stp
tests/rocker/bridge-vlan
tests/rocker/bridge-vlan-stp
tests/rocker/port
tests/rocker/tut.dot
tests/rtc-test.c
tests/rtl8139-test.c
tests/spapr-phb-test.c
tests/tcg/Makefile
tests/tcg/hello-arm.c
tests/tcg/hello-i386.c
tests/tcg/hello-mips.c
tests/tcg/linux-test.c
tests/tcg/pi_10.com
tests/tcg/runcom.c
tests/tcg/sha1.c
tests/tcg/test-arm-iwmmxt.s
tests/tcg/test-i386-code16.S
tests/tcg/test-i386-fprem.c
tests/tcg/test-i386-muldiv.h
tests/tcg/test-i386-shift.h
tests/tcg/test-i386-ssse3.c
tests/tcg/test-i386-vm86.S
tests/tcg/test-i386.c
tests/tcg/test-i386.h
tests/tcg/test-mmap.c
tests/tcg/test_path.c
tests/tcg/testthread.c
tests/tco-test.c
tests/test-aio.c
tests/test-base64.c
tests/test-bitops.c
tests/test-blockjob-txn.c
tests/test-blockjob.c
tests/test-cutils.c
tests/test-filter-mirror.c
tests/test-filter-redirector.c
tests/test-hbitmap.c
tests/test-int128.c
tests/test-iov.c
tests/test-logging.c
tests/test-mul64.c
tests/test-netfilter.c
tests/test-qdev-global-props.c
tests/test-qdist.c
tests/test-qemu-opts.c
tests/test-qga.c
tests/test-qht-par.c
tests/test-qht.c
tests/test-rcu-list.c
tests/test-rfifolock.c
tests/test-thread-pool.c
tests/test-throttle.c
tests/test-timed-average.c
tests/test-visitor-serialization.c
tests/test-vmstate.c
tests/test-write-threshold.c
tests/test-x86-cpuid.c
tests/test-xbzrle.c
tests/tmp105-test.c
tests/tpci200-test.c
tests/vhost-user-bridge.c
tests/vhost-user-test.c
tests/virtio-balloon-test.c
tests/virtio-blk-test.c
tests/virtio-console-test.c
tests/virtio-net-test.c
tests/virtio-rng-test.c
tests/virtio-scsi-test.c
tests/virtio-serial-test.c
tests/vmxnet3-test.c
tests/wdt_ib700-test.c
thread-pool.c
tpm.c
trace-events
util/Makefile.objs
util/acl.c
util/base64.c
util/bitmap.c
util/bitops.c
util/compatfd.c
util/crc32c.c
util/cutils.c
util/envlist.c
util/event_notifier-posix.c
util/event_notifier-win32.c
util/fifo8.c
util/getauxval.c
util/hbitmap.c
util/hexdump.c
util/host-utils.c
util/id.c
util/iov.c
util/log.c
util/memfd.c
util/mmap-alloc.c
util/module.c
util/notify.c
util/osdep.c
util/oslib-posix.c
util/oslib-win32.c
util/path.c
util/qdist.c
util/qemu-config.c
util/qemu-openpty.c
util/qemu-option.c
util/qemu-progress.c
util/qemu-thread-posix.c
util/qemu-thread-win32.c
util/qemu-timer-common.c
util/qht.c
util/range.c
util/rcu.c
util/readline.c
util/rfifolock.c
util/timed-average.c
util/trace-events
util/unicode.c
util/uri.c
version.rc
^ permalink raw reply [flat|nested] 55+ messages in thread
* Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered
2016-08-30 11:31 ` Markus Armbruster
@ 2016-08-30 12:26 ` Cornelia Huck
2016-08-30 12:40 ` Paolo Bonzini
2016-08-30 12:48 ` Paolo Bonzini
` (4 subsequent siblings)
5 siblings, 1 reply; 55+ messages in thread
From: Cornelia Huck @ 2016-08-30 12:26 UTC (permalink / raw)
To: Markus Armbruster; +Cc: qemu-devel
On Tue, 30 Aug 2016 13:31:12 +0200
Markus Armbruster <armbru@redhat.com> wrote:
> >> Full list of unmaintained files now:
(...)
> include/standard-headers/asm-s390/kvm_virtio.h
> include/standard-headers/asm-s390/virtio-ccw.h
> include/standard-headers/asm-x86/hyperv.h
> include/standard-headers/linux/if_ether.h
> include/standard-headers/linux/input-event-codes.h
> include/standard-headers/linux/input.h
> include/standard-headers/linux/pci_regs.h
> include/standard-headers/linux/types.h
> include/standard-headers/linux/virtio_9p.h
> include/standard-headers/linux/virtio_balloon.h
> include/standard-headers/linux/virtio_blk.h
> include/standard-headers/linux/virtio_config.h
> include/standard-headers/linux/virtio_console.h
> include/standard-headers/linux/virtio_gpu.h
> include/standard-headers/linux/virtio_ids.h
> include/standard-headers/linux/virtio_input.h
> include/standard-headers/linux/virtio_net.h
> include/standard-headers/linux/virtio_pci.h
> include/standard-headers/linux/virtio_ring.h
> include/standard-headers/linux/virtio_rng.h
> include/standard-headers/linux/virtio_scsi.h
> include/standard-headers/linux/virtio_types.h
I don't think standard-headers can really be 'maintained', as they are
essentially imported by a script. And while there's a certain overlap,
the maintainer of a Linux header file is not neccessarily a qemu
developer.
(...)
> linux-headers/COPYING
> linux-headers/README
> linux-headers/asm-arm/kvm.h
> linux-headers/asm-arm/kvm_para.h
> linux-headers/asm-arm/unistd.h
> linux-headers/asm-arm64/kvm.h
> linux-headers/asm-arm64/kvm_para.h
> linux-headers/asm-arm64/unistd.h
> linux-headers/asm-generic/kvm_para.h
> linux-headers/asm-mips/kvm.h
> linux-headers/asm-mips/kvm_para.h
> linux-headers/asm-mips/unistd.h
> linux-headers/asm-powerpc/epapr_hcalls.h
> linux-headers/asm-powerpc/kvm.h
> linux-headers/asm-powerpc/kvm_para.h
> linux-headers/asm-powerpc/unistd.h
> linux-headers/asm-s390/kvm.h
> linux-headers/asm-s390/kvm_para.h
> linux-headers/asm-s390/unistd.h
> linux-headers/asm-x86/hyperv.h
> linux-headers/asm-x86/kvm.h
> linux-headers/asm-x86/kvm_para.h
> linux-headers/asm-x86/unistd.h
> linux-headers/asm-x86/unistd_32.h
> linux-headers/asm-x86/unistd_64.h
> linux-headers/asm-x86/unistd_x32.h
> linux-headers/linux/kvm.h
> linux-headers/linux/kvm_para.h
> linux-headers/linux/psci.h
> linux-headers/linux/userfaultfd.h
> linux-headers/linux/vfio.h
> linux-headers/linux/vhost.h
> linux-headers/linux/virtio_config.h
> linux-headers/linux/virtio_ring.h
Same goes for linux-headers. We don't even touch those (beyond the
massaging done by the import script).
Maybe we could make get_maintainers.pl point at the maintainer for
the import script for these headers? Or is there something more
clever we could do?
^ permalink raw reply [flat|nested] 55+ messages in thread
* Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered
2016-08-30 12:26 ` Cornelia Huck
@ 2016-08-30 12:40 ` Paolo Bonzini
2016-08-30 13:29 ` Cornelia Huck
0 siblings, 1 reply; 55+ messages in thread
From: Paolo Bonzini @ 2016-08-30 12:40 UTC (permalink / raw)
To: Cornelia Huck, Markus Armbruster; +Cc: qemu-devel
On 30/08/2016 14:26, Cornelia Huck wrote:
> Same goes for linux-headers. We don't even touch those (beyond the
> massaging done by the import script).
>
> Maybe we could make get_maintainers.pl point at the maintainer for
> the import script for these headers? Or is there something more
> clever we could do?
We need a "maintainer" for imported headers and then MAINTAINERS can do
F: scripts/update-linux-headers.sh
F: linux-headers/
F: includes/standard-headers/
Paolo
^ permalink raw reply [flat|nested] 55+ messages in thread
* Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered
2016-08-30 11:31 ` Markus Armbruster
2016-08-30 12:26 ` Cornelia Huck
@ 2016-08-30 12:48 ` Paolo Bonzini
2016-08-30 12:57 ` Peter Maydell
2016-08-30 14:47 ` Paolo Bonzini
2016-08-30 13:39 ` Cornelia Huck
` (3 subsequent siblings)
5 siblings, 2 replies; 55+ messages in thread
From: Paolo Bonzini @ 2016-08-30 12:48 UTC (permalink / raw)
To: Markus Armbruster, qemu-devel
On 30/08/2016 13:31, Markus Armbruster wrote:
> $ for i in `git-ls-files`; do [ "`scripts/get_maintainer.pl -f --no-git-fallback $i | grep -v '^qemu-devel@nongnu\.org'`" ] || echo $i; done >unmaintained-files
> $ grep -c '\.c$' unmaintained-files
> 402
>
> 402 out of 2132 (19%). More progress, but not yet there.
Not bad.
> $ git-diff --diff-filter=A --name-only 6138fbd | grep -c '\.c$'
> 215
> $ git-diff --diff-filter=A --name-only 6138fbd | grep '\.c$' | join unmaintained-files - | wc -l
> 86
>
> This time, it's 86 out of 215 (40%). Getting worse. I'll cook up a
> patch to make checkpatch.pl catch such additions.
Good idea.
>>>> Apparently, nobody cares for tests:
>>>>
>>>> $ grep '^tests/' unmaintained-files | grep -c '\.c$'
>>>> 654
>>>> $ git-ls-files | grep '^tests/' | grep -c '\.c$'
>>>> 664
>>>
>>> Now 91 out of 665.
>>
>> 105 out of 687.
>
> 114 out of 726.
I think this is expected to some extent. Is it worth moving tests to
many tests subdirectories, e.g. hw/scsi/tests? Many files would be
covered automatically.
> Active subsystems lacking a maintainer include tilegx, qdev, replay.
You, Eduardo, me?
> Headers that should probably be covered by existing MAINTAINERS stanzas
> include include/sysemu/block-backend.h include/qom/cpu.h
> include/hw/arm/xlnx-zynqmp.h.
Also:
hw/intc/gic* (ARM)
hw/*/mips* (MIPS)
hw/*/slavio* (SPARC)
libdecnumber/ (target-ppc/)
etc.
Any kind soul that converts the Coverity components into MAINTAINERS
patches?
Paolo
^ permalink raw reply [flat|nested] 55+ messages in thread
* Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered
2016-08-30 12:48 ` Paolo Bonzini
@ 2016-08-30 12:57 ` Peter Maydell
2016-08-30 18:31 ` John Snow
2016-08-30 14:47 ` Paolo Bonzini
1 sibling, 1 reply; 55+ messages in thread
From: Peter Maydell @ 2016-08-30 12:57 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: Markus Armbruster, qemu-devel
On 30 August 2016 at 13:48, Paolo Bonzini <pbonzini@redhat.com> wrote:
> I think this is expected to some extent. Is it worth moving tests to
> many tests subdirectories, e.g. hw/scsi/tests? Many files would be
> covered automatically.
Moving tests around in order to increase MAINTAINERS coverage
seems to me to be putting the cart before the horse. I think
the tests are fine where they are.
thanks
-- PMM
^ permalink raw reply [flat|nested] 55+ messages in thread
* Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered
2016-08-30 12:40 ` Paolo Bonzini
@ 2016-08-30 13:29 ` Cornelia Huck
0 siblings, 0 replies; 55+ messages in thread
From: Cornelia Huck @ 2016-08-30 13:29 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: Markus Armbruster, qemu-devel
On Tue, 30 Aug 2016 14:40:05 +0200
Paolo Bonzini <pbonzini@redhat.com> wrote:
> On 30/08/2016 14:26, Cornelia Huck wrote:
> > Same goes for linux-headers. We don't even touch those (beyond the
> > massaging done by the import script).
> >
> > Maybe we could make get_maintainers.pl point at the maintainer for
> > the import script for these headers? Or is there something more
> > clever we could do?
>
> We need a "maintainer" for imported headers and then MAINTAINERS can do
>
> F: scripts/update-linux-headers.sh
> F: linux-headers/
> F: includes/standard-headers/
Sounds reasonable. As I have stared at that script before, I can do
that unless someone else wants to take it.
^ permalink raw reply [flat|nested] 55+ messages in thread
* Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered
2016-08-30 11:31 ` Markus Armbruster
2016-08-30 12:26 ` Cornelia Huck
2016-08-30 12:48 ` Paolo Bonzini
@ 2016-08-30 13:39 ` Cornelia Huck
2016-09-12 13:56 ` Thomas Huth
` (2 subsequent siblings)
5 siblings, 0 replies; 55+ messages in thread
From: Cornelia Huck @ 2016-08-30 13:39 UTC (permalink / raw)
To: Markus Armbruster; +Cc: qemu-devel
On Tue, 30 Aug 2016 13:31:12 +0200
Markus Armbruster <armbru@redhat.com> wrote:
> >> Full list of unmaintained files now:
> docs/virtio-migration.txt
I wrote this so I guess I could maintain it; but it should probably go
with the other core virtio stuff?
> default-configs/s390x-softmmu.mak
> include/hw/watchdog/wdt_diag288.h
> pc-bios/s390-ccw.img
These can go with the s390 virtio-ccw machine.
^ permalink raw reply [flat|nested] 55+ messages in thread
* Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered
2016-08-30 12:48 ` Paolo Bonzini
2016-08-30 12:57 ` Peter Maydell
@ 2016-08-30 14:47 ` Paolo Bonzini
2016-08-30 15:29 ` Markus Armbruster
1 sibling, 1 reply; 55+ messages in thread
From: Paolo Bonzini @ 2016-08-30 14:47 UTC (permalink / raw)
To: Markus Armbruster, qemu-devel
On 30/08/2016 14:48, Paolo Bonzini wrote:
> > Active subsystems lacking a maintainer include tilegx, qdev, replay.
>
> You, Eduardo, me?
FWIW I was referring to qdev.
As to replay, it is mostly by Pavel but the remaining changes would need
review by the relevant maintainers (e.g. USB for USB replay) so it's
best left unmaintained.
Paolo
^ permalink raw reply [flat|nested] 55+ messages in thread
* Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered
2016-08-30 14:47 ` Paolo Bonzini
@ 2016-08-30 15:29 ` Markus Armbruster
2016-08-30 15:33 ` Paolo Bonzini
0 siblings, 1 reply; 55+ messages in thread
From: Markus Armbruster @ 2016-08-30 15:29 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: qemu-devel
Paolo Bonzini <pbonzini@redhat.com> writes:
> On 30/08/2016 14:48, Paolo Bonzini wrote:
>> > Active subsystems lacking a maintainer include tilegx, qdev, replay.
>>
>> You, Eduardo, me?
>
> FWIW I was referring to qdev.
Jointly?
[...]
^ permalink raw reply [flat|nested] 55+ messages in thread
* Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered
2016-08-30 15:29 ` Markus Armbruster
@ 2016-08-30 15:33 ` Paolo Bonzini
2016-08-31 8:28 ` Markus Armbruster
0 siblings, 1 reply; 55+ messages in thread
From: Paolo Bonzini @ 2016-08-30 15:33 UTC (permalink / raw)
To: Markus Armbruster; +Cc: qemu-devel
On 30/08/2016 17:29, Markus Armbruster wrote:
> > > > Active subsystems lacking a maintainer include tilegx, qdev, replay.
> > >
> > > You, Eduardo, me?
> >
> > FWIW I was referring to qdev.
>
> Jointly?
A subset not including me would also be fine. But since the git
fallback still exists, and the code is _obviously_ maintained, I don't
think there is a particular hurry to add new people to the list.
Maintainers are most useful when there are a lot of simple patches, not
when each patch's design must be discussed in the community.
Paolo
^ permalink raw reply [flat|nested] 55+ messages in thread
* Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered
2016-08-30 12:57 ` Peter Maydell
@ 2016-08-30 18:31 ` John Snow
0 siblings, 0 replies; 55+ messages in thread
From: John Snow @ 2016-08-30 18:31 UTC (permalink / raw)
To: Peter Maydell, Paolo Bonzini; +Cc: Markus Armbruster, qemu-devel
On 08/30/2016 08:57 AM, Peter Maydell wrote:
> On 30 August 2016 at 13:48, Paolo Bonzini <pbonzini@redhat.com> wrote:
>> I think this is expected to some extent. Is it worth moving tests to
>> many tests subdirectories, e.g. hw/scsi/tests? Many files would be
>> covered automatically.
>
> Moving tests around in order to increase MAINTAINERS coverage
> seems to me to be putting the cart before the horse. I think
> the tests are fine where they are.
>
In this case, it's not like we'll ever have a generic tests maintainer.
Putting tests in with their subsystems makes some organizational sense.
(Maybe it makes the Makefile and test suite a lot uglier, though.)
It's a minor thing for now anyway. First order of business is the
checkpatch script that squawks about new unmaintained files.
--js
> thanks
> -- PMM
>
^ permalink raw reply [flat|nested] 55+ messages in thread
* Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered
2016-08-30 15:33 ` Paolo Bonzini
@ 2016-08-31 8:28 ` Markus Armbruster
0 siblings, 0 replies; 55+ messages in thread
From: Markus Armbruster @ 2016-08-31 8:28 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: qemu-devel
I really shouldn't reply to this, because more maintainer duties is
about the last thing I need, but here goes anyway:
Paolo Bonzini <pbonzini@redhat.com> writes:
> On 30/08/2016 17:29, Markus Armbruster wrote:
>> > > > Active subsystems lacking a maintainer include tilegx, qdev, replay.
>> > >
>> > > You, Eduardo, me?
>> >
>> > FWIW I was referring to qdev.
>>
>> Jointly?
>
> A subset not including me would also be fine. But since the git
> fallback still exists, and the code is _obviously_ maintained, I don't
> think there is a particular hurry to add new people to the list.
> Maintainers are most useful when there are a lot of simple patches, not
> when each patch's design must be discussed in the community.
Even then, having someone "own" the discussion is useful: make sure it
happens, and stays on track.
Moreover, not *all* qdev patches need wider discussion. You're doing a
good job picking up such patches to "unmaintained" code. Still, having
less "unmaintained" code can only make that job easier.
Last but not least,
$ scripts/get_maintainer.pl -f hw/core/qdev.c
get_maintainer.pl: No maintainers found, printing recent contributors.
get_maintainer.pl: Do not blindly cc: them on patches! Use common sense.
Markus Armbruster <armbru@redhat.com> (commit_signer:4/12=33%)
David Gibson <david@gibson.dropbear.id.au> (commit_signer:4/12=33%)
Eric Blake <eblake@redhat.com> (commit_signer:3/12=25%)
Igor Mammedov <imammedo@redhat.com> (commit_signer:2/12=17%)
"Andreas Färber" <afaerber@suse.de> (commit_signer:2/12=17%)
qemu-devel@nongnu.org (open list:All patches CC here)
must look scary for contributors who don't know that qdev "is
_obviously_ maintained".
^ permalink raw reply [flat|nested] 55+ messages in thread
* Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered
2016-08-30 11:31 ` Markus Armbruster
` (2 preceding siblings ...)
2016-08-30 13:39 ` Cornelia Huck
@ 2016-09-12 13:56 ` Thomas Huth
2016-09-23 12:56 ` Thomas Huth
2018-11-21 18:14 ` Markus Armbruster
5 siblings, 0 replies; 55+ messages in thread
From: Thomas Huth @ 2016-09-12 13:56 UTC (permalink / raw)
To: Markus Armbruster, qemu-devel, Pavel Dovgalyuk
On 30.08.2016 13:31, Markus Armbruster wrote:
> Markus Armbruster <armbru@redhat.com> writes:
>
>> Paolo asked for an update.
>
> Another update; HEAD is commit e00da55.
[...]
>>> Full list of unmaintained files now:
[...]
> default-configs/aarch64-linux-user.mak
> default-configs/aarch64-softmmu.mak
> default-configs/alpha-linux-user.mak
> default-configs/alpha-softmmu.mak
> default-configs/arm-linux-user.mak
> default-configs/arm-softmmu.mak
> default-configs/armeb-linux-user.mak
> default-configs/cris-linux-user.mak
> default-configs/cris-softmmu.mak
> default-configs/i386-bsd-user.mak
> default-configs/i386-linux-user.mak
> default-configs/i386-softmmu.mak
> default-configs/lm32-softmmu.mak
> default-configs/m68k-linux-user.mak
> default-configs/m68k-softmmu.mak
> default-configs/microblaze-linux-user.mak
> default-configs/microblaze-softmmu.mak
> default-configs/microblazeel-linux-user.mak
> default-configs/microblazeel-softmmu.mak
> default-configs/mips-linux-user.mak
> default-configs/mips-softmmu-common.mak
> default-configs/mips-softmmu.mak
> default-configs/mips64-linux-user.mak
> default-configs/mips64-softmmu.mak
> default-configs/mips64el-linux-user.mak
> default-configs/mips64el-softmmu.mak
> default-configs/mipsel-linux-user.mak
> default-configs/mipsel-softmmu.mak
> default-configs/mipsn32-linux-user.mak
> default-configs/mipsn32el-linux-user.mak
> default-configs/moxie-softmmu.mak
> default-configs/or32-linux-user.mak
> default-configs/or32-softmmu.mak
> default-configs/pci.mak
> default-configs/ppc-linux-user.mak
> default-configs/ppc-softmmu.mak
> default-configs/ppc64-linux-user.mak
> default-configs/ppc64-softmmu.mak
> default-configs/ppc64abi32-linux-user.mak
> default-configs/ppc64le-linux-user.mak
> default-configs/ppcemb-softmmu.mak
> default-configs/s390x-linux-user.mak
> default-configs/s390x-softmmu.mak
> default-configs/sh4-linux-user.mak
> default-configs/sh4-softmmu.mak
> default-configs/sh4eb-linux-user.mak
> default-configs/sh4eb-softmmu.mak
> default-configs/sound.mak
> default-configs/sparc-bsd-user.mak
> default-configs/sparc-linux-user.mak
> default-configs/sparc-softmmu.mak
> default-configs/sparc32plus-linux-user.mak
> default-configs/sparc64-bsd-user.mak
> default-configs/sparc64-linux-user.mak
> default-configs/sparc64-softmmu.mak
> default-configs/tilegx-linux-user.mak
> default-configs/tricore-softmmu.mak
> default-configs/unicore32-linux-user.mak
> default-configs/unicore32-softmmu.mak
> default-configs/usb.mak
> default-configs/x86_64-bsd-user.mak
> default-configs/x86_64-linux-user.mak
> default-configs/x86_64-softmmu.mak
> default-configs/xtensa-softmmu.mak
> default-configs/xtensaeb-softmmu.mak
Any ideas how to put the default-configs into the MAINTAINERS file? Most
of them neither really belong to a certain machine, nor to a certain
CPU, but rather to both ... i.e. should there be an entry in both sections?
[...]
> po/bg.po
> po/de_DE.po
> po/fr_FR.po
> po/hu.po
> po/it.po
> po/messages.po
> po/tr.po
> po/zh_CN.po
I think the po files have kind of a maintainer - the person who's listed
in the "Last-Translator:" section of the header there. Maybe we
could/should teach get_maintainer.pl to look at that header?
> replay/Makefile.objs
> replay/replay-char.c
> replay/replay-events.c
> replay/replay-input.c
> replay/replay-internal.c
> replay/replay-internal.h
> replay/replay-time.c
> replay/replay.c
Maybe Pavel Dovgalyuk could maintain those?
Thomas
^ permalink raw reply [flat|nested] 55+ messages in thread
* Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered
2016-08-30 11:31 ` Markus Armbruster
` (3 preceding siblings ...)
2016-09-12 13:56 ` Thomas Huth
@ 2016-09-23 12:56 ` Thomas Huth
2016-09-23 14:47 ` Thomas Huth
2018-11-21 18:14 ` Markus Armbruster
5 siblings, 1 reply; 55+ messages in thread
From: Thomas Huth @ 2016-09-23 12:56 UTC (permalink / raw)
To: Markus Armbruster, qemu-devel; +Cc: Alexander Graf
On 30.08.2016 13:31, Markus Armbruster wrote:
[...]
>>>> Ideas? Takers?
>>>
>>> Full list of unmaintained files now:
[...]
> hw/misc/applesmc.c
Is this file used at all anymore? I can't see any code that instantiates
this device ... so maybe that's a good candidate for clean-up, unless
somebody volunteers for maintaining this device?
Thomas
^ permalink raw reply [flat|nested] 55+ messages in thread
* Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered
2016-09-23 12:56 ` Thomas Huth
@ 2016-09-23 14:47 ` Thomas Huth
0 siblings, 0 replies; 55+ messages in thread
From: Thomas Huth @ 2016-09-23 14:47 UTC (permalink / raw)
To: Markus Armbruster, qemu-devel; +Cc: Alexander Graf
On 23.09.2016 14:56, Thomas Huth wrote:
> On 30.08.2016 13:31, Markus Armbruster wrote:
> [...]
>>>>> Ideas? Takers?
>>>>
>>>> Full list of unmaintained files now:
> [...]
>> hw/misc/applesmc.c
>
> Is this file used at all anymore? I can't see any code that instantiates
> this device ... so maybe that's a good candidate for clean-up, unless
> somebody volunteers for maintaining this device?
Ok, never mind, looks like you need to instantiate this device manually
if you want to run OS X on QEMU. So it's still needed, I guess.
Thomas
^ permalink raw reply [flat|nested] 55+ messages in thread
* Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered
2016-08-30 11:31 ` Markus Armbruster
` (4 preceding siblings ...)
2016-09-23 12:56 ` Thomas Huth
@ 2018-11-21 18:14 ` Markus Armbruster
2018-11-22 12:22 ` Thomas Huth
5 siblings, 1 reply; 55+ messages in thread
From: Markus Armbruster @ 2018-11-21 18:14 UTC (permalink / raw)
To: qemu-devel
Time for another update. My HEAD is at v3.1.0-rc2.
Markus Armbruster <armbru@redhat.com> writes:
> Markus Armbruster <armbru@redhat.com> writes:
>
>> Paolo asked for an update.
>
> Another update; HEAD is commit e00da55.
A.k.a. v2.7.0-rc5~7.
>> Markus Armbruster <armbru@redhat.com> writes:
>>
>>> Markus Armbruster <armbru@redhat.com> writes:
>>>
>>>> In my experience, too many files are not covered by MAINTAINERS.
>>>> scripts/get_maintainer.pl falls back to git then, unless you say
>>>> --no-git-fallback. Copies sent there tends to annoy their recipients
>>>> without accomplishing all that much.
>>>>
>>>> Two obvious improvements:
>>>>
>>>> * Easy: Flip scripts/get_maintainer.pl's default to --no-git-fallback.
>>>> I'll post the obvious patch, please raise your objections there.
We actually went with Paolo's commit c6561586f0f "get_maintainer.pl:
restrict cases where it falls back to --git". Later modified by commit
4db84796e75 "get_maintainer.pl: fall back to git if only lists are
found".
>>>> * Harder: improve MAINTAINERS coverage.
>>>
>>> A few folks have started doing that. Much appreciated!
>>>
>>> I collected recent patches to MAINTAINERS, and reran my analysis.
>>>
>>>> Let me back up subjective experience with hard data. The tree has quite
>>>> a few files:
>>>>
>>>> $ git-ls-files | wc -l
>>>> 3746
>>>
>>> Now 3752.
>>
>> Eleven months later, this is 4387.
>
> Another eleven months later, it's 4921.
27 months later, it's 6461. 2633 end in .c.
>>>> Counting them by extension:
>>>>
>>>> $ git-ls-files | sed -n 's#.*/##;s#.*\.##p' | sort | uniq -c | sort -nr
>>>> 1836 c
>>>> 818 h
>>>> 133 out
>>>> 105 S
>>>> 97 objs
>>>> 69 s
>>>> 64 mak
>>>> 48 json
>>>> 47 py
>>>> 41 txt
>>>> 33 exit
>>>> 33 err
>>>> 16 xml
>>>> 16 bin
>>>> 13 rom
>>>> 12 sh
>>>> 12 dsl
>>>> [Long tail that doesn't add up to anything interesting omitted]
>>>>
>>>> Let's look for .c not in MAINTAINERS:
>>>>
>>>> $ for i in `git-ls-files`; do [ "`scripts/get_maintainer.pl -f --no-git-fallback $i`" ] || echo $i; done >unmaintained-files
>>>> $ grep -c '\.c$' unmaintained-files
>>>> 1066
>>>>
>>>> That's almost 60%. Not good.
>>>
>>> Down to 491 our of 1841 (27%). Progress, but not quite enough.
>>
>> 461 out of 1945 (24%). At this linear rate, we'll reach 10%
>> unmaintained in five years.
>
> This is now
>
> $ for i in `git-ls-files`; do [ "`scripts/get_maintainer.pl -f --no-git-fallback $i | grep -v '^qemu-devel@nongnu\.org'`" ] || echo $i; done >unmaintained-files
> $ grep -c '\.c$' unmaintained-files
> 402
>
> 402 out of 2132 (19%). More progress, but not yet there.
armbru@dusky:~/work/qemu$ for i in `git-ls-files`; do [ "`scripts/get_maintainer.pl -f --no-git-fallback $i | grep -v '^qemu-devel@nongnu\.org'`" ] || echo $i; done >unmaintained-files
armbru@dusky:~/work/qemu$ grep -c '\.c$' unmaintained-files
259
259 out of 2633 (10%). Getting down to 10% took us "only" a bit over
three years instead of the projected five.
>> We're still adding unmaintained .c files:
>>
>> $ git-diff --diff-filter=A --name-only e668d1b | grep -c '\.c$'
>> 116
>> $ git-diff --diff-filter=A --name-only e668d1b | grep '\.c$' | join unmaintained-files - | wc -l
>> 37
>>
>> 37 out of 116 new files (32%) are not covered. That's worse than we do
>> for old files. Inexcusable.
>
> $ git-diff --diff-filter=A --name-only 6138fbd | grep -c '\.c$'
> 215
> $ git-diff --diff-filter=A --name-only 6138fbd | grep '\.c$' | join unmaintained-files - | wc -l
> 86
>
> This time, it's 86 out of 215 (40%). Getting worse. I'll cook up a
> patch to make checkpatch.pl catch such additions.
We eventually took Joe Perches's commit 4be6131e329 "checkpatch: emit a
warning on file add/move".
$ git-diff --diff-filter=A --name-only e00da55 | grep -c '\.c$'
574
$ git-diff --diff-filter=A --name-only e00da55 | grep '\.c$' | join unmaintained-files - | wc -l
68
68 out of 574 new .c files are unmaintained (12%). We've gotten better,
but still not good enough.
>>>> Apparently, nobody cares for tests:
>>>>
>>>> $ grep '^tests/' unmaintained-files | grep -c '\.c$'
>>>> 654
>>>> $ git-ls-files | grep '^tests/' | grep -c '\.c$'
>>>> 664
>>>
>>> Now 91 out of 665.
>>
>> 105 out of 687.
>
> 114 out of 726.
59 out of 794.
>>>> Filtering those out leaves us with 412 unmaintained out of of 1172, or
>>>> 35% unmaintained. Not good even if we (foolishly!) considered tests not
>>>> worthy of maintenance.
>>>>
>>>> Maybe unmaintained files are much smaller. David A. Wheeler's
>>>> SLOCCount counts 570kSLOC in 1212 maintained files (+140 files sloccount
>>>> doesn't know how to count) vs. 300kSLOC in 1798 unmaintained files (+596
>>>> uncounted), or 35% unmaintained SLOC. With tests/ ignored, it's 30%.
>>>> So, unmaintained files are indeed smaller, but 30-something percent is
>>>> still not good.
>>>>
>>>> Where are the unmaintained files? Top-scoring directories outside
>>>> tests/ and include/, files in subdirs not counted:
>>>>
>>>> #files directory
>>>> 84 68% .
>>>> 63 100% default-configs
>>>> 48 100% pc-bios
>>>> 43 97% stubs
>>>> 39 100% util
>>>> 37 100% pc-bios/keymaps
>>>> 35 81% hw/display
>>>> 32 94% scripts
>>>> 26 92% docs
>>>> 26 100% libcacard
>>>> 23 69% hw/misc
>>>> 22 57% hw/net
>>>> 21 63% hw/intc
>>>> 19 100% roms
>>>> 18 100% disas
>>>> 18 56% hw/timer
>>>> 16 100% hw/core
>>>> 15 53% hw/char
>>>> 15 100% qga
>>>> 14 100% docs/specs
>>>> 12 92% hw/input
>>>> 12 100% qobject
>>>> 12 100% target-m68k
>>>> 11 100% backends
>>>> 11 100% pc-bios/s390-ccw
>>>> 10 71% hw/dma
>>
>> Different tack: what are the unmaintained files we actually change?
>>
>> Unmaintained files sorted by number of commits in the past year (commit
>> 1733681):
>>
>> $ for i in `cat unmaintained-files`; do echo -n "$i "; git-rev-list 1733681.. $i | wc -l; done | awk '{ printf "%7d %s\n", $2, $1 }' | sort -rn | head -n 100
>> 79 trace-events
>> 77 MAINTAINERS
>> 74 tests/Makefile
>> 37 hw/core/qdev.c
>> 35 arch_init.c
>> 33 tests/libqos/ahci.c
>> 30 tests/libqos/ahci.h
>> 27 qdev-monitor.c
>> 27 include/hw/boards.h
>> 27 Makefile
>> 26 include/exec/exec-all.h
>> 25 include/hw/virtio/virtio.h
>> 24 hw/xen/xen_pt_config_init.c
>> 23 include/hw/virtio/virtio-scsi.h
>> 22 util/qemu-option.c
>> 22 hw/net/rtl8139.c
>> 22 hw/intc/arm_gic.c
>> 22 VERSION
>> 21 target-tilegx/translate.c
>> 21 include/ui/console.h
> [...]
>
> Unmaintained files sorted by number of commits in the past year (commit
> 351053e):
>
> $ for i in `cat unmaintained-files`; do echo -n "$i "; git-rev-list 351053e.. $i | wc -l; done | awk '{ printf "%7d %s\n", $2, $1 }' | sort -rn | head -n 100
> 181 trace-events
> 104 configure
> 98 MAINTAINERS
> 82 hw/misc/ivshmem.c
> 54 qemu-options.hx
> 53 Makefile.objs
> 50 target-tilegx/translate.c
> 49 Makefile
> 42 include/sysemu/block-backend.h
> 31 include/qemu-common.h
> 30 tests/vhost-user-test.c
> 28 tests/.gitignore
> 28 include/qom/cpu.h
> 27 include/qemu/osdep.h
> 23 include/sysemu/sysemu.h
> 22 tests/test-throttle.c
> 22 scripts/checkpatch.pl
> 22 hw/ipmi/ipmi_bmc_sim.c
> 21 qemu-doc.texi
> 20 util/log.c
[...]
>
> Active subsystems lacking a maintainer include tilegx, qdev, replay.
>
> Headers that should probably be covered by existing MAINTAINERS stanzas
> include include/sysemu/block-backend.h include/qom/cpu.h
> include/hw/arm/xlnx-zynqmp.h.
Unmaintained files sorted by number of commits in the past year
(v2.11.0-rc2):
$ for i in `cat unmaintained-files`; do echo -n "$i "; git-rev-list v2.11.0-rc2.. $i | wc -l; done | awk '{ printf "%7d %s\n", $2, $1 }' | sort -rn | head -n 100
139 MAINTAINERS
138 configure
108 tests/Makefile.include
87 qemu-options.hx
62 qemu-doc.texi
56 Makefile
44 tests/test-bdrv-drain.c
26 tests/test-blockjob.c
24 Makefile.objs
22 VERSION
21 tests/test-blockjob-txn.c
21 scripts/checkpatch.pl
20 default-configs/arm-softmmu.mak
19 hw/display/sm501.c
17 hw/misc/Makefile.objs
16 include/sysemu/sysemu.h
15 include/hw/mem/pc-dimm.h
15 hw/sd/trace-events
15 contrib/libvhost-user/libvhost-user.c
14 tests/test-char.c
14 hw/core/qdev.c
13 scripts/update-linux-headers.sh
13 scripts/device-crash-test
13 hw/display/Makefile.objs
13 .gitignore
12 include/qom/cpu.h
12 include/hw/mem/memory-device.h
12 include/elf.h
12 hw/misc/trace-events
12 default-configs/ppc-softmmu.mak
11 util/qht.c
10 util/memfd.c
10 qdev-monitor.c
10 include/sysemu/blockdev.h
10 include/qapi/qmp/dispatch.h
10 hw/misc/ivshmem.c
10 gdbstub.c
10 docs/devel/testing.rst
9 tests/check-qobject.c
9 include/qemu/osdep.h
9 include/hw/compat.h
9 contrib/libvhost-user/libvhost-user.h
8 util/qemu-config.c
8 util/Makefile.objs
8 linux-headers/linux/kvm.h
8 iothread.c
8 include/qemu/timer.h
8 include/qemu/qht.h
8 include/hw/qdev-properties.h
8 include/hw/pci-host/uninorth.h
8 hw/intc/trace-events
8 hw/hyperv/hyperv.c
8 hw/core/loader.c
7 util/qsp.c
7 tests/test-qht.c
7 tests/.gitignore
7 os-posix.c
7 include/qemu/compiler.h
7 include/monitor/monitor.h
7 include/hw/qdev-core.h
7 include/hw/loader.h
7 include/hw/arm/smmu-common.h
7 docs/qcow2-cache.txt
7 default-configs/i386-softmmu.mak
7 Makefile.target
7 .gitmodules
6 tests/check-qlit.c
6 pc-bios/README
6 include/sysemu/arch_init.h
6 include/qemu/thread.h
6 include/qemu/memfd.h
6 include/hw/ssi/xilinx_spips.h
6 include/hw/hyperv/hyperv.h
6 include/hw/block/block.h
6 hw/nvram/fw_cfg.c
6 hw/input/ps2.c
6 docs/nvdimm.txt
6 docs/interop/qmp-spec.txt
6 device-hotplug.c
6 default-configs/x86_64-softmmu.mak
5 win_dump.c
5 util/uri.c
5 util/qemu-thread-posix.c
5 util/oslib-posix.c
5 tests/test-x86-cpuid-compat.c
5 tests/test-rcu-list.c
5 tests/tcg/README
5 tests/migration/Makefile
5 rules.mak
5 roms/openbios
5 pc-bios/openbios-ppc
5 linux-headers/asm-x86/kvm.h
5 linux-headers/asm-powerpc/kvm.h
5 include/standard-headers/linux/pci_regs.h
5 include/qemu/typedefs.h
5 include/qemu/cutils.h
5 include/hw/misc/iotkit-secctl.h
5 hw/watchdog/watchdog.c
5 hw/sd/ssi-sd.c
5 hw/pci-host/bonito.c
Maintainers lacks a pattern covering tests/ in a few places,
e.g. tests/test-blockjob*.c, tests/test-char.c.
qdev needs a maintainer. It has needed one since forever.
>> Sorted by maximum(added lines, deleted lines), top scorers:
>>
>> $ git-diff --numstat 1733681 `cat unmaintained-files ` | awk '{ print ($1 > $2 ? $1 : $2), $0 }' | sort -nr | sed 's/^[0-9]* //' | head -n 100
>> 2161 0 target-tilegx/translate.c
>> 1504 0 pc-bios/qemu.rsrc
>> 1406 0 target-tilegx/opcode_tilegx.h
>> 1255 0 tests/test-cutils.c
>> 1203 0 include/standard-headers/linux/input.h
>> 1 1112 arch_init.c
>> 1104 0 tests/pkix_asn1_tab.c
>> 1039 767 fpu/softfloat.c
>> 1014 0 docs/specs/rocker.txt
>> 962 0 tests/libqos/ahci.c
>> 924 4 disas/mips.c
>> 908 0 include/standard-headers/linux/pci_regs.h
>> 609 150 hw/intc/arm_gic.c
>> 597 0 scripts/analyze-migration.py
>> 586 0 tests/libqos/ahci.h
>> 565 119 hw/display/tcx.c
>> 485 0 tests/crypto-tls-x509-helpers.c
>> 465 0 tests/tco-test.c
>> 463 0 tests/rcutorture.c
>> 439 0 hw/display/vga-helpers.h
> [...]
>
> $ git-diff --numstat 351053e `cat unmaintained-files ` | awk '{ print ($1 > $2 ? $1 : $2), $0 }' | sort -nr | sed 's/^[0-9]* //' | head -n 100
> 2453 0 target-tilegx/translate.c
> 1810 0 hw/ipmi/ipmi_bmc_sim.c
> 63 1542 trace-events
> 1438 0 tests/vhost-user-bridge.c
> 1406 0 target-tilegx/opcode_tilegx.h
> 1348 5 tests/test-cutils.c
> 1105 0 tests/pkix_asn1_tab.c
> 1063 0 linux-headers/asm-mips/unistd.h
> 950 515 hw/misc/ivshmem.c
> 930 0 tests/test-qga.c
> 907 559 configure
> 844 0 util/qht.c
> 825 0 hmp-commands-info.hx
> 805 0 include/standard-headers/linux/input-event-codes.h
> 71 788 include/standard-headers/linux/input.h
> 778 0 tests/Makefile.include
> 635 0 include/hw/ide/internal.h
> 623 0 tests/migration/guestperf/plot.py
> 177 539 scripts/checkpatch.pl
> 537 0 hw/ipmi/isa_ipmi_bt.c
[...]
$ git-diff --numstat v2.11.0-rc2 `cat unmaintained-files ` | awk '{ print ($1 > $2 ? $1 : $2), $0 }' | sort -nr | sed 's/^[0-9]* //' | head -n 100
1848 0 include/standard-headers/linux/ethtool.h
1609 0 tests/test-bdrv-drain.c
1148 359 configure
992 0 tests/fp/fp-test.c
928 806 util/uri.c
836 0 include/hw/xtensa/xtensa-isa.h
795 0 hw/misc/iotkit-secctl.c
794 0 util/qsp.c
785 0 linux-headers/asm-generic/unistd.h
732 0 docs/devel/testing.rst
725 0 util/vfio-helpers.c
668 10 tests/test-cutils.c
667 0 include/standard-headers/drivers/infiniband/hw/vmw_pvrdma/pvrdma_dev_api.h
664 323 qemu-doc.texi
654 0 hw/hyperv/hyperv.c
653 0 tests/fp/wrap.inc.c
9 620 hw/input/adb.c
597 0 tests/fp/Makefile
587 0 include/standard-headers/drm/drm_fourcc.h
574 0 contrib/vhost-user-blk/vhost-user-blk.c
508 571 qemu-options.hx
566 0 pc-bios/canyonlands.dts
558 30 contrib/libvhost-user/libvhost-user.c
541 0 hw/pci-host/sabre.c
540 0 docs/interop/firmware.json
503 121 MAINTAINERS
128 442 hw/input/ps2.c
407 0 hw/input/adb-kbd.c
4 397 linux-headers/asm-s390/unistd.h
389 0 win_dump.c
383 0 include/standard-headers/drivers/infiniband/hw/vmw_pvrdma/pvrdma_verbs.h
367 0 linux-headers/asm-s390/unistd_32.h
359 0 linux-headers/LICENSES/preferred/GPL-2.0
10 348 linux-headers/COPYING
335 28 hw/core/loader.c
334 0 linux-headers/asm-s390/unistd_64.h
327 0 hw/hyperv/hyperv_testdev.c
61 312 include/glib-compat.h
297 0 include/standard-headers/rdma/vmw_pvrdma-abi.h
281 82 Makefile
277 0 hw/misc/imx7_ccm.c
274 31 hw/display/sm501.c
266 0 tests/test-util-sockets.c
265 233 tests/Makefile.include
262 0 hw/input/adb-mouse.c
253 0 tests/migration/s390x/a-b-bios.h
249 12 tests/test-blockjob.c
240 0 hw/misc/pca9552.c
216 12 tests/test-char.c
51 208 hw/intc/openpic.c
202 0 hw/nvram/eeprom_at24c.c
11 195 hw/i2c/i2c-ddc.c
191 0 hw/display/sii9022.c
179 0 include/qemu/win_dump_defs.h
171 0 tests/atomic64-bench.c
170 58 util/qht.c
170 0 include/hw/arm/smmu-common.h
31 160 memory_ldst.inc.c
158 0 docs/interop/prl-xml.txt
157 0 tests/test-image-locking.c
154 0 linux-headers/linux/psp-sev.h
153 0 include/qemu/atomic128.h
150 6 linux-headers/linux/kvm.h
149 0 tests/socket-helpers.c
147 0 include/exec/memory_ldst_phys.inc.h
26 144 hw/pci-host/bonito.c
139 0 include/hw/misc/imx7_ccm.h
138 0 tests/multiboot/aout_kludge.S
133 2 include/qemu/rcu_queue.h
63 130 hw/core/qdev.c
130 0 include/hw/hyperv/hyperv-proto.h
129 41 Makefile.objs
129 0 util/cutils.c
128 7 include/qemu/thread.h
127 20 scripts/checkpatch.pl
125 0 include/hw/misc/iotkit-secctl.h
124 0 hw/misc/imx7_gpr.c
123 48 gdbstub.c
123 2 docs/specs/tpm.txt
122 0 include/standard-headers/asm-x86/kvm_para.h
114 0 include/standard-headers/drivers/infiniband/hw/vmw_pvrdma/pvrdma_ring.h
109 0 include/hw/mem/memory-device.h
109 0 docs/amd-memory-encryption.txt
108 0 include/exec/memory_ldst_cached.inc.h
107 0 docs/can.txt
105 11 tests/test-qht.c
105 0 include/sysemu/hvf.h
102 0 linux-headers/linux/vfio.h
99 5 tests/vhost-user-bridge.c
97 0 include/standard-headers/linux/qemu_fw_cfg.h
96 0 include/qemu/lockable.h
96 0 hw/core/qdev-fw.c
94 3 include/elf.h
93 0 include/qemu/units.h
91 50 util/memfd.c
91 37 docs/qcow2-cache.txt
9 89 tests/.gitignore
89 5 util/oslib-posix.c
89 3 include/qemu/compiler.h
89 0 hw/misc/imx2_wdt.c
>>>>
>>>> Ideas? Takers?
>>>
>>> Full list of unmaintained files now:
[...]
.dir-locals.el
.editorconfig
.exrc
.gdbinit
.gitignore
.gitmodules
.gitpublish
.mailmap
CODING_STYLE
COPYING
COPYING.LIB
Changelog
HACKING
LICENSE
MAINTAINERS
Makefile
Makefile.objs
Makefile.target
README
VERSION
accel/Makefile.objs
accel/accel.c
accel/stubs/Makefile.objs
accel/stubs/hax-stub.c
accel/stubs/hvf-stub.c
accel/stubs/kvm-stub.c
accel/stubs/tcg-stub.c
accel/stubs/whpx-stub.c
arch_init.c
backends/Makefile.objs
balloon.c
bsd-user/Makefile.objs
bsd-user/bsd-mman.h
bsd-user/bsdload.c
bsd-user/elfload.c
bsd-user/errno_defs.h
bsd-user/freebsd/strace.list
bsd-user/freebsd/syscall_nr.h
bsd-user/i386/target_signal.h
bsd-user/i386/target_syscall.h
bsd-user/main.c
bsd-user/mmap.c
bsd-user/netbsd/strace.list
bsd-user/netbsd/syscall_nr.h
bsd-user/openbsd/strace.list
bsd-user/openbsd/syscall_nr.h
bsd-user/qemu.h
bsd-user/signal.c
bsd-user/sparc/target_signal.h
bsd-user/sparc/target_syscall.h
bsd-user/sparc64/target_signal.h
bsd-user/sparc64/target_syscall.h
bsd-user/strace.c
bsd-user/syscall.c
bsd-user/syscall_defs.h
bsd-user/uaccess.c
bsd-user/x86_64/target_signal.h
bsd-user/x86_64/target_syscall.h
bt-host.c
bt-vhci.c
capstone
configure
contrib/ivshmem-client/Makefile.objs
contrib/ivshmem-client/ivshmem-client.c
contrib/ivshmem-client/ivshmem-client.h
contrib/ivshmem-client/main.c
contrib/ivshmem-server/Makefile.objs
contrib/ivshmem-server/ivshmem-server.c
contrib/ivshmem-server/ivshmem-server.h
contrib/ivshmem-server/main.c
contrib/libvhost-user/Makefile.objs
contrib/libvhost-user/libvhost-user-glib.c
contrib/libvhost-user/libvhost-user-glib.h
contrib/libvhost-user/libvhost-user.c
contrib/libvhost-user/libvhost-user.h
contrib/systemd/qemu-guest-agent.service
contrib/systemd/qemu-pr-helper.service
contrib/systemd/qemu-pr-helper.socket
contrib/vhost-user-blk/Makefile.objs
contrib/vhost-user-blk/vhost-user-blk.c
contrib/vhost-user-scsi/Makefile.objs
contrib/vhost-user-scsi/vhost-user-scsi.c
cpus-common.c
default-configs/aarch64-softmmu.mak
default-configs/alpha-softmmu.mak
default-configs/arm-softmmu.mak
default-configs/cris-softmmu.mak
default-configs/hppa-softmmu.mak
default-configs/hyperv.mak
default-configs/i386-bsd-user.mak
default-configs/i386-softmmu.mak
default-configs/lm32-softmmu.mak
default-configs/m68k-softmmu.mak
default-configs/microblaze-softmmu.mak
default-configs/microblazeel-softmmu.mak
default-configs/mips-softmmu-common.mak
default-configs/mips-softmmu.mak
default-configs/mips64-softmmu.mak
default-configs/mips64el-softmmu.mak
default-configs/mipsel-softmmu.mak
default-configs/nios2-softmmu.mak
default-configs/or1k-softmmu.mak
default-configs/ppc-softmmu.mak
default-configs/ppc64-softmmu.mak
default-configs/riscv32-softmmu.mak
default-configs/riscv64-softmmu.mak
default-configs/sh4-softmmu.mak
default-configs/sh4eb-softmmu.mak
default-configs/sound.mak
default-configs/sparc-bsd-user.mak
default-configs/sparc-softmmu.mak
default-configs/sparc64-bsd-user.mak
default-configs/sparc64-softmmu.mak
default-configs/tricore-softmmu.mak
default-configs/unicore32-softmmu.mak
default-configs/virtio.mak
default-configs/x86_64-bsd-user.mak
default-configs/x86_64-softmmu.mak
default-configs/xtensa-softmmu.mak
default-configs/xtensaeb-softmmu.mak
device-hotplug.c
disas.c
disas/Makefile.objs
dma-helpers.c
docs/amd-memory-encryption.txt
docs/bootindex.txt
docs/can.txt
docs/ccid.txt
docs/config/ich9-ehci-uhci.cfg
docs/config/mach-virt-graphical.cfg
docs/config/mach-virt-serial.cfg
docs/config/q35-emulated.cfg
docs/config/q35-virtio-graphical.cfg
docs/config/q35-virtio-serial.cfg
docs/devel/atomics.txt
docs/devel/blkdebug.txt
docs/devel/blkverify.txt
docs/devel/loads-stores.rst
docs/devel/lockcnt.txt
docs/devel/memory.txt
docs/devel/multi-thread-tcg.txt
docs/devel/multiple-iothreads.txt
docs/devel/rcu.txt
docs/devel/stable-process.rst
docs/devel/testing.rst
docs/devel/virtio-migration.txt
docs/igd-assign.txt
docs/image-fuzzer.txt
docs/interop/firmware.json
docs/interop/live-block-operations.rst
docs/interop/pr-helper.rst
docs/interop/prl-xml.txt
docs/interop/qed_spec.txt
docs/interop/qemu-qmp-ref.texi
docs/interop/qmp-intro.txt
docs/interop/qmp-spec.txt
docs/interop/vnc-ledstate-Pseudo-encoding.txt
docs/memory-hotplug.txt
docs/multi-thread-compression.txt
docs/multiseat.txt
docs/nvdimm.txt
docs/pr-manager.rst
docs/qcow2-cache.txt
docs/qdev-device-use.txt
docs/qemu-block-drivers.texi
docs/qemu_logo.pdf
docs/qemupciserial.inf
docs/rdma.txt
docs/specs/acpi_cpu_hotplug.txt
docs/specs/acpi_mem_hotplug.txt
docs/specs/acpi_nvdimm.txt
docs/specs/edu.txt
docs/specs/fw_cfg.txt
docs/specs/ivshmem-spec.txt
docs/specs/pvpanic.txt
docs/specs/standard-vga.txt
docs/specs/tpm.txt
docs/specs/vmcoreinfo.txt
docs/specs/vmw_pvscsi-spec.txt
docs/spice-port-fqdn.txt
docs/spin/aio_notify.promela
docs/spin/aio_notify_accept.promela
docs/spin/aio_notify_bug.promela
docs/spin/tcg-exclusive.promela
docs/spin/win32-qemu-event.promela
docs/virtio-balloon-stats.txt
docs/xbzrle.txt
dtc
gdb-xml/aarch64-core.xml
gdb-xml/aarch64-fpu.xml
gdb-xml/arm-core.xml
gdb-xml/arm-neon.xml
gdb-xml/arm-vfp.xml
gdb-xml/arm-vfp3.xml
gdb-xml/cf-core.xml
gdb-xml/cf-fp.xml
gdb-xml/i386-32bit-core.xml
gdb-xml/i386-32bit-sse.xml
gdb-xml/i386-32bit.xml
gdb-xml/i386-64bit-core.xml
gdb-xml/i386-64bit-sse.xml
gdb-xml/i386-64bit.xml
gdb-xml/m68k-fp.xml
gdb-xml/power-altivec.xml
gdb-xml/power-core.xml
gdb-xml/power-fpu.xml
gdb-xml/power-spe.xml
gdb-xml/power-vsx.xml
gdb-xml/power64-core.xml
gdbstub.c
hw/Makefile.objs
hw/bt/Makefile.objs
hw/bt/core.c
hw/bt/hci-csr.c
hw/bt/hci.c
hw/bt/hid.c
hw/bt/l2cap.c
hw/bt/sdp.c
hw/core/Makefile.objs
hw/core/bus.c
hw/core/empty_slot.c
hw/core/fw-path-provider.c
hw/core/hotplug.c
hw/core/irq.c
hw/core/loader.c
hw/core/nmi.c
hw/core/or-irq.c
hw/core/platform-bus.c
hw/core/ptimer.c
hw/core/qdev-fw.c
hw/core/qdev-properties-system.c
hw/core/qdev-properties.c
hw/core/qdev.c
hw/core/reset.c
hw/core/split-irq.c
hw/core/stream.c
hw/core/sysbus.c
hw/core/uboot_image.h
hw/cpu/Makefile.objs
hw/cpu/core.c
hw/display/Makefile.objs
hw/display/ads7846.c
hw/display/blizzard.c
hw/display/cg3.c
hw/display/dpcd.c
hw/display/framebuffer.c
hw/display/framebuffer.h
hw/display/g364fb.c
hw/display/jazz_led.c
hw/display/sii9022.c
hw/display/sm501.c
hw/display/sm501_template.h
hw/display/ssd0303.c
hw/display/ssd0323.c
hw/display/tc6393xb.c
hw/display/tc6393xb_template.h
hw/display/tcx.c
hw/display/trace-events
hw/display/vmware_vga.c
hw/dma/Makefile.objs
hw/dma/rc4030.c
hw/dma/soc_dma.c
hw/dma/trace-events
hw/gpio/Makefile.objs
hw/gpio/gpio_key.c
hw/gpio/max7310.c
hw/gpio/mpc8xxx.c
hw/gpio/zaurus.c
hw/hyperv/Makefile.objs
hw/hyperv/hyperv.c
hw/hyperv/hyperv_testdev.c
hw/i2c/Makefile.objs
hw/i2c/bitbang_i2c.c
hw/i2c/bitbang_i2c.h
hw/i2c/core.c
hw/i2c/i2c-ddc.c
hw/i2c/smbus.c
hw/i2c/smbus_eeprom.c
hw/i2c/trace-events
hw/input/Makefile.objs
hw/input/adb-internal.h
hw/input/adb-kbd.c
hw/input/adb-mouse.c
hw/input/adb.c
hw/input/hid.c
hw/input/lm832x.c
hw/input/ps2.c
hw/input/trace-events
hw/input/tsc2005.c
hw/input/tsc210x.c
hw/intc/Makefile.objs
hw/intc/gicv3_internal.h
hw/intc/intc.c
hw/intc/nios2_iic.c
hw/intc/ompic.c
hw/intc/openpic.c
hw/intc/openpic_kvm.c
hw/intc/slavio_intctl.c
hw/intc/trace-events
hw/intc/vgic_common.h
hw/isa/Makefile.objs
hw/isa/apm.c
hw/isa/isa-bus.c
hw/isa/trace-events
hw/m68k/Makefile.objs
hw/misc/Makefile.objs
hw/misc/applesmc.c
hw/misc/arm_l2x0.c
hw/misc/auxbus.c
hw/misc/cbus.c
hw/misc/imx25_ccm.c
hw/misc/imx2_wdt.c
hw/misc/imx6_ccm.c
hw/misc/imx7_ccm.c
hw/misc/imx7_gpr.c
hw/misc/imx7_snvs.c
hw/misc/iotkit-secctl.c
hw/misc/ivshmem.c
hw/misc/max111x.c
hw/misc/pca9552.c
hw/misc/pvpanic.c
hw/misc/tmp105.c
hw/misc/tmp105.h
hw/misc/tmp421.c
hw/misc/trace-events
hw/nvram/Makefile.objs
hw/nvram/ds1225y.c
hw/nvram/eeprom93xx.c
hw/nvram/eeprom_at24c.c
hw/nvram/fw_cfg.c
hw/nvram/trace-events
hw/pci-host/Makefile.objs
hw/pci-host/bonito.c
hw/pci-host/gpex.c
hw/pci-host/sabre.c
hw/pci-host/trace-events
hw/pcmcia/Makefile.objs
hw/pcmcia/pcmcia.c
hw/sd/Makefile.objs
hw/sd/ssi-sd.c
hw/sd/trace-events
hw/timer/Makefile.objs
hw/timer/altera_timer.c
hw/timer/ds1338.c
hw/timer/m48t59-internal.h
hw/timer/m48t59.c
hw/timer/slavio_timer.c
hw/timer/trace-events
hw/timer/twl92230.c
hw/watchdog/Makefile.objs
hw/watchdog/trace-events
hw/watchdog/watchdog.c
hw/watchdog/wdt_i6300esb.c
include/disas/bfd.h
include/disas/capstone.h
include/disas/disas.h
include/elf.h
include/exec/address-spaces.h
include/exec/gdbstub.h
include/exec/gen-icount.h
include/exec/hwaddr.h
include/exec/log.h
include/exec/memattrs.h
include/exec/memory_ldst.inc.h
include/exec/memory_ldst_cached.inc.h
include/exec/memory_ldst_phys.inc.h
include/exec/poison.h
include/exec/ramlist.h
include/exec/semihost.h
include/exec/softmmu-semi.h
include/exec/target_page.h
include/exec/tb-context.h
include/exec/tb-hash-xx.h
include/exec/tb-lookup.h
include/exec/translator.h
include/exec/user/abitypes.h
include/exec/user/thunk.h
include/glib-compat.h
include/hw/arm/fdt.h
include/hw/arm/fsl-imx25.h
include/hw/arm/linux-boot-if.h
include/hw/arm/sharpsl.h
include/hw/arm/smmu-common.h
include/hw/arm/smmuv3.h
include/hw/arm/soc_dma.h
include/hw/arm/sysbus-fdt.h
include/hw/block/block.h
include/hw/block/flash.h
include/hw/bt.h
include/hw/char/cadence_uart.h
include/hw/char/digic-uart.h
include/hw/char/escc.h
include/hw/char/nrf51_uart.h
include/hw/char/serial.h
include/hw/char/xilinx_uartlite.h
include/hw/compat.h
include/hw/core/split-irq.h
include/hw/cpu/core.h
include/hw/devices.h
include/hw/display/dpcd.h
include/hw/elf_ops.h
include/hw/empty_slot.h
include/hw/fw-path-provider.h
include/hw/hotplug.h
include/hw/hw.h
include/hw/hyperv/hyperv-proto.h
include/hw/hyperv/hyperv.h
include/hw/i2c/i2c-ddc.h
include/hw/i2c/i2c.h
include/hw/i2c/smbus.h
include/hw/input/adb-keys.h
include/hw/input/adb.h
include/hw/input/hid.h
include/hw/input/ps2.h
include/hw/intc/heathrow_pic.h
include/hw/intc/intc.h
include/hw/ipack/ipack.h
include/hw/irq.h
include/hw/isa/apm.h
include/hw/isa/i8259_internal.h
include/hw/isa/isa.h
include/hw/kvm/clock.h
include/hw/loader-fit.h
include/hw/loader.h
include/hw/mem/memory-device.h
include/hw/mem/pc-dimm.h
include/hw/misc/arm_integrator_debug.h
include/hw/misc/auxbus.h
include/hw/misc/imx25_ccm.h
include/hw/misc/imx2_wdt.h
include/hw/misc/imx6_ccm.h
include/hw/misc/imx7_ccm.h
include/hw/misc/imx7_gpr.h
include/hw/misc/imx7_snvs.h
include/hw/misc/iotkit-secctl.h
include/hw/misc/ivshmem.h
include/hw/misc/pca9552.h
include/hw/misc/pca9552_regs.h
include/hw/misc/pvpanic.h
include/hw/misc/tmp105_regs.h
include/hw/nmi.h
include/hw/nvram/eeprom93xx.h
include/hw/nvram/fw_cfg.h
include/hw/nvram/sun_nvram.h
include/hw/or-irq.h
include/hw/pci-bridge/simba.h
include/hw/pci-host/gpex.h
include/hw/pci-host/sabre.h
include/hw/pci-host/uninorth.h
include/hw/pci-host/xilinx-pcie.h
include/hw/pcmcia.h
include/hw/platform-bus.h
include/hw/ptimer.h
include/hw/qdev-core.h
include/hw/qdev-dma.h
include/hw/qdev-properties.h
include/hw/qdev.h
include/hw/sparc/sparc64.h
include/hw/sparc/sun4m_iommu.h
include/hw/sparc/sun4u_iommu.h
include/hw/ssi/xilinx_spips.h
include/hw/stream.h
include/hw/sysbus.h
include/hw/timer/digic-timer.h
include/hw/xtensa/xtensa-isa.h
include/libdecnumber/dconfig.h
include/libdecnumber/decContext.h
include/libdecnumber/decDPD.h
include/libdecnumber/decNumber.h
include/libdecnumber/decNumberLocal.h
include/libdecnumber/dpd/decimal128.h
include/libdecnumber/dpd/decimal128Local.h
include/libdecnumber/dpd/decimal32.h
include/libdecnumber/dpd/decimal64.h
include/monitor/monitor.h
include/monitor/qdev.h
include/qapi/qmp/dispatch.h
include/qemu-common.h
include/qemu-io.h
include/qemu/acl.h
include/qemu/atomic.h
include/qemu/atomic128.h
include/qemu/base64.h
include/qemu/bcd.h
include/qemu/bitmap.h
include/qemu/bitops.h
include/qemu/bswap.h
include/qemu/compiler.h
include/qemu/config-file.h
include/qemu/cpuid.h
include/qemu/crc32c.h
include/qemu/cutils.h
include/qemu/drm.h
include/qemu/envlist.h
include/qemu/event_notifier.h
include/qemu/fifo32.h
include/qemu/fifo8.h
include/qemu/fprintf-fn.h
include/qemu/futex.h
include/qemu/help_option.h
include/qemu/host-utils.h
include/qemu/id.h
include/qemu/int128.h
include/qemu/iov.h
include/qemu/jhash.h
include/qemu/lockable.h
include/qemu/log-for-trace.h
include/qemu/log.h
include/qemu/main-loop.h
include/qemu/memfd.h
include/qemu/mmap-alloc.h
include/qemu/module.h
include/qemu/notify.h
include/qemu/option_int.h
include/qemu/osdep.h
include/qemu/path.h
include/qemu/pmem.h
include/qemu/processor.h
include/qemu/qdist.h
include/qemu/qht.h
include/qemu/qsp.h
include/qemu/queue.h
include/qemu/range.h
include/qemu/ratelimit.h
include/qemu/rcu.h
include/qemu/rcu_queue.h
include/qemu/readline.h
include/qemu/seqlock.h
include/qemu/stats64.h
include/qemu/sys_membarrier.h
include/qemu/systemd.h
include/qemu/thread-posix.h
include/qemu/thread.h
include/qemu/timed-average.h
include/qemu/timer.h
include/qemu/typedefs.h
include/qemu/unicode.h
include/qemu/units.h
include/qemu/uri.h
include/qemu/vfio-helpers.h
include/qemu/win_dump_defs.h
include/qemu/xattr.h
include/qom/cpu.h
include/standard-headers/asm-s390/virtio-ccw.h
include/standard-headers/asm-x86/kvm_para.h
include/standard-headers/drivers/infiniband/hw/vmw_pvrdma/pvrdma_dev_api.h
include/standard-headers/drivers/infiniband/hw/vmw_pvrdma/pvrdma_ring.h
include/standard-headers/drivers/infiniband/hw/vmw_pvrdma/pvrdma_verbs.h
include/standard-headers/drm/drm_fourcc.h
include/standard-headers/linux/ethtool.h
include/standard-headers/linux/if_ether.h
include/standard-headers/linux/input-event-codes.h
include/standard-headers/linux/input.h
include/standard-headers/linux/kernel.h
include/standard-headers/linux/pci_regs.h
include/standard-headers/linux/qemu_fw_cfg.h
include/standard-headers/linux/sysinfo.h
include/standard-headers/linux/types.h
include/standard-headers/linux/virtio_9p.h
include/standard-headers/linux/virtio_balloon.h
include/standard-headers/linux/virtio_blk.h
include/standard-headers/linux/virtio_config.h
include/standard-headers/linux/virtio_console.h
include/standard-headers/linux/virtio_crypto.h
include/standard-headers/linux/virtio_gpu.h
include/standard-headers/linux/virtio_ids.h
include/standard-headers/linux/virtio_input.h
include/standard-headers/linux/virtio_mmio.h
include/standard-headers/linux/virtio_net.h
include/standard-headers/linux/virtio_pci.h
include/standard-headers/linux/virtio_ring.h
include/standard-headers/linux/virtio_rng.h
include/standard-headers/linux/virtio_scsi.h
include/standard-headers/linux/virtio_types.h
include/standard-headers/linux/virtio_vsock.h
include/standard-headers/rdma/vmw_pvrdma-abi.h
include/sysemu/accel.h
include/sysemu/arch_init.h
include/sysemu/balloon.h
include/sysemu/block-backend.h
include/sysemu/blockdev.h
include/sysemu/bt.h
include/sysemu/dma.h
include/sysemu/hax.h
include/sysemu/hvf.h
include/sysemu/hw_accel.h
include/sysemu/iothread.h
include/sysemu/memory_mapping.h
include/sysemu/os-posix.h
include/sysemu/qtest.h
include/sysemu/reset.h
include/sysemu/sev.h
include/sysemu/sysemu.h
include/sysemu/watchdog.h
include/sysemu/whpx.h
include/trace-tcg.h
iothread.c
libdecnumber/Makefile.objs
libdecnumber/decContext.c
libdecnumber/decNumber.c
libdecnumber/dpd/decimal128.c
libdecnumber/dpd/decimal32.c
libdecnumber/dpd/decimal64.c
linux-headers/COPYING
linux-headers/LICENSES/exceptions/Linux-syscall-note
linux-headers/LICENSES/preferred/BSD-2-Clause
linux-headers/LICENSES/preferred/BSD-3-Clause
linux-headers/LICENSES/preferred/GPL-2.0
linux-headers/README
linux-headers/asm-arm/bitsperlong.h
linux-headers/asm-arm/kvm.h
linux-headers/asm-arm/unistd-common.h
linux-headers/asm-arm/unistd-eabi.h
linux-headers/asm-arm/unistd-oabi.h
linux-headers/asm-arm/unistd.h
linux-headers/asm-arm64/bitsperlong.h
linux-headers/asm-arm64/kvm.h
linux-headers/asm-arm64/unistd.h
linux-headers/asm-generic/bitsperlong.h
linux-headers/asm-generic/unistd.h
linux-headers/asm-mips/bitsperlong.h
linux-headers/asm-mips/kvm.h
linux-headers/asm-mips/sgidefs.h
linux-headers/asm-mips/unistd.h
linux-headers/asm-powerpc/bitsperlong.h
linux-headers/asm-powerpc/kvm.h
linux-headers/asm-powerpc/unistd.h
linux-headers/asm-s390/bitsperlong.h
linux-headers/asm-s390/kvm.h
linux-headers/asm-s390/unistd.h
linux-headers/asm-s390/unistd_32.h
linux-headers/asm-s390/unistd_64.h
linux-headers/asm-x86/bitsperlong.h
linux-headers/asm-x86/kvm.h
linux-headers/asm-x86/unistd.h
linux-headers/asm-x86/unistd_32.h
linux-headers/asm-x86/unistd_64.h
linux-headers/asm-x86/unistd_x32.h
linux-headers/linux/kvm.h
linux-headers/linux/psci.h
linux-headers/linux/psp-sev.h
linux-headers/linux/userfaultfd.h
linux-headers/linux/vfio.h
linux-headers/linux/vfio_ccw.h
linux-headers/linux/vhost.h
linux-headers/linux/virtio_config.h
linux-headers/linux/virtio_ring.h
memory_ldst.inc.c
memory_mapping.c
module-common.c
os-posix.c
pc-bios/Makefile
pc-bios/QEMU,cgthree.bin
pc-bios/QEMU,tcx.bin
pc-bios/README
pc-bios/bamboo.dtb
pc-bios/bamboo.dts
pc-bios/bios-256k.bin
pc-bios/bios.bin
pc-bios/canyonlands.dtb
pc-bios/canyonlands.dts
pc-bios/efi-e1000.rom
pc-bios/efi-e1000e.rom
pc-bios/efi-eepro100.rom
pc-bios/efi-ne2k_pci.rom
pc-bios/efi-pcnet.rom
pc-bios/efi-rtl8139.rom
pc-bios/efi-virtio.rom
pc-bios/efi-vmxnet3.rom
pc-bios/hppa-firmware.img
pc-bios/keymaps/Makefile
pc-bios/keymaps/ar
pc-bios/keymaps/bepo
pc-bios/keymaps/common
pc-bios/keymaps/cz
pc-bios/keymaps/da
pc-bios/keymaps/de
pc-bios/keymaps/de-ch
pc-bios/keymaps/en-gb
pc-bios/keymaps/en-us
pc-bios/keymaps/es
pc-bios/keymaps/et
pc-bios/keymaps/fi
pc-bios/keymaps/fo
pc-bios/keymaps/fr
pc-bios/keymaps/fr-be
pc-bios/keymaps/fr-ca
pc-bios/keymaps/fr-ch
pc-bios/keymaps/hr
pc-bios/keymaps/hu
pc-bios/keymaps/is
pc-bios/keymaps/it
pc-bios/keymaps/ja
pc-bios/keymaps/lt
pc-bios/keymaps/lv
pc-bios/keymaps/mk
pc-bios/keymaps/modifiers
pc-bios/keymaps/nl
pc-bios/keymaps/nl-be
pc-bios/keymaps/no
pc-bios/keymaps/pl
pc-bios/keymaps/pt
pc-bios/keymaps/pt-br
pc-bios/keymaps/ru
pc-bios/keymaps/sl
pc-bios/keymaps/sv
pc-bios/keymaps/th
pc-bios/keymaps/tr
pc-bios/kvmvapic.bin
pc-bios/linuxboot.bin
pc-bios/linuxboot_dma.bin
pc-bios/multiboot.bin
pc-bios/openbios-ppc
pc-bios/optionrom/Makefile
pc-bios/optionrom/code16gcc.h
pc-bios/optionrom/flat.lds
pc-bios/optionrom/kvmvapic.S
pc-bios/optionrom/linuxboot.S
pc-bios/optionrom/linuxboot_dma.c
pc-bios/optionrom/multiboot.S
pc-bios/optionrom/optionrom.h
pc-bios/palcode-clipper
pc-bios/petalogix-ml605.dtb
pc-bios/petalogix-s3adsp1800.dtb
pc-bios/pxe-e1000.rom
pc-bios/pxe-eepro100.rom
pc-bios/pxe-ne2k_pci.rom
pc-bios/pxe-pcnet.rom
pc-bios/pxe-rtl8139.rom
pc-bios/pxe-virtio.rom
pc-bios/qemu-icon.bmp
pc-bios/qemu-nsis.bmp
pc-bios/qemu-nsis.ico
pc-bios/qemu.rsrc
pc-bios/qemu_logo.svg
pc-bios/qemu_logo_no_text.svg
pc-bios/qemu_vga.ndrv
pc-bios/s390-netboot.img
pc-bios/sgabios.bin
pc-bios/u-boot-sam460-20100605.bin
pc-bios/vgabios-bochs-display.bin
pc-bios/vgabios-cirrus.bin
pc-bios/vgabios-qxl.bin
pc-bios/vgabios-ramfb.bin
pc-bios/vgabios-stdvga.bin
pc-bios/vgabios-virtio.bin
pc-bios/vgabios-vmware.bin
pc-bios/vgabios.bin
po/Makefile
po/bg.po
po/de_DE.po
po/fr_FR.po
po/hu.po
po/it.po
po/messages.po
po/tr.po
po/zh_CN.po
qdev-monitor.c
qdict-test-data.txt
qemu-bridge-helper.c
qemu-doc.texi
qemu-keymap.c
qemu-options-wrapper.h
qemu-options.h
qemu-options.hx
qemu-tech.texi
qom/cpu.c
roms/Makefile
roms/QemuMacDrivers
roms/SLOF
roms/config.seabios-128k
roms/config.seabios-256k
roms/config.vga-bochs-display
roms/config.vga-cirrus
roms/config.vga-isavga
roms/config.vga-qxl
roms/config.vga-ramfb
roms/config.vga-stdvga
roms/config.vga-virtio
roms/config.vga-vmware
roms/configure-seabios.sh
roms/ipxe
roms/openbios
roms/openhackware
roms/qemu-palcode
roms/seabios
roms/seabios-hppa
roms/sgabios
roms/skiboot
roms/u-boot
roms/u-boot-sam460ex
rules.mak
scripts/analyze-inclusions
scripts/archive-source.sh
scripts/checkpatch.pl
scripts/clean-header-guards.pl
scripts/clean-includes
scripts/cleanup-trace-events.pl
scripts/cocci-macro-file.h
scripts/coccinelle/cpu_restore_state.cocci
scripts/coccinelle/err-bad-newline.cocci
scripts/coccinelle/error_propagate_null.cocci
scripts/coccinelle/inplace-byteswaps.cocci
scripts/coccinelle/memory-region-init-ram.cocci
scripts/coccinelle/overflow_muldiv64.cocci
scripts/coccinelle/remove_local_err.cocci
scripts/coccinelle/remove_muldiv64.cocci
scripts/coccinelle/return_directly.cocci
scripts/coccinelle/round.cocci
scripts/coccinelle/simplify_muldiv64.cocci
scripts/coccinelle/swap_muldiv64.cocci
scripts/coccinelle/tcg_gen_extract.cocci
scripts/coccinelle/typecast.cocci
scripts/coccinelle/use-error_fatal.cocci
scripts/create_config
scripts/device-crash-test
scripts/disas-objdump.pl
scripts/extract-vsssdk-headers
scripts/feature_to_c.sh
scripts/get_maintainer.pl
scripts/git.orderfile
scripts/gtester-cat
scripts/hxtool
scripts/kvm/kvm_flightrecorder
scripts/kvm/vmxcap
scripts/make-release
scripts/make_device_config.sh
scripts/modules/module_block.py
scripts/qemugdb/__init__.py
scripts/qemugdb/coroutine.py
scripts/qemugdb/mtree.py
scripts/qemugdb/tcg.py
scripts/qemugdb/timers.py
scripts/refresh-pxe-roms.sh
scripts/shaderinclude.pl
scripts/show-fixed-bugs.sh
scripts/switch-timer-api
scripts/texi2pod.pl
scripts/update-linux-headers.sh
target/tilegx/Makefile.objs
target/tilegx/cpu.c
target/tilegx/cpu.h
target/tilegx/helper.c
target/tilegx/helper.h
target/tilegx/opcode_tilegx.h
target/tilegx/simd_helper.c
target/tilegx/spr_def_64.h
target/tilegx/translate.c
tests/.gitignore
tests/Makefile.include
tests/acceptance/README.rst
tests/acceptance/avocado_qemu/__init__.py
tests/acceptance/boot_linux_console.py
tests/acceptance/version.py
tests/acceptance/vnc.py
tests/atomic64-bench.c
tests/atomic_add-bench.c
tests/boot-sector.c
tests/boot-sector.h
tests/check-block.sh
tests/check-qlit.c
tests/check-qnull.c
tests/check-qobject.c
tests/crypto-tls-psk-helpers.c
tests/crypto-tls-psk-helpers.h
tests/crypto-tls-x509-helpers.c
tests/crypto-tls-x509-helpers.h
tests/data/acpi/pc/APIC
tests/data/acpi/pc/APIC.cphp
tests/data/acpi/pc/APIC.dimmpxm
tests/data/acpi/pc/DSDT
tests/data/acpi/pc/DSDT.bridge
tests/data/acpi/pc/DSDT.cphp
tests/data/acpi/pc/DSDT.dimmpxm
tests/data/acpi/pc/DSDT.ipmikcs
tests/data/acpi/pc/DSDT.memhp
tests/data/acpi/pc/DSDT.numamem
tests/data/acpi/pc/FACP
tests/data/acpi/pc/FACS
tests/data/acpi/pc/HPET
tests/data/acpi/pc/NFIT.dimmpxm
tests/data/acpi/pc/SLIT.cphp
tests/data/acpi/pc/SLIT.memhp
tests/data/acpi/pc/SRAT.cphp
tests/data/acpi/pc/SRAT.dimmpxm
tests/data/acpi/pc/SRAT.memhp
tests/data/acpi/pc/SRAT.numamem
tests/data/acpi/pc/SSDT.dimmpxm
tests/data/acpi/q35/APIC
tests/data/acpi/q35/APIC.cphp
tests/data/acpi/q35/APIC.dimmpxm
tests/data/acpi/q35/DSDT
tests/data/acpi/q35/DSDT.bridge
tests/data/acpi/q35/DSDT.cphp
tests/data/acpi/q35/DSDT.dimmpxm
tests/data/acpi/q35/DSDT.ipmibt
tests/data/acpi/q35/DSDT.memhp
tests/data/acpi/q35/DSDT.mmio64
tests/data/acpi/q35/DSDT.numamem
tests/data/acpi/q35/FACP
tests/data/acpi/q35/FACS
tests/data/acpi/q35/HPET
tests/data/acpi/q35/MCFG
tests/data/acpi/q35/NFIT.dimmpxm
tests/data/acpi/q35/SLIT.cphp
tests/data/acpi/q35/SLIT.memhp
tests/data/acpi/q35/SRAT.cphp
tests/data/acpi/q35/SRAT.dimmpxm
tests/data/acpi/q35/SRAT.memhp
tests/data/acpi/q35/SRAT.mmio64
tests/data/acpi/q35/SRAT.numamem
tests/data/acpi/q35/SSDT.dimmpxm
tests/data/acpi/rebuild-expected-aml.sh
tests/data/test-qga-config
tests/data/test-qga-os-release
tests/decode/check.sh
tests/decode/err_argset1.decode
tests/decode/err_argset2.decode
tests/decode/err_field1.decode
tests/decode/err_field2.decode
tests/decode/err_field3.decode
tests/decode/err_field4.decode
tests/decode/err_field5.decode
tests/decode/err_init1.decode
tests/decode/err_init2.decode
tests/decode/err_init3.decode
tests/decode/err_init4.decode
tests/decode/err_overlap1.decode
tests/decode/err_overlap2.decode
tests/decode/err_overlap3.decode
tests/decode/err_overlap4.decode
tests/decode/err_overlap5.decode
tests/decode/err_overlap6.decode
tests/decode/err_overlap7.decode
tests/decode/err_overlap8.decode
tests/decode/err_overlap9.decode
tests/fp/.gitignore
tests/fp/Makefile
tests/fp/berkeley-softfloat-3
tests/fp/berkeley-testfloat-3
tests/fp/fp-test.c
tests/fp/platform.h
tests/fp/wrap.inc.c
tests/guest-debug/test-gdbstub.py
tests/io-channel-helpers.c
tests/io-channel-helpers.h
tests/iothread.c
tests/iothread.h
tests/keys/README
tests/keys/id_rsa
tests/keys/id_rsa.pub
tests/migration/.gitignore
tests/migration/Makefile
tests/migration/aarch64/Makefile
tests/migration/aarch64/a-b-kernel.S
tests/migration/aarch64/a-b-kernel.h
tests/migration/guestperf-batch.py
tests/migration/guestperf-plot.py
tests/migration/guestperf.py
tests/migration/guestperf/__init__.py
tests/migration/guestperf/comparison.py
tests/migration/guestperf/engine.py
tests/migration/guestperf/hardware.py
tests/migration/guestperf/plot.py
tests/migration/guestperf/progress.py
tests/migration/guestperf/report.py
tests/migration/guestperf/scenario.py
tests/migration/guestperf/shell.py
tests/migration/guestperf/timings.py
tests/migration/i386/Makefile
tests/migration/i386/a-b-bootblock.S
tests/migration/i386/a-b-bootblock.h
tests/migration/migration-test.h
tests/migration/s390x/Makefile
tests/migration/s390x/a-b-bios.c
tests/migration/s390x/a-b-bios.h
tests/migration/stress.c
tests/multiboot/.gitignore
tests/multiboot/Makefile
tests/multiboot/aout_kludge.S
tests/multiboot/aout_kludge.out
tests/multiboot/libc.c
tests/multiboot/libc.h
tests/multiboot/link.ld
tests/multiboot/mmap.c
tests/multiboot/mmap.out
tests/multiboot/module.txt
tests/multiboot/modules.c
tests/multiboot/modules.out
tests/multiboot/multiboot.h
tests/multiboot/run_test.sh
tests/multiboot/start.S
tests/pkix_asn1_tab.c
tests/ptimer-test-stubs.c
tests/ptimer-test.h
tests/qemu-iotests-quick.sh
tests/qht-bench.c
tests/rcutorture.c
tests/requirements.txt
tests/socket-helpers.c
tests/socket-helpers.h
tests/tcg/README
tests/tcg/hppa/Makefile.include
tests/tcg/hppa/Makefile.target
tests/tcg/m68k/Makefile.include
tests/tcg/m68k/Makefile.target
tests/tcg/ppc/Makefile.include
tests/tcg/ppc/Makefile.target
tests/tcg/riscv/Makefile.include
tests/tcg/sh4/Makefile.include
tests/tcg/sh4/Makefile.target
tests/tcg/sparc64/Makefile.include
tests/tcg/sparc64/Makefile.target
tests/test-aio-multithread.c
tests/test-aio.c
tests/test-base64.c
tests/test-bdrv-drain.c
tests/test-bitcnt.c
tests/test-bitops.c
tests/test-block-backend.c
tests/test-blockjob-txn.c
tests/test-blockjob.c
tests/test-bufferiszero.c
tests/test-char.c
tests/test-cutils.c
tests/test-filter-mirror.c
tests/test-filter-redirector.c
tests/test-image-locking.c
tests/test-int128.c
tests/test-iov.c
tests/test-logging.c
tests/test-mul64.c
tests/test-netfilter.c
tests/test-qdev-global-props.c
tests/test-qdist.c
tests/test-qht-par.c
tests/test-qht.c
tests/test-rcu-list.c
tests/test-rcu-simpleq.c
tests/test-rcu-tailq.c
tests/test-shift128.c
tests/test-thread-pool.c
tests/test-timed-average.c
tests/test-util-sockets.c
tests/test-vmstate.c
tests/test-write-threshold.c
tests/test-x86-cpuid-compat.c
tests/test-x86-cpuid.c
tests/test-xbzrle.c
tests/vhost-user-bridge.c
util/Makefile.objs
util/acl.c
util/aiocb.c
util/atomic64.c
util/base64.c
util/bitmap.c
util/bitops.c
util/bufferiszero.c
util/cacheinfo.c
util/compatfd.c
util/crc32c.c
util/cutils.c
util/envlist.c
util/event_notifier-posix.c
util/fifo8.c
util/getauxval.c
util/hexdump.c
util/host-utils.c
util/id.c
util/iohandler.c
util/iov.c
util/lockcnt.c
util/log.c
util/memfd.c
util/mmap-alloc.c
util/module.c
util/notify.c
util/osdep.c
util/oslib-posix.c
util/pagesize.c
util/path.c
util/qdist.c
util/qemu-config.c
util/qemu-openpty.c
util/qemu-thread-common.h
util/qemu-thread-posix.c
util/qemu-timer-common.c
util/qht.c
util/qsp.c
util/range.c
util/rcu.c
util/readline.c
util/stats64.c
util/sys_membarrier.c
util/systemd.c
util/thread-pool.c
util/timed-average.c
util/trace-events
util/unicode.c
util/uri.c
util/vfio-helpers.c
version.rc
win_dump.c
win_dump.h
^ permalink raw reply [flat|nested] 55+ messages in thread
* Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered
2018-11-21 18:14 ` Markus Armbruster
@ 2018-11-22 12:22 ` Thomas Huth
2018-11-22 21:56 ` BALATON Zoltan
2018-11-26 13:54 ` Markus Armbruster
0 siblings, 2 replies; 55+ messages in thread
From: Thomas Huth @ 2018-11-22 12:22 UTC (permalink / raw)
To: Markus Armbruster, qemu-devel
Cc: BALATON Zoltan, Peter Maydell, Eduardo Habkost
On 2018-11-21 19:14, Markus Armbruster wrote:
> Time for another update. My HEAD is at v3.1.0-rc2.
Thanks a lot for this, Markus, very appreciated!
[...]
> Unmaintained files sorted by number of commits in the past year
> (v2.11.0-rc2):
>
> $ for i in `cat unmaintained-files`; do echo -n "$i "; git-rev-list v2.11.0-rc2.. $i | wc -l; done | awk '{ printf "%7d %s\n", $2, $1 }' | sort -rn | head -n 100
> 139 MAINTAINERS
> 138 configure
> 108 tests/Makefile.include
> 87 qemu-options.hx
I still think we'd need someone to look after qemu-options.hx, since
these are public interfaces...
> 62 qemu-doc.texi
> 56 Makefile
> 44 tests/test-bdrv-drain.c
> 26 tests/test-blockjob.c
> 24 Makefile.objs
> 22 VERSION
> 21 tests/test-blockjob-txn.c
> 21 scripts/checkpatch.pl
> 20 default-configs/arm-softmmu.mak
Maybe add that to one of Peter's ARM sections?
> 19 hw/display/sm501.c
Maybe Balaton wants to adopt this file?
> 17 hw/misc/Makefile.objs
> 16 include/sysemu/sysemu.h
> 15 include/hw/mem/pc-dimm.h
> 15 hw/sd/trace-events
> 15 contrib/libvhost-user/libvhost-user.c
> 14 tests/test-char.c
> 14 hw/core/qdev.c
> 13 scripts/update-linux-headers.sh
> 13 scripts/device-crash-test
That should go into the "Python scripts" section.
> 13 hw/display/Makefile.objs
> 13 .gitignore
> 12 include/qom/cpu.h
> 12 include/hw/mem/memory-device.h
> 12 include/elf.h
> 12 hw/misc/trace-events
> 12 default-configs/ppc-softmmu.mak
> 11 util/qht.c
> 10 util/memfd.c
> 10 qdev-monitor.c
> 10 include/sysemu/blockdev.h
> 10 include/qapi/qmp/dispatch.h
> 10 hw/misc/ivshmem.c
> 10 gdbstub.c
> 10 docs/devel/testing.rst
> 9 tests/check-qobject.c
> 9 include/qemu/osdep.h
> 9 include/hw/compat.h
> 9 contrib/libvhost-user/libvhost-user.h
> 8 util/qemu-config.c
> 8 util/Makefile.objs
> 8 linux-headers/linux/kvm.h
> 8 iothread.c
> 8 include/qemu/timer.h
> 8 include/qemu/qht.h
> 8 include/hw/qdev-properties.h
> 8 include/hw/pci-host/uninorth.h
uninorth is definitely related to mac99.
> 8 hw/intc/trace-events
> 8 hw/hyperv/hyperv.c
> 8 hw/core/loader.c
> 7 util/qsp.c
> 7 tests/test-qht.c
> 7 tests/.gitignore
> 7 os-posix.c
> 7 include/qemu/compiler.h
> 7 include/monitor/monitor.h
> 7 include/hw/qdev-core.h
> 7 include/hw/loader.h
> 7 include/hw/arm/smmu-common.h
> 7 docs/qcow2-cache.txt
> 7 default-configs/i386-softmmu.mak
> 7 Makefile.target
> 7 .gitmodules
> 6 tests/check-qlit.c
> 6 pc-bios/README
> 6 include/sysemu/arch_init.h
> 6 include/qemu/thread.h
> 6 include/qemu/memfd.h
> 6 include/hw/ssi/xilinx_spips.h
That belongs to one of the ARM machines, I think.
> 6 include/hw/hyperv/hyperv.h
> 6 include/hw/block/block.h
> 6 hw/nvram/fw_cfg.c
> 6 hw/input/ps2.c
> 6 docs/nvdimm.txt
> 6 docs/interop/qmp-spec.txt
> 6 device-hotplug.c
> 6 default-configs/x86_64-softmmu.mak
> 5 win_dump.c
> 5 util/uri.c
> 5 util/qemu-thread-posix.c
> 5 util/oslib-posix.c
> 5 tests/test-x86-cpuid-compat.c
> 5 tests/test-rcu-list.c
> 5 tests/tcg/README
> 5 tests/migration/Makefile
> 5 rules.mak
> 5 roms/openbios
> 5 pc-bios/openbios-ppc
> 5 linux-headers/asm-x86/kvm.h
> 5 linux-headers/asm-powerpc/kvm.h
> 5 include/standard-headers/linux/pci_regs.h
> 5 include/qemu/typedefs.h
> 5 include/qemu/cutils.h
> 5 include/hw/misc/iotkit-secctl.h
> 5 hw/watchdog/watchdog.c
> 5 hw/sd/ssi-sd.c
> 5 hw/pci-host/bonito.c
Bonito seems to belong to MIPS Fulong.
> qdev needs a maintainer. It has needed one since forever.
Definitely. But who could do that job?
Thomas
^ permalink raw reply [flat|nested] 55+ messages in thread
* Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered
2018-11-22 12:22 ` Thomas Huth
@ 2018-11-22 21:56 ` BALATON Zoltan
2018-11-23 5:17 ` Philippe Mathieu-Daudé
2018-11-26 13:54 ` Markus Armbruster
1 sibling, 1 reply; 55+ messages in thread
From: BALATON Zoltan @ 2018-11-22 21:56 UTC (permalink / raw)
To: Thomas Huth; +Cc: Markus Armbruster, qemu-devel, Peter Maydell, Eduardo Habkost
On Thu, 22 Nov 2018, Thomas Huth wrote:
>> 19 hw/display/sm501.c
>
> Maybe Balaton wants to adopt this file?
As discussed before this was originally part of SH4 but since that seems
to be not actively maintained any more and latest changes were for
sam460ex I can add it to sam460ex. I planned to do that when I make any
changes in the future but if needed I can send a patch for this now.
While we're there, should I also add pc-bios/canyonlands.dts which is the
device tree for sam460ex?
Regards,
BALATON Zoltan
^ permalink raw reply [flat|nested] 55+ messages in thread
* Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered
2018-11-22 21:56 ` BALATON Zoltan
@ 2018-11-23 5:17 ` Philippe Mathieu-Daudé
2018-11-23 10:56 ` BALATON Zoltan
0 siblings, 1 reply; 55+ messages in thread
From: Philippe Mathieu-Daudé @ 2018-11-23 5:17 UTC (permalink / raw)
To: BALATON Zoltan, Thomas Huth
Cc: Peter Maydell, Markus Armbruster, Eduardo Habkost, qemu-devel
Hi Zoltan,
On 22/11/18 22:56, BALATON Zoltan wrote:
> On Thu, 22 Nov 2018, Thomas Huth wrote:
>>> 19 hw/display/sm501.c
>>
>> Maybe Balaton wants to adopt this file?
>
> As discussed before this was originally part of SH4 but since that seems
> to be not actively maintained any more and latest changes were for
> sam460ex I can add it to sam460ex. I planned to do that when I make any
> changes in the future but if needed I can send a patch for this now.
>
> While we're there, should I also add pc-bios/canyonlands.dts which is
> the device tree for sam460ex?
Yes, I suggest this set:
pc-bios/canyonlands.dt?
pc-bios/u-boot-sam460*
roms/u-boot-sam460ex
Regards,
Phil.
^ permalink raw reply [flat|nested] 55+ messages in thread
* Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered
2018-11-23 5:17 ` Philippe Mathieu-Daudé
@ 2018-11-23 10:56 ` BALATON Zoltan
2018-11-23 11:03 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 55+ messages in thread
From: BALATON Zoltan @ 2018-11-23 10:56 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: Thomas Huth, Peter Maydell, Markus Armbruster, Eduardo Habkost,
qemu-devel
On Fri, 23 Nov 2018, Philippe Mathieu-Daudé wrote:
> On 22/11/18 22:56, BALATON Zoltan wrote:
>> While we're there, should I also add pc-bios/canyonlands.dts which is
>> the device tree for sam460ex?
>
> Yes, I suggest this set:
>
> pc-bios/canyonlands.dt?
> pc-bios/u-boot-sam460*
> roms/u-boot-sam460ex
Well, canyonlands.dtb and u-boot-sam460-*.bin are binaries built from
canyonlands.dts and roms/u-boot-sam460ex respectively and
roms/u-boot-sam460ex is mirrored from my git repo. So should these be
added despite of this or is it enough to add canyonlands.dts? I thought
only sources are listed in MAINTAINERS not binaries or external sources.
Regards,
BALATON Zoltan
^ permalink raw reply [flat|nested] 55+ messages in thread
* Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered
2018-11-23 10:56 ` BALATON Zoltan
@ 2018-11-23 11:03 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 55+ messages in thread
From: Philippe Mathieu-Daudé @ 2018-11-23 11:03 UTC (permalink / raw)
To: BALATON Zoltan
Cc: Thomas Huth, Peter Maydell, Markus Armbruster, Eduardo Habkost,
qemu-devel
On 23/11/18 11:56, BALATON Zoltan wrote:
> On Fri, 23 Nov 2018, Philippe Mathieu-Daudé wrote:
>> On 22/11/18 22:56, BALATON Zoltan wrote:
>>> While we're there, should I also add pc-bios/canyonlands.dts which is
>>> the device tree for sam460ex?
>>
>> Yes, I suggest this set:
>>
>> pc-bios/canyonlands.dt?
>> pc-bios/u-boot-sam460*
>> roms/u-boot-sam460ex
>
> Well, canyonlands.dtb and u-boot-sam460-*.bin are binaries built from
> canyonlands.dts and roms/u-boot-sam460ex respectively and
> roms/u-boot-sam460ex is mirrored from my git repo. So should these be
> added despite of this or is it enough to add canyonlands.dts? I thought
> only sources are listed in MAINTAINERS not binaries or external sources.
Hmm I see various binaries, i.e.:
$ file pc-bios/s390-ccw.img
pc-bios/s390-ccw.img: ELF 64-bit MSB shared object, IBM S/390, version 1
(SYSV), dynamically linked, interpreter /lib/ld64.so.1,
BuildID[sha1]=5bf569bf2205ea94a015c1fe2702d7efb446a8c5, stripped
$ ./scripts/get_maintainer.pl -f pc-bios/s390-ccw.img
Christian Borntraeger <borntraeger@de.ibm.com> (supporter:S390-ccw boot)
Thomas Huth <thuth@redhat.com> (supporter:S390-ccw boot)
Cornelia Huck <cohuck@redhat.com> (supporter:S390)
qemu-s390x@nongnu.org (open list:S390-ccw boot)
$ file pc-bios/u-boot.e500
pc-bios/u-boot.e500: ELF 32-bit MSB executable, PowerPC or cisco 4500,
version 1 (SYSV), statically linked, stripped
$ ./scripts/get_maintainer.pl -f pc-bios/u-boot.e500
David Gibson <david@gibson.dropbear.id.au> (odd fixer:e500)
qemu-ppc@nongnu.org (open list:e500)
If I have issues with a binary like 'canyonlands.dtb' I'd like to be
able to contact the maintainer. Maybe this is not the best example since
the 'canyonlands.dts' is there too ;)
Regards,
Phil.
^ permalink raw reply [flat|nested] 55+ messages in thread
* Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered
2018-11-22 12:22 ` Thomas Huth
2018-11-22 21:56 ` BALATON Zoltan
@ 2018-11-26 13:54 ` Markus Armbruster
1 sibling, 0 replies; 55+ messages in thread
From: Markus Armbruster @ 2018-11-26 13:54 UTC (permalink / raw)
To: Thomas Huth
Cc: Markus Armbruster, qemu-devel, Peter Maydell, Eduardo Habkost,
Philippe Mathieu-Daudé,
Paolo Bonzini, Eric Blake, Laurent Vivier, Peter Crosthwaite,
Igor Mammedov, Andreas Färber, Michael S. Tsirkin
Thomas Huth <thuth@redhat.com> writes:
> On 2018-11-21 19:14, Markus Armbruster wrote:
>> Time for another update. My HEAD is at v3.1.0-rc2.
>
> Thanks a lot for this, Markus, very appreciated!
>
> [...]
>> Unmaintained files sorted by number of commits in the past year
>> (v2.11.0-rc2):
>>
>> $ for i in `cat unmaintained-files`; do echo -n "$i "; git-rev-list v2.11.0-rc2.. $i | wc -l; done | awk '{ printf "%7d %s\n", $2, $1 }' | sort -rn | head -n 100
>> 139 MAINTAINERS
>> 138 configure
>> 108 tests/Makefile.include
>> 87 qemu-options.hx
>
> I still think we'd need someone to look after qemu-options.hx, since
> these are public interfaces...
QAPIfication to the rescue...
[...]
>> qdev needs a maintainer. It has needed one since forever.
>
> Definitely. But who could do that job?
I'm afraid most (all?) candidates that have the experience lack the
bandwidth. I certainly do. Let's ask git:
$ scripts/get_maintainer.pl -f hw/core/qdev.c
get_maintainer.pl: No maintainers found, printing recent contributors.
get_maintainer.pl: Do not blindly cc: them on patches! Use common sense.
Markus Armbruster <armbru@redhat.com> (commit_signer:8/14=57%)
"Philippe Mathieu-Daudé" <f4bug@amsat.org> (commit_signer:6/14=43%)
Paolo Bonzini <pbonzini@redhat.com> (commit_signer:5/14=36%)
Eric Blake <eblake@redhat.com> (commit_signer:4/14=29%)
Laurent Vivier <laurent@vivier.eu> (commit_signer:2/14=14%)
qemu-devel@nongnu.org (open list:All patches CC here)
$ scripts/get_maintainer.pl -f --git-blame hw/core/qdev.c
Anthony Liguori <anthony@codemonkey.ws> (authored lines:170/1114=15%,commits:49/158=31%)
Peter Crosthwaite <peter.crosthwaite@xilinx.com> (authored lines:149/1114=13%)
Paolo Bonzini <pbonzini@redhat.com> (authored lines:112/1114=10%,commits:49/158=31%)
Igor Mammedov <imammedo@redhat.com> (authored lines:72/1114=6%)
Paul Brook <paul@codesourcery.com> (authored lines:65/1114=6%)
"Andreas Färber" <afaerber@suse.de> (commits:50/158=32%)
Markus Armbruster <armbru@redhat.com> (commits:27/158=17%)
"Michael S. Tsirkin" <mst@redhat.com> (commits:27/158=17%)
qemu-devel@nongnu.org (open list:All patches CC here)
Any takers?
^ permalink raw reply [flat|nested] 55+ messages in thread
end of thread, other threads:[~2018-11-26 13:54 UTC | newest]
Thread overview: 55+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-10-20 9:19 [Qemu-devel] MAINTAINERS leaves too many files uncovered Markus Armbruster
2014-10-20 18:36 ` Paolo Bonzini
2014-10-22 8:23 ` Markus Armbruster
2014-10-22 9:00 ` Paolo Bonzini
2014-10-22 11:45 ` Markus Armbruster
2014-10-22 11:50 ` Paolo Bonzini
2014-10-22 13:06 ` Markus Armbruster
2014-10-22 13:22 ` Alexander Graf
2014-10-22 13:36 ` Paolo Bonzini
2014-10-22 11:58 ` [Qemu-devel] MAINTAINERS: please add myself as usb-serial.c and baum.c maintainer Samuel Thibault
2014-10-22 12:51 ` Paolo Bonzini
2014-10-22 13:00 ` Markus Armbruster
2014-10-22 13:53 ` Samuel Thibault
2014-10-22 15:21 ` Markus Armbruster
2014-10-22 12:06 ` [Qemu-devel] MAINTAINERS leaves too many files uncovered Michael Roth
2014-10-22 12:54 ` Luiz Capitulino
2015-09-22 9:13 ` Markus Armbruster
2015-09-22 10:06 ` Daniel P. Berrange
2015-09-22 10:18 ` Paolo Bonzini
2015-09-22 13:42 ` Thomas Huth
2015-09-22 14:58 ` Gerd Hoffmann
2015-09-22 15:13 ` Juan Quintela
2015-09-22 14:58 ` Daniel P. Berrange
2015-09-22 15:40 ` Peter Maydell
2015-09-22 18:07 ` Eric Blake
2015-09-22 19:50 ` Paolo Bonzini
2015-09-23 8:24 ` Kevin Wolf
2015-09-23 8:30 ` Alberto Garcia
2015-09-24 12:49 ` Markus Armbruster
2015-09-24 12:47 ` Markus Armbruster
2015-09-22 18:37 ` John Snow
2016-08-30 11:31 ` Markus Armbruster
2016-08-30 12:26 ` Cornelia Huck
2016-08-30 12:40 ` Paolo Bonzini
2016-08-30 13:29 ` Cornelia Huck
2016-08-30 12:48 ` Paolo Bonzini
2016-08-30 12:57 ` Peter Maydell
2016-08-30 18:31 ` John Snow
2016-08-30 14:47 ` Paolo Bonzini
2016-08-30 15:29 ` Markus Armbruster
2016-08-30 15:33 ` Paolo Bonzini
2016-08-31 8:28 ` Markus Armbruster
2016-08-30 13:39 ` Cornelia Huck
2016-09-12 13:56 ` Thomas Huth
2016-09-23 12:56 ` Thomas Huth
2016-09-23 14:47 ` Thomas Huth
2018-11-21 18:14 ` Markus Armbruster
2018-11-22 12:22 ` Thomas Huth
2018-11-22 21:56 ` BALATON Zoltan
2018-11-23 5:17 ` Philippe Mathieu-Daudé
2018-11-23 10:56 ` BALATON Zoltan
2018-11-23 11:03 ` Philippe Mathieu-Daudé
2018-11-26 13:54 ` Markus Armbruster
2014-10-22 14:02 ` Alex Bennée
2014-10-22 15:26 ` Markus Armbruster
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.