* [Buildroot] [PATCH] webkitgtk24: use the correct Config.in option for NEON
@ 2015-10-09 9:20 Thomas Petazzoni
2015-10-09 10:33 ` Gustavo Zacarias
2015-10-09 13:23 ` Thomas Petazzoni
0 siblings, 2 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2015-10-09 9:20 UTC (permalink / raw)
To: buildroot
In order to enable JIT support on ARM, webkitgtk24 currently looks at
BR2_ARM_ENABLE_NEON, which is not correct: BR2_ARM_CPU_HAS_NEON should
be used instead.
The BR2_ARM_ENABLE_NEON is only visible for cores that select
BR2_ARM_CPU_MAYBE_HAS_NEON, in order to allow to specify if his
particular SoC has chosen to integrate NEON or not. And if so,
BR2_ARM_CPU_HAS_NEON gets selected.
BR2_ARM_CPU_HAS_NEON is in fact selected in two different ways:
- Either directly by the CPU core selection, if NEON is mandatory in
this CPU core.
- Or by BR2_ARM_ENABLE_NEON, for CPU cores where NEON support is
optional.
So really, BR2_ARM_CPU_HAS_NEON is what should be used by packages.
Cc: Gustavo Zacarias <gustavo@zacarias.com.ar>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
package/webkitgtk24/webkitgtk24.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/webkitgtk24/webkitgtk24.mk b/package/webkitgtk24/webkitgtk24.mk
index a58fed3..3be1cc7 100644
--- a/package/webkitgtk24/webkitgtk24.mk
+++ b/package/webkitgtk24/webkitgtk24.mk
@@ -88,7 +88,7 @@ endif
# ARM needs NEON for JIT
# i386 & x86_64 don't seem to have any special requirements
-ifeq ($(BR2_ARM_ENABLE_NEON)$(BR2_i386)$(BR2_x86_64),y)
+ifeq ($(BR2_ARM_CPU_HAS_NEON)$(BR2_i386)$(BR2_x86_64),y)
WEBKITGTK24_CONF_OPTS += --enable-jit
else
WEBKITGTK24_CONF_OPTS += --disable-jit
--
2.6.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] webkitgtk24: use the correct Config.in option for NEON
2015-10-09 9:20 [Buildroot] [PATCH] webkitgtk24: use the correct Config.in option for NEON Thomas Petazzoni
@ 2015-10-09 10:33 ` Gustavo Zacarias
2015-10-09 13:23 ` Thomas Petazzoni
1 sibling, 0 replies; 3+ messages in thread
From: Gustavo Zacarias @ 2015-10-09 10:33 UTC (permalink / raw)
To: buildroot
On 09/10/15 06:20, Thomas Petazzoni wrote:
> In order to enable JIT support on ARM, webkitgtk24 currently looks at
> BR2_ARM_ENABLE_NEON, which is not correct: BR2_ARM_CPU_HAS_NEON should
> be used instead.
>
> The BR2_ARM_ENABLE_NEON is only visible for cores that select
> BR2_ARM_CPU_MAYBE_HAS_NEON, in order to allow to specify if his
> particular SoC has chosen to integrate NEON or not. And if so,
> BR2_ARM_CPU_HAS_NEON gets selected.
>
> BR2_ARM_CPU_HAS_NEON is in fact selected in two different ways:
>
> - Either directly by the CPU core selection, if NEON is mandatory in
> this CPU core.
>
> - Or by BR2_ARM_ENABLE_NEON, for CPU cores where NEON support is
> optional.
>
> So really, BR2_ARM_CPU_HAS_NEON is what should be used by packages.
>
> Cc: Gustavo Zacarias <gustavo@zacarias.com.ar>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Acked-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] webkitgtk24: use the correct Config.in option for NEON
2015-10-09 9:20 [Buildroot] [PATCH] webkitgtk24: use the correct Config.in option for NEON Thomas Petazzoni
2015-10-09 10:33 ` Gustavo Zacarias
@ 2015-10-09 13:23 ` Thomas Petazzoni
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2015-10-09 13:23 UTC (permalink / raw)
To: buildroot
Hello,
On Fri, 9 Oct 2015 11:20:06 +0200, Thomas Petazzoni wrote:
> In order to enable JIT support on ARM, webkitgtk24 currently looks at
> BR2_ARM_ENABLE_NEON, which is not correct: BR2_ARM_CPU_HAS_NEON should
> be used instead.
>
> The BR2_ARM_ENABLE_NEON is only visible for cores that select
> BR2_ARM_CPU_MAYBE_HAS_NEON, in order to allow to specify if his
> particular SoC has chosen to integrate NEON or not. And if so,
> BR2_ARM_CPU_HAS_NEON gets selected.
>
> BR2_ARM_CPU_HAS_NEON is in fact selected in two different ways:
>
> - Either directly by the CPU core selection, if NEON is mandatory in
> this CPU core.
>
> - Or by BR2_ARM_ENABLE_NEON, for CPU cores where NEON support is
> optional.
>
> So really, BR2_ARM_CPU_HAS_NEON is what should be used by packages.
>
> Cc: Gustavo Zacarias <gustavo@zacarias.com.ar>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
> package/webkitgtk24/webkitgtk24.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-10-09 13:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-10-09 9:20 [Buildroot] [PATCH] webkitgtk24: use the correct Config.in option for NEON Thomas Petazzoni
2015-10-09 10:33 ` Gustavo Zacarias
2015-10-09 13:23 ` Thomas Petazzoni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.