* [PATCH] mfd: axp20x: Add a cell for the power button part of the,axp288 PMICs
@ 2015-10-12 7:16 Borun Fu
2015-10-13 8:11 ` Lee Jones
0 siblings, 1 reply; 6+ messages in thread
From: Borun Fu @ 2015-10-12 7:16 UTC (permalink / raw)
To: sameo, lee.jones
Cc: linux-kernel, fei.yang, Pallala, Ramakrishna, jacob.jun.pan
This patch adds the mfd cell info for axp288 power key device.
Signed-off-by: Borun Fu <borun.fu@linux.intel.com>
Signed-off-by: Fei Yang <fei.yang@intel.com>
---
drivers/mfd/axp20x.c | 20 ++++++++++++++++++++
1 file changed, 20 insertions(+)
diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c
index 3f576b7..3f4e11f 100644
--- a/drivers/mfd/axp20x.c
+++ b/drivers/mfd/axp20x.c
@@ -161,6 +161,21 @@ static struct resource axp22x_pek_resources[] = {
},
};
+static struct resource axp288_power_button_resources[] = {
+ {
+ .name = "PEK_DBR",
+ .start = AXP288_IRQ_POKN,
+ .end = AXP288_IRQ_POKN,
+ .flags = IORESOURCE_IRQ,
+ },
+ {
+ .name = "PEK_DBF",
+ .start = AXP288_IRQ_POKP,
+ .end = AXP288_IRQ_POKP,
+ .flags = IORESOURCE_IRQ,
+ },
+};
+
static struct resource axp288_fuel_gauge_resources[] = {
{
.start = AXP288_IRQ_QWBTU,
@@ -572,6 +587,11 @@ static struct mfd_cell axp288_cells[] = {
.resources = axp288_fuel_gauge_resources,
},
{
+ .name = "axp20x-pek", /* axp20x-pek works for AXP288 as well */
+ .num_resources = ARRAY_SIZE(axp288_power_button_resources),
+ .resources = axp288_power_button_resources,
+ },
+ {
.name = "axp288_pmic_acpi",
},
};
--
1.7.10.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] mfd: axp20x: Add a cell for the power button part of the,axp288 PMICs
2015-10-12 7:16 [PATCH] mfd: axp20x: Add a cell for the power button part of the,axp288 PMICs Borun Fu
@ 2015-10-13 8:11 ` Lee Jones
2015-10-13 18:33 ` Yang, Fei
0 siblings, 1 reply; 6+ messages in thread
From: Lee Jones @ 2015-10-13 8:11 UTC (permalink / raw)
To: Borun Fu
Cc: sameo, linux-kernel, fei.yang, Pallala, Ramakrishna, jacob.jun.pan
On Mon, 12 Oct 2015, Borun Fu wrote:
> This patch adds the mfd cell info for axp288 power key device.
>
> Signed-off-by: Borun Fu <borun.fu@linux.intel.com>
> Signed-off-by: Fei Yang <fei.yang@intel.com>
> ---
> drivers/mfd/axp20x.c | 20 ++++++++++++++++++++
> 1 file changed, 20 insertions(+)
>
> diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c
> index 3f576b7..3f4e11f 100644
> --- a/drivers/mfd/axp20x.c
> +++ b/drivers/mfd/axp20x.c
> @@ -161,6 +161,21 @@ static struct resource axp22x_pek_resources[] = {
> },
> };
>
> +static struct resource axp288_power_button_resources[] = {
> + {
> + .name = "PEK_DBR",
> + .start = AXP288_IRQ_POKN,
> + .end = AXP288_IRQ_POKN,
> + .flags = IORESOURCE_IRQ,
> + },
> + {
> + .name = "PEK_DBF",
> + .start = AXP288_IRQ_POKP,
> + .end = AXP288_IRQ_POKP,
> + .flags = IORESOURCE_IRQ,
> + },
> +};
> +
> static struct resource axp288_fuel_gauge_resources[] = {
> {
> .start = AXP288_IRQ_QWBTU,
> @@ -572,6 +587,11 @@ static struct mfd_cell axp288_cells[] = {
> .resources = axp288_fuel_gauge_resources,
> },
> {
> + .name = "axp20x-pek", /* axp20x-pek works for AXP288 as well */
Doesn't this change insinuate that?
If axp20x-pek didn't work for AXP288 you wouldn't have put it in this
structure right?
> + .num_resources = ARRAY_SIZE(axp288_power_button_resources),
> + .resources = axp288_power_button_resources,
> + },
> + {
> .name = "axp288_pmic_acpi",
> },
> };
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] mfd: axp20x: Add a cell for the power button part of the,axp288 PMICs
2015-10-13 8:11 ` Lee Jones
@ 2015-10-13 18:33 ` Yang, Fei
2015-10-14 7:08 ` Lee Jones
0 siblings, 1 reply; 6+ messages in thread
From: Yang, Fei @ 2015-10-13 18:33 UTC (permalink / raw)
To: Lee Jones, Borun Fu
Cc: sameo, linux-kernel, Pallala, Ramakrishna, jacob.jun.pan
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 1015 bytes --]
>> static struct resource axp288_fuel_gauge_resources[] = {
>> {
>> .start = AXP288_IRQ_QWBTU,
>> @@ -572,6 +587,11 @@ static struct mfd_cell axp288_cells[] = {
>> .resources = axp288_fuel_gauge_resources,
>> },
>> {
>> + .name = "axp20x-pek", /* axp20x-pek works for AXP288 as well */
>
>Doesn't this change insinuate that?
>
>If axp20x-pek didn't work for AXP288 you wouldn't have put it in this structure right?
>
Are you suggesting to remove the comment? Just want to make sure I understand you correctly.
>> + .num_resources = ARRAY_SIZE(axp288_power_button_resources),
>> + .resources = axp288_power_button_resources,
>> + },
>> + {
>> .name = "axp288_pmic_acpi",
>> },
>> };
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead Linaro.org â Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
ÿôèº{.nÇ+·®+%Ëÿ±éݶ\x17¥wÿº{.nÇ+·¥{±þG«éÿ{ayº\x1dÊÚë,j\a¢f£¢·hïêÿêçz_è®\x03(éÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?¨èÚ&£ø§~á¶iOæ¬z·vØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?I¥
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mfd: axp20x: Add a cell for the power button part of the,axp288 PMICs
2015-10-13 18:33 ` Yang, Fei
@ 2015-10-14 7:08 ` Lee Jones
2015-10-14 7:47 ` Borun Fu
0 siblings, 1 reply; 6+ messages in thread
From: Lee Jones @ 2015-10-14 7:08 UTC (permalink / raw)
To: Yang, Fei
Cc: Borun Fu, sameo, linux-kernel, Pallala, Ramakrishna, jacob.jun.pan
On Tue, 13 Oct 2015, Yang, Fei wrote:
> >> static struct resource axp288_fuel_gauge_resources[] = {
> >> {
> >> .start = AXP288_IRQ_QWBTU,
> >> @@ -572,6 +587,11 @@ static struct mfd_cell axp288_cells[] = {
> >> .resources = axp288_fuel_gauge_resources,
> >> },
> >> {
> >> + .name = "axp20x-pek", /* axp20x-pek works for AXP288 as well */
> >
> >Doesn't this change insinuate that?
> >
> >If axp20x-pek didn't work for AXP288 you wouldn't have put it in this structure right?
>
> Are you suggesting to remove the comment? Just want to make sure I understand you correctly.
I am.
> >> + .num_resources = ARRAY_SIZE(axp288_power_button_resources),
> >> + .resources = axp288_power_button_resources,
> >> + },
> >> + {
> >> .name = "axp288_pmic_acpi",
> >> },
> >> };
>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mfd: axp20x: Add a cell for the power button part of the,axp288 PMICs
2015-10-14 7:08 ` Lee Jones
@ 2015-10-14 7:47 ` Borun Fu
2015-10-14 8:00 ` Lee Jones
0 siblings, 1 reply; 6+ messages in thread
From: Borun Fu @ 2015-10-14 7:47 UTC (permalink / raw)
To: Lee Jones, Yang, Fei
Cc: sameo, linux-kernel, Pallala, Ramakrishna, jacob.jun.pan
So the patch will be refined to remove the comment as follows. Any else comments?
@@ -572,6 +587,11 @@ static struct mfd_cell axp288_cells[] = {
.resources = axp288_fuel_gauge_resources,
},
{
+ .name = "axp20x-pek",
+ .num_resources = ARRAY_SIZE(axp288_power_button_resources),
+ .resources = axp288_power_button_resources,
+ },
+ {
.name = "axp288_pmic_acpi",
},
};
On 10/14/2015 15:08, Lee Jones wrote:
> On Tue, 13 Oct 2015, Yang, Fei wrote:
>
>>>> static struct resource axp288_fuel_gauge_resources[] = {
>>>> {
>>>> .start = AXP288_IRQ_QWBTU,
>>>> @@ -572,6 +587,11 @@ static struct mfd_cell axp288_cells[] = {
>>>> .resources = axp288_fuel_gauge_resources,
>>>> },
>>>> {
>>>> + .name = "axp20x-pek", /* axp20x-pek works for AXP288 as well */
>>>
>>> Doesn't this change insinuate that?
>>>
>>> If axp20x-pek didn't work for AXP288 you wouldn't have put it in this structure right?
>>
>> Are you suggesting to remove the comment? Just want to make sure I understand you correctly.
>
> I am.
>
>>>> + .num_resources = ARRAY_SIZE(axp288_power_button_resources),
>>>> + .resources = axp288_power_button_resources,
>>>> + },
>>>> + {
>>>> .name = "axp288_pmic_acpi",
>>>> },
>>>> };
>>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mfd: axp20x: Add a cell for the power button part of the,axp288 PMICs
2015-10-14 7:47 ` Borun Fu
@ 2015-10-14 8:00 ` Lee Jones
0 siblings, 0 replies; 6+ messages in thread
From: Lee Jones @ 2015-10-14 8:00 UTC (permalink / raw)
To: Borun Fu
Cc: Yang, Fei, sameo, linux-kernel, Pallala, Ramakrishna, jacob.jun.pan
On Wed, 14 Oct 2015, Borun Fu wrote:
> So the patch will be refined to remove the comment as follows. Any
> else comments?
Please don't top post. If you have a comment about something that was
said, please make your comment directly _after_ it (a.k.a inline).
> @@ -572,6 +587,11 @@ static struct mfd_cell axp288_cells[] = {
> .resources = axp288_fuel_gauge_resources,
> },
> {
> + .name = "axp20x-pek",
> + .num_resources = ARRAY_SIZE(axp288_power_button_resources),
> + .resources = axp288_power_button_resources,
> + },
> + {
> .name = "axp288_pmic_acpi",
> },
> };
No need to do this. It doesn't save anyone any time.
Just resubmit the next version of the patch.
> On 10/14/2015 15:08, Lee Jones wrote:
> > On Tue, 13 Oct 2015, Yang, Fei wrote:
> >
> >>>> static struct resource axp288_fuel_gauge_resources[] = {
> >>>> {
> >>>> .start = AXP288_IRQ_QWBTU,
> >>>> @@ -572,6 +587,11 @@ static struct mfd_cell axp288_cells[] = {
> >>>> .resources = axp288_fuel_gauge_resources,
> >>>> },
> >>>> {
> >>>> + .name = "axp20x-pek", /* axp20x-pek works for AXP288 as well */
> >>>
> >>> Doesn't this change insinuate that?
> >>>
> >>> If axp20x-pek didn't work for AXP288 you wouldn't have put it in this structure right?
> >>
> >> Are you suggesting to remove the comment? Just want to make sure I understand you correctly.
> >
> > I am.
> >
> >>>> + .num_resources = ARRAY_SIZE(axp288_power_button_resources),
> >>>> + .resources = axp288_power_button_resources,
> >>>> + },
> >>>> + {
> >>>> .name = "axp288_pmic_acpi",
> >>>> },
> >>>> };
> >>
> >
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-10-14 8:00 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-10-12 7:16 [PATCH] mfd: axp20x: Add a cell for the power button part of the,axp288 PMICs Borun Fu
2015-10-13 8:11 ` Lee Jones
2015-10-13 18:33 ` Yang, Fei
2015-10-14 7:08 ` Lee Jones
2015-10-14 7:47 ` Borun Fu
2015-10-14 8:00 ` Lee Jones
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.