Re: [Xen-devel] [linux-3.14 bisection] complete test-amd64-i386-xl-qcow2

[David Vrabel <david.vrabel@citrix.com>]

On 12/10/15 13:56, Ben Hutchings wrote:
> On Mon, 2015-10-12 at 11:11 +0100, David Vrabel wrote:
>> On 08/10/15 23:14, Ben Hutchings wrote:
>>> On Wed, 2015-09-02 at 10:18 +0100, Ian Campbell wrote:
>>>> [resending to correct stable address, sorry folks]
>>>>
>>>> TL;DR: Any backport of 30b03d05e074 to earlier than commit 1401c00e59e
>>>> ("xen/gntdev: convert priv->lock to a mutex", which was added in v4.0)
>>>> needs $something doing to it, either s/mutex/spinlock/ or (more likely)
>>>> backporting of 1401c00e59e too.
>>>>
>>>> Looking at LTS:
>>>>
>>>> 3.18.y:> > > > 	> > > >   Backported both.
>>>> 3.16.y:> > > > 	> > > >   Has backported neither
>>>> 3.14.y:> > > > 	> > > > * Only backported 30b03d05e074
>>>> 3.12.y:> > > > 	> > > >   Has backported neither
>>>> 3.10.y:> > > > 	> > > > * Only backported 30b03d05e074
>>>> 3.4.y:> > > > 	> > > >   Has backported neither
>>>> 3.2.y:> > > > 	> > > >   Has backported neither
>>>>
>>>> So AFAICT 3.14.y and 3.10.y need fixes, probably following 3.18 and
>>>> backporting 1401c00e59e.
>>>>
>>>> 3.16/12/4/2 might need to be careful if they subsequently pick up 30b03d05.
>>> [...]
>>>
>>> I came up with the patch below for 3.2.  Let me know if it's not
>>> correct.
>>
>> Please just take commit 1401c00e59e instead.
> 
> I couldn't 'just' take that commit; it doesn't apply cleanly.  However
> I've backported it and changed 30b03d05e074 accordingly.  The two
> patches are attached for your review.

They look fine, thanks.

David