Re: [Qemu-devel] [PATCH 2/2] kvm/x86: Hyper-V kvm exit

From: Eric Blake <eblake@redhat.com>
To: "Denis V. Lunev" <den@openvz.org>
Cc: Gleb Natapov <gleb@kernel.org>,
	qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org,
	rkagan@virtuozzo.com, Andrey Smetanin <asmetanin@virtuozzo.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Vitaly Kuznetsov <vkuznets@redhat.com>,
	"K. Y. Srinivasan" <kys@microsoft.com>
Subject: Re: [Qemu-devel] [PATCH 2/2] kvm/x86: Hyper-V kvm exit
Date: Mon, 12 Oct 2015 07:44:28 -0600	[thread overview]
Message-ID: <561BB93C.9050409@redhat.com> (raw)
In-Reply-To: <561BB8D2.60402@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 921 bytes --]

On 10/12/2015 07:42 AM, Eric Blake wrote:
> On 10/09/2015 07:39 AM, Denis V. Lunev wrote:
>> From: Andrey Smetanin <asmetanin@virtuozzo.com>
>>
>> A new vcpu exit is introduced to notify the userspace of the
>> changes in Hyper-V synic configuraion triggered by guest writing to the
> 
> s/configuraion/configuration/
> Is 'synic' intended?  Is it short for something (if so, spelling it out
> may help)?

Ah, I see it now from patch 1/2: SYNthetic Interrupt Controller.

>> +related with Hyper-V emulation. Currently used to synchronize modified
>> +Hyper-V synic state with userspace.
> 
> Again, is 'synic' intended?  Hmm, I see it throughout the patch, so it
> looks intentional, but I keep trying to read it as a typo for 'sync'.

Don't know if SynIC would make it any easier to read?

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]