All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Roman Alyautdin <ralyautdin@dev.rtsoft.ru>, balbi@ti.com
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: musb: core: add common method of getting vbus status
Date: Mon, 12 Oct 2015 19:44:27 +0300	[thread overview]
Message-ID: <561BE36B.2000908@cogentembedded.com> (raw)
In-Reply-To: <1444659272-599-1-git-send-email-ralyautdin@dev.rtsoft.ru>

Hello.

On 10/12/2015 05:14 PM, Roman Alyautdin wrote:

> Fix musb_platform_get_vbus_status return value in case of platform
> implementation is not defined, bringing expected behaviour of
> musb_platform_get wrapper. Add musb_vbus_show default method to determine
> VBUS status in case platform method is not defined.
>
> Signed-off-by: Roman Alyautdin <ralyautdin@dev.rtsoft.ru>
> ---
>   drivers/usb/musb/musb_core.c |   13 ++++++++++---
>   drivers/usb/musb/musb_core.h |    2 +-
>   2 files changed, 11 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c
> index 4a518ff..3551540 100644
> --- a/drivers/usb/musb/musb_core.c
> +++ b/drivers/usb/musb/musb_core.c
> @@ -1771,13 +1771,20 @@ musb_vbus_show(struct device *dev, struct device_attribute *attr, char *buf)
>   	unsigned long	flags;
>   	unsigned long	val;
>   	int		vbus;
> +	u8		devctl;

    I'd add the variable to the block it's used in but this way is OK too.

[...]

MBR, Sergei


      reply	other threads:[~2015-10-12 16:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-12 13:59 [PATCH] usb: musb: core: add common method of getting vbus status Roman Alyautdin
2015-10-12 14:13 ` Roman Alyautdin
2015-10-12 14:14 ` Roman Alyautdin
2015-10-12 16:44   ` Sergei Shtylyov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=561BE36B.2000908@cogentembedded.com \
    --to=sergei.shtylyov@cogentembedded.com \
    --cc=balbi@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=ralyautdin@dev.rtsoft.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.