[PATCH] Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR. Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR.

[PATCH] Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR. Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR.

[Harman Kalra]

Signed-off-by: Harman Kalra <harman4linux@gmail.com>
---
 drivers/ata/pata_at91.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/ata/pata_at91.c b/drivers/ata/pata_at91.c
index 9f27b14..1611e0e 100644
--- a/drivers/ata/pata_at91.c
+++ b/drivers/ata/pata_at91.c
@@ -347,10 +347,8 @@ static int at91sam9_smc_fields_init(struct device *dev)
 
 	field.reg = AT91SAM9_SMC_MODE(AT91SAM9_SMC_GENERIC);
 	fields.mode = devm_regmap_field_alloc(dev, smc, field);
-	if (IS_ERR(fields.mode))
-		return PTR_ERR(fields.mode);
 
-	return 0;
+	return PTR_ERR_OR_ZERO(fields.mode);
 }
 
 static int pata_at91_probe(struct platform_device *pdev)
-- 
1.7.9.5

Re: [PATCH] Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR. Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR.

[Sergei Shtylyov]

Hello.

On 9/21/2016 10:48 PM, Harman Kalra wrote:

    Looks like your patch summary and description got merged together in the 
subject.

> Signed-off-by: Harman Kalra <harman4linux@gmail.com>
[...]

MBR, Sergei

Re: [PATCH] Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR. Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR.

[Sergei Shtylyov]

On 09/22/2016 01:44 PM, Sergei Shtylyov wrote:

>    Looks like your patch summary and description got merged together in the
> subject.

    Also, the subject (summary) should contain driver name as a prefix: 
"pata_at91: Use ..."

>> Signed-off-by: Harman Kalra <harman4linux@gmail.com>
> [...]

MBR, Sergei

Re: [PATCH] Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR. Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR.

[Tejun Heo]

On Thu, Sep 22, 2016 at 01:18:31AM +0530, Harman Kalra wrote:
> Signed-off-by: Harman Kalra <harman4linux@gmail.com>

Fixed up subject and applied to libata/for-4.9.

Thanks.

-- 
tejun