* [Qemu-devel] [PATCH v2 0/3] virtio-blk: no scsi-passthrough by default
@ 2015-10-16 10:25 Cornelia Huck
2015-10-16 10:25 ` [Qemu-devel] [PATCH v2 1/3] s390x: include HW_COMPAT_* props Cornelia Huck
` (4 more replies)
0 siblings, 5 replies; 14+ messages in thread
From: Cornelia Huck @ 2015-10-16 10:25 UTC (permalink / raw)
To: qemu-devel
Cc: kwolf, qemu-block, mst, jasowang, agraf, borntraeger, stefanha,
Cornelia Huck, pbonzini
Lightly tested on s390x.
Changes v1->v2:
- have the s390x compat hander include HW_COMPAT
- prepare the pseries 2.4 compat handler
- switch compat property at virtio-blk-device instead of the
transport level
Cornelia Huck (3):
s390x: include HW_COMPAT_* props
ppc/spapr: add 2.4 compat props
virtio-blk: switch off scsi-passthrough by default
hw/block/virtio-blk.c | 2 +-
hw/ppc/spapr.c | 9 +++++++++
hw/s390x/s390-virtio-ccw.c | 2 ++
include/hw/compat.h | 6 +++++-
4 files changed, 17 insertions(+), 2 deletions(-)
--
2.3.9
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Qemu-devel] [PATCH v2 1/3] s390x: include HW_COMPAT_* props
2015-10-16 10:25 [Qemu-devel] [PATCH v2 0/3] virtio-blk: no scsi-passthrough by default Cornelia Huck
@ 2015-10-16 10:25 ` Cornelia Huck
2015-10-16 10:30 ` Christian Borntraeger
2015-10-16 10:25 ` [Qemu-devel] [PATCH v2 2/3] ppc/spapr: add 2.4 compat props Cornelia Huck
` (3 subsequent siblings)
4 siblings, 1 reply; 14+ messages in thread
From: Cornelia Huck @ 2015-10-16 10:25 UTC (permalink / raw)
To: qemu-devel
Cc: kwolf, qemu-block, mst, jasowang, agraf, borntraeger, stefanha,
Cornelia Huck, pbonzini
We want to inherit generic hw compat as well.
Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
---
hw/s390x/s390-virtio-ccw.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c
index 20883ff..d09d867 100644
--- a/hw/s390x/s390-virtio-ccw.c
+++ b/hw/s390x/s390-virtio-ccw.c
@@ -20,6 +20,7 @@
#include "qemu/config-file.h"
#include "s390-pci-bus.h"
#include "hw/s390x/storage-keys.h"
+#include "hw/compat.h"
#define TYPE_S390_CCW_MACHINE "s390-ccw-machine"
@@ -236,6 +237,7 @@ static const TypeInfo ccw_machine_info = {
};
#define CCW_COMPAT_2_4 \
+ HW_COMPAT_2_4 \
{\
.driver = TYPE_S390_SKEYS,\
.property = "migration-enabled",\
--
2.3.9
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [Qemu-devel] [PATCH v2 2/3] ppc/spapr: add 2.4 compat props
2015-10-16 10:25 [Qemu-devel] [PATCH v2 0/3] virtio-blk: no scsi-passthrough by default Cornelia Huck
2015-10-16 10:25 ` [Qemu-devel] [PATCH v2 1/3] s390x: include HW_COMPAT_* props Cornelia Huck
@ 2015-10-16 10:25 ` Cornelia Huck
2015-10-16 10:25 ` [Qemu-devel] [PATCH v2 3/3] virtio-blk: switch off scsi-passthrough by default Cornelia Huck
` (2 subsequent siblings)
4 siblings, 0 replies; 14+ messages in thread
From: Cornelia Huck @ 2015-10-16 10:25 UTC (permalink / raw)
To: qemu-devel
Cc: kwolf, qemu-block, mst, jasowang, agraf, borntraeger, stefanha,
Cornelia Huck, pbonzini
HW_COMPAT_2_4 will become non-empty: prepare for it.
Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
---
hw/ppc/spapr.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
index d1b0e53..c216e2c 100644
--- a/hw/ppc/spapr.c
+++ b/hw/ppc/spapr.c
@@ -2224,7 +2224,11 @@ static const TypeInfo spapr_machine_info = {
},
};
+#define SPAPR_COMPAT_2_4 \
+ HW_COMPAT_2_4
+
#define SPAPR_COMPAT_2_3 \
+ SPAPR_COMPAT_2_4 \
HW_COMPAT_2_3 \
{\
.driver = "spapr-pci-host-bridge",\
@@ -2338,11 +2342,16 @@ static const TypeInfo spapr_machine_2_3_info = {
static void spapr_machine_2_4_class_init(ObjectClass *oc, void *data)
{
+ static GlobalProperty compat_props[] = {
+ SPAPR_COMPAT_2_4
+ { /* end of list */ }
+ };
MachineClass *mc = MACHINE_CLASS(oc);
mc->desc = "pSeries Logical Partition (PAPR compliant) v2.4";
mc->alias = "pseries";
mc->is_default = 0;
+ mc->compat_props = compat_props;
}
static const TypeInfo spapr_machine_2_4_info = {
--
2.3.9
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [Qemu-devel] [PATCH v2 3/3] virtio-blk: switch off scsi-passthrough by default
2015-10-16 10:25 [Qemu-devel] [PATCH v2 0/3] virtio-blk: no scsi-passthrough by default Cornelia Huck
2015-10-16 10:25 ` [Qemu-devel] [PATCH v2 1/3] s390x: include HW_COMPAT_* props Cornelia Huck
2015-10-16 10:25 ` [Qemu-devel] [PATCH v2 2/3] ppc/spapr: add 2.4 compat props Cornelia Huck
@ 2015-10-16 10:25 ` Cornelia Huck
2015-10-16 10:32 ` Christian Borntraeger
2015-10-16 12:40 ` [Qemu-devel] [PATCH v2 0/3] virtio-blk: no " Paolo Bonzini
2015-10-21 10:12 ` Stefan Hajnoczi
4 siblings, 1 reply; 14+ messages in thread
From: Cornelia Huck @ 2015-10-16 10:25 UTC (permalink / raw)
To: qemu-devel
Cc: kwolf, qemu-block, mst, jasowang, agraf, borntraeger, stefanha,
Cornelia Huck, pbonzini
Devices that are compliant with virtio-1 do not support scsi
passthrough any more (and it has not been a recommended setup
anyway for quite some time). To avoid having to switch it off
explicitly in newer qemus that turn on virtio-1 by default, let's
switch the default to scsi=false for 2.5.
Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
---
hw/block/virtio-blk.c | 2 +-
include/hw/compat.h | 6 +++++-
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c
index 8beb26b..999dbd7 100644
--- a/hw/block/virtio-blk.c
+++ b/hw/block/virtio-blk.c
@@ -975,7 +975,7 @@ static Property virtio_blk_properties[] = {
DEFINE_PROP_STRING("serial", VirtIOBlock, conf.serial),
DEFINE_PROP_BIT("config-wce", VirtIOBlock, conf.config_wce, 0, true),
#ifdef __linux__
- DEFINE_PROP_BIT("scsi", VirtIOBlock, conf.scsi, 0, true),
+ DEFINE_PROP_BIT("scsi", VirtIOBlock, conf.scsi, 0, false),
#endif
DEFINE_PROP_BIT("request-merging", VirtIOBlock, conf.request_merging, 0,
true),
diff --git a/include/hw/compat.h b/include/hw/compat.h
index 095de5d..93e71af 100644
--- a/include/hw/compat.h
+++ b/include/hw/compat.h
@@ -2,7 +2,11 @@
#define HW_COMPAT_H
#define HW_COMPAT_2_4 \
- /* empty */
+ {\
+ .driver = "virtio-blk-device",\
+ .property = "scsi",\
+ .value = "true",\
+ },
#define HW_COMPAT_2_3 \
{\
--
2.3.9
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [Qemu-devel] [PATCH v2 1/3] s390x: include HW_COMPAT_* props
2015-10-16 10:25 ` [Qemu-devel] [PATCH v2 1/3] s390x: include HW_COMPAT_* props Cornelia Huck
@ 2015-10-16 10:30 ` Christian Borntraeger
0 siblings, 0 replies; 14+ messages in thread
From: Christian Borntraeger @ 2015-10-16 10:30 UTC (permalink / raw)
To: Cornelia Huck, qemu-devel
Cc: kwolf, qemu-block, mst, jasowang, agraf, stefanha, pbonzini
Am 16.10.2015 um 12:25 schrieb Cornelia Huck:
> We want to inherit generic hw compat as well.
>
> Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
> ---
> hw/s390x/s390-virtio-ccw.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c
> index 20883ff..d09d867 100644
> --- a/hw/s390x/s390-virtio-ccw.c
> +++ b/hw/s390x/s390-virtio-ccw.c
> @@ -20,6 +20,7 @@
> #include "qemu/config-file.h"
> #include "s390-pci-bus.h"
> #include "hw/s390x/storage-keys.h"
> +#include "hw/compat.h"
>
> #define TYPE_S390_CCW_MACHINE "s390-ccw-machine"
>
> @@ -236,6 +237,7 @@ static const TypeInfo ccw_machine_info = {
> };
>
> #define CCW_COMPAT_2_4 \
> + HW_COMPAT_2_4 \
> {\
> .driver = TYPE_S390_SKEYS,\
> .property = "migration-enabled",\
>
Acked-by: Christian Borntraeger <borntraeger@de.ibm.com>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Qemu-devel] [PATCH v2 3/3] virtio-blk: switch off scsi-passthrough by default
2015-10-16 10:25 ` [Qemu-devel] [PATCH v2 3/3] virtio-blk: switch off scsi-passthrough by default Cornelia Huck
@ 2015-10-16 10:32 ` Christian Borntraeger
2015-10-16 10:44 ` Cornelia Huck
0 siblings, 1 reply; 14+ messages in thread
From: Christian Borntraeger @ 2015-10-16 10:32 UTC (permalink / raw)
To: Cornelia Huck, qemu-devel
Cc: kwolf, qemu-block, mst, jasowang, agraf, stefanha, pbonzini
Am 16.10.2015 um 12:25 schrieb Cornelia Huck:
> Devices that are compliant with virtio-1 do not support scsi
> passthrough any more (and it has not been a recommended setup
> anyway for quite some time). To avoid having to switch it off
> explicitly in newer qemus that turn on virtio-1 by default, let's
> switch the default to scsi=false for 2.5.
>
> Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
> ---
> hw/block/virtio-blk.c | 2 +-
> include/hw/compat.h | 6 +++++-
> 2 files changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c
> index 8beb26b..999dbd7 100644
> --- a/hw/block/virtio-blk.c
> +++ b/hw/block/virtio-blk.c
> @@ -975,7 +975,7 @@ static Property virtio_blk_properties[] = {
> DEFINE_PROP_STRING("serial", VirtIOBlock, conf.serial),
> DEFINE_PROP_BIT("config-wce", VirtIOBlock, conf.config_wce, 0, true),
> #ifdef __linux__
> - DEFINE_PROP_BIT("scsi", VirtIOBlock, conf.scsi, 0, true),
> + DEFINE_PROP_BIT("scsi", VirtIOBlock, conf.scsi, 0, false),
> #endif
> DEFINE_PROP_BIT("request-merging", VirtIOBlock, conf.request_merging, 0,
> true),
> diff --git a/include/hw/compat.h b/include/hw/compat.h
> index 095de5d..93e71af 100644
> --- a/include/hw/compat.h
> +++ b/include/hw/compat.h
> @@ -2,7 +2,11 @@
> #define HW_COMPAT_H
>
> #define HW_COMPAT_2_4 \
> - /* empty */
> + {\
> + .driver = "virtio-blk-device",\
> + .property = "scsi",\
> + .value = "true",\
does that work?
If yes, would it make sense to convert the things in HW_COMPAT_2_3 from
pci to device, e.g.
{\
- .driver = "virtio-blk-pci",\
+ .driver = "virtio-blk-device",\
.property = "any_layout",\
.value = "off",\
...
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Qemu-devel] [PATCH v2 3/3] virtio-blk: switch off scsi-passthrough by default
2015-10-16 10:32 ` Christian Borntraeger
@ 2015-10-16 10:44 ` Cornelia Huck
2015-10-16 11:07 ` Christian Borntraeger
0 siblings, 1 reply; 14+ messages in thread
From: Cornelia Huck @ 2015-10-16 10:44 UTC (permalink / raw)
To: Christian Borntraeger
Cc: kwolf, qemu-block, mst, jasowang, qemu-devel, agraf, stefanha, pbonzini
On Fri, 16 Oct 2015 12:32:52 +0200
Christian Borntraeger <borntraeger@de.ibm.com> wrote:
> Am 16.10.2015 um 12:25 schrieb Cornelia Huck:
> > Devices that are compliant with virtio-1 do not support scsi
> > passthrough any more (and it has not been a recommended setup
> > anyway for quite some time). To avoid having to switch it off
> > explicitly in newer qemus that turn on virtio-1 by default, let's
> > switch the default to scsi=false for 2.5.
> >
> > Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
> > ---
> > hw/block/virtio-blk.c | 2 +-
> > include/hw/compat.h | 6 +++++-
> > 2 files changed, 6 insertions(+), 2 deletions(-)
> >
> > diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c
> > index 8beb26b..999dbd7 100644
> > --- a/hw/block/virtio-blk.c
> > +++ b/hw/block/virtio-blk.c
> > @@ -975,7 +975,7 @@ static Property virtio_blk_properties[] = {
> > DEFINE_PROP_STRING("serial", VirtIOBlock, conf.serial),
> > DEFINE_PROP_BIT("config-wce", VirtIOBlock, conf.config_wce, 0, true),
> > #ifdef __linux__
> > - DEFINE_PROP_BIT("scsi", VirtIOBlock, conf.scsi, 0, true),
> > + DEFINE_PROP_BIT("scsi", VirtIOBlock, conf.scsi, 0, false),
> > #endif
> > DEFINE_PROP_BIT("request-merging", VirtIOBlock, conf.request_merging, 0,
> > true),
> > diff --git a/include/hw/compat.h b/include/hw/compat.h
> > index 095de5d..93e71af 100644
> > --- a/include/hw/compat.h
> > +++ b/include/hw/compat.h
> > @@ -2,7 +2,11 @@
> > #define HW_COMPAT_H
> >
> > #define HW_COMPAT_2_4 \
> > - /* empty */
> > + {\
> > + .driver = "virtio-blk-device",\
> > + .property = "scsi",\
> > + .value = "true",\
>
> does that work?
It did for me :)
>
> If yes, would it make sense to convert the things in HW_COMPAT_2_3 from
> pci to device, e.g.
>
>
> {\
> - .driver = "virtio-blk-pci",\
> + .driver = "virtio-blk-device",\
> .property = "any_layout",\
> .value = "off",\
> ...
Not sure: We don't have 2.3 compat for ccw... but would give a better
template for later changes.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Qemu-devel] [PATCH v2 3/3] virtio-blk: switch off scsi-passthrough by default
2015-10-16 10:44 ` Cornelia Huck
@ 2015-10-16 11:07 ` Christian Borntraeger
2015-10-18 7:59 ` Michael S. Tsirkin
0 siblings, 1 reply; 14+ messages in thread
From: Christian Borntraeger @ 2015-10-16 11:07 UTC (permalink / raw)
To: Cornelia Huck
Cc: kwolf, qemu-block, mst, jasowang, qemu-devel, agraf, stefanha, pbonzini
Am 16.10.2015 um 12:44 schrieb Cornelia Huck:
> On Fri, 16 Oct 2015 12:32:52 +0200
> Christian Borntraeger <borntraeger@de.ibm.com> wrote:
>
>> Am 16.10.2015 um 12:25 schrieb Cornelia Huck:
>>> Devices that are compliant with virtio-1 do not support scsi
>>> passthrough any more (and it has not been a recommended setup
>>> anyway for quite some time). To avoid having to switch it off
>>> explicitly in newer qemus that turn on virtio-1 by default, let's
>>> switch the default to scsi=false for 2.5.
>>>
>>> Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
>>> ---
>>> hw/block/virtio-blk.c | 2 +-
>>> include/hw/compat.h | 6 +++++-
>>> 2 files changed, 6 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c
>>> index 8beb26b..999dbd7 100644
>>> --- a/hw/block/virtio-blk.c
>>> +++ b/hw/block/virtio-blk.c
>>> @@ -975,7 +975,7 @@ static Property virtio_blk_properties[] = {
>>> DEFINE_PROP_STRING("serial", VirtIOBlock, conf.serial),
>>> DEFINE_PROP_BIT("config-wce", VirtIOBlock, conf.config_wce, 0, true),
>>> #ifdef __linux__
>>> - DEFINE_PROP_BIT("scsi", VirtIOBlock, conf.scsi, 0, true),
>>> + DEFINE_PROP_BIT("scsi", VirtIOBlock, conf.scsi, 0, false),
>>> #endif
>>> DEFINE_PROP_BIT("request-merging", VirtIOBlock, conf.request_merging, 0,
>>> true),
>>> diff --git a/include/hw/compat.h b/include/hw/compat.h
>>> index 095de5d..93e71af 100644
>>> --- a/include/hw/compat.h
>>> +++ b/include/hw/compat.h
>>> @@ -2,7 +2,11 @@
>>> #define HW_COMPAT_H
>>>
>>> #define HW_COMPAT_2_4 \
>>> - /* empty */
>>> + {\
>>> + .driver = "virtio-blk-device",\
>>> + .property = "scsi",\
>>> + .value = "true",\
>>
>> does that work?
>
> It did for me :)
>
>>
>> If yes, would it make sense to convert the things in HW_COMPAT_2_3 from
>> pci to device, e.g.
>>
>>
>> {\
>> - .driver = "virtio-blk-pci",\
>> + .driver = "virtio-blk-device",\
>> .property = "any_layout",\
>> .value = "off",\
>> ...
>
> Not sure: We don't have 2.3 compat for ccw... but would give a better
> template for later changes.
Yes. But this can be an addon patch.
Lets keep this patch as is to have scsi=off as default for virtio 1.0
(some iotests do fail because of this)
Christian
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Qemu-devel] [PATCH v2 0/3] virtio-blk: no scsi-passthrough by default
2015-10-16 10:25 [Qemu-devel] [PATCH v2 0/3] virtio-blk: no scsi-passthrough by default Cornelia Huck
` (2 preceding siblings ...)
2015-10-16 10:25 ` [Qemu-devel] [PATCH v2 3/3] virtio-blk: switch off scsi-passthrough by default Cornelia Huck
@ 2015-10-16 12:40 ` Paolo Bonzini
2015-10-21 10:12 ` Stefan Hajnoczi
4 siblings, 0 replies; 14+ messages in thread
From: Paolo Bonzini @ 2015-10-16 12:40 UTC (permalink / raw)
To: Cornelia Huck, qemu-devel
Cc: kwolf, qemu-block, mst, jasowang, agraf, borntraeger, stefanha
On 16/10/2015 12:25, Cornelia Huck wrote:
> Lightly tested on s390x.
>
> Changes v1->v2:
> - have the s390x compat hander include HW_COMPAT
> - prepare the pseries 2.4 compat handler
> - switch compat property at virtio-blk-device instead of the
> transport level
>
> Cornelia Huck (3):
> s390x: include HW_COMPAT_* props
> ppc/spapr: add 2.4 compat props
> virtio-blk: switch off scsi-passthrough by default
>
> hw/block/virtio-blk.c | 2 +-
> hw/ppc/spapr.c | 9 +++++++++
> hw/s390x/s390-virtio-ccw.c | 2 ++
> include/hw/compat.h | 6 +++++-
> 4 files changed, 17 insertions(+), 2 deletions(-)
>
Thanks! It all looks good.
Paolo
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Qemu-devel] [PATCH v2 3/3] virtio-blk: switch off scsi-passthrough by default
2015-10-16 11:07 ` Christian Borntraeger
@ 2015-10-18 7:59 ` Michael S. Tsirkin
2015-10-19 11:53 ` Cornelia Huck
0 siblings, 1 reply; 14+ messages in thread
From: Michael S. Tsirkin @ 2015-10-18 7:59 UTC (permalink / raw)
To: Christian Borntraeger
Cc: kwolf, qemu-block, jasowang, qemu-devel, agraf, stefanha,
Cornelia Huck, pbonzini
On Fri, Oct 16, 2015 at 01:07:28PM +0200, Christian Borntraeger wrote:
> Am 16.10.2015 um 12:44 schrieb Cornelia Huck:
> > On Fri, 16 Oct 2015 12:32:52 +0200
> > Christian Borntraeger <borntraeger@de.ibm.com> wrote:
> >
> >> Am 16.10.2015 um 12:25 schrieb Cornelia Huck:
> >>> Devices that are compliant with virtio-1 do not support scsi
> >>> passthrough any more (and it has not been a recommended setup
> >>> anyway for quite some time). To avoid having to switch it off
> >>> explicitly in newer qemus that turn on virtio-1 by default, let's
> >>> switch the default to scsi=false for 2.5.
> >>>
> >>> Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
> >>> ---
> >>> hw/block/virtio-blk.c | 2 +-
> >>> include/hw/compat.h | 6 +++++-
> >>> 2 files changed, 6 insertions(+), 2 deletions(-)
> >>>
> >>> diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c
> >>> index 8beb26b..999dbd7 100644
> >>> --- a/hw/block/virtio-blk.c
> >>> +++ b/hw/block/virtio-blk.c
> >>> @@ -975,7 +975,7 @@ static Property virtio_blk_properties[] = {
> >>> DEFINE_PROP_STRING("serial", VirtIOBlock, conf.serial),
> >>> DEFINE_PROP_BIT("config-wce", VirtIOBlock, conf.config_wce, 0, true),
> >>> #ifdef __linux__
> >>> - DEFINE_PROP_BIT("scsi", VirtIOBlock, conf.scsi, 0, true),
> >>> + DEFINE_PROP_BIT("scsi", VirtIOBlock, conf.scsi, 0, false),
> >>> #endif
> >>> DEFINE_PROP_BIT("request-merging", VirtIOBlock, conf.request_merging, 0,
> >>> true),
> >>> diff --git a/include/hw/compat.h b/include/hw/compat.h
> >>> index 095de5d..93e71af 100644
> >>> --- a/include/hw/compat.h
> >>> +++ b/include/hw/compat.h
> >>> @@ -2,7 +2,11 @@
> >>> #define HW_COMPAT_H
> >>>
> >>> #define HW_COMPAT_2_4 \
> >>> - /* empty */
> >>> + {\
> >>> + .driver = "virtio-blk-device",\
> >>> + .property = "scsi",\
> >>> + .value = "true",\
> >>
> >> does that work?
> >
> > It did for me :)
> >
> >>
> >> If yes, would it make sense to convert the things in HW_COMPAT_2_3 from
> >> pci to device, e.g.
> >>
> >>
> >> {\
> >> - .driver = "virtio-blk-pci",\
> >> + .driver = "virtio-blk-device",\
> >> .property = "any_layout",\
> >> .value = "off",\
> >> ...
> >
> > Not sure: We don't have 2.3 compat for ccw... but would give a better
> > template for later changes.
>
> Yes. But this can be an addon patch.
>
> Lets keep this patch as is to have scsi=off as default for virtio 1.0
>
> (some iotests do fail because of this)
>
> Christian
What fails, exactly?
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Qemu-devel] [PATCH v2 3/3] virtio-blk: switch off scsi-passthrough by default
2015-10-18 7:59 ` Michael S. Tsirkin
@ 2015-10-19 11:53 ` Cornelia Huck
2015-10-19 11:57 ` Michael S. Tsirkin
0 siblings, 1 reply; 14+ messages in thread
From: Cornelia Huck @ 2015-10-19 11:53 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: kwolf, qemu-block, jasowang, qemu-devel, agraf,
Christian Borntraeger, stefanha, pbonzini
On Sun, 18 Oct 2015 10:59:59 +0300
"Michael S. Tsirkin" <mst@redhat.com> wrote:
> On Fri, Oct 16, 2015 at 01:07:28PM +0200, Christian Borntraeger wrote:
> > Lets keep this patch as is to have scsi=off as default for virtio 1.0
> >
> > (some iotests do fail because of this)
> >
> > Christian
>
> What fails, exactly?
For example, testcase 068 (on s390x, since we default virtio-1 to on):
--- /data/git/yyy/qemu/tests/qemu-iotests/068.out 2015-03-09 12:32:35.245444052 +0100
+++ 068.out.bad 2015-10-19 13:48:00.023772655 +0200
@@ -3,9 +3,8 @@
=== Saving and reloading a VM state to/from a qcow2 image ===
Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=131072
+qemu-system-s390x: -hda /data/git/yyy/qemu/build/tests/qemu-iotests/scratch/t.qcow2: Please set scsi=off for virtio-blk devices in order to use virtio 1.0
QEMU X.Y.Z monitor - type 'help' for more information
-(qemu) savevm 0
-(qemu) quit
+(qemu) qemu-system-s390x: -hda /data/git/yyy/qemu/build/tests/qemu-iotests/scratch/t.qcow2: Please set scsi=off for virtio-blk devices in order to use virtio 1.0
QEMU X.Y.Z monitor - type 'help' for more information
-(qemu) quit
-*** done
+(qemu) *** done
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Qemu-devel] [PATCH v2 3/3] virtio-blk: switch off scsi-passthrough by default
2015-10-19 11:53 ` Cornelia Huck
@ 2015-10-19 11:57 ` Michael S. Tsirkin
2015-10-19 12:21 ` Cornelia Huck
0 siblings, 1 reply; 14+ messages in thread
From: Michael S. Tsirkin @ 2015-10-19 11:57 UTC (permalink / raw)
To: Cornelia Huck
Cc: kwolf, qemu-block, jasowang, qemu-devel, agraf,
Christian Borntraeger, stefanha, pbonzini
On Mon, Oct 19, 2015 at 01:53:50PM +0200, Cornelia Huck wrote:
> On Sun, 18 Oct 2015 10:59:59 +0300
> "Michael S. Tsirkin" <mst@redhat.com> wrote:
>
> > On Fri, Oct 16, 2015 at 01:07:28PM +0200, Christian Borntraeger wrote:
>
> > > Lets keep this patch as is to have scsi=off as default for virtio 1.0
> > >
> > > (some iotests do fail because of this)
> > >
> > > Christian
> >
> > What fails, exactly?
>
> For example, testcase 068 (on s390x, since we default virtio-1 to on):
I see, thanks.
So it's just the assertion that we have in code that fires.
Sure, scsi must be off by default before virtio 1 is on.
> --- /data/git/yyy/qemu/tests/qemu-iotests/068.out 2015-03-09 12:32:35.245444052 +0100
> +++ 068.out.bad 2015-10-19 13:48:00.023772655 +0200
> @@ -3,9 +3,8 @@
> === Saving and reloading a VM state to/from a qcow2 image ===
>
> Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=131072
> +qemu-system-s390x: -hda /data/git/yyy/qemu/build/tests/qemu-iotests/scratch/t.qcow2: Please set scsi=off for virtio-blk devices in order to use virtio 1.0
> QEMU X.Y.Z monitor - type 'help' for more information
> -(qemu) savevm 0
> -(qemu) quit
> +(qemu) qemu-system-s390x: -hda /data/git/yyy/qemu/build/tests/qemu-iotests/scratch/t.qcow2: Please set scsi=off for virtio-blk devices in order to use virtio 1.0
> QEMU X.Y.Z monitor - type 'help' for more information
> -(qemu) quit
> -*** done
> +(qemu) *** done
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Qemu-devel] [PATCH v2 3/3] virtio-blk: switch off scsi-passthrough by default
2015-10-19 11:57 ` Michael S. Tsirkin
@ 2015-10-19 12:21 ` Cornelia Huck
0 siblings, 0 replies; 14+ messages in thread
From: Cornelia Huck @ 2015-10-19 12:21 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: kwolf, qemu-block, jasowang, qemu-devel, agraf,
Christian Borntraeger, stefanha, pbonzini
On Mon, 19 Oct 2015 14:57:31 +0300
"Michael S. Tsirkin" <mst@redhat.com> wrote:
> On Mon, Oct 19, 2015 at 01:53:50PM +0200, Cornelia Huck wrote:
> > On Sun, 18 Oct 2015 10:59:59 +0300
> > "Michael S. Tsirkin" <mst@redhat.com> wrote:
> >
> > > On Fri, Oct 16, 2015 at 01:07:28PM +0200, Christian Borntraeger wrote:
> >
> > > > Lets keep this patch as is to have scsi=off as default for virtio 1.0
> > > >
> > > > (some iotests do fail because of this)
> > > >
> > > > Christian
> > >
> > > What fails, exactly?
> >
> > For example, testcase 068 (on s390x, since we default virtio-1 to on):
>
> I see, thanks.
> So it's just the assertion that we have in code that fires.
> Sure, scsi must be off by default before virtio 1 is on.
And -hda always assumes defaults...
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Qemu-devel] [PATCH v2 0/3] virtio-blk: no scsi-passthrough by default
2015-10-16 10:25 [Qemu-devel] [PATCH v2 0/3] virtio-blk: no scsi-passthrough by default Cornelia Huck
` (3 preceding siblings ...)
2015-10-16 12:40 ` [Qemu-devel] [PATCH v2 0/3] virtio-blk: no " Paolo Bonzini
@ 2015-10-21 10:12 ` Stefan Hajnoczi
4 siblings, 0 replies; 14+ messages in thread
From: Stefan Hajnoczi @ 2015-10-21 10:12 UTC (permalink / raw)
To: Cornelia Huck
Cc: kwolf, qemu-block, mst, jasowang, qemu-devel, agraf, borntraeger,
pbonzini
On Fri, Oct 16, 2015 at 12:25:51PM +0200, Cornelia Huck wrote:
> Lightly tested on s390x.
>
> Changes v1->v2:
> - have the s390x compat hander include HW_COMPAT
> - prepare the pseries 2.4 compat handler
> - switch compat property at virtio-blk-device instead of the
> transport level
>
> Cornelia Huck (3):
> s390x: include HW_COMPAT_* props
> ppc/spapr: add 2.4 compat props
> virtio-blk: switch off scsi-passthrough by default
>
> hw/block/virtio-blk.c | 2 +-
> hw/ppc/spapr.c | 9 +++++++++
> hw/s390x/s390-virtio-ccw.c | 2 ++
> include/hw/compat.h | 6 +++++-
> 4 files changed, 17 insertions(+), 2 deletions(-)
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2015-10-21 10:12 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-10-16 10:25 [Qemu-devel] [PATCH v2 0/3] virtio-blk: no scsi-passthrough by default Cornelia Huck
2015-10-16 10:25 ` [Qemu-devel] [PATCH v2 1/3] s390x: include HW_COMPAT_* props Cornelia Huck
2015-10-16 10:30 ` Christian Borntraeger
2015-10-16 10:25 ` [Qemu-devel] [PATCH v2 2/3] ppc/spapr: add 2.4 compat props Cornelia Huck
2015-10-16 10:25 ` [Qemu-devel] [PATCH v2 3/3] virtio-blk: switch off scsi-passthrough by default Cornelia Huck
2015-10-16 10:32 ` Christian Borntraeger
2015-10-16 10:44 ` Cornelia Huck
2015-10-16 11:07 ` Christian Borntraeger
2015-10-18 7:59 ` Michael S. Tsirkin
2015-10-19 11:53 ` Cornelia Huck
2015-10-19 11:57 ` Michael S. Tsirkin
2015-10-19 12:21 ` Cornelia Huck
2015-10-16 12:40 ` [Qemu-devel] [PATCH v2 0/3] virtio-blk: no " Paolo Bonzini
2015-10-21 10:12 ` Stefan Hajnoczi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.