* [PATCH v4] iio: mma8452: support either of the available interrupt pins
@ 2015-10-15 13:10 Martin Kepplinger
2015-10-20 11:03 ` Martin Kepplinger
2015-10-22 18:22 ` Rob Herring
0 siblings, 2 replies; 10+ messages in thread
From: Martin Kepplinger @ 2015-10-15 13:10 UTC (permalink / raw)
To: robh+dt, pawel.moll, mark.rutland, ijc+devicetree, galak, jic23,
knaack.h, lars, pmeerw, mfuzzey
Cc: devicetree, linux-kernel, linux-iio, Martin Kepplinger,
Martin Kepplinger
This change is important in order for everyone to be easily able to use the
driver for one of the supported accelerometer chips!
Until now, the driver blindly assumed that the INT1 interrupt line is wired
on a user's board. But these devices have 2 interrupt lines and can route
their interrupt sources to one of them. Now, if "INT2" is found and matches
i2c_client->irq, INT2 will be used.
The chip's default actually is INT2, which is why probably many boards will
have it wired and can make use of this.
Of course, this also falls back to assuming INT1, so for existing users
nothing will break. The new functionality is described in the bindings doc.
Signed-off-by: Martin Kepplinger <martin.kepplinger@theobroma-systems.com>
---
changelog:
v4: use irq that matches client->irq, backwards compatible
v3: correctly assign irq if both pins are described in DT
v2: don't warn but normally handle if both pins are described in dts
thanks Mark Rutland
v1: initial post
.../devicetree/bindings/iio/accel/mma8452.txt | 6 ++++++
drivers/iio/accel/mma8452.c | 21 +++++++++++++++------
2 files changed, 21 insertions(+), 6 deletions(-)
diff --git a/Documentation/devicetree/bindings/iio/accel/mma8452.txt b/Documentation/devicetree/bindings/iio/accel/mma8452.txt
index e3c3746..3c10e85 100644
--- a/Documentation/devicetree/bindings/iio/accel/mma8452.txt
+++ b/Documentation/devicetree/bindings/iio/accel/mma8452.txt
@@ -7,13 +7,18 @@ Required properties:
* "fsl,mma8453"
* "fsl,mma8652"
* "fsl,mma8653"
+
- reg: the I2C address of the chip
Optional properties:
- interrupt-parent: should be the phandle for the interrupt controller
+
- interrupts: interrupt mapping for GPIO IRQ
+ - interrupt-names: should contain "INT1" and/or "INT2", the accelerometer's
+ interrupt line in use.
+
Example:
mma8453fc@1d {
@@ -21,4 +26,5 @@ Example:
reg = <0x1d>;
interrupt-parent = <&gpio1>;
interrupts = <5 0>;
+ interrupt-names = "INT2";
};
diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c
index 1eccc2d..116a6e4 100644
--- a/drivers/iio/accel/mma8452.c
+++ b/drivers/iio/accel/mma8452.c
@@ -29,6 +29,7 @@
#include <linux/iio/events.h>
#include <linux/delay.h>
#include <linux/of_device.h>
+#include <linux/of_irq.h>
#define MMA8452_STATUS 0x00
#define MMA8452_STATUS_DRDY (BIT(2) | BIT(1) | BIT(0))
@@ -1130,13 +1131,21 @@ static int mma8452_probe(struct i2c_client *client,
MMA8452_INT_FF_MT;
int enabled_interrupts = MMA8452_INT_TRANS |
MMA8452_INT_FF_MT;
+ int irq2;
- /* Assume wired to INT1 pin */
- ret = i2c_smbus_write_byte_data(client,
- MMA8452_CTRL_REG5,
- supported_interrupts);
- if (ret < 0)
- return ret;
+ irq2 = of_irq_get_byname(client->dev.of_node, "INT2");
+
+ if (irq2 == client->irq) {
+ dev_dbg(&client->dev, "using interrupt line INT2\n");
+ } else {
+ ret = i2c_smbus_write_byte_data(client,
+ MMA8452_CTRL_REG5,
+ supported_interrupts);
+ if (ret < 0)
+ return ret;
+
+ dev_dbg(&client->dev, "using interrupt line INT1\n");
+ }
ret = i2c_smbus_write_byte_data(client,
MMA8452_CTRL_REG4,
--
2.1.4
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH v4] iio: mma8452: support either of the available interrupt pins
@ 2015-10-20 11:03 ` Martin Kepplinger
0 siblings, 0 replies; 10+ messages in thread
From: Martin Kepplinger @ 2015-10-20 11:03 UTC (permalink / raw)
To: robh+dt, pawel.moll, mark.rutland, ijc+devicetree, galak, jic23,
knaack.h, lars, pmeerw, mfuzzey
Cc: devicetree, linux-kernel, linux-iio, Martin Kepplinger
Am 2015-10-15 um 15:10 schrieb Martin Kepplinger:
> This change is important in order for everyone to be easily able to use the
> driver for one of the supported accelerometer chips!
>
> Until now, the driver blindly assumed that the INT1 interrupt line is wired
> on a user's board. But these devices have 2 interrupt lines and can route
> their interrupt sources to one of them. Now, if "INT2" is found and matches
> i2c_client->irq, INT2 will be used.
>
> The chip's default actually is INT2, which is why probably many boards will
> have it wired and can make use of this.
>
> Of course, this also falls back to assuming INT1, so for existing users
> nothing will break. The new functionality is described in the bindings doc.
>
> Signed-off-by: Martin Kepplinger <martin.kepplinger@theobroma-systems.com>
> ---
> changelog:
> v4: use irq that matches client->irq, backwards compatible
> v3: correctly assign irq if both pins are described in DT
> v2: don't warn but normally handle if both pins are described in dts
> thanks Mark Rutland
> v1: initial post
>
> .../devicetree/bindings/iio/accel/mma8452.txt | 6 ++++++
> drivers/iio/accel/mma8452.c | 21 +++++++++++++++------
> 2 files changed, 21 insertions(+), 6 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/iio/accel/mma8452.txt b/Documentation/devicetree/bindings/iio/accel/mma8452.txt
> index e3c3746..3c10e85 100644
> --- a/Documentation/devicetree/bindings/iio/accel/mma8452.txt
> +++ b/Documentation/devicetree/bindings/iio/accel/mma8452.txt
> @@ -7,13 +7,18 @@ Required properties:
> * "fsl,mma8453"
> * "fsl,mma8652"
> * "fsl,mma8653"
> +
> - reg: the I2C address of the chip
>
> Optional properties:
>
> - interrupt-parent: should be the phandle for the interrupt controller
> +
> - interrupts: interrupt mapping for GPIO IRQ
>
> + - interrupt-names: should contain "INT1" and/or "INT2", the accelerometer's
> + interrupt line in use.
> +
> Example:
>
> mma8453fc@1d {
> @@ -21,4 +26,5 @@ Example:
> reg = <0x1d>;
> interrupt-parent = <&gpio1>;
> interrupts = <5 0>;
> + interrupt-names = "INT2";
> };
> diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c
> index 1eccc2d..116a6e4 100644
> --- a/drivers/iio/accel/mma8452.c
> +++ b/drivers/iio/accel/mma8452.c
> @@ -29,6 +29,7 @@
> #include <linux/iio/events.h>
> #include <linux/delay.h>
> #include <linux/of_device.h>
> +#include <linux/of_irq.h>
>
> #define MMA8452_STATUS 0x00
> #define MMA8452_STATUS_DRDY (BIT(2) | BIT(1) | BIT(0))
> @@ -1130,13 +1131,21 @@ static int mma8452_probe(struct i2c_client *client,
> MMA8452_INT_FF_MT;
> int enabled_interrupts = MMA8452_INT_TRANS |
> MMA8452_INT_FF_MT;
> + int irq2;
>
> - /* Assume wired to INT1 pin */
> - ret = i2c_smbus_write_byte_data(client,
> - MMA8452_CTRL_REG5,
> - supported_interrupts);
> - if (ret < 0)
> - return ret;
> + irq2 = of_irq_get_byname(client->dev.of_node, "INT2");
> +
> + if (irq2 == client->irq) {
> + dev_dbg(&client->dev, "using interrupt line INT2\n");
> + } else {
> + ret = i2c_smbus_write_byte_data(client,
> + MMA8452_CTRL_REG5,
> + supported_interrupts);
> + if (ret < 0)
> + return ret;
> +
> + dev_dbg(&client->dev, "using interrupt line INT1\n");
> + }
>
> ret = i2c_smbus_write_byte_data(client,
> MMA8452_CTRL_REG4,
>
This works fine and would be convenient to have. Any objections?
thanks
martin
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v4] iio: mma8452: support either of the available interrupt pins
@ 2015-10-20 11:03 ` Martin Kepplinger
0 siblings, 0 replies; 10+ messages in thread
From: Martin Kepplinger @ 2015-10-20 11:03 UTC (permalink / raw)
To: robh+dt-DgEjT+Ai2ygdnm+yROfE0A, pawel.moll-5wv7dgnIgG8,
mark.rutland-5wv7dgnIgG8, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg,
galak-sgV2jX0FEOL9JmXXK+q4OQ, jic23-DgEjT+Ai2ygdnm+yROfE0A,
knaack.h-Mmb7MZpHnFY, lars-Qo5EllUWu/uELgA04lAiVw,
pmeerw-jW+XmwGofnusTnJN9+BGXg, mfuzzey-mB3Nsq4MPf1BDgjK7y7TUQ
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-iio-u79uwXL29TY76Z2rM5mHXA, Martin Kepplinger
Am 2015-10-15 um 15:10 schrieb Martin Kepplinger:
> This change is important in order for everyone to be easily able to use the
> driver for one of the supported accelerometer chips!
>
> Until now, the driver blindly assumed that the INT1 interrupt line is wired
> on a user's board. But these devices have 2 interrupt lines and can route
> their interrupt sources to one of them. Now, if "INT2" is found and matches
> i2c_client->irq, INT2 will be used.
>
> The chip's default actually is INT2, which is why probably many boards will
> have it wired and can make use of this.
>
> Of course, this also falls back to assuming INT1, so for existing users
> nothing will break. The new functionality is described in the bindings doc.
>
> Signed-off-by: Martin Kepplinger <martin.kepplinger-SN7IsUiht6C/RdPyistoZJqQE7yCjDx5@public.gmane.org>
> ---
> changelog:
> v4: use irq that matches client->irq, backwards compatible
> v3: correctly assign irq if both pins are described in DT
> v2: don't warn but normally handle if both pins are described in dts
> thanks Mark Rutland
> v1: initial post
>
> .../devicetree/bindings/iio/accel/mma8452.txt | 6 ++++++
> drivers/iio/accel/mma8452.c | 21 +++++++++++++++------
> 2 files changed, 21 insertions(+), 6 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/iio/accel/mma8452.txt b/Documentation/devicetree/bindings/iio/accel/mma8452.txt
> index e3c3746..3c10e85 100644
> --- a/Documentation/devicetree/bindings/iio/accel/mma8452.txt
> +++ b/Documentation/devicetree/bindings/iio/accel/mma8452.txt
> @@ -7,13 +7,18 @@ Required properties:
> * "fsl,mma8453"
> * "fsl,mma8652"
> * "fsl,mma8653"
> +
> - reg: the I2C address of the chip
>
> Optional properties:
>
> - interrupt-parent: should be the phandle for the interrupt controller
> +
> - interrupts: interrupt mapping for GPIO IRQ
>
> + - interrupt-names: should contain "INT1" and/or "INT2", the accelerometer's
> + interrupt line in use.
> +
> Example:
>
> mma8453fc@1d {
> @@ -21,4 +26,5 @@ Example:
> reg = <0x1d>;
> interrupt-parent = <&gpio1>;
> interrupts = <5 0>;
> + interrupt-names = "INT2";
> };
> diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c
> index 1eccc2d..116a6e4 100644
> --- a/drivers/iio/accel/mma8452.c
> +++ b/drivers/iio/accel/mma8452.c
> @@ -29,6 +29,7 @@
> #include <linux/iio/events.h>
> #include <linux/delay.h>
> #include <linux/of_device.h>
> +#include <linux/of_irq.h>
>
> #define MMA8452_STATUS 0x00
> #define MMA8452_STATUS_DRDY (BIT(2) | BIT(1) | BIT(0))
> @@ -1130,13 +1131,21 @@ static int mma8452_probe(struct i2c_client *client,
> MMA8452_INT_FF_MT;
> int enabled_interrupts = MMA8452_INT_TRANS |
> MMA8452_INT_FF_MT;
> + int irq2;
>
> - /* Assume wired to INT1 pin */
> - ret = i2c_smbus_write_byte_data(client,
> - MMA8452_CTRL_REG5,
> - supported_interrupts);
> - if (ret < 0)
> - return ret;
> + irq2 = of_irq_get_byname(client->dev.of_node, "INT2");
> +
> + if (irq2 == client->irq) {
> + dev_dbg(&client->dev, "using interrupt line INT2\n");
> + } else {
> + ret = i2c_smbus_write_byte_data(client,
> + MMA8452_CTRL_REG5,
> + supported_interrupts);
> + if (ret < 0)
> + return ret;
> +
> + dev_dbg(&client->dev, "using interrupt line INT1\n");
> + }
>
> ret = i2c_smbus_write_byte_data(client,
> MMA8452_CTRL_REG4,
>
This works fine and would be convenient to have. Any objections?
thanks
martin
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v4] iio: mma8452: support either of the available interrupt pins
2015-10-20 11:03 ` Martin Kepplinger
(?)
@ 2015-10-22 15:22 ` Martin Kepplinger
-1 siblings, 0 replies; 10+ messages in thread
From: Martin Kepplinger @ 2015-10-22 15:22 UTC (permalink / raw)
To: robh+dt, pawel.moll, mark.rutland, ijc+devicetree, galak, jic23,
knaack.h, lars, pmeerw, mfuzzey
Cc: devicetree, linux-kernel, linux-iio, Martin Kepplinger
Am 2015-10-20 um 13:03 schrieb Martin Kepplinger:
> Am 2015-10-15 um 15:10 schrieb Martin Kepplinger:
>> This change is important in order for everyone to be easily able to use the
>> driver for one of the supported accelerometer chips!
>>
>> Until now, the driver blindly assumed that the INT1 interrupt line is wired
>> on a user's board. But these devices have 2 interrupt lines and can route
>> their interrupt sources to one of them. Now, if "INT2" is found and matches
>> i2c_client->irq, INT2 will be used.
>>
>> The chip's default actually is INT2, which is why probably many boards will
>> have it wired and can make use of this.
>>
>> Of course, this also falls back to assuming INT1, so for existing users
>> nothing will break. The new functionality is described in the bindings doc.
>>
>> Signed-off-by: Martin Kepplinger <martin.kepplinger@theobroma-systems.com>
>> ---
>> changelog:
>> v4: use irq that matches client->irq, backwards compatible
>> v3: correctly assign irq if both pins are described in DT
>> v2: don't warn but normally handle if both pins are described in dts
>> thanks Mark Rutland
>> v1: initial post
>>
>> .../devicetree/bindings/iio/accel/mma8452.txt | 6 ++++++
>> drivers/iio/accel/mma8452.c | 21 +++++++++++++++------
>> 2 files changed, 21 insertions(+), 6 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/iio/accel/mma8452.txt b/Documentation/devicetree/bindings/iio/accel/mma8452.txt
>> index e3c3746..3c10e85 100644
>> --- a/Documentation/devicetree/bindings/iio/accel/mma8452.txt
>> +++ b/Documentation/devicetree/bindings/iio/accel/mma8452.txt
>> @@ -7,13 +7,18 @@ Required properties:
>> * "fsl,mma8453"
>> * "fsl,mma8652"
>> * "fsl,mma8653"
>> +
>> - reg: the I2C address of the chip
>>
>> Optional properties:
>>
>> - interrupt-parent: should be the phandle for the interrupt controller
>> +
>> - interrupts: interrupt mapping for GPIO IRQ
>>
>> + - interrupt-names: should contain "INT1" and/or "INT2", the accelerometer's
>> + interrupt line in use.
>> +
>> Example:
>>
>> mma8453fc@1d {
>> @@ -21,4 +26,5 @@ Example:
>> reg = <0x1d>;
>> interrupt-parent = <&gpio1>;
>> interrupts = <5 0>;
>> + interrupt-names = "INT2";
>> };
>> diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c
>> index 1eccc2d..116a6e4 100644
>> --- a/drivers/iio/accel/mma8452.c
>> +++ b/drivers/iio/accel/mma8452.c
>> @@ -29,6 +29,7 @@
>> #include <linux/iio/events.h>
>> #include <linux/delay.h>
>> #include <linux/of_device.h>
>> +#include <linux/of_irq.h>
>>
>> #define MMA8452_STATUS 0x00
>> #define MMA8452_STATUS_DRDY (BIT(2) | BIT(1) | BIT(0))
>> @@ -1130,13 +1131,21 @@ static int mma8452_probe(struct i2c_client *client,
>> MMA8452_INT_FF_MT;
>> int enabled_interrupts = MMA8452_INT_TRANS |
>> MMA8452_INT_FF_MT;
>> + int irq2;
>>
>> - /* Assume wired to INT1 pin */
>> - ret = i2c_smbus_write_byte_data(client,
>> - MMA8452_CTRL_REG5,
>> - supported_interrupts);
>> - if (ret < 0)
>> - return ret;
>> + irq2 = of_irq_get_byname(client->dev.of_node, "INT2");
>> +
>> + if (irq2 == client->irq) {
>> + dev_dbg(&client->dev, "using interrupt line INT2\n");
>> + } else {
>> + ret = i2c_smbus_write_byte_data(client,
>> + MMA8452_CTRL_REG5,
>> + supported_interrupts);
>> + if (ret < 0)
>> + return ret;
>> +
>> + dev_dbg(&client->dev, "using interrupt line INT1\n");
>> + }
>>
>> ret = i2c_smbus_write_byte_data(client,
>> MMA8452_CTRL_REG4,
>>
>
> This works fine and would be convenient to have. Any objections?
>
> thanks
> martin
yes, no, maybe?
thanks
martin
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v4] iio: mma8452: support either of the available interrupt pins
@ 2015-10-22 18:22 ` Rob Herring
0 siblings, 0 replies; 10+ messages in thread
From: Rob Herring @ 2015-10-22 18:22 UTC (permalink / raw)
To: Martin Kepplinger
Cc: Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala,
Jonathan Cameron, Hartmut Knaack, Lars-Peter Clausen,
Peter Meerwald, Martin Fuzzey, devicetree, linux-kernel,
linux-iio, Martin Kepplinger
On Thu, Oct 15, 2015 at 8:10 AM, Martin Kepplinger <martink@posteo.de> wrote:
> This change is important in order for everyone to be easily able to use the
> driver for one of the supported accelerometer chips!
>
> Until now, the driver blindly assumed that the INT1 interrupt line is wired
> on a user's board. But these devices have 2 interrupt lines and can route
> their interrupt sources to one of them. Now, if "INT2" is found and matches
> i2c_client->irq, INT2 will be used.
>
> The chip's default actually is INT2, which is why probably many boards will
> have it wired and can make use of this.
>
> Of course, this also falls back to assuming INT1, so for existing users
> nothing will break. The new functionality is described in the bindings doc.
>
> Signed-off-by: Martin Kepplinger <martin.kepplinger@theobroma-systems.com>
> ---
> changelog:
> v4: use irq that matches client->irq, backwards compatible
> v3: correctly assign irq if both pins are described in DT
> v2: don't warn but normally handle if both pins are described in dts
> thanks Mark Rutland
> v1: initial post
>
> .../devicetree/bindings/iio/accel/mma8452.txt | 6 ++++++
For the binding:
Rob Herring <robh@kernel.org>
> drivers/iio/accel/mma8452.c | 21 +++++++++++++++------
> 2 files changed, 21 insertions(+), 6 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/iio/accel/mma8452.txt b/Documentation/devicetree/bindings/iio/accel/mma8452.txt
> index e3c3746..3c10e85 100644
> --- a/Documentation/devicetree/bindings/iio/accel/mma8452.txt
> +++ b/Documentation/devicetree/bindings/iio/accel/mma8452.txt
> @@ -7,13 +7,18 @@ Required properties:
> * "fsl,mma8453"
> * "fsl,mma8652"
> * "fsl,mma8653"
> +
> - reg: the I2C address of the chip
>
> Optional properties:
>
> - interrupt-parent: should be the phandle for the interrupt controller
> +
> - interrupts: interrupt mapping for GPIO IRQ
>
> + - interrupt-names: should contain "INT1" and/or "INT2", the accelerometer's
> + interrupt line in use.
> +
> Example:
>
> mma8453fc@1d {
> @@ -21,4 +26,5 @@ Example:
> reg = <0x1d>;
> interrupt-parent = <&gpio1>;
> interrupts = <5 0>;
> + interrupt-names = "INT2";
> };
> diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c
> index 1eccc2d..116a6e4 100644
> --- a/drivers/iio/accel/mma8452.c
> +++ b/drivers/iio/accel/mma8452.c
> @@ -29,6 +29,7 @@
> #include <linux/iio/events.h>
> #include <linux/delay.h>
> #include <linux/of_device.h>
> +#include <linux/of_irq.h>
>
> #define MMA8452_STATUS 0x00
> #define MMA8452_STATUS_DRDY (BIT(2) | BIT(1) | BIT(0))
> @@ -1130,13 +1131,21 @@ static int mma8452_probe(struct i2c_client *client,
> MMA8452_INT_FF_MT;
> int enabled_interrupts = MMA8452_INT_TRANS |
> MMA8452_INT_FF_MT;
> + int irq2;
>
> - /* Assume wired to INT1 pin */
> - ret = i2c_smbus_write_byte_data(client,
> - MMA8452_CTRL_REG5,
> - supported_interrupts);
> - if (ret < 0)
> - return ret;
> + irq2 = of_irq_get_byname(client->dev.of_node, "INT2");
> +
> + if (irq2 == client->irq) {
> + dev_dbg(&client->dev, "using interrupt line INT2\n");
> + } else {
> + ret = i2c_smbus_write_byte_data(client,
> + MMA8452_CTRL_REG5,
> + supported_interrupts);
> + if (ret < 0)
> + return ret;
> +
> + dev_dbg(&client->dev, "using interrupt line INT1\n");
> + }
>
> ret = i2c_smbus_write_byte_data(client,
> MMA8452_CTRL_REG4,
> --
> 2.1.4
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v4] iio: mma8452: support either of the available interrupt pins
@ 2015-10-22 18:22 ` Rob Herring
0 siblings, 0 replies; 10+ messages in thread
From: Rob Herring @ 2015-10-22 18:22 UTC (permalink / raw)
To: Martin Kepplinger
Cc: Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala,
Jonathan Cameron, Hartmut Knaack, Lars-Peter Clausen,
Peter Meerwald, Martin Fuzzey, devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-iio-u79uwXL29TY76Z2rM5mHXA, Martin Kepplinger
On Thu, Oct 15, 2015 at 8:10 AM, Martin Kepplinger <martink-1KBjaw7Xf1+zQB+pC5nmwQ@public.gmane.org> wrote:
> This change is important in order for everyone to be easily able to use the
> driver for one of the supported accelerometer chips!
>
> Until now, the driver blindly assumed that the INT1 interrupt line is wired
> on a user's board. But these devices have 2 interrupt lines and can route
> their interrupt sources to one of them. Now, if "INT2" is found and matches
> i2c_client->irq, INT2 will be used.
>
> The chip's default actually is INT2, which is why probably many boards will
> have it wired and can make use of this.
>
> Of course, this also falls back to assuming INT1, so for existing users
> nothing will break. The new functionality is described in the bindings doc.
>
> Signed-off-by: Martin Kepplinger <martin.kepplinger-SN7IsUiht6C/RdPyistoZJqQE7yCjDx5@public.gmane.org>
> ---
> changelog:
> v4: use irq that matches client->irq, backwards compatible
> v3: correctly assign irq if both pins are described in DT
> v2: don't warn but normally handle if both pins are described in dts
> thanks Mark Rutland
> v1: initial post
>
> .../devicetree/bindings/iio/accel/mma8452.txt | 6 ++++++
For the binding:
Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> drivers/iio/accel/mma8452.c | 21 +++++++++++++++------
> 2 files changed, 21 insertions(+), 6 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/iio/accel/mma8452.txt b/Documentation/devicetree/bindings/iio/accel/mma8452.txt
> index e3c3746..3c10e85 100644
> --- a/Documentation/devicetree/bindings/iio/accel/mma8452.txt
> +++ b/Documentation/devicetree/bindings/iio/accel/mma8452.txt
> @@ -7,13 +7,18 @@ Required properties:
> * "fsl,mma8453"
> * "fsl,mma8652"
> * "fsl,mma8653"
> +
> - reg: the I2C address of the chip
>
> Optional properties:
>
> - interrupt-parent: should be the phandle for the interrupt controller
> +
> - interrupts: interrupt mapping for GPIO IRQ
>
> + - interrupt-names: should contain "INT1" and/or "INT2", the accelerometer's
> + interrupt line in use.
> +
> Example:
>
> mma8453fc@1d {
> @@ -21,4 +26,5 @@ Example:
> reg = <0x1d>;
> interrupt-parent = <&gpio1>;
> interrupts = <5 0>;
> + interrupt-names = "INT2";
> };
> diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c
> index 1eccc2d..116a6e4 100644
> --- a/drivers/iio/accel/mma8452.c
> +++ b/drivers/iio/accel/mma8452.c
> @@ -29,6 +29,7 @@
> #include <linux/iio/events.h>
> #include <linux/delay.h>
> #include <linux/of_device.h>
> +#include <linux/of_irq.h>
>
> #define MMA8452_STATUS 0x00
> #define MMA8452_STATUS_DRDY (BIT(2) | BIT(1) | BIT(0))
> @@ -1130,13 +1131,21 @@ static int mma8452_probe(struct i2c_client *client,
> MMA8452_INT_FF_MT;
> int enabled_interrupts = MMA8452_INT_TRANS |
> MMA8452_INT_FF_MT;
> + int irq2;
>
> - /* Assume wired to INT1 pin */
> - ret = i2c_smbus_write_byte_data(client,
> - MMA8452_CTRL_REG5,
> - supported_interrupts);
> - if (ret < 0)
> - return ret;
> + irq2 = of_irq_get_byname(client->dev.of_node, "INT2");
> +
> + if (irq2 == client->irq) {
> + dev_dbg(&client->dev, "using interrupt line INT2\n");
> + } else {
> + ret = i2c_smbus_write_byte_data(client,
> + MMA8452_CTRL_REG5,
> + supported_interrupts);
> + if (ret < 0)
> + return ret;
> +
> + dev_dbg(&client->dev, "using interrupt line INT1\n");
> + }
>
> ret = i2c_smbus_write_byte_data(client,
> MMA8452_CTRL_REG4,
> --
> 2.1.4
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v4] iio: mma8452: support either of the available interrupt pins
@ 2015-10-25 11:05 ` Jonathan Cameron
0 siblings, 0 replies; 10+ messages in thread
From: Jonathan Cameron @ 2015-10-25 11:05 UTC (permalink / raw)
To: Rob Herring, Martin Kepplinger
Cc: Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala,
Hartmut Knaack, Lars-Peter Clausen, Peter Meerwald,
Martin Fuzzey, devicetree, linux-kernel, linux-iio,
Martin Kepplinger
On 22/10/15 19:22, Rob Herring wrote:
> On Thu, Oct 15, 2015 at 8:10 AM, Martin Kepplinger <martink@posteo.de> wrote:
>> This change is important in order for everyone to be easily able to use the
>> driver for one of the supported accelerometer chips!
>>
>> Until now, the driver blindly assumed that the INT1 interrupt line is wired
>> on a user's board. But these devices have 2 interrupt lines and can route
>> their interrupt sources to one of them. Now, if "INT2" is found and matches
>> i2c_client->irq, INT2 will be used.
>>
>> The chip's default actually is INT2, which is why probably many boards will
>> have it wired and can make use of this.
>>
>> Of course, this also falls back to assuming INT1, so for existing users
>> nothing will break. The new functionality is described in the bindings doc.
>>
>> Signed-off-by: Martin Kepplinger <martin.kepplinger@theobroma-systems.com>
>> ---
>> changelog:
>> v4: use irq that matches client->irq, backwards compatible
>> v3: correctly assign irq if both pins are described in DT
>> v2: don't warn but normally handle if both pins are described in dts
>> thanks Mark Rutland
>> v1: initial post
>>
>> .../devicetree/bindings/iio/accel/mma8452.txt | 6 ++++++
>
> For the binding:
>
> Rob Herring <robh@kernel.org>
I've guessed that was an Acked-by :)
Anyhow, applied to the togreg branch of iio.git.
I'm afraid after my hiatus for a couple of weeks (day job work crisis now
over) this has missed going in for the current cycle.
IIO merge closes more than a week before the merge window opens and Linus
just announced probably release a week today.
Sorry about that, will be queued up for an early entry into linux next
after the merge window closes.
Jonathan
>
>> drivers/iio/accel/mma8452.c | 21 +++++++++++++++------
>> 2 files changed, 21 insertions(+), 6 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/iio/accel/mma8452.txt b/Documentation/devicetree/bindings/iio/accel/mma8452.txt
>> index e3c3746..3c10e85 100644
>> --- a/Documentation/devicetree/bindings/iio/accel/mma8452.txt
>> +++ b/Documentation/devicetree/bindings/iio/accel/mma8452.txt
>> @@ -7,13 +7,18 @@ Required properties:
>> * "fsl,mma8453"
>> * "fsl,mma8652"
>> * "fsl,mma8653"
>> +
>> - reg: the I2C address of the chip
>>
>> Optional properties:
>>
>> - interrupt-parent: should be the phandle for the interrupt controller
>> +
>> - interrupts: interrupt mapping for GPIO IRQ
>>
>> + - interrupt-names: should contain "INT1" and/or "INT2", the accelerometer's
>> + interrupt line in use.
>> +
>> Example:
>>
>> mma8453fc@1d {
>> @@ -21,4 +26,5 @@ Example:
>> reg = <0x1d>;
>> interrupt-parent = <&gpio1>;
>> interrupts = <5 0>;
>> + interrupt-names = "INT2";
>> };
>> diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c
>> index 1eccc2d..116a6e4 100644
>> --- a/drivers/iio/accel/mma8452.c
>> +++ b/drivers/iio/accel/mma8452.c
>> @@ -29,6 +29,7 @@
>> #include <linux/iio/events.h>
>> #include <linux/delay.h>
>> #include <linux/of_device.h>
>> +#include <linux/of_irq.h>
>>
>> #define MMA8452_STATUS 0x00
>> #define MMA8452_STATUS_DRDY (BIT(2) | BIT(1) | BIT(0))
>> @@ -1130,13 +1131,21 @@ static int mma8452_probe(struct i2c_client *client,
>> MMA8452_INT_FF_MT;
>> int enabled_interrupts = MMA8452_INT_TRANS |
>> MMA8452_INT_FF_MT;
>> + int irq2;
>>
>> - /* Assume wired to INT1 pin */
>> - ret = i2c_smbus_write_byte_data(client,
>> - MMA8452_CTRL_REG5,
>> - supported_interrupts);
>> - if (ret < 0)
>> - return ret;
>> + irq2 = of_irq_get_byname(client->dev.of_node, "INT2");
>> +
>> + if (irq2 == client->irq) {
>> + dev_dbg(&client->dev, "using interrupt line INT2\n");
>> + } else {
>> + ret = i2c_smbus_write_byte_data(client,
>> + MMA8452_CTRL_REG5,
>> + supported_interrupts);
>> + if (ret < 0)
>> + return ret;
>> +
>> + dev_dbg(&client->dev, "using interrupt line INT1\n");
>> + }
>>
>> ret = i2c_smbus_write_byte_data(client,
>> MMA8452_CTRL_REG4,
>> --
>> 2.1.4
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v4] iio: mma8452: support either of the available interrupt pins
@ 2015-10-25 11:05 ` Jonathan Cameron
0 siblings, 0 replies; 10+ messages in thread
From: Jonathan Cameron @ 2015-10-25 11:05 UTC (permalink / raw)
To: Rob Herring, Martin Kepplinger
Cc: Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala,
Hartmut Knaack, Lars-Peter Clausen, Peter Meerwald,
Martin Fuzzey, devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-iio-u79uwXL29TY76Z2rM5mHXA, Martin Kepplinger
On 22/10/15 19:22, Rob Herring wrote:
> On Thu, Oct 15, 2015 at 8:10 AM, Martin Kepplinger <martink-1KBjaw7Xf1+zQB+pC5nmwQ@public.gmane.org> wrote:
>> This change is important in order for everyone to be easily able to use the
>> driver for one of the supported accelerometer chips!
>>
>> Until now, the driver blindly assumed that the INT1 interrupt line is wired
>> on a user's board. But these devices have 2 interrupt lines and can route
>> their interrupt sources to one of them. Now, if "INT2" is found and matches
>> i2c_client->irq, INT2 will be used.
>>
>> The chip's default actually is INT2, which is why probably many boards will
>> have it wired and can make use of this.
>>
>> Of course, this also falls back to assuming INT1, so for existing users
>> nothing will break. The new functionality is described in the bindings doc.
>>
>> Signed-off-by: Martin Kepplinger <martin.kepplinger-SN7IsUiht6C/RdPyistoZJqQE7yCjDx5@public.gmane.org>
>> ---
>> changelog:
>> v4: use irq that matches client->irq, backwards compatible
>> v3: correctly assign irq if both pins are described in DT
>> v2: don't warn but normally handle if both pins are described in dts
>> thanks Mark Rutland
>> v1: initial post
>>
>> .../devicetree/bindings/iio/accel/mma8452.txt | 6 ++++++
>
> For the binding:
>
> Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
I've guessed that was an Acked-by :)
Anyhow, applied to the togreg branch of iio.git.
I'm afraid after my hiatus for a couple of weeks (day job work crisis now
over) this has missed going in for the current cycle.
IIO merge closes more than a week before the merge window opens and Linus
just announced probably release a week today.
Sorry about that, will be queued up for an early entry into linux next
after the merge window closes.
Jonathan
>
>> drivers/iio/accel/mma8452.c | 21 +++++++++++++++------
>> 2 files changed, 21 insertions(+), 6 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/iio/accel/mma8452.txt b/Documentation/devicetree/bindings/iio/accel/mma8452.txt
>> index e3c3746..3c10e85 100644
>> --- a/Documentation/devicetree/bindings/iio/accel/mma8452.txt
>> +++ b/Documentation/devicetree/bindings/iio/accel/mma8452.txt
>> @@ -7,13 +7,18 @@ Required properties:
>> * "fsl,mma8453"
>> * "fsl,mma8652"
>> * "fsl,mma8653"
>> +
>> - reg: the I2C address of the chip
>>
>> Optional properties:
>>
>> - interrupt-parent: should be the phandle for the interrupt controller
>> +
>> - interrupts: interrupt mapping for GPIO IRQ
>>
>> + - interrupt-names: should contain "INT1" and/or "INT2", the accelerometer's
>> + interrupt line in use.
>> +
>> Example:
>>
>> mma8453fc@1d {
>> @@ -21,4 +26,5 @@ Example:
>> reg = <0x1d>;
>> interrupt-parent = <&gpio1>;
>> interrupts = <5 0>;
>> + interrupt-names = "INT2";
>> };
>> diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c
>> index 1eccc2d..116a6e4 100644
>> --- a/drivers/iio/accel/mma8452.c
>> +++ b/drivers/iio/accel/mma8452.c
>> @@ -29,6 +29,7 @@
>> #include <linux/iio/events.h>
>> #include <linux/delay.h>
>> #include <linux/of_device.h>
>> +#include <linux/of_irq.h>
>>
>> #define MMA8452_STATUS 0x00
>> #define MMA8452_STATUS_DRDY (BIT(2) | BIT(1) | BIT(0))
>> @@ -1130,13 +1131,21 @@ static int mma8452_probe(struct i2c_client *client,
>> MMA8452_INT_FF_MT;
>> int enabled_interrupts = MMA8452_INT_TRANS |
>> MMA8452_INT_FF_MT;
>> + int irq2;
>>
>> - /* Assume wired to INT1 pin */
>> - ret = i2c_smbus_write_byte_data(client,
>> - MMA8452_CTRL_REG5,
>> - supported_interrupts);
>> - if (ret < 0)
>> - return ret;
>> + irq2 = of_irq_get_byname(client->dev.of_node, "INT2");
>> +
>> + if (irq2 == client->irq) {
>> + dev_dbg(&client->dev, "using interrupt line INT2\n");
>> + } else {
>> + ret = i2c_smbus_write_byte_data(client,
>> + MMA8452_CTRL_REG5,
>> + supported_interrupts);
>> + if (ret < 0)
>> + return ret;
>> +
>> + dev_dbg(&client->dev, "using interrupt line INT1\n");
>> + }
>>
>> ret = i2c_smbus_write_byte_data(client,
>> MMA8452_CTRL_REG4,
>> --
>> 2.1.4
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v4] iio: mma8452: support either of the available interrupt pins
@ 2015-10-25 13:04 ` Martin Kepplinger
0 siblings, 0 replies; 10+ messages in thread
From: Martin Kepplinger @ 2015-10-25 13:04 UTC (permalink / raw)
To: Jonathan Cameron, Rob Herring, Martin Kepplinger
Cc: Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala,
Hartmut Knaack, Lars-Peter Clausen, Peter Meerwald,
Martin Fuzzey, devicetree, linux-kernel, linux-iio
Am 25. Oktober 2015 12:05:05 MEZ, schrieb Jonathan Cameron <jic23@kernel.org>:
>On 22/10/15 19:22, Rob Herring wrote:
>> On Thu, Oct 15, 2015 at 8:10 AM, Martin Kepplinger
><martink@posteo.de> wrote:
>>> This change is important in order for everyone to be easily able to
>use the
>>> driver for one of the supported accelerometer chips!
>>>
>>> Until now, the driver blindly assumed that the INT1 interrupt line
>is wired
>>> on a user's board. But these devices have 2 interrupt lines and can
>route
>>> their interrupt sources to one of them. Now, if "INT2" is found and
>matches
>>> i2c_client->irq, INT2 will be used.
>>>
>>> The chip's default actually is INT2, which is why probably many
>boards will
>>> have it wired and can make use of this.
>>>
>>> Of course, this also falls back to assuming INT1, so for existing
>users
>>> nothing will break. The new functionality is described in the
>bindings doc.
>>>
>>> Signed-off-by: Martin Kepplinger
><martin.kepplinger@theobroma-systems.com>
>>> ---
>>> changelog:
>>> v4: use irq that matches client->irq, backwards compatible
>>> v3: correctly assign irq if both pins are described in DT
>>> v2: don't warn but normally handle if both pins are described in dts
>>> thanks Mark Rutland
>>> v1: initial post
>>>
>>> .../devicetree/bindings/iio/accel/mma8452.txt | 6 ++++++
>>
>> For the binding:
>>
>> Rob Herring <robh@kernel.org>
>I've guessed that was an Acked-by :)
>
>Anyhow, applied to the togreg branch of iio.git.
>
>I'm afraid after my hiatus for a couple of weeks (day job work crisis
>now
>over) this has missed going in for the current cycle.
>
>IIO merge closes more than a week before the merge window opens and
>Linus
>just announced probably release a week today.
>
>Sorry about that, will be queued up for an early entry into linux next
>after the merge window closes.
>
>Jonathan
That's fine. Thanks
>>
>>> drivers/iio/accel/mma8452.c | 21
>+++++++++++++++------
>>> 2 files changed, 21 insertions(+), 6 deletions(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/iio/accel/mma8452.txt
>b/Documentation/devicetree/bindings/iio/accel/mma8452.txt
>>> index e3c3746..3c10e85 100644
>>> --- a/Documentation/devicetree/bindings/iio/accel/mma8452.txt
>>> +++ b/Documentation/devicetree/bindings/iio/accel/mma8452.txt
>>> @@ -7,13 +7,18 @@ Required properties:
>>> * "fsl,mma8453"
>>> * "fsl,mma8652"
>>> * "fsl,mma8653"
>>> +
>>> - reg: the I2C address of the chip
>>>
>>> Optional properties:
>>>
>>> - interrupt-parent: should be the phandle for the interrupt
>controller
>>> +
>>> - interrupts: interrupt mapping for GPIO IRQ
>>>
>>> + - interrupt-names: should contain "INT1" and/or "INT2", the
>accelerometer's
>>> + interrupt line in use.
>>> +
>>> Example:
>>>
>>> mma8453fc@1d {
>>> @@ -21,4 +26,5 @@ Example:
>>> reg = <0x1d>;
>>> interrupt-parent = <&gpio1>;
>>> interrupts = <5 0>;
>>> + interrupt-names = "INT2";
>>> };
>>> diff --git a/drivers/iio/accel/mma8452.c
>b/drivers/iio/accel/mma8452.c
>>> index 1eccc2d..116a6e4 100644
>>> --- a/drivers/iio/accel/mma8452.c
>>> +++ b/drivers/iio/accel/mma8452.c
>>> @@ -29,6 +29,7 @@
>>> #include <linux/iio/events.h>
>>> #include <linux/delay.h>
>>> #include <linux/of_device.h>
>>> +#include <linux/of_irq.h>
>>>
>>> #define MMA8452_STATUS 0x00
>>> #define MMA8452_STATUS_DRDY (BIT(2) | BIT(1) |
>BIT(0))
>>> @@ -1130,13 +1131,21 @@ static int mma8452_probe(struct i2c_client
>*client,
>>> MMA8452_INT_FF_MT;
>>> int enabled_interrupts = MMA8452_INT_TRANS |
>>> MMA8452_INT_FF_MT;
>>> + int irq2;
>>>
>>> - /* Assume wired to INT1 pin */
>>> - ret = i2c_smbus_write_byte_data(client,
>>> - MMA8452_CTRL_REG5,
>>> -
>supported_interrupts);
>>> - if (ret < 0)
>>> - return ret;
>>> + irq2 = of_irq_get_byname(client->dev.of_node,
>"INT2");
>>> +
>>> + if (irq2 == client->irq) {
>>> + dev_dbg(&client->dev, "using interrupt line
>INT2\n");
>>> + } else {
>>> + ret = i2c_smbus_write_byte_data(client,
>>> +
>MMA8452_CTRL_REG5,
>>> +
>supported_interrupts);
>>> + if (ret < 0)
>>> + return ret;
>>> +
>>> + dev_dbg(&client->dev, "using interrupt line
>INT1\n");
>>> + }
>>>
>>> ret = i2c_smbus_write_byte_data(client,
>>> MMA8452_CTRL_REG4,
>>> --
>>> 2.1.4
>>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-iio"
>in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v4] iio: mma8452: support either of the available interrupt pins
@ 2015-10-25 13:04 ` Martin Kepplinger
0 siblings, 0 replies; 10+ messages in thread
From: Martin Kepplinger @ 2015-10-25 13:04 UTC (permalink / raw)
To: Jonathan Cameron, Rob Herring, Martin Kepplinger
Cc: Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala,
Hartmut Knaack, Lars-Peter Clausen, Peter Meerwald,
Martin Fuzzey, devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-iio-u79uwXL29TY76Z2rM5mHXA
Am 25. Oktober 2015 12:05:05 MEZ, schrieb Jonathan Cameron <jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>:
>On 22/10/15 19:22, Rob Herring wrote:
>> On Thu, Oct 15, 2015 at 8:10 AM, Martin Kepplinger
><martink-1KBjaw7Xf1+zQB+pC5nmwQ@public.gmane.org> wrote:
>>> This change is important in order for everyone to be easily able to
>use the
>>> driver for one of the supported accelerometer chips!
>>>
>>> Until now, the driver blindly assumed that the INT1 interrupt line
>is wired
>>> on a user's board. But these devices have 2 interrupt lines and can
>route
>>> their interrupt sources to one of them. Now, if "INT2" is found and
>matches
>>> i2c_client->irq, INT2 will be used.
>>>
>>> The chip's default actually is INT2, which is why probably many
>boards will
>>> have it wired and can make use of this.
>>>
>>> Of course, this also falls back to assuming INT1, so for existing
>users
>>> nothing will break. The new functionality is described in the
>bindings doc.
>>>
>>> Signed-off-by: Martin Kepplinger
><martin.kepplinger-SN7IsUiht6C/RdPyistoZJqQE7yCjDx5@public.gmane.org>
>>> ---
>>> changelog:
>>> v4: use irq that matches client->irq, backwards compatible
>>> v3: correctly assign irq if both pins are described in DT
>>> v2: don't warn but normally handle if both pins are described in dts
>>> thanks Mark Rutland
>>> v1: initial post
>>>
>>> .../devicetree/bindings/iio/accel/mma8452.txt | 6 ++++++
>>
>> For the binding:
>>
>> Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
>I've guessed that was an Acked-by :)
>
>Anyhow, applied to the togreg branch of iio.git.
>
>I'm afraid after my hiatus for a couple of weeks (day job work crisis
>now
>over) this has missed going in for the current cycle.
>
>IIO merge closes more than a week before the merge window opens and
>Linus
>just announced probably release a week today.
>
>Sorry about that, will be queued up for an early entry into linux next
>after the merge window closes.
>
>Jonathan
That's fine. Thanks
>>
>>> drivers/iio/accel/mma8452.c | 21
>+++++++++++++++------
>>> 2 files changed, 21 insertions(+), 6 deletions(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/iio/accel/mma8452.txt
>b/Documentation/devicetree/bindings/iio/accel/mma8452.txt
>>> index e3c3746..3c10e85 100644
>>> --- a/Documentation/devicetree/bindings/iio/accel/mma8452.txt
>>> +++ b/Documentation/devicetree/bindings/iio/accel/mma8452.txt
>>> @@ -7,13 +7,18 @@ Required properties:
>>> * "fsl,mma8453"
>>> * "fsl,mma8652"
>>> * "fsl,mma8653"
>>> +
>>> - reg: the I2C address of the chip
>>>
>>> Optional properties:
>>>
>>> - interrupt-parent: should be the phandle for the interrupt
>controller
>>> +
>>> - interrupts: interrupt mapping for GPIO IRQ
>>>
>>> + - interrupt-names: should contain "INT1" and/or "INT2", the
>accelerometer's
>>> + interrupt line in use.
>>> +
>>> Example:
>>>
>>> mma8453fc@1d {
>>> @@ -21,4 +26,5 @@ Example:
>>> reg = <0x1d>;
>>> interrupt-parent = <&gpio1>;
>>> interrupts = <5 0>;
>>> + interrupt-names = "INT2";
>>> };
>>> diff --git a/drivers/iio/accel/mma8452.c
>b/drivers/iio/accel/mma8452.c
>>> index 1eccc2d..116a6e4 100644
>>> --- a/drivers/iio/accel/mma8452.c
>>> +++ b/drivers/iio/accel/mma8452.c
>>> @@ -29,6 +29,7 @@
>>> #include <linux/iio/events.h>
>>> #include <linux/delay.h>
>>> #include <linux/of_device.h>
>>> +#include <linux/of_irq.h>
>>>
>>> #define MMA8452_STATUS 0x00
>>> #define MMA8452_STATUS_DRDY (BIT(2) | BIT(1) |
>BIT(0))
>>> @@ -1130,13 +1131,21 @@ static int mma8452_probe(struct i2c_client
>*client,
>>> MMA8452_INT_FF_MT;
>>> int enabled_interrupts = MMA8452_INT_TRANS |
>>> MMA8452_INT_FF_MT;
>>> + int irq2;
>>>
>>> - /* Assume wired to INT1 pin */
>>> - ret = i2c_smbus_write_byte_data(client,
>>> - MMA8452_CTRL_REG5,
>>> -
>supported_interrupts);
>>> - if (ret < 0)
>>> - return ret;
>>> + irq2 = of_irq_get_byname(client->dev.of_node,
>"INT2");
>>> +
>>> + if (irq2 == client->irq) {
>>> + dev_dbg(&client->dev, "using interrupt line
>INT2\n");
>>> + } else {
>>> + ret = i2c_smbus_write_byte_data(client,
>>> +
>MMA8452_CTRL_REG5,
>>> +
>supported_interrupts);
>>> + if (ret < 0)
>>> + return ret;
>>> +
>>> + dev_dbg(&client->dev, "using interrupt line
>INT1\n");
>>> + }
>>>
>>> ret = i2c_smbus_write_byte_data(client,
>>> MMA8452_CTRL_REG4,
>>> --
>>> 2.1.4
>>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-iio"
>in
>> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2015-10-25 13:04 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-10-15 13:10 [PATCH v4] iio: mma8452: support either of the available interrupt pins Martin Kepplinger
2015-10-20 11:03 ` Martin Kepplinger
2015-10-20 11:03 ` Martin Kepplinger
2015-10-22 15:22 ` Martin Kepplinger
2015-10-22 18:22 ` Rob Herring
2015-10-22 18:22 ` Rob Herring
2015-10-25 11:05 ` Jonathan Cameron
2015-10-25 11:05 ` Jonathan Cameron
2015-10-25 13:04 ` Martin Kepplinger
2015-10-25 13:04 ` Martin Kepplinger
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.